Re: [Mesa-dev] [PATCH 1/4] intel/reg: Add helpers for 64-bit integer immediates

2017-11-02 Thread Jason Ekstrand
On Thu, Nov 2, 2017 at 10:12 PM, Michael Schellenberger Costa < mschellenbergerco...@googlemail.com> wrote: > Hi Jason, > > -Ursprüngliche Nachricht- > Von: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] Im Auftrag > von Jason Ekstrand > Gesendet: Freitag, 3. November 2017 05:53

[Mesa-dev] [PATCH 1/4] intel/reg: Add helpers for 64-bit integer immediates

2017-11-02 Thread Jason Ekstrand
--- src/intel/compiler/brw_reg.h | 18 ++ 1 file changed, 18 insertions(+) diff --git a/src/intel/compiler/brw_reg.h b/src/intel/compiler/brw_reg.h index d68d64f..a641869 100644 --- a/src/intel/compiler/brw_reg.h +++ b/src/intel/compiler/brw_reg.h @@ -597,6 +597,24 @@

[Mesa-dev] [PATCH 3/4] intel/fs/nir: Use Q immediates for load_const on gen8+

2017-11-02 Thread Jason Ekstrand
On gen7, the only 64-bit type we have is DF so we have to use that but on gen8+, we have Q types so we should use them to avoid any possibility of floating-point weirdness. While we're here, retype destinations so we aren't relying on the destination type. --- src/intel/compiler/brw_fs_nir.cpp |

[Mesa-dev] [PATCH 2/4] intel/fs/nir: Setup immediates based on type in i2b and f2b

2017-11-02 Thread Jason Ekstrand
--- src/intel/compiler/brw_fs_nir.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/intel/compiler/brw_fs_nir.cpp b/src/intel/compiler/brw_fs_nir.cpp index bb153ca..b92f158 100644 --- a/src/intel/compiler/brw_fs_nir.cpp +++ b/src/intel/compiler/brw_fs_nir.cpp @@

[Mesa-dev] [PATCH 4/4] intel/fs/nir: Return Q types from brw_reg_type_for_bit_size

2017-11-02 Thread Jason Ekstrand
Now that we're returning a sane type, we can drop the retyping to Q in nir_emit_load_const. Cc: Jose Maria Casanova Crespo --- src/intel/compiler/brw_fs_nir.cpp | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/intel/compiler/brw_fs_nir.cpp

[Mesa-dev] [PATCH] radv: add initial copy descriptor support.

2017-11-02 Thread Dave Airlie
From: Dave Airlie It appears the latest dota2 vulkan uses this, and we get a hang in VR mode without it. Cc: "17.2 17.3" Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_descriptor_set.c | 61

Re: [Mesa-dev] [PATCH] nir/serialize: fix build with gcc 4.4.7

2017-11-02 Thread Jason Ekstrand
*grumble* old compilers... *grumble* Reviewed-by: Jason Ekstrand On Thu, Nov 2, 2017 at 7:59 PM, Dave Airlie wrote: > From: Dave Airlie > > I had to build on RHEL6 today, and noticed this. > > Signed-off-by: Dave Airlie

[Mesa-dev] [PATCH] nir/serialize: fix build with gcc 4.4.7

2017-11-02 Thread Dave Airlie
From: Dave Airlie I had to build on RHEL6 today, and noticed this. Signed-off-by: Dave Airlie --- src/compiler/nir/nir_serialize.c | 38 +++--- 1 files changed, 19 insertions(+), 19 deletions(-) diff --git

[Mesa-dev] [Bug 100038] [BDW] gpu hangs ecode 8:0:0x84d77c1c

2017-11-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100038 Matt Turner changed: What|Removed |Added QA Contact|mesa-dev@lists.freedesktop.

Re: [Mesa-dev] [PATCH v2 4/4] i965/gen10: Implement Wa3DStateMode

2017-11-02 Thread Matt Turner
On Thu, Nov 2, 2017 at 11:26 AM, Nanley Chery wrote: > On Wed, Nov 01, 2017 at 03:52:15PM -0700, Anuj Phogat wrote: >> V2: Remove the bits enabling Float blend optimization. It is >> enabled through CACHE_MODE_SS register. >> Update the comment. >> >> This

[Mesa-dev] [PATCH v3 1/4] i965/gen10: Implement WaSampleOffsetIZ workaround

2017-11-02 Thread Anuj Phogat
There are few other (duplicate) workarounds which have similar recommendations: WaFlushHangWhenNonPipelineStateAndMarkerStalled WaCSStallBefore3DSamplePattern WaPipeControlBefore3DStateSamplePattern WaPipeControlBefore3DStateSamplePattern has some extra recommendations if driver is using mid

Re: [Mesa-dev] [PATCH v2 1/4] i965/gen10: Implement WaSampleOffsetIZ workaround

2017-11-02 Thread Anuj Phogat
On Thu, Nov 2, 2017 at 10:59 AM, Nanley Chery wrote: > On Wed, Nov 01, 2017 at 03:48:25PM -0700, Anuj Phogat wrote: >> There are few other (duplicate) workarounds which have similar >> recommendations: >> WaFlushHangWhenNonPipelineStateAndMarkerStalled >>

Re: [Mesa-dev] [PATCH v2 2/4] i965/gen10: Implement WaForceRCPFEHangWorkaround

2017-11-02 Thread Anuj Phogat
On Thu, Nov 2, 2017 at 11:18 AM, Nanley Chery wrote: > On Wed, Nov 01, 2017 at 03:49:52PM -0700, Anuj Phogat wrote: >> V2: Add the check for Post Sync Operation. >> Update the workaround comment. >> > > Did you mean to put the V2 hunk after the messsage? > >> This

Re: [Mesa-dev] [PATCH v2 4/4] i965/gen10: Implement Wa3DStateMode

2017-11-02 Thread Anuj Phogat
On Thu, Nov 2, 2017 at 11:26 AM, Nanley Chery wrote: > On Wed, Nov 01, 2017 at 03:52:15PM -0700, Anuj Phogat wrote: >> V2: Remove the bits enabling Float blend optimization. It is >> enabled through CACHE_MODE_SS register. >> Update the comment. >> >> This

[Mesa-dev] [PATCH] mesa: fix deleting the dummy ATI_fs

2017-11-02 Thread Miklós Máté
The DummyShader is used by GenFragmentShadersATI() as a placeholder to mark IDs as allocated. Context cleanup wants to delete everything in ctx->Shared->ATIShaders, and crashes on these placeholders with this backtrace: ==15060== Invalid free() / delete / delete[] / realloc() ==15060==at

[Mesa-dev] [PATCH 4/5] meson: add support for xlib glx

2017-11-02 Thread Dylan Baker
There is a bunch of churn in the main meson.build so that we can correctly set the auto tristate of GLX. In particular, don't build xlib-based glx when dri and gallium are disabled but vulkan is enabled, in that case just turn glx off. Signed-off-by: Dylan Baker ---

[Mesa-dev] [PATCH 3/5] meson: move gl pkgconfig generation out of glx

2017-11-02 Thread Dylan Baker
Because the same generation logic is required by xlib glx and gallium-xlib glx, it makes sense to pull it out. Signed-off-by: Dylan Baker --- src/glx/meson.build | 11 --- src/meson.build | 12 2 files changed, 12 insertions(+), 11 deletions(-)

[Mesa-dev] [PATCH 2/5] meson: move wayland-egl into egl folder

2017-11-02 Thread Dylan Baker
This ensure that it's properly guarded, but also makes the code clearer by grouping related things together.. Signed-off-by: Dylan Baker --- src/egl/meson.build | 4 src/meson.build | 3 --- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git

[Mesa-dev] [PATCH 5/5] meson: build gallium-xlib based glx

2017-11-02 Thread Dylan Baker
Signed-off-by: Dylan Baker --- meson.build | 16 +++--- src/gallium/meson.build | 11 +++- src/gallium/state_trackers/glx/xlib/meson.build | 27 ++ src/gallium/targets/libgl-xlib/meson.build | 68

[Mesa-dev] [PATCH 0/5] meson glx-xlib (classic and gallium)

2017-11-02 Thread Dylan Baker
There's a few cleanups in here, but mostly it's just the logic for building xlib backed glx. Dylan Baker (5): meson: add nir_builder_opcodes_h to gallium_auxiliary meson: move wayland-egl into egl folder meson: move gl pkgconfig generation out of glx meson: add support for xlib glx

[Mesa-dev] [PATCH 1/5] meson: add nir_builder_opcodes_h to gallium_auxiliary

2017-11-02 Thread Dylan Baker
This creates a dependency on this header being generated before trying to compile any of these targets, as well as passing the correct -I to the compiler to ensure it's included correctly. Signed-off-by: Dylan Baker --- src/gallium/auxiliary/meson.build | 2 +- 1 file

Re: [Mesa-dev] [PATCH mesa 1/2] meson: standardize .so version to major.minor.patch

2017-11-02 Thread Dylan Baker
I'm also not sure that it matters, but I think consistency with autotools is important, Reviewed-by: Dylan Baker Quoting Eric Engestrom (2017-11-02 16:42:11) > This `version` field defines the filename for the .so. > The plan .so as well as .so.$major are always symlinks to

[Mesa-dev] [PATCH mesa 2/2] meson: drop GLESv1 .so version back to 1.0.0

2017-11-02 Thread Eric Engestrom
autotools generates libGLESv1_CM.so.1.0.0, so let's make sure meson does the same. Signed-off-by: Eric Engestrom --- src/mapi/es1api/meson.build | 2 +- src/mapi/shared-glapi/meson.build | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH mesa 1/2] meson: standardize .so version to major.minor.patch

2017-11-02 Thread Eric Engestrom
This `version` field defines the filename for the .so. The plan .so as well as .so.$major are always symlinks to this. Unless I'm mistaken, only the major is ever used, so this shouldn't, but for consistency with autotools (and in case it does matter), let's always have all 3 major.minor.patch

Re: [Mesa-dev] [PATCH] mesa: prevent deleting the dummy ATI_fs

2017-11-02 Thread Miklós Máté
On 02/11/17 17:16, Nicolai Hähnle wrote: On 01.11.2017 00:34, Miklós Máté wrote: This fixes a crash upon context destruction when glGenFragmentShadersATI() was used. Backtrace: ==15060== Invalid free() / delete / delete[] / realloc() ==15060==    at 0x482F478: free (vg_replace_malloc.c:530)

[Mesa-dev] [Bug 103543] meson targets which link libgallium.a have unresolved symbol llvm::RTDyldMemoryManager

2017-11-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103543 --- Comment #2 from Dylan Baker --- Also, I noticed you're using meson from git, are you building with upstream master, or do you have additional patches? -- You are receiving this mail because: You are the assignee

[Mesa-dev] [Bug 103543] meson targets which link libgallium.a have unresolved symbol llvm::RTDyldMemoryManager

2017-11-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103543 Dylan Baker changed: What|Removed |Added Status|NEW |NEEDINFO ---

[Mesa-dev] [PATCH] intel/fs: Use a pure vertical stride for large register strides

2017-11-02 Thread Jason Ekstrand
Register strides higher than 4 are uncommon but they can happen. For instance, if you have a 64-bit extract_u8 operation, we turn that into UB -> UQ MOV with a source stride of 8. Our previous calculation would try to generate a stride of <32;8,8>:ub which is invalid because the maximum

Re: [Mesa-dev] [PATCH 05/12] glsl: Combine nop-swizzle optimization with swizzle-swizzle optimization

2017-11-02 Thread Thomas Helland
Changes all look really good, and some performance numbers I have for a similar patch I've written shows a marginal benefit in compiler runtime performance (perf-stat -> cycles executed) For patches 4 and 5. Reviewed-by: 2. nov. 2017 21.26 skrev "Ian Romanick"

[Mesa-dev] [PATCH v4 9/9] egl/wayland: add dri2_wl_free_buffers() helper (v3)

2017-11-02 Thread Gwan-gyeong Mun
This deduplicates free routines of color_buffers array. v2: - Add clear_all argument to check clearing all of color_buffers or not. - Fixes from Eric's review: a) polish check routine of check_lock and color_buffers[i].locked b) move 'native_buffer = NULL' to avoid leaking locked buffers

[Mesa-dev] [PATCH v4 8/9] egl: add dri2_surface_get_front_image() helper (v4)

2017-11-02 Thread Gwan-gyeong Mun
To share common get and create dri_image_front code. In preparation to adding of new platform which uses this helper. v2: - Remove unneeded ifdef magic - Fixes from Eric's review: a) Split out series of refactor for helpers to a separate series. b) Add the new helper function and use

[Mesa-dev] [PATCH v4 7/9] egl: add dri2_surface_free_image() helper (v4)

2017-11-02 Thread Gwan-gyeong Mun
To share common free DRIimage code. In preparation to adding of new platform which uses this helper. v2: - Fixes from Eric's review: a) Split out series of refactor for helpers to a separate series. b) Add the new helper function and use them to replace the old code in the same

[Mesa-dev] [PATCH v4 4/9] egl: add a missed initialization of buffer age.

2017-11-02 Thread Gwan-gyeong Mun
It add an initialization of buffer age on dri2_surface_set_back_buffer(). Fixes from Emil's review - Split out separated patch for adding of missed initialization of buffer age. [1] [1] https://lists.freedesktop.org/archives/mesa-dev/2017-October/173129.html Signed-off-by: Mun Gwan-gyeong

[Mesa-dev] [PATCH v4 5/9] egl: add going out of the loop when color_buffer is set.

2017-11-02 Thread Gwan-gyeong Mun
If color_buffer is set once, we don't need to set a same native buffer to remained free slot of color_buffers. So we can go out of the loop when color_buffer is set first. Fixes from Emil's review - Add setting "updated" and bailing out when the color_buffer is set.[1] [1]

[Mesa-dev] [PATCH v4 6/9] egl: add dri2_surface_update_age() helper (v3)

2017-11-02 Thread Gwan-gyeong Mun
To share common update buffer age code. This updates old buffer's age and sets current back buffer's age to 1. In preparation to adding of new platform which uses this helper. v2: - Fixes from Eric's review: a) Split out series of refactor for helpers to a separate series. b) Add the new

[Mesa-dev] [PATCH v4 2/9] egl: refactor color_buffers structure for deduplicating (v2)

2017-11-02 Thread Gwan-gyeong Mun
From: "Mun, Gwan-gyeong" This is added for preventing adding of new color buffers structure and back* when new platform backend is added. This refactoring separates out the common and platform specific bits. This makes odd casting in the platform_foo.c but it prevents adding

[Mesa-dev] [PATCH v4 3/9] egl: add dri2_surface_set_back_buffer() helper (v3)

2017-11-02 Thread Gwan-gyeong Mun
To share common record buffers and update back buffer code. This records all the buffers created by each platform's native window and update back buffer for updating buffer's age in swap_buffers. In preparation to adding of new platform which uses this helper. v2: - Remove unneeded ifdef magic

[Mesa-dev] [PATCH v4 1/9] egl: add dri2_surface_fixup() helper (v3)

2017-11-02 Thread Gwan-gyeong Mun
From: "Mun, Gwan-gyeong" To share common free outdated buffers and update size code. This compares width and height arguments with current egl surface dimension, if the compared surface dimension is differ, then it free local buffers and updates dimension. In preparation to

Re: [Mesa-dev] [PATCH] mesa/shaderapi: Do a dry run of linking an in-use program

2017-11-02 Thread Timothy Arceri
I think I'd rather see this handled by releasing the uniforms only after the second link is successful and using a temp/fallback pointer to hold it until then. We need to do a similar type of thing with shader source and the shader cache e.g [1]. [1]

[Mesa-dev] [PATCH 10/12] glsl: Minor cleanups after previous commit

2017-11-02 Thread Ian Romanick
From: Ian Romanick I think it's more clear to only call emit_access once. The only difference between the two calls is the value of size_mul used for the offset parameter... but you really have to look at it to be sure. The s/is_64bit/is_double/ change is because

[Mesa-dev] [PATCH 04/12] glsl: Make the swizzle-swizzle optimization greedy

2017-11-02 Thread Ian Romanick
From: Ian Romanick If there is a long sequence of swizzled swizzles, compact all of them down to a single swizzle. Signed-off-by: Ian Romanick --- src/compiler/glsl/opt_swizzle_swizzle.cpp | 59 +++ 1 file

[Mesa-dev] [PATCH 09/12] glsl: Use more link_calculate_matrix_stride in lower_buffer_access

2017-11-02 Thread Ian Romanick
From: Ian Romanick I was going to squash this with the previous commit, but there's a lot of churn in that commit. Signed-off-by: Ian Romanick --- src/compiler/glsl/lower_buffer_access.cpp | 22 ++ 1 file changed, 2

[Mesa-dev] [PATCH 06/12] glsl/linker: Optimize swizzles again after linking

2017-11-02 Thread Ian Romanick
From: Ian Romanick Without this, the SPIR-V generator has to deal with a bunch of junk like: (swiz z (swiz xxx (swiz x (var_ref packed:binormal.z,light_dir It seems better to cull that stuff out than to add code to deal with it. The problem is the way

[Mesa-dev] [PATCH 12/12] spirv: Import the latest 1.0.12 header and JSON from Khronos

2017-11-02 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/compiler/spirv/spirv.core.grammar.json | 266 - src/compiler/spirv/spirv.h | 40 + 2 files changed, 38 insertions(+), 268 deletions(-)

[Mesa-dev] [PATCH 02/12] glsl: Silence unused parameter warning

2017-11-02 Thread Ian Romanick
From: Ian Romanick glsl/lower_shared_reference.cpp: In member function ‘virtual void {anonymous}::lower_shared_reference_visitor::insert_buffer_access(void*, ir_dereference*, const glsl_type*, ir_rvalue*, unsigned int, int)’: glsl/lower_shared_reference.cpp:244:58:

[Mesa-dev] [PATCH 07/12] glsl: Refactor matrix stride calculation into a utility function

2017-11-02 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/compiler/glsl/link_uniforms.cpp | 57 ++--- src/compiler/glsl/linker.h | 4 +++ 2 files changed, 50 insertions(+), 11 deletions(-) diff --git

[Mesa-dev] [PATCH 01/12] i965: Silence "enumeral and non-enumeral type in conditional expression" warnings

2017-11-02 Thread Ian Romanick
From: Ian Romanick compiler/brw_inst.h: In function ‘brw_reg_type brw_inst_dst_type(const gen_device_info*, const brw_inst*)’: compiler/brw_inst.h:801:55: warning: enumeral and non-enumeral type in conditional expression [-Wextra] unsigned file =

[Mesa-dev] [PATCH 03/12] glsl: Remove program_resource_visitor::visit_field(const glsl_struct_field *)

2017-11-02 Thread Ian Romanick
From: Ian Romanick I could not find any remaining users. Signed-off-by: Ian Romanick --- src/compiler/glsl/link_uniforms.cpp | 8 src/compiler/glsl/linker.h | 10 -- 2 files changed, 18 deletions(-) diff --git

[Mesa-dev] [PATCH 05/12] glsl: Combine nop-swizzle optimization with swizzle-swizzle optimization

2017-11-02 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/compiler/Makefile.sources | 3 +- src/compiler/glsl/glsl_parser_extras.cpp | 3 +- src/compiler/glsl/ir_optimization.h| 3 +-

[Mesa-dev] [PATCH 11/12] i965: Don't request GLSL IR lowering of gl_VertexID

2017-11-02 Thread Ian Romanick
From: Ian Romanick Let the lowering in NIR handle it instead. This hurts one shader that occurs twice in shader-db (SynMark GSCloth) on IVB and HSW. No other shaders or platforms were affected. total cycles in shared programs: 253438422 -> 253438426 (0.00%) cycles in

[Mesa-dev] [PATCH 08/12] glsl: Use link_calculate_matrix_stride in lower_buffer_access and friends

2017-11-02 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/compiler/glsl/lower_buffer_access.cpp| 58 +++- src/compiler/glsl/lower_buffer_access.h | 8 ++-- src/compiler/glsl/lower_shared_reference.cpp | 18

Re: [Mesa-dev] [PATCH 2/2] st/glsl_to_nir: delay adding built-in uniforms to Parameters list

2017-11-02 Thread Timothy Arceri
On 03/11/17 03:25, Nicolai Hähnle wrote: On 01.11.2017 06:20, Timothy Arceri wrote: Delaying adding built-in uniforms until after we convert to NIR gives us a better chance to optimise them away. Also NIR allows us to iterate over the uniforms directly so should be faster. ---  

Re: [Mesa-dev] [PATCH 0/9] Implement {GLX_ARB, EGL_KHR}_context_flush_control

2017-11-02 Thread Emil Velikov
On 2 November 2017 at 19:01, Adam Jackson wrote: > Yet another rebase and resend, as I'm getting to the point where I'd > like to be able to use this in xserver. This only enables it for > llvmpipe and i965, it's trivial to enable for other drivers but I > haven't tested any. >

Re: [Mesa-dev] [PATCH 2/9] intel: Don't flush the old context in intelMakeCurrent

2017-11-02 Thread Emil Velikov
[removing Neil's old email as it bounces] On 2 November 2017 at 19:01, Adam Jackson wrote: > From: Neil Roberts > > It shouldn't be necessary to flush the context within the driver > implementation because the old context is explicitly flushed in >

Re: [Mesa-dev] [PATCH 12/13] meson: build gallium va state tracker

2017-11-02 Thread Emil Velikov
On 2 November 2017 at 18:11, Dylan Baker wrote: > Quoting Emil Velikov (2017-11-02 05:59:40) >> On 1 November 2017 at 22:49, Dylan Baker wrote: >> > --- >> > meson.build | 35 +- >> > meson_options.txt

[Mesa-dev] [PATCH 9/9] i965: Enable flush control

2017-11-02 Thread Adam Jackson
From: Neil Roberts Reviewed-by: Adam Jackson Signed-off-by: Neil Roberts --- src/mesa/drivers/dri/i965/brw_context.c | 20 +++- src/mesa/drivers/dri/i965/intel_screen.c | 2 ++ 2 files changed, 21 insertions(+), 1

[Mesa-dev] [PATCH 4/9] dri: Add a flush control extension

2017-11-02 Thread Adam Jackson
From: Neil Roberts This advertises that the driver can accept a new context attribute __DRI_CTX_ATTRIB_RELEASE_BEHAVIOR. Reviewed-by: Adam Jackson Signed-off-by: Neil Roberts --- include/GL/internal/dri_interface.h| 25

[Mesa-dev] [PATCH 8/9] drisw: Enable flush control for llvmpipe and softpipe

2017-11-02 Thread Adam Jackson
Hilariously this is a fairly big win. Neil's multi-context-test improves from ~24 to ~36 fps with llvmpipe on a Core i5-3317U. softpipe also improves, from about 2.25 to 3.09 fps (when it's that slow, you're allowed to be that precise). I'd have added it to swrast classic, but the testcase

[Mesa-dev] [PATCH 3/9] dri: Change __DriverApiRec::CreateContext to take a struct for attribs

2017-11-02 Thread Adam Jackson
From: Neil Roberts Previously the CreateContext method of __DriverApiRec took a set of arguments to describe the attribute values from the window system API's CreateContextAttribs function. As more attributes get added this could quickly get unworkable and every new

[Mesa-dev] [PATCH 7/9] gallium: Wire up flush control

2017-11-02 Thread Adam Jackson
Reviewed-by: Marek Olšák Signed-off-by: Adam Jackson --- src/gallium/include/state_tracker/st_api.h | 1 + src/gallium/state_trackers/dri/dri_context.c | 6 +- src/mesa/state_tracker/st_manager.c | 3 +++ 3 files changed, 9 insertions(+), 1

[Mesa-dev] [PATCH 6/9] egl: Implement EGL_KHR_context_flush_control

2017-11-02 Thread Adam Jackson
Signed-off-by: Adam Jackson --- src/egl/drivers/dri2/egl_dri2.c | 11 ++- src/egl/drivers/dri2/egl_dri2.h | 1 + src/egl/main/eglapi.c | 1 + src/egl/main/eglcontext.c | 10 ++ src/egl/main/eglcontext.h | 1 + src/egl/main/egldisplay.h

[Mesa-dev] [PATCH 1/9] egl/dri2: Factor out context attribute initialization

2017-11-02 Thread Adam Jackson
Signed-off-by: Adam Jackson --- src/egl/drivers/dri2/egl_dri2.c | 35 +-- 1 file changed, 9 insertions(+), 26 deletions(-) diff --git a/src/egl/drivers/dri2/egl_dri2.c b/src/egl/drivers/dri2/egl_dri2.c index 503450542e..57226f60a7 100644 ---

[Mesa-dev] [PATCH 5/9] glx: Implement GLX_ARB_context_flush_control

2017-11-02 Thread Adam Jackson
From: Neil Roberts Reviewed-by: Adam Jackson Signed-off-by: Neil Roberts --- src/glx/dri2_glx.c | 18 -- src/glx/dri3_glx.c | 14 -- src/glx/dri_common.c| 16 +++-

[Mesa-dev] [PATCH 2/9] intel: Don't flush the old context in intelMakeCurrent

2017-11-02 Thread Adam Jackson
From: Neil Roberts It shouldn't be necessary to flush the context within the driver implementation because the old context is explicitly flushed in _mesa_make_current which is called a little further on. It is useful to only have a single place that flushes when switching

[Mesa-dev] [PATCH 0/9] Implement {GLX_ARB, EGL_KHR}_context_flush_control

2017-11-02 Thread Adam Jackson
Yet another rebase and resend, as I'm getting to the point where I'd like to be able to use this in xserver. This only enables it for llvmpipe and i965, it's trivial to enable for other drivers but I haven't tested any. - ajax ___ mesa-dev mailing list

Re: [Mesa-dev] Meson's default build type

2017-11-02 Thread Andres Rodriguez
On 2017-11-02 01:52 PM, Eric Engestrom wrote: On Thursday, 2017-11-02 17:39:53 +, Eric Engestrom wrote: On Thursday, 2017-11-02 09:46:05 -0700, Chad Versace wrote: On Wed 01 Nov 2017, Dylan Baker wrote: Quoting Ilia Mirkin (2017-11-01 16:05:17) On Wed, Nov 1, 2017 at 7:03 PM, Dylan

Re: [Mesa-dev] [PATCH v3] compiler: Mark when input/ouput attribute at VS uses 16-bit (v2)

2017-11-02 Thread Chema Casanova
El 02/11/17 a las 19:25, Jason Ekstrand escribió: > On Thu, Nov 2, 2017 at 11:17 AM, Chema Casanova > wrote: > > > > El 01/11/17 a las 22:07, Jason Ekstrand escribió: > > On Tue, Oct 17, 2017 at 10:05 AM, Jose Maria Casanova Crespo >

[Mesa-dev] [PATCH] mesa/shaderapi: Do a dry run of linking an in-use program

2017-11-02 Thread Neil Roberts
If an in-use program is unsuccessfully linked, the GL spec requires that the executable and the uniform state of the program should remain until a new program is bound. Previously this sort of worked in Mesa except that it would free the uniform state before attempting to link. At least on i965

[Mesa-dev] [Bug 103505] RX 480, newest mesa, VULKAN Does not start

2017-11-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103505 --- Comment #6 from Bas Nieuwenhuizen --- As said in comment #1, can you get a backtrace of the segfault? -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the

Re: [Mesa-dev] [PATCH v2 4/4] i965/gen10: Implement Wa3DStateMode

2017-11-02 Thread Nanley Chery
On Wed, Nov 01, 2017 at 03:52:15PM -0700, Anuj Phogat wrote: > V2: Remove the bits enabling Float blend optimization. It is > enabled through CACHE_MODE_SS register. > Update the comment. > > This workaround doesn't fix any of the piglit hangs we've seen > on CNL. > I haven't seen this

Re: [Mesa-dev] [PATCH v3] compiler: Mark when input/ouput attribute at VS uses 16-bit (v2)

2017-11-02 Thread Jason Ekstrand
On Thu, Nov 2, 2017 at 11:17 AM, Chema Casanova wrote: > > > El 01/11/17 a las 22:07, Jason Ekstrand escribió: > > On Tue, Oct 17, 2017 at 10:05 AM, Jose Maria Casanova Crespo > > > wrote: > > > > New shader

Re: [Mesa-dev] [PATCH v2 2/4] i965/gen10: Implement WaForceRCPFEHangWorkaround

2017-11-02 Thread Nanley Chery
On Wed, Nov 01, 2017 at 03:49:52PM -0700, Anuj Phogat wrote: > V2: Add the check for Post Sync Operation. > Update the workaround comment. > Did you mean to put the V2 hunk after the messsage? > This workaround doesn't fix any of the piglit hangs we've seen > on CNL. But it might be fixing

Re: [Mesa-dev] [PATCH v3] compiler: Mark when input/ouput attribute at VS uses 16-bit (v2)

2017-11-02 Thread Chema Casanova
El 01/11/17 a las 22:07, Jason Ekstrand escribió: > On Tue, Oct 17, 2017 at 10:05 AM, Jose Maria Casanova Crespo > > wrote: > > New shader attribute to mark when a location has 16-bit > value. This patch includes support on mesa glsl

Re: [Mesa-dev] [PATCH 2/3] gbm: Don't traverse backwards for includes

2017-11-02 Thread Dylan Baker
Quoting Emil Velikov (2017-11-02 11:04:44) > On 2 November 2017 at 16:53, Dylan Baker wrote: > > Quoting Emil Velikov (2017-11-02 06:21:09) > >> On 21 October 2017 at 02:00, Dylan Baker wrote: > >> > This is just a terrible idea, but it also needs to be

Re: [Mesa-dev] [PATCH 12/13] meson: build gallium va state tracker

2017-11-02 Thread Dylan Baker
Quoting Emil Velikov (2017-11-02 05:59:40) > On 1 November 2017 at 22:49, Dylan Baker wrote: > > --- > > meson.build | 35 +- > > meson_options.txt | 13 ++ > > src/gallium/meson.build |

Re: [Mesa-dev] Meson's default build type

2017-11-02 Thread Eric Engestrom
On Thursday, 2017-11-02 17:39:53 +, Eric Engestrom wrote: > On Thursday, 2017-11-02 09:46:05 -0700, Chad Versace wrote: > > On Wed 01 Nov 2017, Dylan Baker wrote: > > > Quoting Ilia Mirkin (2017-11-01 16:05:17) > > > > On Wed, Nov 1, 2017 at 7:03 PM, Dylan Baker wrote: >

Re: [Mesa-dev] [PATCH 2/3] gbm: Don't traverse backwards for includes

2017-11-02 Thread Emil Velikov
On 2 November 2017 at 16:53, Dylan Baker wrote: > Quoting Emil Velikov (2017-11-02 06:21:09) >> On 21 October 2017 at 02:00, Dylan Baker wrote: >> > This is just a terrible idea, but it also needs to be fixed for the next >> > patch to work, so let's fix

Re: [Mesa-dev] [PATCH v2 1/4] i965/gen10: Implement WaSampleOffsetIZ workaround

2017-11-02 Thread Nanley Chery
On Wed, Nov 01, 2017 at 03:48:25PM -0700, Anuj Phogat wrote: > There are few other (duplicate) workarounds which have similar > recommendations: > WaFlushHangWhenNonPipelineStateAndMarkerStalled > WaCSStallBefore3DSamplePattern > WaPipeControlBefore3DStateSamplePattern > >

Re: [Mesa-dev] Meson's default build type

2017-11-02 Thread Eric Engestrom
On Thursday, 2017-11-02 09:46:05 -0700, Chad Versace wrote: > On Wed 01 Nov 2017, Dylan Baker wrote: > > Quoting Ilia Mirkin (2017-11-01 16:05:17) > > > On Wed, Nov 1, 2017 at 7:03 PM, Dylan Baker wrote: > > > > Quoting Ilia Mirkin (2017-11-01 15:52:56) > > > >> On Wed, Nov

Re: [Mesa-dev] Meson's default build type

2017-11-02 Thread Dylan Baker
Quoting Matt Turner (2017-11-02 10:06:43) > On Thu, Nov 2, 2017 at 9:51 AM, Michel Dänzer wrote: > > FWIW, my vote is for debugoptimized: Assertions are enabled and there's > > debugging information useful for bug reports, but performance should be > > decent. > > If

[Mesa-dev] [Bug 93866] Tonga: Weston-drm direct scan out corruption

2017-11-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=93866 Michel Dänzer changed: What|Removed |Added Component|DRM/AMDgpu |Mesa core

[Mesa-dev] [PATCH v2] glsl: add varying resources for arrays of complex types

2017-11-02 Thread Juan A. Suarez Romero
This patch is mostly a patch done by Ilia Mirkin. It fixes KHR-GL45.enhanced_layouts.varying_structure_locations. v2: fix locations for TCS/TES/GS inputs and outputs (Ilia) CC: Ilia Mirkin Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103098 Signed-off-by: Juan

Re: [Mesa-dev] [PATCH v3 00/43] anv: SPV_KHR_16bit_storage/VK_KHR_16bit_storage for gen8+

2017-11-02 Thread Chema Casanova
El 02/11/17 a las 01:43, Jason Ekstrand escribió: > I'm done reading for the day.  As you're working on incorporating > feedback, I'd  like you to re-arrange things a bit so that we do > everything required to enable VK_KHR_16bit_storage (including > advertising the Vulkan extension string) for

Re: [Mesa-dev] [PATCH] glsl: add varying resources for arrays of complex types

2017-11-02 Thread Juan A. Suarez Romero
On Fri, 2017-10-27 at 11:09 -0400, Ilia Mirkin wrote: > > > With the latter ones getting bogus locations? What is it supposed to > > > do in this case? > > > > Why it would get bogus locations? > > Because it'll do elem_location += stride every time, but they each > should get the same location.

Re: [Mesa-dev] [PATCH 12/15] ac: add support for SPV_AMD_shader_ballot

2017-11-02 Thread Connor Abbott
On Thu, Nov 2, 2017 at 12:10 PM, Nicolai Hähnle wrote: > On 31.10.2017 16:36, Connor Abbott wrote: >> >> On Tue, Oct 31, 2017 at 2:08 AM, Dave Airlie wrote: +LLVMValueRef +ac_build_subgroup_inclusive_scan(struct ac_llvm_context *ctx, +

Re: [Mesa-dev] [PATCH 10/10] ac: remove the remaining duplicate llvm types

2017-11-02 Thread Marek Olšák
For the series: Reviewed-by: Marek Olšák Marek On Thu, Nov 2, 2017 at 3:41 AM, Timothy Arceri wrote: > --- > src/amd/common/ac_nir_to_llvm.c | 13 + > 1 file changed, 1 insertion(+), 12 deletions(-) > > diff --git

Re: [Mesa-dev] [PATCH 6/6] ac: use the ac i64 llvm type

2017-11-02 Thread Marek Olšák
For the series: Reviewed-by: Marek Olšák Marek On Thu, Nov 2, 2017 at 2:50 AM, Timothy Arceri wrote: > --- > src/amd/common/ac_nir_to_llvm.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/src/amd/common/ac_nir_to_llvm.c

Re: [Mesa-dev] [PATCH 2/3] mesa: enable ARB_texture_buffer_* extensions in the Compatibility profile

2017-11-02 Thread Marek Olšák
One possibility would be to discard each hunk in each patch until you find the problematic one. It might be a bug in i965 that was just uncovered and fixing it might be non-trivial. For example, set_max_gl_versions in i965 doesn't allow creating GL 4.6 contexts directly, but there might be more.

Re: [Mesa-dev] [PATCH 07/13] autotools: set XA versions in configure.ac and configure header file

2017-11-02 Thread Matt Turner
With Emil's suggestions, Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] Meson's default build type

2017-11-02 Thread Matt Turner
On Thu, Nov 2, 2017 at 9:51 AM, Michel Dänzer wrote: > FWIW, my vote is for debugoptimized: Assertions are enabled and there's > debugging information useful for bug reports, but performance should be > decent. If debugoptimized turns on DEBUG, then I don't think performance

Re: [Mesa-dev] [PATCH 42.5/48] nir/builder: Add a nir_imm_intN_t helper

2017-11-02 Thread Lionel Landwerlin
Reviewed-by: Lionel Landwerlin On 31/10/17 23:54, Jason Ekstrand wrote: This lets you easily build integer immediates of arbitrary bit size. --- src/compiler/nir/nir_builder.h | 12 1 file changed, 12 insertions(+) diff --git

Re: [Mesa-dev] [PATCH 2/3] gbm: Don't traverse backwards for includes

2017-11-02 Thread Dylan Baker
Quoting Emil Velikov (2017-11-02 06:21:09) > On 21 October 2017 at 02:00, Dylan Baker wrote: > > This is just a terrible idea, but it also needs to be fixed for the next > > patch to work, so let's fix it right. > > > Please rework the commit message. Perhaps something alike

Re: [Mesa-dev] Meson's default build type

2017-11-02 Thread Michel Dänzer
On 02/11/17 05:46 PM, Chad Versace wrote: > On Wed 01 Nov 2017, Dylan Baker wrote: >> Quoting Ilia Mirkin (2017-11-01 16:05:17) >>> On Wed, Nov 1, 2017 at 7:03 PM, Dylan Baker wrote: Quoting Ilia Mirkin (2017-11-01 15:52:56) > On Wed, Nov 1, 2017 at 6:49 PM, Chad

[Mesa-dev] Meson's default build type

2017-11-02 Thread Chad Versace
On Wed 01 Nov 2017, Dylan Baker wrote: > Quoting Ilia Mirkin (2017-11-01 16:05:17) > > On Wed, Nov 1, 2017 at 7:03 PM, Dylan Baker wrote: > > > Quoting Ilia Mirkin (2017-11-01 15:52:56) > > >> On Wed, Nov 1, 2017 at 6:49 PM, Chad Versace > > >>

Re: [Mesa-dev] [PATCH] mesa: prevent deleting the dummy ATI_fs

2017-11-02 Thread Marek Olšák
Can you rebase and resend the patch? It doesn't apply with "git am". Thanks, Marek On Wed, Nov 1, 2017 at 12:34 AM, Miklós Máté wrote: > This fixes a crash upon context destruction when > glGenFragmentShadersATI() was used. Backtrace: > ==15060== Invalid free() / delete /

Re: [Mesa-dev] [PATCH 2/2] st/glsl_to_nir: use nir_shader_gather_info()

2017-11-02 Thread Nicolai Hähnle
Both patches: Reviewed-by: Nicolai Hähnle On 01.11.2017 12:01, Timothy Arceri wrote: Use the NIR helper rather than the GLSL IR helper to get in/out masks. This allows us to ignore varyings removed by NIR optimisations. --- src/mesa/state_tracker/st_glsl_to_nir.cpp

Re: [Mesa-dev] [PATCH 2/2] st/glsl_to_nir: delay adding built-in uniforms to Parameters list

2017-11-02 Thread Nicolai Hähnle
On 01.11.2017 06:20, Timothy Arceri wrote: Delaying adding built-in uniforms until after we convert to NIR gives us a better chance to optimise them away. Also NIR allows us to iterate over the uniforms directly so should be faster. --- src/mesa/state_tracker/st_glsl_to_nir.cpp | 68

Re: [Mesa-dev] [PATCH 1/2] st/glsl_to_nir: pass gl_shader_program to st_finalize_nir()

2017-11-02 Thread Nicolai Hähnle
This patch: Reviewed-by: Nicolai Hähnle On 01.11.2017 06:20, Timothy Arceri wrote: --- src/mesa/state_tracker/st_glsl_to_nir.cpp | 24 ++-- src/mesa/state_tracker/st_nir.h | 4 +++- src/mesa/state_tracker/st_program.c | 10

Re: [Mesa-dev] [PATCH 2/2] ac/radeonsi: add support for tex instr without a derefence

2017-11-02 Thread Nicolai Hähnle
Both patches: Reviewed-by: Nicolai Hähnle On 01.11.2017 02:43, Timothy Arceri wrote: These are produced by nir_lower_bitmap(), adding the missing derefence would cause other issues that need to be hacked around such as skipping sampler lowering and uniform location

Re: [Mesa-dev] [PATCH 2/2] mesa/st: implement max combined output resources limiting.

2017-11-02 Thread Nicolai Hähnle
Could you already add the change to return a non-zero value from r600 so that *something* is using this cap? Apart from that, both patches are Reviewed-by: Nicolai Hähnle On 01.11.2017 00:58, Dave Airlie wrote: From: Dave Airlie if the driver

  1   2   >