[Mesa-dev] [PATCH] egl: EXT_pixel_format_float plumbing

2017-11-08 Thread Tapani Pälli
Patch adds support and capability to match with new surface attribute, component type. Currently no configs with floating point type are exposed. With this change, following dEQP test starts to pass: dEQP-EGL.functional.choose_config.color_component_type_ext.dont_care

Re: [Mesa-dev] [PATCH] i965: Enable disk shader cache by default

2017-11-08 Thread Jordan Justen
On 2017-11-08 17:26:47, Timothy Arceri wrote: > Reviewed-by: Timothy Arceri > > Mark may want to consider adding some of the once a day type CI runs for > this. For example running the test suite for two consecutive runs on the > same build so that the second run uses

Re: [Mesa-dev] [PATCH v3] glsl/linker: location aliasing requires types to have the same width

2017-11-08 Thread Iago Toral
Hi Ilia, are you okay with this version of the patch? Iago On Tue, 2017-11-07 at 10:50 +0100, Iago Toral Quiroga wrote: > Regarding location aliasing requirements, the OpenGL spec says: > >   "Further, when location aliasing, the aliases sharing the location >    must have the same underlying

[Mesa-dev] [PATCH 11/17] main: Support 1 Mesa format with get for GL_PROGRAM_BINARY_FORMATS

2017-11-08 Thread Jordan Justen
Mesa supports either 0 or 1 formats. If 1 format is supported, it is GL_PROGRAM_BINARY_FORMAT_MESA as defined in the GL_MESA_program_binary_formats extension spec. Signed-off-by: Jordan Justen --- src/mesa/main/get.c | 9 +

[Mesa-dev] [PATCH 14/17] main: Support calling driver for ProgramBinary

2017-11-08 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/mesa/main/dd.h| 4 src/mesa/main/shaderapi.c | 38 +- 2 files changed, 25 insertions(+), 17 deletions(-) diff --git a/src/mesa/main/dd.h b/src/mesa/main/dd.h index

[Mesa-dev] [PATCH 13/17] main: Support calling driver for GetProgramBinary

2017-11-08 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/mesa/main/dd.h| 4 src/mesa/main/shaderapi.c | 17 +++-- 2 files changed, 15 insertions(+), 6 deletions(-) diff --git a/src/mesa/main/dd.h b/src/mesa/main/dd.h index 91eff55f84d..c20d8b80e1d 100644 ---

[Mesa-dev] [PATCH 08/17] i965: Add brw_program_serialize_nir

2017-11-08 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/mesa/drivers/dri/i965/brw_link.cpp | 9 ++--- src/mesa/drivers/dri/i965/brw_program.c | 12 src/mesa/drivers/dri/i965/brw_program.h | 3 +++ 3 files changed, 17 insertions(+), 7 deletions(-) diff --git

[Mesa-dev] [PATCH 10/17] main: Allow non-zero NUM_PROGRAM_BINARY_FORMATS

2017-11-08 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/mesa/main/get_hash_params.py | 2 +- src/mesa/main/mtypes.h | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/get_hash_params.py b/src/mesa/main/get_hash_params.py index

[Mesa-dev] [PATCH 06/17] i965: Add brw_program_deserialize_nir

2017-11-08 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/mesa/drivers/dri/i965/brw_disk_cache.c | 31 -- src/mesa/drivers/dri/i965/brw_program.c| 16 +++ src/mesa/drivers/dri/i965/brw_program.h| 4 3 files changed, 28 insertions(+), 23

[Mesa-dev] [PATCH 03/17] compiler: Fold shader_cache in with libglsl sources

2017-11-08 Thread Jordan Justen
It appears that we include the shader cache sources into libglsl regardless. The Meson build already does this. Signed-off-by: Jordan Justen --- src/compiler/Android.glsl.mk | 3 +-- src/compiler/Makefile.glsl.am | 3 +-- src/compiler/Makefile.sources | 6 ++ 3

[Mesa-dev] [PATCH 04/17] glsl: Split out shader program serialization

2017-11-08 Thread Jordan Justen
This will allow us to use the program serialization to implement ARB_get_program_binary. Signed-off-by: Jordan Justen --- src/compiler/Makefile.sources |2 + src/compiler/glsl/meson.build |2 + src/compiler/glsl/serialize.cpp| 1238

[Mesa-dev] [PATCH 07/17] i965: Free serialized nir after deserializing

2017-11-08 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/mesa/drivers/dri/i965/brw_program.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_program.c b/src/mesa/drivers/dri/i965/brw_program.c index 39308f306df..809766574f8 100644 ---

[Mesa-dev] [PATCH 16/17] util: Add Mesa ARB_get_program_binary helper functions

2017-11-08 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/util/Makefile.sources | 2 + src/util/meson.build | 2 + src/util/program_binary.c | 322 ++ src/util/program_binary.h | 91 + 4 files changed, 417 insertions(+)

[Mesa-dev] [PATCH 09/17] i965: Fix memory leak when serializing nir

2017-11-08 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/mesa/drivers/dri/i965/brw_program.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/drivers/dri/i965/brw_program.c b/src/mesa/drivers/dri/i965/brw_program.c index 798b7d24dd6..f795fc1dbc3 100644 ---

[Mesa-dev] [PATCH 15/17] main: Clear shader program data whenever ProgramBinary is called

2017-11-08 Thread Jordan Justen
The GL_ARB_get_program_binary extension spec says: "If ProgramBinary fails to load a binary, no error is generated, but any information about a previous link or load of that program object is lost." Signed-off-by: Jordan Justen --- src/mesa/main/shaderapi.c | 2

[Mesa-dev] [PATCH 17/17] i965: Add ARB_get_program_binary support using nir_serialization

2017-11-08 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/mesa/drivers/dri/i965/Makefile.sources | 1 + src/mesa/drivers/dri/i965/brw_context.c| 9 ++ src/mesa/drivers/dri/i965/brw_context.h| 16 ++ src/mesa/drivers/dri/i965/brw_program_binary.c | 200

[Mesa-dev] [PATCH 12/17] main: Support calling driver for GL_PROGRAM_BINARY_LENGTH

2017-11-08 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/mesa/main/dd.h| 12 src/mesa/main/shaderapi.c | 8 +++- 2 files changed, 19 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/dd.h b/src/mesa/main/dd.h index da03b2e8b94..91eff55f84d 100644 ---

[Mesa-dev] [PATCH 05/17] main, glsl: Add UniformDataDefaults which stores uniform defaults

2017-11-08 Thread Jordan Justen
The ARB_get_program_binary extension requires that uniform values in a program be restored to their initial value just after linking. This patch saves off the initial values just after linking. When the program is restored by glProgramBinary, we can use this to copy the initial value of uniforms

[Mesa-dev] [PATCH 01/17] docs/specs: Add GL_MESA_program_binary_formats extension spec

2017-11-08 Thread Jordan Justen
Similar idea to Tim's "spec: MESA_program_binary", but simplified and written to support both ARB_get_program_binary and OES_get_program_binary. Signed-off-by: Jordan Justen Cc: Ian Romanick Cc: Timothy Arceri ---

[Mesa-dev] [PATCH 02/17] include/GL: Add GL_MESA_program_binary_formats

2017-11-08 Thread Jordan Justen
Signed-off-by: Jordan Justen --- include/GL/gl.h | 8 1 file changed, 8 insertions(+) diff --git a/include/GL/gl.h b/include/GL/gl.h index 5b284802885..6ae8088f6cb 100644 --- a/include/GL/gl.h +++ b/include/GL/gl.h @@ -2101,6 +2101,14 @@ typedef void

[Mesa-dev] [PATCH 00/17] i965 ARB_get_program_binary support

2017-11-08 Thread Jordan Justen
git://people.freedesktop.org/~jljusten/mesa i965-get-program-binary-v1 This series adds i965 support for ARB_get_program_binary with greater than 0 supported formats. Today we support this extension, but advertise support for 0 formats. This series allows i965 to advertise support for 1 format.

Re: [Mesa-dev] [PATCH] mesa: replace GLenum with GLenum16 in common structures

2017-11-08 Thread Brian Paul
On 11/08/2017 08:16 PM, Marek Olšák wrote: From: Marek Olšák For lower CPU cache usage. All enums fit within 2 bytes. gl_context = 152400 -> 136824 bytes Wow. vbo_context = 22696 -> 21520 bytes --- src/mesa/drivers/dri/nouveau/nv04_state_frag.c | 4 +-

[Mesa-dev] [PATCH] r600/query: drop rest of vi workaround code.

2017-11-08 Thread Dave Airlie
From: Dave Airlie This isn't needed in r600 anymore. Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/r600_query.c | 46 ++- src/gallium/drivers/r600/r600_query.h | 4 --- 2 files changed, 13 insertions(+), 37

[Mesa-dev] [PATCH v4] i965 : optimized bucket index calculation

2017-11-08 Thread aravindan . muthukumar
From: Aravindan Muthukumar Reducing Bucket index calculation to O(1). This algorithm calculates the index using matrix method. Matrix arrangement is as below: Assuming PAGE_SIZE is 4096. 1*4096 2*40963*40964*4096 5*4096 6*4096

Re: [Mesa-dev] [PATCH 7/9] st/mesa: add support for hw atomics to glsl->tgsi. (v4)

2017-11-08 Thread Dave Airlie
On 9 November 2017 at 11:54, Dave Airlie wrote: > From: Dave Airlie > > This adds support for creating the hw atomic tgsi from > the glsl codepaths. > > v2: drop the atomic index and move to backend. > v3: drop buffer decls. (Marek) > v4: fix off by one

Re: [Mesa-dev] [PATCH v3] i965 : optimized bucket index calculation

2017-11-08 Thread Muthukumar, Aravindan
> On 11/06/2017 08:30 PM, aravindan.muthuku...@intel.com wrote: > > From: Aravindan Muthukumar > > > > Now the complexity has been reduced to O(1) > > > > Algorithm calculates the index using matrix method. > > Matrix arrangement is as below: > > Assuming PAGE_SIZE

Re: [Mesa-dev] [PATCH 3/4] glsl: s/unsigned/glsl_base_type/ in glsl type code (v2)

2017-11-08 Thread Brian Paul
On 11/08/2017 08:12 PM, Brian Paul wrote: On 11/08/2017 06:28 PM, Ian Romanick wrote: Any thoughts about my data using __attribute__((__packed__))? Sorry, I didn't have time to dig into it. I took a look this evening. I think the ENUM_8BIT idea will work for GCC and MSVC but only for C++

[Mesa-dev] [PATCH 7/6] radeonsi: don't call r600_can_dma_copy_buffer for DISCARD_RANGE

2017-11-08 Thread Marek Olšák
From: Marek Olšák we don't use dma_data in this codepath. --- src/gallium/drivers/radeon/r600_buffer_common.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/gallium/drivers/radeon/r600_buffer_common.c

[Mesa-dev] [PATCH 6/6] radeonsi: remove has_cp_dma, has_streamout flags

2017-11-08 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeon/r600_buffer_common.c | 5 + src/gallium/drivers/radeon/r600_pipe_common.h | 2 -- src/gallium/drivers/radeonsi/si_pipe.c | 3 --- 3 files changed, 1 insertion(+), 9 deletions(-) diff --git

[Mesa-dev] [PATCH 5/6] radeonsi: pack r600_surface better

2017-11-08 Thread Marek Olšák
From: Marek Olšák 160 -> 136 bytes --- src/gallium/drivers/radeon/r600_pipe_common.h | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/src/gallium/drivers/radeon/r600_pipe_common.h b/src/gallium/drivers/radeon/r600_pipe_common.h

[Mesa-dev] [PATCH 4/6] radeonsi: pack r600_texture better

2017-11-08 Thread Marek Olšák
From: Marek Olšák 1752 -> 1736 bytes --- src/gallium/drivers/radeon/r600_pipe_common.h | 53 +-- 1 file changed, 26 insertions(+), 27 deletions(-) diff --git a/src/gallium/drivers/radeon/r600_pipe_common.h

[Mesa-dev] [PATCH] mesa: replace GLenum with GLenum16 in common structures

2017-11-08 Thread Marek Olšák
From: Marek Olšák For lower CPU cache usage. All enums fit within 2 bytes. gl_context = 152400 -> 136824 bytes vbo_context = 22696 -> 21520 bytes --- src/mesa/drivers/dri/nouveau/nv04_state_frag.c | 4 +- src/mesa/drivers/dri/nouveau/nv10_state_frag.c | 4 +-

[Mesa-dev] [PATCH 3/6] radeonsi: clean up r600_surface

2017-11-08 Thread Marek Olšák
From: Marek Olšák 216 -> 160 bytes --- src/gallium/drivers/radeon/r600_pipe_common.h | 37 --- src/gallium/drivers/radeon/r600_texture.c | 3 --- 2 files changed, 11 insertions(+), 29 deletions(-) diff --git

[Mesa-dev] [PATCH 1/6] radeonsi: remove DBG_NO_DISCARD_RANGE

2017-11-08 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeon/r600_buffer_common.c | 2 -- src/gallium/drivers/radeon/r600_pipe_common.c | 2 -- src/gallium/drivers/radeon/r600_pipe_common.h | 1 - 3 files changed, 5 deletions(-) diff --git

[Mesa-dev] [PATCH 2/6] radeonsi: remove r600_texture::non_disp_tiling

2017-11-08 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeon/r600_pipe_common.h | 2 -- src/gallium/drivers/radeon/r600_texture.c | 7 --- 2 files changed, 9 deletions(-) diff --git a/src/gallium/drivers/radeon/r600_pipe_common.h

[Mesa-dev] [Bug 103586] OpenCL/Clover: AMD Turks: corrupt output buffer (depending on dimension order?)

2017-11-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103586 --- Comment #10 from Dave Gilbert --- I believe I'm still seeing this: dg@hath:~/ocl2$ clinfo Number of platforms 1 Platform Name Clover Platform

Re: [Mesa-dev] [PATCH 3/4] glsl: s/unsigned/glsl_base_type/ in glsl type code (v2)

2017-11-08 Thread Brian Paul
On 11/08/2017 06:28 PM, Ian Romanick wrote: Any thoughts about my data using __attribute__((__packed__))? Sorry, I didn't have time to dig into it. I took a look this evening. I think the ENUM_8BIT idea will work for GCC and MSVC but only for C++ sources. MSVC doesn't like the sized enum

Re: [Mesa-dev] [PATCH 2/4] r600: use mysterious DX10_CLAMP bit in pixel shader setup

2017-11-08 Thread Roland Scheidegger
FWIW I'd really appreciate it if someone could shed some light on that mystery bit there... Roland Am 09.11.2017 um 03:58 schrieb srol...@vmware.com: > From: Roland Scheidegger > > I don't know what this bit really does. The docs are somewhere between > misleading and wrong

Re: [Mesa-dev] [PATCH 2/2] r600: use the clamped versions of rcp/rsq for eg/cayman.

2017-11-08 Thread Roland Scheidegger
All on Juniper. But anyway, I've got another solution, with the only drawback that I don't really know what it does due to docs being lackluster/misleading there :-). But that would let us keep the ieee opcodes. And while I don't know what it does, I suspect it's a better idea regardless ;-). hw

Re: [Mesa-dev] [PATCH 2/2] r600: use the clamped versions of rcp/rsq for eg/cayman.

2017-11-08 Thread Roland Scheidegger
Am 08.11.2017 um 07:18 schrieb Ilia Mirkin: > tgsi_rsq appears to ignore the passed-in op and always puts in > ALU_OP1_RECIPSQRT_CLAMPED anyways. It also sticks an absolute value on > the RSQ() argument. This only happens for eg, not cayman. (Probably > why only the rcp_clamped change appeared to

[Mesa-dev] [PATCH 1/4] r600: use min_dx10/max_dx10 instead of min/max

2017-11-08 Thread sroland
From: Roland Scheidegger I believe this is the safe thing to do, especially ever since the driver actually generates NaNs for muls too. Albeit since the radeon ISA docs are inaccurate/wrong there, I'm not entirely sure what the non-dx10 versions do, but (as required by dx10)

[Mesa-dev] [PATCH 4/4] r600: set the number type correctly for float rts in cb setup

2017-11-08 Thread sroland
From: Roland Scheidegger Float rts were always set as unorm instead of float. Not sure of the consequences, but at least it looks like the blend clamp would have been enabled, which is against the rules (only eg really bothered to even attempt to specify this correctly, r600

[Mesa-dev] [PATCH 2/4] r600: use mysterious DX10_CLAMP bit in pixel shader setup

2017-11-08 Thread sroland
From: Roland Scheidegger I don't know what this bit really does. The docs are somewhere between misleading and wrong however, as at least the newer ones (that bit exists with GCN as well) imply all NaNs would get converted to zeros, which is definitely NOT the case (and that

[Mesa-dev] [PATCH 3/4] r600: use ieee version of rcp

2017-11-08 Thread sroland
From: Roland Scheidegger r600 used the clamped version for rcp, whereas both evergreen and cayman used the ieee version. I don't know why that discrepancy exists (it does so since day 1) but there does not seem to be a valid reason for this, so make it consistent. This seems

Re: [Mesa-dev] [PATCH 2/9] gallium/tgsi: start adding hw atomics (v3.1)

2017-11-08 Thread Ilia Mirkin
Just some naming trivia, not a proper review: On Wed, Nov 8, 2017 at 8:54 PM, Dave Airlie wrote: > From: Dave Airlie > > This adds support for a hw atomic counters to TGSI. > > A new register file for storing atomic counters is added, > along with a new

[Mesa-dev] [PATCH 5/9] st/mesa: start adding support for hw atomics atom. (v2)

2017-11-08 Thread Dave Airlie
From: Dave Airlie This adds a new atom that calls the new driver API to bind buffers containing hw atomics. v2: fixup bindings for sparse buffers. (mareko/nha) don't bind buffer atomics when hw atomics are enabled. use NewAtomicBuffer (mareko) Signed-off-by: Dave Airlie

[Mesa-dev] [PATCH 8/9] r600: add support for hw atomic counters. (v3)

2017-11-08 Thread Dave Airlie
From: Dave Airlie This adds support for the evergreen/cayman atomic counters. These are implemented using GDS append/consume counters. The values for each counter are loaded before drawing and saved after each draw using special CP packets. v2: move hw atomic assignment

[Mesa-dev] [PATCH 9/9] docs: update r600 atomic counter status.

2017-11-08 Thread Dave Airlie
From: Dave Airlie Signed-off-by: Dave Airlie --- docs/features.txt | 6 +++--- docs/relnotes/17.4.0.html | 1 + 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/docs/features.txt b/docs/features.txt index 10ccf9d..86d07ba 100644 ---

[Mesa-dev] [PATCH 6/9] st/mesa: setup hw atomic limits. (v1.1)

2017-11-08 Thread Dave Airlie
From: Dave Airlie HW atomics need to use caps to set some limits, and some other limits may also need limiting. This fixes things up to work for evergreen hw, it may need more changes in the future if other hw wants to use this path. v1.1: fix indent. Reviewed-by: Nicolai

[Mesa-dev] [PATCH 3/9] gallium: add hw atomic buffer binding API.

2017-11-08 Thread Dave Airlie
From: Dave Airlie This API binds atomic buffers for all bound shaders (as per the GL semantics). This is needed to support cross shader hw atomic counters. Reviewed-by: Nicolai Hähnle Reviewed-by: Marek Olšák Signed-off-by:

[Mesa-dev] [PATCH 7/9] st/mesa: add support for hw atomics to glsl->tgsi. (v4)

2017-11-08 Thread Dave Airlie
From: Dave Airlie This adds support for creating the hw atomic tgsi from the glsl codepaths. v2: drop the atomic index and move to backend. v3: drop buffer decls. (Marek) v4: fix off by one (Gert) Reviewed-by: Nicolai Hähnle Reviewed-by: Marek

[Mesa-dev] [PATCH 2/9] gallium/tgsi: start adding hw atomics (v3.1)

2017-11-08 Thread Dave Airlie
From: Dave Airlie This adds support for a hw atomic counters to TGSI. A new register file for storing atomic counters is added, along with a new atomic counter semantic, along with docs for both. v2: drop semantic, move hw counter to backend, Ilia pointed out SSO would have

[Mesa-dev] [PATCH 4/9] mesa/program: add hw atomic counter file

2017-11-08 Thread Dave Airlie
From: Dave Airlie This is needed for the GLSL->TGSI translation for hw atomic counters. Reviewed-by: Nicolai Hähnle Reviewed-by: Marek Olšák Signed-off-by: Dave Airlie --- src/mesa/main/mtypes.h | 1 + 1

[Mesa-dev] gallium/r600 atomic - v4

2017-11-08 Thread Dave Airlie
Hopefully last pass, a few fixes in here, patch 5 is the only outstanding non-reviewed one, I think I've fixed the sparse buffer binding in it well enough, there is also fix for Gert's off-by one. Dave. ___ mesa-dev mailing list

[Mesa-dev] [PATCH 1/9] gallium: add CAPs to support HW atomic counters. (v3)

2017-11-08 Thread Dave Airlie
From: Dave Airlie This looks like an evergreen specific feature, but with atomic counters AMD have hw specific counters they use instead of operating on buffers directly. These are separate to the buffer atomics, so require different limits and code paths. I've left the CAP

Re: [Mesa-dev] [PATCH 2/4] st/mesa: use enum types instead of int/unsigned (v3)

2017-11-08 Thread Ian Romanick
On 11/08/2017 09:08 AM, Erik Faye-Lund wrote: > On Wed, Nov 8, 2017 at 1:07 AM, Brian Paul wrote: >> Use the proper enum types for various variables. Makes life in gdb >> a little nicer. Note that the size of enum bitfields must be one >> larger so the high bit is always zero

Re: [Mesa-dev] [PATCH 3/4] glsl: s/unsigned/glsl_base_type/ in glsl type code (v2)

2017-11-08 Thread Ian Romanick
Any thoughts about my data using __attribute__((__packed__))? On 11/07/2017 04:07 PM, Brian Paul wrote: > Declare glsl_type::sampled_type as glsl_base_type as we do for the > base_type field. And make base_type a bitfield to save a few bytes. > > Update glsl_type constructor to take

Re: [Mesa-dev] [PATCH] i965: Enable disk shader cache by default

2017-11-08 Thread Timothy Arceri
Reviewed-by: Timothy Arceri Mark may want to consider adding some of the once a day type CI runs for this. For example running the test suite for two consecutive runs on the same build so that the second run uses the shader cache and also a second run the uses

Re: [Mesa-dev] gallium/r600 hw atomic support (v3)

2017-11-08 Thread Dave Airlie
On 7 November 2017 at 20:45, Gert Wollny wrote: > Am Dienstag, den 07.11.2017, 16:30 +1000 schrieb Dave Airlie: >> This is the 3rd submission of the gallium/r600 hw atomic counter >> support. >> >> This is fixes some rebase artifacts, removes the BUFFER decls from >> the

Re: [Mesa-dev] [PATCH] ac/nir: add support for all intrinsics. (v2)

2017-11-08 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen On Thu, Nov 9, 2017 at 2:12 AM, Dave Airlie wrote: > From: Dave Airlie > > This is derived from tgsi/radeonsi code from the GLSL intrinsics. > > This should pre-fix radv for the upcoming spirv

[Mesa-dev] [PATCH] ac/nir: add support for all intrinsics. (v2)

2017-11-08 Thread Dave Airlie
From: Dave Airlie This is derived from tgsi/radeonsi code from the GLSL intrinsics. This should pre-fix radv for the upcoming spirv patches. v2: actually use wait_cnt, sleep deprived dad time! (Bas) Signed-off-by: Dave Airlie ---

Re: [Mesa-dev] [PATCH] ac/nir: add support for all intrinsics.

2017-11-08 Thread Bas Nieuwenhuizen
On Thu, Nov 9, 2017 at 2:04 AM, Dave Airlie wrote: > From: Dave Airlie > > This is derived from tgsi/radeonsi code from the GLSL intrinsics. > > This should pre-fix radv for the upcoming spirv patches. > > Signed-off-by: Dave Airlie >

[Mesa-dev] [PATCH] ac/nir: add support for all intrinsics.

2017-11-08 Thread Dave Airlie
From: Dave Airlie This is derived from tgsi/radeonsi code from the GLSL intrinsics. This should pre-fix radv for the upcoming spirv patches. Signed-off-by: Dave Airlie --- src/amd/common/ac_nir_to_llvm.c | 32 +++- 1 file

[Mesa-dev] [PATCH] i965: Enable disk shader cache by default

2017-11-08 Thread Jordan Justen
f9d5a7add42af5a2e4410526d1480a08f41317ae along with a16dc04ad51c32e5c7d136e4dd6273d983385d3f appears to have fixed the one known regression with shader cache. (Deus Ex instability.) We should enable the shader cache by default to stabilize it before the next major Mesa release. Signed-off-by:

[Mesa-dev] [PATCH] swr: Fixed an uncommon freed-memory access during state validation

2017-11-08 Thread Bruce Cherniak
State validation is performed during clear and draw calls. Validation during clear was still accessing vertex buffer state. When the currently set vertex buffers are client arrays, this could lead to accessing freed memory. Such is the case with the VMD application. Previously, vertex buffer

[Mesa-dev] [Bug 102891] [radv] glitches on rpcs3 emulator (green zones)

2017-11-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102891 --- Comment #6 from Dave Airlie --- Did someone already try RADV_DEBUG=zerovram to see if it helps? The trace replays badly on amdgpu-pro which suggests the bad stuff is in ram before recording. -- You are receiving

Re: [Mesa-dev] [PATCH] i965: implement (un)mapImage

2017-11-08 Thread Julien Isorce
Ah yes you are right, my mistake. I will update the patch after some more testing. Thx. On 8 November 2017 at 17:21, Chris Wilson wrote: > Quoting Julien Isorce (2017-11-08 16:55:05) > > v2: add early return if (flag & MAP_INTERNAL_MASK) > > > > Already implemented for

Re: [Mesa-dev] [PATCH] anv/meson: Generate dev_icd.json

2017-11-08 Thread Jason Ekstrand
On Wed, Nov 8, 2017 at 3:42 PM, Chad Versace wrote: > On Wed 08 Nov 2017, Jason Ekstrand wrote: > > On Wed, Nov 8, 2017 at 1:40 PM, Chad Versace <[1] > chadvers...@chromium.org> > > wrote: > > > > On Tue 07 Nov 2017, Dylan Baker wrote: > > > Quoting Eric

Re: [Mesa-dev] [PATCH] anv/meson: Generate dev_icd.json

2017-11-08 Thread Chad Versace
On Wed 08 Nov 2017, Jason Ekstrand wrote: > On Wed, Nov 8, 2017 at 1:40 PM, Chad Versace <[1]chadvers...@chromium.org> > wrote: > > On Tue 07 Nov 2017, Dylan Baker wrote: > > Quoting Eric Engestrom (2017-11-07 07:25:53) > > > On Wednesday, 2017-11-01 13:49:03 -0700, Chad Versace

[Mesa-dev] Mesa 17.2.5 release candidate

2017-11-08 Thread Andres Gomez
Hello list, The candidate for the Mesa 17.2.5 is now available. Currently we have: - 30 queued - 16 nominated (outstanding) - and 3 rejected patches In the current queue we have: In Mesa Core a GL error related to the ARB_ES3_1_compatibility spec noticed with the GFXBench 5 Aztec Ruins has

[Mesa-dev] [PATCH 4/4] i965: Use prepare_external instead of make_shareable in setTexBuffer2

2017-11-08 Thread Jason Ekstrand
The setTexBuffer2 hook from GLX is used to implement glxBindTexImageEXT which has tighter restrictions than just "it's shared". In particular, it says that any rendering to the image while it is bound causes the contents to become undefined. The GLX_EXT_texture_from_pixmap extension provides us

[Mesa-dev] [PATCH 2/4] i965/tex_image: Reference the renderbuffer miptree in setTexBuffer2

2017-11-08 Thread Jason Ekstrand
The old code made a new miptree that referenced the same BO as the renderbuffer and just trusted in the memory aliasing to work. There are only two ways in which the new miptree is liable to differ from the one in the renderbuffer and neither of them matter: 1) It may have a different target.

[Mesa-dev] [PATCH 3/4] i965/tex_image: Pull the tex format from the renderbuffer in intelSetTexBuffer2

2017-11-08 Thread Jason Ekstrand
Cc: "17.3" --- src/mesa/drivers/dri/i965/intel_tex_image.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_tex_image.c b/src/mesa/drivers/dri/i965/intel_tex_image.c index c52992a..28800f6

[Mesa-dev] [PATCH 1/4] i965/miptree: Loosen the format check in miptree_match_image

2017-11-08 Thread Jason Ekstrand
This function is used to determine when we need to re-allocate a miptree. Since we do nothing different in miptree allocation for sRGB vs. linear, loosening this should be safe and may lead to less copying and reallocating in some odd cases. Cc: "17.3" Cc:

Re: [Mesa-dev] [PATCH 4/4] meson: Enable VC4's NEON assembly support.

2017-11-08 Thread Eric Anholt
Dylan Baker writes: > [ Unknown signature status ] > Quoting Eric Anholt (2017-11-08 14:14:57) >> --- >> meson.build | 5 +++-- >> src/gallium/drivers/vc4/meson.build | 13 + >> 2 files changed, 16 insertions(+), 2 deletions(-) >> >>

Re: [Mesa-dev] [PATCH 0/4] meson: vc4 ARMHF cross-build support

2017-11-08 Thread Timothy Arceri
On 09/11/17 09:14, Eric Anholt wrote: Timothy Arceri noted that vc4 didn't seem to have the NEON stuff hooked up, so I worked on getting vc4 cross builds working for me finally. I haven't tested the result on HW quite yet. I can now build vc4 with asm enable with this series so: Tested-by:

[Mesa-dev] [Bug 103586] OpenCL/Clover: AMD Turks: corrupt output buffer (depending on dimension order?)

2017-11-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103586 --- Comment #9 from Dave Gilbert --- (In reply to Jan Vesely from comment #8) > (In reply to Dave Gilbert from comment #6) > > (In reply to Jan Vesely from comment #5) > > > (In reply to Dave Gilbert from comment #4) >

Re: [Mesa-dev] [PATCH 2/3] glx: Prepare the DRI backends for GLX_EXT_no_config_context

2017-11-08 Thread Eric Anholt
Adam Jackson writes: > This should be safe as these backends already support the EGL version of > this extension. DRI1 is not affected because it does not support > GLX_ARB_create_context anyway. DRI-Windows is not prepared to implement > this as there's no equivalent WGL

Re: [Mesa-dev] [PATCH] amd/addrlib: update to latest version

2017-11-08 Thread Ilia Mirkin
On Wed, Nov 8, 2017 at 4:13 AM, Nicolai Hähnle wrote: > On 08.11.2017 09:53, Michel Dänzer wrote: >> >> On 07/11/17 10:58 PM, Marek Olšák wrote: >>> >>> On Tue, Nov 7, 2017 at 9:01 PM, Nicolai Hähnle >>> wrote: On 07.11.2017 18:35, Michel Dänzer

Re: [Mesa-dev] [PATCH] amd/addrlib: update to latest version

2017-11-08 Thread Eric Anholt
Nicolai Hähnle writes: > On 08.11.2017 09:53, Michel Dänzer wrote: >> On 07/11/17 10:58 PM, Marek Olšák wrote: >>> On Tue, Nov 7, 2017 at 9:01 PM, Nicolai Hähnle wrote: On 07.11.2017 18:35, Michel Dänzer wrote: > > On 07/11/17 06:28 PM, Marek

[Mesa-dev] [Bug 103586] OpenCL/Clover: AMD Turks: corrupt output buffer (depending on dimension order?)

2017-11-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103586 --- Comment #8 from Jan Vesely --- (In reply to Dave Gilbert from comment #6) > (In reply to Jan Vesely from comment #5) > > (In reply to Dave Gilbert from comment #4) > > > Created attachment 135313 [details] > > >

Re: [Mesa-dev] [PATCH 4/4] meson: Enable VC4's NEON assembly support.

2017-11-08 Thread Dylan Baker
Quoting Eric Anholt (2017-11-08 14:14:57) > --- > meson.build | 5 +++-- > src/gallium/drivers/vc4/meson.build | 13 + > 2 files changed, 16 insertions(+), 2 deletions(-) > > diff --git a/meson.build b/meson.build > index 0118c9a7c5ef..189c9be5b59c 100644 >

[Mesa-dev] [PATCH 2/4] meson: Drop stale comment about making valgrind conditional.

2017-11-08 Thread Eric Anholt
It was fixed in 5c2ff5773a707519f6a773126f201c4e1e8a42d7. --- meson.build | 1 - 1 file changed, 1 deletion(-) diff --git a/meson.build b/meson.build index 117ed7c087f4..0118c9a7c5ef 100644 --- a/meson.build +++ b/meson.build @@ -691,7 +691,6 @@ if with_glvnd pre_args += '-DUSE_LIBGLVND=1'

[Mesa-dev] [PATCH 0/4] meson: vc4 ARMHF cross-build support

2017-11-08 Thread Eric Anholt
Timothy Arceri noted that vc4 didn't seem to have the NEON stuff hooked up, so I worked on getting vc4 cross builds working for me finally. I haven't tested the result on HW quite yet. Eric Anholt (4): meson: Leave dep_llvm empty if !with_llvm meson: Drop stale comment about making valgrind

[Mesa-dev] [PATCH 1/4] meson: Leave dep_llvm empty if !with_llvm

2017-11-08 Thread Eric Anholt
The gallium auxiliary build would link against llvm, for the gallivm code that it didn't build. This broke the build on my armhf cross, where libLLVM-3.9.so is not multiarch and thus points to x86-64 libs. --- meson.build | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git

[Mesa-dev] [PATCH 4/4] meson: Enable VC4's NEON assembly support.

2017-11-08 Thread Eric Anholt
--- meson.build | 5 +++-- src/gallium/drivers/vc4/meson.build | 13 + 2 files changed, 16 insertions(+), 2 deletions(-) diff --git a/meson.build b/meson.build index 0118c9a7c5ef..189c9be5b59c 100644 --- a/meson.build +++ b/meson.build @@ -485,8 +485,9 @@

[Mesa-dev] [PATCH 3/4] meson: Always link libgallium_dri.so against dep_thread.

2017-11-08 Thread Eric Anholt
Somehow on my cross build the -pthread is getting lost. All the other deps seem to work out fine. --- src/gallium/targets/dri/meson.build | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/targets/dri/meson.build b/src/gallium/targets/dri/meson.build index

Re: [Mesa-dev] [PATCH v3] egl/wayland: Support for KHR_partial_update

2017-11-08 Thread Harish Krupo
Hi Emil, Emil Velikov writes: > On 27 October 2017 at 05:54, Harish Krupo wrote: >> Hi Eric, >> >> Eric Engestrom writes: >> >>> On Monday, 2017-10-23 16:20:54 +0530, Harish Krupo wrote: This passes 33/37

Re: [Mesa-dev] [PATCH] meson: Add script to use VERSION file for getting version

2017-11-08 Thread Dylan Baker
Quoting Eric Engestrom (2017-11-08 12:38:26) > > > On 8 November 2017 19:32:22 GMT, Dylan Baker wrote: > > Quoting Eric Engestrom (2017-11-08 04:21:41) > > > On Wednesday, 2017-11-01 11:58:16 -0700, Dylan Baker wrote: > > > > Meson has up until this point set it's version

Re: [Mesa-dev] [PATCH] anv/meson: Generate dev_icd.json

2017-11-08 Thread Jason Ekstrand
On Wed, Nov 8, 2017 at 1:40 PM, Chad Versace wrote: > On Tue 07 Nov 2017, Dylan Baker wrote: > > Quoting Eric Engestrom (2017-11-07 07:25:53) > > > On Wednesday, 2017-11-01 13:49:03 -0700, Chad Versace wrote: > > > > I tested this in a setup where the builddir was

Re: [Mesa-dev] [RFC PATCH v1 00/30] anv: dma-buf and DRM format modifiers

2017-11-08 Thread Chad Versace
On Tue 07 Nov 2017, Jason Ekstrand wrote: > All of the pre-work patches have been reviewed by myself and Lionel.  I've > also > read through the rest of the series and things look pretty good to me.  I did > make some scattered comments but they shouldn't be a big deal. > > My primary concern

Re: [Mesa-dev] [PATCH] Adding support for EXT_sRGB for Opengl ES

2017-11-08 Thread Harish Krupo
Hi Emil, Emil Velikov writes: > Hi Harish, > > This seems to have fallen through the cracks, right? Thanks for bringing this up again :) > Keep in mind that I've not checked all the existing code paths - just > skimming through the patch itself. > > s/Adding support

Re: [Mesa-dev] [PATCH] anv/meson: Generate dev_icd.json

2017-11-08 Thread Chad Versace
On Tue 07 Nov 2017, Dylan Baker wrote: > Quoting Eric Engestrom (2017-11-07 07:25:53) > > On Wednesday, 2017-11-01 13:49:03 -0700, Chad Versace wrote: > > > I tested this in a setup where the builddir was outside of the srcdir. > > > --- > > > src/intel/vulkan/meson.build | 12 > > >

Re: [Mesa-dev] [PATCH 5/5] meson: build gallium-xlib based glx

2017-11-08 Thread Eric Anholt
Dylan Baker writes: > Signed-off-by: Dylan Baker > --- > meson.build | 16 +++--- > src/gallium/meson.build | 11 +++- > src/gallium/state_trackers/glx/xlib/meson.build | 27 ++ >

[Mesa-dev] [Bug 103586] OpenCL/Clover: AMD Turks: corrupt output buffer (depending on dimension order?)

2017-11-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103586 --- Comment #7 from Jan Vesely --- Created attachment 135318 --> https://bugs.freedesktop.org/attachment.cgi?id=135318=edit annotated asm dump -- You are receiving this mail because: You are the QA Contact for the

[Mesa-dev] [Bug 103586] OpenCL/Clover: AMD Turks: corrupt output buffer (depending on dimension order?)

2017-11-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103586 --- Comment #6 from Dave Gilbert --- (In reply to Jan Vesely from comment #5) > (In reply to Dave Gilbert from comment #4) > > Created attachment 135313 [details] > > foo.link-0.ll > > > > That's all 3 of the debug

[Mesa-dev] [Bug 103586] OpenCL/Clover: AMD Turks: corrupt output buffer (depending on dimension order?)

2017-11-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103586 --- Comment #5 from Jan Vesely --- (In reply to Dave Gilbert from comment #4) > Created attachment 135313 [details] > foo.link-0.ll > > That's all 3 of the debug files it produced. > (I wasn't sure which were the llvm

Re: [Mesa-dev] [PATCH] meson: Add script to use VERSION file for getting version

2017-11-08 Thread Eric Engestrom
On 8 November 2017 19:32:22 GMT, Dylan Baker wrote: > Quoting Eric Engestrom (2017-11-08 04:21:41) > > On Wednesday, 2017-11-01 11:58:16 -0700, Dylan Baker wrote: > > > Meson has up until this point set it's version in the root > meson.build > > > script. While there are

Re: [Mesa-dev] [PATCH 01/18] radeon/vcn: add vcn encode interface

2017-11-08 Thread Christian König
Am 08.11.2017 um 19:08 schrieb boyuan.zh...@amd.com: From: Boyuan Zhang Add a new header file for vcn encode interface Signed-off-by: Boyuan Zhang Only briefly skimmed over it, but what I saw looks mostly sane. Maybe nice to have is to have the

Re: [Mesa-dev] [PATCH] docs: add documentation for building with meson

2017-11-08 Thread Dylan Baker
Quoting Ian Romanick (2017-11-08 11:05:24) > On 11/08/2017 10:59 AM, Ian Romanick wrote: > > Is there a way to get a list of options before having any success? I > > want to disable using LLVM, but I can't get the list of options to do so > > because I don't have libelf (required for LLVM...

  1   2   >