[Mesa-dev] [PATCH v2 21/25] mesa: Add a reference to gl_shader_spirv_data to gl_linked_shader

2017-11-30 Thread Eduardo Lima Mitev
This is a reference to the spirv_data object stored in gl_shader, which stores shader SPIR-V data that is needed during linking too. --- src/mesa/main/mtypes.h| 8 src/mesa/main/shaderobj.c | 1 + 2 files changed, 9 insertions(+) diff --git a/src/mesa/main/mtypes.h

[Mesa-dev] [PATCH v2 15/25] spirv_extensions: add spirv_supported_extensions on gl_constants

2017-11-30 Thread Eduardo Lima Mitev
From: Alejandro Piñeiro We can use it to get real values for ARB_spirv_extensions methods. v2: Rebase update after changes on previous patches. --- src/mesa/main/mtypes.h | 3 +++ src/mesa/main/spirv_extensions.c | 20 +++- 2 files changed, 22

[Mesa-dev] [PATCH v2 18/25] mesa: Implement glSpecializeShaderARB

2017-11-30 Thread Eduardo Lima Mitev
From: Nicolai Hähnle v2: * Use gl_spirv_validation instead of spirv_to_nir. This method just validates the shader. The conversion to NIR will happen later, during linking. (Alejandro Piñeiro) * Use gl_shader_spirv_data struct to store the SPIR-V data.

[Mesa-dev] [PATCH v2 20/25] mesa/program: Link SPIR-V shaders using the SPIR-V code-path

2017-11-30 Thread Eduardo Lima Mitev
--- src/mesa/program/ir_to_mesa.cpp | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/mesa/program/ir_to_mesa.cpp b/src/mesa/program/ir_to_mesa.cpp index 047f5b38f71..83de0143c65 100644 --- a/src/mesa/program/ir_to_mesa.cpp +++ b/src/mesa/program/ir_to_mesa.cpp @@ -36,6

[Mesa-dev] [PATCH v2 16/25] spirv_extensions: i965: initialize SPIR-V extensions

2017-11-30 Thread Eduardo Lima Mitev
From: Alejandro Piñeiro v2: Rebase update after changes on previous patches. --- src/mesa/drivers/dri/i965/brw_context.c | 6 ++ src/mesa/main/context.c | 2 ++ 2 files changed, 8 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_context.c

[Mesa-dev] [PATCH v2 17/25] nir/spirv: add gl_spirv_validation method

2017-11-30 Thread Eduardo Lima Mitev
From: Alejandro Piñeiro ARB_gl_spirv adds the ability to use SPIR-V binaries, and a new method, glSpecializeShader. From OpenGL 4.6 spec, section 7.2.1 "Shader Specialization", error table: INVALID_VALUE is generated if does not name a valid entry point for .

[Mesa-dev] [PATCH v2 14/25] spirv_extensions: define spirv_extensions_supported

2017-11-30 Thread Eduardo Lima Mitev
From: Alejandro Piñeiro Add a struct to maintain which SPIR-V extensions are supported, and an utility method to initialize it based on nir_spirv_supported_capabilities. v2: * Fixing code style (Ian Romanick) * Adding a prefix (spirv) to fill_supported_spirv_extensions

[Mesa-dev] [PATCH v2 12/25] spirv_extensions: add GL_ARB_spirv_extensions boilerplate

2017-11-30 Thread Eduardo Lima Mitev
From: Alejandro Piñeiro v2: * Mention extension gap at gl_API.xml (Emil Velikov) * Bail with INVALID_ENUM if extension not available on getStringi (Emil Velikov) * Use EXTRA_EXT macro when defining the extension at get.c/get_hash_params.py (Emil Velikov) *

[Mesa-dev] [PATCH v2 05/25] mesa: implement SPIR-V loading in glShaderBinary

2017-11-30 Thread Eduardo Lima Mitev
From: Nicolai Hähnle v2: * Add a gl_shader_spirv_data member to gl_shader, which already encapsulates a gl_spirv_module where the binary will be saved. (Eduardo Lima) * Just use the 'spirv_data' member to know whether a gl_shader has the SPIR_V_BINARY_ARB

[Mesa-dev] [PATCH v2 09/25] mesa: move nir_spirv_supported_capabilities definition

2017-11-30 Thread Eduardo Lima Mitev
From: Alejandro Piñeiro Due gl_spirv we will use it on more places, specifically on gl_constants, where we would like to use it without a pointer. --- src/compiler/spirv/nir_spirv.h | 15 ++- src/mesa/main/mtypes.h | 11 +++ 2 files changed, 13

[Mesa-dev] [PATCH v2 13/25] spirv_extensions: add list of extensions and to_string method

2017-11-30 Thread Eduardo Lima Mitev
From: Alejandro Piñeiro Ideally this should be generated somehow. One option would be gather all the extension dependencies listed on the core grammar, but there would be the possibility of not including some of the extensions. Note that spirv-tools is doing it just

[Mesa-dev] [PATCH v2 10/25] mesa: add gl_constants::SpirVCapabilities

2017-11-30 Thread Eduardo Lima Mitev
From: Nicolai Hähnle For drivers to declare which SPIR-V features they support. v2: Don't use a pointer (Ian Romanick) --- src/mesa/main/mtypes.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h index

[Mesa-dev] [PATCH v2 04/25] mesa/glspirv: Add struct gl_shader_spirv_data

2017-11-30 Thread Eduardo Lima Mitev
This is a per-shader structure holding the SPIR-V data associated with the shader (binary module, specialization constants and entry-point). This is needed because both gl_shader and gl_linked_shader need to share this data. Instead of copying the data, we pass a reference to it upon program

[Mesa-dev] [PATCH v2 06/25] mesa/shaderapi: add a getter for GL_SPIR_V_BINARY_ARB

2017-11-30 Thread Eduardo Lima Mitev
From: Nicolai Hähnle v2: Use the 'spirv_data' member of gl_shader instead of a dedicated flag. (Timothy Arceri) --- src/mesa/main/shaderapi.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/mesa/main/shaderapi.c b/src/mesa/main/shaderapi.c index

[Mesa-dev] [PATCH v2 11/25] i965: initialize SPIR-V capabilities

2017-11-30 Thread Eduardo Lima Mitev
From: Alejandro Piñeiro Needed for ARB_gl_spirv. Right now those are the same that the intel vulkan driver, but those are not shared. From the ARB_spirv_extensions spec: "3. If a new GL extension is added that includes SPIR-V support via a new SPIR-V extension does

[Mesa-dev] [PATCH v2 08/25] spirv_extensions: rename nir_spirv_supported_extensions

2017-11-30 Thread Eduardo Lima Mitev
From: Alejandro Piñeiro Renamed to nir_spirv_supported_capabilities. The original name seemed to suggest that it was directly related to the SPIR-V extensions supported, but that is not the case. For example, float64 was supported on SPIR-V 1.0 core, without the need of

[Mesa-dev] [PATCH v2 07/25] mesa: refuse to compile SPIR-V shaders or link mixed shaders

2017-11-30 Thread Eduardo Lima Mitev
From: Nicolai Hähnle Note that gl_shader::CompileStatus will also indicate whether a shader has been successfully specialized. v2: Use the 'spirv_data' member of gl_shader to know if it is a SPIR-V shader, instead of a dedicated flag. (Timothy Arceri) ---

[Mesa-dev] [PATCH v2 01/25] mesa: add GL_ARB_gl_spirv boilerplate

2017-11-30 Thread Eduardo Lima Mitev
From: Nicolai Hähnle v2: * Add meson build bits (Eric Engestrom) * Return INVALID_OPERATION error on SpecializeShaderARB (Ian Romanick) Reviewed-by: Emil Velikov Reviewed-by: Ian Romanick Reviewed-by: Timothy

[Mesa-dev] [PATCH v2 03/25] mesa/glspirv: Add struct gl_spirv_module

2017-11-30 Thread Eduardo Lima Mitev
From: Nicolai Hähnle v2: * Make the SPIR-V module struct part of a larger gl_shader_spirv_data struct that will be introduced later, and don't reference it directly in gl_shader. (Eduardo Lima) * Readability improvements (Ian Romanick) Reviewed-by: Ian

[Mesa-dev] [PATCH v2 00/25] Initial gl_spirv and spirv_extensions support in Mesa and i965

2017-11-30 Thread Eduardo Lima Mitev
Hello, This is the second version of the series providing initial support for ARB_gl_spirv and ARB_spirv_extensions in Mesa and i965. First version of the series can be found at . In this series we hope we have

[Mesa-dev] [PATCH v2 02/25] mesa: Add boilerplate for the GL 4.6 alias of glSpecializeShaderARB

2017-11-30 Thread Eduardo Lima Mitev
From: Neil Roberts --- src/mapi/glapi/gen/GL4x.xml | 11 +++ 1 file changed, 11 insertions(+) diff --git a/src/mapi/glapi/gen/GL4x.xml b/src/mapi/glapi/gen/GL4x.xml index 88dba5cd71a..0a8094166c8 100644 --- a/src/mapi/glapi/gen/GL4x.xml +++

Re: [Mesa-dev] [PATCH 1/2] meson: fix GLES3/gl31.h install

2017-11-30 Thread Eric Engestrom
On Wednesday, 2017-11-29 11:19:54 -0800, Dylan Baker wrote: > This is a typo, gl32.h is installed twice. > > Reported-by: Marc Dietrich > Signed-off-by: Dylan Baker Both are Reviewed-by: Eric Engestrom > --- >

Re: [Mesa-dev] [PATCH mesa] u_debug: do not compile asserts when they are disabled

2017-11-30 Thread Eric Engestrom
On Thursday, 2017-11-30 12:16:06 +, Eric Engestrom wrote: > Commit f0ba7d897d1c22202531a added this code to expose asserts to the > compiler in an attempt to hide 'unused variable' warnings, incorrectly > claiming it was a no-op. This has two bad effects: > - any assert with side-effects are

[Mesa-dev] [Bug 103762] [swr] piglit ext_transform_feedback-immediate-reuse-uniform-buffer has a ~5% pass rate

2017-11-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103762 Bruce Cherniak changed: What|Removed |Added Assignee|mesa-dev@lists.freedesktop.

Re: [Mesa-dev] [PATCH] egl/android: Partially handle HAL_PIXEL_FORMAT_IMPLEMENTATION_DEFINED

2017-11-30 Thread Rob Herring
On Thu, Nov 30, 2017 at 12:11 AM, Tapani Pälli wrote: > > > On 11/30/2017 06:13 AM, Tomasz Figa wrote: >> >> On Thu, Nov 30, 2017 at 3:43 AM, Robert Foss >> wrote: >>> >>> Hey, >>> >>> On Tue, 2017-11-28 at 11:49 +, Emil Velikov wrote:

Re: [Mesa-dev] [PATCH 7/7] meson: fix deps and underlinkage of libGL

2017-11-30 Thread Emil Velikov
On 30 November 2017 at 15:13, Jon Turney wrote: > On 29/11/2017 17:34, Dylan Baker wrote: >> >> Quoting Jon Turney (2017-11-29 08:22:54) >>> >>> On 28/11/2017 18:21, Dylan Baker wrote: Quoting Emil Velikov (2017-11-27 06:31:35) > > IIRC Windows

Re: [Mesa-dev] [PATCH] intel/isl: Declare private array as static const

2017-11-30 Thread Jason Ekstrand
Oops. Rb On November 30, 2017 01:27:50 Kenneth Graunke wrote: On Wednesday, November 29, 2017 11:10:48 AM PST Chad Versace wrote: It's array isl_drm.c:modifier_info[] . --- src/intel/isl/isl_drm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Mesa-dev] [PATCH 10/29] anv/cmd_buffer: Add an anv_genX_call macro

2017-11-30 Thread Pohjolainen, Topi
On Mon, Nov 27, 2017 at 07:06:00PM -0800, Jason Ekstrand wrote: > This is copied and pasted from the similar macro we added to ISL. > --- > src/intel/vulkan/anv_cmd_buffer.c | 40 > --- > 1 file changed, 25 insertions(+), 15 deletions(-) Reviewed-by: Topi

Re: [Mesa-dev] [PATCH 11/29] anv/cmd_buffer: Add a mark_image_written helper

2017-11-30 Thread Pohjolainen, Topi
On Mon, Nov 27, 2017 at 07:06:01PM -0800, Jason Ekstrand wrote: > Currently, this helper does nothing but we call it every place where an > image is written through the render pipeline. This will allow us to > properly mark the aux state so that we can handle resolves correctly. > --- >

Re: [Mesa-dev] [PATCH 6/6] glx: Implement GLX_EXT_no_config_context (v3)

2017-11-30 Thread Emil Velikov
On 14 November 2017 at 20:13, Adam Jackson wrote: > @@ -562,6 +562,10 @@ dri2_convert_glx_attribs(unsigned num_attribs, const > uint32_t *attribs, > return false; > } > break; > + case GLX_SCREEN: > + /* Implies

Re: [Mesa-dev] [PATCH 1/6] glx: Simplify some dummy vtable interactions

2017-11-30 Thread Emil Velikov
On 14 November 2017 at 20:13, Adam Jackson wrote: > The dummy vtable has these slots as NULL already, no need to check for > the dummy context explicitly. > Looks good, but make sure that `make check' still passes. With that Reviewed-by: Emil Velikov

Re: [Mesa-dev] [PATCH 2/6] glx: Use __glXSendError instead of open-coding it

2017-11-30 Thread Emil Velikov
On 14 November 2017 at 20:13, Adam Jackson wrote: > This also fixes a bug, the error path through MakeCurrent didn't > translate the error code by the extension's error base. > May I suggest splitting the MakeContextCurrent bugfix from the refactor? Reason being, that the

Re: [Mesa-dev] [PATCH 2/2] ac/surface: always compute DCC info when DCC is possible on GFX9

2017-11-30 Thread Nicolai Hähnle
On 30.11.2017 02:20, Marek Olšák wrote: From: Marek Olšák The same code for VI doesn't check for scanout either. Both patches: Reviewed-by: Nicolai Hähnle --- src/amd/common/ac_surface.c | 1 - 1 file changed, 1 deletion(-) diff --git

Re: [Mesa-dev] [PATCH] docs/release-calendar: update and extend

2017-11-30 Thread Andres Gomez
On Wed, 2017-11-29 at 18:20 +, Emil Velikov wrote: > From: Emil Velikov > > Cc: Juan A. Suárez > Cc: Andres Gomez > Signed-off-by: Emil Velikov > --- > Gents, I have no objections if you want

Re: [Mesa-dev] [PATCH 1/2] gallium/util: add u_transfer_helper

2017-11-30 Thread Rob Clark
On Thu, Nov 30, 2017 at 10:04 AM, Nicolai Hähnle wrote: > On 29.11.2017 14:48, Rob Clark wrote: >> >> Add a new helper that drivers can use to emulate various things that >> need special handling in particular in transfer_map: >> >> 1) z32_s8x24.. gl/gallium treats this as a

Re: [Mesa-dev] [PATCH v2 4/5] gallium: Make a helper for doing Z32_FLOAT_S8X24_UINT mappings.

2017-11-30 Thread Nicolai Hähnle
On 30.11.2017 16:14, Rob Clark wrote: On Thu, Nov 30, 2017 at 9:53 AM, Nicolai Hähnle wrote: On 28.11.2017 15:01, Rob Clark wrote: On Tue, Nov 21, 2017 at 4:13 PM, Eric Anholt wrote: v2: Remove the callback, leave avoiding the recursion up to the

Re: [Mesa-dev] [PATCH 01/21] st/mesa: handle compute atomics

2017-11-30 Thread Nicolai Hähnle
On 29.11.2017 05:36, Dave Airlie wrote: From: Dave Airlie Just reuse the cs atomics bit and emit the hw atomic state. Reviewed-by: Nicolai Hähnle --- src/mesa/state_tracker/st_atom_atomicbuf.c | 4 src/mesa/state_tracker/st_context.c

Re: [Mesa-dev] [PATCH] anv: Check if memfd_create is already defined.

2017-11-30 Thread Emil Velikov
Vinson please add a small note why now aka "Newly introduced with glibc 2.27" With that the patch is: Reviewed-by: Emil Velikov Wrt scons - it does not build anything vulkan; Android does though :-) Android people will address on their end when applicable. -Emil

Re: [Mesa-dev] [PATCH v3] nir: add varying array splitting pass

2017-11-30 Thread Nicolai Hähnle
On 30.11.2017 01:19, Timothy Arceri wrote: V2: - fix matrix support, non-array matrices were being skipped in v1 v3: - handle lowering of tcs output loads correctly - correctly mark indirect locations for either in or out not both when processing a stage. - use nir_src_copy() when

Re: [Mesa-dev] [PATCH v2 4/5] gallium: Make a helper for doing Z32_FLOAT_S8X24_UINT mappings.

2017-11-30 Thread Rob Clark
On Thu, Nov 30, 2017 at 9:53 AM, Nicolai Hähnle wrote: > On 28.11.2017 15:01, Rob Clark wrote: >> >> On Tue, Nov 21, 2017 at 4:13 PM, Eric Anholt wrote: >>> >>> v2: Remove the callback, leave avoiding the recursion up to the caller >>> (probably by

Re: [Mesa-dev] [PATCH 7/7] meson: fix deps and underlinkage of libGL

2017-11-30 Thread Jon Turney
On 29/11/2017 17:34, Dylan Baker wrote: Quoting Jon Turney (2017-11-29 08:22:54) On 28/11/2017 18:21, Dylan Baker wrote: Quoting Emil Velikov (2017-11-27 06:31:35) IIRC Windows mandates binaries with unresolved symbols. Other platforms allow such behaviour. I think we want to set

Re: [Mesa-dev] [PATCH] docs/release-calendar: update and extend

2017-11-30 Thread Nicolai Hähnle
On 29.11.2017 19:20, Emil Velikov wrote: From: Emil Velikov Cc: Juan A. Suárez Cc: Andres Gomez Signed-off-by: Emil Velikov Acked-by: Nicolai Hähnle --- Gents, I

Re: [Mesa-dev] [PATCH mesa] gallium/hud: use #ifdef to test for macro existence

2017-11-30 Thread Nicolai Hähnle
Reviewed-by: Nicolai Hähnle On 29.11.2017 16:05, Eric Engestrom wrote: Signed-off-by: Eric Engestrom --- src/gallium/auxiliary/hud/hud_context.c | 10 +- src/gallium/auxiliary/hud/hud_cpufreq.c | 2 +-

Re: [Mesa-dev] [PATCH 1/2] gallium/util: add u_transfer_helper

2017-11-30 Thread Nicolai Hähnle
On 29.11.2017 14:48, Rob Clark wrote: Add a new helper that drivers can use to emulate various things that need special handling in particular in transfer_map: 1) z32_s8x24.. gl/gallium treats this as a single buffer with depth and stencil interleaved but hardware frequently treats this

Re: [Mesa-dev] [PATCH v2 4/5] gallium: Make a helper for doing Z32_FLOAT_S8X24_UINT mappings.

2017-11-30 Thread Nicolai Hähnle
On 28.11.2017 15:01, Rob Clark wrote: On Tue, Nov 21, 2017 at 4:13 PM, Eric Anholt wrote: v2: Remove the callback, leave avoiding the recursion up to the caller (probably by rewriting the vtbl either in pctx or u_resource_vtbl) hmm, that is still a bit ugly.. and

Re: [Mesa-dev] [PATCH 2/2] glsl: don't run intrastage array validation when the interface type is not an array

2017-11-30 Thread Nicolai Hähnle
Can you add an explanation / spec quote for this? On 09.11.2017 12:48, Samuel Iglesias Gonsálvez wrote: Signed-off-by: Samuel Iglesias Gonsálvez --- src/compiler/glsl/link_interface_blocks.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Mesa-dev] [PATCH 1/2] glsl/es: precision qualifier doesn't need to match in UBOs

2017-11-30 Thread Nicolai Hähnle
On 09.11.2017 12:48, Samuel Iglesias Gonsálvez wrote: Signed-off-by: Samuel Iglesias Gonsálvez Can you also update the comment? I can't quite match what the comment says to what the code does. I think it should be something like: "They might mismatch due to the two

Re: [Mesa-dev] [PATCH 1/5] xlib: remove empty GLX_NV_vertex_array_range stubs

2017-11-30 Thread Emil Velikov
On 29 November 2017 at 20:41, Adam Jackson wrote: > On Wed, 2017-11-29 at 19:23 +, Emil Velikov wrote: >> From: Emil Velikov >> >> The extension was never implemented and seemingly never will. >> The DRI based libGL dropped support for it over 10

Re: [Mesa-dev] [PATCH] intel/blorp: Fix possible NULL pointer dereferencing

2017-11-30 Thread Andres Gomez
On Wed, 2017-11-29 at 17:53 +0200, Vadym Shovkoplias wrote: > Hi Andres, > > Thanks for the review! > I'm not familiar with Mesa workflow so far so I'll appreciate any > help in pushing this patch. You are welcome ... ... and pushed ☺ -- Br, Andres

Re: [Mesa-dev] [PATCH 1/7] gallium: Refactor out vl_put_screen and vl_get_screen

2017-11-30 Thread Leo Liu
On 11/30/2017 06:22 AM, Julien Isorce wrote: Hi Gurkirpal, > Before refactoring process both the state trackers were in independent directories. > During earlier refactoring effort we decided to keep that directory structure so it made > sense to move them to auxiliary code. After that I

Re: [Mesa-dev] [PATCH] Android: disable warnings causing errors

2017-11-30 Thread Emil Velikov
On 29 November 2017 at 18:12, Rob Herring wrote: > On Wed, Nov 29, 2017 at 11:01 AM, Emil Velikov > wrote: >> On 27 November 2017 at 19:36, Rob Herring wrote: >>> AOSP master has changed the build default to -Werror making all the >>>

[Mesa-dev] [Bug 101614] OSMesa 17.1.3 simd16intrin build FAIL on Win/MinGW - 'expected initializer before _simd16_setzero_ps ...'

2017-11-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101614 Bruce Cherniak changed: What|Removed |Added Assignee|mesa-dev@lists.freedesktop.

[Mesa-dev] [Bug 103732] [swr] often gets stuck in piglit's glx-multi-context-single-window test

2017-11-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103732 --- Comment #12 from Bruce Cherniak --- > I've just did it [1] but for future patches check the instructions[2]. > Feel free to send patches if you think the instructions could be improved ;-) Much thanks Emil!

[Mesa-dev] [Bug 103732] [swr] often gets stuck in piglit's glx-multi-context-single-window test

2017-11-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103732 --- Comment #11 from Emil Velikov --- > Yes, I do believe this is a good candidate for picking to the 17.2 stable > queue. What do I need to do to enable that? > I've just did it [1] but for future patches check the

[Mesa-dev] [PATCH 2/2] radv: remove set but unnecessary radv_color_buffer_info::micro_tile_mode

2017-11-30 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_device.c | 1 - src/amd/vulkan/radv_private.h | 1 - 2 files changed, 2 deletions(-) diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c index 336cb125a0..62591c7e3d 100644 ---

[Mesa-dev] [PATCH 1/2] radv: do not store gfx9_epitch in radv_color_buffer_info

2017-11-30 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 7 --- src/amd/vulkan/radv_device.c | 3 --- src/amd/vulkan/radv_private.h| 1 - 3 files changed, 4 insertions(+), 7 deletions(-) diff --git a/src/amd/vulkan/radv_cmd_buffer.c

[Mesa-dev] [PATCH mesa] u_debug: do not compile asserts when they are disabled

2017-11-30 Thread Eric Engestrom
Commit f0ba7d897d1c22202531a added this code to expose asserts to the compiler in an attempt to hide 'unused variable' warnings, incorrectly claiming it was a no-op. This has two bad effects: - any assert with side-effects are executed when they should be disabled - the whole content of the

Re: [Mesa-dev] [PATCH mesa 16/16] util: use NDEBUG to guard asserts

2017-11-30 Thread Eric Engestrom
On Tuesday, 2017-11-28 20:19:46 +0100, Gert Wollny wrote: > Am Dienstag, den 28.11.2017, 10:53 + schrieb Eric Engestrom: > > > > > The parameters to a preprocessor macro are (basically) just > > > text.  They are not evaluated until after the macro is > > > expanded.  I'm 93.2% sure removing

Re: [Mesa-dev] [RFC] r600/evergreen compute shader + glsl 4.30 support

2017-11-30 Thread Gert Wollny
Am Donnerstag, den 30.11.2017, 17:56 +1000 schrieb Dave Airlie: > On 30 November 2017 at 17:20, Gert Wollny > wrote: > > Am Donnerstag, den 30.11.2017, 09:30 +1000 schrieb Dave Airlie: > > > On 29 November 2017 at 22:46, Gert Wollny > > > wrote: > > >

Re: [Mesa-dev] Refactored st/omx/tizonia commits

2017-11-30 Thread Eric Engestrom
On Wednesday, 2017-11-29 16:23:26 -0800, Dylan Baker wrote: > Quoting Eric Engestrom (2017-11-29 07:19:02) > > On Wednesday, 2017-11-29 09:32:09 +0530, Gurkirpal Singh wrote: > > > These are the refactored commits related to the GSoC project involving > > > adding a st/omx state tracker using

[Mesa-dev] [PATCH v2] i965: Capture INTEL_DEBUG alongside the hanging batch

2017-11-30 Thread Chris Wilson
Similar to how we create a growing state buffer to live alongside the batch buffer, also create a debug buffer that is submitted and recreated on every batch. This allows us to emit debugging information about this batch that will be captured alongside the hanging batch for aide in post-mortem

Re: [Mesa-dev] Refactored st/omx/tizonia commits

2017-11-30 Thread Julien Isorce
Hi Gurkirpal, I am glad to see you continue working on this out of the GSoC project. I have reviewed it already during that period so just giving my official "the series is:" Reviewed-by: Julien Isorce On 30 November 2017 at 00:23, Dylan Baker

[Mesa-dev] [Bug 97852] Unreal Engine corrupted preview viewport

2017-11-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97852 Tapani Pälli changed: What|Removed |Added Resolution|--- |FIXED

Re: [Mesa-dev] [PATCH 1/7] gallium: Refactor out vl_put_screen and vl_get_screen

2017-11-30 Thread Julien Isorce
Hi Gurkirpal, > Before refactoring process both the state trackers were in independent directories. > During earlier refactoring effort we decided to keep that directory structure so it made > sense to move them to auxiliary code. After that I moved them both under st/omx. > Since there could be

Re: [Mesa-dev] GBM and the Device Memory Allocator Proposals

2017-11-30 Thread Nicolai Hähnle
On 30.11.2017 07:28, James Jones wrote: This is all a really long-winded way of saying yeah I think it would be technically feasible to implement GBM on top of the generic allocator mechanisms, but I don't think that's a very interesting undertaking. It'd just be an ABI-compatibility thing for

Re: [Mesa-dev] [PATCH] intel/isl: Declare private array as static const

2017-11-30 Thread Kenneth Graunke
On Wednesday, November 29, 2017 11:10:48 AM PST Chad Versace wrote: > It's array isl_drm.c:modifier_info[] . > --- > src/intel/isl/isl_drm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/intel/isl/isl_drm.c b/src/intel/isl/isl_drm.c > index eb3c6f59138..31895e15e16

Re: [Mesa-dev] [PATCH v2] mesa: add AllowGLSLCrossStageInterpolationMismatch workaround

2017-11-30 Thread Kenneth Graunke
On Thursday, November 23, 2017 9:46:07 PM PST Tapani Pälli wrote: > This fixes issues seen with certain versions of Unreal Engine 4 editor > and games built with that using GLSL 4.30. > > v2: add driinfo_gallium change (Emil Velikov) > > Signed-off-by: Tapani Pälli >

Re: [Mesa-dev] [PATCH v4 01/44] glsl: Add 16-bit types

2017-11-30 Thread Pohjolainen, Topi
On Thu, Nov 30, 2017 at 03:07:45AM +0100, Jose Maria Casanova Crespo wrote: > From: Eduardo Lima Mitev Just a few style nits, see below. > > Adds new INT16, UINT16 and FLOAT16 base types. > > The corresponding GL types for half floats were reused from the >

Re: [Mesa-dev] GBM and the Device Memory Allocator Proposals

2017-11-30 Thread Nicolai Hähnle
On 30.11.2017 01:09, Miguel Angel Vico wrote: It seems to me that $new_thing should grow as a separate thing whether it ends up replacing GBM or GBM internals are somewhat rewritten on top of it. If I'm reading you both correctly, you agree with that, so in order to move forward, should we go

Re: [Mesa-dev] [PATCH 00/14] meson: most of gallium

2017-11-30 Thread Marc Dietrich
Hi Dylan, Am Mittwoch, 29. November 2017, 19:14:37 CET schrieb Dylan Baker: > Quoting Marc Dietrich (2017-11-29 04:31:07) > > > Hi Dylan, > > > > Am Mittwoch, 29. November 2017, 00:30:21 CET schrieb Dylan Baker: > > > This series is the gallium media state trackers, the "nine" Direct3D > > >

Re: [Mesa-dev] [PATCH 09/29] anv/cmd_buffer: Generalize transition_color_buffer

2017-11-30 Thread Pohjolainen, Topi
On Mon, Nov 27, 2017 at 07:05:59PM -0800, Jason Ekstrand wrote: > This moves it to being based on layout_to_aux_usage instead of being > hard-coded based on bits of a priori knowledge of how transitions > interact with layouts. This conceptually simplifies things because > we're now using

<    1   2