Re: [Mesa-dev] [PATCH] RFC: Workaround for gen9 hw astc5x5 sampler bug

Hi, The patch series I have submitted handles the case of needing to resolve texture surfaces when a draw (or compute) accesses a texture which is astc5x5. As it is quite clear you understand the issue and know the code of i965 the patch centers on, you are an excellent person to review the

Re: [Mesa-dev] [PATCH v4 22/25] mesa/glspirv: Create gl_linked_shader objects for a SPIR-V program

On 04/12/17 20:21, Eduardo Lima Mitev wrote: v2: Bail out if we see more that one shader for the same stage, and add a corresponding comment. (Timothy Arceri) v3: Adds also a linker error log to the condition above. (Timothy Arceri) --- src/mesa/main/glspirv.c | 64

Re: [Mesa-dev] [PATCH v4 00/44] anv: SPV_KHR_16bit_storage/VK_KHR_16bit_storage for gen8+

A couple of notes: 1) I *think* I gave you enough reviews to land the UBO/SSBO part and the optimizations in 26-28. If reviews are still missing anywhere, please let me know. If not, let's try and get that part landed. 2) I send out a patch to rewrite assign_constant_locations which I think

Re: [Mesa-dev] [PATCH v3 24/25] i965: Call spirv_to_nir() instead of glsl_to_nir() for SPIR-V shaders

Reviewed-by: Timothy Arceri On 04/12/17 20:21, Eduardo Lima Mitev wrote: This is the main fork of the shader compilation code-path, where a NIR shader is obtained by calling spirv_to_nir() or glsl_to_nir(), depending on its nature.. v2: Use 'spirv_data' member from

Re: [Mesa-dev] [PATCH 6/6] anv: Enable UBO pushing

On Mon, Dec 4, 2017 at 9:07 PM, Jason Ekstrand wrote: > On Mon, Dec 4, 2017 at 8:53 PM, Jordan Justen > wrote: > >> On 2017-12-01 17:20:09, Jason Ekstrand wrote: >> > --- >> > src/intel/vulkan/anv_device.c | 1 + >> >

Re: [Mesa-dev] [PATCH 6/6] anv: Enable UBO pushing

On Mon, Dec 4, 2017 at 8:53 PM, Jordan Justen wrote: > On 2017-12-01 17:20:09, Jason Ekstrand wrote: > > --- > > src/intel/vulkan/anv_device.c | 1 + > > src/intel/vulkan/anv_pipeline.c | 6 ++ > > 2 files changed, 7 insertions(+) > > > > diff --git

Re: [Mesa-dev] V3 i965/Gallium ARB_get_program_binary support

Ping! The outstanding patches for review are: 4, 12, 22, 23 Gallium specific patches: 17-21 The following have a v1 r-b Nicolai but have changed since: 13, 14, 15 Branch available here: https://github.com/tarceri/Mesa.git gallium-program-binary On 29/11/17 12:24, Timothy Arceri wrote:

Re: [Mesa-dev] [PATCH 6/6] anv: Enable UBO pushing

On 2017-12-01 17:20:09, Jason Ekstrand wrote: > --- > src/intel/vulkan/anv_device.c | 1 + > src/intel/vulkan/anv_pipeline.c | 6 ++ > 2 files changed, 7 insertions(+) > > diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c > index 937efb9..43781bd 100644 > ---

[Mesa-dev] [Bug 104084] Vulkan doesnt work at all

https://bugs.freedesktop.org/show_bug.cgi?id=104084 Timothy Arceri changed: What|Removed |Added Resolution|--- |NOTABUG

[Mesa-dev] [PATCH v2] st/mesa: swizzle argument when there's a vector size mismatch

GLSL IR operation arguments can sometimes have an implicit swizzle as a result of a vector arg and a scalar arg, where the scalar argument is implicitly expanded to the size of the vector argument. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103955 Signed-off-by: Ilia Mirkin

[Mesa-dev] [Bug 104084] Vulkan doesnt work at all

https://bugs.freedesktop.org/show_bug.cgi?id=104084 --- Comment #4 from gamedev1...@gmail.com --- Thanks it worked but the entire thing was a bit silly just for vulkan maybe Mesa can add a better way Sent from my iPhone > On Dec 4, 2017, at 7:37 PM, bugzilla-dae...@freedesktop.org wrote: > >

Re: [Mesa-dev] screen blurred and glxgears segment fault on ubuntu17.10 for arm architecture server with amdgpu(AMD RADEON PRO WX7100)

Thanks for your reply. The attachment is the Xorg log. If you need other information, pls let me know. Thanks. -邮件原件- 发件人: Michel Dänzer [mailto:mic...@daenzer.net] 发送时间: 2017年12月5日 1:02 收件人: Lvzhihong (ReJohn) 抄送: mesa-dev@lists.freedesktop.org; Liuchen

[Mesa-dev] [Bug 103955] Using array in structure results in wrong GLSL compilation output

https://bugs.freedesktop.org/show_bug.cgi?id=103955 --- Comment #9 from Younghun Jang --- (In reply to Ilia Mirkin from comment #8) > This patch fixes the sample case for me: > > https://patchwork.freedesktop.org/patch/191532/ I concur. The patch fixes the bug. And I

Re: [Mesa-dev] [PATCH] Android: enable noreturn and returns_nonnull attributes

Reviewed-by: Jason Ekstrand On Mon, Dec 4, 2017 at 6:21 PM, Rob Herring wrote: > Commit 94ca8e04adf6 ("spirv: Add vtn_fail and vtn_assert helpers") broke > Android builds which have -Werror enabled with the following errors: > >

[Mesa-dev] [PATCH] Android: enable noreturn and returns_nonnull attributes

Commit 94ca8e04adf6 ("spirv: Add vtn_fail and vtn_assert helpers") broke Android builds which have -Werror enabled with the following errors: external/mesa3d/src/compiler/spirv/spirv_to_nir.c:272:1: error: control may reach end of non-void function [-Werror,-Wreturn-type]

Re: [Mesa-dev] Please implement the vaapi-egl for vaapi hardware decoding, vdpau can't handle HEVC 10bit video.

On 04/12/17 16:33, Leo Liu wrote: > On 12/04/2017 04:32 AM, Emil Velikov wrote: >> On 2 December 2017 at 15:26, Julian Lai wrote: >>> Since the crappy vaapi-glx was dropped off by mpv-git player, there is no >>> way to play HEVC 10bit video with zero-copy hardware

Re: [Mesa-dev] [PATCH v4 20/44] i965/fs: Add byte scattered read message and fs support

On Mon, Dec 4, 2017 at 4:50 PM, Chema Casanova wrote: > On 30/11/17 21:45, Jason Ekstrand wrote: > > On Wed, Nov 29, 2017 at 6:50 PM, Jose Maria Casanova Crespo > > > wrote: > > > > v2: Fix alignment style (Topi

Re: [Mesa-dev] [PATCH 0/6] anv: Add support for pushing ranges of UBOs

On Fri, Dec 1, 2017 at 5:20 PM, Jason Ekstrand wrote: > We've had this optimization in the GL driver since July but never got > around to hooking it up in Vulkan. This lets us turn UBOs into push > constants which are significantly faster since they read the UBO data >

Re: [Mesa-dev] [PATCH v4 20/44] i965/fs: Add byte scattered read message and fs support

On 30/11/17 21:45, Jason Ekstrand wrote: > On Wed, Nov 29, 2017 at 6:50 PM, Jose Maria Casanova Crespo > > wrote: > > v2: Fix alignment style (Topi Pohjolainen) >     (Jason Ekstrand) >     - Enable bit_size parameter to scattered

Re: [Mesa-dev] [PATCH 01/29] intel/isl: Codify AUX operations in an enum

On Mon, Nov 27, 2017 at 07:05:51PM -0800, Jason Ekstrand wrote: > Right now, we have different entrypoints and enums in blorp for these > different operations. This provides us a central enum which we can > begin to transition to. > --- > src/intel/isl/isl.h | 74 >

Re: [Mesa-dev] [PATCH 2/3] st/va: use designated initialisers for VA driver functions

On 04/12/17 20:52, Leo Liu wrote: > Signed-off-by: Leo Liu > --- > src/gallium/state_trackers/va/context.c | 99 > - > 1 file changed, 49 insertions(+), 50 deletions(-) > > diff --git a/src/gallium/state_trackers/va/context.c >

Re: [Mesa-dev] [PATCH 3/8] glapi/check_table: Remove 'extern "C"' block

Quoting Emil Velikov (2017-11-23 11:04:34) > On 20 November 2017 at 23:12, Dylan Baker wrote: > > This doesn't actually accomplish what it's meant to do, as extern C > > doesn't undefine __cplusplus, so the included headers define a template > > (because __cplusplus is

Re: [Mesa-dev] Fwd: errors for mesa master Android build 1698

On Mon, Dec 4, 2017 at 3:12 PM, Rob Herring wrote: > Looks like Jason is the actual culprit here. Unfortunately, the build > can't keep up with every commit. Looks to me like these should be > fixed. > The problem is that you need to define HAVE_FUNC_ATTRIBUTE_NORETURN > I

[Mesa-dev] [PATCH] nvir: Always split 64-bit IMAD/IMUL operations

Those operations do not map to actual hardware instructions, therefore those should always be lowered to 32-bit instructions. Fixes: 009c54aa7af "nv50/ir: Split 64-bit integer MAD/MUL operations" Signed-off-by: Pierre Moreau ---

[Mesa-dev] [Bug 104084] Vulkan doesnt work at all

https://bugs.freedesktop.org/show_bug.cgi?id=104084 --- Comment #3 from Dylan Baker --- The archwiki has good documentation on this here: https://wiki.archlinux.org/index.php/AMDGPU#Enable_Southern_Islands_.28SI.29_and_Sea_Islands_.28CIK.29_support Basically the

[Mesa-dev] Fwd: errors for mesa master Android build 1698

Looks like Jason is the actual culprit here. Unfortunately, the build can't keep up with every commit. Looks to me like these should be fixed. I wonder how long until I give up and just set Android back to -Wno-error... Rob -- Forwarded message -- From:

[Mesa-dev] [PATCH] libdrm: Fix QNX build by including 'sys/ioctl.h'

drm.h header includes 'sys/ioccom.h' for ioctl definitions on non-linux Unix platforms, but QNX seems to define those in 'sys/ioctl.h' instead. Signed-off-by: Miguel A Vico Moya --- include/drm/drm.h | 5 + 1 file changed, 5 insertions(+) diff --git

Re: [Mesa-dev] [PATCH 00/14] meson: most of gallium

Quoting Eric Engestrom (2017-12-04 07:38:04) > On Thursday, 2017-11-30 10:34:06 -0800, Dylan Baker wrote: > > Quoting Eric Engestrom (2017-11-29 07:44:08) > > > On Tuesday, 2017-11-28 15:30:21 -0800, Dylan Baker wrote: > > > > This series is the gallium media state trackers, the "nine" Direct3D >

Re: [Mesa-dev] [PATCH] i965/cnl: Avoid fast-clearing sRGB render buffers

On Fri, Dec 01, 2017 at 04:42:22PM -0800, Jason Ekstrand wrote: > On Fri, Dec 1, 2017 at 2:44 PM, Nanley Chery wrote: > > > Gen10 doesn't automatically decode the clear color of sRGB buffers. To > > get correct rendering, avoid fast-clearing such buffers for now. > > > >

[Mesa-dev] [Bug 104084] Vulkan doesnt work at all

https://bugs.freedesktop.org/show_bug.cgi?id=104084 --- Comment #2 from gamedev1...@gmail.com --- I’m very confused since when do we need a special kernel loaded to use vulkan that seems a bit silly doesn’t it anyway to get this kernel loaded what should I do on arch Sent from my iPhone >

[Mesa-dev] [PATCH] meson: Add lmsensors to gallium libgl-xlib target.

Fixes: 5e71efef44b992b5d70b ("meson: Add lmsensors support") Signed-off-by: Dylan Baker --- src/gallium/targets/libgl-xlib/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/targets/libgl-xlib/meson.build

[Mesa-dev] [Bug 104084] Vulkan doesnt work at all

https://bugs.freedesktop.org/show_bug.cgi?id=104084 Bas Nieuwenhuizen changed: What|Removed |Added Component|Other

[Mesa-dev] [PATCH 2/3] st/va: use designated initialisers for VA driver functions

Signed-off-by: Leo Liu --- src/gallium/state_trackers/va/context.c | 99 - 1 file changed, 49 insertions(+), 50 deletions(-) diff --git a/src/gallium/state_trackers/va/context.c b/src/gallium/state_trackers/va/context.c index

[Mesa-dev] [PATCH 3/3] st/va: Enable vaExportSurfaceHandle()

From: Mark Thompson It will be present from libva 2.1 (VAAPI 1.1.0 or higher). v2: rebase to previous patches(Leo) Signed-off-by: Mark Thompson Signed-off-by: Leo Liu --- src/gallium/state_trackers/va/context.c | 2 +-

[Mesa-dev] [PATCH 1/3] st/va: rename vlVaSubpictureImage to vlVaSetSubpictureImage

Following VA spec Signed-off-by: Leo Liu --- src/gallium/state_trackers/va/context.c| 2 +- src/gallium/state_trackers/va/subpicture.c | 2 +- src/gallium/state_trackers/va/va_private.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git

Re: [Mesa-dev] [PATCH 1/9] compiler: Add new system value SYSTEM_VALUE_BASE_VERTEX_ID

Hi, On 30/11/17 21:43, Neil Roberts wrote: Kenneth Graunke writes: We have a number of similar names now: SYSTEM_VALUE_BASE_VERTEX SYSTEM_VALUE_BASE_VERTEX_ID SYSTEM_VALUE_VERTEX_ID SYSTEM_VALUE_VERTEX_ID_ZERO_BASE BASE_VERTEX and BASE_VERTEX_ID are

[Mesa-dev] [PATCH v2 1/7] compiler: Add SYSTEM_VALUE_FIRST_VERTEX and instrinsics

This VS system value will contain the value passed as for indexed draw calls or the value passed as for non-indexed draw calls. It will be used to calculate the gl_VertexID as SYSTEM_VALUE_VERTEX_ID_ZERO_BASE plus SYSTEM_VALUE_FIRST_VERTEX. Note that the current calculation which uses

[Mesa-dev] [PATCH v2 4/7] i965: Let nir lower gl_VertexID instead of the linker

From: Neil Roberts --- src/mesa/drivers/dri/i965/brw_context.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_context.c b/src/mesa/drivers/dri/i965/brw_context.c index b62852d90c8..249f62847b9 100644 ---

[Mesa-dev] [PATCH v2 5/7] nir: Offset vertex_id by first_vertex instead of base_vertex

From: Neil Roberts base_vertex will be zero for non-indexed calls, but we need it to include the ‘first’ parameter. This is true for both GL and Vulkan. I think this patch will also affect freedreno and radeonsi. I believe if they are relying on this lowering then they are

[Mesa-dev] [PATCH v2 7/7] i965: gl_BaseVertex must be zero for non-indexed draw calls

- From the OpenGL 4.6 (11.1.3.9 Shader Inputs) specification: "gl_BaseVertex holds the integer value passed to the baseVertex parameter to the command that resulted in the current shader invocation. In the case where the command has no baseVertex parameter, the value of gl_BaseVertex is zero." -

[Mesa-dev] [PATCH v2 6/7] spirv: Lower BaseVertex to FIRST_VERTEX instead of BASE_VERTEX

From: Neil Roberts The base vertex in Vulkan is different from GL in that for non-indexed primitives the value is taken from the firstVertex parameter instead of being set to zero. This coincides with the new SYSTEM_VALUE_FIRST_VERTEX instead of BASE_VERTEX. ---

[Mesa-dev] [PATCH v2 3/7] intel: emit first_vertex and reorder the VE' components

The new order is: * VE 1: * VE 2: Previously it was: * VE 1: * VE 2: The gl_BaseVertex is in a new location now, and firstvertex occupies the old gl_BaseVertex place. This way we can keep

[Mesa-dev] [PATCH v2 2/7] intel/compiler: Add a uses_firstvertex flag

From: Neil Roberts Reviewed-by: Kenneth Graunke --- src/intel/compiler/brw_compiler.h | 1 + src/intel/compiler/brw_vec4.cpp | 4 2 files changed, 5 insertions(+) diff --git a/src/intel/compiler/brw_compiler.h

[Mesa-dev] [PATCH v2 0/7] Fix shader_draw_parameters CTS tests

This patch series is a v2 of the one we sent some weeks ago to fix gl_BaseVertex in i965. The original patch series can be found on here: https://patchwork.freedesktop.org/series/33623/ * Rationale: gl_BaseVertex must be zero for non-indexed draw comands. However, for this kind of draw comands,

Re: [Mesa-dev] [PATCH] radeon/vcn: determine idr by pic type

> Am 30.11.2017 um 22:18 schrieb Leo Liu: >> >> >> On 11/30/2017 04:12 PM, boyuan.zh...@amd.com wrote: >>> From: Boyuan Zhang >>> >>> Vaapi encode interface provides idr frame flags, where omx interface >>> doesn't. >>> Therefore, change to use picture type to determine idr

Re: [Mesa-dev] [PATCH] st/mesa: swizzle argument when there's a vector size mismatch

Yeah, the typo was a last second edit, as always. Thanks for making a sample failing case, will investigate. I hate all these interpolateat tests :( so many edge cases... On Dec 4, 2017 2:51 PM, "Marek Olšák" wrote: > There is a typo, so it doesn't build. > > It breaks these

Re: [Mesa-dev] [PATCH] st/mesa: swizzle argument when there's a vector size mismatch

There is a typo, so it doesn't build. It breaks these CTS tests: gl45-cts@shader_multisample_interpolation@render@interpolate_at_offset* Error: state_tracker/st_glsl_to_tgsi.cpp:1347: void glsl_to_tgsi_visitor::visit_expression(ir_expression*, st_src_reg*): Assertion

[Mesa-dev] [Bug 104084] Vulkan doesnt work at all

https://bugs.freedesktop.org/show_bug.cgi?id=104084 Bug ID: 104084 Summary: Vulkan doesnt work at all Product: Mesa Version: 17.2 Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW Severity: major

Re: [Mesa-dev] [PATCH 09/22] mesa: Add GL_RGBA + GL_UNSIGNED_INT_2_10_10_10_REV for OES read type.

On 04.12.2017 20:45, Marek Olšák wrote: Do we need to handle B10G10R10X2 as well? Good catch, that is missing indeed. Also noticed that dEQP wide color test does not test BGRX. Marek On Wed, Nov 29, 2017 at 5:20 AM, Mario Kleiner wrote: This format + type

Re: [Mesa-dev] [PATCH 22/22] st/dri: Add option to control exposure of 10 bpc color configs.

For patches 4-5, 7, 9-19, 21-22: Reviewed-by: Marek Olšák Marek On Wed, Nov 29, 2017 at 5:21 AM, Mario Kleiner wrote: > Some clients may not like rgb10 fbconfigs and visuals. > Support driconf option 'allow_rgb10_configs' on gallium > to allow

Re: [Mesa-dev] [PATCH 09/22] mesa: Add GL_RGBA + GL_UNSIGNED_INT_2_10_10_10_REV for OES read type.

Do we need to handle B10G10R10X2 as well? Marek On Wed, Nov 29, 2017 at 5:20 AM, Mario Kleiner wrote: > This format + type combo is good for BGRA1010102 framebuffers > for use with glReadPixels() under GLES, so add it for the > GL_IMPLEMENTATION_COLOR_READ_TYPE_OES

Re: [Mesa-dev] [PATCH 2/3] meson: fix underlinkage without dri3

Quoting Emil Velikov (2017-12-04 09:28:19) > On 1 December 2017 at 23:06, Dylan Baker wrote: > > There are some case where the dri3 loader is covering for underlinkage > > for GLX and EGL, provide the linkage that they actually need. > > > > Signed-off-by: Dylan Baker

Re: [Mesa-dev] [PATCH 2/3] meson: Add lmsensors support

On 4 December 2017 at 18:25, Dylan Baker wrote: > Quoting Emil Velikov (2017-12-04 10:14:15) >> On 4 December 2017 at 18:06, Dylan Baker wrote: >> > Quoting Emil Velikov (2017-12-04 05:20:03) >> >> On 29 November 2017 at 00:56, Dylan Baker

Re: [Mesa-dev] [PATCH v2] radv: fix a crash in radv_can_dump_shader()

Reviewed-by: Bas Nieuwenhuizen On Mon, Dec 4, 2017 at 3:32 PM, Samuel Pitoiset wrote: > module can be NULL, oops. > > v2: really check that module is not NULL > > Signed-off-by: Samuel Pitoiset > --- >

Re: [Mesa-dev] [PATCH 2/3] meson: Add lmsensors support

Quoting Emil Velikov (2017-12-04 10:14:15) > On 4 December 2017 at 18:06, Dylan Baker wrote: > > Quoting Emil Velikov (2017-12-04 05:20:03) > >> On 29 November 2017 at 00:56, Dylan Baker wrote: > >> > Signed-off-by: Dylan Baker

[Mesa-dev] [PATCH v2] egl/android: Partially handle HAL_PIXEL_FORMAT_IMPLEMENTATION_DEFINED

From: Tomasz Figa There is no API available to properly query the IMPLEMENTATION_DEFINED format. As a workaround we rely here on gralloc allocating either an arbitrary YCbCr 4:2:0 or RGBX_, with the latter being recognized by lock_ycbcr failing. Reviewed-on:

Re: [Mesa-dev] Please implement the vaapi-egl for vaapi hardware decoding, vdpau can't handle HEVC 10bit video.

On 12/04/2017 12:47 PM, Emil Velikov wrote: On 4 December 2017 at 16:33, Leo Liu wrote: On 12/04/2017 04:32 AM, Emil Velikov wrote: On 2 December 2017 at 15:26, Julian Lai wrote: Since the crappy vaapi-glx was dropped off by mpv-git player, there

Re: [Mesa-dev] [PATCH 2/3] meson: Add lmsensors support

On 4 December 2017 at 18:06, Dylan Baker wrote: > Quoting Emil Velikov (2017-12-04 05:20:03) >> On 29 November 2017 at 00:56, Dylan Baker wrote: >> > Signed-off-by: Dylan Baker >> > --- >> > meson.build

Re: [Mesa-dev] [PATCH mesa] meson: fix pl111 dependency on vc4

Quoting Eric Engestrom (2017-12-04 07:08:01) > src/gallium/winsys/pl111/drm/libpl111winsys.a(pl111_drm_winsys.c.o): In > function `pl111_drm_screen_create': > pl111_drm_winsys.c:(.text+0x33): undefined reference to > `vc4_drm_screen_create_renderonly' > > Signed-off-by: Eric Engestrom

Re: [Mesa-dev] [PATCH] freedreno: add -Wno-packed-bitfield-compat for meson build

Reviewed-by: Dylan Baker Quoting Rob Clark (2017-12-04 05:44:59) > Otherwise huge amount of spam from instr-a2xx.h.. gcc has no way to know > that freedreno was never built with such an old gcc version to care > about the bugs in old gcc ;-) > > Patch is really Eric

Re: [Mesa-dev] [PATCH 2/3] meson: Add lmsensors support

Quoting Emil Velikov (2017-12-04 05:20:03) > On 29 November 2017 at 00:56, Dylan Baker wrote: > > Signed-off-by: Dylan Baker > > --- > > meson.build | 11 +++ > > meson_options.txt | 7

Re: [Mesa-dev] Please implement the vaapi-egl for vaapi hardware decoding, vdpau can't handle HEVC 10bit video.

On 12/04/2017 04:32 AM, Emil Velikov wrote: On 2 December 2017 at 15:26, Julian Lai wrote: Since the crappy vaapi-glx was dropped off by mpv-git player, there is no way to play HEVC 10bit video with zero-copy hardware acceleration, vdpau can't do it either, please

Re: [Mesa-dev] Please implement the vaapi-egl for vaapi hardware decoding, vdpau can't handle HEVC 10bit video.

On 4 December 2017 at 16:33, Leo Liu wrote: > > > On 12/04/2017 04:32 AM, Emil Velikov wrote: >> >> On 2 December 2017 at 15:26, Julian Lai wrote: >>> >>> Since the crappy vaapi-glx was dropped off by mpv-git player, there is no >>> way to play HEVC 10bit

Re: [Mesa-dev] [PATCH] meson: Install dri.pc file when building gallium dri drivers

On 1 December 2017 at 22:03, Dylan Baker wrote: > Currently this pkg-config file is only installed if a classic dri driver > is built. This is wrong, it should be installed if any dri driver is > installed, which includes the gallium dri target. > > Reported-by: Marc Dietrich

Re: [Mesa-dev] [PATCH 0/3] anv/i965: account timestamp correctly on Gen10

This series is Reviewed-by: Rafael Antognolli On Mon, Dec 04, 2017 at 04:21:26PM +, Lionel Landwerlin wrote: > Hi all, > > We've had some timestamp related issues on Gen10. Those are mostly > related to the fact that the frequency of the timestamps is variable

Re: [Mesa-dev] [PATCH 2/3] meson: fix underlinkage without dri3

On 1 December 2017 at 23:06, Dylan Baker wrote: > There are some case where the dri3 loader is covering for underlinkage > for GLX and EGL, provide the linkage that they actually need. > > Signed-off-by: Dylan Baker > --- > src/egl/meson.build | 2

Re: [Mesa-dev] [PATCH 3/3] meson: Fix overlinkage of dri3 loader

On 1 December 2017 at 23:06, Dylan Baker wrote: > This was covering for underinkage elsewhere. With that fixed these can > be removed. > > Signed-off-by: Dylan Baker > --- > src/loader/meson.build | 3 +-- > 1 file changed, 1 insertion(+), 2

[Mesa-dev] [PATCH 1/2] gallium/util: add u_transfer_helper

Add a new helper that drivers can use to emulate various things that need special handling in particular in transfer_map: 1) z32_s8x24.. gl/gallium treats this as a single buffer with depth and stencil interleaved but hardware frequently treats this as separate z32 and s8 buffers.

[Mesa-dev] [PATCH 2/2] freedreno: use u_transfer_helper

Signed-off-by: Rob Clark --- src/gallium/drivers/freedreno/freedreno_resource.c | 271 - src/gallium/drivers/freedreno/freedreno_resource.h | 2 +- 2 files changed, 44 insertions(+), 229 deletions(-) diff --git

Re: [Mesa-dev] screen blurred and glxgears segment fault on ubuntu17.10 for arm architecture server with amdgpu(AMD RADEON PRO WX7100)

On 2017-12-04 03:49 AM, Lvzhihong (ReJohn) wrote: > Hi,all, > > We met a problem on ubuntu17.10 for arm server with amdgpu(AMD > RADEON PRO WX7100),  we use open source driver which are integrated in > ubuntu17.10. And the architecture is AArch64-linux-gnu. > >   > > we

Re: [Mesa-dev] [PATCH v4 15/44] i965/fs: Define new shader opcode to set rounding modes

El 01/12/17 a las 09:06, Pohjolainen, Topi escribió: > On Thu, Nov 30, 2017 at 03:07:59AM +0100, Jose Maria Casanova Crespo wrote: >> From: Alejandro Piñeiro >> >> Although it is possible to emit them directly as AND/OR on brw_fs_nir, >> having a specific opcode makes it

Re: [Mesa-dev] [PATCH] egl/x11: Remove unneeded free() on always null string

On Monday, 2017-12-04 12:48:55 +0200, Vadim Shovkoplias wrote: > Hi Eric, Hey, sorry, I forgot to hit "send" on the reply I wrote on friday :] > > Mostly by a static analysis tool. It found at least 7 issues with useless > free() calls and other problems that probably should be fixed. What

Re: [Mesa-dev] [PATCH v4 11/44] i965: Support for 16-bit base types in helper functions

El 01/12/17 a las 09:03, Pohjolainen, Topi escribió: > On Thu, Nov 30, 2017 at 03:07:55AM +0100, Jose Maria Casanova Crespo wrote: >> v2: Fixed calculation of scalar size for 16-bit types. (Jason Ekstrand) >> >> Signed-off-by: Jose Maria Casanova Crespo >> Signed-off-by:

[Mesa-dev] [PATCH] glsl/linker: link-error using the same name in unnamed block and outside

According with OpenGL GLSL 4.20 spec, section 4.3.9, page 57: "It is a link-time error if any particular shader interface contains: - two different blocks, each having no instance name, and each having a member of the same name, or - a variable outside a block, and a

[Mesa-dev] [PATCH 0/3] anv/i965: account timestamp correctly on Gen10

Hi all, We've had some timestamp related issues on Gen10. Those are mostly related to the fact that the frequency of the timestamps is variable depending on the part you get. There is no way to tell from the PCI-id, you can only get that information by reading a couple of registers. We

[Mesa-dev] [PATCH 2/3] i965: read CS timestamp frequency from the kernel on Gen10+

We cannot figure this value out of the PCI-id anymore. Let's read it from the kernel (which computes this from a few registers). When running on a (upcoming) 4.16-rc1+ kernel, this will fixes piglit tests on CNL : spec@arb_timer_query@query gl_timestamp spec@arb_timer_query@timestamp-get

[Mesa-dev] [PATCH 3/3] anv: query CS timestamp frequency from the kernel

The reference value in gen_device_info isn't going to be acurate on Gen10+. We should query it from the kernel, which reads a couple of register to compute the actual value. Signed-off-by: Lionel Landwerlin --- src/intel/vulkan/anv_device.c | 13 + 1

[Mesa-dev] [PATCH 1/3] drm-uapi: Update drm/i915 headers from drm-next

Taken from drm-next ca797d29cd63e7b71b4eea29aff3b1cefd1ecb59 Signed-off-by: Lionel Landwerlin --- include/drm-uapi/README | 8 +++--- include/drm-uapi/drm.h | 41 ++ include/drm-uapi/drm_mode.h | 70

Re: [Mesa-dev] [PATCH 3/3] nv50/ir: Fix unused var warnings in release build

On Saturday, 2017-12-02 13:28:04 -0500, Ilia Mirkin wrote: > On Sat, Dec 2, 2017 at 1:22 PM, Rhys Kidd wrote: > > Signed-off-by: Rhys Kidd > > --- > > src/gallium/drivers/nouveau/codegen/nv50_ir_emit_nv50.cpp | 2 +- > >

Re: [Mesa-dev] [PATCH v4 01/44] glsl: Add 16-bit types

El 30/11/17 a las 10:25, Pohjolainen, Topi escribió: > On Thu, Nov 30, 2017 at 03:07:45AM +0100, Jose Maria Casanova Crespo wrote: >> From: Eduardo Lima Mitev > Just a few style nits, see below. > >> Adds new INT16, UINT16 and FLOAT16 base types. >> >> The corresponding GL

Re: [Mesa-dev] [PATCH 0/3] Fix linkage for libEGL and libGLX without dri3

On Friday, 2017-12-01 15:06:17 -0800, Dylan Baker wrote: > As we discussed elsewhere, this should fix the linkage of the dri3 loader and > glx and egl. > > Dylan Baker (3): > meson: Reformat meson code to match more common style > meson: fix underlinkage without dri3 > meson: Fix

Re: [Mesa-dev] [PATCH] meson: Install dri.pc file when building gallium dri drivers

On Friday, 2017-12-01 14:03:16 -0800, Dylan Baker wrote: > Currently this pkg-config file is only installed if a classic dri driver > is built. This is wrong, it should be installed if any dri driver is > installed, which includes the gallium dri target. > > Reported-by: Marc Dietrich

Re: [Mesa-dev] [PATCH] Android: disable warnings causing errors

On Thursday, 2017-11-30 14:20:08 +, Emil Velikov wrote: > On 29 November 2017 at 18:12, Rob Herring wrote: > > On Wed, Nov 29, 2017 at 11:01 AM, Emil Velikov > > wrote: > >> On 27 November 2017 at 19:36, Rob Herring wrote: > >>>

Re: [Mesa-dev] [PATCH 00/14] meson: most of gallium

On Thursday, 2017-11-30 10:34:06 -0800, Dylan Baker wrote: > Quoting Eric Engestrom (2017-11-29 07:44:08) > > On Tuesday, 2017-11-28 15:30:21 -0800, Dylan Baker wrote: > > > This series is the gallium media state trackers, the "nine" Direct3D state > > > tracker, and an architectural change in the

Re: [Mesa-dev] [PATCH] Android: gallium/radeon: fix libmesa_amd_common dependency

Reviewed-by: Marek Olšák Marek On Sat, Dec 2, 2017 at 1:36 PM, Mauro Rossi wrote: > libmesa_amd_common static dependency is added in Android build > to avoid the following building errors: > > In file included from >

[Mesa-dev] [PATCH mesa] meson: fix pl111 dependency on vc4

src/gallium/winsys/pl111/drm/libpl111winsys.a(pl111_drm_winsys.c.o): In function `pl111_drm_screen_create': pl111_drm_winsys.c:(.text+0x33): undefined reference to `vc4_drm_screen_create_renderonly' Signed-off-by: Eric Engestrom --- meson.build

[Mesa-dev] [PATCH mesa] i915: add missing 0 defines

Thanks to Emil's -Wundef, t_dd_dmatmp.h now complains that intel_render.c is missing a couple `#define`s. Assigning them to 0 keeps the existing behaviour; I'll let someone else turn them on if this is the behaviour that was intended. Signed-off-by: Eric Engestrom ---

[Mesa-dev] [PATCH v2] radv: fix a crash in radv_can_dump_shader()

module can be NULL, oops. v2: really check that module is not NULL Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_shader.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/amd/vulkan/radv_shader.h b/src/amd/vulkan/radv_shader.h

Re: [Mesa-dev] [PATCH] freedreno: add -Wno-packed-bitfield-compat for meson build

On Monday, 2017-12-04 08:44:59 -0500, Rob Clark wrote: > Otherwise huge amount of spam from instr-a2xx.h.. gcc has no way to know > that freedreno was never built with such an old gcc version to care > about the bugs in old gcc ;-) > > Patch is really Eric Engestrom's, he showed me how to do this

Re: [Mesa-dev] [PATCH 1/7] gallium: Refactor out vl_put_screen and vl_get_screen

On 12/03/2017 10:04 AM, Gurkirpal Singh wrote: I sent the modified patches in another thread a while ago. Please review in case got missed. Please be patient for a few days to see if any other comments. After then please rebase, add rb/ab to your patches, and send them to me, I will commit

Re: [Mesa-dev] [PATCH mesa 02/16] anv: tie anv_assert() enablement to regular assert()

On 27 November 2017 at 18:40, Eric Engestrom wrote: > On Sunday, 2017-11-26 10:12:46 +1100, Timothy Arceri wrote: >> On 25/11/17 08:02, Timothy Arceri wrote: >> > On 25/11/17 05:07, Eric Engestrom wrote: >> > > Signed-off-by: Eric Engestrom

Re: [Mesa-dev] [PATCH 16/29] anv/cmd_buffer: Pass a subpass id into begin_subpass

On Mon, Nov 27, 2017 at 07:06:06PM -0800, Jason Ekstrand wrote: > This is a bit less awkward than passing in the subpass because it means > we don't have to extract the subpass id from the subpass. > --- > src/intel/vulkan/genX_cmd_buffer.c | 12 +--- > 1 file changed, 5 insertions(+), 7

Re: [Mesa-dev] [PATCH 15/29] anv/cmd_buffer: Add begin/end_subpass helpers

On Mon, Nov 27, 2017 at 07:06:05PM -0800, Jason Ekstrand wrote: > Having begin/end_subpass is a bit nicer than the begin/next/end hooks > that Vulkan gives us. > --- > src/intel/vulkan/genX_cmd_buffer.c | 55 > +- > 1 file changed, 31 insertions(+), 24

[Mesa-dev] [PATCH] freedreno: add -Wno-packed-bitfield-compat for meson build

Otherwise huge amount of spam from instr-a2xx.h.. gcc has no way to know that freedreno was never built with such an old gcc version to care about the bugs in old gcc ;-) Patch is really Eric Engestrom's, he showed me how to do this in meson. Cc: Eric Engestrom

Re: [Mesa-dev] [PATCH 2/3] meson: Add lmsensors support

On 29 November 2017 at 00:56, Dylan Baker wrote: > Signed-off-by: Dylan Baker > --- > meson.build | 11 +++ > meson_options.txt | 7 +++ > src/gallium/drivers/etnaviv/meson.build

Re: [Mesa-dev] [PATCH 7/8] gallium/u_upload_mgr: allow drivers to specify pipe_resource::flags

Patches 1 and 3-7: Reviewed-by: Nicolai Hähnle On 01.12.2017 21:19, Marek Olšák wrote: From: Marek Olšák --- src/gallium/auxiliary/util/u_upload_mgr.c| 9 ++--- src/gallium/auxiliary/util/u_upload_mgr.h| 2 +-

Re: [Mesa-dev] [PATCH 2/8] radeonsi: allow DMABUF exports for local buffers

On Dec 4, 2017 12:58 PM, "Nicolai Hähnle" wrote: On 01.12.2017 21:19, Marek Olšák wrote: > From: Marek Olšák > > Cc: 17.3 > What's the use-case for this? OpenCL interop. What if somebody exports as DMABUF, then

Re: [Mesa-dev] [PATCH 8/8] radeonsi: make const and stream uploaders allocate read-only memory

On 01.12.2017 21:19, Marek Olšák wrote: From: Marek Olšák and anything that clones these uploaders, like u_threaded_context. Bottom/top-of-pipe fences will have to be moved away from using the stream_uploader. --- src/gallium/drivers/radeon/r600_pipe_common.c | 6

Re: [Mesa-dev] [PATCH 2/8] radeonsi: allow DMABUF exports for local buffers

On 01.12.2017 21:19, Marek Olšák wrote: From: Marek Olšák Cc: 17.3 What's the use-case for this? What if somebody exports as DMABUF, then re-imports in a different API and exports as FD for inter-process sharing from there? ---

Re: [Mesa-dev] [PATCH] radeonsi: pass llvm type directly to buffer_load()

Reviewed-by: Nicolai Hähnle On 04.12.2017 05:17, Timothy Arceri wrote: --- src/gallium/drivers/radeonsi/si_shader.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c

  1   2   >