[Mesa-dev] [PATCH] vbo: remove MaxVertexAttribStride assert check.

2018-05-14 Thread Dave Airlie
From: Dave Airlie Some drivers (virgl) don't support GL4.4 or GLES3.1 yet, so never fill in this const. Signed-off-by: Dave Airlie --- src/mesa/vbo/vbo_exec_draw.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/mesa/vbo/vbo_exec_draw.c

[Mesa-dev] [Bug 106209] [opencl] [llvm-svn] build failure undefined reference to `clang::FrontendTimesIsEnabled'

2018-05-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106209 Kai changed: What|Removed |Added Resolution|--- |FIXED

Re: [Mesa-dev] [PATCH 7/9] radeonsi: avoid a crash in gallivm_dispose_target_library_info

2018-05-14 Thread Marek Olšák
On Mon, May 14, 2018 at 10:55 PM, Jan Vesely wrote: > On Thu, 2018-05-10 at 17:10 -0400, Marek Olšák wrote: > > On Thu, May 10, 2018 at 4:39 PM, Jan Vesely > wrote: > > > > > Is this still needed for llvm-6.0.1? > > > > > > > Probably. > > was it

Re: [Mesa-dev] [PATCH 7/9] radeonsi: avoid a crash in gallivm_dispose_target_library_info

2018-05-14 Thread Jan Vesely
On Thu, 2018-05-10 at 17:10 -0400, Marek Olšák wrote: > On Thu, May 10, 2018 at 4:39 PM, Jan Vesely wrote: > > > Is this still needed for llvm-6.0.1? > > > > Probably. was it reproducible on non-ubuntu systems? There's still some time until 6.0.1 is out, but I don't

[Mesa-dev] [PATCH] gallivm: Use alloca_undef with array type instead of alloca_array

2018-05-14 Thread sroland
From: Roland Scheidegger Use a single allocation of array type instead of the old-style array allocation for the temp and immediate arrays. Probably only makes a difference if they aren't used indirectly (so, if we used them solely because there's too many temps or

Re: [Mesa-dev] [PATCH] opencl: autotools: Fix linking order for OpenCL target

2018-05-14 Thread Jan Vesely
Hi Kai, I've pushed the patch. I've also kept the stable tag although the policy is (afaik) to only support llvm versions available at the point of mesa release. Don't be surprised to see some pushback from stable maintainers. thanks, Jan On Sun, 2018-05-13 at 23:19 +0200, Dieter Nützel wrote:

[Mesa-dev] [PATCH] cso: check count == 0 in cso_set_vertex_buffers

2018-05-14 Thread Marek Olšák
From: Marek Olšák The code didn't expect that. Fixes: 86d63b53a20a747e "gallium: remove aux_vertex_buffer_slot code" --- src/gallium/auxiliary/cso_cache/cso_context.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/gallium/auxiliary/cso_cache/cso_context.c

[Mesa-dev] [RFC] glsl: bump default glsl version to 130 if EXT_gpu_shader4 used

2018-05-14 Thread Timothy Arceri
EXT_gpu_shader4 is GL 3.0 plus some more bits and pieces. Currently the extension is never enabled for any drivers. Bumping the glsl version should allow shaders to compile. Noticed when looking at the trace from: Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102522 ---

[Mesa-dev] [Bug 106522] QA Notice

2018-05-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106522 Bug ID: 106522 Summary: QA Notice Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW Severity: normal Priority:

[Mesa-dev] [Bug 102522] [radeonsi, bisected] commit 147d7fb772 causes full-window map to flash green in Crea

2018-05-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102522 Timothy Arceri changed: What|Removed |Added Status|NEW |NEEDINFO ---

Re: [Mesa-dev] docs: Intel Mesa Drivers infographic

2018-05-14 Thread Jason Ekstrand
One more comment: NIR is *not* a stable API. On Mon, May 14, 2018 at 2:10 PM, Laura Ekstrand wrote: > I've made the edits. https://drive.google.com/file/d/1D0k3- > p88xEame5gepJQfIcCyZhG4CAsW/view?usp=sharing > > Thanks. > > Laura > > On Fri, May 11, 2018 at 5:07 PM,

Re: [Mesa-dev] [PATCH 00/19] AMD support for NIR deref instructions.

2018-05-14 Thread Rob Clark
On Mon, May 14, 2018 at 8:07 PM, Dave Airlie wrote: > On 13 May 2018 at 10:19, Bas Nieuwenhuizen wrote: >> This implements support in radv and radeonsi for NIR deref >> instructions instead of deref chains. >> >> It contains 4 parts: >> - patch 1 is a

Re: [Mesa-dev] [PATCH 00/19] AMD support for NIR deref instructions.

2018-05-14 Thread Dave Airlie
On 13 May 2018 at 10:19, Bas Nieuwenhuizen wrote: > This implements support in radv and radeonsi for NIR deref > instructions instead of deref chains. > > It contains 4 parts: > - patch 1 is a fixup for the initial series by Jason > - Add support everywhere for

[Mesa-dev] [PATCH 1/2] radv/resolve: pass number of components to resolve builder

2018-05-14 Thread Dave Airlie
From: Dave Airlie This just adds the option to use more components --- src/amd/vulkan/radv_meta.c| 9 + src/amd/vulkan/radv_meta.h| 3 ++- src/amd/vulkan/radv_meta_resolve_cs.c | 2 +- src/amd/vulkan/radv_meta_resolve_fs.c | 2 +- 4 files

[Mesa-dev] [PATCH 2/2] radv: attempt to do multi-layer subpass resolve in single pass

2018-05-14 Thread Dave Airlie
From: Dave Airlie This changes the cs resolve path to try and resolve all layers using a single shader invocation. We still have to create a dest iview to do the srgb format conversion. --- src/amd/vulkan/radv_meta_resolve_cs.c | 107 ++ 1

Re: [Mesa-dev] [PATCH 3/4] i965: Handle non-zero texture buffer offsets in buffer object range calculation.

2018-05-14 Thread Nanley Chery
On Fri, May 11, 2018 at 05:09:57PM -0700, Francisco Jerez wrote: > Hey Nanley, > > Nanley Chery writes: > > > On Mon, Mar 19, 2018 at 11:26:58AM -0700, Francisco Jerez wrote: > >> Otherwise the specified surface state will allow the GPU to access > >> memory up to

Re: [Mesa-dev] docs: Intel Mesa Drivers infographic

2018-05-14 Thread Laura Ekstrand
I've made the edits. https://drive.google.com/file/d/1D0k3-p88xEame5gepJQfIcCyZhG4CAsW/view?usp=sharing Thanks. Laura On Fri, May 11, 2018 at 5:07 PM, Jason Ekstrand wrote: > Couple of edits: > > i915: I'd leave the bit about "embedded" out. I don't think it's used >

[Mesa-dev] [PATCH] ac/surface: Don't assert that bpp is power of two.

2018-05-14 Thread Bas Nieuwenhuizen
There are non-shared linear images too, and those don't need the extra alignment at all. So just keep track of whether the image can be exported. Fixes: e361970ed73 "radv: Add support for IMG_DATA_FORMAT_32_32_32." --- src/amd/common/ac_surface.c | 10 ++ 1 file changed, 6

Re: [Mesa-dev] [PATCH 2/2] egl: make eglWaitClient behave like glFinish

2018-05-14 Thread Eric Anholt
Tapani Pälli writes: > On 14.05.2018 10:03, Eric Anholt wrote: >> Tapani Pälli writes: >> >>> As defined by the spec: >>> "All rendering calls for the currently bound context, for >>> the current rendering API, made prior to

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/2] radv: Fix up 2_10_10_10 alpha sign.

2018-05-14 Thread Bas Nieuwenhuizen
On Mon, May 14, 2018 at 9:28 PM, Mark Janes wrote: > Bas Nieuwenhuizen writes: > >> Pre-Vega HW always interprets the alpha for this format as unsigned, >> so we have to implement a fixup to do the sign correctly for signed >> formats. >> >> CC:

[Mesa-dev] [PATCH] radv: Fix up 2_10_10_10 alpha sign.

2018-05-14 Thread Bas Nieuwenhuizen
Pre-Vega HW always interprets the alpha for this format as unsigned, so we have to implement a fixup to do the sign correctly for signed formats. v2: Improve indexing mess. CC: 18.0 Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106480 Reviewed-by:

Re: [Mesa-dev] [PATCH] spirv: fix visiting inner loops with same break/continue block

2018-05-14 Thread Jason Ekstrand
On Mon, May 14, 2018 at 1:22 PM, Jason Ekstrand wrote: > On Mon, May 14, 2018 at 1:05 PM, Samuel Pitoiset < > samuel.pitoi...@gmail.com> wrote: > >> We should stop walking through the CFG when the inner loop's >> break block ends up as the same block as the outer loop's >>

Re: [Mesa-dev] [PATCH] spirv: fix visiting inner loops with same break/continue block

2018-05-14 Thread Jason Ekstrand
On Mon, May 14, 2018 at 1:05 PM, Samuel Pitoiset wrote: > We should stop walking through the CFG when the inner loop's > break block ends up as the same block as the outer loop's > continue block because we are already going to visit it. > > This fixes the following

[Mesa-dev] [PATCH] spirv: fix visiting inner loops with same break/continue block

2018-05-14 Thread Samuel Pitoiset
We should stop walking through the CFG when the inner loop's break block ends up as the same block as the outer loop's continue block because we are already going to visit it. This fixes the following assertion which ends up by crashing in RADV or ANV: SPIR-V parsing FAILED: In file

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/2] radv: Fix up 2_10_10_10 alpha sign.

2018-05-14 Thread Mark Janes
Bas Nieuwenhuizen writes: > Pre-Vega HW always interprets the alpha for this format as unsigned, > so we have to implement a fixup to do the sign correctly for signed > formats. > > CC: 18.0 18.1 I couldn't apply this to 18.0. You

[Mesa-dev] [Bug 106502] Running game with wine fullscreen freezes the system when missing xf86-video-amdgpu

2018-05-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106502 --- Comment #4 from Fabian Maurer --- Created attachment 139565 --> https://bugs.freedesktop.org/attachment.cgi?id=139565=edit Xorg log when it works -- You are receiving this mail because: You are the QA Contact for

[Mesa-dev] [Bug 106502] Running game with wine fullscreen freezes the system when missing xf86-video-amdgpu

2018-05-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106502 --- Comment #3 from Fabian Maurer --- Created attachment 139564 --> https://bugs.freedesktop.org/attachment.cgi?id=139564=edit Xorg log when freeze occurs > What does "corrupt installation of xf86-video-amdgpu" mean

[Mesa-dev] [Bug 100430] [radv] graphical glitches on dolphin emulator

2018-05-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100430 --- Comment #19 from MIka R --- I had the same rectangle bug in Metroid Prime: Trilogy and that patch fixed it for me. Thanks a bunch! -- You are receiving this mail because: You are the assignee for the bug. You are the

Re: [Mesa-dev] [PATCH mesa 2/5] meson: fix gallium-drivers=[]

2018-05-14 Thread Dylan Baker
Quoting Eric Engestrom (2018-05-14 07:08:07) > On Friday, 2018-05-11 08:48:34 -0700, Dylan Baker wrote: > > Quoting Eric Engestrom (2018-05-11 07:12:27) > > > Fixes: 5608d0a2cee47c7d037f ("meson: use array type options") > > > Signed-off-by: Eric Engestrom > > > --- > >

Re: [Mesa-dev] Mesa (18.1): Bump version to rc4

2018-05-14 Thread Dylan Baker
Quoting Michel Dänzer (2018-05-14 08:04:38) > On 2018-05-11 07:19 PM, Dylan Baker wrote: > > Quoting Michel Dänzer (2018-05-11 09:55:23) > >> > >> Hi Dylan, > >> > >> > >> any reason for not picking 6f81e07ecb8c0793dc482307d5d96fd3df95b7d2 > >> "dri3: Only update number of back buffers in

Re: [Mesa-dev] [PATCH mesa 1/4] docs/meson: fix various typos

2018-05-14 Thread Dylan Baker
For the series: Reviewed-by: Dylan Baker Quoting Eric Engestrom (2018-05-14 08:48:41) > Signed-off-by: Eric Engestrom > --- > docs/meson.html | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/docs/meson.html

Re: [Mesa-dev] [PATCH mesa 1/2] meson: remove "empty array"/"array of an empty string" confusion

2018-05-14 Thread Dylan Baker
I don't have a problem with this, but it is changing user facing interfaces. You might want to solicit some other developers on this before you land it. We'll also need to make some changes to our CI. I'm wondering if the better solution is to change upstream meson to treat -Darray= and

Re: [Mesa-dev] [PATCH 01/10] i965: Use meta for pixel ops on gen6+

2018-05-14 Thread Pohjolainen, Topi
On Fri, May 11, 2018 at 04:48:17PM -0700, Jason Ekstrand wrote: > Using meta for anything is fairly aweful and definitely has more CPU > overhead. However, it also uses the 3D pipe and is therefore likely > faster in terms of GPU time than the blitter. Also, the blitter code > has so many early

[Mesa-dev] [Bug 106480] A2B10G10R10_SNORM vertex attribute doesn't work.

2018-05-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106480 Bas Nieuwenhuizen changed: What|Removed |Added Status|NEW |RESOLVED

[Mesa-dev] [Bug 106331] radv doesnt support VK_FORMAT_R32G32B32_SFLOAT

2018-05-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106331 Bas Nieuwenhuizen changed: What|Removed |Added Status|NEW |RESOLVED

Re: [Mesa-dev] [PATCH 08/10] i965: Remove support for the BLT ring

2018-05-14 Thread Pohjolainen, Topi
On Mon, May 14, 2018 at 10:08:35AM -0700, Jason Ekstrand wrote: > On Mon, May 14, 2018 at 10:07 AM, Pohjolainen, Topi < > topi.pohjolai...@gmail.com> wrote: > > > On Fri, May 11, 2018 at 04:48:24PM -0700, Jason Ekstrand wrote: > > > We still support the blitter on gen4-5 but it's on the same ring

Re: [Mesa-dev] [PATCH 10/10] intel/blorp: Use linear formats for CCS_E clear colors in copies

2018-05-14 Thread Pohjolainen, Topi
On Fri, May 11, 2018 at 04:48:26PM -0700, Jason Ekstrand wrote: > It's clear that the original code meant to do this and there is even a > 10-line comment explaining why. Originally, we had a simple function > for packing the clear colors which was unaware of sRGB. However, in > a6b66a7b26ae1,

Re: [Mesa-dev] [PATCH 09/10] i965/miptree: Move the access_raw call to the individual map functions

2018-05-14 Thread Pohjolainen, Topi
On Fri, May 11, 2018 at 04:48:25PM -0700, Jason Ekstrand wrote: > The only function that doesn't need to call access_raw is map_blit. If > it takes the blitter path, it will happen as part of intel_miptree_copy. > If map_blit takes the blorp path, no brw_blorp_copy_miptrees will handle The part

[Mesa-dev] [PATCH 11/10] i965: Remove ring switching entirely

2018-05-14 Thread Jason Ekstrand
--- src/mesa/drivers/dri/i965/brw_compute.c | 2 +- src/mesa/drivers/dri/i965/brw_context.h | 7 -- src/mesa/drivers/dri/i965/brw_draw.c | 2 +- src/mesa/drivers/dri/i965/brw_misc_state.c| 2 +- src/mesa/drivers/dri/i965/brw_pipe_control.c | 32 +++---

Re: [Mesa-dev] [PATCH 08/10] i965: Remove support for the BLT ring

2018-05-14 Thread Jason Ekstrand
On Mon, May 14, 2018 at 10:07 AM, Pohjolainen, Topi < topi.pohjolai...@gmail.com> wrote: > On Fri, May 11, 2018 at 04:48:24PM -0700, Jason Ekstrand wrote: > > We still support the blitter on gen4-5 but it's on the same ring as 3D. > > --- > > src/mesa/drivers/dri/i965/intel_batchbuffer.c | 12

Re: [Mesa-dev] [PATCH 08/10] i965: Remove support for the BLT ring

2018-05-14 Thread Pohjolainen, Topi
On Fri, May 11, 2018 at 04:48:24PM -0700, Jason Ekstrand wrote: > We still support the blitter on gen4-5 but it's on the same ring as 3D. > --- > src/mesa/drivers/dri/i965/intel_batchbuffer.c | 12 +++- > 1 file changed, 3 insertions(+), 9 deletions(-) Nothing amiss in the patch itself,

Re: [Mesa-dev] [PATCH 00/10] Die, blitter, die!

2018-05-14 Thread Pohjolainen, Topi
On Fri, May 11, 2018 at 04:48:16PM -0700, Jason Ekstrand wrote: > This patch series completely kills off our usage of the hardware blitter > for Sandy Bridge and later. On Sandy Bridge, the blitter was moved to > another ring and so using it incurs noticable synchronization overhead and, > at the

[Mesa-dev] [PATCH 09/19] i965: Add brw_stage_cache_id to map gl stages to brw cache_ids

2018-05-14 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/mesa/drivers/dri/i965/brw_program_cache.c | 15 +++ src/mesa/drivers/dri/i965/brw_state.h | 2 ++ 2 files changed, 17 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_program_cache.c

[Mesa-dev] [PATCH 16/19] i965: Add brw_populate_default_key

2018-05-14 Thread Jordan Justen
We will need to populate the default key for ARB_get_program_binary to allow us to retrieve the default gen program to store save in the program binary. Signed-off-by: Jordan Justen --- src/mesa/drivers/dri/i965/brw_cs.c | 15 ++---

[Mesa-dev] [PATCH 07/19] i965: Add brw_program_deserialize_driver_blob

2018-05-14 Thread Jordan Justen
brw_program_deserialize_driver_blob will be a more generic form of brw_program_deserialize_nir. In addition to nir, it will also be able to extract gen binaries and upload them to the program cache. In this commit, it continues to only support nir. Signed-off-by: Jordan Justen

[Mesa-dev] [PATCH 08/19] i965: Add brw_(read|write)_blob_program_data functions

2018-05-14 Thread Jordan Justen
We will want to use these for both the disk shader cache, and for the ARB_get_program_binary. Signed-off-by: Jordan Justen --- src/mesa/drivers/dri/i965/brw_disk_cache.c | 45 +++- src/mesa/drivers/dri/i965/brw_program.h| 10 ++

[Mesa-dev] [PATCH 12/19] i965: Add support for driver cache blob containing the gen program

2018-05-14 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/mesa/drivers/dri/i965/brw_program_binary.c | 41 ++ 1 file changed, 41 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_program_binary.c b/src/mesa/drivers/dri/i965/brw_program_binary.c index

[Mesa-dev] [PATCH 17/19] mesa: Add gl_shader_program param to ProgramBinarySerializeDriverBlob

2018-05-14 Thread Jordan Justen
This might be required because some stages might generate different programs depending on the other stages in the program. For example, the i965 driver's tessellation control stage depends on the tessellation evaluation shader. Signed-off-by: Jordan Justen ---

[Mesa-dev] [PATCH 06/19] i965: Move brw_program_*serialize_nir to brw_program_binary.c

2018-05-14 Thread Jordan Justen
This will allow get_program_binary to add the gen program into its serialization in addition to just the nir program. Signed-off-by: Jordan Justen --- src/mesa/drivers/dri/i965/brw_program.c| 37 --

[Mesa-dev] [PATCH 10/19] i965: Add brw_prog_key_set_id helper to set the program id on any stage

2018-05-14 Thread Jordan Justen
For saving programs (shader cache; get program binary) it is useful to set the id to 0, with the stage being a parameter. For restoring programs it is useful to set the id to the id allocated to the program at creation time. Signed-off-by: Jordan Justen ---

[Mesa-dev] [PATCH 18/19] i965: Add flag_state param to brw_search_cache

2018-05-14 Thread Jordan Justen
This allows brw_search_cache to be used to find programs without causing extra state to be emitted in the case where the program isn't being made active. (For example, to find the program to save out with the ARB_get_program_binary interface.) Signed-off-by: Jordan Justen

[Mesa-dev] [PATCH 19/19] i965: Support saving the gen program with glGetProgramBinary

2018-05-14 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/mesa/drivers/dri/i965/brw_program_binary.c | 72 +++--- 1 file changed, 66 insertions(+), 6 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_program_binary.c

[Mesa-dev] [PATCH 01/19] mesa: Add disk shader cache driver blob callback

2018-05-14 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/compiler/glsl/shader_cache.cpp | 8 src/mesa/main/dd.h | 15 +++ 2 files changed, 23 insertions(+) diff --git a/src/compiler/glsl/shader_cache.cpp b/src/compiler/glsl/shader_cache.cpp index

[Mesa-dev] [PATCH 13/19] compiler/blob: Add blob_skip_bytes

2018-05-14 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/compiler/blob.c | 7 +++ src/compiler/blob.h | 6 ++ 2 files changed, 13 insertions(+) diff --git a/src/compiler/blob.c b/src/compiler/blob.c index 5e8671b7b44..c89092e1cf3 100644 --- a/src/compiler/blob.c +++

[Mesa-dev] [PATCH 15/19] i965: Replace brw_setup_tex_for_precompile brw with devinfo

2018-05-14 Thread Jordan Justen
Trying to make sure the setup of the default program key is not dependent on the GL state. Signed-off-by: Jordan Justen --- src/mesa/drivers/dri/i965/brw_cs.c | 2 +- src/mesa/drivers/dri/i965/brw_gs.c | 2 +- src/mesa/drivers/dri/i965/brw_program.c | 3 +--

[Mesa-dev] [PATCH 04/19] i965: Use ShaderCacheSerializeDriverBlob driver function

2018-05-14 Thread Jordan Justen
This function is called just before the gl_program::driver_cache_blob is saved out as part of the gl_program serialization. Signed-off-by: Jordan Justen --- src/mesa/drivers/dri/i965/brw_context.c | 4 src/mesa/drivers/dri/i965/brw_link.cpp | 11 ---

[Mesa-dev] [PATCH 00/19] i965 save default gen program with GetProgramBinary

2018-05-14 Thread Jordan Justen
git://people.freedesktop.org/~jljusten/mesa i965-get-program-binary-gen-v1 Currently we only save the nir program out when GetProgramBinary is called. It is likely that the program using ARB_get_program_binary will also use the default gen program after loading a program with ProgramBinary.

[Mesa-dev] [PATCH 11/19] i965: Use brw_prog_key_set_id in disk cache load/store code

2018-05-14 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/mesa/drivers/dri/i965/brw_disk_cache.c | 24 1 file changed, 8 insertions(+), 16 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_disk_cache.c b/src/mesa/drivers/dri/i965/brw_disk_cache.c index

[Mesa-dev] [PATCH 03/19] st/mesa: i965: Use ShaderCacheSerializeDriverBlob driver function

2018-05-14 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/mesa/state_tracker/st_context.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mesa/state_tracker/st_context.c b/src/mesa/state_tracker/st_context.c index ee76e07a7d1..0d0cfc5c63c 100644 ---

[Mesa-dev] [PATCH 05/19] mesa: Always call ProgramBinarySerializeDriverBlob

2018-05-14 Thread Jordan Justen
The driver may prefer to have a different blob for ARB_get_program_binary compared to the version saved out for the disk shader cache. Since they both use the driver_cache_blob field, we need to always give the driver the opportunity to fill in the driver_cache_blob when saving the program

[Mesa-dev] [PATCH 02/19] st/mesa: Skip serializing driver_cache_blob if it exists

2018-05-14 Thread Jordan Justen
Previously the mesa core code would not call to serialize the driver_cache_blob if it existed. We will update it to always call to serialize the driver_cache_blob meaning we should avoid re-serializing it under mesa/state_tracker. Signed-off-by: Jordan Justen ---

[Mesa-dev] [PATCH 14/19] i965: Regenerate blob without gen program for shader cache

2018-05-14 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/mesa/drivers/dri/i965/brw_program_binary.c | 64 +- 1 file changed, 63 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_program_binary.c

Re: [Mesa-dev] [PATCH v2 1/2] radv: Fix up 2_10_10_10 alpha sign.

2018-05-14 Thread Roland Scheidegger
Slightly OT (not actually radv related), does someone know if this bug affects pre-gcn gpus and if so which ones? There's a bug filed against r600 (with Barts) which suspiciously looks like it's the exact same issue: https://bugs.freedesktop.org/show_bug.cgi?id=105095 But it works for me

[Mesa-dev] [PATCH mesa 2/2] docs/meson: mention how to use array options

2018-05-14 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- docs/meson.html | 8 1 file changed, 8 insertions(+) diff --git a/docs/meson.html b/docs/meson.html index d05b5fe347b67bad9f8d..c260b703902083045e27 100644 --- a/docs/meson.html +++ b/docs/meson.html @@ -67,6 +67,14 @@ 1.

[Mesa-dev] [PATCH mesa 1/2] meson: remove "empty array"/"array of an empty string" confusion

2018-05-14 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- meson_options.txt | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/meson_options.txt b/meson_options.txt index ce7d87f1ebd74a4ecc2c..b851f086a2b756142d8d 100644 --- a/meson_options.txt +++ b/meson_options.txt

[Mesa-dev] [PATCH mesa 4/4] docs/meson: mark code/commands as

2018-05-14 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- docs/meson.html | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/docs/meson.html b/docs/meson.html index 009aebd817057f3e73da..29907a60a9cb02975065 100644 --- a/docs/meson.html +++

[Mesa-dev] [PATCH mesa 3/4] docs/meson: replace plaintext url with a link

2018-05-14 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- docs/meson.html | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/meson.html b/docs/meson.html index 3c0e3a168b1a706a99be..009aebd817057f3e73da 100644 --- a/docs/meson.html +++ b/docs/meson.html @@ -90,9

[Mesa-dev] [PATCH mesa 2/4] docs/meson: fix various html issues

2018-05-14 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- docs/meson.html | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/docs/meson.html b/docs/meson.html index 841a0d5b9d8d65b71da5..3c0e3a168b1a706a99be 100644 --- a/docs/meson.html +++ b/docs/meson.html @@ -95,6

[Mesa-dev] [PATCH mesa 1/4] docs/meson: fix various typos

2018-05-14 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- docs/meson.html | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/docs/meson.html b/docs/meson.html index c260b703902083045e27..841a0d5b9d8d65b71da5 100644 --- a/docs/meson.html +++ b/docs/meson.html @@

[Mesa-dev] [PATCH] amd/addrlib: Use defines in autotools build.

2018-05-14 Thread Bas Nieuwenhuizen
Otherwise stuff like NDEBUG would not be passed through. CC: Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106479 --- src/amd/Makefile.addrlib.am | 1 + 1 file changed, 1 insertion(+) diff --git a/src/amd/Makefile.addrlib.am

Re: [Mesa-dev] [PATCH v2 1/2] radv: Fix up 2_10_10_10 alpha sign.

2018-05-14 Thread Samuel Pitoiset
On 05/14/2018 05:25 PM, Bas Nieuwenhuizen wrote: Pre-Vega HW always interprets the alpha for this format as unsigned, so we have to implement a fixup to do the sign correctly for signed formats. v2: Improve indexing mess. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106480

[Mesa-dev] [PATCH v2 1/2] radv: Fix up 2_10_10_10 alpha sign.

2018-05-14 Thread Bas Nieuwenhuizen
Pre-Vega HW always interprets the alpha for this format as unsigned, so we have to implement a fixup to do the sign correctly for signed formats. v2: Improve indexing mess. CC: 18.0 18.1 --- src/amd/vulkan/radv_nir_to_llvm.c | 68

[Mesa-dev] [PATCH v2 2/2] radv: Disable texel buffers with A2 SNORM/SSCALED/SINT for pre-vega.

2018-05-14 Thread Bas Nieuwenhuizen
The hardware always interprets the alpha as unsigned and fixing it in the shader is going to add unacceptable overheads. CC: 18.0 18.1 --- src/amd/vulkan/radv_formats.c | 19 +++ 1 file changed, 19 insertions(+) diff --git

Re: [Mesa-dev] [PATCH 1/2] vc4: use util_copy_framebuffer_state

2018-05-14 Thread Eric Anholt
Rob Clark writes: > On Mon, May 14, 2018 at 9:16 AM, Rob Clark wrote: >> Signed-off-by: Rob Clark >> --- >> Just happened to notice that vc4/vc5 was open-coding >> util_copy_framebuffer_state() > > and ofc if I actually managed to

Re: [Mesa-dev] [PATCH] autotools, meson: add tileset.h

2018-05-14 Thread Juan A. Suarez Romero
On Mon, 2018-05-14 at 15:37 +0100, Eric Engestrom wrote: > On Monday, 2018-05-14 16:02:02 +0200, Juan A. Suarez Romero wrote: > > On Mon, 2018-05-14 at 14:09 +0100, Eric Engestrom wrote: > > > On Monday, 2018-05-14 13:53:37 +0200, Juan A. Suarez Romero wrote: > > > > Fixes: 4e52cb51b5 ("swr/rast:

Re: [Mesa-dev] [PATCH v2 16/21] nir/linker: Add nir_build_program_resource_list()

2018-05-14 Thread Alejandro Piñeiro
On 14/05/18 01:26, Timothy Arceri wrote: > On 12/05/18 19:40, Alejandro Piñeiro wrote: >> From: Eduardo Lima Mitev >> >> This function is equivalent to the linker.cpp >> build_program_resource_list() but will extract the resources from NIR >> shaders instead. >> >> For now, only

Re: [Mesa-dev] Mesa (18.1): Bump version to rc4

2018-05-14 Thread Michel Dänzer
On 2018-05-11 07:19 PM, Dylan Baker wrote: > Quoting Michel Dänzer (2018-05-11 09:55:23) >> >> Hi Dylan, >> >> >> any reason for not picking 6f81e07ecb8c0793dc482307d5d96fd3df95b7d2 >> "dri3: Only update number of back buffers in loader_dri3_get_buffers" >> for rc4? > > Hi Michel, > > That patch

Re: [Mesa-dev] [PATCH 1/4] radv: check that layout isn't NULL in radv_nir_shader_info_pass()

2018-05-14 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen for the series. On Mon, May 14, 2018 at 4:04 PM, Samuel Pitoiset wrote: > An upcoming patch will run the shader info pass on the > geometry shader just before emitting the GS copy shader. > > Signed-off-by:

Re: [Mesa-dev] [PATCH] gallium: remove aux_vertex_buffer_slot code

2018-05-14 Thread Michel Dänzer
Hi Marek, On 2018-05-10 06:21 PM, Marek Olšák wrote: > From: Marek Olšák > > The slot index is always 0, and is pretty unlikely to change in the future. This change caused dozens of piglit tests to crash for me, see an example below from

Re: [Mesa-dev] [PATCH mesa 4/5] meson: fix platforms=[]

2018-05-14 Thread Eric Engestrom
On Friday, 2018-05-11 08:54:13 -0700, Dylan Baker wrote: > Quoting Eric Engestrom (2018-05-11 07:12:29) > > Fixes: 5608d0a2cee47c7d037f ("meson: use array type options") > > Signed-off-by: Eric Engestrom > > --- > > meson.build | 26 +++--- > > 1

Re: [Mesa-dev] [PATCH] autotools, meson: add tileset.h

2018-05-14 Thread Eric Engestrom
On Monday, 2018-05-14 16:02:02 +0200, Juan A. Suarez Romero wrote: > On Mon, 2018-05-14 at 14:09 +0100, Eric Engestrom wrote: > > On Monday, 2018-05-14 13:53:37 +0200, Juan A. Suarez Romero wrote: > > > Fixes: 4e52cb51b5 ("swr/rast: Thread locked tiles improvement") > > > --- > > >

[Mesa-dev] [PATCH v2] docs: add 18.0.5 in the release calendar

2018-05-14 Thread Juan A. Suarez Romero
Mesa 18.1 series has not been released yet, so let's extend 18.0 lifetime. v2: Add missing closing TR tags (Eric Engestrom) CC: Andres Gomez CC: Emil Velikov --- docs/release-calendar.html | 9 - 1 file changed, 8 insertions(+), 1

[Mesa-dev] threading in OSMesa and gallium swr driver

2018-05-14 Thread Alexandre
Hello, Sorry for the inconvenience if this message is not appropriate for this mailing list. The following is a question for developers of the swr driver of gallium. I am the main developer of a motion graphics application. Our application internally has a dependency graph where each node may

Re: [Mesa-dev] [PATCH mesa 2/5] meson: fix gallium-drivers=[]

2018-05-14 Thread Eric Engestrom
On Friday, 2018-05-11 08:48:34 -0700, Dylan Baker wrote: > Quoting Eric Engestrom (2018-05-11 07:12:27) > > Fixes: 5608d0a2cee47c7d037f ("meson: use array type options") > > Signed-off-by: Eric Engestrom > > --- > > meson.build | 73

[Mesa-dev] [PATCH] st/xa: Bump minor

2018-05-14 Thread Thomas Hellstrom
Bump xa minor to signal that the underlying mesa version is suitable for dri3. This is a bit ugly since it doesn't relate to a specific xa interface change. Recently there has been a number of fixes in mesa that helps enabling dri3 without any significant regressions in automated testing and

[Mesa-dev] [PATCH 2/4] radv: run the shader info pass before emitting the GS copy shader

2018-05-14 Thread Samuel Pitoiset
For further optimizations. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_nir_to_llvm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/amd/vulkan/radv_nir_to_llvm.c b/src/amd/vulkan/radv_nir_to_llvm.c index f98940f0d8f..a8af32b58f3 100644 ---

[Mesa-dev] [PATCH 1/4] radv: check that layout isn't NULL in radv_nir_shader_info_pass()

2018-05-14 Thread Samuel Pitoiset
An upcoming patch will run the shader info pass on the geometry shader just before emitting the GS copy shader. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_shader_info.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH 3/4] radv: scan the geometry shader output usage mask

2018-05-14 Thread Samuel Pitoiset
For reducing the number of parameters that are exported by the GS copy shader. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_shader.h | 3 +++ src/amd/vulkan/radv_shader_info.c | 6 ++ 2 files changed, 9 insertions(+) diff --git

[Mesa-dev] [PATCH 4/4] radv: reduce the number of parameters export by the GS copy shader

2018-05-14 Thread Samuel Pitoiset
By using the geometry shader output usage mask. This improves all Vulkan demos that use a geometry shader (ie. geometryshader, deferredshadows, viewportarray). Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_nir_to_llvm.c | 7 +++ 1 file changed, 3

Re: [Mesa-dev] [PATCH 1/2] vc4: use util_copy_framebuffer_state

2018-05-14 Thread Rob Clark
On Mon, May 14, 2018 at 9:16 AM, Rob Clark wrote: > Signed-off-by: Rob Clark > --- > Just happened to notice that vc4/vc5 was open-coding > util_copy_framebuffer_state() and ofc if I actually managed to test-compile what I *thought* I was compiling, I

Re: [Mesa-dev] [PATCH] autotools, meson: add tileset.h

2018-05-14 Thread Juan A. Suarez Romero
On Mon, 2018-05-14 at 14:09 +0100, Eric Engestrom wrote: > On Monday, 2018-05-14 13:53:37 +0200, Juan A. Suarez Romero wrote: > > Fixes: 4e52cb51b5 ("swr/rast: Thread locked tiles improvement") > > --- > > src/gallium/drivers/swr/Makefile.sources | 1 + > > src/gallium/drivers/swr/meson.build

Re: [Mesa-dev] [PATCH] docs: add 18.0.5 in the release calendar

2018-05-14 Thread Eric Engestrom
On Monday, 2018-05-14 11:34:43 +0200, Juan A. Suarez Romero wrote: > Mesa 18.1 series has not been released yet, so let's extend 18.0 lifetime. > > CC: Andres Gomez > CC: Emil Velikov > --- > docs/release-calendar.html | 7 ++- > 1 file changed,

[Mesa-dev] [PATCH 2/2] vc5: use util_copy_framebuffer_state

2018-05-14 Thread Rob Clark
Signed-off-by: Rob Clark --- src/gallium/drivers/vc5/vc5_state.c | 12 +--- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/src/gallium/drivers/vc5/vc5_state.c b/src/gallium/drivers/vc5/vc5_state.c index 42ae64157c4..27c9f78a0e9 100644 ---

[Mesa-dev] [PATCH 1/2] vc4: use util_copy_framebuffer_state

2018-05-14 Thread Rob Clark
Signed-off-by: Rob Clark --- Just happened to notice that vc4/vc5 was open-coding util_copy_framebuffer_state() src/gallium/drivers/vc4/vc4_state.c | 12 +--- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/src/gallium/drivers/vc4/vc4_state.c

[Mesa-dev] [PATCH] mesa: handle a bunch of formats in IMPLEMENTATION_COLOR_READ_*

2018-05-14 Thread Tomeu Vizoso
Virgl could save a lot of work converting buffers in the host side between formats if Mesa supported a bunch of other formats when reading pixels. This commit adds cases to handle specific formats so that the values reported by the two calls match more closely the underlying native formats. In

Re: [Mesa-dev] [PATCH] autotools, meson: add tileset.h

2018-05-14 Thread Eric Engestrom
On Monday, 2018-05-14 13:53:37 +0200, Juan A. Suarez Romero wrote: > Fixes: 4e52cb51b5 ("swr/rast: Thread locked tiles improvement") > --- > src/gallium/drivers/swr/Makefile.sources | 1 + > src/gallium/drivers/swr/meson.build | 3 ++- > 2 files changed, 3 insertions(+), 1 deletion(-) > >

[Mesa-dev] [PATCH] autotools, meson: add tileset.h

2018-05-14 Thread Juan A. Suarez Romero
Fixes: 4e52cb51b5 ("swr/rast: Thread locked tiles improvement") --- src/gallium/drivers/swr/Makefile.sources | 1 + src/gallium/drivers/swr/meson.build | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/swr/Makefile.sources

Re: [Mesa-dev] [PATCH 2/2] egl: make eglWaitClient behave like glFinish

2018-05-14 Thread Tapani Pälli
On 14.05.2018 10:03, Eric Anholt wrote: Tapani Pälli writes: As defined by the spec: "All rendering calls for the currently bound context, for the current rendering API, made prior to eglWaitClient, are guaranteed to be executed before native rendering

Re: [Mesa-dev] [PATCH] llvmpipe: Fix random number generation for unit tests

2018-05-14 Thread Jose Fonseca
Hi Roland, It's indeed been long time since I wrote this and I'm no longer certain of what I intended to do, but the change looks overall. Reviewed-by: Jose Fonseca But is it really true rand returns 63 bits? I think it return RAND_MAX, which was actually often 31 bits.

Re: [Mesa-dev] [PATCH] radv: Translate logic ops.

2018-05-14 Thread Samuel Pitoiset
Nice catch Bas! With Ilia's suggestion, this patch is: Reviewed-by: Samuel Pitoiset On 05/14/2018 03:14 AM, Bas Nieuwenhuizen wrote: radeonsi could pass them through but the enum changed between Gallium and Vulkan, so we have to translate. In progress I made the

  1   2   >