Re: [Mesa-dev] RFC about anv change that should be applicable to radv

2018-06-28 Thread Tapani Pälli
On 06/27/2018 06:25 PM, Mauro Rossi wrote: Hi, Il giorno mer 27 giu 2018 alle ore 10:41 Tapani Pälli mailto:tapani.pa...@intel.com>> ha scritto: Hi; On 06/13/2018 09:32 AM, Mauro Rossi wrote: > +Samuel Pitoiset > > > 2018-06-11 22:31 GMT+02:00 Mauro Rossi

Re: [Mesa-dev] [PATCH 18/18] radeonsi: enable OpenGL 4.4 compat profile

2018-06-28 Thread Marek Olšák
For patches 15-18: Reviewed-by: Marek Olšák Marek On Thu, Jun 28, 2018 at 2:46 AM, Timothy Arceri wrote: > --- > src/gallium/drivers/radeonsi/si_get.c | 7 +++ > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/src/gallium/drivers/radeonsi/si_get.c >

Re: [Mesa-dev] [PATCH 14/18] mesa: add compat profile support for ARB_multi_draw_indirect

2018-06-28 Thread Marek Olšák
Same feedback as on patch 12. Marek On Thu, Jun 28, 2018 at 2:46 AM, Timothy Arceri wrote: > --- > src/mesa/main/extensions_table.h | 2 +- > src/mesa/vbo/vbo_exec_array.c| 75 +++- > 2 files changed, 74 insertions(+), 3 deletions(-) > > diff --git

Re: [Mesa-dev] [PATCH 13/18] mesa: make valid_draw_indirect_multi() accessible externally

2018-06-28 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Thu, Jun 28, 2018 at 2:46 AM, Timothy Arceri wrote: > We will use this to add compat support to ARB_multi_draw_indirect > in the following patch. > --- > src/mesa/main/draw_validate.c | 24 > src/mesa/main/draw_validate.h | 3 +++ >

Re: [Mesa-dev] [PATCH 12/18] mesa: add ARB_draw_indirect support to compat profile

2018-06-28 Thread Marek Olšák
On Thu, Jun 28, 2018 at 2:46 AM, Timothy Arceri wrote: > --- > src/mesa/main/bufferobj.c| 3 +- > src/mesa/main/extensions_table.h | 2 +- > src/mesa/vbo/vbo_exec_array.c| 66 +++- > 3 files changed, 67 insertions(+), 4 deletions(-) > > diff --git

Re: [Mesa-dev] [PATCH 11/18] mesa: generate GL_INVALID_OPERATION using draw indirect in dlist

2018-06-28 Thread Marek Olšák
For patches 1-11: Reviewed-by: Marek Olšák Marek On Thu, Jun 28, 2018 at 2:46 AM, Timothy Arceri wrote: > The spec doesn't explicitly say to generate an error but since > DrawArraysInstanced* and DrawElementsInstanced* do, it makes > sense to do it for these functions also. > --- >

Re: [Mesa-dev] [PATCH] glsl: enable EXT_texture_array by default in 1.30

2018-06-28 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Fri, Jun 29, 2018 at 12:42 AM, Timothy Arceri wrote: > This extension was made core in OpenGL 3.0. > > This fixes rendering issues in No Man's Sky. > --- > src/compiler/glsl/builtin_functions.cpp | 8 +--- > 1 file changed, 5 insertions(+), 3 deletions(-)

[Mesa-dev] [PATCH] glsl: enable EXT_texture_array by default in 1.30

2018-06-28 Thread Timothy Arceri
This extension was made core in OpenGL 3.0. This fixes rendering issues in No Man's Sky. --- src/compiler/glsl/builtin_functions.cpp | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/compiler/glsl/builtin_functions.cpp b/src/compiler/glsl/builtin_functions.cpp

[Mesa-dev] [PATCH] r600/sb: cleanup if_conversion iterator to be legal C++

2018-06-28 Thread Dave Airlie
From: Dave Airlie The current code causes: /usr/include/c++/8/debug/safe_iterator.h:207: Error: attempt to copy from a singular iterator. This is due to the iterators getting invalidated, fix the reverse iterator to use the return value from erase, and cast it properly. Cc: ---

Re: [Mesa-dev] Radeonsi OpenGL 4.4 compat profile support

2018-06-28 Thread Dieter Nützel
For the series: Tested-by: Dieter Nützel on RX 580 with Plasma 5, UH, UV, Blender 2.79b, Krita 4.1 and glmark2. Dieter Am 28.06.2018 08:46, schrieb Timothy Arceri: Sorry to keep spamming the list with this stuff, but Dave helped out with ARB_vertex_attrib_64bit support and the spec bug I

Re: [Mesa-dev] [PATCH 1/3] radeonsi: move VS_STATE_SGPR before draw SGPRs

2018-06-28 Thread Dieter Nützel
For the series: Tested-by: Dieter Nützel on RX 580 with Plasma 5, UH, UV, Blender 2.79b, Krita 4.1 and glmark2. Dieter Am 27.06.2018 22:10, schrieb Marek Olšák: From: Marek Olšák for vertex color clamping. --- src/gallium/drivers/radeonsi/si_shader.c | 14 +++---

Re: [Mesa-dev] [PATCH] radv: optimize vkCmd{Set, Reset}Event() a little bit

2018-06-28 Thread Dieter Nützel
Tested-by: Dieter Nützel on RX 580 with F1 2017. Dieter Am 28.06.2018 12:21, schrieb Samuel Pitoiset: Always emitting a bottom-of-pipe event is quite dumb. Instead, start to optimize these functions by syncing PFP for the top-of-pipe and syncing ME for the post-index-fetch event. This can

Re: [Mesa-dev] [PATCH] Plumb invariant output attrib thru TGSI

2018-06-28 Thread Dave Airlie
On 29 June 2018 at 11:03, Robert Tarasov wrote: > ping for push. it's not pushed yet. Oops I thought I'd done it. will push it now. Dave. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] Plumb invariant output attrib thru TGSI

2018-06-28 Thread Robert Tarasov
ping for push. it's not pushed yet. On Wed, Jun 20, 2018 at 5:55 PM, Robert Tarasov wrote: > From: "Joe M. Kniss" > > Add support for glsl 'invariant' modifier for output data declarations. > Gallium drivers that use TGSI serialization currently loose invariant > modifiers in glsl shaders. > >

Re: [Mesa-dev] [PATCH 03/10] glsl: don't let an 'if' then-branch kill copy propagation for else-branch

2018-06-28 Thread Caio Marcelo de Oliveira Filho
Hi, > > The hurt instruction count is caused because the extra propagation > > causes an input variable to be read from two branches of an > > if (load_input intrinsic in NIR). Depending on the complexity of each > > branch this might be a win or not in terms of cycles. > > I just sent out a

Re: [Mesa-dev] [PATCH 11/12] nir: Add partial redundancy elimination for compares

2018-06-28 Thread Caio Marcelo de Oliveira Filho
Hi, On Wed, Jun 27, 2018 at 09:46:24PM -0700, Ian Romanick wrote: > From: Ian Romanick > > This pass attempts to dectect code sequences like > > if (x < y) { > z = y - z; Typo "z = x - y". > Currently only floating point compares and adds are supported. Adding > support for

Re: [Mesa-dev] [PATCH] nv50/ir: Improve Maintainability of Target*::initOpInfo()

2018-06-28 Thread Karol Herbst
On Sat, Jun 16, 2018 at 12:26 PM, Rhys Perry wrote: > This is mainly useful for when one needs to add new opcodes in a painless > and reliable way. > > Signed-off-by: Rhys Perry > --- > .../drivers/nouveau/codegen/nv50_ir_target_nv50.cpp | 21 > - >

Re: [Mesa-dev] [PATCH 4/8] radv: add all dependencies from external to the first subpass

2018-06-28 Thread Fredrik Höglund
On Wednesday 27 June 2018, Samuel Pitoiset wrote: > > On 06/27/2018 02:12 AM, Bas Nieuwenhuizen wrote: > > Reviewed-by: Bas Nieuwenhuizen > > > > for patch 3-4. Not sure they should go to stable though, since they > > are optimizations? > > Isn't the whole series for optimization purposes?

Re: [Mesa-dev] [PATCH 07/12] intel/compiler: More peephole select

2018-06-28 Thread Caio Marcelo de Oliveira Filho
Hi, > diff --git a/src/intel/compiler/brw_nir.c b/src/intel/compiler/brw_nir.c > index 67c062d91f5..6a0d4090fa7 100644 > --- a/src/intel/compiler/brw_nir.c > +++ b/src/intel/compiler/brw_nir.c > @@ -557,7 +557,22 @@ brw_nir_optimize(nir_shader *nir, const struct > brw_compiler *compiler, >

Re: [Mesa-dev] [PATCH 1/8] radv: don't flush src stages when dstStageMask == BOTTOM_OF_PIPE

2018-06-28 Thread Fredrik Höglund
On Wednesday 27 June 2018, Bas Nieuwenhuizen wrote: > Don't we still need this when having layout transitions? I think the answer is probably yes, though I haven't noticed any regressions with this patch. I'll post an updated version that takes transitions into account. > On Tue, Jun 26, 2018

[Mesa-dev] [PATCH] src/egl/Makefile: fix build race

2018-06-28 Thread Ross Burton
There is a parallel make build issue in src/egl/drivers/dri2/ for wayland builds. Can be reproduced with: $ rm src/egl/drivers/dri2/*.h src/egl/drivers/dri2/platform_wayland.lo $ make -C src/egl/ drivers/dri2/platform_wayland.lo ../../../mesa-18.1.2/src/egl/drivers/dri2/platform_wayland.c:50:10:

[Mesa-dev] [PATCH 1/2] mesa: MESA_framebuffer_flip_y extension [v2]

2018-06-28 Thread Fritz Koenig
Adds an extension to glFramebufferParameteri that will specify if the framebuffer is vertically flipped. Historically system framebuffers are vertically flipped and user framebuffers are not. Checking to see the state was done by looking at the name field. This adds an explicit field. v2: *

[Mesa-dev] [PATCH 2/2] i965: implement MESA_framebuffer_flip_yv [v2]

2018-06-28 Thread Fritz Koenig
Instead of using _mesa_is_winsys_fbo or _mesa_is_user_fbo to infer if an fbo is flipped use the InvertedY flag. --- src/mesa/drivers/dri/i965/brw_blorp.c | 2 +- src/mesa/drivers/dri/i965/brw_meta_util.c | 4 +- src/mesa/drivers/dri/i965/brw_sf.c| 6 +--

Re: [Mesa-dev] [PATCH 11/11] ac/radv: using tls to store llvm related info and speed up compiles (v3)

2018-06-28 Thread Dave Airlie
On 28 June 2018 at 18:23, Alex Smith wrote: > Hi Dave, > > I did a quick test with this on Rise of the Tomb Raider. It reduced the time > taken to create all pipelines for the whole game over 8 threads (with > RADV_DEBUG=nocache) from 12m24s to 11m35s. Nice improvement :) Oh good to have some

Re: [Mesa-dev] [PATCH] anv/cmd_buffer: emit binding tables always if push constants are dirty

2018-06-28 Thread Jason Ekstrand
On Thu, Jun 28, 2018 at 3:58 AM, Iago Toral wrote: > On Thu, 2018-06-28 at 08:47 +0200, Iago Toral wrote: > > On Wed, 2018-06-27 at 09:13 -0700, Jason Ekstrand wrote: > > On Wed, Jun 27, 2018 at 2:25 AM, Iago Toral wrote: > > On Tue, 2018-06-26 at 10:59 -0700, Jason Ekstrand wrote: > > On Tue,

Re: [Mesa-dev] [PATCH 1/2] radv: enable/disable prediction for the DCC decompression pass

2018-06-28 Thread Dave Airlie
Seems sane, Reviewed-by: Dave Airlie On 29 June 2018 at 01:14, Samuel Pitoiset wrote: > ping? > > On 04/18/2018 02:34 PM, Samuel Pitoiset wrote: >> >> Performing a DCC decompression pass is currently pretty rare, >> but using prediction allows the GPU to skip unnecessary passes. >> >>

[Mesa-dev] [PATCH 0/1] swr/rast: last swr formatting changes for a while v2

2018-06-28 Thread Alok Hota
Sorry for the churn on these patches. They had to be split in three due to some code change in between a mass formatting change. Anyway this patch contains only formatting changes for the files that were updated in the last patch v2 : I added the clang formatting file we used Alok Hota (1):

[Mesa-dev] [PATCH 1/1] swr/rast: Updating code style based on current v clang-format rules v2

2018-06-28 Thread Alok Hota
added clang format file --- .../drivers/swr/rasterizer/_clang-format | 114 +++ .../swr/rasterizer/jitter/JitManager.cpp | 133 ++-- .../swr/rasterizer/jitter/builder_gfx_mem.cpp | 90 + .../swr/rasterizer/jitter/builder_gfx_mem.h | 101 +-

Re: [Mesa-dev] [PATCH] anv: finish the binding_table_pool on destroyDevice when use_softpin

2018-06-28 Thread Jason Ekstrand
Rb On June 28, 2018 08:50:21 Jose Maria Casanova Crespo wrote: Running VK-CTS in batch execution mode was raising the VK_ERROR_INITIALIZATION_FAILED error in multiple tests. But when the same failing tests were run isolated they always passed. createDevice and destroyDevice were called

Re: [Mesa-dev] [PATCH 02/12] i965/vec4: Don't cmod propagate from CMP to ADD if the writemask isn't compatible

2018-06-28 Thread Caio Marcelo de Oliveira Filho
Patch looks good to me, consider suggestion in the end of the email. Reviewed-by: Caio Marcelo de Oliveira Filho A related question: for the case "if (inst->opcode == BRW_OPCODE_CMP && !inst->src[1].is_zero())" don't we need to break if we find an ADD that is not a match but writes to the

[Mesa-dev] [PATCH] gallium/u_vbuf: drop min/max-scanning for empty indirect draws

2018-06-28 Thread Erik Faye-Lund
When building with asserts enabled, we'll end up triggering an assert in pipe_buffer_map_range down this code-path, due to trying to map an empty range. Even if we avoid that, we'll trigger another assert a bit later, because u_vbuf_get_minmax_index returns a min-index of -1 here, which gets

Re: [Mesa-dev] [PATCH 50/53] intel/anv, blorp, i965: Implement the SKL 16x MSAA SIMD32 workaround

2018-06-28 Thread Kenneth Graunke
On Thursday, May 24, 2018 2:56:32 PM PDT Jason Ekstrand wrote: > --- > src/intel/blorp/blorp_genX_exec.h | 14 ++ > src/intel/vulkan/genX_pipeline.c | 20 ++-- > src/mesa/drivers/dri/i965/genX_state_upload.c | 16 > 3 files

Re: [Mesa-dev] [PATCH v3] virgl: Add support for glGetMultisample

2018-06-28 Thread Gert Wollny
Am Donnerstag, den 28.06.2018, 18:09 +0200 schrieb Erik Faye-Lund: > It still seems kinda strange (and fragile) to me to try to enumerate > all possible sample locations up-front instead of querying a given > texture for it's sample-locations. With virgl, querying a texture for host-side

Re: [Mesa-dev] [PATCH 06/12] nir/opt_peephole_select: Don't try to remove flow control around indirect loads

2018-06-28 Thread Marek Olšák
On our hardware, indirect accesses can go through memory with no bounds checking. Marek On Thu, Jun 28, 2018 at 12:46 AM, Ian Romanick wrote: > From: Ian Romanick > > That flow control may be trying to avoid invalid loads. On at least > some platforms, those loads can also be expensive. > >

Re: [Mesa-dev] [PATCH 01/12] intel/compiler: Silence unused parameter warnings brw_nir.c

2018-06-28 Thread Caio Marcelo de Oliveira Filho
Reviewed-by: Caio Marcelo de Oliveira Filho On Wed, Jun 27, 2018 at 09:46:14PM -0700, Ian Romanick wrote: > From: Ian Romanick > > src/intel/compiler/brw_nir.c: In function ‘brw_nir_lower_vue_outputs’: > src/intel/compiler/brw_nir.c:464:32: warning: unused parameter ‘is_scalar’ >

Re: [Mesa-dev] [PATCH v2 2/2] i965: Implement ARB_compute_variable_group_size.

2018-06-28 Thread Manolova, Plamena
Hi Karol, Thank you for reviewing! I'll go ahead and push the changes you need from nir_lower_system_values.c to master. Thank you, Pam On Thu, Jun 28, 2018 at 5:50 AM, Karol Herbst wrote: > Hi, > > if the changes inside "src/compiler/nir/nir_lower_system_values.c" are > extracted into a

Re: [Mesa-dev] [PATCH] virgl: Support ARB_framebuffer_no_attachments

2018-06-28 Thread Emil Velikov
On 28 June 2018 at 17:16, Drew Davenport wrote: > On Wed, Jun 27, 2018 at 1:57 AM Emil Velikov wrote: >> >> On 27 June 2018 at 09:55, Emil Velikov wrote: >> > Hi Drew, >> > >> > Just some food for thought. The patch in itself looks correct albeit >> > partial. >> > >> > On 27 June 2018 at

Re: [Mesa-dev] [PATCH] virgl: Support ARB_framebuffer_no_attachments

2018-06-28 Thread Drew Davenport
On Wed, Jun 27, 2018 at 6:47 AM Ilia Mirkin wrote: > > On Tue, Jun 26, 2018 at 7:00 PM, Drew Davenport > wrote: > > This change lets the following test pass on virgl: > > dEQP-GLES31.functional.state_query.framebuffer_default.framebuffer_default_samples_get_framebuffer_parameteriv > > --- > >

Re: [Mesa-dev] [PATCH] virgl: Support ARB_framebuffer_no_attachments

2018-06-28 Thread Drew Davenport
On Wed, Jun 27, 2018 at 1:57 AM Emil Velikov wrote: > > On 27 June 2018 at 09:55, Emil Velikov wrote: > > Hi Drew, > > > > Just some food for thought. The patch in itself looks correct albeit > > partial. > > > > On 27 June 2018 at 00:00, Drew Davenport wrote: > >> This change lets the

Re: [Mesa-dev] [PATCH v3] virgl: Add support for glGetMultisample

2018-06-28 Thread Erik Faye-Lund
On Thu, Jun 28, 2018 at 5:54 PM Gert Wollny wrote: > > Am Donnerstag, den 28.06.2018, 17:40 +0200 schrieb Erik Faye-Lund: > > On Thu, Jun 28, 2018 at 5:31 PM Gert Wollny > m> wrote: > > > > > > There are two aspects: > > > > > > For each number of samples there is indeed a fixes set of sample >

Re: [Mesa-dev] [PATCH v3] virgl: Add support for glGetMultisample

2018-06-28 Thread Gert Wollny
Am Donnerstag, den 28.06.2018, 17:40 +0200 schrieb Erik Faye-Lund: > On Thu, Jun 28, 2018 at 5:31 PM Gert Wollny m> wrote: > > > > There are two aspects: > > > > For each number of samples there is indeed a fixes set of sample > > positions that only depends on the hardware. The set

[Mesa-dev] [PATCH] anv: finish the binding_table_pool on destroyDevice when use_softpin

2018-06-28 Thread Jose Maria Casanova Crespo
Running VK-CTS in batch execution mode was raising the VK_ERROR_INITIALIZATION_FAILED error in multiple tests. But when the same failing tests were run isolated they always passed. createDevice and destroyDevice were called before and after every tests. Because the binding_table_pool was never

Re: [Mesa-dev] [PATCH v3] virgl: Add support for glGetMultisample

2018-06-28 Thread Erik Faye-Lund
On Thu, Jun 28, 2018 at 5:31 PM Gert Wollny wrote: > > Am Donnerstag, den 28.06.2018, 17:09 +0200 schrieb Erik Faye-Lund: > > Unless I'm misunderstanding, this seems to indicate that the hardware > > has a fixed set of sample positions, which I don't think is true for > > most hardware. Instead,

Re: [Mesa-dev] [PATCH v3] virgl: Add support for glGetMultisample

2018-06-28 Thread Gert Wollny
Am Donnerstag, den 28.06.2018, 17:09 +0200 schrieb Erik Faye-Lund: > Unless I'm misunderstanding, this seems to indicate that the hardware > has a fixed set of sample positions, which I don't think is true for > most hardware. Instead, the sample locations is a function of the > multisampling mode

Re: [Mesa-dev] [PATCH 1/2] radv: enable/disable prediction for the DCC decompression pass

2018-06-28 Thread Samuel Pitoiset
ping? On 04/18/2018 02:34 PM, Samuel Pitoiset wrote: Performing a DCC decompression pass is currently pretty rare, but using prediction allows the GPU to skip unnecessary passes. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_meta_fast_clear.c | 4 ++-- 1 file changed, 2

Re: [Mesa-dev] [PATCH v3] virgl: Add support for glGetMultisample

2018-06-28 Thread Erik Faye-Lund
Unless I'm misunderstanding, this seems to indicate that the hardware has a fixed set of sample positions, which I don't think is true for most hardware. Instead, the sample locations is a function of the multisampling mode for a given surface... On Thu, Jun 28, 2018 at 3:45 PM Gert Wollny

[Mesa-dev] [Bug 102227] Commit 26aee6f4d5 causes crash-loop on android-x86 (surfaceflinger to exit with status 1)

2018-06-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102227 --- Comment #4 from Dainius Masiliūnas --- I'm experiencing this as well, on an AMD Brazos machine. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the

[Mesa-dev] [PATCH 2/3] meson: do not use the deprecated wayland-scanner "code"

2018-06-28 Thread Emil Velikov
From: Emil Velikov With version v1.15 the "code" option was deprecated in favour of "private-code" or "public-code". Before the interface symbol generated was exported (which is a bad idea since it's internal implementation detail) and others may misuse it. That was the case with libva approx.

[Mesa-dev] [PATCH 1/3] meson: use dependency()+find_program() for wayland-scanner

2018-06-28 Thread Emil Velikov
From: Emil Velikov Helps when the native wayland-scanner is located outside of PATH. Inspired by the xserver code ;-) Cc: Dylan Baker Cc: Eric Engestrom Signed-off-by: Emil Velikov --- meson.build | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/meson.build

[Mesa-dev] [PATCH 3/3] autoconf: do not use the deprecated wayland-scanner "code"

2018-06-28 Thread Emil Velikov
From: Emil Velikov With version v1.15 the "code" option was deprecated in favour of "private-code" or "public-code". Before the interface symbol generated was exported (which is a bad idea since it's internal implementation detail) and others may misuse it. That was the case with libva approx.

Re: [Mesa-dev] [PATCH 0/4] fixes primarily for LLVM trunk support v2

2018-06-28 Thread Cherniak, Bruce
v2 Reviewed-by: Bruce Cherniak > On Jun 25, 2018, at 9:52 AM, Alok Hota wrote: > > These code changes were made in between some of the formatting changes. > Unforunately we do have another formatting patch coming in after this, > but I will keep that separate. > > These patches are primarily

[Mesa-dev] [PATCH v3] virgl: Add support for glGetMultisample

2018-06-28 Thread Gert Wollny
Use caps to obtain the multisample sample positions for up to 16 positions and implement the according Gallium interface. Fixes (when run on GL host): dEQP-GLES31.functional.texture.multisample.samples_1.sample_position dEQP-GLES31.functional.texture.multisample.samples_2.sample_position

Re: [Mesa-dev] [PATCH 2/4] swr/rast: Adding SCATTERPS functionality to BuilderGfxMem

2018-06-28 Thread Cherniak, Bruce
Reviewed-by: Bruce Cherniak > On Jun 25, 2018, at 9:52 AM, Alok Hota wrote: > > --- > .../swr/rasterizer/jitter/builder_gfx_mem.cpp | 13 + > .../drivers/swr/rasterizer/jitter/builder_gfx_mem.h | 6 ++ > 2 files changed, 19 insertions(+) > > diff --git

Re: [Mesa-dev] [PATCH 1/1] swr/rast: Updating code style based on current clang-format rules

2018-06-28 Thread Cherniak, Bruce
Reviewed-by: Bruce Cherniak > On Jun 22, 2018, at 9:11 AM, Alok Hota wrote: > > --- > .../swr/rasterizer/jitter/JitManager.cpp | 133 ++-- > .../swr/rasterizer/jitter/builder_gfx_mem.cpp | 90 + > .../swr/rasterizer/jitter/builder_gfx_mem.h | 101 +- >

Re: [Mesa-dev] [ANNOUNCE] mesa 18.1.3

2018-06-28 Thread Emil Velikov
Hi Dylan, On 27 June 2018 at 21:07, Dylan Baker wrote: > Hi list, > > Mesa 18.1.3 is planned for Friday June 29th, at 10AM PDT. > > Statistics for this release: > - 37 queued > - 0 nominated > - 2 rejected > Please have some distinction (in the title) wrt the actual release announcement. I've

Re: [Mesa-dev] [virglrenderer-devel] [PATCH] virgl/vtest: add support to vtest for new cap getting.

2018-06-28 Thread Jakob Bornecrantz
On 2018-06-27 23:26, Dave Airlie wrote: On 28 June 2018 at 03:25, Jakob Bornecrantz wrote: On 2018-06-08 07:22, Dave Airlie wrote: From: Dave Airlie The vtest protocol is pretty simple but also pretty dumb, and the v1 caps query was fixed size, with no nice way to expand it, however the

Re: [Mesa-dev] [PATCH 06/12] nir/opt_peephole_select: Don't try to remove flow control around indirect loads

2018-06-28 Thread Rob Clark
On Thu, Jun 28, 2018 at 12:46 AM, Ian Romanick wrote: > From: Ian Romanick > > That flow control may be trying to avoid invalid loads. On at least > some platforms, those loads can also be expensive. So for adreno, indirect uniform loads aren't really that expensive (it takes a few cycles to

Re: [Mesa-dev] [PATCH] anv/cmd_buffer: emit binding tables always if push constants are dirty

2018-06-28 Thread Iago Toral
On Thu, 2018-06-28 at 08:47 +0200, Iago Toral wrote: > On Wed, 2018-06-27 at 09:13 -0700, Jason Ekstrand wrote: > > On Wed, Jun 27, 2018 at 2:25 AM, Iago Toral > > wrote: > > > On Tue, 2018-06-26 at 10:59 -0700, Jason Ekstrand wrote: > > > > On Tue, Jun 26, 2018 at 4:08 AM, Iago Toral Quiroga >

Re: [Mesa-dev] Question about EGL_KHR_partial_update implementation

2018-06-28 Thread Frank Binns
Hi Qiang, Qiang Yu writes: > Hi Harish, > > I want to implement EGL_KHR_partial_update for lima mesa driver and find you > worked on Android/Wayland support for it: > https://patchwork.freedesktop.org/patch/160944/ > https://patchwork.freedesktop.org/patch/188695/ > > So I have some question

[Mesa-dev] [PATCH] radv: optimize vkCmd{Set, Reset}Event() a little bit

2018-06-28 Thread Samuel Pitoiset
Always emitting a bottom-of-pipe event is quite dumb. Instead, start to optimize these functions by syncing PFP for the top-of-pipe and syncing ME for the post-index-fetch event. This can still be improved by emitting EOS events for syncing PS and CS stages. Signed-off-by: Samuel Pitoiset ---

[Mesa-dev] Question about EGL_KHR_partial_update implementation

2018-06-28 Thread Qiang Yu
Hi Harish, I want to implement EGL_KHR_partial_update for lima mesa driver and find you worked on Android/Wayland support for it: https://patchwork.freedesktop.org/patch/160944/ https://patchwork.freedesktop.org/patch/188695/ So I have some question about it: your implementation seems to depend

Re: [Mesa-dev] [PATCH 11/11] ac/radv: using tls to store llvm related info and speed up compiles (v3)

2018-06-28 Thread Alex Smith
Hi Dave, I did a quick test with this on Rise of the Tomb Raider. It reduced the time taken to create all pipelines for the whole game over 8 threads (with RADV_DEBUG=nocache) from 12m24s to 11m35s. Nice improvement :) Also didn't see any issues, so: Tested-by: Alex Smith Thanks, Alex On 27

Re: [Mesa-dev] Radeonsi OpenGL 4.4 compat profile support

2018-06-28 Thread Mike Lothian
Hi I can confirm Dying Light is still working great with this series, it doesn't require any overrides and changes to the graphical settings no longer cause crashes Tropico 5 also launches and plays with the allow_higher_compat_version option removed from /etc/drirc (I don't own the other 2

[Mesa-dev] [PATCH 10/18] mesa: add missing display list support for ARB_compute_shader

2018-06-28 Thread Timothy Arceri
The extension is enabled for compat profile but there is currently no display list support. I filed a spec bug and it has been agreed that glDispatchComputeIndirect should generate an INVALID_OPERATION error when called during display list compilation. --- src/mesa/main/dlist.c | 39

[Mesa-dev] [PATCH 18/18] radeonsi: enable OpenGL 4.4 compat profile

2018-06-28 Thread Timothy Arceri
--- src/gallium/drivers/radeonsi/si_get.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_get.c b/src/gallium/drivers/radeonsi/si_get.c index 0e8617d0fee..96ff2a9e46b 100644 --- a/src/gallium/drivers/radeonsi/si_get.c +++

Re: [Mesa-dev] [PATCH] anv/cmd_buffer: emit binding tables always if push constants are dirty

2018-06-28 Thread Iago Toral
On Wed, 2018-06-27 at 09:13 -0700, Jason Ekstrand wrote: > On Wed, Jun 27, 2018 at 2:25 AM, Iago Toral > wrote: > > On Tue, 2018-06-26 at 10:59 -0700, Jason Ekstrand wrote: > > > On Tue, Jun 26, 2018 at 4:08 AM, Iago Toral Quiroga > > a.com> wrote: > > > > Storage images require to patch push

[Mesa-dev] [PATCH 17/18] mesa: enable ARB_vertex_attrib_64bit in compat profile

2018-06-28 Thread Timothy Arceri
--- src/mapi/glapi/gen/apiexec.py | 20 ++-- src/mesa/main/extensions_table.h| 2 +- src/mesa/main/tests/dispatch_sanity.cpp | 23 --- src/mesa/main/vtxfmt.c | 2 +- 4 files changed, 24 insertions(+), 23 deletions(-) diff

[Mesa-dev] [PATCH 15/18] vbo_save: add support for doubles to display list code

2018-06-28 Thread Timothy Arceri
From: Dave Airlie Required for ARB_vertex_attrib_64bit compat profile support. --- src/mesa/main/mtypes.h | 2 +- src/mesa/vbo/vbo_private.h | 3 +++ src/mesa/vbo/vbo_save_api.c | 18 -- src/mesa/vbo/vbo_save_draw.c | 18 +- 4 files changed, 29

[Mesa-dev] [PATCH 12/18] mesa: add ARB_draw_indirect support to compat profile

2018-06-28 Thread Timothy Arceri
--- src/mesa/main/bufferobj.c| 3 +- src/mesa/main/extensions_table.h | 2 +- src/mesa/vbo/vbo_exec_array.c| 66 +++- 3 files changed, 67 insertions(+), 4 deletions(-) diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c index

[Mesa-dev] [PATCH 16/18] mesa: add outstanding ARB_vertex_attrib_64bit dlist support

2018-06-28 Thread Timothy Arceri
--- src/mesa/main/dlist.c | 178 ++ 1 file changed, 178 insertions(+) diff --git a/src/mesa/main/dlist.c b/src/mesa/main/dlist.c index 5ff0a23018c..ae23d292837 100644 --- a/src/mesa/main/dlist.c +++ b/src/mesa/main/dlist.c @@ -471,6 +471,10 @@ typedef enum

[Mesa-dev] [PATCH 05/18] mesa: add glUniformSubroutinesuiv() display list support

2018-06-28 Thread Timothy Arceri
--- src/mesa/main/dlist.c | 34 ++ 1 file changed, 34 insertions(+) diff --git a/src/mesa/main/dlist.c b/src/mesa/main/dlist.c index d49eebae00d..2425cf24f1b 100644 --- a/src/mesa/main/dlist.c +++ b/src/mesa/main/dlist.c @@ -523,6 +523,9 @@ typedef enum /*

[Mesa-dev] [PATCH 11/18] mesa: generate GL_INVALID_OPERATION using draw indirect in dlist

2018-06-28 Thread Timothy Arceri
The spec doesn't explicitly say to generate an error but since DrawArraysInstanced* and DrawElementsInstanced* do, it makes sense to do it for these functions also. --- src/mesa/main/dlist.c | 47 +++ 1 file changed, 47 insertions(+) diff --git

[Mesa-dev] [PATCH 14/18] mesa: add compat profile support for ARB_multi_draw_indirect

2018-06-28 Thread Timothy Arceri
--- src/mesa/main/extensions_table.h | 2 +- src/mesa/vbo/vbo_exec_array.c| 75 +++- 2 files changed, 74 insertions(+), 3 deletions(-) diff --git a/src/mesa/main/extensions_table.h b/src/mesa/main/extensions_table.h index 1446a4bd421..12b796777df 100644 ---

[Mesa-dev] [PATCH 08/18] mesa: enable ARB_viewport_array in compat profile

2018-06-28 Thread Timothy Arceri
--- src/mapi/glapi/gen/apiexec.py | 16 src/mesa/main/extensions_table.h| 2 +- src/mesa/main/tests/dispatch_sanity.cpp | 17 + 3 files changed, 18 insertions(+), 17 deletions(-) diff --git a/src/mapi/glapi/gen/apiexec.py

[Mesa-dev] [PATCH 13/18] mesa: make valid_draw_indirect_multi() accessible externally

2018-06-28 Thread Timothy Arceri
We will use this to add compat support to ARB_multi_draw_indirect in the following patch. --- src/mesa/main/draw_validate.c | 24 src/mesa/main/draw_validate.h | 3 +++ 2 files changed, 15 insertions(+), 12 deletions(-) diff --git a/src/mesa/main/draw_validate.c

[Mesa-dev] [PATCH 06/18] mesa: enable ARB_shader_subroutine in compat profile

2018-06-28 Thread Timothy Arceri
--- src/mapi/glapi/gen/apiexec.py | 16 src/mesa/main/extensions_table.h| 2 +- src/mesa/main/tests/dispatch_sanity.cpp | 19 +-- 3 files changed, 18 insertions(+), 19 deletions(-) diff --git a/src/mapi/glapi/gen/apiexec.py

[Mesa-dev] [PATCH 02/18] mesa: add ProgramUniform*d display list support

2018-06-28 Thread Timothy Arceri
This is required for fp64 to be enabled in compat profile. --- src/mesa/main/dlist.c | 514 ++ 1 file changed, 514 insertions(+) diff --git a/src/mesa/main/dlist.c b/src/mesa/main/dlist.c index aec373b7ab1..d49eebae00d 100644 --- a/src/mesa/main/dlist.c

[Mesa-dev] [PATCH 09/18] mesa: expose some ARB_viewport_array dependent extensions in compat

2018-06-28 Thread Timothy Arceri
--- src/mesa/main/extensions_table.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/extensions_table.h b/src/mesa/main/extensions_table.h index f04fea9e3bc..f79a52cee8c 100644 --- a/src/mesa/main/extensions_table.h +++ b/src/mesa/main/extensions_table.h @@

[Mesa-dev] [PATCH 07/18] mesa: add ARB_viewport_array display list support

2018-06-28 Thread Timothy Arceri
--- src/mesa/main/dlist.c | 211 ++ 1 file changed, 211 insertions(+) diff --git a/src/mesa/main/dlist.c b/src/mesa/main/dlist.c index 2425cf24f1b..b2b1f723a17 100644 --- a/src/mesa/main/dlist.c +++ b/src/mesa/main/dlist.c @@ -290,6 +290,15 @@ typedef enum

[Mesa-dev] Radeonsi OpenGL 4.4 compat profile support

2018-06-28 Thread Timothy Arceri
Sorry to keep spamming the list with this stuff, but Dave helped out with ARB_vertex_attrib_64bit support and the spec bug I submitted for indirect compute dispatch was resolved so it seemed like a good idea to send it all out again together with these updates. Pretty much everything has

[Mesa-dev] [PATCH 01/18] mesa: add Uniform*d support to display lists

2018-06-28 Thread Timothy Arceri
This is required so we can enable fp64 support in compat profile. --- src/mapi/glapi/gen/apiexec.py | 36 +-- src/mesa/main/dlist.c | 493 ++ 2 files changed, 511 insertions(+), 18 deletions(-) diff --git a/src/mapi/glapi/gen/apiexec.py

[Mesa-dev] [PATCH 03/18] mesa: enable ARB_gpu_shader_fp64 in compat profile

2018-06-28 Thread Timothy Arceri
--- src/mesa/main/extensions_table.h| 2 +- src/mesa/main/tests/dispatch_sanity.cpp | 38 - 2 files changed, 20 insertions(+), 20 deletions(-) diff --git a/src/mesa/main/extensions_table.h b/src/mesa/main/extensions_table.h index 7af48a4ad91..5fe2e88fe98 100644

[Mesa-dev] [PATCH 04/18] mesa: stop hiding remaining query parameters from OpenGL compat

2018-06-28 Thread Timothy Arceri
I managed to miss these two in my last pass at this. --- src/mesa/main/get_hash_params.py | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/mesa/main/get_hash_params.py b/src/mesa/main/get_hash_params.py index 83136108e95..618e306e509 100644 ---