Re: [Mesa-dev] [PATCH 1/5] nir/cf: Remove phi sources if needed in nir_handle_add_jump

2018-10-02 Thread Iago Toral
On Tue, 2018-10-02 at 07:50 -0500, Jason Ekstrand wrote: > On Tue, Oct 2, 2018 at 7:30 AM Jason Ekstrand > wrote: > > On Tue, Oct 2, 2018 at 5:53 AM Iago Toral > > wrote: > > > On Sat, 2018-09-22 at 16:39 -0500, Jason Ekstrand wrote: > > > > > > > If the block in which the jump is inserted is

Re: [Mesa-dev] [PATCH] glsl/linker: Check the subroutine associated functions names

2018-10-02 Thread Tapani Pälli
On 10/2/18 7:38 PM, Vadym Shovkoplias wrote: Hi Tapani, Thanks for the review! Completely agree with the first comment, I'll change that and resend the patch. Regarding second comment. I'm not sure if it is possible to do this check after the optimization loop. From my observations

[Mesa-dev] [Bug 108135] AVX instructions leak outside of CPU feature check and cause SIGILL

2018-10-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108135 --- Comment #3 from Thiago Macieira --- (In reply to Thiago Macieira from comment #2) > The patch does solve the problem for the particular file, but there are more > AVX uses in swrast_dri.so. The next issue is the intialisation of the >

[Mesa-dev] [Bug 108135] AVX instructions leak outside of CPU feature check and cause SIGILL

2018-10-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108135 --- Comment #2 from Thiago Macieira --- The patch does solve the problem for the particular file, but there are more AVX uses in swrast_dri.so. The next issue is the intialisation of the builtin types in src/compiler/glsl_types.cpp, caused by:

Re: [Mesa-dev] shader cache backward compatibility

2018-10-02 Thread Timothy Arceri
On 3/9/18 6:53 pm, Alexander Larsson wrote: On Mon, Sep 3, 2018 at 10:41 AM Alexander Larsson wrote: On Fri, Aug 31, 2018 at 4:05 PM Emil Velikov wrote: Valid point - I forgot about that. A couple of ideas come to mind: - static link LLVM (Flatpak already does it) No LLVM changes

Re: [Mesa-dev] [PATCH 2/2] nir: Expose nir_remove_unused_io_vars().

2018-10-02 Thread Timothy Arceri
On 29/9/18 5:52 am, Eric Anholt wrote: For gallium drivers where you want to do some linking at variant compile time, you don't have the other producer/consumer shader on hand to modify. By exposing the inner function, the driver can have the used varyings in the compiled shader cache key and

Re: [Mesa-dev] [PATCH 9/9] i965/tex_image: Drop intelCompressedTexSubImage

2018-10-02 Thread Nanley Chery
On Wed, Sep 26, 2018 at 04:31:11PM -0700, Nanley Chery wrote: > Effectively revert 710b1d2e665ed654fb8d52b146fa22469e1dc3a7. > > This function was created to perform the ASTC void-extent workaround. > Now that the workaround is handled prior to sampling, this function is > no longer necessary.

Re: [Mesa-dev] [PATCH 0/9] i965: Re-implement the gen9 void-extent ASTC WA with BLORP

2018-10-02 Thread Nanley Chery
On Wed, Sep 26, 2018 at 04:31:02PM -0700, Nanley Chery wrote: > The current workaround has two issues. It causes significant slow-downs [1] in > application startup times and uses the modified ASTC blocks for non-sampling > operations. This can result in incorrect texture downloads. > > This

Re: [Mesa-dev] [PATCH 01/13] mesa: add a list of EXT_direct_state_access to dispatch sanity

2018-10-02 Thread Timothy Arceri
On 3/10/18 7:50 am, Marek Olšák wrote: This is probably OK, though the TODO list in features.txt should also be updated when a new subset is implemented. Sure now that we have one :) Thanks for the feedback on the series. However priorities have changed since I sent this series. Also it

Re: [Mesa-dev] [PATCH] util/u_queue: don't inherit thread affinity from parent thread

2018-10-02 Thread Marek Olšák
On Tue, Oct 2, 2018 at 6:36 PM Rob Clark wrote: > > On Tue, Oct 2, 2018 at 6:30 PM Marek Olšák wrote: > > > > From: Marek Olšák > > > > --- > > src/util/u_queue.c | 12 > > 1 file changed, 12 insertions(+) > > > > diff --git a/src/util/u_queue.c b/src/util/u_queue.c > > index

[Mesa-dev] [PATCH 11/15] radeonsi: center viewport to improve guardband clipping for high resolutions

2018-10-02 Thread Marek Olšák
From: Marek Olšák This will be more useful when we change the quant mode to increase subpixel precision and decrease the viewport range (which might not be possible if the viewport is not centered in the viewport range). --- src/gallium/drivers/radeonsi/si_gfx_cs.c | 1 +

[Mesa-dev] [PATCH 15/15] radeonsi: use higher subpixel precision (QUANT_MODE) for smaller viewports

2018-10-02 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_get.c | 4 +- src/gallium/drivers/radeonsi/si_pipe.h| 8 +++ .../drivers/radeonsi/si_state_viewport.c | 50 --- 3 files changed, 53 insertions(+), 9 deletions(-) diff --git

[Mesa-dev] [PATCH 14/15] radeonsi: move emission of PA_SU_VTX_CNTL into emit_guardband

2018-10-02 Thread Marek Olšák
From: Marek Olšák We'll modify the quant mode there, which also affects the guarband computation. --- src/gallium/drivers/radeonsi/si_gfx_cs.c | 1 + src/gallium/drivers/radeonsi/si_state.c | 8 +++- src/gallium/drivers/radeonsi/si_state.h | 2 ++

[Mesa-dev] [PATCH 13/15] radeonsi: don't re-upload the sample position constant buffer repeatedly

2018-10-02 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_pipe.c | 7 +++ src/gallium/drivers/radeonsi/si_pipe.h | 13 - src/gallium/drivers/radeonsi/si_state.c | 19 +-- src/gallium/drivers/radeonsi/si_state_msaa.c | 10 +- 4 files changed,

[Mesa-dev] [PATCH 12/15] radeonsi: set PA_SU_PRIM_FILTER_CNTL optimally

2018-10-02 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_gfx_cs.c | 1 + src/gallium/drivers/radeonsi/si_state.c | 15 +++ src/gallium/drivers/radeonsi/si_state.h | 1 + 3 files changed, 13 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_gfx_cs.c

[Mesa-dev] [PATCH 08/15] radeonsi: add GDS support to CP DMA

2018-10-02 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_cp_dma.c | 104 ++- src/gallium/drivers/radeonsi/si_pipe.c | 4 + src/gallium/drivers/radeonsi/si_pipe.h | 2 + 3 files changed, 89 insertions(+), 21 deletions(-) diff --git

[Mesa-dev] [PATCH 09/15] radeonsi: switch back to standard DX sample positions

2018-10-02 Thread Marek Olšák
From: Marek Olšák Apps may rely on them. --- src/gallium/drivers/radeonsi/si_state_msaa.c | 43 1 file changed, 26 insertions(+), 17 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_state_msaa.c b/src/gallium/drivers/radeonsi/si_state_msaa.c index

[Mesa-dev] [PATCH 10/15] radeonsi: save raster config in screen, add se_tile_repeat

2018-10-02 Thread Marek Olšák
From: Marek Olšák --- src/amd/common/ac_gpu_info.c| 13 +++-- src/amd/common/ac_gpu_info.h| 3 ++- src/amd/vulkan/si_cmd_buffer.c | 2 +- src/gallium/drivers/radeonsi/si_pipe.c | 9 + src/gallium/drivers/radeonsi/si_pipe.h | 3 +++

[Mesa-dev] [PATCH 07/15] radeonsi: rename si_gfx_* functions to si_cp_*

2018-10-02 Thread Marek Olšák
From: Marek Olšák and write_event_eop -> release_mem --- src/amd/common/sid.h | 1 + src/gallium/drivers/radeonsi/si_fence.c | 32 +-- src/gallium/drivers/radeonsi/si_perfcounter.c | 14 src/gallium/drivers/radeonsi/si_pipe.h| 16

[Mesa-dev] [PATCH 01/15] ac: define all address spaces properly

2018-10-02 Thread Marek Olšák
From: Marek Olšák --- src/amd/common/ac_llvm_build.c | 10 +- src/amd/common/ac_llvm_build.h | 10 ++ src/amd/common/ac_nir_to_llvm.c | 2 +- src/amd/vulkan/radv_nir_to_llvm.c| 2 +- src/gallium/drivers/radeonsi/si_shader.c | 6 +++--- 5

[Mesa-dev] [PATCH 04/15] ac: add ac_build_round

2018-10-02 Thread Marek Olšák
From: Marek Olšák --- src/amd/common/ac_llvm_build.c| 19 +-- src/amd/common/ac_llvm_build.h| 1 + src/amd/common/ac_nir_to_llvm.c | 2 +- .../drivers/radeonsi/si_shader_tgsi_mem.c | 4 +--- 4 files changed, 20 insertions(+),

[Mesa-dev] [PATCH 03/15] ac: correct PKT3_COPY_DATA definitions

2018-10-02 Thread Marek Olšák
From: Marek Olšák --- src/amd/common/sid.h | 11 +-- src/amd/vulkan/radv_cmd_buffer.c | 6 +++--- src/amd/vulkan/radv_query.c | 8 src/gallium/drivers/radeonsi/si_compute.c | 2 +-

[Mesa-dev] [PATCH 02/15] ac: simplify LLVM alloca helpers

2018-10-02 Thread Marek Olšák
From: Marek Olšák --- src/amd/common/ac_llvm_build.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/src/amd/common/ac_llvm_build.c b/src/amd/common/ac_llvm_build.c index 4cbf599d946..fc6dc396d38 100644 --- a/src/amd/common/ac_llvm_build.c +++

[Mesa-dev] [PATCH 06/15] radeonsi: fix a typo at CS_PARTIAL_FLUSH

2018-10-02 Thread Marek Olšák
From: Marek Olšák harmless --- src/gallium/drivers/radeonsi/si_state_draw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_state_draw.c b/src/gallium/drivers/radeonsi/si_state_draw.c index 3d56d8e9ab4..81eb34d75e2 100644 ---

[Mesa-dev] [PATCH 05/15] radeonsi: make si_gfx_write_event_eop more configurable

2018-10-02 Thread Marek Olšák
From: Marek Olšák --- src/amd/common/sid.h | 5 + src/gallium/drivers/radeonsi/si_fence.c | 19 ++- src/gallium/drivers/radeonsi/si_perfcounter.c | 2 ++ src/gallium/drivers/radeonsi/si_pipe.h| 2 +-

[Mesa-dev] [PATCH 00/15] A bunch of shared code and RadeonSI changes

2018-10-02 Thread Marek Olšák
Hi, Interesting bits: - CP DMA support for GDS (unused but there is a test) - switch back to DX sample positions - center the viewport in the scanline area for maximizing the guardband - optimal PA_SU_PRIM_FILTER_CNTL - higher subpixel precision for 4K and lower resolutions (for more precise

[Mesa-dev] [PATCH] util/u_queue: don't inherit thread affinity from parent thread

2018-10-02 Thread Marek Olšák
From: Marek Olšák --- src/util/u_queue.c | 12 1 file changed, 12 insertions(+) diff --git a/src/util/u_queue.c b/src/util/u_queue.c index 22d2cdd0fa2..9dd1a69ed7a 100644 --- a/src/util/u_queue.c +++ b/src/util/u_queue.c @@ -232,20 +232,32 @@ struct thread_input { }; static

Re: [Mesa-dev] [PATCH 09/13] mesa: add support for glMapNamedBufferRangeEXT()

2018-10-02 Thread Marek Olšák
On Sat, Sep 8, 2018 at 12:33 AM Timothy Arceri wrote: > > --- > .../glapi/gen/EXT_direct_state_access.xml | 10 + > src/mesa/main/bufferobj.c | 45 +-- > src/mesa/main/bufferobj.h | 3 ++ > src/mesa/main/tests/dispatch_sanity.cpp

Re: [Mesa-dev] [PATCH 08/13] mesa: add support for glNamedBufferStorageEXT

2018-10-02 Thread Marek Olšák
features.txt can be updated. Marek On Sat, Sep 8, 2018 at 12:34 AM Timothy Arceri wrote: > > This is available in ARB_buffer_storage when > EXT_direct_state_access is present. > --- > src/mapi/glapi/gen/gl_API.xml | 7 +++ > src/mesa/main/bufferobj.c | 15

[Mesa-dev] [PATCH] anv/batch_chain: Don't start a new BO just for BATCH_BUFFER_START

2018-10-02 Thread Jason Ekstrand
Previously, we just went ahead and emitted MI_BATCH_BUFFER_START as normal. If we are near enough to the end, this can cause us to start a new BO just for the MI_BATCH_BUFFER_START which messes up chaining. We always reserve enough space at the end for an MI_BATCH_BUFFER_START so we can just

[Mesa-dev] [Bug 108135] AVX instructions leak outside of CPU feature check and cause SIGILL

2018-10-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108135 --- Comment #1 from Thiago Macieira --- Created attachment 141840 --> https://bugs.freedesktop.org/attachment.cgi?id=141840=edit Attempt at making the variables local static -- You are receiving this mail because: You are the QA Contact for

Re: [Mesa-dev] [PATCH 04/13] glapi: add EXT_direct_state_access

2018-10-02 Thread Marek Olšák
The patch subject should be changed, because it adds only a tiny subset of the extension. Marek On Sat, Sep 8, 2018 at 12:32 AM Timothy Arceri wrote: > > From: Chris Forbes > > Signed-off-by: Chris Forbes > --- > .../glapi/gen/EXT_direct_state_access.xml | 101 ++ >

Re: [Mesa-dev] [PATCH 03/13] mesa: EXT_dsa add selectorless matrix stack functions

2018-10-02 Thread Marek Olšák
features.txt should be updated. Marek On Sat, Sep 8, 2018 at 12:31 AM Timothy Arceri wrote: > > From: Chris Forbes > > Allows the legacy matrix stacks to be manipulated without disturbing the > matrix mode selector. > > Signed-off-by: Chris Forbes > --- > src/mesa/main/matrix.c | 370

Re: [Mesa-dev] [PATCH 01/13] mesa: add a list of EXT_direct_state_access to dispatch sanity

2018-10-02 Thread Marek Olšák
This is probably OK, though the TODO list in features.txt should also be updated when a new subset is implemented. Marek On Sat, Sep 8, 2018 at 12:32 AM Timothy Arceri wrote: > > This extension is huge and this gives us a TODO list of functions > to implement. > --- >

Re: [Mesa-dev] Meson-windows v4 (9/21/2018 rebase): LLVM linking problems

2018-10-02 Thread Dylan Baker
Quoting Liviu Prodea (2018-10-02 14:05:09) > > > > > > > On Tuesday, October 2, 2018, 8:08:39 PM GMT+3, Dylan Baker > wrote: > > > Quoting Liviu Prodea (2018-10-02 08:08:41) > > Made a comprehensive test of this patch series and I still stumbled upon > > some > > big problems: > > > > 1.

Re: [Mesa-dev] [PATCH] radeonsi: avoid sending GS_EMIT in shaders without outputs

2018-10-02 Thread Marek Olšák
Pushed, thanks! Marek On Sun, Sep 23, 2018 at 6:45 PM Józef Kucia wrote: > > Fixes GPU hangs. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107857 > Signed-off-by: Józef Kucia > --- > src/gallium/drivers/radeonsi/si_shader.c | 9 ++--- > 1 file changed, 6 insertions(+), 3

[Mesa-dev] [PATCH] anv: Use separate MOCS settings for external BOs

2018-10-02 Thread Jason Ekstrand
On Broadwell and above, we have to use different MOCS settings to allow the kernel to take over and disable caching when needed for external buffers. On Broadwell, this is especially important because the kernel can't disable eLLC so we have to do it in userspace. We very badly don't want to do

Re: [Mesa-dev] Meson-windows v4 (9/21/2018 rebase): LLVM linking problems

2018-10-02 Thread Liviu Prodea
On Tuesday, October 2, 2018, 8:08:39 PM GMT+3, Dylan Baker wrote: Quoting Liviu Prodea (2018-10-02 08:08:41) > Made a comprehensive test of this patch series and I still stumbled upon some > big problems: > > 1. Automatic LLVM linking via llvm-config if used by adding LLVM bin

[Mesa-dev] [Bug 108135] AVX instructions leak outside of CPU feature check and cause SIGILL

2018-10-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108135 Bug ID: 108135 Summary: AVX instructions leak outside of CPU feature check and cause SIGILL Product: Mesa Version: git Hardware: Other OS: All

[Mesa-dev] [Bug 108135] AVX instructions leak outside of CPU feature check and cause SIGILL

2018-10-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108135 Thiago Macieira changed: What|Removed |Added Assignee|mesa-dev@lists.freedesktop. |timothy.o.row...@intel.com

Re: [Mesa-dev] [PATCH 5/6] r600: use build-id when available for disk cache

2018-10-02 Thread Marek Olšák
For the series: Reviewed-by: Marek Olšák Marek On Tue, Sep 18, 2018 at 10:14 PM Timothy Arceri wrote: > > --- > src/gallium/drivers/r600/r600_pipe_common.c | 14 +++--- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/src/gallium/drivers/r600/r600_pipe_common.c >

Re: [Mesa-dev] [PATCH 2/3] configure: allow building with python3

2018-10-02 Thread Dylan Baker
I haven't had a chance to do that yet. I'll see if I can find some time this week. Quoting Emil Velikov (2018-10-02 08:02:12) > Hi Dylan, > > On Mon, 3 Sep 2018 at 14:57, Emil Velikov wrote: > > > > On 24 August 2018 at 19:51, Dylan Baker wrote: > > > Can we just change the script to write a

Re: [Mesa-dev] [PATCH mesa 1/4] meson: turn git_sha1.h target into a proper dependency

2018-10-02 Thread Dylan Baker
Quoting Eric Engestrom (2018-10-02 07:09:03) > Cc: mesa-sta...@lists.freedesktop.org > Signed-off-by: Eric Engestrom > --- > src/mesa/meson.build | 3 +-- > src/meson.build | 13 - > 2 files changed, 9 insertions(+), 7 deletions(-) > > diff --git a/src/mesa/meson.build

Re: [Mesa-dev] [PATCH] meson: Don't allow building EGL on on KMS systems or Haiku

2018-10-02 Thread Dylan Baker
That might be possible. I'll double check. Dylan Quoting Ilia Mirkin (2018-10-01 20:58:20) > Shouldn't it be possible to use the x11 platform (+drisw)? > On Mon, Oct 1, 2018 at 3:43 PM Dylan Baker wrote: > > > > Currently mesa only supports EGL for KMS (Linux, *BSD) systems and > > Haiku, we

Re: [Mesa-dev] [PATCH 1/5] util: import public domain code for integer division by a constant

2018-10-02 Thread Jason Ekstrand
On Tue, Oct 2, 2018 at 3:20 PM Marek Olšák wrote: > > On Tue, Oct 2, 2018, 1:15 PM Jason Ekstrand wrote: > >> Reading through things in a bit more detail, I do believe that importing >> this version in some form would be better than using mine for a number of >> reasons: >> >> * It is better

Re: [Mesa-dev] [PATCH 1/5] util: import public domain code for integer division by a constant

2018-10-02 Thread Marek Olšák
On Tue, Oct 2, 2018, 1:15 PM Jason Ekstrand wrote: > Reading through things in a bit more detail, I do believe that importing > this version in some form would be better than using mine for a number of > reasons: > > * It is better optimized for signed integers > * The struct of division

[Mesa-dev] [Bug 108062] Mesa 18.2.0 and Mesa 18.2.1 RADV Freeze

2018-10-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108062 marco.grima...@gmail.com changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

Re: [Mesa-dev] [PATCH] st/va:Aligned image width and height to 16.

2018-10-02 Thread Ilia Mirkin
vlVaGetImage should respect the x/y/width/height. The surface size need not have any correlation to the image size. Someone should double-check the docs for how that function should work, but the current logic seems completely bogus. On Tue, Oct 2, 2018 at 3:09 PM Koenig, Christian wrote: > >

Re: [Mesa-dev] [PATCH mesa v2] i965: searching the cache doesn't need to modify it

2018-10-02 Thread Kenneth Graunke
The best way to make this code more readable is to replace it entirely. It's horribly overcomplicated for what is basically an open-coded hash table. I've had various starts at that...but never quite managed to finish. :( You could probably grab iris_program_cache.c from my iris branch, make it

Re: [Mesa-dev] [PATCH] st/va:Aligned image width and height to 16.

2018-10-02 Thread Koenig, Christian
Well that's the complete wrong place for that. The stride of the surface is determined by addrlib. That one should handle aligning the parameters. Christian. Am 02.10.2018 20:38 schrieb "Sharma, Deepak" : Christian, the issue which trying to address here is vlvaGetImage doesn’t use

Re: [Mesa-dev] [PATCH] st/va:Aligned image width and height to 16.

2018-10-02 Thread Sharma, Deepak
Christian, the issue which trying to address here is vlvaGetImage doesn’t use width/height passed to function. box.width is calculated from surface and that will end up in wrong stride for dst buffer for said resolution. So was thinking to use aligned width/height for vaCreateImage as well as

[Mesa-dev] [PATCH 4/9] i965: Map the query results for the life of the bo

2018-10-02 Thread Chris Wilson
If we map the bo upon creation, we can avoid the latency of mmapping it when querying, and later use the asynchronous, persistent map of the predicate to do a quick query. v2: Inline the wait on results; it disappears shortly in the next few patches. Signed-off-by: Chris Wilson Cc: Kenneth

[Mesa-dev] [PATCH 1/9] i965: Check last known busy status on bo before asking the kernel

2018-10-02 Thread Chris Wilson
If we know the bo is idle (that is we have no submitted a command buffer referencing this bo since the last query) we can skip asking the kernel. Note this may report a false negative if the target is being shared between processes (exported via dmabuf or flink). To allow the caller control over

[Mesa-dev] [PATCH 6/9] i965: Use 'available' fence for polling query results

2018-10-02 Thread Chris Wilson
If we always write the 'available' flag after writing the final result of the query, we can probe that predicate to quickly query whether the result is ready from userspace. The primary advantage of checking the predicate is that it allows for more fine-grained queries, we do not have to wait for

[Mesa-dev] [PATCH 9/9] i965: Set query->flush after flushing the query

2018-10-02 Thread Chris Wilson
Skip the next check for brw_batch_references() by recording when we flush the query. --- src/mesa/drivers/dri/i965/gen6_queryobj.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/mesa/drivers/dri/i965/gen6_queryobj.c b/src/mesa/drivers/dri/i965/gen6_queryobj.c

[Mesa-dev] [PATCH 5/9] i965: Use snoop bo for accessing query results on !llc

2018-10-02 Thread Chris Wilson
Ony non-llc architectures where we are primarily reading back the results of the GPU queries, then we can improve performance by using a cacheable mapping of the results. Unfortunately, enabling snooping makes the writes from the GPU slower, which may adversely affect pipelined query operations

[Mesa-dev] [PATCH 3/9] i965: Replace open-coded gen6 queryobj offsets with simple helpers

2018-10-02 Thread Chris Wilson
Lots of places open-coded the assumed layout of the predicate/results within the query object, replace those with simple helpers. v2: Fix function decl style. Signed-off-by: Chris Wilson Cc: Kenneth Graunke Cc: Matt Turner --- .../drivers/dri/i965/brw_conditional_render.c | 10 --

[Mesa-dev] [PATCH 8/9] i965: Pass consistent args along gen6_queryobj.c

2018-10-02 Thread Chris Wilson
Be consistent in passing along brw_context rather than switching between that and gl_context. Signed-off-by: Chris Wilson --- src/mesa/drivers/dri/i965/gen6_queryobj.c | 30 +++ 1 file changed, 14 insertions(+), 16 deletions(-) diff --git

[Mesa-dev] [PATCH 2/9] i965: Replace hard-coded indices with const named variables in gen6_queryobj

2018-10-02 Thread Chris Wilson
To simplify replacement later, replace repeated use of explicit 0/1 with local variables of the same value. Signed-off-by: Chris Wilson Cc: Kenneth Graunke Cc: Matt Turner --- src/mesa/drivers/dri/i965/gen6_queryobj.c | 30 --- 1 file changed, 16 insertions(+), 14

[Mesa-dev] [PATCH 7/9] i965: Pack simple pipelined query objects into the same buffer

2018-10-02 Thread Chris Wilson
Reuse the same query object buffer for multiple queries within the same batch. A task for the future is propagating the GL_NO_MEMORY errors. Signed-off-by: Chris Wilson Cc: Kenneth Graunke Cc: Matt Turner --- src/mesa/drivers/dri/i965/brw_context.c | 3 ++

[Mesa-dev] [Bug 107832] Gallium picking A16L16 formats when emulating INTENSITY16 conflicts with mesa

2018-10-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107832 --- Comment #2 from Gert Wollny --- Yes, it fixes the bug - I proposed and pushed the patch ;) -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the

Re: [Mesa-dev] [PATCH 1/5] util: import public domain code for integer division by a constant

2018-10-02 Thread Jason Ekstrand
Reading through things in a bit more detail, I do believe that importing this version in some form would be better than using mine for a number of reasons: * It is better optimized for signed integers * The struct of division factors is much better than what I did. (I did consider a struct and

Re: [Mesa-dev] Meson-windows v4 (9/21/2018 rebase): LLVM linking problems

2018-10-02 Thread Dylan Baker
Quoting Liviu Prodea (2018-10-02 08:08:41) > Made a comprehensive test of this patch series and I still stumbled upon some > big problems: > > 1. Automatic LLVM linking via llvm-config if used by adding LLVM bin folder to > PATH results in build failure with 'llvm-c/Core.h' not found in

Re: [Mesa-dev] [PATCH] glsl/linker: Check the subroutine associated functions names

2018-10-02 Thread Vadym Shovkoplias
Hi Tapani, Thanks for the review! Completely agree with the first comment, I'll change that and resend the patch. Regarding second comment. I'm not sure if it is possible to do this check after the optimization loop. From my observations compiler inlines everything and only after that it removes

[Mesa-dev] [Bug 107594] [PATCH] fix crosscompilling with meson

2018-10-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107594 --- Comment #3 from Dylan Baker --- Are you running into this issue, by chance: https://github.com/mesonbuild/meson/issues/4254 -- You are receiving this mail because: You are the QA Contact for the

Re: [Mesa-dev] [PATCH] i965: Replace checks for rb->Name with FlipY (v2)

2018-10-02 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand On Mon, Sep 17, 2018 at 3:52 PM Fritz Koenig wrote: > In the GL_MESA_framebuffer_flip_y implementation > _mesa_is_winsys_fbo checks were replaced with > FlipY checks. rb->Name is also used to determine > if a buffer is winsys. > > v2: Fixes annotation [for emil] >

Re: [Mesa-dev] [PATCH mesa 1/3] include: sync eglplatform.h from Khronos

2018-10-02 Thread Eric Engestrom
On Tuesday, 2018-10-02 16:32:44 +0100, Emil Velikov wrote: > Hi Eric, > > On Sun, 10 Jun 2018 at 09:36, Eric Engestrom wrote: > > > > An issue [1] was recently raised with the upstream eglplatform.h, as my > > upstreaming of the "X11 on Apple" resulted in Apple platforms to always > > try to

[Mesa-dev] [PATCH] i965: consider a 'base level' when calculating width0, height0, depth0

2018-10-02 Thread asimiklit . work
From: Andrii Simiklit I guess that when we calculating the width0, height0, depth0 to use for function 'intel_miptree_create' we need to consider the 'base level' like it is done in the 'intel_miptree_create_for_teximage' function. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107987

[Mesa-dev] [Bug 108118] AMDGPU sometimes hangs forever when running graphical applications

2018-10-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108118 --- Comment #3 from duoora...@gmail.com --- Problem also occurs with kernel 4.17.14, it is not 4.18+ specific. Dmesg output for the hang under 4.17.14 was: [drm:amdgpu_job_timedout [amdgpu]] *ERROR* ring gfx timeout, last signaled seq=73798

Re: [Mesa-dev] [PATCH mesa 1/3] include: sync eglplatform.h from Khronos

2018-10-02 Thread Emil Velikov
Hi Eric, On Sun, 10 Jun 2018 at 09:36, Eric Engestrom wrote: > > An issue [1] was recently raised with the upstream eglplatform.h, as my > upstreaming of the "X11 on Apple" resulted in Apple platforms to always > try to include X11 headers. > > The solution [2] was to also upstream our

[Mesa-dev] [Bug 108118] AMDGPU sometimes hangs forever when running graphical applications

2018-10-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108118 --- Comment #2 from duoora...@gmail.com --- I've failed to replicate the problem with both Wine DX9 games (backed by OpenGL) and Dota 2's OpenGL mode so I think it is a Vulkan specific issue. Will test an older kernel next. -- You are

[Mesa-dev] Meson-windows v4 (9/21/2018 rebase): LLVM linking problems

2018-10-02 Thread Liviu Prodea
Made a comprehensive test of this patch series and I still stumbled upon some big problems: 1. Automatic LLVM linking via llvm-config if used by adding LLVM bin folder to PATH results in build failure with 'llvm-c/Core.h' not found in  src/gallium/auxiliary/gallivm/lp_bld.h. Appveyor CI from

Re: [Mesa-dev] [PATCH 2/3] configure: allow building with python3

2018-10-02 Thread Emil Velikov
Hi Dylan, On Mon, 3 Sep 2018 at 14:57, Emil Velikov wrote: > > On 24 August 2018 at 19:51, Dylan Baker wrote: > > Can we just change the script to write a file instead of sending it's output > > through the shell? That should fix any encoding problems since the shell > > wont > > touch it and

Re: [Mesa-dev] [PATCH v1] loader/dri3: wait for fences if back-buffer available

2018-10-02 Thread Michel Dänzer
On 2018-10-01 4:35 p.m., Sergii Romantsov wrote: > Yes, it also works Great, thanks for testing! Sent out a proper patch for review: https://patchwork.freedesktop.org/patch/254393/ -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast

[Mesa-dev] [PATCH] loader/dri3: Also wait for front buffer fence if we triggered it

2018-10-02 Thread Michel Dänzer
From: Michel Dänzer In that case, we have to wait for the fence to synchronize with the corresponding drawing we triggered in the X server. Fixes incorrect display with the i965 and some applications, e.g. solvespace. Bugzilla: https://bugs.freedesktop.org/108097 Fixes: aefac10fecc9

Re: [Mesa-dev] [PATCH mesa v2] i965: searching the cache doesn't need to modify it

2018-10-02 Thread Eric Engestrom
Ping? I'm just adding `const` to make it easier to read and understand the code, and allow the compiler to tell us if we make a mistake and start modifying things shouldn't. On Tuesday, 2018-08-07 12:02:53 +0100, Eric Engestrom wrote: > Signed-off-by: Eric Engestrom > --- > v2: forgot the hunk

[Mesa-dev] [PATCH mesa 4/4] clover: add missing meson build dependency

2018-10-02 Thread Eric Engestrom
Fixes: 42ea0631f108d82554339 "meson: build clover" Signed-off-by: Eric Engestrom --- src/gallium/state_trackers/clover/meson.build | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/state_trackers/clover/meson.build b/src/gallium/state_trackers/clover/meson.build index

[Mesa-dev] [PATCH mesa 3/4] svga: add missing meson build dependency

2018-10-02 Thread Eric Engestrom
Fixes: a537231b226280bc1e5b7 "meson: build svga driver on linux" Signed-off-by: Eric Engestrom --- src/gallium/drivers/svga/meson.build | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/svga/meson.build b/src/gallium/drivers/svga/meson.build index

[Mesa-dev] [PATCH mesa 2/4] anv: add missing meson build dependency

2018-10-02 Thread Eric Engestrom
Fixes: e4538b93f5d5177318f2 "anv: Implement VK_KHR_driver_properties" Signed-off-by: Eric Engestrom --- src/intel/vulkan/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/vulkan/meson.build b/src/intel/vulkan/meson.build index

[Mesa-dev] [PATCH mesa 1/4] meson: turn git_sha1.h target into a proper dependency

2018-10-02 Thread Eric Engestrom
Cc: mesa-sta...@lists.freedesktop.org Signed-off-by: Eric Engestrom --- src/mesa/meson.build | 3 +-- src/meson.build | 13 - 2 files changed, 9 insertions(+), 7 deletions(-) diff --git a/src/mesa/meson.build b/src/mesa/meson.build index

Re: [Mesa-dev] [PATCH mesa] anv: suppress warning about unhandled image layout

2018-10-02 Thread Jason Ekstrand
Rb On October 2, 2018 08:33:37 Eric Engestrom wrote: Let's just be explicit that VK_NV_shading_rate_image is not supported. Suggested-by: Jason Ekstrand Fixes: 6ee17091708a41c4aa81a "vulkan: Update the XML and headers to 1.1.86" Signed-off-by: Eric Engestrom ---

[Mesa-dev] [PATCH mesa] anv: suppress warning about unhandled image layout

2018-10-02 Thread Eric Engestrom
Let's just be explicit that VK_NV_shading_rate_image is not supported. Suggested-by: Jason Ekstrand Fixes: 6ee17091708a41c4aa81a "vulkan: Update the XML and headers to 1.1.86" Signed-off-by: Eric Engestrom --- src/intel/vulkan/anv_image.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

Re: [Mesa-dev] [PATCH 1/5] nir/cf: Remove phi sources if needed in nir_handle_add_jump

2018-10-02 Thread Jason Ekstrand
On Tue, Oct 2, 2018 at 7:30 AM Jason Ekstrand wrote: > On Tue, Oct 2, 2018 at 5:53 AM Iago Toral wrote: > >> On Sat, 2018-09-22 at 16:39 -0500, Jason Ekstrand wrote: >> > If the block in which the jump is inserted is the predecessor of a >> > phi >> > then we need to remove phi sources

Re: [Mesa-dev] [PATCH 1/5] nir/cf: Remove phi sources if needed in nir_handle_add_jump

2018-10-02 Thread Jason Ekstrand
On Tue, Oct 2, 2018 at 5:53 AM Iago Toral wrote: > On Sat, 2018-09-22 at 16:39 -0500, Jason Ekstrand wrote: > > If the block in which the jump is inserted is the predecessor of a > > phi > > then we need to remove phi sources otherwise the phi may end up with > > things improperly connected.

Re: [Mesa-dev] [PATCH 1/6] util: rename timestamp param in disk_cache_create()

2018-10-02 Thread Timothy Arceri
Ping on patches 1-5 I've pushed patch 6. On 19/9/18 12:13 pm, Timothy Arceri wrote: Only some drivers use a timestamp here. Others use things such as build-id, or even a combination of build-ids from Mesa and LLVM. --- src/util/disk_cache.c | 8 1 file changed, 4 insertions(+), 4

[Mesa-dev] [PATCH mesa] egl: sync headers from Khronos

2018-10-02 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- include/EGL/egl.h | 8 include/EGL/eglext.h | 9 + include/EGL/eglplatform.h | 8 3 files changed, 13 insertions(+), 12 deletions(-) diff --git a/include/EGL/egl.h b/include/EGL/egl.h index

Re: [Mesa-dev] [PATCH 0/5] nir, spirv: Fix bugs uncovered by spirv-opt

2018-10-02 Thread Iago Toral
On Tue, 2018-10-02 at 12:54 +0200, Iago Toral wrote: > Letf a couple of minor comments, but otherwise the series is: > > Reviewed-by: Iago Toral Quiorga s/Quiorga/Quiroga > On Sat, 2018-09-22 at 16:39 -0500, Jason Ekstrand wrote: > > This little series fixes three bugs encountered while

Re: [Mesa-dev] [PATCH 0/5] nir, spirv: Fix bugs uncovered by spirv-opt

2018-10-02 Thread Iago Toral
Letf a couple of minor comments, but otherwise the series is: Reviewed-by: Iago Toral Quiorga On Sat, 2018-09-22 at 16:39 -0500, Jason Ekstrand wrote: > This little series fixes three bugs encountered while running the > Vulkan > CTS with SPIR-V optimizations enabled. The optimizations

Re: [Mesa-dev] [PATCH 1/5] nir/cf: Remove phi sources if needed in nir_handle_add_jump

2018-10-02 Thread Iago Toral
On Sat, 2018-09-22 at 16:39 -0500, Jason Ekstrand wrote: > If the block in which the jump is inserted is the predecessor of a > phi > then we need to remove phi sources otherwise the phi may end up with > things improperly connected. Found by running the Vulkan CTS with > SPIR-V optimizations

Re: [Mesa-dev] [PATCH] st/va:Aligned image width and height to 16.

2018-10-02 Thread Christian König
Am 02.10.2018 um 03:47 schrieb Sharma, Deepak: From: suresh guttula In case of decoding of resolution like 40x24, while allocating surface video buffer is always aligned with macroblock width/height which is 16. But when application tries to get data after decoding through vaCreateImage

Re: [Mesa-dev] [PATCH v2 8/8] egl: add EGL_platform_device support

2018-10-02 Thread Emil Velikov
On Thu, 20 Sep 2018 at 15:13, Mathias Fröhlich wrote: > > If I replace the above with > > EGLint surface_type = 0; > /* Only advertise pbuffer configs for non swrast devices */ > if (dri2_dpy->image_driver) > surface_type = EGL_PBUFFER_BIT; > >

Re: [Mesa-dev] [PATCH v2 3/8] egl: add EGL_EXT_device_drm support

2018-10-02 Thread Emil Velikov
Hi Mathias, On Thu, 20 Sep 2018 at 15:12, Mathias Fröhlich wrote: > > @@ -141,6 +231,12 @@ _eglQueryDeviceStringEXT(_EGLDevice *dev, EGLint name) > > switch (name) { > > case EGL_EXTENSIONS: > >return dev->extensions; > > +#ifdef HAVE_LIBDRM > > + case EGL_DRM_DEVICE_FILE_EXT:

Re: [Mesa-dev] [PATCH 4/5] spirv: Pass SSA values through functions

2018-10-02 Thread Iago Toral
On Sat, 2018-09-22 at 16:39 -0500, Jason Ekstrand wrote: > Previously, we would create temporary variables and fill them out. > Instead, we create as many function parameters as we need and pass > them > through as SSA defs. (...) > void > vtn_handle_function_call(struct vtn_builder *b, SpvOp

[Mesa-dev] [Bug 108120] tools_error2aub-error2aub fails to build: error: implicit declaration of function ‘va_start’

2018-10-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108120 --- Comment #4 from Lionel Landwerlin --- (In reply to Paul Menzel from comment #3) > (In reply to Lionel Landwerlin from comment #2) > > Sent https://patchwork.freedesktop.org/patch/254342/ > > Thanks, I just wanted to upload the same change.

Re: [Mesa-dev] [PATCH] intel: error2aub: fix missing include

2018-10-02 Thread Tapani Pälli
Reviewed-by: Tapani Pälli On 10/2/18 12:29 PM, Lionel Landwerlin wrote: Signed-off-by: Lionel Landwerlin Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108120 --- src/intel/tools/error2aub.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/intel/tools/error2aub.c

Re: [Mesa-dev] [PATCH v2 2/8] egl: add EGL_MESA_device_software support

2018-10-02 Thread Emil Velikov
On Thu, 20 Sep 2018 at 15:12, Mathias Fröhlich wrote: > > Hi Emil, > > Some comments inline below: > > On Tuesday, 4 September 2018 20:32:59 CEST Emil Velikov wrote: > > From: Emil Velikov > > > > Add a plain software device, which is always available. > > > > We can safely assign it as the

Re: [Mesa-dev] [PATCH v2 1/8] egl: add base EGL_EXT_device_base implementation

2018-10-02 Thread Emil Velikov
On Thu, 20 Sep 2018 at 15:11, Mathias Fröhlich wrote: > > Hi Emil, > Thanks Mathias. Just coming back from some holidays and XDC. Most of your commends are addressed ... the ones which are not I'll commend on in a moment. > On Tuesday, 4 September 2018 20:32:58 CEST Emil Velikov wrote: > >

[Mesa-dev] [Bug 108120] tools_error2aub-error2aub fails to build: error: implicit declaration of function ‘va_start’

2018-10-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108120 --- Comment #3 from Paul Menzel --- (In reply to Lionel Landwerlin from comment #2) > Sent https://patchwork.freedesktop.org/patch/254342/ Thanks, I just wanted to upload the same change. Two nitpicks. 1. Should the include be inserted

[Mesa-dev] [Bug 108120] tools_error2aub-error2aub fails to build: error: implicit declaration of function ‘va_start’

2018-10-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108120 --- Comment #2 from Lionel Landwerlin --- Sent https://patchwork.freedesktop.org/patch/254342/ -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the

[Mesa-dev] [PATCH] intel: error2aub: fix missing include

2018-10-02 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108120 --- src/intel/tools/error2aub.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/intel/tools/error2aub.c b/src/intel/tools/error2aub.c index 8a23d5ef1e7..b33cb1356f9 100644 ---

  1   2   >