Re: [Mesa-dev] [PATCH] amd: remove support for LLVM 6.0

2018-11-05 Thread Samuel Pitoiset
On 11/5/18 10:52 PM, Marek Olšák wrote: On Fri, Nov 2, 2018 at 5:21 AM Samuel Pitoiset mailto:samuel.pitoi...@gmail.com>> wrote: User are encouraged to switch to LLVM 7.0 released in September 2018. Signed-off-by: Samuel Pitoiset mailto:samuel.pitoi...@gmail.com>> ---

Re: [Mesa-dev] [PATCH 00/15] VK_ANDROID_external_memory_android_hardware_buffer

2018-11-05 Thread Tapani Pälli
FYI now I've noticed that SkQP runs some new tests as well .. most of them are passing but there are 2 failures. Will start to investigate this. Results were: unitTest_VulkanHardwareBuffer_CPU_EGL pass unitTest_VulkanHardwareBuffer_CPU_Vulkan pass unitTest_VulkanHardwareBuffer_EGL_EGL pass

Re: [Mesa-dev] [PATCH 09/15] anv/android: add ahardwarebuffer external memory properties

2018-11-05 Thread Tapani Pälli
On 11/5/18 8:23 PM, Lionel Landwerlin wrote: On 30/10/2018 06:26, Tapani Pälli wrote: const VkPhysicalDeviceExternalImageFormatInfo *external_info = NULL; VkExternalImageFormatPropertiesKHR *external_props = NULL; VkSamplerYcbcrConversionImageFormatProperties *ycbcr_props = NULL;

[Mesa-dev] [PATCH 61/61] nir: Document precision lowering pass

2018-11-05 Thread Topi Pohjolainen
--- src/compiler/nir/nir_lower_precision.cpp | 106 ++- 1 file changed, 104 insertions(+), 2 deletions(-) diff --git a/src/compiler/nir/nir_lower_precision.cpp b/src/compiler/nir/nir_lower_precision.cpp index 3d05fa2b3c9..9647fb4d6a9 100644 ---

[Mesa-dev] intel: WIP: Support for using 16-bits for mediump

2018-11-05 Thread Topi Pohjolainen
Here is a version 2 of adding support for 16-bit float instructions in the shader compiler. Unlike the first version which did all the analysis at glsl level here one adds the notion of precision to NIR variables and does the analysis and precision lowering in NIR level. This lives in:

Re: [Mesa-dev] [PATCH 07/28] spirv/nir: don't set interface_type if it is not a struct

2018-11-05 Thread Timothy Arceri
On 22/10/18 11:24 pm, Alejandro Piñeiro wrote: vnt_variables uses interface_type on several use cases, but on nir variable it is more limited. From nir.h: /** * For variables that are in an interface block or are an instance of an * interface block, this is the \c

Re: [Mesa-dev] [PATCH 03/28] spirv/nir: setting interface type for ubos/ssbos

2018-11-05 Thread Timothy Arceri
On 22/10/18 11:24 pm, Alejandro Piñeiro wrote: Right now, a type is considered a ubo/ssbo if the mode is uniform/shader_storage and the interface_type is different to NULL. See ir_variable::in_in_buffer_block as an example. in_in_buffer_block -> is_in_buffer_block Otherwise 1-3: Reviewed-by:

Re: [Mesa-dev] [PATCH] configure.ac: make judgement logic cleaner

2018-11-05 Thread Zhaowei YUan
Can anyone review this patch? On 10/29/18 3:08 PM, Zhaowei Yuan wrote: > The purpose of judegment here is to output error message > and abort configure procedure if gbm is not enabled, the > original statement makes it work, however, its logic is > not clear and easy to make people confused. > >

[Mesa-dev] NIR vectorise varyings V3

2018-11-05 Thread Timothy Arceri
This fixes the regressions in the glxbench tessellation benchmark [1]. This version fixes some silly mistakes that were causing some tests to fail on Intels CI system, see patch 2 for more details. [1] https://bugs.freedesktop.org/show_bug.cgi?id=107510

[Mesa-dev] [PATCH v3 1/3] nir: add glsl_replace_vector_type()

2018-11-05 Thread Timothy Arceri
This creates a new glsl_type with the specified number on components. We will use this in the following patch when vectorising io. --- src/compiler/nir_types.cpp | 24 src/compiler/nir_types.h | 2 ++ 2 files changed, 26 insertions(+) diff --git

[Mesa-dev] [PATCH v3 3/3] i965/anv: use nir_opt_vectorize_io()

2018-11-05 Thread Timothy Arceri
Commit 8d8222461f9d7f49 caused substantially more URB messages in geometry and tessellation shaders (due to enabling nir_lower_io_to_scalar_early). This combines io again to avoid this regression while still allowing link time optimisation of components. Shader-db results (SKL): total

[Mesa-dev] [PATCH v3 2/3] nir: add nir_opt_vectorize_io()

2018-11-05 Thread Timothy Arceri
Once linking opts are done this pass recombines varying components. This patch is loosely based on Connor's vectorize alu pass. V2: skip fragment shaders V3: - dont accidentally vectorise local vars - pass correct component to create_new_store() --- src/compiler/Makefile.sources |

Re: [Mesa-dev] [PATCH] gallium/util: don't let children of fork & exec inherit our thread affinity

2018-11-05 Thread Marek Olšák
On Mon, Nov 5, 2018 at 5:09 AM Haehnle, Nicolai wrote: > On 31.10.18 21:41, Marek Olšák wrote: > > Instead of saying that, you should say "Mesa should be slower with most > > apps, so that we don't decrease perf for 2 apps too much", because > > that's what you are saying. It seems like you have

Re: [Mesa-dev] [PATCH] radv/nir: avoid packing vertex outputs we can eliminate

2018-11-05 Thread Timothy Arceri
On Mon, Nov 5, 2018, at 4:44 PM, Timothy Arceri wrote: > On 6/11/18 11:30 am, Eric Anholt wrote: > > Timothy Arceri writes: > > > >> For now I have only enabled this for RADV we can do it > >> also for radeonsi also but we need to add a CAP for it. > > > > If we're doing this at link time, why

Re: [Mesa-dev] [PATCH] radv/nir: avoid packing vertex outputs we can eliminate

2018-11-05 Thread Timothy Arceri
On 6/11/18 11:30 am, Eric Anholt wrote: Timothy Arceri writes: For now I have only enabled this for RADV we can do it also for radeonsi also but we need to add a CAP for it. If we're doing this at link time, why not push the constant value from the producer into the consumer shader and then

[Mesa-dev] [Bug 108669] driOpenDriver uses RTLD_GLOBAL and breaks clang's libc++

2018-11-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108669 Bug ID: 108669 Summary: driOpenDriver uses RTLD_GLOBAL and breaks clang's libc++ Product: Mesa Version: 18.0 Hardware: Other OS: All Status:

Re: [Mesa-dev] [PATCH] radv/nir: avoid packing vertex outputs we can eliminate

2018-11-05 Thread Eric Anholt
Timothy Arceri writes: > For now I have only enabled this for RADV we can do it > also for radeonsi also but we need to add a CAP for it. If we're doing this at link time, why not push the constant value from the producer into the consumer shader and then cut out the varying entirely?

Re: [Mesa-dev] [PATCH 3/3] anv: Implement VK_EXT_conditional_rendering for gen 7.5+

2018-11-05 Thread Jason Ekstrand
On Wed, Oct 17, 2018 at 6:59 AM Danylo Piliaiev wrote: > Conditional rendering affects next functions: > - vkCmdDraw, vkCmdDrawIndexed, vkCmdDrawIndirect, vkCmdDrawIndexedIndirect > - vkCmdDrawIndirectCountKHR, vkCmdDrawIndexedIndirectCountKHR > - vkCmdDispatch, vkCmdDispatchIndirect,

Re: [Mesa-dev] [PATCH] gallium/util: don't let children of fork & exec inherit our thread affinity

2018-11-05 Thread Eric Anholt
"Haehnle, Nicolai" writes: > On 31.10.18 21:41, Marek Olšák wrote: >> Instead of saying that, you should say "Mesa should be slower with most >> apps, so that we don't decrease perf for 2 apps too much", because >> that's what you are saying. It seems like you have some limited belief >> that

Re: [Mesa-dev] [PATCH 1/2] gallium: add PIPE_CONTEXT_LOSE_CONTEXT_ON_RESET

2018-11-05 Thread Dieter Nützel
For the series Tested-by: Dieter Nützel Dieter Am 02.11.2018 21:10, schrieb Marek Olšák: From: Marek Olšák --- src/gallium/include/pipe/p_defines.h | 3 +++ src/mesa/state_tracker/st_manager.c | 3 +++ 2 files changed, 6 insertions(+) diff --git a/src/gallium/include/pipe/p_defines.h

Re: [Mesa-dev] [PATCH 1/3] anv: Implement VK_KHR_draw_indirect_count for gen 7.5+

2018-11-05 Thread Jason Ekstrand
On Wed, Oct 17, 2018 at 6:59 AM Danylo Piliaiev wrote: > Signed-off-by: Danylo Piliaiev > --- > src/intel/vulkan/anv_extensions.py | 1 + > src/intel/vulkan/genX_cmd_buffer.c | 155 + > 2 files changed, 156 insertions(+) > > diff --git

Re: [Mesa-dev] [PATCH v5 0/3] Add and enable extension EXT_sRGB_write_control

2018-11-05 Thread Marek Olšák
At the Gallium level, you can change between UNORM and SRGB in pipe_surface. If you allocate a texture as SRGB, you should be able to use it as LINEAR and vice versa. All hardware that supports both LINEAR and SRGB supports this. A typical hw driver does that simply by changing the format in the

Re: [Mesa-dev] [PATCH] amd: remove support for LLVM 6.0

2018-11-05 Thread Marek Olšák
On Fri, Nov 2, 2018 at 5:21 AM Samuel Pitoiset wrote: > User are encouraged to switch to LLVM 7.0 released in September 2018. > > Signed-off-by: Samuel Pitoiset > --- > configure.ac | 4 +- > meson.build | 2 +- >

Re: [Mesa-dev] [PATCH] intel/decoders: fix instruction base address parsing

2018-11-05 Thread Kenneth Graunke
On Monday, November 5, 2018 12:42:40 PM PST Lionel Landwerlin wrote: > Signed-off-by: Lionel Landwerlin > Fixes: 00103db04ab879 ("intel: Fix decoding for partial STATE_BASE_ADDRESS > updates.") > --- > src/intel/common/gen_batch_decoder.c | 2 +- >

Re: [Mesa-dev] [PATCH 2/2] glsl: Add pragma to disable all warnings

2018-11-05 Thread Matt Turner
On Thu, Nov 1, 2018 at 3:37 PM Ian Romanick wrote: > > From: Ian Romanick > > warnings. This is a big hammer. If we ever need a smaller hammer, we I bet there was a line in the commit message before this that started with '#pragma', which git commit interpreted as a comment. > can enhance

Re: [Mesa-dev] [PATCH 1/2] glsl: Add warning tests for identifiers with __

2018-11-05 Thread Matt Turner
On Thu, Nov 1, 2018 at 3:37 PM Ian Romanick wrote: > > From: Ian Romanick > > Signed-off-by: Ian Romanick > Cc: Matt Turner > --- > .../tests/warnings/031-__-in-function-name.vert| 22 > ++ > .../warnings/031-__-in-function-name.vert.expected | 3 +++ > 2 files

[Mesa-dev] [PATCH] intel/decoders: fix instruction base address parsing

2018-11-05 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin Fixes: 00103db04ab879 ("intel: Fix decoding for partial STATE_BASE_ADDRESS updates.") --- src/intel/common/gen_batch_decoder.c | 2 +- src/intel/tools/aubinator_viewer_decoder.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git

[Mesa-dev] [PATCH] st/xvmc: Add X11 include path.

2018-11-05 Thread Vinson Lee
This patch fixes this build error. CC tests/xvmc_bench.o In file included from tests/xvmc_bench.c:35: tests/testlib.h:38:10: fatal error: 'X11/Xlib.h' file not found ^~~~ Signed-off-by: Vinson Lee --- src/gallium/state_trackers/xvmc/Makefile.am | 1 + 1 file changed, 1

Re: [Mesa-dev] [PATCH 09/15] anv/android: add ahardwarebuffer external memory properties

2018-11-05 Thread Lionel Landwerlin
On 30/10/2018 06:26, Tapani Pälli wrote: const VkPhysicalDeviceExternalImageFormatInfo *external_info = NULL; VkExternalImageFormatPropertiesKHR *external_props = NULL; VkSamplerYcbcrConversionImageFormatProperties *ycbcr_props = NULL; + struct

[Mesa-dev] [PATCH EGL/MESA] EGL/mesa: Initial write up for EGL_MESA_query_driver

2018-11-05 Thread Veluri Mithun
Signed-off-by: Veluri Mithun --- docs/specs/EGL_MESA_query_driver.txt | 53 1 file changed, 53 insertions(+) create mode 100644 docs/specs/EGL_MESA_query_driver.txt diff --git a/docs/specs/EGL_MESA_query_driver.txt b/docs/specs/EGL_MESA_query_driver.txt new file

Re: [Mesa-dev] [PATCH] vulkan/wsi/wayland: Respect non-blocking AcquireNextImage

2018-11-05 Thread Chad Versace
On Tue 30 Oct 2018, Daniel Stone wrote: > If the client has requested that AcquireNextImage not block at all, with > a timeout of 0, then don't make any non-blocking calls. > > This will still potentially block infinitely given a non-infinte > timeout, but the fix for that is much more involved.

Re: [Mesa-dev] [PATCH] mesa: expose NV_conditional_render on GLES

2018-11-05 Thread Erik Faye-Lund
On Mon, 2018-11-05 at 12:29 -0500, Ilia Mirkin wrote: > I doesn't need ES 3.0, just EXT_occlusion_query_boolean, which mesa > happens to support. Whoops, I don't know how I missed that fact. Yeah, you're right, ES 2.0 should be enough. > Are there any drivers that support conditional > render

Re: [Mesa-dev] [PATCH] st/va: fix incorrect use of resource_destroy

2018-11-05 Thread Emil Velikov
On Sat, 3 Nov 2018 at 00:57, Marek Olšák wrote: > > From: Marek Olšák > Fixes: 4373dd32154 ("st/va: Support YUV formats in vaCreateSurfaces") Cc: Drew Davenport Reviewed-by: Emil Velikov -Emil ___ mesa-dev mailing list

Re: [Mesa-dev] [PATCH] mesa: expose NV_conditional_render on GLES

2018-11-05 Thread Ilia Mirkin
I doesn't need ES 3.0, just EXT_occlusion_query_boolean, which mesa happens to support. Are there any drivers that support conditional render but not ARB_occlusion_query? (I don't think that's really possible given that the feature is basically designed for occlusion queries...) On Mon, Nov 5,

[Mesa-dev] [PATCH] mesa: expose NV_conditional_render on GLES

2018-11-05 Thread Erik Faye-Lund
The extension spec has been updated to include GLES 3 support, so let's enable it there. Signed-off-by: Erik Faye-Lund --- This patch can be tested with this piglit-series: https://patchwork.freedesktop.org/series/52039/ src/mapi/glapi/gen/NV_conditional_render.xml | 4 ++--

Re: [Mesa-dev] [PATCH v1] i965/batch/debug: Allow log be dumped before assert

2018-11-05 Thread Kenneth Graunke
On Monday, November 5, 2018 5:02:49 AM PST Sergii Romantsov wrote: > Message that may show the culprit of assert now will > be dumped before that for debug purposes. > > CC: Kenneth Graunke > CC: Lionel G Landwerlin > Signed-off-by: Sergii Romantsov > --- >

[Mesa-dev] [Bug 108275] Breaking out of loop creates broken code on RADV

2018-11-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108275 --- Comment #9 from Samuel Pitoiset --- Created attachment 142373 --> https://bugs.freedesktop.org/attachment.cgi?id=142373=edit workaround This workaround appears to fix the problem on my side. I will investigate more. -- You are

[Mesa-dev] [PATCH v2] egl/glvnd: correctly report errors when vendor cannot be found

2018-11-05 Thread Emil Velikov
From: Emil Velikov If the user provides an invalid display or device the ToVendor lookup will fail. In this case, the local [Mesa vendor] error code will be set. Thus on sequential eglGetError(), the error will be EGL_SUCCESS. To be more specific, GLVND remembers the last vendor and calls back

Re: [Mesa-dev] [PATCH 00/11] intel/fs: Add a generic SEND opcode and use it on

2018-11-05 Thread Jason Ekstrand
On Mon, Nov 5, 2018 at 10:39 AM Eero Tamminen wrote: > Hi, > > On 3.11.2018 2.06, Jason Ekstrand wrote: > > This patch series is something we've talked about doing for a while and > > haven't gotten around to yet. It implements a generic SEND opcode and > then > > reworks a bunch of the current

Re: [Mesa-dev] [PATCH v3] autotools: library-dependency when no sse and 32-bit

2018-11-05 Thread Dylan Baker
Thanks! Quoting Lionel Landwerlin (2018-11-05 04:25:40) > Done. Thanks! > > On 05/11/2018 11:04, Sergii Romantsov wrote: > > Could, please, somebody push? > > On Thu, Nov 1, 2018 at 6:11 PM Dylan Baker wrote: > > Reviewed-by: Dylan Baker > > Quoting Sergii Romantsov

Re: [Mesa-dev] [PATCH 00/11] intel/fs: Add a generic SEND opcode and use it on

2018-11-05 Thread Eero Tamminen
Hi, On 3.11.2018 2.06, Jason Ekstrand wrote: This patch series is something we've talked about doing for a while and haven't gotten around to yet. It implements a generic SEND opcode and then reworks a bunch of the current SEND instructions such as texturing to use that instead of piles of

Re: [Mesa-dev] [PATCH] st/va: fix incorrect use of resource_destroy

2018-11-05 Thread Michel Dänzer
On 2018-11-03 1:56 a.m., Marek Olšák wrote: > From: Marek Olšák > > --- > src/gallium/state_trackers/va/surface.c | 6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/src/gallium/state_trackers/va/surface.c > b/src/gallium/state_trackers/va/surface.c > index

Re: [Mesa-dev] [PATCH v4 1/2] i965/batch: avoid reverting batch buffer if saved state is an empty

2018-11-05 Thread Mark Janes
andrey simiklit writes: > Hello, > > I tested this patch few times and have the following results: > https://mesa-ci.01.org/global_logic/builds/38/group/63a9f0ea7bb98050796b649e85481845 > https://mesa-ci.01.org/global_logic/builds/41/group/63a9f0ea7bb98050796b649e85481845 >

Re: [Mesa-dev] [PATCH v5 0/3] Add and enable extension EXT_sRGB_write_control

2018-11-05 Thread Ilia Mirkin
On Mon, Nov 5, 2018 at 11:02 AM Gert Wollny wrote: > > Am Montag, den 05.11.2018, 08:56 -0500 schrieb Ilia Mirkin: > > At the gallium level, it's a promise that some PIPE_FORMAT_*_SRGB is > > supported for rendering and that you can use a non-srgb format in the > > surface even if the resource

Re: [Mesa-dev] [PATCH 2/2] egl/glvnd: correctly report errors when vendor cannot be found

2018-11-05 Thread Kyle Brenneman
On 11/5/18 9:13 AM, Emil Velikov wrote: On Fri, 2 Nov 2018 at 22:09, Kyle Brenneman wrote: +if (vendor == NULL) { +// XXX: How can we end here with EGL_SUCCESS? +if (errorCode != EGL_SUCCESS) { +// Since we have no vendor, the follow-up eglGetError() call will

Re: [Mesa-dev] [PATCH 2/2] egl/glvnd: correctly report errors when vendor cannot be found

2018-11-05 Thread Emil Velikov
On Fri, 2 Nov 2018 at 22:09, Kyle Brenneman wrote: > > +if (vendor == NULL) { > > +// XXX: How can we end here with EGL_SUCCESS? > > +if (errorCode != EGL_SUCCESS) { > > +// Since we have no vendor, the follow-up eglGetError() call > > will > > +//

Re: [Mesa-dev] [PATCH v5 0/3] Add and enable extension EXT_sRGB_write_control

2018-11-05 Thread Gert Wollny
Am Montag, den 05.11.2018, 08:56 -0500 schrieb Ilia Mirkin: > At the gallium level, it's a promise that some PIPE_FORMAT_*_SRGB is > supported for rendering and that you can use a non-srgb format in the > surface even if the resource was originally allocated with an srgb > format (and

[Mesa-dev] [PATCH 13/13] anv/formats: drop RGBA swizzle for ycbcr formats

2018-11-05 Thread Lionel Landwerlin
We're always using RGBA as source. Signed-off-by: Lionel Landwerlin --- src/intel/vulkan/anv_formats.c | 80 +- 1 file changed, 40 insertions(+), 40 deletions(-) diff --git a/src/intel/vulkan/anv_formats.c b/src/intel/vulkan/anv_formats.c index

[Mesa-dev] [PATCH 10/13] anv/formats: allow formats to be describe per generation

2018-11-05 Thread Lionel Landwerlin
Like we mentioned in a previous commit, YCbCr single plane formats can be sampled from using 2 different HW settings on Gen11/ICL. This change stored for each Vulkan format an array descriptions (struct anv_format) instead of a single one. Signed-off-by: Lionel Landwerlin ---

[Mesa-dev] [PATCH 12/13] anv/icl: enable 16bit single plane YCbCr formats

2018-11-05 Thread Lionel Landwerlin
Now that we have the ability to sample easily for this on Gen11 and also the refactoring to just enable this on that particular platform, let's turn this on. Signed-off-by: Lionel Landwerlin --- src/intel/vulkan/anv_formats.c | 16 +++- 1 file changed, 11 insertions(+), 5

[Mesa-dev] [PATCH 08/13] anv: convert anv_layout_to_aux_usage to use plane

2018-11-05 Thread Lionel Landwerlin
This will help with the creation of image views where the aspect of the view doesn't necessarly match the aspect of the image plane. Signed-off-by: Lionel Landwerlin --- src/intel/vulkan/anv_blorp.c | 2 +- src/intel/vulkan/anv_image.c | 26 +-

[Mesa-dev] [PATCH 09/13] anv: use format stored aspects to build up images & imageviews

2018-11-05 Thread Lionel Landwerlin
For single planar YCbCr formats like : - VK_FORMAT_G8B8G8R8_422_UNORM - VK_FORMAT_B8G8R8G8_422_UNORM - VK_FORMAT_G16B16G16R16_422_UNORM - VK_FORMAT_B16G16R16G16_422_UNORM we could only use YCbCr HW formats to sample from those. This is because the HW was designed in such a way that

[Mesa-dev] [PATCH 04/13] anv: associate vulkan formats with aspects

2018-11-05 Thread Lionel Landwerlin
This will make it easier to associate an aspect with a plane number. Signed-off-by: Lionel Landwerlin --- src/intel/vulkan/anv_formats.c | 107 - src/intel/vulkan/anv_private.h | 3 + 2 files changed, 69 insertions(+), 41 deletions(-) diff --git

[Mesa-dev] [PATCH 11/13] anv: introduce device compatibility checks for format query

2018-11-05 Thread Lionel Landwerlin
We add a function that allows us to check whether a particular description of a Vulkan format is available for a given device. Signed-off-by: Lionel Landwerlin --- src/intel/vulkan/anv_formats.c| 65 --- src/intel/vulkan/anv_image.c | 4 +-

[Mesa-dev] [PATCH 01/13] anv: simplify internal address offset

2018-11-05 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin --- src/intel/vulkan/anv_private.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/intel/vulkan/anv_private.h b/src/intel/vulkan/anv_private.h index d8a08d9d67f..8475008db4a 100644 --- a/src/intel/vulkan/anv_private.h +++

[Mesa-dev] [PATCH 07/13] anv/image: use stored format to figure out plane from aspect

2018-11-05 Thread Lionel Landwerlin
Now that we have aspects stored into anv_format_plane we can just go through the list of planes of a given format and figure which one matches the aspect we're interested in. This will come handy as when we introduce 2 different view of the same buffer for YCbCr formats. Signed-off-by: Lionel

[Mesa-dev] [PATCH 00/13] anv: support new formats with multiple views

2018-11-05 Thread Lionel Landwerlin
Hi all, This series is about reworking how we deal with formats a bit. Up to now we had described formats as a set of planes, each of them mapping exactly to 1 HW binding table entry. When introducing YCbCr support a while back, this way of describing formats prevented us to support YCbCr

[Mesa-dev] [PATCH 03/13] anv/lower_ycbcr: make sure to set 0s on all components

2018-11-05 Thread Lionel Landwerlin
To play around with debugging, we might want to disable one or the other component. Having 0s as default values makes this work. Otherwise we might have NULL components, leading to crashes. Signed-off-by: Lionel Landwerlin --- src/intel/vulkan/anv_nir_lower_ycbcr_textures.c | 4 +++- 1 file

[Mesa-dev] [PATCH 05/13] anv: use image aspects rather than computed ones

2018-11-05 Thread Lionel Landwerlin
This shouldn't make any difference but I feel uneasy to use the expanded aspects that do not represent the image in its entirety. If we ever change the implementation of the anv_image_aspect_to_plane() helper, this is safer. Signed-off-by: Lionel Landwerlin --- src/intel/vulkan/anv_image.c | 2

[Mesa-dev] [PATCH 06/13] anv: move helper function internally

2018-11-05 Thread Lionel Landwerlin
It's only used in anv_image.c Signed-off-by: Lionel Landwerlin --- src/intel/vulkan/anv_image.c | 22 ++ src/intel/vulkan/anv_private.h | 22 -- 2 files changed, 22 insertions(+), 22 deletions(-) diff --git a/src/intel/vulkan/anv_image.c

[Mesa-dev] [PATCH 02/13] anv/image: remove unused parameter

2018-11-05 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin --- src/intel/vulkan/anv_image.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vulkan/anv_image.c index e89ce012be7..1d1ec4befe4 100644 --- a/src/intel/vulkan/anv_image.c +++

Re: [Mesa-dev] [PATCH] amd: remove support for LLVM 6.0

2018-11-05 Thread Michel Dänzer
On 2018-11-04 4:12 a.m., Marek Olšák wrote: > On Fri, Nov 2, 2018 at 10:58 AM Michel Dänzer wrote: > >> On 2018-11-02 10:23 a.m., Samuel Pitoiset wrote: >>> User are encouraged to switch to LLVM 7.0 released in September 2018. >> >> At least two major releases of LLVM should always be supported,

Re: [Mesa-dev] [PATCH v5 0/3] Add and enable extension EXT_sRGB_write_control

2018-11-05 Thread Ilia Mirkin
On Mon, Nov 5, 2018 at 7:12 AM Gert Wollny wrote: > > Am Donnerstag, den 01.11.2018, 12:32 -0400 schrieb Ilia Mirkin: > > > > > > EXT_framebuffer_sRGB is a desktop GL ext. EXT_sRGB_write_control is a > > GLES ext that was meant to provide the same functionality in GLES > > (have a glance at Issue

Re: [Mesa-dev] [PATCH v1] i965/batch/debug: Allow log be dumped before assert

2018-11-05 Thread Lionel Landwerlin
Reviewed-by: Lionel Landwerlin On 05/11/2018 14:02, Sergii Romantsov wrote: Message that may show the culprit of assert now will be dumped before that for debug purposes. CC: Kenneth Graunke CC: Lionel G Landwerlin Signed-off-by: Sergii Romantsov ---

[Mesa-dev] [PATCH v1] i965/batch/debug: Allow log be dumped before assert

2018-11-05 Thread Sergii Romantsov
Message that may show the culprit of assert now will be dumped before that for debug purposes. CC: Kenneth Graunke CC: Lionel G Landwerlin Signed-off-by: Sergii Romantsov --- src/mesa/drivers/dri/i965/intel_batchbuffer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Mesa-dev] [Bug 108560] Mesa 32 is built without sse

2018-11-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108560 Sergii Romantsov changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

Re: [Mesa-dev] [PATCH v3] autotools: library-dependency when no sse and 32-bit

2018-11-05 Thread Lionel Landwerlin
Done. Thanks! On 05/11/2018 11:04, Sergii Romantsov wrote: Could, please, somebody push? On Thu, Nov 1, 2018 at 6:11 PM Dylan Baker > wrote: Reviewed-by: Dylan Baker mailto:dy...@pnwbakers.com>> Quoting Sergii Romantsov (2018-11-01 04:02:43) >

[Mesa-dev] [Bug 108659] Using Vulkan causes GPU hang on SI

2018-11-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108659 Samuel Pitoiset changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [Bug 108659] Using Vulkan causes GPU hang on SI

2018-11-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108659 --- Comment #2 from Turo Lamminen --- Reverting the commit locally fixes the issue. That LLVM is currently the latest available in Debian, I'd have to go to LLVM's own repository. Is it possible to either check LLVM version at runtime or fail

Re: [Mesa-dev] [PATCH v5 0/3] Add and enable extension EXT_sRGB_write_control

2018-11-05 Thread Gert Wollny
Am Donnerstag, den 01.11.2018, 12:32 -0400 schrieb Ilia Mirkin: > > > EXT_framebuffer_sRGB is a desktop GL ext. EXT_sRGB_write_control is a > GLES ext that was meant to provide the same functionality in GLES > (have a glance at Issue #1 in that spec). You could have hardware > that supports

[Mesa-dev] [Bug 108659] Using Vulkan causes GPU hang on SI

2018-11-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108659 --- Comment #1 from Samuel Pitoiset --- You have llvm r343154 while that mesa commit requires r345763, can you update your llvm? Or revert that change locally? -- You are receiving this mail because: You are the assignee for the bug. You are

[Mesa-dev] [Bug 108659] Using Vulkan causes GPU hang on SI

2018-11-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108659 Bug ID: 108659 Summary: Using Vulkan causes GPU hang on SI Product: Mesa Version: git Hardware: All OS: Linux (All) Status: NEW Severity: major

[Mesa-dev] [PATCH] gallium/wgl: Avoid calling SetPixelFormat if used as drop-in opengl32

2018-11-05 Thread Frank Richter
Hello, I've stumbled across an issue were Mesa failed to create a context when it's used as a opengl32 surrogate (from Qt). The weird thing was that the failure only happened on certain graphics hardware, even though Mesa was supposed to take over GL duties. As it turns out, the problem was

Re: [Mesa-dev] [PATCH v4 1/2] i965/batch: avoid reverting batch buffer if saved state is an empty

2018-11-05 Thread andrey simiklit
Hello, Thanks for your quick reply. Is it acceptable that this patch somehow fixes one more test for G965 platform: ext_framebuffer_multisample-accuracy or we need to fix this to push it? Regards, Andrii. On Mon, Nov 5, 2018 at 10:42 AM Jordan Justen wrote: > On 2018-11-05 00:11:52,

[Mesa-dev] [Bug 108508] Graphic glitches with stream output support on OLAND AMD GPU GCN 1.0

2018-11-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108508 --- Comment #23 from Ahmed Elsayed --- Created attachment 142366 --> https://bugs.freedesktop.org/attachment.cgi?id=142366=edit GPU hang report for Mafia III. -- You are receiving this mail because: You are the assignee for the bug. You are

[Mesa-dev] [Bug 108508] Graphic glitches with stream output support on OLAND AMD GPU GCN 1.0

2018-11-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108508 Ahmed Elsayed changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED

Re: [Mesa-dev] [PATCH mesa 2/2] wsi/wayland: only finish() a successfully init()ed display

2018-11-05 Thread Philipp Zabel
On Mon, 2018-11-05 at 10:00 +, Eric Engestrom wrote: > Cc: Dave Airlie > Cc: Philipp Zabel > Signed-off-by: Eric Engestrom Reviewed-by: Philipp Zabel > --- > src/vulkan/wsi/wsi_common_wayland.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git

Re: [Mesa-dev] [PATCH] gallium/util: don't let children of fork & exec inherit our thread affinity

2018-11-05 Thread Haehnle, Nicolai
On 31.10.18 21:41, Marek Olšák wrote: > Instead of saying that, you should say "Mesa should be slower with most > apps, so that we don't decrease perf for 2 apps too much", because > that's what you are saying. It seems like you have some limited belief > that only allows you to see the problem

Re: [Mesa-dev] [PATCH mesa 2/2] wsi/wayland: only finish() a successfully init()ed display

2018-11-05 Thread Dave Airlie
Reviewed-by: Dave Airlie On Mon, 5 Nov 2018 at 20:00, Eric Engestrom wrote: > > Cc: Dave Airlie > Cc: Philipp Zabel > Signed-off-by: Eric Engestrom > --- > src/vulkan/wsi/wsi_common_wayland.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git

Re: [Mesa-dev] [PATCH mesa 1/2] wsi/wayland: user proper VkResult type

2018-11-05 Thread Dave Airlie
Reviewed-by: Dave Airlie On Mon, 5 Nov 2018 at 20:00, Eric Engestrom wrote: > > Signed-off-by: Eric Engestrom > --- > src/vulkan/wsi/wsi_common_wayland.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/vulkan/wsi/wsi_common_wayland.c >

Re: [Mesa-dev] [PATCH v3] autotools: library-dependency when no sse and 32-bit

2018-11-05 Thread Sergii Romantsov
Could, please, somebody push? On Thu, Nov 1, 2018 at 6:11 PM Dylan Baker wrote: > Reviewed-by: Dylan Baker > > Quoting Sergii Romantsov (2018-11-01 04:02:43) > > Building of 32bit Mesa may fail if __SSE__ is not specified. > > Added missed dependency from libm. > > > > v2: avoided dependecy on

[Mesa-dev] [PATCH mesa 2/2] wsi/wayland: only finish() a successfully init()ed display

2018-11-05 Thread Eric Engestrom
Cc: Dave Airlie Cc: Philipp Zabel Signed-off-by: Eric Engestrom --- src/vulkan/wsi/wsi_common_wayland.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/vulkan/wsi/wsi_common_wayland.c b/src/vulkan/wsi/wsi_common_wayland.c index

[Mesa-dev] [PATCH mesa 1/2] wsi/wayland: user proper VkResult type

2018-11-05 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- src/vulkan/wsi/wsi_common_wayland.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/vulkan/wsi/wsi_common_wayland.c b/src/vulkan/wsi/wsi_common_wayland.c index 86b3acec94e8b98b3dbf..a799b427621d72b2927c 100644 ---

[Mesa-dev] [PATCH] radv: allocate enough space in CS when copying query results with compute

2018-11-05 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_query.c | 4 1 file changed, 4 insertions(+) diff --git a/src/amd/vulkan/radv_query.c b/src/amd/vulkan/radv_query.c index 494dc24016..47e7f08001 100644 --- a/src/amd/vulkan/radv_query.c +++ b/src/amd/vulkan/radv_query.c @@ -1283,6

[Mesa-dev] [PATCH] radv: disable conditional rendering for vkCmdCopyQueryPoolResults()

2018-11-05 Thread Samuel Pitoiset
VK_EXT_conditional_rendering says that copy commands should not be affected by conditional rendering. Cc: 18.2 18.3 Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_query.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/amd/vulkan/radv_query.c

Re: [Mesa-dev] [PATCH v4 1/2] i965/batch: avoid reverting batch buffer if saved state is an empty

2018-11-05 Thread Jordan Justen
On 2018-11-05 00:11:52, andrey simiklit wrote: > Hello, > > I tested this patch few times and have the following results: > https://mesa-ci.01.org/global_logic/builds/38/group/63a9f0ea7bb98050796b649e85481845 > https://mesa-ci.01.org/global_logic/builds/41/group/63a9f0ea7bb98050796b649e85481845 >

Re: [Mesa-dev] [PATCH] EGL/mesa: Initial writeup for MESA_query_renderer

2018-11-05 Thread Haehnle, Nicolai
On 05.11.18 05:48, Veluri Mithun wrote: > Sry for the late, I had internal exams last month. > > the EGL version of the extension to the new document.  The EGL enums > will probably be different, so maybe replace the enum values with 0x > for now. > > What are these tokens(enum

Re: [Mesa-dev] [PATCH 1/4] intel/dump_gpu: add missing gdb option

2018-11-05 Thread Tapani Pälli
Series is Reviewed-by: Tapani Pälli On 10/29/18 8:14 PM, Lionel Landwerlin wrote: Signed-off-by: Lionel Landwerlin --- src/intel/tools/intel_dump_gpu.in | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/intel/tools/intel_dump_gpu.in b/src/intel/tools/intel_dump_gpu.in index

[Mesa-dev] [Bug 108560] Mesa 32 is built without sse

2018-11-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108560 network...@rkmail.ru changed: What|Removed |Added CC||network...@rkmail.ru -- You are

Re: [Mesa-dev] [PATCH v4 1/2] i965/batch: avoid reverting batch buffer if saved state is an empty

2018-11-05 Thread andrey simiklit
Hello, I tested this patch few times and have the following results: https://mesa-ci.01.org/global_logic/builds/38/group/63a9f0ea7bb98050796b649e85481845 https://mesa-ci.01.org/global_logic/builds/41/group/63a9f0ea7bb98050796b649e85481845