Re: [Mesa-dev] [PATCH 1/3] nir: add new linking opt nir_move_out_const_to_consumer()

2018-11-06 Thread Timothy Arceri
Thinking about this some more I think I need to add some code to check write_masks. I'll add this and some piglit tests for it later tonight or tomorrow. On 7/11/18 3:20 pm, Timothy Arceri wrote: This pass moves constant outputs to the consuming shader stage where possible. ---

Re: [Mesa-dev] intel: WIP: Support for using 16-bits for mediump

2018-11-06 Thread Iago Toral
On Tue, 2018-11-06 at 11:04 +0200, Pohjolainen, Topi wrote: > On Tue, Nov 06, 2018 at 09:40:17AM +0100, Iago Toral wrote: > > On Tue, 2018-11-06 at 08:30 +0200, Topi Pohjolainen wrote: > > > Here is a version 2 of adding support for 16-bit float > > > instructions > > > in > > > the shader

Re: [Mesa-dev] [PATCH 3/3] anv/i965: make use of nir_move_out_const_to_consumer()

2018-11-06 Thread Timothy Arceri
shader-db results for SLK: On 7/11/18 3:20 pm, Timothy Arceri wrote: total instructions in shared programs: 13106498 -> 13091573 (-0.11%) instructions in affected programs: 1186244 -> 1171319 (-1.26%) helped: 6186 HURT: 0 total cycles in shared programs: 332062633 -> 331961653 (-0.03%) cycles

[Mesa-dev] [PATCH 3/3] anv/i965: make use of nir_move_out_const_to_consumer()

2018-11-06 Thread Timothy Arceri
total instructions in shared programs: 13106498 -> 13091573 (-0.11%) instructions in affected programs: 1186244 -> 1171319 (-1.26%) helped: 6186 HURT: 0 total cycles in shared programs: 332062633 -> 331961653 (-0.03%) cycles in affected programs: 8537165 -> 8436185 (-1.18%) helped: 5371 HURT: 862

[Mesa-dev] [PATCH 1/3] nir: add new linking opt nir_move_out_const_to_consumer()

2018-11-06 Thread Timothy Arceri
This pass moves constant outputs to the consuming shader stage where possible. --- src/compiler/nir/nir.h| 2 + src/compiler/nir/nir_linking_helpers.c| 104 ++ src/mesa/state_tracker/st_glsl_to_nir.cpp | 2 +- 3 files changed, 107 insertions(+), 1

[Mesa-dev] [PATCH 2/3] radv: make use of nir_move_out_const_to_consumer()

2018-11-06 Thread Timothy Arceri
vkpipeline-db results: Totals from affected shaders: SGPRS: 28400 -> 28576 (0.62 %) VGPRS: 27916 -> 27692 (-0.80 %) Spilled SGPRs: 140 -> 138 (-1.43 %) Spilled VGPRs: 0 -> 0 (0.00 %) Private memory VGPRs: 0 -> 0 (0.00 %) Scratch size: 0 -> 0 (0.00 %) dwords per thread Code Size: 1534456 ->

Re: [Mesa-dev] [PATCH vulkan/spec 1/3] Add an extension to specify that derivative groups are quads

2018-11-06 Thread Jason Ekstrand
On Tue, Nov 6, 2018 at 9:43 PM Roland Scheidegger wrote: > Am 06.11.18 um 22:48 schrieb Jason Ekstrand: > > This came to the top of my list recently due to a difference between > > OpenGL and Vulkan discard operations and D3D's discard operation. The > > OpenGL and Vulkan discard is defined to

Re: [Mesa-dev] [PATCH vulkan/spec 1/3] Add an extension to specify that derivative groups are quads

2018-11-06 Thread Roland Scheidegger
Am 06.11.18 um 22:48 schrieb Jason Ekstrand: > This came to the top of my list recently due to a difference between > OpenGL and Vulkan discard operations and D3D's discard operation. The > OpenGL and Vulkan discard is defined to be control flow and derivatives > are undefined after discard.

[Mesa-dev] [PATCH] freedreno: implements get_sample_position

2018-11-06 Thread Hyunjun Ko
Since 1285f71d3e landed, it needs to provide apps with proper sample position for MSAA. Currently no way to query this to hw, these are taken from blob driver. Fixes: dEQP-GLES31.functional.texture.multisample.samples_#.sample_position --- .../drivers/freedreno/freedreno_resource.c| 43

Re: [Mesa-dev] [PATCH v2 2/5] gallium: Add new PIPE_CAP_MULTISAMPLED_RENDER_TO_TEXTURE

2018-11-06 Thread Roland Scheidegger
Am 07.11.18 um 00:03 schrieb Kristian Høgsberg: > On Tue, Nov 6, 2018 at 2:44 PM Axel Davy wrote: >> >> Hi, >> >> Is there anything to be done in the nine state trackers (or other state >> trackers). >> >> Nine uses create_surface. Should it expect the field to be filled >> properly by the driver

Re: [Mesa-dev] [PATCH 21/31] nir: Add support for 1-bit data types

2018-11-06 Thread Connor Abbott
I quickly looked through the users of glsl_get_bit_size, and here are the ones I found that still have to be fixed up: - vtn_type_layout_430() - vtn_type_block_size() in vtn_variables.c - our OpBitcast implementation, although I don't think we can see booleans there? (Also, it doesn't handle 8

Re: [Mesa-dev] [PATCH v2 2/5] gallium: Add new PIPE_CAP_MULTISAMPLED_RENDER_TO_TEXTURE

2018-11-06 Thread Kristian Høgsberg
On Tue, Nov 6, 2018 at 2:44 PM Axel Davy wrote: > > Hi, > > Is there anything to be done in the nine state trackers (or other state > trackers). > > Nine uses create_surface. Should it expect the field to be filled > properly by the driver ? Nothing is required from any state tracker, but if

Re: [Mesa-dev] [PATCH v2 1/5] mesa: Add core support for EXT_multisampled_render_to_texture2

2018-11-06 Thread Ilia Mirkin
On Tue, Nov 6, 2018 at 5:18 PM Kristian H. Kristensen wrote: > > This also turns on EXT_multisampled_render_to_texture which is a > subset of EXT_multisampled_render_to_texture2, allowing only > COLOR_ATTACHMENT0. You also enable the texture2 variant as well, no? > > Signed-off-by: Kristian H.

Re: [Mesa-dev] [PATCH 21/31] nir: Add support for 1-bit data types

2018-11-06 Thread Connor Abbott
On Tue, Oct 23, 2018 at 12:16 AM Jason Ekstrand wrote: > > This commit adds support for 1-bit booleans and integers. Booleans > obviously take a value of true or false. Because we have to define the > semantics of 1-bit signed and unsigned integers, we define uint1_t to > take values of 0 and 1

Re: [Mesa-dev] [PATCH v2 2/5] gallium: Add new PIPE_CAP_MULTISAMPLED_RENDER_TO_TEXTURE

2018-11-06 Thread Axel Davy
Hi, Is there anything to be done in the nine state trackers (or other state trackers). Nine uses create_surface. Should it expect the field to be filled properly by the driver ? On 06/11/2018 23:09, Kristian H. Kristensen wrote: + /** +* If a driver doesn't advertise

[Mesa-dev] [PATCH v2 3/5] st/mesa: Add support for EXT_multisampled_render_to_texture

2018-11-06 Thread Kristian H. Kristensen
In gallium, we model the attachment sample count as a new nr_samples field in pipe_surface. A driver can indicate support for the extension using the new pipe cap, PIPE_CAP_MULTISAMPLED_RENDER_TO_TEXTURE. Signed-off-by: Kristian H. Kristensen --- src/mesa/state_tracker/st_cb_fbo.c | 3 +++

[Mesa-dev] [PATCH 0/4] EXT_multisampled_render_to_texture and MSAA for a6xx

2018-11-06 Thread Kristian H. Kristensen
Here's a small patch series that adds support for EXT_multisampled_render_to_texture to core mesa and gallium, turns on MSAA for freedreno/a6xx and then enables the new extension for a6xx. v2: - Split gallium and st commit - Document PIPE_CAP_MULTISAMPLED_RENDER_TO_TEXTURE - Move sample count

[Mesa-dev] [PATCH v2 2/5] gallium: Add new PIPE_CAP_MULTISAMPLED_RENDER_TO_TEXTURE

2018-11-06 Thread Kristian H. Kristensen
This new pipe cap and the new nr_samples field in pipe_surface lets a state tracker bind a render target with a different sample count than the resource. This allows for implementing EXT_multisampled_render_to_texture and EXT_multisampled_render_to_texture2. Signed-off-by: Kristian H. Kristensen

[Mesa-dev] [PATCH v2 5/5] freedreno: Add support for EXT_multisampled_render_to_texture

2018-11-06 Thread Kristian H. Kristensen
There is not much to do in freedreno - tile layout and multisample state for gmem renderings is programmed based on the pfb sample count, while resolve blits take the destination sample count from the resource. Signed-off-by: Kristian H. Kristensen ---

[Mesa-dev] [PATCH v2 1/5] mesa: Add core support for EXT_multisampled_render_to_texture2

2018-11-06 Thread Kristian H. Kristensen
This also turns on EXT_multisampled_render_to_texture which is a subset of EXT_multisampled_render_to_texture2, allowing only COLOR_ATTACHMENT0. Signed-off-by: Kristian H. Kristensen --- .../EXT_multisampled_render_to_texture.xml| 34 ++ src/mapi/glapi/gen/Makefile.am

[Mesa-dev] [PATCH v2 4/5] freedreno/a6xx: MSAA

2018-11-06 Thread Kristian H. Kristensen
From: Rob Clark Signed-off-by: Rob Clark --- .../drivers/freedreno/a6xx/fd6_blend.c| 2 + .../drivers/freedreno/a6xx/fd6_context.c | 2 + src/gallium/drivers/freedreno/a6xx/fd6_draw.c | 3 ++ src/gallium/drivers/freedreno/a6xx/fd6_emit.c | 12 --

Re: [Mesa-dev] [PATCH] st/mesa: don't do L3 thread pinning for Blender

2018-11-06 Thread Edmondo Tommasina
Hi Marek It would be nice to have the driconf part of this patch committed in master to make it easy to test with and without the L3 pinning, so this patch is: Reviewed-by: Edmondo Tommasina Now with this patch in place I'm starting to collect some numbers with and without the CCX affinity on

[Mesa-dev] [PATCH 0/3] vulkan, anv: Add a new VK_EXT_derivative_group_quad

2018-11-06 Thread Jason Ekstrand
This three-patch series includes a draft of a new Vulkan extension along with the trivial implementation in anv. The extension allows a driver to advertise that derivative groups are just quads. In other words, that it's safe to mix non-uniform control flow and derivatives as long as the

[Mesa-dev] [PATCH vulkan/spec 1/3] Add an extension to specify that derivative groups are quads

2018-11-06 Thread Jason Ekstrand
This came to the top of my list recently due to a difference between OpenGL and Vulkan discard operations and D3D's discard operation. The OpenGL and Vulkan discard is defined to be control flow and derivatives are undefined after discard. With D3D, derivatives are considered well-defined after

[Mesa-dev] [PATCH mesa 2/3] vulkan: Import the XML and headers bits for VK_EXT_derivative_group_quad

2018-11-06 Thread Jason Ekstrand
--- include/vulkan/vulkan_core.h | 13 + src/vulkan/registry/vk.xml | 13 ++--- 2 files changed, 23 insertions(+), 3 deletions(-) diff --git a/include/vulkan/vulkan_core.h b/include/vulkan/vulkan_core.h index 4cd8ed51dcd..e14aaf8c184 100644 ---

[Mesa-dev] [PATCH mesa 3/3] anv: Add support for VK_EXT_derivative_group_quad

2018-11-06 Thread Jason Ekstrand
--- src/intel/vulkan/anv_device.c | 8 src/intel/vulkan/anv_extensions.py | 1 + 2 files changed, 9 insertions(+) diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c index ee35e013329..89827ccacbe 100644 --- a/src/intel/vulkan/anv_device.c +++

Re: [Mesa-dev] [PATCH 2/4] st/mesa: Add support for EXT_multisampled_render_to_texture

2018-11-06 Thread Kristian Høgsberg
On Tue, Nov 6, 2018 at 12:09 PM Ilia Mirkin wrote: > > On Tue, Nov 6, 2018 at 2:31 PM Kristian H. Kristensen > wrote: > > > > In gallium, we model the attachment sample count as a new nr_samples > > field in pipe_surface. A driver can indicate support for the extension > > using the new pipe

Re: [Mesa-dev] [PATCH] radv/nir: avoid packing vertex outputs we can eliminate

2018-11-06 Thread Timothy Arceri
On 7/11/18 7:40 am, Timothy Arceri wrote: On 7/11/18 5:00 am, Eric Anholt wrote: Timothy Arceri writes: On Mon, Nov 5, 2018, at 4:44 PM, Timothy Arceri wrote: On 6/11/18 11:30 am, Eric Anholt wrote: Timothy Arceri writes: For now I have only enabled this for RADV we can do it also for

Re: [Mesa-dev] [PATCH 1/3] st/nine: fix stack corruption due to ABI mismatch

2018-11-06 Thread Axel Davy
Hi, The three patches seem ok. Thanks, Reviewed-by: Axel Davy I assume you don't have push rights. I will push in a few days if nobody complains. Yours, Axel Davy On 06/11/2018 09:27, Andre Heider wrote: This fixes various crashes and hangs when using nine's 'thread_submit' feature.

Re: [Mesa-dev] [PATCH] radv/nir: avoid packing vertex outputs we can eliminate

2018-11-06 Thread Timothy Arceri
On 7/11/18 5:00 am, Eric Anholt wrote: Timothy Arceri writes: On Mon, Nov 5, 2018, at 4:44 PM, Timothy Arceri wrote: On 6/11/18 11:30 am, Eric Anholt wrote: Timothy Arceri writes: For now I have only enabled this for RADV we can do it also for radeonsi also but we need to add a CAP for

Re: [Mesa-dev] [PATCH 3/4] freedreno/a6xx: MSAA

2018-11-06 Thread Rob Clark
On Tue, Nov 6, 2018 at 3:14 PM Ilia Mirkin wrote: > > On Tue, Nov 6, 2018 at 2:31 PM Kristian H. Kristensen > wrote: > > > > From: Rob Clark > > > > Signed-off-by: Rob Clark > > --- > > .../drivers/freedreno/a6xx/fd6_blend.c| 2 + > > .../drivers/freedreno/a6xx/fd6_context.c |

Re: [Mesa-dev] [PATCH 4/4] freedreno: Add support for EXT_multisampled_render_to_texture

2018-11-06 Thread Rob Clark
On Tue, Nov 6, 2018 at 3:18 PM Ilia Mirkin wrote: > > On Tue, Nov 6, 2018 at 2:31 PM Kristian H. Kristensen > wrote: > > > > There is not much to do in freedreno - tile layout and multisample > > state for gmem renderings is programmed based on the pfb sample count, > > while resolve blits take

Re: [Mesa-dev] [PATCH v5 0/3] Add and enable extension EXT_sRGB_write_control

2018-11-06 Thread Ilia Mirkin
On Tue, Nov 6, 2018 at 3:15 PM Gert Wollny wrote: > > Am Dienstag, den 06.11.2018, 11:14 -0500 schrieb Ilia Mirkin: > > On Tue, Nov 6, 2018 at 10:27 AM Gert Wollny > m> wrote: > > I'm not as intimately familiar with GLES extensions / features, but > > would EXT_sRGB be the extension that covers

Re: [Mesa-dev] [PATCH 4/4] freedreno: Add support for EXT_multisampled_render_to_texture

2018-11-06 Thread Ilia Mirkin
On Tue, Nov 6, 2018 at 2:31 PM Kristian H. Kristensen wrote: > > There is not much to do in freedreno - tile layout and multisample > state for gmem renderings is programmed based on the pfb sample count, > while resolve blits take the destination sample count from the resource. > >

Re: [Mesa-dev] [PATCH v5 0/3] Add and enable extension EXT_sRGB_write_control

2018-11-06 Thread Gert Wollny
Am Dienstag, den 06.11.2018, 11:14 -0500 schrieb Ilia Mirkin: > On Tue, Nov 6, 2018 at 10:27 AM Gert Wollny m> wrote: > I'm not as intimately familiar with GLES extensions / features, but > would EXT_sRGB be the extension that covers that support? The extension has the status "not complete" but

Re: [Mesa-dev] [PATCH 3/4] freedreno/a6xx: MSAA

2018-11-06 Thread Ilia Mirkin
On Tue, Nov 6, 2018 at 2:31 PM Kristian H. Kristensen wrote: > > From: Rob Clark > > Signed-off-by: Rob Clark > --- > .../drivers/freedreno/a6xx/fd6_blend.c| 2 + > .../drivers/freedreno/a6xx/fd6_context.c | 2 + > src/gallium/drivers/freedreno/a6xx/fd6_draw.c | 3 ++ >

Re: [Mesa-dev] [PATCH 2/4] st/mesa: Add support for EXT_multisampled_render_to_texture

2018-11-06 Thread Ilia Mirkin
On Tue, Nov 6, 2018 at 2:31 PM Kristian H. Kristensen wrote: > > In gallium, we model the attachment sample count as a new nr_samples > field in pipe_surface. A driver can indicate support for the extension > using the new pipe cap, PIPE_CAP_MULTISAMPLED_RENDER_TO_TEXTURE. > > Signed-off-by:

[Mesa-dev] [PATCH 1/4] mesa: Add core support for EXT_multisampled_render_to_texture

2018-11-06 Thread Kristian H. Kristensen
Signed-off-by: Kristian H. Kristensen --- .../EXT_multisampled_render_to_texture.xml| 34 ++ src/mapi/glapi/gen/Makefile.am| 1 + src/mapi/glapi/gen/gl_API.xml | 2 + src/mapi/glapi/gen/meson.build| 1 +

[Mesa-dev] [PATCH 3/4] freedreno/a6xx: MSAA

2018-11-06 Thread Kristian H. Kristensen
From: Rob Clark Signed-off-by: Rob Clark --- .../drivers/freedreno/a6xx/fd6_blend.c| 2 + .../drivers/freedreno/a6xx/fd6_context.c | 2 + src/gallium/drivers/freedreno/a6xx/fd6_draw.c | 3 ++ src/gallium/drivers/freedreno/a6xx/fd6_emit.c | 12 --

[Mesa-dev] [PATCH 4/4] freedreno: Add support for EXT_multisampled_render_to_texture

2018-11-06 Thread Kristian H. Kristensen
There is not much to do in freedreno - tile layout and multisample state for gmem renderings is programmed based on the pfb sample count, while resolve blits take the destination sample count from the resource. Signed-off-by: Kristian H. Kristensen ---

[Mesa-dev] [PATCH 2/4] st/mesa: Add support for EXT_multisampled_render_to_texture

2018-11-06 Thread Kristian H. Kristensen
In gallium, we model the attachment sample count as a new nr_samples field in pipe_surface. A driver can indicate support for the extension using the new pipe cap, PIPE_CAP_MULTISAMPLED_RENDER_TO_TEXTURE. Signed-off-by: Kristian H. Kristensen --- src/gallium/include/pipe/p_defines.h | 1 +

[Mesa-dev] [PATCH 0/4] EXT_multisampled_render_to_texture and MSAA for a6xx

2018-11-06 Thread Kristian H. Kristensen
Here's a small patch series that adds support for EXT_multisampled_render_to_texture to core mesa and gallium, turns on MSAA for freedreno/a6xx and then enables the new extension for a6xx. Kristian ___ mesa-dev mailing list

Re: [Mesa-dev] [PATCH] radv/nir: avoid packing vertex outputs we can eliminate

2018-11-06 Thread Eric Anholt
Timothy Arceri writes: > On Mon, Nov 5, 2018, at 4:44 PM, Timothy Arceri wrote: >> On 6/11/18 11:30 am, Eric Anholt wrote: >> > Timothy Arceri writes: >> > >> >> For now I have only enabled this for RADV we can do it >> >> also for radeonsi also but we need to add a CAP for it. >> > >> > If

Re: [Mesa-dev] [PATCH] vulkan: Update the XML and headers to 1.1.90

2018-11-06 Thread Lionel Landwerlin
Acked-by: Lionel Landwerlin ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] vulkan: Update the XML and headers to 1.1.90

2018-11-06 Thread Samuel Pitoiset
Acked-by: Samuel Pitoiset On 11/6/18 4:50 PM, Jason Ekstrand wrote: The biggest change here is the rename of VK_NVX_ray_tracing to VK_NV_ray_tracing and the total removal of VK_KHR_mir_surface. --- include/vulkan/vulkan.h | 6 - include/vulkan/vulkan_core.h | 480

Re: [Mesa-dev] [PATCH v2 03/13] intel/decoder: tools: Use engine for decoding batch instructions

2018-11-06 Thread Lionel Landwerlin
On 06/11/2018 17:26, Toni Lönnberg wrote: On Tue, Nov 06, 2018 at 12:11:16PM +, Lionel Landwerlin wrote: On 31/10/2018 13:12, Toni Lönnberg wrote: The engine to which the batch was sent to is now set to the decoder context when decoding the batch. This is needed so that we can distinguish

Re: [Mesa-dev] [PATCH v3 4/4] r600: Add support for EXT_texture_sRGB_R8

2018-11-06 Thread Roland Scheidegger
Reviewed-by: Roland Scheidegger Am 06.11.18 um 12:04 schrieb Gert Wollny: > Hi Dave & Roland, > > Can I persuade you to take a look at this one-liner? > > Many thanks, > Gert > > Am Donnerstag, den 01.11.2018, 12:59 +0100 schrieb Gert Wollny: >> From: Gert Wollny >> >> Enables on R600

Re: [Mesa-dev] [PATCH v2 04/13] intel/genxml: Add engine definition to render engine instructions (gen4)

2018-11-06 Thread Toni Lönnberg
On Tue, Nov 06, 2018 at 12:40:43PM +, Lionel Landwerlin wrote: > On 31/10/2018 13:12, Toni Lönnberg wrote: > > Instructions meant for the render engine now have a definition > > specifying that so that can differentiate instructions meant for > > different engines due to shared opcodes. v2:

Re: [Mesa-dev] [PATCH v2 03/13] intel/decoder: tools: Use engine for decoding batch instructions

2018-11-06 Thread Toni Lönnberg
On Tue, Nov 06, 2018 at 12:11:16PM +, Lionel Landwerlin wrote: > On 31/10/2018 13:12, Toni Lönnberg wrote: > > The engine to which the batch was sent to is now set to the decoder context > > when > > decoding the batch. This is needed so that we can distinguish between > > instructions as the

Re: [Mesa-dev] [PATCH v2 02/13] intel/decoder: Engine parameter for instructions

2018-11-06 Thread Toni Lönnberg
On Tue, Nov 06, 2018 at 12:07:58PM +, Lionel Landwerlin wrote: > On 31/10/2018 13:12, Toni Lönnberg wrote: > > Preliminary work for adding handling of different pipes to gen_decoder. Each > > instruction needs to have a definition describing which engine it is meant > > for. > > If left

Re: [Mesa-dev] [PATCH v5 0/3] Add and enable extension EXT_sRGB_write_control

2018-11-06 Thread Marek Olšák
I prefer not to have any negative caps. Marek On Tue, Nov 6, 2018, 11:14 AM Ilia Mirkin On Tue, Nov 6, 2018 at 10:27 AM Gert Wollny > wrote: > > > > Am Dienstag, den 06.11.2018, 09:29 -0500 schrieb Ilia Mirkin: > > > On Tue, Nov 6, 2018 at 5:59 AM Gert Wollny > > > wrote: > > > > > > > > > >

Re: [Mesa-dev] [PATCH] amd: remove support for LLVM 6.0

2018-11-06 Thread Marek Olšák
On Tue, Nov 6, 2018, 2:47 AM Samuel Pitoiset > > On 11/5/18 10:52 PM, Marek Olšák wrote: > > On Fri, Nov 2, 2018 at 5:21 AM Samuel Pitoiset > > mailto:samuel.pitoi...@gmail.com>> wrote: > > > > User are encouraged to switch to LLVM 7.0 released in September 2018. > > > > Signed-off-by:

Re: [Mesa-dev] [PATCH 1/3] freedreno: implements get_sample_position

2018-11-06 Thread Erik Faye-Lund
On Tue, 2018-11-06 at 19:27 +0900, Hyunjun Ko wrote: > Since 1285f71d3e landed, it needs to provide apps with proper sample > position for MSAA. > > Currently no way to query this to hw, these are taken from blob > driver. > > Fixes: dEQP- >

[Mesa-dev] [ANNOUNCE] mesa 18.3.0-rc1

2018-11-06 Thread Emil Velikov
The first release candidate for Mesa 18.3.0 is now available. The plan is to have one release candidate every Wednesday, until the anticipated final release on 21nd November 2018. The expectation is that the 18.2 branch will remain alive with bi- weekly releases until the 18.3.1 release. Here

[Mesa-dev] [PATCH v2 0/2] anv: Implement VK_KHR_draw_indirect_count and VK_EXT_conditional_rendering

2018-11-06 Thread Danylo Piliaiev
This series implement VK_KHR_draw_indirect_count and VK_EXT_conditional_rendering extensions. They are implemented together because they are highly interweaved. There are already tests in VK_CTS for VK_KHR_draw_indirect_count. Tests for VK_EXT_conditional_rendering

[Mesa-dev] [PATCH v2 1/2] anv: Implement VK_KHR_draw_indirect_count for gen 7+

2018-11-06 Thread Danylo Piliaiev
v2: by Jason Ekstrand - Move out of the draw loop population of registers which aren't changed in it - Remove dependency on ALU registers - Clarify usage of PIPE_CONTROL - Without usage of ALU registers patch works for gen7+ Signed-off-by: Danylo Piliaiev --- I'm uncertain about

[Mesa-dev] [PATCH v2 2/2] anv: Implement VK_EXT_conditional_rendering for gen 7.5+

2018-11-06 Thread Danylo Piliaiev
Conditional rendering affects next functions: - vkCmdDraw, vkCmdDrawIndexed, vkCmdDrawIndirect, vkCmdDrawIndexedIndirect - vkCmdDrawIndirectCountKHR, vkCmdDrawIndexedIndirectCountKHR - vkCmdDispatch, vkCmdDispatchIndirect, vkCmdDispatchBase - vkCmdClearAttachments To reduce readings from the

Re: [Mesa-dev] [PATCH v5 0/3] Add and enable extension EXT_sRGB_write_control

2018-11-06 Thread Ilia Mirkin
On Tue, Nov 6, 2018 at 10:27 AM Gert Wollny wrote: > > Am Dienstag, den 06.11.2018, 09:29 -0500 schrieb Ilia Mirkin: > > On Tue, Nov 6, 2018 at 5:59 AM Gert Wollny > > wrote: > > > > > > > > > I'm not so sure that things break, at least we have all the dEQP > > > master tests that are enabled by

[Mesa-dev] [PATCH] vulkan: Update the XML and headers to 1.1.90

2018-11-06 Thread Jason Ekstrand
The biggest change here is the rename of VK_NVX_ray_tracing to VK_NV_ray_tracing and the total removal of VK_KHR_mir_surface. --- include/vulkan/vulkan.h | 6 - include/vulkan/vulkan_core.h | 480 --- include/vulkan/vulkan_mir.h | 65 -

Re: [Mesa-dev] [PATCH mesa] meson: hide warnings from external project `gtest`

2018-11-06 Thread Eric Engestrom
On Tuesday, 2018-11-06 14:32:53 +, Emil Velikov wrote: > On Wed, 31 Oct 2018 at 18:47, Emil Velikov wrote: > > > > One that I'd like to eventually enable (and as an error if possible) > > > is -Wundef to warn when undefined macros are used; in my experience at > > > $PREVIOUS_JOB this

Re: [Mesa-dev] [PATCH 1/2] anv: stub internal android code

2018-11-06 Thread Lionel Landwerlin
Thanks Eric & Tapani. Pushed to master. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH v5 0/3] Add and enable extension EXT_sRGB_write_control

2018-11-06 Thread Gert Wollny
Am Dienstag, den 06.11.2018, 09:29 -0500 schrieb Ilia Mirkin: > On Tue, Nov 6, 2018 at 5:59 AM Gert Wollny > wrote: > > > > > > I'm not so sure that things break, at least we have all the dEQP > > master tests that are enabled by the available extension (level > > GLES 3.2+) passing on virgl,

Re: [Mesa-dev] [PATCH mesa 2/2] wsi/wayland: only finish() a successfully init()ed display

2018-11-06 Thread Eric Engestrom
On Tuesday, 2018-11-06 15:15:41 +0100, Juan A. Suarez Romero wrote: > On Mon, 2018-11-05 at 10:00 +, Eric Engestrom wrote: > > Cc: Dave Airlie > > Cc: Philipp Zabel > > Signed-off-by: Eric Engestrom > > --- > > src/vulkan/wsi/wsi_common_wayland.c | 3 ++- > > 1 file changed, 2

Re: [Mesa-dev] [PATCH v2] egl/glvnd: correctly report errors when vendor cannot be found

2018-11-06 Thread Kyle Brenneman
On 11/05/2018 10:00 AM, Emil Velikov wrote: From: Emil Velikov If the user provides an invalid display or device the ToVendor lookup will fail. In this case, the local [Mesa vendor] error code will be set. Thus on sequential eglGetError(), the error will be EGL_SUCCESS. To be more specific,

Re: [Mesa-dev] [PATCH mesa] meson: hide warnings from external project `gtest`

2018-11-06 Thread Emil Velikov
On Wed, 31 Oct 2018 at 18:47, Emil Velikov wrote: > > One that I'd like to eventually enable (and as an error if possible) > > is -Wundef to warn when undefined macros are used; in my experience at > > $PREVIOUS_JOB this warning very often indicates actual bugs. > > > It would have caught a bug

Re: [Mesa-dev] [PATCH v5 0/3] Add and enable extension EXT_sRGB_write_control

2018-11-06 Thread Ilia Mirkin
On Tue, Nov 6, 2018 at 5:59 AM Gert Wollny wrote: > > Am Montag, den 05.11.2018, 11:17 -0500 schrieb Ilia Mirkin: > > On Mon, Nov 5, 2018 at 11:02 AM Gert Wollny > m> wrote: > > > > > > Am Montag, den 05.11.2018, 08:56 -0500 schrieb Ilia Mirkin: > > > > At the gallium level, it's a promise that

Re: [Mesa-dev] [PATCH 11/13] anv: introduce device compatibility checks for format query

2018-11-06 Thread andrey simiklit
Hello, Please find my comment below: On Mon, Nov 5, 2018 at 5:36 PM Lionel Landwerlin < lionel.g.landwer...@intel.com> wrote: > We add a function that allows us to check whether a particular > description of a Vulkan format is available for a given device. > > Signed-off-by: Lionel Landwerlin

Re: [Mesa-dev] [PATCH mesa 2/2] wsi/wayland: only finish() a successfully init()ed display

2018-11-06 Thread Juan A. Suarez Romero
On Mon, 2018-11-05 at 10:00 +, Eric Engestrom wrote: > Cc: Dave Airlie > Cc: Philipp Zabel > Signed-off-by: Eric Engestrom > --- > src/vulkan/wsi/wsi_common_wayland.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/vulkan/wsi/wsi_common_wayland.c >

Re: [Mesa-dev] [PATCH 1/2] gbm: Introduce a helper function for printing GBM format names.

2018-11-06 Thread Daniel Stone
Hi, On Tue, 6 Nov 2018 at 13:11, Eric Engestrom wrote: > On Friday, 2018-11-02 14:40:49 -0700, Eric Anholt wrote: > > +GBM_EXPORT char * > > +gbm_format_get_name(uint32_t gbm_format, struct gbm_format_name_desc *desc) > > +{ > > Actually, This won't work with the two GBM_BO_FORMAT_{X,A}RGB;

Re: [Mesa-dev] [Mesa-stable] [PATCH 0/5] add support for EXT_shader_implicit_conversions

2018-11-06 Thread Erik Faye-Lund
On Nov 6, 2018 13:51, "Juan A. Suarez Romero" wrote:On Tue, 2018-11-06 at 10:32 +, Emil Velikov wrote: > On Fri, 2 Nov 2018 at 16:06, Erik Faye-Lund > wrote: > > On Fri, 2018-11-02 at 15:40 +, Emil Velikov wrote: > > > On Tue, 30 Oct 2018 at 17:11, Erik Faye-Lund > > > wrote: > >

Re: [Mesa-dev] [PATCH v5 0/3] Add and enable extension EXT_sRGB_write_control

2018-11-06 Thread Gert Wollny
Am Montag, den 05.11.2018, 17:00 -0500 schrieb Marek Olšák: > At the Gallium level, you can change between UNORM and SRGB in > pipe_surface. If you allocate a texture as SRGB, you should be able > to use it as LINEAR and vice versa. > > All hardware that supports both LINEAR and SRGB supports

Re: [Mesa-dev] intel: WIP: Support for using 16-bits for mediump

2018-11-06 Thread Pohjolainen, Topi
On Tue, Nov 06, 2018 at 02:08:32PM +0100, Connor Abbott wrote: > On Tue, Nov 6, 2018 at 1:45 PM Pohjolainen, Topi > wrote: > > > > On Tue, Nov 06, 2018 at 11:31:58AM +0100, Connor Abbott wrote: > > > On Tue, Nov 6, 2018 at 11:14 AM Pohjolainen, Topi > > > wrote: > > > > > > > > On Tue, Nov 06,

Re: [Mesa-dev] [PATCH 04/13] anv: associate vulkan formats with aspects

2018-11-06 Thread Eric Engestrom
On Monday, 2018-11-05 15:35:58 +, Lionel Landwerlin wrote: > This will make it easier to associate an aspect with a plane number. > > Signed-off-by: Lionel Landwerlin > --- > src/intel/vulkan/anv_formats.c | 107 - > src/intel/vulkan/anv_private.h | 3 + >

Re: [Mesa-dev] [PATCH 1/2] gbm: Introduce a helper function for printing GBM format names.

2018-11-06 Thread Eric Engestrom
On Friday, 2018-11-02 14:40:49 -0700, Eric Anholt wrote: > This requires that the caller make a little (stack) allocation to store > the string. > --- > src/gbm/main/gbm.c | 18 ++ > src/gbm/main/gbm.h | 6 ++ > 2 files changed, 24 insertions(+) > > diff --git

Re: [Mesa-dev] intel: WIP: Support for using 16-bits for mediump

2018-11-06 Thread Connor Abbott
On Tue, Nov 6, 2018 at 1:45 PM Pohjolainen, Topi wrote: > > On Tue, Nov 06, 2018 at 11:31:58AM +0100, Connor Abbott wrote: > > On Tue, Nov 6, 2018 at 11:14 AM Pohjolainen, Topi > > wrote: > > > > > > On Tue, Nov 06, 2018 at 10:45:52AM +0100, Connor Abbott wrote: > > > > As far as I understand,

Re: [Mesa-dev] [PATCH 12/15] anv: introduce helper to resolve vk_format from anv_format

2018-11-06 Thread Lionel Landwerlin
We could touch the macros in anv_formats.c to include VkFormat in anv_format if that makes your life easier. On 30/10/2018 05:26, Tapani Pälli wrote: Signed-off-by: Tapani Pälli --- src/intel/vulkan/anv_formats.c | 18 ++ src/intel/vulkan/anv_private.h | 3 +++ 2 files

Re: [Mesa-dev] [Mesa-stable] [PATCH] wayland/egl: Resize EGL surface on update buffer for swrast

2018-11-06 Thread Juan A. Suarez Romero
On Tue, 2018-11-06 at 09:53 +0100, Olivier Fourdan wrote: > Hi > > On Thu, Oct 25, 2018 at 5:51 PM Juan A. Suarez Romero > wrote: > > On Thu, 2018-10-25 at 14:48 +0200, Olivier Fourdan wrote: > > > After commit a9fb331ea ("wayland/egl: update surface size on window > > > resize"), the surface

Re: [Mesa-dev] [PATCH 1/2] anv: stub internal android code

2018-11-06 Thread Eric Engestrom
On Tuesday, 2018-11-06 12:55:06 +, Lionel Landwerlin wrote: > On 06/11/2018 12:52, Eric Engestrom wrote: > > On Tuesday, 2018-11-06 12:42:20 +, Lionel Landwerlin wrote: > > > On 06/11/2018 12:20, Eric Engestrom wrote: > > > > On Tuesday, 2018-11-06 11:37:50 +, Lionel Landwerlin wrote:

Re: [Mesa-dev] [PATCH 1/2] anv: stub internal android code

2018-11-06 Thread Lionel Landwerlin
On 06/11/2018 12:52, Eric Engestrom wrote: On Tuesday, 2018-11-06 12:42:20 +, Lionel Landwerlin wrote: On 06/11/2018 12:20, Eric Engestrom wrote: On Tuesday, 2018-11-06 11:37:50 +, Lionel Landwerlin wrote: This reduces the amount of #ifdef ANDROID we'll have to have inside the driver.

Re: [Mesa-dev] [PATCH 1/2] anv: stub internal android code

2018-11-06 Thread Eric Engestrom
On Tuesday, 2018-11-06 12:42:20 +, Lionel Landwerlin wrote: > On 06/11/2018 12:20, Eric Engestrom wrote: > > On Tuesday, 2018-11-06 11:37:50 +, Lionel Landwerlin wrote: > > > This reduces the amount of #ifdef ANDROID we'll have to have inside > > > the driver. Potentially offering better

Re: [Mesa-dev] [Mesa-stable] [PATCH 0/5] add support for EXT_shader_implicit_conversions

2018-11-06 Thread Juan A. Suarez Romero
On Tue, 2018-11-06 at 10:32 +, Emil Velikov wrote: > On Fri, 2 Nov 2018 at 16:06, Erik Faye-Lund > wrote: > > On Fri, 2018-11-02 at 15:40 +, Emil Velikov wrote: > > > On Tue, 30 Oct 2018 at 17:11, Erik Faye-Lund > > > wrote: > > > > EXT_shader_implicit_conversions is a useful extension

Re: [Mesa-dev] intel: WIP: Support for using 16-bits for mediump

2018-11-06 Thread Pohjolainen, Topi
On Tue, Nov 06, 2018 at 11:31:58AM +0100, Connor Abbott wrote: > On Tue, Nov 6, 2018 at 11:14 AM Pohjolainen, Topi > wrote: > > > > On Tue, Nov 06, 2018 at 10:45:52AM +0100, Connor Abbott wrote: > > > As far as I understand, mediump handling can be split into two parts: > > > > > > 1. Figuring

Re: [Mesa-dev] [PATCH 08/15] anv/android: support import/export of AHardwareBuffer objects

2018-11-06 Thread Tapani Pälli
On 11/6/18 12:31 PM, Lionel Landwerlin wrote: On 30/10/2018 05:26, Tapani Pälli wrote: v2: add support for non-image buffers (AHARDWAREBUFFER_FORMAT_BLOB) v3: properly handle usage bits when creating from image v4: refactor, code cleanup (Jason) Signed-off-by: Tapani Pälli ---  

Re: [Mesa-dev] [PATCH 08/15] anv/android: support import/export of AHardwareBuffer objects

2018-11-06 Thread Tapani Pälli
On 11/6/18 12:07 PM, Lionel Landwerlin wrote: On 30/10/2018 05:26, Tapani Pälli wrote: v2: add support for non-image buffers (AHARDWAREBUFFER_FORMAT_BLOB) v3: properly handle usage bits when creating from image v4: refactor, code cleanup (Jason) Signed-off-by: Tapani Pälli ---  

Re: [Mesa-dev] [PATCH 1/2] anv: stub internal android code

2018-11-06 Thread Lionel Landwerlin
On 06/11/2018 12:20, Eric Engestrom wrote: On Tuesday, 2018-11-06 11:37:50 +, Lionel Landwerlin wrote: This reduces the amount of #ifdef ANDROID we'll have to have inside the driver. Potentially offering better coverage of the android extensions. Signed-off-by: Lionel Landwerlin ---

Re: [Mesa-dev] [PATCH v2 04/13] intel/genxml: Add engine definition to render engine instructions (gen4)

2018-11-06 Thread Lionel Landwerlin
On 31/10/2018 13:12, Toni Lönnberg wrote: Instructions meant for the render engine now have a definition specifying that so that can differentiate instructions meant for different engines due to shared opcodes. v2: Divided into individual patches for each gen --- Just responding to this one,

Re: [Mesa-dev] [Mesa-stable] [PATCH] virgl/vtest-winsys: Use virgl version of bind flags

2018-11-06 Thread Juan A. Suarez Romero
On Fri, 2018-11-02 at 15:23 +, Emil Velikov wrote: > On Thu, 1 Nov 2018 at 09:50, Gert Wollny wrote: > > From: Gert Wollny > > > > The bind flags defined by mesa/gallium might not always be in sync > > with the ones copied to virglrenderer/gallium. Therefore, use the > > flags defined in

Re: [Mesa-dev] [PATCH 1/2] anv: stub internal android code

2018-11-06 Thread Eric Engestrom
On Tuesday, 2018-11-06 11:37:50 +, Lionel Landwerlin wrote: > This reduces the amount of #ifdef ANDROID we'll have to have inside > the driver. Potentially offering better coverage of the android > extensions. > > Signed-off-by: Lionel Landwerlin > --- > src/intel/Makefile.sources

Re: [Mesa-dev] [PATCH v3] intel/decoder: tools: gen_engine to drm_i915_gem_engine_class

2018-11-06 Thread Lionel Landwerlin
Looks good, thanks! Reviewed-by: Lionel Landwerlin On 31/10/2018 13:57, Toni Lönnberg wrote: Removed the gen_engine enum and changed the involved functions to use the drm_i915_gem_engine_class enum from UAPI instead. v3: Wrong engine was being used for blocks in video ring ---

Re: [Mesa-dev] [PATCH 1/2] anv: stub internal android code

2018-11-06 Thread Tapani Pälli
Hi; This is very nice as when we get more Android functions it will reduce ifdeffing. This did not quite work though, but I found a cure! See below ... On 11/6/18 1:37 PM, Lionel Landwerlin wrote: This reduces the amount of #ifdef ANDROID we'll have to have inside the driver. Potentially

Re: [Mesa-dev] [PATCH v2 03/13] intel/decoder: tools: Use engine for decoding batch instructions

2018-11-06 Thread Lionel Landwerlin
On 31/10/2018 13:12, Toni Lönnberg wrote: The engine to which the batch was sent to is now set to the decoder context when decoding the batch. This is needed so that we can distinguish between instructions as the render and video pipe share some of the instruction opcodes. v2: The engine is now

Re: [Mesa-dev] [PATCH 08/12] configure.ac: deprecate --with-llvm-prefix

2018-11-06 Thread Emil Velikov
On Thu, 1 Nov 2018 at 16:13, Michel Dänzer wrote: > > On 2018-11-01 5:03 p.m., Jan Vesely wrote: > > On Wed, 2018-10-31 at 18:40 +, Emil Velikov wrote: > >> On Wed, 31 Oct 2018 at 17:41, Jan Vesely wrote: > >>> On Wed, 2018-10-31 at 17:22 +, Emil Velikov wrote: > On Wed, 31 Oct 2018

Re: [Mesa-dev] [PATCH v2 02/13] intel/decoder: Engine parameter for instructions

2018-11-06 Thread Lionel Landwerlin
On 31/10/2018 13:12, Toni Lönnberg wrote: Preliminary work for adding handling of different pipes to gen_decoder. Each instruction needs to have a definition describing which engine it is meant for. If left undefined, by default, the instruction is defined for all engines. v2: Changed to use

Re: [Mesa-dev] [PATCH v2 08/32] intel/isl: Add gen10 variants of Yf and Ys tiling

2018-11-06 Thread Pohjolainen, Topi
On Fri, Oct 12, 2018 at 01:46:38PM -0500, Jason Ekstrand wrote: > --- > src/intel/isl/isl.c | 9 +++-- > src/intel/isl/isl.h | 12 ++-- > src/intel/isl/isl_drm.c | 2 ++ > src/intel/isl/isl_gen7.c | 8 +++- >

Re: [Mesa-dev] [PATCH] egl: return correct error code for a case req ver < 3 with forward-compatible

2018-11-06 Thread andrey simiklit
Hello, Any updates here? I think that I missed tag: Reported-by: Ian Romanick Here: https://bugzilla.freedesktop.org/show_bug.cgi?id=92552#c9 The patch for the test which will check it: https://patchwork.freedesktop.org/patch/256432/ Thanks, Andrii. On Thu, Oct 11, 2018 at 2:12 PM wrote: >

Re: [Mesa-dev] [PATCH v2] egl: doesn't allow egl to create a forward-compatible context with req ver < 3

2018-11-06 Thread andrey simiklit
Hello, Any updates here? :-) This test is needed to check issue which should be fixed by the following mesa patch: https://patchwork.freedesktop.org/patch/256063/ This issue mentioned in this bug by Ian Romanick : https://bugzilla.freedesktop.org/show_bug.cgi?id=92552#c9 Regards, Andrii. On

Re: [Mesa-dev] intel: WIP: Support for using 16-bits for mediump

2018-11-06 Thread Connor Abbott
On Tue, Nov 6, 2018 at 11:31 AM Connor Abbott wrote: > > On Tue, Nov 6, 2018 at 11:14 AM Pohjolainen, Topi > wrote: > > > > On Tue, Nov 06, 2018 at 10:45:52AM +0100, Connor Abbott wrote: > > > As far as I understand, mediump handling can be split into two parts: > > > > > > 1. Figuring out which

[Mesa-dev] [PATCH 1/2] anv: stub internal android code

2018-11-06 Thread Lionel Landwerlin
This reduces the amount of #ifdef ANDROID we'll have to have inside the driver. Potentially offering better coverage of the android extensions. Signed-off-by: Lionel Landwerlin --- src/intel/Makefile.sources | 4 +++ src/intel/Makefile.vulkan.am | 3 ++-

[Mesa-dev] [PATCH 2/2] anv/android: mark gralloc allocated BOs as external

2018-11-06 Thread Lionel Landwerlin
Allocating through Gralloc implies buffers are going to be used outside the driver. We have special MOCS settings for external BOs and we probably want to use them here too. Signed-off-by: Lionel Landwerlin Fixes: a1220e73116bad7 ("anv/android: Set the BO flags in bo_cache_import (v2)") ---

Re: [Mesa-dev] [PATCH v3 4/4] r600: Add support for EXT_texture_sRGB_R8

2018-11-06 Thread Gert Wollny
Hi Dave & Roland, Can I persuade you to take a look at this one-liner? Many thanks, Gert Am Donnerstag, den 01.11.2018, 12:59 +0100 schrieb Gert Wollny: > From: Gert Wollny > > Enables on R600 and makes pass: > dEQP-GLES31.functional.srgb_texture_decode.skip_decode.sr8.* >

  1   2   >