[Mesa-dev] [PATCH 2/3] mesa/glthread: enable immediate mode

From: Marek Olšák --- src/mapi/glapi/gen/gl_API.xml | 2 +- src/mesa/vbo/vbo_exec_api.c | 14 ++ 2 files changed, 11 insertions(+), 5 deletions(-) diff --git a/src/mapi/glapi/gen/gl_API.xml b/src/mapi/glapi/gen/gl_API.xml index aae9a5835db..929e5f6b024 100644 ---

[Mesa-dev] [PATCH 3/3] drirc: enable glthread for Talos Principle

From: Marek Olšák Immediate mode was needed. --- src/util/00-mesa-defaults.conf | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/util/00-mesa-defaults.conf b/src/util/00-mesa-defaults.conf index a148c87a882..99eb2eb42bc 100644 --- a/src/util/00-mesa-defaults.conf +++

[Mesa-dev] [PATCH 1/3] mesa/glthread: pass the function name to _mesa_glthread_restore_dispatch

From: Marek Olšák If you insert printf there, you'll know why glthread was disabled. --- src/mapi/glapi/gen/gl_marshal.py | 2 +- src/mesa/main/glthread.c | 4 ++-- src/mesa/main/glthread.h | 2 +- src/mesa/main/marshal.c | 2 +- 4 files changed, 5 insertions(+), 5

Re: [Mesa-dev] [PATCH 1/3 v2] glsl: prevent qualifiers modification of predeclared variables

Nice! Series is: Reviewed-by: Timothy Arceri On 10/10/18 9:07 am, Ian Romanick wrote: From: Ian Romanick Section 3.7 (Identifiers) of the GLSL spec says: However, as noted in the specification, there are some cases where previously declared variables can be redeclared to change

[Mesa-dev] [PATCH 2/5] nir: Inline lower_clip_vs() into nir_lower_clip_vs().

It's now called exactly once, and there's not really any distinction. --- src/compiler/nir/nir_lower_clip.c | 76 ++- 1 file changed, 34 insertions(+), 42 deletions(-) diff --git a/src/compiler/nir/nir_lower_clip.c b/src/compiler/nir/nir_lower_clip.c index

[Mesa-dev] [PATCH 5/5] i965: Allow only one slot of clip distances to be set on Gen4-5.

The existing backend code assumed that if VARYING_SLOT_CLIP_DIST0 was written, then VARYING_SLOT_CLIP_DIST1 would be as well. That's true with the current lowering, but not necessary if there are 4 or fewer clip distances. Separate out the checks to allow this. The new NIR-based lowering will

[Mesa-dev] [PATCH 3/5] nir: Save nir_variable pointers in nir_lower_clip_vs rather than locs.

I'll want the variables in the next patch. --- src/compiler/nir/nir_lower_clip.c | 24 1 file changed, 8 insertions(+), 16 deletions(-) diff --git a/src/compiler/nir/nir_lower_clip.c b/src/compiler/nir/nir_lower_clip.c index ced6d31c117..2299f746305 100644 ---

[Mesa-dev] [PATCH 4/5] nir: Make nir_lower_clip_vs optionally work with variables.

The way nir_lower_clip_vs() works with store_output intrinsics makes a ton of assumptions about the driver_location field. In i965, I'd rather do this lowering early and work with variables. ir3 and vc4 could probably do that as well, but I'm not sure exactly what paths would need updating, so

[Mesa-dev] [PATCH 1/5] nir: Use nir_shader_get_entrypoint in nir_lower_clip_vs().

--- src/compiler/nir/nir_lower_clip.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/compiler/nir/nir_lower_clip.c b/src/compiler/nir/nir_lower_clip.c index 7081295a500..013645101f2 100644 --- a/src/compiler/nir/nir_lower_clip.c +++

Re: [Mesa-dev] [PATCH 22/28] util: promote u_memory to src/util

On Fri, Nov 9, 2018 at 7:28 PM Dylan Baker wrote: > > Quoting Rob Clark (2018-11-09 14:27:35) > > On Fri, Nov 9, 2018 at 1:41 PM Dylan Baker wrote: > > > > > > as well as os_memory* > > > > Thanks, I think this will be useful for me to extract freedreno/ir3 > > out to src/compiler :-) > >

Re: [Mesa-dev] [PATCH] st/mesa: make use of nir_link_constant_varyings()

Timothy Arceri writes: > Shader-db results radeonsi (VEGA): > > Totals from affected shaders: > SGPRS: 161464 -> 161368 (-0.06 %) > VGPRS: 86904 -> 86292 (-0.70 %) > Spilled SGPRs: 296 -> 314 (6.08 %) > Spilled VGPRs: 0 -> 0 (0.00 %) > Private memory VGPRs: 0 -> 0 (0.00 %) > Scratch size: 0 -> 0

Re: [Mesa-dev] [PATCH 22/28] util: promote u_memory to src/util

Quoting Rob Clark (2018-11-09 14:27:35) > On Fri, Nov 9, 2018 at 1:41 PM Dylan Baker wrote: > > > > as well as os_memory* > > Thanks, I think this will be useful for me to extract freedreno/ir3 > out to src/compiler :-) Shouldn't that be src/qualcomm? :) > > Reviewed-by: Rob Clark Thanks!

Re: [Mesa-dev] [PATCH 04/28] r200: use preprocessor for big vs little endian checks

Quoting Dylan Baker (2018-11-09 15:52:05) > Quoting Timothy Arceri (2018-11-09 13:45:27) > > On 10/11/18 5:39 am, Dylan Baker wrote: > > > Instead of using a function at runtime we can just build the right code > > > for the right platform. > > > --- > > > src/mesa/drivers/dri/r200/r200_blit.c

Re: [Mesa-dev] [PATCH 04/28] r200: use preprocessor for big vs little endian checks

Quoting Timothy Arceri (2018-11-09 13:45:27) > On 10/11/18 5:39 am, Dylan Baker wrote: > > Instead of using a function at runtime we can just build the right code > > for the right platform. > > --- > > src/mesa/drivers/dri/r200/r200_blit.c | 76 ++- > >

Re: [Mesa-dev] [PATCH] meson: fix libatomic tests

Quoting Matt Turner (2018-11-09 15:26:50) > The underscore change alone is enough to fix the build on 32-bit ppc > and sparc. It's unclear to me if the dep_atomic even changes anything. > Without it I still see -latomic in the command to build > src/util/u_atomic_test. I would just drop that part.

Re: [Mesa-dev] [PATCH] meson: fix libatomic tests

The underscore change alone is enough to fix the build on 32-bit ppc and sparc. It's unclear to me if the dep_atomic even changes anything. Without it I still see -latomic in the command to build src/util/u_atomic_test. I would just drop that part. Reviewed-and-Tested-by: Matt Turner Thanks!

[Mesa-dev] [Bug 108640] [Regression] Starcraft II broken graphics

https://bugs.freedesktop.org/show_bug.cgi?id=108640 Travis changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

Re: [Mesa-dev] [PATCH 22/28] util: promote u_memory to src/util

On Fri, Nov 9, 2018 at 1:41 PM Dylan Baker wrote: > > as well as os_memory* Thanks, I think this will be useful for me to extract freedreno/ir3 out to src/compiler :-) Reviewed-by: Rob Clark > --- > src/gallium/auxiliary/Makefile.sources | 5 - >

[Mesa-dev] [PATCH] st/mesa: make use of nir_link_constant_varyings()

Shader-db results radeonsi (VEGA): Totals from affected shaders: SGPRS: 161464 -> 161368 (-0.06 %) VGPRS: 86904 -> 86292 (-0.70 %) Spilled SGPRs: 296 -> 314 (6.08 %) Spilled VGPRs: 0 -> 0 (0.00 %) Private memory VGPRs: 0 -> 0 (0.00 %) Scratch size: 0 -> 0 (0.00 %) dwords per thread Code Size:

Re: [Mesa-dev] [PATCH] mesa: mark GL_SR8_EXT non-renderable on GLES

Reviewed-by: Ilia Mirkin On Fri, Nov 9, 2018 at 4:48 PM Marek Olšák wrote: > > From: Marek Olšák > > Fixes: > dEQP-GLES3.functional.fbo.completeness.renderable.texture.color0.sr8_ext > --- > src/mesa/main/fbobject.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git

[Mesa-dev] [PATCH] mesa: mark GL_SR8_EXT non-renderable on GLES

From: Marek Olšák Fixes: dEQP-GLES3.functional.fbo.completeness.renderable.texture.color0.sr8_ext --- src/mesa/main/fbobject.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c index c3dded6b928..68e0daf3423 100644 ---

Re: [Mesa-dev] [PATCH 04/28] r200: use preprocessor for big vs little endian checks

On 10/11/18 5:39 am, Dylan Baker wrote: Instead of using a function at runtime we can just build the right code for the right platform. --- src/mesa/drivers/dri/r200/r200_blit.c | 76 ++- src/mesa/drivers/dri/r200/r200_texstate.c | 7 ++- 2 files changed, 38

[Mesa-dev] [PATCH] meson: Don't set -Wall

meson does this for you with it's warn levels, so we don't need to set it ourselves. Fixes: d1992255bb29054fa51763376d125183a9f602f3 ("meson: Add build Intel "anv" vulkan driver") --- meson.build | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/meson.build

[Mesa-dev] [PATCH] meson: fix libatomic tests

There are two problems: 1) the extra underscore in MISSING_64BIT_ATOMICS 2) we should ink with libatomic if the previous test decided we needed it CC: Matt Turner Fixes: d1992255bb29054fa51763376d125183a9f602f3 ("meson: Add build Intel "anv" vulkan driver") --- meson.build | 3 ++- 1

Re: [Mesa-dev] [PATCH 1/3 v2] glsl: prevent qualifiers modification of predeclared variables

bump On 10/09/2018 03:07 PM, Ian Romanick wrote: > From: Ian Romanick > > Section 3.7 (Identifiers) of the GLSL spec says: > > However, as noted in the specification, there are some cases where > previously declared variables can be redeclared to change or add > some property, and

[Mesa-dev] [PATCH 28/28] remove final imports.h bits

This moves the fi_types to a new mesa_private.h and removes the imports.c file. The vast majority of this patch is just removing pound includes of imports.h and fixing up the recursive includes. --- src/Makefile.am | 1 - src/compiler/glsl/glsl_to_nir.cpp

[Mesa-dev] [PATCH 24/28] replace malloc macros in imports.h with u_memory.h versions

--- src/amd/vulkan/winsys/amdgpu/radv_amdgpu_bo.c | 1 + src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c | 2 ++ src/gallium/state_trackers/dri/dri_context.c| 2 ++ src/gallium/state_trackers/glx/xlib/glx_api.c | 1 + src/gallium/state_trackers/glx/xlib/xm_api.c

[Mesa-dev] [PATCH 01/28] replace _mesa_is_pow_two with util_is_power_of_two_*

mostly this uses util_is_power_of_two_or_zero, which has the same behavior as _mesa_is_pow_two when the input is zero. In cases where the value is known to be != 0 ahead of time I used the _nonzero variant as it may be faster on some platforms. --- src/intel/compiler/brw_reg.h |

[Mesa-dev] [PATCH 22/28] util: promote u_memory to src/util

as well as os_memory* --- src/gallium/auxiliary/Makefile.sources | 5 - src/gallium/auxiliary/meson.build | 5 - src/gallium/auxiliary/util/u_debug_memory.c| 4 ++-- src/gallium/auxiliary/util/u_format.c | 2 +-

[Mesa-dev] [PATCH 15/28] replace _mesa_snprintf with util_snprintf

--- src/mapi/glapi/gen/gl_enums.py | 4 ++-- src/mesa/drivers/common/meta.c | 6 +++--- src/mesa/main/debug.c | 8 src/mesa/main/dlist.c | 5 +++-- src/mesa/main/errors.c | 7 +++ src/mesa/main/imports.c | 14

[Mesa-dev] [PATCH 21/28] Replace IS_INF_OR_NAN with util_is_inf_or_nan

--- src/mesa/main/draw.c| 4 ++-- src/mesa/main/imports.h | 23 --- src/mesa/program/prog_execute.c | 28 ++-- src/mesa/swrast/s_aalinetemp.h | 2 +- src/mesa/swrast/s_aatritemp.h | 2 +- src/mesa/swrast/s_linetemp.h| 2 +-

[Mesa-dev] [PATCH 20/28] move windows strtok_r define to u_string

This makes more sense for it, it's only used in the glsl compiler currently, so we could probably move it there, but this seems fine for a header only #define. --- src/mesa/main/imports.h | 4 src/util/u_string.h | 4 2 files changed, 4 insertions(+), 4 deletions(-) diff --git

[Mesa-dev] [PATCH 26/28] replace imports memory functions with utils memory functions

--- src/compiler/SConscript.glsl | 2 - src/mesa/Android.libmesa_glsl_utils.mk| 2 - .../drivers/dri/i915/intel_buffer_objects.c | 19 ++- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 9 +- src/mesa/main/bufferobj.c | 7 +-

[Mesa-dev] [PATCH 06/28] dri/osmesa: use preprocessor for selecting endian code paths

--- src/mesa/drivers/osmesa/osmesa.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/src/mesa/drivers/osmesa/osmesa.c b/src/mesa/drivers/osmesa/osmesa.c index 44374a2e917..9f25f4f9a47 100644 --- a/src/mesa/drivers/osmesa/osmesa.c +++

[Mesa-dev] [PATCH 17/28] mesa/main: remove unused IROUNDD

--- src/mesa/main/imports.h | 8 1 file changed, 8 deletions(-) diff --git a/src/mesa/main/imports.h b/src/mesa/main/imports.h index fbb7e59ca06..165a9ce05e1 100644 --- a/src/mesa/main/imports.h +++ b/src/mesa/main/imports.h @@ -119,14 +119,6 @@ static inline int IROUND(float f)

[Mesa-dev] [PATCH 11/28] replace LOG2 with util_fast_log2

The implementation is somewhat different, although if you go back in time far enough they're the same, but the one in u_math was changed a long time back to be faster. --- src/mesa/main/imports.h | 29 - src/mesa/swrast/s_span.c | 4 ++--

[Mesa-dev] [PATCH 09/28] mesa/swrast: replace instances of _mesa_little_endian with preprocessor

--- src/mesa/swrast/s_renderbuffer.c | 9 - src/mesa/swrast/s_triangle.c | 2 +- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/src/mesa/swrast/s_renderbuffer.c b/src/mesa/swrast/s_renderbuffer.c index 8c97e4e11b4..ab4932728a9 100644 ---

[Mesa-dev] [PATCH 12/28] u_math: add x86 optimized version of ifloor

This is copied from the one in src/mesa/main/imports.h, which is the same otherwise. --- src/util/u_math.h | 18 ++ 1 file changed, 18 insertions(+) diff --git a/src/util/u_math.h b/src/util/u_math.h index e7dbbe5ca22..fcd3054060b 100644 --- a/src/util/u_math.h +++

[Mesa-dev] [PATCH 25/28] util: Add an aligned realloc function

Mesa has one of these in imports.h, so u_memory needs one as well. This is the version from mesa ported. --- src/util/os_memory.h | 3 +++ src/util/os_memory_aligned.h | 35 +++ src/util/os_memory_stdc.h| 18 ++ src/util/u_memory.h

[Mesa-dev] [PATCH 27/28] mesa: move ADD_POINTERS to macros.h

I'm not really sure where else to put it. Since imports.h only has two things left in it (neither of which are abstractions for smoothing away libc differences) I'd like to get them out of there. macros.h is the only place I can think of to put this macro. --- src/mesa/main/imports.h| 9

[Mesa-dev] [PATCH 14/28] replace _mesa_vsnprtinf with util_vsnprtinf

--- src/mesa/main/errors.c | 13 +++-- src/mesa/main/imports.c | 8 src/mesa/main/imports.h | 3 --- 3 files changed, 7 insertions(+), 17 deletions(-) diff --git a/src/mesa/main/errors.c b/src/mesa/main/errors.c index a9687913627..18dff1ce3cc 100644 ---

[Mesa-dev] [PATCH 18/28] use util_strcasecmp in places that may be compiled on msvc

This is the same as the one defined in imports.h, but from utils. XXX: needs to be compiled with msvc --- src/compiler/glsl/glsl_parser.yy | 3 ++- src/mesa/main/imports.h | 4 src/util/debug.c | 9 + 3 files changed, 7 insertions(+), 9 deletions(-) diff

[Mesa-dev] [PATCH 04/28] r200: use preprocessor for big vs little endian checks

Instead of using a function at runtime we can just build the right code for the right platform. --- src/mesa/drivers/dri/r200/r200_blit.c | 76 ++- src/mesa/drivers/dri/r200/r200_texstate.c | 7 ++- 2 files changed, 38 insertions(+), 45 deletions(-) diff --git

[Mesa-dev] [PATCH 07/28] util/u_endian: set PIPE_ARCH_*_ENDIAN to 1

This will allow it to be used as a drop in replacement for _mesa_little_endian in a number of cases. --- src/util/u_endian.h | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/src/util/u_endian.h b/src/util/u_endian.h index e11b381588d..2f424a96600 100644 ---

[Mesa-dev] [PATCH 23/28] amd/vulkan: Remove FREE alias for free

Even within this directory free and FREE are used interchangeably, and u_memory has a FREE macro already --- src/amd/vulkan/radv_radeon_winsys.h | 2 -- src/amd/vulkan/winsys/amdgpu/radv_amdgpu_bo.c | 8 src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c | 6 +++---

[Mesa-dev] [PATCH 02/28] replace _mesa_next_pow_two_* with util_next_power_of_two_*

The 64 bit variant in imports.h isn't even used. --- .../drivers/dri/radeon/radeon_mipmap_tree.c | 2 +- src/mesa/main/imports.h | 52 --- 2 files changed, 1 insertion(+), 53 deletions(-) diff --git a/src/mesa/drivers/dri/radeon/radeon_mipmap_tree.c

[Mesa-dev] [PATCH 03/28] replace _mesa_logbase2 with util_logbase2

--- src/intel/compiler/brw_eu_emit.c | 4 ++-- src/intel/compiler/brw_fs.cpp| 2 +- src/intel/compiler/brw_fs_generator.cpp | 2 +- src/intel/compiler/brw_fs_reg_allocate.cpp | 4 ++-- src/intel/compiler/brw_ir_fs.h | 4 ++--

[Mesa-dev] [PATCH 05/28] r100: Use preprocessor to select big vs little endian paths

--- src/mesa/drivers/dri/radeon/radeon_blit.c| 49 src/mesa/drivers/dri/radeon/radeon_screen.c | 21 +++-- src/mesa/drivers/dri/radeon/radeon_texture.c | 31 ++--- 3 files changed, 53 insertions(+), 48 deletions(-) diff --git

[Mesa-dev] [PATCH 08/28] mesa/main: replace uses of _mesa_little_endian with preprocessor

--- src/mesa/main/format_utils.c | 24 --- src/mesa/main/formats.c | 68 src/mesa/main/texcompress_bptc.c | 7 +++- src/mesa/main/texcompress_fxt1.c | 7 +++- src/mesa/main/texcompress_rgtc.c | 14 +-- src/mesa/main/texcompress_s3tc.c |

[Mesa-dev] [PATCH 13/28] replace IFLOOR with util_ifloor

which are exactly the same function with exactly the same implementation --- src/mesa/main/drawpix.c | 5 ++- src/mesa/main/imports.h | 31 - src/mesa/program/prog_execute.c | 2 +- src/mesa/state_tracker/st_cb_bitmap.c | 4 +-

[Mesa-dev] [PATCH 10/28] mesa/main: delete now unused _mesa_little_endian

--- src/mesa/main/imports.h | 12 1 file changed, 12 deletions(-) diff --git a/src/mesa/main/imports.h b/src/mesa/main/imports.h index 863ac56f535..7e067dd23e3 100644 --- a/src/mesa/main/imports.h +++ b/src/mesa/main/imports.h @@ -206,18 +206,6 @@ static inline int IFLOOR(float f)

[Mesa-dev] [PATCH 16/28] Replace IROUND_POS with _mesa_roundevenf

Which has the same behavior. --- src/mesa/drivers/x11/xm_api.c | 2 +- src/mesa/main/imports.h| 10 -- src/mesa/swrast/s_aaline.c | 3 +-- src/mesa/swrast/s_aatriangle.c | 3 +-- 4 files changed, 3 insertions(+), 15 deletions(-) diff --git a/src/mesa/drivers/x11/xm_api.c

[Mesa-dev] [PATCH 00/28] Make use of utils functions more

Mesa has a lot of internal code duplication, sometimes it's exactly the same code in two different places, sometimes it's code where one copy has a fast path and the other doesn't. After I imported u_math into src/utils I realized just how much of this duplication there was, and started looking

[Mesa-dev] [PATCH 19/28] replace IROUND with util functions

This adds two new util functions to rounding.h, _mesa_iroundf and mesa_lround, which are just wrappers around roundf and round, that cast to int and long int respectively. This is possible since mesa recently dropped support for VC2013, since 2015 and 2017 support roundf. ---

[Mesa-dev] [PATCH 1/2] egl: introduce a log level getter function

Being able to retrieve the log level can be useful to enable/disable debug code. The alternative, which is calling 'getenv' function every time to retrieve the log level, is more "expensive". Signed-off-by: Silvestrs Timofejevs --- src/egl/main/egllog.c | 9 + src/egl/main/egllog.h | 4

[Mesa-dev] [PATCH 0/2] debug feature to dump "get configs" and "chosen configs"

This patch series provides an easy way to see what configs have been returned by the 'eglGetConfigs' and 'eglChooseConfig' functions, and give an overview of config attributes. Silvestrs Timofejevs (2): egl: introduce a log level getter function egl: add config debug printout

[Mesa-dev] [PATCH 2/2] egl: add config debug printout

Feature to print out EGL returned configs for debug purposes. 'eglChooseConfig' and 'eglGetConfigs' debug information printout is enabled when the log level equals '_EGL_DEBUG'. The configs are printed, and if any of them are "chosen" they are marked with their index in the chosen configs array.

Re: [Mesa-dev] [PATCH] intel/fs: Prevent emission of IR instructions not aligned to their own execution size.

Tested-by: Sagar Ghuge On 11/8/18 5:26 PM, Francisco Jerez wrote: > This can occur during payload setup of SIMD-split send message > instructions, which can lead to the emission of header setup > instructions with a non-zero channel group and fixed SIMD width. Such > instructions could end up

[Mesa-dev] [PATCH 3/3] specs: Bump GLX_MESA_query_renderer to version 9

Note that we have an official GL extension number, pick the appropriate section of the GLX spec to modify, and add changelog. Signed-off-by: Adam Jackson --- docs/specs/MESA_query_renderer.spec | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git

[Mesa-dev] [PATCH 1/3] specs: Remove GLES profile interaction text from GLX_MESA_query_renderer

In one place we say, if GLES isn't supported then the profile version will be 0.0. Then later we say, if the GLES profile extension isn't supported then GLX_RENDERER_OPENGL_ES_PROFILE_VERSION_MESA is not mentioned in the spec. A strict reading of the latter would mean that

[Mesa-dev] [PATCH 0/3] Update GLX_MESA_query_renderer spec

No functional change, just making the text match the implementation. Will sync this to the Khronos registry once merged. - ajax ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 2/3] specs: Remove GLX_RENDERER_ID_MESA from GLX_MESA_query_renderer

This has not even had an attempt at implementation. If you asked for renderer 0 - which, the spec implies, should always work - then dri2_convert_glx_attribs would fail, we'd silently fall back to creating an indirect context, and xserver would also not recognize the attribute and would throw

Re: [Mesa-dev] [PATCH 2/4] compiler: avoid 'unused variable' and 'may be used uninitialized' warnings

On Friday, 2018-11-09 16:15:12 +0200, andrey simiklit wrote: > Hello, > > Thanks for review. > Please find my comments below: > > On Fri, Nov 9, 2018 at 2:52 PM Eric Engestrom > wrote: > > > On Tuesday, 2018-09-11 15:42:05 +0300, asimiklit.w...@gmail.com wrote: > > > From: Andrii Simiklit > >

Re: [Mesa-dev] [PATCH 3/5] intel/aubinator: fix ring buffer pointer

Reviewed-by: Toni Lönnberg On Fri, Nov 09, 2018 at 04:49:11PM +, Lionel Landwerlin wrote: > We can only start parsing commands from the head pointer. This was > working fine up to now because we only dealt with a "made up" ring > buffer (generated by aub_write) which always had its head at

Re: [Mesa-dev] [PATCH 1/5] intel/aub_read: remove useless breaks

On Friday, 2018-11-09 16:49:09 +, Lionel Landwerlin wrote: > Signed-off-by: Lionel Landwerlin `return` in indeed the one we need to keep here. Reviewed-by: Eric Engestrom > --- > src/intel/tools/aub_read.c | 6 -- > 1 file changed, 6 deletions(-) > > diff --git

Re: [Mesa-dev] [PATCH 00/15] nir: Rework boolean (and maybe all?) conversions

In case anyone is wondering my opinion based on my experience writing both patch series, I think it's decidedly in the version B camp. The code changes required to nir_algebraic and nir_search are almost identical between the two besides the whole virtual opcode thing and the changes to front-end

[Mesa-dev] [PATCH 3/5] intel/aubinator: fix ring buffer pointer

We can only start parsing commands from the head pointer. This was working fine up to now because we only dealt with a "made up" ring buffer (generated by aub_write) which always had its head at 0. Signed-off-by: Lionel Landwerlin --- src/intel/tools/aubinator.c | 4 ++--

[Mesa-dev] [PATCH 1/5] intel/aub_read: remove useless breaks

Signed-off-by: Lionel Landwerlin --- src/intel/tools/aub_read.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/src/intel/tools/aub_read.c b/src/intel/tools/aub_read.c index d83e88ddced..cde6cb4ba03 100644 --- a/src/intel/tools/aub_read.c +++ b/src/intel/tools/aub_read.c @@ -219,27

[Mesa-dev] [PATCH 2/5] intel/decoders: read ring buffer length

Use this value to limit reading the ring buffer. Signed-off-by: Lionel Landwerlin --- src/intel/tools/aubinator.c | 4 +++- src/intel/tools/aubinator_viewer.cpp | 3 ++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/src/intel/tools/aubinator.c

[Mesa-dev] [PATCH 4/5] intel/aub_viewer: fix dynamic state printing

Identical fix to : commit cbd4bc1346f7397242e157bb66099b950a8c5643 Author: Jason Ekstrand Date: Fri Aug 24 16:04:03 2018 -0500 intel/batch_decoder: Fix dynamic state printing Signed-off-by: Lionel Landwerlin --- src/intel/tools/aubinator_viewer_decoder.cpp | 4 ++-- 1 file changed, 2

[Mesa-dev] [PATCH 5/5] intel/aub_viewer: Print blend states properly

Identical fix to : commit 70de31d0c106f58d6b7e6d5b79b8d90c1c112a3b Author: Jason Ekstrand Date: Fri Aug 24 16:05:08 2018 -0500 intel/batch_decoder: Print blend states properly Signed-off-by: Lionel Landwerlin --- src/intel/tools/aubinator_viewer_decoder.cpp | 18 -- 1

[Mesa-dev] [PATCH 0/5] intel/aubinators: fixes

Hi all, Here are a few cleanups/fixes I have in a pretty long branch. I figured this would be easier to review on its own. Thanks for your time, Lionel Landwerlin (5): intel/aub_read: remove useless breaks intel/decoders: read ring buffer length intel/aubinator: fix ring buffer pointer

Re: [Mesa-dev] [PATCH] mesa/main: fixup make check after NV_conditional_render for gles

On Fri, Nov 9, 2018 at 11:43 AM Erik Faye-Lund wrote: > > On Fri, 2018-11-09 at 11:17 -0500, Ilia Mirkin wrote: > > On Fri, Nov 9, 2018 at 10:51 AM Erik Faye-Lund > > wrote: > > > On Fri, 2018-11-09 at 10:44 -0500, Ilia Mirkin wrote: > > > > Errr ... why are these being added to the ABI now?

Re: [Mesa-dev] [PATCH] mesa/main: fixup make check after NV_conditional_render for gles

On Fri, 2018-11-09 at 11:17 -0500, Ilia Mirkin wrote: > On Fri, Nov 9, 2018 at 10:51 AM Erik Faye-Lund > wrote: > > On Fri, 2018-11-09 at 10:44 -0500, Ilia Mirkin wrote: > > > Errr ... why are these being added to the ABI now? Extensions are > > > generally not added in. Some are grandfathered

Re: [Mesa-dev] [PATCH] intel/fs: Prevent emission of IR instructions not aligned to their own execution size.

Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] mesa/main: fixup make check after NV_conditional_render for gles

On Fri, Nov 9, 2018 at 10:51 AM Erik Faye-Lund wrote: > > On Fri, 2018-11-09 at 10:44 -0500, Ilia Mirkin wrote: > > Errr ... why are these being added to the ABI now? Extensions are > > generally not added in. Some are grandfathered in, but this one would > > be new. > > > > Or is this due to the

Re: [Mesa-dev] [PATCH v2] nir: fix output offset compute for dvec3/4

Cool. 1-3 are Reviewed-by: Jason Ekstrand On Fri, Nov 9, 2018 at 7:09 AM Alejandro Piñeiro wrote: > The offset compute was working fine for the case of attrib_slots=1, > and updating the offset for the following varying. > > But in the case of attrib_slots=2 (so dvec3/4), we are basically >

Re: [Mesa-dev] [PATCH 6/7] RFC: nir/xfb_info: arrays of basic types adds just one varying

On November 9, 2018 06:39:25 Alejandro Piñeiro wrote: On 08/11/18 23:14, Jason Ekstrand wrote: On Thu, Nov 8, 2018 at 7:22 AM Alejandro Piñeiro wrote: On OpenGL, a array of a simple type adds just one varying. So gl_transform_feedback_varying_info struct defined at mtypes.h includes the

Re: [Mesa-dev] [PATCH] mesa/main: fixup make check after NV_conditional_render for gles

On Fri, 2018-11-09 at 10:44 -0500, Ilia Mirkin wrote: > Errr ... why are these being added to the ABI now? Extensions are > generally not added in. Some are grandfathered in, but this one would > be new. > > Or is this due to the fact that it's grandfathered in for GL, and > making that and GLES

Re: [Mesa-dev] [PATCH] mesa/main: fixup make check after NV_conditional_render for gles

Errr ... why are these being added to the ABI now? Extensions are generally not added in. Some are grandfathered in, but this one would be new. Or is this due to the fact that it's grandfathered in for GL, and making that and GLES different would be tricky? On Fri, Nov 9, 2018 at 10:20 AM Erik

Re: [Mesa-dev] [PATCH] mesa/main: fixup make check after NV_conditional_render for gles

On Friday, 2018-11-09 16:20:39 +0100, Erik Faye-Lund wrote: > It seems I missed some details when exposing NV_conditional_render > on GLES; this fixes up "make check". > > Fixes: 5213be9fab7 ("mesa: expose NV_conditional_render on GLES") > Signed-off-by: Erik Faye-Lund Thanks for the quick fix!

[Mesa-dev] [PATCH] mesa/main: fixup make check after NV_conditional_render for gles

It seems I missed some details when exposing NV_conditional_render on GLES; this fixes up "make check". Fixes: 5213be9fab7 ("mesa: expose NV_conditional_render on GLES") Signed-off-by: Erik Faye-Lund --- Caught by the Intel CI system. Sorry about this! src/mapi/es2api/ABI-check |

Re: [Mesa-dev] [PATCH 2/4] compiler: avoid 'unused variable' and 'may be used uninitialized' warnings

Hello, Thanks for review. Please find my comments below: On Fri, Nov 9, 2018 at 2:52 PM Eric Engestrom wrote: > On Tuesday, 2018-09-11 15:42:05 +0300, asimiklit.w...@gmail.com wrote: > > From: Andrii Simiklit > > > > 1. nir/nir_lower_vars_to_ssa.c:691:21: warning: > >unused variable

Re: [Mesa-dev] [PATCH] radv: include LLVM IR in the VK_AMD_shader_info "disassembly"

On 11/9/18 2:53 PM, Haehnle, Nicolai wrote: On 08.11.18 20:39, Samuel Pitoiset wrote: On 11/8/18 4:15 PM, Nicolai Hähnle wrote: From: Nicolai Hähnle Helpful for debugging compiler backend problems: this allows us to easily retrieve the LLVM IR from RenderDoc. -- For the peanut gallery:

Re: [Mesa-dev] [PATCH] radv: include LLVM IR in the VK_AMD_shader_info "disassembly"

On 08.11.18 20:39, Samuel Pitoiset wrote: > > > On 11/8/18 4:15 PM, Nicolai Hähnle wrote: >> From: Nicolai Hähnle >> >> Helpful for debugging compiler backend problems: this allows us to >> easily retrieve the LLVM IR from RenderDoc. >> -- >> For the peanut gallery: AMD's official stance on

Re: [Mesa-dev] [PATCH 4/4] main: avoid 'may be used uninitialized' warnings

On Tuesday, 2018-09-11 15:42:07 +0300, asimiklit.w...@gmail.com wrote: > From: Andrii Simiklit > > 1. main/texcompress_etc.c:1314:12: > warning: ‘*((void *)+2)’ may be used uninitialized in this function > 2. main/texcompress_etc.c:1354:12: > warning: ‘*((void *)+2)’ may be used

Re: [Mesa-dev] [PATCH 3/4] i965: avoid 'unused variable' and 'may be used uninitialized' warnings

On Tuesday, 2018-09-11 15:42:06 +0300, asimiklit.w...@gmail.com wrote: > From: Andrii Simiklit > > 1. brw_blorp.c:1502:4: warning: > ‘num_layers’ may be used uninitialized in this function > 2. brw_blorp.c:1502:4: warning: > ‘start_layer’ may be used uninitialized in this function > 3.

[Mesa-dev] [PATCH v2] nir: fix output offset compute for dvec3/4

The offset compute was working fine for the case of attrib_slots=1, and updating the offset for the following varying. But in the case of attrib_slots=2 (so dvec3/4), we are basically splitting the comp_slots needed in two outputs. In that case we can't add to the offset the full size of the

Re: [Mesa-dev] [PATCH 2/7] nir: don't assert when xfb_buffer/stride is present but not xfb_offset

On 08/11/18 22:42, Jason Ekstrand wrote: > On Thu, Nov 8, 2018 at 7:22 AM Alejandro Piñeiro > wrote: > > In order to allow nir_gather_xfb_info to be used on OpenGL, > specifically ARB_gl_spirv. > > So, from OpenGL 4.6 spec, section 11.1.2.1, "Output

Re: [Mesa-dev] [PATCH 2/4] compiler: avoid 'unused variable' and 'may be used uninitialized' warnings

On Tuesday, 2018-09-11 15:42:05 +0300, asimiklit.w...@gmail.com wrote: > From: Andrii Simiklit > > 1. nir/nir_lower_vars_to_ssa.c:691:21: warning: >unused variable ‘var’ >nir_variable *var = path->path[0]->var; > > 2. nir_types.cpp:558:31: warning: > ‘elem_align’ may be used

Re: [Mesa-dev] [PATCH 1/4] intel/tools: avoid 'ignoring return value' and 'unused variable' warnings

On Tuesday, 2018-09-11 15:42:04 +0300, asimiklit.w...@gmail.com wrote: > From: Andrii Simiklit > > 1. tools/i965_disasm.c:58:4: warning: > ignoring return value of ‘fread’, > declared with attribute warn_unused_result > fread(assembly, *end, 1, fp); > > 2. tools/aub_read.c:271:31:

Re: [Mesa-dev] [PATCH 6/7] RFC: nir/xfb_info: arrays of basic types adds just one varying

On 08/11/18 23:14, Jason Ekstrand wrote: > On Thu, Nov 8, 2018 at 7:22 AM Alejandro Piñeiro > wrote: > > On OpenGL, a array of a simple type adds just one varying. So > gl_transform_feedback_varying_info struct defined at mtypes.h includes > the parameters

Re: [Mesa-dev] [PATCH v2 0/4] i965: add support for sampling from AYUV images

On Friday, 2018-11-09 10:55:47 +, Lionel Landwerlin wrote: > Hi all, > > This v2 just splits the nir commit in 2 for readability and adds an > entry into the android backend. > > Many thanks to Tapani for the review. > > Cheers, > > Lionel Landwerlin (4): > nir/lower_tex: add alpha

Re: [Mesa-dev] [Mesa-stable] [PATCH] mapi: avoid text relocation in x86 tsd stubs

On Thu, Nov 08, 2018 at 03:54:20PM +, Emil Velikov wrote: > On Fri, 2 Nov 2018 at 00:02, Jonathan Gray wrote: > > > > On Thu, Nov 01, 2018 at 12:26:34PM -0700, Ian Romanick wrote: > > > On 10/31/2018 09:08 PM, Jonathan Gray wrote: > > > > Make similiar changes to libglvnd to avoid a text

Re: [Mesa-dev] [PATCH] freedreno/drm: Move drm_msm.h to include/drm-uapi

On Thursday, 2018-11-08 13:31:27 -0800, Chad Versace wrote: > So the future Vulkan driver can share it. :) :) :) > > I tested Meson, but not Autotools nor Android.mk. Not sure how useful this is then, but the meson side of this patch is: Reviewed-by: Eric Engestrom and the rest looks

[Mesa-dev] [ANNOUNCE] mesa 18.3.0-rc2

The second release candidate for Mesa 18.3.0 is now available. Dave Airlie (2): radv: apply xfb buffer offset at buffer binding time not later. (v2) radv: fix begin/end transform feedback with 0 counter buffers. Dylan Baker (1): meson: link gallium nine with pthreads Emil

Re: [Mesa-dev] [PATCH] i965: Fix -Wswitch on INTEL_COPY_STREAMING_LOAD

On Thursday, 2018-11-08 12:55:35 -0800, Chad Versace wrote: > The warning is emitted when building without INLINE_SSE41. I sent https://patchwork.freedesktop.org/patch/259015/ a couple of weeks ago, but your patch gives a more specific error message, so: Reviewed-by: Eric Engestrom > --- >

Re: [Mesa-dev] [PATCH 2/3] gbm: Introduce a helper function for printing GBM format names.

On Thursday, 2018-11-08 10:01:37 -0800, Eric Anholt wrote: > This requires that the caller make a little (stack) allocation to store > the string. > > v2: Use gbm_format_canonicalize (suggested by Daniel) Yep, fixes it. Series is Reviewed-by: Eric Engestrom > --- > src/gbm/main/gbm.c | 20

[Mesa-dev] [PATCH v2 3/4] dri: add AYUV format

v2: Add a AYUV entry android in the android backend (Tapani) Signed-off-by: Lionel Landwerlin Reviewed-by: Tapani Pälli --- include/GL/internal/dri_interface.h | 2 ++ src/egl/drivers/dri2/egl_dri2.c | 1 + src/egl/drivers/dri2/platform_android.c | 1 + 3 files changed, 4

[Mesa-dev] [PATCH v2 2/4] nir/lower_tex: Add AYUV lowering support

Byte ordering is : 0: V 1: U 2: Y 3: A v2: Split refactoring of alpha channel (Lionel) Signed-off-by: Lionel Landwerlin Reviewed-by: Tapani Pälli --- src/compiler/nir/nir.h | 1 + src/compiler/nir/nir_lower_tex.c | 19 +++ 2 files changed, 20 insertions(+) diff

  1   2   >