Re: [Mesa-dev] [PATCH] r600: Only set context streamout strides info from the shader that has outputs

2018-11-18 Thread Marek Olšák
This is ok. It can still break if multiple stages contain different streamout info, which might happen with separate shader objects. Marek On Mon, Nov 19, 2018, 1:56 AM Gert Wollny From: Gert Wollny > > With 5d517a streamout info is only attached to the shader for which the > transform

Re: [Mesa-dev] FOSDEM 2019: Graphics DevRoom: Call for speakers.

2018-11-18 Thread Luc Verhaegen
On Mon, Nov 19, 2018 at 08:17:32AM +0100, Luc Verhaegen wrote: > Hi, > > At FOSDEM on saturday the 3rd of february 2018, there will be another > graphics DevRoom. URL: https://fosdem.org/2018/ That should of course read: At FOSDEM on saturday the 2nd of february 2019, there will be another

[Mesa-dev] FOSDEM 2019: Graphics DevRoom: Call for speakers.

2018-11-18 Thread Luc Verhaegen
Hi, At FOSDEM on saturday the 3rd of february 2018, there will be another graphics DevRoom. URL: https://fosdem.org/2018/ The focus of this DevRoom is of course the same as the previous editions, namely: * Graphics drivers: from display to media to 3d drivers, both in kernel or userspace.

Re: [Mesa-dev] [PATCH] r600: Only set context streamout strides info from the shader that has outputs

2018-11-18 Thread Dave Airlie
On Mon, 19 Nov 2018 at 16:56, Gert Wollny wrote: > > From: Gert Wollny > > With 5d517a streamout info is only attached to the shader for which the > transform feedback is actually recorded, but the driver set the context info > with each state submitted, thereby always using the info data that

[Mesa-dev] [PATCH] r600: Only set context streamout strides info from the shader that has outputs

2018-11-18 Thread Gert Wollny
From: Gert Wollny With 5d517a streamout info is only attached to the shader for which the transform feedback is actually recorded, but the driver set the context info with each state submitted, thereby always using the info data that was attached to the vertex shader. Pass the streamout

[Mesa-dev] [PATCH 5/8] nir: rework force_unroll_array_access()

2018-11-18 Thread Timothy Arceri
Here we rework force_unroll_array_access() so that we can reused the induction variable detection in a following patch. --- src/compiler/nir/nir_loop_analyze.c | 49 - 1 file changed, 35 insertions(+), 14 deletions(-) diff --git a/src/compiler/nir/nir_loop_analyze.c

[Mesa-dev] [PATCH 8/8] nir: add partial loop unrolling support

2018-11-18 Thread Timothy Arceri
This adds partial loop unrolling support and makes use of a guessed trip count based on array access. The code is written so that we could use partial unrolling more generally, but for now it's only use when we have guessed the trip count. We use partial unrolling for this guessed trip count

[Mesa-dev] [PATCH 4/8] nir: factor out some of the complex loop unroll code to a helper

2018-11-18 Thread Timothy Arceri
--- src/compiler/nir/nir_opt_loop_unroll.c | 116 ++--- 1 file changed, 64 insertions(+), 52 deletions(-) diff --git a/src/compiler/nir/nir_opt_loop_unroll.c b/src/compiler/nir/nir_opt_loop_unroll.c index a25a89f094..d9272fedd8 100644 ---

[Mesa-dev] Partial loop unrolling support

2018-11-18 Thread Timothy Arceri
This series add support for partial loop unrolling for loops with an unknown trip count. The new partial_unroll function allows the caller to specifiy how may times the loop should be unrolled and then the loop is inserted in the innermost continue branch of the unrolled loop. For now we only do

[Mesa-dev] [PATCH 2/8] nir: add a new nir_cf_list_clone_and_reinsert() helper

2018-11-18 Thread Timothy Arceri
--- src/compiler/nir/nir_control_flow.h | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/compiler/nir/nir_control_flow.h b/src/compiler/nir/nir_control_flow.h index 2ea460e5df..9111b30a29 100644 --- a/src/compiler/nir/nir_control_flow.h +++

[Mesa-dev] [PATCH 3/8] nir: make use of new nir_cf_list_clone_and_reinsert() helper

2018-11-18 Thread Timothy Arceri
--- src/compiler/nir/nir_opt_loop_unroll.c | 74 ++ 1 file changed, 28 insertions(+), 46 deletions(-) diff --git a/src/compiler/nir/nir_opt_loop_unroll.c b/src/compiler/nir/nir_opt_loop_unroll.c index ea2012e292..a25a89f094 100644 ---

[Mesa-dev] [PATCH 6/8] nir: add guess trip count support to loop analysis

2018-11-18 Thread Timothy Arceri
This detects an induction variable used as an array index to guess the trip count of the loop. This enables us to do a partial unroll of the loop, with can eventually result in the loop being eliminated. --- src/compiler/nir/nir.h | 4 ++ src/compiler/nir/nir_loop_analyze.c | 78

[Mesa-dev] [PATCH 7/8] nir: add new partially_unrolled bool to nir_loop

2018-11-18 Thread Timothy Arceri
In order to stop continuously partially unrolling the same loop we add the bool partialy_unrolled to nir_loop, we add it here rather than in nir_loop_info because nir_loop_info is only set via loop analysis and is intended to be cleared before each analysis. Also nir_loop_info is never cloned. ---

[Mesa-dev] [PATCH 1/8] nir: small tidy ups for nir_loop_analyze()

2018-11-18 Thread Timothy Arceri
--- src/compiler/nir/nir_loop_analyze.c | 31 ++--- 1 file changed, 10 insertions(+), 21 deletions(-) diff --git a/src/compiler/nir/nir_loop_analyze.c b/src/compiler/nir/nir_loop_analyze.c index 9c3fd2f286..c779383b36 100644 --- a/src/compiler/nir/nir_loop_analyze.c +++

[Mesa-dev] [PATCH] virgl: fix vtest regression since fencing changes.

2018-11-18 Thread Dave Airlie
From: Dave Airlie The in_fence_fd needs to be initialised to -1. Fixes: d1a1c21e7 (virgl: native fence fd support) --- src/gallium/winsys/virgl/vtest/virgl_vtest_winsys.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/winsys/virgl/vtest/virgl_vtest_winsys.c

[Mesa-dev] [Bug 107991] RX580 ~ ring gfx timeout ~ particular shaders created by a dolphin-emu game can crash AMDGPU, with both RadeonSI and RADV ~ attached apitrace for RadeonSI

2018-11-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107991 --- Comment #16 from kyle.de...@mykolab.com --- Well, not quite. John, from above, is still having issues, apparently, so I'm happy to wait. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for

[Mesa-dev] [PATCH] nir/rfc: don't compare casts

2018-11-18 Thread Dave Airlie
From: Dave Airlie I've no idea how right or wrong this is, it stops a crash with dEQP-VK.spirv_assembly.instruction.compute.variable_pointers.compute.workgroup_two_buffers on radv with variablePointers. --- src/compiler/nir/nir_deref.c | 4 1 file changed, 4 insertions(+) diff --git

[Mesa-dev] nir/spirv radv variable pointer fixes (round 1)

2018-11-18 Thread Dave Airlie
These 3 I think I've sent before, I've cleaned them up a bit, and hopefully taken any review into account. These are enough to get variablepointers on radv to work, but they are the easiest ones to review first. Dave. ___ mesa-dev mailing list

[Mesa-dev] [PATCH 3/3] nir: handle shared pointers in lowering indirect derefs.

2018-11-18 Thread Dave Airlie
From: Dave Airlie Check if the base ends up with no variable, and continue if we see that case outside the loop. --- src/compiler/nir/nir_lower_indirect_derefs.c | 4 1 file changed, 4 insertions(+) diff --git a/src/compiler/nir/nir_lower_indirect_derefs.c

[Mesa-dev] [PATCH 1/3] spirv/vtn: handle variable pointers without offset lowering

2018-11-18 Thread Dave Airlie
From: Dave Airlie --- src/compiler/spirv/spirv_to_nir.c | 15 --- src/compiler/spirv/vtn_variables.c | 3 ++- 2 files changed, 10 insertions(+), 8 deletions(-) diff --git a/src/compiler/spirv/spirv_to_nir.c b/src/compiler/spirv/spirv_to_nir.c index 4fa02b6fd7b..a05c4d236ca

[Mesa-dev] [PATCH 2/3] nir: move getting deref from var after we check deref type.

2018-11-18 Thread Dave Airlie
From: Dave Airlie I posted a load of hacks before to do this, Jason suggested this, just check the deref mode, not the variable mode and delay getting the variable until we know the type. avoids crashes when derefing shared memory pointers. --- src/compiler/nir/nir_gather_info.c | 7 +++ 1

[Mesa-dev] [Bug 107991] RX580 ~ ring gfx timeout ~ particular shaders created by a dolphin-emu game can crash AMDGPU, with both RadeonSI and RADV ~ attached apitrace for RadeonSI

2018-11-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107991 --- Comment #15 from Rob Stolarz --- I too am no longer seeing crashes on any apitrace file here or from the savestate, as of linux 4.19.2 / mesa 19.0.0_devel.105705.b4380cb070. Kyle, would you agree that this is resolved? -- You are

[Mesa-dev] [PATCH] autotools: Make deps of --enable-* options mandatory

2018-11-18 Thread Lyude Paul
If the user specifies --enable-foo; we should be failing with an error if we can't find the dependencies for foo. Currently however, we're just disabling foo regardless of whether or not the user explicitly asked for it. So, fix that Signed-off-by: Lyude Paul --- configure.ac | 50

Re: [Mesa-dev] [PATCH 09/10] mesa: Factor out struct gl_vertex_format.

2018-11-18 Thread Brian Paul
The series looks great. Just a few minor things below. Reviewed-by: Brian Paul On 11/17/2018 05:14 AM, mathias.froehl...@gmx.net wrote: > From: Mathias Fröhlich > > Factor out struct gl_vertex_format from array attributes. > The data type is supposed to describe the type of a vertex >

Re: [Mesa-dev] Lets talk about autotools

2018-11-18 Thread Dylan Baker
That file can live anywhere and can be referenced by absolute path. On November 17, 2018 9:15:20 AM PST, "Kai Wasserbäch" wrote: >Hey Dylan, >Dylan Baker wrote on 17.11.18 05:04: >> Quoting Dylan Baker (2018-09-17 09:44:07) >>> I feel like for !windows meson is in good enough shape at this

Re: [Mesa-dev] [PATCH mesa] gbm: add missing comma between strings

2018-11-18 Thread Eric Anholt
Eric Engestrom writes: > Fixes: d971a4230d54069c996bc "loader: Factor out the common driver > opening logic from each loader." > Cc: Eric Anholt > Signed-off-by: Eric Engestrom Reviewed-by: Eric Anholt signature.asc Description: PGP signature

[Mesa-dev] [PATCH mesa] gbm: add missing comma between strings

2018-11-18 Thread Eric Engestrom
Fixes: d971a4230d54069c996bc "loader: Factor out the common driver opening logic from each loader." Cc: Eric Anholt Signed-off-by: Eric Engestrom --- src/gbm/backends/dri/gbm_dri.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Mesa-dev] Lets talk about autotools

2018-11-18 Thread Gert Wollny
Am Freitag, den 16.11.2018, 20:04 -0800 schrieb Dylan Baker: > > Is there anything else we're missing in meson to be able to drop > autotools? One thing that I notes is that it seems to be impossible to run the test suite for just one subdirectory because the only way to run the build is from