Hi Brian,
On Sunday, 18 November 2018 20:54:50 CET Brian Paul wrote:
> The series looks great. Just a few minor things below.
>
> Reviewed-by: Brian Paul
Thank you!
For reference, the requested changes in the following mail.
I have also used GLubyte for Patch #10 then.
best
Mathias
From: Mathias Fröhlich
Factor out struct gl_vertex_format from array attributes.
The data type is supposed to describe the type of a vertex
element. At this current stage the data type is only used
with the VAO, but actually is useful in various other places.
Due to the bitfields being used,
From: Mathias Fröhlich
With the current VAO layout we do not need to make these
fields a bitfield. We get a tight struct layout with this change
for VAO attributes.
v2: Change unsigned char -> GLubyte.
Reviewed-by: Brian Paul
Signed-off-by: Mathias Fröhlich
---
src/mesa/main/mtypes.h | 4
On Tue, Nov 20, 2018 at 12:08 AM Dave Airlie wrote:
> On Tue, 20 Nov 2018 at 14:42, Marek Olšák wrote:
> >
> > On Mon, Nov 19, 2018 at 7:15 PM Bas Nieuwenhuizen <
> b...@basnieuwenhuizen.nl> wrote:
> >>
> >> So I tried to test this with radv and got a bunch of crashes in CTS,
> >> mostly around
I'd like to keep ARB_texture_float enabled on drivers that don't support
linear interpolation. ARB_texture_float is required by DX9, which doesn't
require linear interpolation. If you pushed this, you would break DX9 games
for r300, which is de-facto reference DX9 hardware.
Marek
On Mon, Nov 19,
On Tue, Nov 20, 2018 at 12:08 AM Dave Airlie wrote:
> On Tue, 20 Nov 2018 at 14:42, Marek Olšák wrote:
> >
> > On Mon, Nov 19, 2018 at 7:15 PM Bas Nieuwenhuizen <
> b...@basnieuwenhuizen.nl> wrote:
> >>
> >> So I tried to test this with radv and got a bunch of crashes in CTS,
> >> mostly around
Adam Jackson writes:
> On Tue, 2018-10-30 at 16:38 -0700, Eric Anholt wrote:
>> Eric Anholt writes:
>>
>> > The CTS requires a 565-no-depth-no-stencil config for ES 3.0, but at depth
>> > 24 of X11 we wouldn't do so. We can satisfy that bad requirement using a
>> > pbuffer-only visual with
On Tue, 20 Nov 2018 at 14:42, Marek Olšák wrote:
>
> On Mon, Nov 19, 2018 at 7:15 PM Bas Nieuwenhuizen
> wrote:
>>
>> So I tried to test this with radv and got a bunch of crashes in CTS,
>> mostly around 3d image support:
>>
>> #3 0x771a9396 in __assert_fail () from /usr/lib/libc.so.6
On Mon, Nov 19, 2018 at 7:15 PM Bas Nieuwenhuizen
wrote:
> So I tried to test this with radv and got a bunch of crashes in CTS,
> mostly around 3d image support:
>
> #3 0x771a9396 in __assert_fail () from /usr/lib/libc.so.6
> #4 0x769da3b4 in
>
From: Marek Olšák
---
src/gallium/drivers/radeonsi/si_shader_nir.c | 36 +---
1 file changed, 32 insertions(+), 4 deletions(-)
diff --git a/src/gallium/drivers/radeonsi/si_shader_nir.c
b/src/gallium/drivers/radeonsi/si_shader_nir.c
index 87ca0161b45..e7ba282b075 100644
---
From: Marek Olšák
---
.../drivers/radeonsi/si_shader_tgsi_mem.c | 29 +++
1 file changed, 23 insertions(+), 6 deletions(-)
diff --git a/src/gallium/drivers/radeonsi/si_shader_tgsi_mem.c
b/src/gallium/drivers/radeonsi/si_shader_tgsi_mem.c
index 979e47d3cc4..6decedc4cce
From: Marek Olšák
---
.../drivers/radeonsi/si_shader_tgsi_mem.c | 49 ++-
1 file changed, 37 insertions(+), 12 deletions(-)
diff --git a/src/gallium/drivers/radeonsi/si_shader_tgsi_mem.c
b/src/gallium/drivers/radeonsi/si_shader_tgsi_mem.c
index 2ba3f251ff8..81df73ea9b1
From: Marek Olšák
---
src/gallium/drivers/radeonsi/si_shader_tgsi_mem.c | 13 -
1 file changed, 4 insertions(+), 9 deletions(-)
diff --git a/src/gallium/drivers/radeonsi/si_shader_tgsi_mem.c
b/src/gallium/drivers/radeonsi/si_shader_tgsi_mem.c
index 81df73ea9b1..979e47d3cc4 100644
From: Marek Olšák
---
.../drivers/radeonsi/si_shader_tgsi_mem.c | 45 ---
src/gallium/drivers/radeonsi/si_state.c | 7 +--
2 files changed, 42 insertions(+), 10 deletions(-)
diff --git a/src/gallium/drivers/radeonsi/si_shader_tgsi_mem.c
From: Marek Olšák
---
src/gallium/auxiliary/tgsi/tgsi_scan.c | 28 --
src/gallium/auxiliary/tgsi/tgsi_scan.h | 7 +++
2 files changed, 33 insertions(+), 2 deletions(-)
diff --git a/src/gallium/auxiliary/tgsi/tgsi_scan.c
b/src/gallium/auxiliary/tgsi/tgsi_scan.c
So I tried to test this with radv and got a bunch of crashes in CTS,
mostly around 3d image support:
#3 0x771a9396 in __assert_fail () from /usr/lib/libc.so.6
#4 0x769da3b4 in
Addr::V2::Gfx9Lib::HwlGetPreferredSurfaceSetting (this=0x57661b30,
pIn=0x7fffd5f0,
On Mon, Nov 19, 2018 at 5:31 PM Timothy Arceri
wrote:
> On 20/11/18 2:46 am, Jason Ekstrand wrote:
> > I also saw a case last week where the induction variable is <=
> > imax(thing, 4) and it'd be nice to unroll those too.
>
> That is an interesting one. It means we could do a simple unroll for
On 20/11/18 2:46 am, Jason Ekstrand wrote:
I also saw a case last week where the induction variable is <=
imax(thing, 4) and it'd be nice to unroll those too.
That is an interesting one. It means we could do a simple unroll for the
first 4 iterations i.e no if statements required, which is a
From: Marek Olšák
Cc: 18.2 18.3
---
src/gallium/winsys/amdgpu/drm/amdgpu_bo.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/src/gallium/winsys/amdgpu/drm/amdgpu_bo.c
b/src/gallium/winsys/amdgpu/drm/amdgpu_bo.c
index f49fb47b80e..3ee38b8a79f 100644
---
From: Marek Olšák
Cc: 18.2 18.3
---
src/gallium/winsys/amdgpu/drm/amdgpu_winsys.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/src/gallium/winsys/amdgpu/drm/amdgpu_winsys.c
b/src/gallium/winsys/amdgpu/drm/amdgpu_winsys.c
index f32bbd9d086..b20d702670d 100644
---
One thing I always go to the autoconfig webpage for is to copy and paste
the line for a 32bit cross-compiled mesa build.
It would be good if someone could document the method for cross
compiling on the meson page before we remove autotools.
[1] https://www.mesa3d.org/autoconf.html
On
Use L3 configuration specified in h/w specification.
V2: Drop configs which do under allocation of l3 cache.
Bump up the comment above table.
Signed-off-by: Anuj Phogat
Cc: Kenneth Graunke
Cc: Francisco Jerez
---
src/intel/common/gen_l3_config.c | 12 ++--
1 file changed, 6
Dropping this patch.
On Tue, Nov 13, 2018 at 2:34 PM Anuj Phogat wrote:
>
> Config#6 recommended by h/w specification causes multiple piglit
> regressions. Use config#9 instead which works well. Setting a weight
> here so that we get the desired config.
>
> Signed-off-by: Anuj Phogat
> Cc:
Jonathan Marek writes:
> some instructions can only be scalar on a2xx, lower these only
Could we have the core ALU scalar lowering take an optional bitmask or
something of ALU ops that need scalar lowering?
signature.asc
Description: PGP signature
On Fri, Nov 16, 2018 at 2:52 PM Francisco Jerez wrote:
>
> Anuj Phogat writes:
>
> > On Fri, Nov 16, 2018 at 6:21 AM Eero Tamminen
> > wrote:
> >>
> >> Hi,
> >>
> >> On 16.11.2018 10.33, Francisco Jerez wrote:
> >> > Kenneth Graunke writes:
> >> [...]
> >> >> Perhaps we'll get both configs
some instructions can only be scalar on a2xx, lower these only
Signed-off-by: Jonathan Marek
---
.../drivers/freedreno/Makefile.sources| 1 +
src/gallium/drivers/freedreno/a2xx/ir2_nir.c | 3 +
.../freedreno/a2xx/ir2_nir_lower_scalar.c | 174 ++
Not in this patch: emitting the hw binning variant and filling the
"draw_patches". That is part of the ir2 patch.
Signed-off-by: Jonathan Marek
---
src/gallium/drivers/freedreno/a2xx/fd2_draw.c | 51 ++--
src/gallium/drivers/freedreno/a2xx/fd2_emit.c | 8 +-
Signed-off-by: Jonathan Marek
---
src/gallium/drivers/freedreno/drm/freedreno_drmif.h | 1 +
src/gallium/drivers/freedreno/drm/msm_bo.c | 3 +++
src/gallium/drivers/freedreno/freedreno_resource.c | 4 +++-
3 files changed, 7 insertions(+), 1 deletion(-)
diff --git
Meson test has a concepts of suites, which allow tests to be grouped
together. This allows for a subtest of tests to be run only (say only
the tests for nir). A test can be added to more than one suite, but for
the most part I've only added a test to a single suite, though I've
added a compiler
From: Nicolai Hähnle
v2:
- use SI_CONTEXT_REG_OFFSET
Reviewed-by: Dave Airlie
---
src/amd/common/sid.h | 3 +++
src/amd/vulkan/radv_cmd_buffer.c | 6 ++
src/amd/vulkan/radv_device.c | 9 -
3 files changed, 9 insertions(+), 9 deletions(-)
diff --git
From: Andrii Simiklit
This patch is needed to avoid incorrect value of StreamOffset flag
in 3DSTATE_SO_BUFFER command after rollback operation.
To be able to test easily this issue
the following workaround is necessary:
-if (!brw_batch_has_aperture_space(brw, 0)) {
by:
+if (true) {
in
From: Andrii Simiklit
This patch is needed to avoid missing 3DSTATE_URB_* commands in a batch after
rollback operation.
To be able to test easily this issue
the following workaround is necessary:
-if (!brw_batch_has_aperture_space(brw, 0)) {
by:
+if (true) {
in brw_draw_single_prim function.
On Mon, Nov 19, 2018 at 3:15 PM Christian Gmeiner
wrote:
>
> Am Mo., 12. Nov. 2018 um 19:17 Uhr schrieb Jonathan Marek :
> >
> > lowers ceil(x) as -floor(-x)
> >
> > Signed-off-by: Jonathan Marek
>
> Do you have push rights? As I am interested in this one I would push
> it for you if needed.
>
Hey Dylan,
Dylan Baker wrote on 19.11.18 20:02:
> Sorry, cell phones are really bad for responding to email...
no worries.
> The file has the same rules as cross files, it can be a local file, passed as
> an
> absolute path, or read from $XDG directories (local files will be read before
> XDG
Am Mo., 19. Nov. 2018 um 21:17 Uhr schrieb Jonathan marek :
>
> I don't have push rights, but robclark added this patch to his staging
> branch so I imagine he will push it soon.
>
Great..
> On 11/19/2018 03:15 PM, Christian Gmeiner wrote:
> > Am Mo., 12. Nov. 2018 um 19:17 Uhr schrieb Jonathan
Eric Engestrom writes:
> On Thursday, 2018-11-15 19:01:24 +0100, Gert Wollny wrote:
>> Emulate MESA_FORMAT_R_SRGB8 by using L8_UNORM_SRGB. This is possible
>> because component swizzling is handled based on the mesa format and,
>> hence, the a r001 swizzling can be used to correct the
I don't have push rights, but robclark added this patch to his staging
branch so I imagine he will push it soon.
On 11/19/2018 03:15 PM, Christian Gmeiner wrote:
Am Mo., 12. Nov. 2018 um 19:17 Uhr schrieb Jonathan Marek :
lowers ceil(x) as -floor(-x)
Signed-off-by: Jonathan Marek
Do you
From: Dave Airlie
Just give back the same value for now.
---
src/amd/common/ac_nir_to_llvm.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c
index cc795324cc5..d7296a4617e 100644
--- a/src/amd/common/ac_nir_to_llvm.c
+++
From: Dave Airlie
For variable pointers we really don't want to case the pointers to int
without a good reason, just add a wrapper for bcsel loading and result
storing.
---
src/amd/common/ac_llvm_build.c | 9 +
src/amd/common/ac_llvm_build.h | 1 +
src/amd/common/ac_nir_to_llvm.c | 7
From: Dave Airlie
We won't have a var to load from, so don't try to the processing
required if we don't need it.
This avoids crashes in:
dEQP-VK.spirv_assembly.instruction.compute.variable_pointers.compute.workgroup_two_buffers
Signed-off-by: Dave Airlie
---
src/amd/common/ac_nir_to_llvm.c |
Variable pointer support still needs another NIR patch, but
these are the 3 ac/radv patches needed to make the tests pass,
apart from the final enable patch.
Dave.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
Am Mo., 12. Nov. 2018 um 19:17 Uhr schrieb Jonathan Marek :
>
> lowers ceil(x) as -floor(-x)
>
> Signed-off-by: Jonathan Marek
Do you have push rights? As I am interested in this one I would push
it for you if needed.
--
greets
--
Christian Gmeiner, MSc
https://christian-gmeiner.info
This works by moving the fadd up across the ffma operations, so that it
can eventually can be combined with a fmul. I'm not sure it works in all
cases, but it works in all the common cases.
This will only affect freedreno since it is the only driver using the
fuse_ffma option.
Example:
out_type is always GLSL_TYPE_FLOAT, so we don't get the ftrunc otherwise
since there are no other conversions needed, use fmov for the other cases
(there is the f2b case, but the 1-bit bool patches should fix that)
Signed-off-by: Jonathan Marek
---
src/compiler/glsl/glsl_to_nir.cpp | 13
Note: the backend must take care that uniform index is now a float
Signed-off-by: Jonathan Marek
---
src/compiler/glsl/glsl_to_nir.cpp | 16
1 file changed, 12 insertions(+), 4 deletions(-)
diff --git a/src/compiler/glsl/glsl_to_nir.cpp
b/src/compiler/glsl/glsl_to_nir.cpp
Quoting Gert Wollny (2018-11-18 02:56:00)
> Am Freitag, den 16.11.2018, 20:04 -0800 schrieb Dylan Baker:
> >
> > Is there anything else we're missing in meson to be able to drop
> > autotools?
>
> One thing that I notes is that it seems to be impossible to run the
> test suite for just one
Quoting Gert Wollny (2018-11-18 02:56:00)
> Am Freitag, den 16.11.2018, 20:04 -0800 schrieb Dylan Baker:
> >
> > Is there anything else we're missing in meson to be able to drop
> > autotools?
>
> One thing that I notes is that it seems to be impossible to run the
> test suite for just one
On Mon, Nov 19, 2018 at 12:30 PM Pohjolainen, Topi <
topi.pohjolai...@gmail.com> wrote:
> On Fri, Oct 12, 2018 at 01:46:56PM -0500, Jason Ekstrand wrote:
> > Unfortunately, there is no nice way to calculate miptail offsets in
> > closed form. Instead, we just copy the tables from the PRM
Although I'm not sure we actually really wanted that rounding behavior in the
first place - it's possible the only reason it was used is just because it had
an easy implementation...
From: Matt Turner
Sent: Friday, November 16, 2018 8:02:00 PM
To: Dylan
Patches 1 and 2 are
Reviewed-by: Jason Ekstrand
As I commented on IRC, I'd recommend we also review and land my emit
pointers on-the-fly patch. I don't know that it's strictly necessary but I
do think it's better.
On Sun, Nov 18, 2018 at 9:57 PM Dave Airlie wrote:
> From: Dave Airlie
>
> I
On Sun, Nov 18, 2018 at 9:57 PM Dave Airlie wrote:
> From: Dave Airlie
>
> Check if the base ends up with no variable, and continue
> if we see that case outside the loop.
> ---
> src/compiler/nir/nir_lower_indirect_derefs.c | 4
> 1 file changed, 4 insertions(+)
>
> diff --git
On 11/19/18 7:37 PM, Dave Airlie wrote:
On Tue, 20 Nov 2018 at 04:30, Nicolai Hähnle wrote:
From: Nicolai Hähnle
---
src/amd/common/sid.h | 3 +++
src/amd/vulkan/radv_cmd_buffer.c | 6 ++
src/amd/vulkan/radv_device.c | 9 -
3 files changed, 9
FWIW this looks like a rather similar incident to me what happened when mesa
began to verify the max vertex stride (which needs to be 2048 with GL 4.4
whereas r600 can only do 2047) where I argued it's a much better idea to lie
about the GL version there rather than the specific vertex stride
On Fri, Oct 12, 2018 at 01:46:59PM -0500, Jason Ekstrand wrote:
> ---
> src/intel/isl/isl.c | 19 +++
> 1 file changed, 19 insertions(+)
Reviewed-by: Topi Pohjolainen
>
> diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c
> index df4fb94a6fe..2513d2e73d1 100644
> ---
Sorry, cell phones are really bad for responding to email...
The file has the same rules as cross files, it can be a local file, passed as an
absolute path, or read from $XDG directories (local files will be read before
XDG ones).
Dylan
Quoting Dylan Baker (2018-11-18 09:01:27)
> That file can
On Fri, Oct 12, 2018 at 01:46:58PM -0500, Jason Ekstrand wrote:
> ---
> src/intel/isl/isl.c | 45 +++--
> 1 file changed, 35 insertions(+), 10 deletions(-)
Reviewed-by: Topi Pohjolainen
>
> diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c
> index
On Tue, 20 Nov 2018 at 04:30, Nicolai Hähnle wrote:
>
> From: Nicolai Hähnle
>
> ---
> src/amd/common/sid.h | 3 +++
> src/amd/vulkan/radv_cmd_buffer.c | 6 ++
> src/amd/vulkan/radv_device.c | 9 -
> 3 files changed, 9 insertions(+), 9 deletions(-)
>
> diff --git
On Fri, Oct 12, 2018 at 01:46:57PM -0500, Jason Ekstrand wrote:
> ---
> src/intel/isl/isl.c | 27 ++-
> 1 file changed, 14 insertions(+), 13 deletions(-)
Reviewed-by: Topi Pohjolainen
>
> diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c
> index
This makes some of the code more clear.
---
src/compiler/nir/nir_deref.c | 8
src/compiler/nir/nir_deref.h | 1 +
2 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/src/compiler/nir/nir_deref.c b/src/compiler/nir/nir_deref.c
index 59b36a7f255..68a3aad5c70 100644
---
On Fri, Oct 12, 2018 at 01:46:56PM -0500, Jason Ekstrand wrote:
> Unfortunately, there is no nice way to calculate miptail offsets in
> closed form. Instead, we just copy the tables from the PRM directly
> verbatim.
> ---
> src/intel/isl/isl.c | 217 +++-
>
tooling that is used for AMDVLK. Hopefully
that will make things simpler going forward.
Since the main patch is pretty big, I've also put it here:
https://gitlab.freedesktop.org/nh/mesa/tree/addrlib-update-20181119
Please review!
Thanks,
Nicolai
___
mesa
From: Nicolai Hähnle
---
src/amd/common/sid.h | 3 +++
src/amd/vulkan/radv_cmd_buffer.c | 6 ++
src/amd/vulkan/radv_device.c | 9 -
3 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/src/amd/common/sid.h b/src/amd/common/sid.h
index
The code which constructs deref paths already gives you the path
starting at the nearest deref_cast or deref_var. All we need to do is
handle the case where the start of the path isn't a deref_var.
Cc: Karol Herbst
Cc: Dave Airlie
---
src/compiler/nir/nir_deref.c | 42
On Mon, 2018-11-19 at 18:43 +0100, Francesco Ansanelli wrote:
> Hi Eric,
>
> While checking this patch I noticed an extra semicolon in this
> function:
> +static inline bool
> +_mesa_has_half_float_textures(const struct gl_context *ctx)
> +{
> + return _mesa_has_ARB_texture_float(ctx) ||
> +
On Monday, 2018-11-19 16:15:24 +0100, Juan A. Suarez Romero wrote:
> On Thu, 2018-10-11 at 16:36 +0100, Eric Engestrom wrote:
> > Those empty variables in the !wayland case are useless and running that
> > meson.build with them breaks the build:
> >
> > [287/850] Generating
Quoting Juan A. Suarez Romero (2018-11-19 07:17:14)
> On Fri, 2018-11-09 at 13:28 -0800, Dylan Baker wrote:
> > meson does this for you with it's warn levels, so we don't need to set
> > it ourselves.
> >
> > Fixes: d1992255bb29054fa51763376d125183a9f602f3
> >("meson: Add build Intel
On Mon, 2018-11-19 at 11:37 -0500, Ilia Mirkin wrote:
> On Mon, Nov 19, 2018 at 11:30 AM Erik Faye-Lund
> wrote:
> > On Mon, 2018-11-19 at 11:13 -0500, Ilia Mirkin wrote:
> > > On Mon, Nov 19, 2018 at 10:40 AM Erik Faye-Lund
> > > wrote:
> > > > On Mon, 2018-11-19 at 10:02 -0500, Ilia Mirkin
On Mon, Nov 19, 2018 at 11:30 AM Erik Faye-Lund
wrote:
>
> On Mon, 2018-11-19 at 11:13 -0500, Ilia Mirkin wrote:
> > On Mon, Nov 19, 2018 at 10:40 AM Erik Faye-Lund
> > wrote:
> > > On Mon, 2018-11-19 at 10:02 -0500, Ilia Mirkin wrote:
> > > > Unfortunately this will drop GL 3.0 from Adreno
On Mon, 2018-11-19 at 11:13 -0500, Ilia Mirkin wrote:
> On Mon, Nov 19, 2018 at 10:40 AM Erik Faye-Lund
> wrote:
> > On Mon, 2018-11-19 at 10:02 -0500, Ilia Mirkin wrote:
> > > Unfortunately this will drop GL 3.0 from Adreno A3xx. I think
> > > we'd
> > > rather fake linear interpolation with F32
On Mon, Nov 19, 2018 at 10:40 AM Erik Faye-Lund
wrote:
>
> On Mon, 2018-11-19 at 10:02 -0500, Ilia Mirkin wrote:
> > Unfortunately this will drop GL 3.0 from Adreno A3xx. I think we'd
> > rather fake linear interpolation with F32 textures which are never
> > used than lose GL 3.0 there...
>
>
Reviewed-by: Bas Nieuwenhuizen
On Mon, Nov 19, 2018 at 4:39 PM Jason Ekstrand wrote:
>
> ---
> include/vulkan/vulkan_core.h | 35 ---
> src/vulkan/registry/vk.xml | 84 +---
> 2 files changed, 98 insertions(+), 21 deletions(-)
>
> diff --git
On Mon, Nov 19, 2018 at 9:40 AM Bas Nieuwenhuizen wrote:
>
> With my limited knowledge of the parts up till now, this is
>
> Reviewed-by: Bas Nieuwenhuizen
>
> with the caveat that this might very well break the Android build.
> Have anyone to look at that or do I need to take a stab?
I'm
I also saw a case last week where the induction variable is <= imax(thing,
4) and it'd be nice to unroll those too.
--Jason
On Mon, Nov 19, 2018 at 12:18 AM Timothy Arceri
wrote:
> This series add support for partial loop unrolling for loops with an
> unknown trip count. The new partial_unroll
agreed.
On Mon, Nov 19, 2018 at 5:57 AM Connor Abbott wrote:
> This will cause the assert to pass when it shouldn't in some cases
> with a 32-bit bitsize, and seems like a hack since it's subverting the
> point of the assert, which is guarantee that we won't lose any
> information by truncating
On Mon, 2018-11-19 at 10:02 -0500, Ilia Mirkin wrote:
> Unfortunately this will drop GL 3.0 from Adreno A3xx. I think we'd
> rather fake linear interpolation with F32 textures which are never
> used than lose GL 3.0 there...
Right...
I guess this means that this GPU never really did support
---
include/vulkan/vulkan_core.h | 35 ---
src/vulkan/registry/vk.xml | 84 +---
2 files changed, 98 insertions(+), 21 deletions(-)
diff --git a/include/vulkan/vulkan_core.h b/include/vulkan/vulkan_core.h
index 4cd8ed51dcd..35c06649aa5 100644
---
Our compile already splits UBO loads into scalars and the untyped
surface read messages we use for SSBO reads and writes only require
dword alignment.
---
src/intel/vulkan/anv_device.c | 7 +++
src/intel/vulkan/anv_extensions.py | 1 +
2 files changed, 8 insertions(+)
diff --git
Reviewed-by: Roland Scheidegger
From: mesa-dev on behalf of Gert
Wollny
Sent: Friday, November 16, 2018 6:06:15 PM
To: mesa-dev@lists.freedesktop.org
Subject: Re: [Mesa-dev] [PATCH] r600: clean up the GS ring buffers when the
context is destroyed
I
On Fri, 2018-11-09 at 13:28 -0800, Dylan Baker wrote:
> meson does this for you with it's warn levels, so we don't need to set
> it ourselves.
>
> Fixes: d1992255bb29054fa51763376d125183a9f602f3
>("meson: Add build Intel "anv" vulkan driver")
Hi.
I've cherry-picked this commit for next
On Thu, 2018-10-11 at 16:36 +0100, Eric Engestrom wrote:
> Those empty variables in the !wayland case are useless and running that
> meson.build with them breaks the build:
>
> [287/850] Generating wayland-drm-client-protocol.h with a custom command.
> FAILED:
Unfortunately this will drop GL 3.0 from Adreno A3xx. I think we'd
rather fake linear interpolation with F32 textures which are never
used than lose GL 3.0 there...
On Mon, Nov 19, 2018 at 7:16 AM Erik Faye-Lund
wrote:
>
> There's nothing in the ARB_texture_float specification that limits
>
With my limited knowledge of the parts up till now, this is
Reviewed-by: Bas Nieuwenhuizen
with the caveat that this might very well break the Android build.
Have anyone to look at that or do I need to take a stab?
On Mon, Nov 12, 2018 at 4:51 PM Rob Clark wrote:
>
> Moves drm and the ir3
Hey Dave,
Thanks for catching this, pushed!
On 2018-11-19 06:47, Dave Airlie wrote:
From: Dave Airlie
The in_fence_fd needs to be initialised to -1.
Fixes: d1a1c21e7 (virgl: native fence fd support)
---
src/gallium/winsys/virgl/vtest/virgl_vtest_winsys.c | 1 +
1 file changed, 1
From: Sergii Romantsov
Xcb-dri3 is installed into custom directory.
Installing of Vulkan on Ubuntu 16.04 fails during relinking.
Potential reason: seems during relinking a path to the custom
dri3-path is missed: glx.la depends on libloader_dri3_helper.la
which depends on XCB_DRI3_LIBS.
On 11/19/18 12:25 PM, Bas Nieuwenhuizen wrote:
On Mon, Nov 19, 2018 at 12:21 PM Samuel Pitoiset
wrote:
On 11/19/18 11:56 AM, Bas Nieuwenhuizen wrote:
On Thu, Nov 15, 2018 at 10:51 AM Samuel Pitoiset
wrote:
This has been initially added for a Sascha demo (ie. deferredshadows),
but as
ctx->Extensions.EXT_texture_type_2_10_10_10_REV is set regardless of
the API that's used, so checking for those direcly will always enable
extensions when they are supported by the driver.
There's no corresponding extension for OpenGL ES 1.x/2.0, so we
shouldn't allow these enums there.
ctx->Extensions.OES_texture_float is set regardless of the API
that's used, so checking for those direcly will always allow the
enums from this extensions when they are supported by the driver.
There's no extension enabling floating-point textures for OpenGL
ES 1.x, so we shouldn't allow those
ctx->Extensions.ARB_ES3_compatibility is set regardless of the API
that's used, so checking for those direcly will always enable
extensions when they are supported by the driver.
But there's no extension enabling ETC2 for OpenGL ES 1.x, so we
shouldn't allow those enums there.
Signed-off-by:
EXT_packed_float isn't supported on OpenGL ES, we shouldn't allow
these enums there, before OpenGL ES 3.0 which also introduce support
for these enums.
Signed-off-by: Erik Faye-Lund
---
src/mesa/main/context.h | 6 ++
src/mesa/main/glformats.c | 6 +++---
2 files changed, 9 insertions(+),
ctx->Extensions.EXT_texture_shared_exponent is set regardless of the
API that's used, so checking for those direcly will always allow the
enums from this extensions when they are supported by the driver.
We also need to make sure this is enabled on OpenGL ES 3. Because the
check is repeated,
sRGB textures is a requirement for OpenGL ES 3.0, so let's make sure
we don't incorrectly enable a too high version.
Signed-off-by: Erik Faye-Lund
---
src/mesa/main/version.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/mesa/main/version.c b/src/mesa/main/version.c
index
On OpenGL ES 2.0, there's separate extensions adding support for
half-float and float textures. So we need to validate the enums
separately as well.
This also prevents these enums from incorrectly being allowed on
OpenGL ES 1.x, where there's no extension that enables this in the
first place.
ctx->Extensions.EXT_texture_sRGB_R8 is set regardless of the API
that's used, so checking for those direcly will always allow the
enums from this extensions when they are supported by the driver.
There's no extension adding support for this on OpenGL ES before
version 3.0, so let's tighten the
ctx->Extensions.EXT_texture_sRGB is set regardless of the API that's
used, so checking for those direcly will always allow the enums from
this extensions when they are supported by the driver.
There's no extension adding support for this on OpenGL ES before
version 3.0, so let's tighten the
ctx->Extensions.EXT_texture_snorm is set regardless of the API
that's used, so checking for those direcly will always allow the
enums from this extensions when they are supported by the driver.
There's no extension adding support for this on OpenGL ES before
version 3.0, so let's tighten the
There's nothing in the ARB_texture_float specification that limits
filterability for floating-point textures, so we need to ensure that
this is required to enable this extension. Luckily, we have just the
right bits ready.
Signed-off-by: Erik Faye-Lund
---
src/mesa/state_tracker/st_extensions.c
OpenGL ES 3.0 require this functionality, so we should also test for it
to avoid incorrectly exposing a too high GLES version.
On desktop, this has been required since all the way back in OpenGL 1.2
anyway.
Signed-off-by: Erik Faye-Lund
---
src/mesa/main/version.c | 3 ++-
1 file changed, 2
The OpenGL ES 3.0 specification, table 3.13 lists half-float textures as
filterable, but not float textures. So we shouldn't depend on
ARB_float_texture, which requires full filtering support for both.
Signed-off-by: Erik Faye-Lund
---
src/mesa/main/version.c | 4 +++-
1 file changed, 3
This should be equalent of what we did before.
Signed-off-by: Erik Faye-Lund
---
src/mesa/state_tracker/st_extensions.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/mesa/state_tracker/st_extensions.c
b/src/mesa/state_tracker/st_extensions.c
index
This extension requies OpenGL, and shouldn't be available on OpenGL ES.
So let's not allow the enums from it either.
Signed-off-by: Erik Faye-Lund
---
src/mesa/main/glformats.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/mesa/main/glformats.c
1 - 100 of 143 matches
Mail list logo
