Re: [Mesa-dev] [PATCH 06/11] nir: rework force_unroll_array_access()

2018-12-04 Thread Thomas Helland
Den tir. 20. nov. 2018 kl. 09:15 skrev Timothy Arceri : > > Here we rework force_unroll_array_access() so that we can reused > the induction variable detection in a following patch. > --- > src/compiler/nir/nir_loop_analyze.c | 49 - > 1 file changed, 35 insertions(+),

Re: [Mesa-dev] [PATCH 05/11] nir: factor out some of the complex loop unroll code to a helper

2018-12-04 Thread Thomas Helland
Den tir. 20. nov. 2018 kl. 09:15 skrev Timothy Arceri : > > --- > src/compiler/nir/nir_opt_loop_unroll.c | 116 ++--- > 1 file changed, 64 insertions(+), 52 deletions(-) > > diff --git a/src/compiler/nir/nir_opt_loop_unroll.c > b/src/compiler/nir/nir_opt_loop_unroll.c > index

[Mesa-dev] [Bug 108946] High memory usage in Black Mesa

2018-12-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108946 Lee Donaghy changed: What|Removed |Added CC||lee295...@gmail.com -- You are

[Mesa-dev] [PATCH 3/8] st/mesa: select ATOMFADD when source type is float

2018-12-04 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 2 ++ src/mesa/state_tracker/st_glsl_to_tgsi_private.h | 1 + 2 files changed, 3 insertions(+) diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp b/src/mesa/state_tracker/st_glsl_to_tgsi.cpp index

[Mesa-dev] [PATCH 8/8] nvc0: expose ATOMFADD on all generations

2018-12-04 Thread Ilia Mirkin
This is supported on all generations for regular memory. For shared memory, all operations are entirely emulated on Fermi/Kepler anyways, for Maxwell, we add a special path to emulate just this operation (using ATOMS.CAS to implement a loop), since there is no ATOMS.ADD.F32 variant.

[Mesa-dev] [PATCH 2/8] gallium: add PIPE_CAP_TGSI_ATOMFADD to indicate support

2018-12-04 Thread Ilia Mirkin
ATOMFADD is a little special -- make drivers have to specify it explicitly. Signed-off-by: Ilia Mirkin --- src/gallium/auxiliary/util/u_screen.c | 1 + src/gallium/docs/source/screen.rst| 2 ++ src/gallium/include/pipe/p_defines.h | 1 + 3 files changed, 4 insertions(+) diff --git

[Mesa-dev] [PATCH 1/8] tgsi: add ATOMFADD operation

2018-12-04 Thread Ilia Mirkin
This is supported by at least NVIDIA hardware, and exposeable via GL extensions. Signed-off-by: Ilia Mirkin --- src/gallium/auxiliary/tgsi/tgsi_exec.c | 4 src/gallium/auxiliary/tgsi/tgsi_info_opcodes.h | 2 +- src/gallium/auxiliary/tgsi/tgsi_scan.c | 1 +

[Mesa-dev] [PATCH 6/8] nv50/ir: ensure that the constraint mov is placed above flow control

2018-12-04 Thread Ilia Mirkin
This is tickled by the Maxwell lowering logic for shared floating point add, but it could potentially come up in other ways too. Signed-off-by: Ilia Mirkin --- Note that this may depend slightly on a local patch. However the overall idea remains entirely the same.

[Mesa-dev] [PATCH 5/8] nv50/ir: add support for converting ATOMFADD to proper ir

2018-12-04 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- src/gallium/drivers/nouveau/codegen/nv50_ir_from_tgsi.cpp | 4 1 file changed, 4 insertions(+) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_from_tgsi.cpp b/src/gallium/drivers/nouveau/codegen/nv50_ir_from_tgsi.cpp index c6e69ff1230..afd7916a321

[Mesa-dev] [PATCH 7/8] gm107/ir: add lowering of atomic f32 add on shared memory

2018-12-04 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- .../nouveau/codegen/nv50_ir_lowering_nvc0.cpp | 49 +++ .../nouveau/codegen/nv50_ir_lowering_nvc0.h | 1 + 2 files changed, 50 insertions(+) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_lowering_nvc0.cpp

[Mesa-dev] [PATCH 4/8] st/mesa: expose GL_NV_shader_atomic_float when ATOMFADD is supported

2018-12-04 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- src/mesa/state_tracker/st_extensions.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/state_tracker/st_extensions.c b/src/mesa/state_tracker/st_extensions.c index 002866d4cdb..8d0e8e0292f 100644 --- a/src/mesa/state_tracker/st_extensions.c +++

[Mesa-dev] [Bug 107991] RX580 ~ ring gfx timeout ~ particular shaders created by a dolphin-emu game can crash AMDGPU, with both RadeonSI and RADV ~ attached apitrace for RadeonSI

2018-12-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107991 John changed: What|Removed |Added CC||john.etted...@gmail.com -- You are receiving

[Mesa-dev] [Bug 108946] High memory usage in Black Mesa

2018-12-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108946 --- Comment #1 from MGG --- Created attachment 142729 --> https://bugs.freedesktop.org/attachment.cgi?id=142729=edit game apitrace -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the

[Mesa-dev] [Bug 108946] High memory usage in Black Mesa

2018-12-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108946 Bug ID: 108946 Summary: High memory usage in Black Mesa Product: Mesa Version: 18.2 Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW Severity:

[Mesa-dev] [Bug 107991] RX580 ~ ring gfx timeout ~ particular shaders created by a dolphin-emu game can crash AMDGPU, with both RadeonSI and RADV ~ attached apitrace for RadeonSI

2018-12-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107991 --- Comment #17 from John --- My apologies for the delay, I had not seen your question before. Your trace replays fine here, but truthfully I did not try it before so I don't know if anything changed on my end. My dolphin save still crashes

Re: [Mesa-dev] Make Jordan an Owner of the mesa project?

2018-12-04 Thread Jason Ekstrand
It's been 24 hours and the only owner who hasn't replied yet is Matt. Given that everyone else has firmly ACKed, I'm going to click the button. Congratulations, Jordan, you're now a mesa Owner! --Jason On Tue, Dec 4, 2018 at 1:41 PM Rob Clark wrote: > On Mon, Dec 3, 2018 at 7:49 PM Jason

Re: [Mesa-dev] [PATCH v2] build: remove autotools

2018-12-04 Thread Marek Olšák
On Tue, Dec 4, 2018 at 7:18 PM Dylan Baker wrote: > Quoting Marek Olšák (2018-12-04 16:04:11) > > On Tue, Dec 4, 2018 at 7:01 PM Dylan Baker wrote: > > > > Quoting Marek Olšák (2018-12-04 14:52:19) > > > CFLAGS="-fno-omit-frame-pointer" \ > > > CXXFLAGS="-fno-omit-frame-pointer" \ >

Re: [Mesa-dev] [PATCH mesa] drop autotools

2018-12-04 Thread Matt Turner
On Tue, Dec 4, 2018 at 3:43 PM Gert Wollny wrote: > > Am Dienstag, den 04.12.2018, 14:01 -0800 schrieb Matt Turner: > > On Tue, Dec 4, 2018 at 12:48 PM Gert Wollny > > wrote: > > > FWIW, I also don't understand the urge to remove the automake build > > > system files, they account for less then

Re: [Mesa-dev] [PATCH v2] build: remove autotools

2018-12-04 Thread Dylan Baker
Quoting Marek Olšák (2018-12-04 16:04:11) > On Tue, Dec 4, 2018 at 7:01 PM Dylan Baker wrote: > > Quoting Marek Olšák (2018-12-04 14:52:19) > > CFLAGS="-fno-omit-frame-pointer" \ > > CXXFLAGS="-fno-omit-frame-pointer" \ > > LDFLAGS="-fuse-ld=gold" \ > >     meson $reconfigure

Re: [Mesa-dev] [PATCH v2] build: remove autotools

2018-12-04 Thread Marek Olšák
On Tue, Dec 4, 2018 at 7:01 PM Dylan Baker wrote: > Quoting Marek Olšák (2018-12-04 14:52:19) > > CFLAGS="-fno-omit-frame-pointer" \ > > CXXFLAGS="-fno-omit-frame-pointer" \ > > LDFLAGS="-fuse-ld=gold" \ > > meson $reconfigure build \ > > --prefix /usr --libdir /usr/lib/$archdir

Re: [Mesa-dev] [PATCH mesa] drop autotools

2018-12-04 Thread Dylan Baker
Quoting Gert Wollny (2018-12-04 15:42:58) > Am Dienstag, den 04.12.2018, 14:01 -0800 schrieb Matt Turner: > > On Tue, Dec 4, 2018 at 12:48 PM Gert Wollny > > wrote: > > > FWIW, I also don't understand the urge to remove the automake build > > > system files, they account for less then 1% of line

Re: [Mesa-dev] [PATCH v2] build: remove autotools

2018-12-04 Thread Dylan Baker
Quoting Marek Olšák (2018-12-04 14:52:19) > CFLAGS="-fno-omit-frame-pointer" \ > CXXFLAGS="-fno-omit-frame-pointer" \ > LDFLAGS="-fuse-ld=gold" \ >     meson $reconfigure build \ >     --prefix /usr --libdir /usr/lib/$archdir --buildtype debugoptimized > --native-file $llvm_config \ >    

Re: [Mesa-dev] [PATCH mesa] drop autotools

2018-12-04 Thread Gert Wollny
Am Dienstag, den 04.12.2018, 14:01 -0800 schrieb Matt Turner: > On Tue, Dec 4, 2018 at 12:48 PM Gert Wollny > wrote: > > FWIW, I also don't understand the urge to remove the automake build > > system files, they account for less then 1% of line count in the > > source > > tree, Emil offered to

Re: [Mesa-dev] [PATCH v2] build: remove autotools

2018-12-04 Thread Marek Olšák
CFLAGS="-fno-omit-frame-pointer" \ CXXFLAGS="-fno-omit-frame-pointer" \ LDFLAGS="-fuse-ld=gold" \ meson $reconfigure build \ --prefix /usr --libdir /usr/lib/$archdir --buildtype debugoptimized --native-file $llvm_config \ -Dgallium-va=false -Dgallium-xvmc=false -Dgallium-omx=disabled

Re: [Mesa-dev] [PATCH v2 1/5] mesa: Add core support for EXT_multisampled_render_to_texture2

2018-12-04 Thread Marek Olšák
On Thu, Nov 29, 2018 at 7:50 PM Kristian Høgsberg wrote: > On Tue, Nov 6, 2018 at 3:03 PM Ilia Mirkin wrote: > > > > On Tue, Nov 6, 2018 at 5:18 PM Kristian H. Kristensen > > wrote: > > > > > > This also turns on EXT_multisampled_render_to_texture which is a > > > subset of

Re: [Mesa-dev] [PATCH v2] build: remove autotools

2018-12-04 Thread Dylan Baker
Quoting Eric Engestrom (2018-12-04 09:36:53) > On Tuesday, 2018-12-04 09:16:18 -0800, Dylan Baker wrote: > > There are now no known distributions using autotools, meson has all of > > the features that autotools does. We don't need two build systems to do > > exactly the same thing, meson is

Re: [Mesa-dev] [PATCH mesa] drop autotools

2018-12-04 Thread Matt Turner
On Tue, Dec 4, 2018 at 12:48 PM Gert Wollny wrote: > FWIW, I also don't understand the urge to remove the automake build > system files, they account for less then 1% of line count in the source > tree, Emil offered to maintain the build system in a way that nobody > who doesn't want to deal with

Re: [Mesa-dev] [PATCH] build: remove autotools

2018-12-04 Thread Dylan Baker
Quoting Marek Olšák (2018-12-04 12:21:58) > There is still the issue that DEBUG is not defined in debug builds if I set > CFLAGS and CXXFLAGS. > > Marek What does you command line look like, and what version of meson do you have? I can do: $ CFLAGS=-Dfoobar CXXFLAGS=-Dfoobar meson build

Re: [Mesa-dev] [PATCH] radv: fix vkCmdCopyQueryoolResults() for timestamp queries

2018-12-04 Thread Bas Nieuwenhuizen
On Tue, Dec 4, 2018 at 4:52 PM Samuel Pitoiset wrote: > > Because WAIT_REG_MEM can only wait for a 32-bit value, it's not > safe to use it for timestamp queries. If we only wait on the low > 32 bits of a timestamp query we could be unlucky and the GPU > might hang. > > One possible fix is to emit

[Mesa-dev] [PATCH 2/5] meson: Fix ppc64 little endian detection

2018-12-04 Thread Dylan Baker
Old versions of meson returned ppc64le as the cpu_family for little endian power8 cpus, versions >=0.48 don't do this, so the check wouldn't work in that case. This generalizes the check to work for both old and new versions of meson. Fixes: 34bbb24ce7702658cdc4e9d34a650e169716c39e

[Mesa-dev] [PATCH 4/5] meson: Add support for gnu hurd

2018-12-04 Thread Dylan Baker
--- meson.build | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/meson.build b/meson.build index 0785609c4b0..3f835e2b952 100644 --- a/meson.build +++ b/meson.build @@ -220,8 +220,6 @@ elif system_has_kms_drm else # FIXME: haiku doesn't use dri, and xlib doesn't use

[Mesa-dev] [PATCH 3/5] meson: Override C++ standard to gnu++11 when building with altivec on ppc64le

2018-12-04 Thread Dylan Baker
Otherwise there will be symbol collisions for the vector name. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108943 Fixes: 34bbb24ce7702658cdc4e9d34a650e169716c39e ("meson: Add support for ppc assembly/optimizations") --- meson.build | 12

[Mesa-dev] [PATCH 0/5] Fixueps for ppc64 and gnu hurd

2018-12-04 Thread Dylan Baker
This little series is aimed at fixing problems reported by fedora and debian when using meson, there's a couple of patches in here for fixing ppc64 detection (tested without llvm), and a couple for gnu hurd (not tested). Dylan Baker (5): meson: remove duplicate definition meson: Fix ppc64

[Mesa-dev] [PATCH 1/5] meson: remove duplicate definition

2018-12-04 Thread Dylan Baker
--- meson.build | 2 -- 1 file changed, 2 deletions(-) diff --git a/meson.build b/meson.build index 1aeef95f722..48ba8127f95 100644 --- a/meson.build +++ b/meson.build @@ -34,8 +34,6 @@ cpp = meson.get_compiler('cpp') null_dep = dependency('', required : false) -system_has_kms_drm =

[Mesa-dev] [PATCH 5/5] meson: Add toggle for glx-direct

2018-12-04 Thread Dylan Baker
GNU Hurd needs to turn off glx-direct, rather than special case it, we'll just add a toggle. --- meson.build | 4 +--- meson_options.txt | 6 ++ 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/meson.build b/meson.build index 3f835e2b952..3aacfa04900 100644 ---

[Mesa-dev] [Bug 106958] Mass Effect Andromeda renders correctly on RX480 POLARIS but BAD ON RX VEGA 64 on wine 3.10 stagingf with DXVK

2018-12-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106958 --- Comment #26 from egon2003 --- I just tried it with LLVM and Mesa from git and the glitch is gone. However I see the glitch with Mesa 18.2.5 compiled against LLVM 7.0.0 and LLVM 7.0.1. The glitch is also there with Mesa 18.3.0-rc5 and LLVM

Re: [Mesa-dev] [PATCH] i965: Be resilient in the face of GPU hangs

2018-12-04 Thread Chris Wilson
Quoting Chris Wilson (2018-10-24 09:40:08) > If we hang the GPU and end up banning our context, we will no longer be > able to submit and abort with an error (exit(1) no less). As we submit > minimal incremental batches that rely on the logical context state of > previous batches, we can not rely

Re: [Mesa-dev] [PATCH] mesa/main: fix up _mesa_has_rg_textures for gles2

2018-12-04 Thread Mark Janes
Choose a well-named branch on your mesa repository that you will use to trigger i965 CI builds. Provide me with the branch name and the repo details, and I will configure the build. When you force-push to the branch, your build will start. You will get a notification when the build starts, and

Re: [Mesa-dev] [PATCH mesa] drop autotools

2018-12-04 Thread Gert Wollny
Am Dienstag, den 04.12.2018, 14:47 -0500 schrieb Jan Vesely: > > > You can, that's what I've done as well. 0.49 just has a much nicer > > mechanism (and one that presumably distro packagers can use more > > easily). > > I don't understand why distros are such a big focus. Don't they all > have

Re: [Mesa-dev] [PATCH 2/2] mesa: expose EXT_texture_compression_bptc in GLES

2018-12-04 Thread Erik Faye-Lund
Nice :) For the series: Reviewed-by: Erik Faye-Lund On Tue, 2018-12-04 at 14:57 -0500, Marek Olšák wrote: > From: Marek Olšák > > tested by piglit. > > v2: rebase > > Reviewed-by: Ilia Mirkin (v1) > --- > docs/relnotes/19.0.0.html| 1 + > src/mesa/main/extensions_table.h | 1 + >

Re: [Mesa-dev] [PATCH] gallium: Android build fixes

2018-12-04 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Tue, Dec 4, 2018 at 1:51 PM Kristian H. Kristensen wrote: > A couple of simple fixes for building on Android with autotools. > --- > src/gallium/auxiliary/util/u_debug_stack_android.cpp | 2 +- > src/gallium/drivers/freedreno/Makefile.am| 1 + >

Re: [Mesa-dev] [PATCH] mesa/main: fix up _mesa_has_rg_textures for gles2

2018-12-04 Thread Erik Faye-Lund
On Tue, 2018-12-04 at 10:33 -0800, Mark Janes wrote: > Tested-by: Mark Janes > > Erik Faye-Lund writes: > > > rg-textures are supported in GLES 2.0 if EXT_texture_rg, so let's > > make > > sure the enums are accepted. > > > > Fixes: 510b6424607 "mesa/main: do not allow rg-textures enums > >

Re: [Mesa-dev] [PATCH] build: remove autotools

2018-12-04 Thread Marek Olšák
There is still the issue that DEBUG is not defined in debug builds if I set CFLAGS and CXXFLAGS. Marek ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] mesa/main: fix up _mesa_has_rg_textures for gles2

2018-12-04 Thread Erik Faye-Lund
Thanks, pushed :) On Tue, 2018-12-04 at 15:03 -0500, Marek Olšák wrote: > Reviewed-by: Marek Olšák > > Marek > > On Tue, Dec 4, 2018 at 6:51 AM Erik Faye-Lund < > erik.faye-l...@collabora.com> wrote: > > rg-textures are supported in GLES 2.0 if EXT_texture_rg, so let's > > make > > sure the

Re: [Mesa-dev] [PATCH] mesa/main: fix up _mesa_has_rg_textures for gles2

2018-12-04 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Tue, Dec 4, 2018 at 6:51 AM Erik Faye-Lund wrote: > rg-textures are supported in GLES 2.0 if EXT_texture_rg, so let's make > sure the enums are accepted. > > Fixes: 510b6424607 "mesa/main: do not allow rg-textures enums before gles3" > Bugzilla:

[Mesa-dev] [PATCH 1/2] mesa: expose EXT_texture_compression_rgtc on GLES

2018-12-04 Thread Marek Olšák
From: Marek Olšák The spec was modified to support GLES. Tested by piglit. v2: rebase Reviewed-by: Ilia Mirkin (v1) --- docs/relnotes/19.0.0.html| 1 + src/mesa/main/extensions_table.h | 2 +- src/mesa/main/glformats.c| 19 ++- src/mesa/main/texcompress.c

[Mesa-dev] [PATCH 2/2] mesa: expose EXT_texture_compression_bptc in GLES

2018-12-04 Thread Marek Olšák
From: Marek Olšák tested by piglit. v2: rebase Reviewed-by: Ilia Mirkin (v1) --- docs/relnotes/19.0.0.html| 1 + src/mesa/main/extensions_table.h | 1 + src/mesa/main/glformats.c| 13 - src/mesa/main/texcompress.c | 8 4 files changed, 22

Re: [Mesa-dev] [PATCH mesa] drop autotools

2018-12-04 Thread Jan Vesely
On Mon, 2018-12-03 at 16:17 -0800, Dylan Baker wrote: > Quoting Bas Nieuwenhuizen (2018-12-03 14:14:19) > > On Mon, Dec 3, 2018 at 7:30 PM Jan Vesely wrote: > > > On Mon, 2018-12-03 at 10:21 +, Eric Engestrom wrote: > > > > Cc: Emil Velikov > > > > Cc: Andres Gomez > > > > Cc: Juan A.

Re: [Mesa-dev] Make Jordan an Owner of the mesa project?

2018-12-04 Thread Rob Clark
On Mon, Dec 3, 2018 at 7:49 PM Jason Ekstrand wrote: > > Jordan has requested to be made an Owner of the mesa project. As much as I > may be the guy who pushed to get everything set up, I don't want to do this > sort of thing on my own. As such, I'm asking for some ACKs. If I can get 5 >

[Mesa-dev] [PATCH] gallium: Android build fixes

2018-12-04 Thread Kristian H. Kristensen
A couple of simple fixes for building on Android with autotools. --- src/gallium/auxiliary/util/u_debug_stack_android.cpp | 2 +- src/gallium/drivers/freedreno/Makefile.am| 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git

[Mesa-dev] [Bug 108943] Build fails on ppc64le with meson

2018-12-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108943 --- Comment #11 from Igor Gnatenko --- Yeah, the gnu++11 fixes problem. And also submitted https://gitlab.freedesktop.org/dbaker/mesa/issues/21. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact

Re: [Mesa-dev] [PATCH] mesa/main: fix up _mesa_has_rg_textures for gles2

2018-12-04 Thread Mark Janes
Tested-by: Mark Janes Erik Faye-Lund writes: > rg-textures are supported in GLES 2.0 if EXT_texture_rg, so let's make > sure the enums are accepted. > > Fixes: 510b6424607 "mesa/main: do not allow rg-textures enums before gles3" > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108936 >

[Mesa-dev] [PATCH 02/12] vtn: handle SpvExecutionModelKernel

2018-12-04 Thread Karol Herbst
Signed-off-by: Karol Herbst --- src/compiler/spirv/spirv_to_nir.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/compiler/spirv/spirv_to_nir.c b/src/compiler/spirv/spirv_to_nir.c index f6a7cd6c4fd..2c2dbe12a3c 100644 --- a/src/compiler/spirv/spirv_to_nir.c +++

[Mesa-dev] [PATCH 12/12] nir/spirv: handle ContractionOff execution mode

2018-12-04 Thread Karol Herbst
Signed-off-by: Karol Herbst --- src/compiler/spirv/spirv_info.h| 1 + src/compiler/spirv/spirv_info_c.py | 1 + src/compiler/spirv/spirv_to_nir.c | 9 - src/compiler/spirv/vtn_alu.c | 4 ++-- src/compiler/spirv/vtn_cfg.c | 2 ++ src/compiler/spirv/vtn_private.h | 3 +++

[Mesa-dev] [PATCH 01/12] mesa: add MESA_SHADER_KERNEL

2018-12-04 Thread Karol Herbst
used for CL kernels Signed-off-by: Karol Herbst --- src/amd/common/ac_nir_to_llvm.c| 4 ++-- src/compiler/nir/nir.c | 2 +- src/compiler/nir/nir_print.c | 7 ++- src/compiler/shader_enums.c| 5 -

[Mesa-dev] [PATCH 08/12] nir/validate: allow to check against a bitmask of bit_sizes

2018-12-04 Thread Karol Herbst
Signed-off-by: Karol Herbst --- src/compiler/nir/nir_validate.c | 34 - 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/src/compiler/nir/nir_validate.c b/src/compiler/nir/nir_validate.c index 7ee13da258d..ef24e96ee3f 100644 ---

[Mesa-dev] [PATCH 04/12] nir/spirv: improve parsing of the memory model

2018-12-04 Thread Karol Herbst
Signed-off-by: Karol Herbst --- src/compiler/nir/nir.h| 8 src/compiler/nir/nir_clone.c | 1 + src/compiler/nir/nir_serialize.c | 2 ++ src/compiler/spirv/spirv_to_nir.c | 26 ++ src/compiler/spirv/vtn_private.h | 3 +++ 5 files changed, 36

[Mesa-dev] [PATCH 11/12] nir: add support for address bit sized system values

2018-12-04 Thread Karol Herbst
Signed-off-by: Karol Herbst --- src/amd/vulkan/radv_meta_buffer.c | 8 ++-- src/amd/vulkan/radv_meta_bufimage.c| 28 +++--- src/amd/vulkan/radv_meta_clear.c | 4 +- src/amd/vulkan/radv_meta_fast_clear.c | 4 +- src/amd/vulkan/radv_meta_resolve_cs.c

[Mesa-dev] [PATCH 07/12] nir: replace more nir_load_system_value calls with builder functions

2018-12-04 Thread Karol Herbst
Signed-off-by: Karol Herbst --- src/amd/vulkan/radv_meta_bufimage.c | 12 ++-- src/amd/vulkan/radv_meta_clear.c| 4 ++-- src/amd/vulkan/radv_query.c | 4 ++-- src/gallium/auxiliary/nir/tgsi_to_nir.c | 3 +-- src/intel/compiler/brw_nir.c| 3 +-- 5

[Mesa-dev] [PATCH 03/12] nir/vtn: add caps for some cl related capabilities

2018-12-04 Thread Karol Herbst
From: Rob Clark vtn supports these, so don't squalk if user is happy with enabling these. Signed-off-by: Karol Herbst --- src/compiler/shader_info.h | 3 +++ src/compiler/spirv/spirv_to_nir.c | 17 ++--- src/compiler/spirv/vtn_variables.c | 6 -- 3 files changed, 21

[Mesa-dev] [PATCH 06/12] nir/spirv: handle SpvStorageClassCrossWorkgroup

2018-12-04 Thread Karol Herbst
Signed-off-by: Karol Herbst --- src/compiler/nir/nir.c | 4 src/compiler/nir/nir.h | 1 + src/compiler/nir/nir_print.c | 2 ++ src/compiler/spirv/vtn_private.h | 1 + src/compiler/spirv/vtn_variables.c | 4 5 files changed, 12 insertions(+) diff --git

[Mesa-dev] [PATCH 05/12] nir: rename global/local to private/function memory

2018-12-04 Thread Karol Herbst
the naming is a bit confusing no matter how you look at it. Within SPIR-V "global" memory is memory accessible from all threads. glsl "global" memory normally refers to shader thread private memory declared at global scope. As we already use "shared" for memory shared across all thrads of a work

[Mesa-dev] [PATCH 10/12] nir: add bit_size parameter to system values with multiple allowed bit sizes

2018-12-04 Thread Karol Herbst
Signed-off-by: Karol Herbst --- src/compiler/nir/nir_builder_opcodes_h.py | 14 -- src/compiler/nir/nir_lower_system_values.c| 4 ++-- src/gallium/drivers/vc4/vc4_nir_lower_blend.c | 4 ++-- 3 files changed, 16 insertions(+), 6 deletions(-) diff --git

[Mesa-dev] [PATCH 09/12] nir: add legal bit_sizes to intrinsics

2018-12-04 Thread Karol Herbst
With OpenCL some system values match the address bits, but in GLSL we also have some system values being 64 bit like subgroup masks. With this it is possible to adjust the builder functions so that depending on the bit_sizes the correct bit_size is used or an additional argument is added in case

[Mesa-dev] [PATCH 00/12] Some cleaned up Compute patches

2018-12-04 Thread Karol Herbst
Extracted some patches from my previous compute series and reworked most of them quite significantly. Most notable changes: * adding a MESA_SHADER_KERNEL to indicate a compute kernel * split physical ptrs from kernel execution model (they don't require each other) * validate bit_size of system

[Mesa-dev] [Bug 108943] Build fails on ppc64le with meson

2018-12-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108943 --- Comment #10 from Dylan Baker --- I have a similar patch in a series I'm about to send out (the debian guys ran into the same thing), but we actually need to do `host_machine.system().startswith('ppc64')` since we still support versions of

[Mesa-dev] [Bug 108943] Build fails on ppc64le with meson

2018-12-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108943 --- Comment #9 from Igor Gnatenko --- (In reply to Dylan Baker from comment #7) > I see some code in autotools we don't have an equivalent of in meson, does > adding `-Dcpp_std=gnu++11` fix this issue? It seems that autotools was building

[Mesa-dev] [Bug 108943] Build fails on ppc64le with meson

2018-12-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108943 --- Comment #8 from Igor Gnatenko --- Created attachment 142723 --> https://bugs.freedesktop.org/attachment.cgi?id=142723=edit 0001-build-correctly-check-for-ppc64le.patch Some trivial fix for correctly detecting power8. -- You are

[Mesa-dev] [Bug 108943] Build fails on ppc64le with meson

2018-12-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108943 --- Comment #7 from Dylan Baker --- I see some code in autotools we don't have an equivalent of in meson, does adding `-Dcpp_std=gnu++11` fix this issue? -- You are receiving this mail because: You are the assignee for the bug. You are the QA

[Mesa-dev] [Bug 108943] Build fails on ppc64le with meson

2018-12-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108943 --- Comment #6 from Eric Engestrom --- (In reply to Igor Gnatenko from comment #3) > > What OS are you running this on? > > Fedora Rawhide. I'm mesa maintainer in Fedora and trying to switch from > autotools to meson in our RPM package. > > >

Re: [Mesa-dev] [PATCH v2] build: remove autotools

2018-12-04 Thread Eric Engestrom
On Tuesday, 2018-12-04 09:16:18 -0800, Dylan Baker wrote: > There are now no known distributions using autotools, meson has all of > the features that autotools does. We don't need two build systems to do > exactly the same thing, meson is faster, easier to maintain, and used by > more devs than

[Mesa-dev] [Bug 107991] RX580 ~ ring gfx timeout ~ particular shaders created by a dolphin-emu game can crash AMDGPU, with both RadeonSI and RADV ~ attached apitrace for RadeonSI

2018-12-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107991 keramidasc...@gmail.com changed: What|Removed |Added CC||keramidasc...@gmail.com --

Re: [Mesa-dev] [PATCH 17/59] intel/compiler: allow extended math functions with HF operands

2018-12-04 Thread Pohjolainen, Topi
On Tue, Dec 04, 2018 at 08:16:41AM +0100, Iago Toral Quiroga wrote: > The PRM states that half-float operands are supported since gen9. > --- > src/intel/compiler/brw_eu_emit.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) Reviewed-by: Topi Pohjolainen > > diff --git

Re: [Mesa-dev] [PATCH 1/2] nir/algebraic: Rewrite bit-size inference

2018-12-04 Thread Dylan Baker
Quoting Connor Abbott (2018-12-04 01:58:28) > On Mon, Dec 3, 2018 at 11:39 PM Dylan Baker wrote: > > > > Quoting Jason Ekstrand (2018-12-03 14:12:41) > > > On Mon, Dec 3, 2018 at 3:50 PM Dylan Baker wrote: > > > > > > Quoting Connor Abbott (2018-11-29 10:32:02) > > > > Before this

Re: [Mesa-dev] [PATCH 16/59] intel/compiler: implement 16-bit fsign

2018-12-04 Thread Pohjolainen, Topi
On Tue, Dec 04, 2018 at 08:16:40AM +0100, Iago Toral Quiroga wrote: > --- > src/intel/compiler/brw_fs_nir.cpp | 27 +-- > 1 file changed, 21 insertions(+), 6 deletions(-) Reviewed-by: Topi Pohjolainen > > diff --git a/src/intel/compiler/brw_fs_nir.cpp >

Re: [Mesa-dev] [PATCH mesa] drop autotools

2018-12-04 Thread Dylan Baker
Quoting Eric Engestrom (2018-12-03 10:26:01) > On Monday, 2018-12-03 10:06:30 -0800, Dylan Baker wrote: > > Quoting Eric Engestrom (2018-12-03 09:46:29) > > > On Monday, 2018-12-03 09:25:48 -0800, Dylan Baker wrote: > > > > Can I admit I was really wanted to send this patch out and it actually >

[Mesa-dev] [PATCH v2] build: remove autotools

2018-12-04 Thread Dylan Baker
There are now no known distributions using autotools, meson has all of the features that autotools does. We don't need two build systems to do exactly the same thing, meson is faster, easier to maintain, and used by more devs than autotools. Let's reduce the ongoing burden of maintaining

[Mesa-dev] [Bug 106958] Mass Effect Andromeda renders correctly on RX480 POLARIS but BAD ON RX VEGA 64 on wine 3.10 stagingf with DXVK

2018-12-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106958 --- Comment #25 from Samuel Pitoiset --- This is with mesa 18.2.5 and LLVM 7.0.1 on Vega 56. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the

[Mesa-dev] [Bug 108943] Build fails on ppc64le with meson

2018-12-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108943 --- Comment #5 from Igor Gnatenko --- Might it be related to this meson part: if get_option('power8') != 'false' if host_machine.cpu_family() == 'ppc64le' if cc.get_id() == 'gcc' and cc.version().version_compare('< 4.8')

[Mesa-dev] [Bug 106958] Mass Effect Andromeda renders correctly on RX480 POLARIS but BAD ON RX VEGA 64 on wine 3.10 stagingf with DXVK

2018-12-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106958 --- Comment #24 from Samuel Pitoiset --- Can't be reproduced on my side, what llvm are you using? -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the

[Mesa-dev] [Bug 108943] Build fails on ppc64le with meson

2018-12-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108943 --- Comment #4 from Igor Gnatenko --- (In reply to Eric Engestrom from comment #1) > This sounds like one of your system headers is #define'ing `vector` as > `__attribute__((something))`, but if that's the case then good luck > compiling *any*

Re: [Mesa-dev] [PATCH v4 5/5] intel/tools: make sure the binary file is properly read

2018-12-04 Thread Eric Engestrom
On Tuesday, 2018-12-04 15:36:28 +0200, andrey simiklit wrote: > Hello, > > I'm sorry for disturbing, could I ask you to push this patch if it > possible? ))) Sorry yes, thanks for the reminder :) I just pushed it! > > Regards, > Andrii. > > On Fri, Nov 30, 2018 at 6:19 PM andrey simiklit >

Re: [Mesa-dev] Make Jordan an Owner of the mesa project?

2018-12-04 Thread Jose Fonseca
ACK. Jose From: Jason Ekstrand Sent: Tuesday, December 4, 2018 00:48 To: ML mesa-dev Cc: Nicolai Hähnle; Ian Romanick; Ilia Mirkin; Dave Airlie; Kenneth Graunke; Matt Turner; Brian Paul; Jose Fonseca; Eric Anholt; Marek Olšák; Rob Clark Subject: Make Jordan

Re: [Mesa-dev] [PATCH] radv: fix vkCmdCopyQueryoolResults() for timestamp queries

2018-12-04 Thread Alex Smith
Tested-by: Alex Smith Thanks! s/Queryool/QueryPool/ in the subject, btw. On Tue, 4 Dec 2018 at 15:52, Samuel Pitoiset wrote: > Because WAIT_REG_MEM can only wait for a 32-bit value, it's not > safe to use it for timestamp queries. If we only wait on the low > 32 bits of a timestamp query we

Re: [Mesa-dev] [PATCH 12/59] intel/compiler: handle b2i/b2f with other integer conversion opcodes

2018-12-04 Thread Pohjolainen, Topi
On Tue, Dec 04, 2018 at 08:16:36AM +0100, Iago Toral Quiroga wrote: > Since we handle booleans as integers this makes more sense. If this is applied before patch 10, can we merge 10 and 13? > --- > src/intel/compiler/brw_fs_nir.cpp | 10 +- > 1 file changed, 5 insertions(+), 5

Re: [Mesa-dev] [Mesa-stable] [PATCH] mesa: Revert INTEL_fragment_shader_ordering support

2018-12-04 Thread Juan A. Suarez Romero
On Tue, 2018-12-04 at 07:47 -0800, Matt Turner wrote: > On Tue, Dec 4, 2018 at 3:15 AM Juan A. Suarez Romero > wrote: > > On Mon, 2018-12-03 at 15:38 -0800, Matt Turner wrote: > > > On Mon, Dec 3, 2018 at 8:12 AM Emil Velikov > > > wrote: > > > > On Thu, 29 Nov 2018 at 23:54, Matt Turner

[Mesa-dev] [Bug 106958] Mass Effect Andromeda renders correctly on RX480 POLARIS but BAD ON RX VEGA 64 on wine 3.10 stagingf with DXVK

2018-12-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106958 --- Comment #23 from egon2003 --- Created attachment 142721 --> https://bugs.freedesktop.org/attachment.cgi?id=142721=edit Screenshot with glitch -- You are receiving this mail because: You are the QA Contact for the bug. You are the

[Mesa-dev] [Bug 106958] Mass Effect Andromeda renders correctly on RX480 POLARIS but BAD ON RX VEGA 64 on wine 3.10 stagingf with DXVK

2018-12-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106958 --- Comment #22 from egon2003 --- I forgot i had played a few minutes. When you start a new game the first time you get an option to choose something I see the issue the first time. See attached screenshot. -- You are receiving this mail

Re: [Mesa-dev] [PATCH 10/59] intel/compiler: implement conversions from 16-bit float to 64-bit

2018-12-04 Thread Pohjolainen, Topi
On Tue, Dec 04, 2018 at 02:33:25PM +0200, Pohjolainen, Topi wrote: > On Tue, Dec 04, 2018 at 08:16:34AM +0100, Iago Toral Quiroga wrote: > > Signed-off-by: Samuel Iglesias Gonsálvez > > --- > > src/intel/compiler/brw_fs_nir.cpp | 41 +++ > > 1 file changed, 41

[Mesa-dev] [Bug 108943] Build fails on ppc64le with meson

2018-12-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108943 --- Comment #3 from Igor Gnatenko --- > What OS are you running this on? Fedora Rawhide. I'm mesa maintainer in Fedora and trying to switch from autotools to meson in our RPM package. > and what toolchain? GCC, the standard one in Fedora ;)

[Mesa-dev] [Bug 106958] Mass Effect Andromeda renders correctly on RX480 POLARIS but BAD ON RX VEGA 64 on wine 3.10 stagingf with DXVK

2018-12-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106958 --- Comment #21 from egon2003 --- Great! I see the issue the first time I get control in the game after starting a new game when looking at certain objects. In the starting scene there is a doctor t perro and the head of the character i just a

[Mesa-dev] [Bug 108943] Build fails on ppc64le with meson

2018-12-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108943 --- Comment #2 from Eric Engestrom --- (In reply to Eric Engestrom from comment #1) > What OS are you running this on? and what toolchain? -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for

[Mesa-dev] [Bug 108943] Build fails on ppc64le with meson

2018-12-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108943 --- Comment #1 from Eric Engestrom --- This sounds like one of your system headers is #define'ing `vector` as `__attribute__((something))`, but if that's the case then good luck compiling *any* C++ code :/ Can you confirm this by adding this

Re: [Mesa-dev] [PATCH] radv: rework the TC-compat HTILE hardware bug with COND_EXEC

2018-12-04 Thread Samuel Pitoiset
On 12/3/18 11:21 PM, Bas Nieuwenhuizen wrote: On Mon, Dec 3, 2018 at 11:13 PM Samuel Pitoiset wrote: After investigating on this, it appears that COND_WRITE doesn't work correctly in some situations. I don't know exactly why does it fail to update DB_Z_INFO.ZRANGE_PRECISION, but as AMDVLK

[Mesa-dev] [PATCH] radv: fix vkCmdCopyQueryoolResults() for timestamp queries

2018-12-04 Thread Samuel Pitoiset
Because WAIT_REG_MEM can only wait for a 32-bit value, it's not safe to use it for timestamp queries. If we only wait on the low 32 bits of a timestamp query we could be unlucky and the GPU might hang. One possible fix is to emit a full end of pipe event and wait on a 32-bit value which is

[Mesa-dev] [Bug 108925] vkCmdCopyQueryPoolResults(VK_QUERY_RESULT_WAIT_BIT) for timestamps with large query count hangs

2018-12-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108925 --- Comment #4 from Samuel Pitoiset --- Can you try this patch https://patchwork.freedesktop.org/series/53482/ ? -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the

Re: [Mesa-dev] [Mesa-stable] [PATCH] mesa: Revert INTEL_fragment_shader_ordering support

2018-12-04 Thread Matt Turner
On Tue, Dec 4, 2018 at 3:15 AM Juan A. Suarez Romero wrote: > > On Mon, 2018-12-03 at 15:38 -0800, Matt Turner wrote: > > On Mon, Dec 3, 2018 at 8:12 AM Emil Velikov > > wrote: > > > On Thu, 29 Nov 2018 at 23:54, Matt Turner wrote: > > > > This extension is not properly tested (testing for > >

Re: [Mesa-dev] GitLab merge requests, discussion summary - Re: [PATCH] docs: Document optional GitLab code review process

2018-12-04 Thread Brian Paul
On 12/03/2018 06:50 PM, Jordan Justen wrote: > Lots of discussion here. :) I hoped to just dip our toes into the > merge request stream, but the consensus is clearly against my idea. Oh > well. :) > > Here's what I gathered from the discussion: > > == Keep email, allow duplicate MR, my idea == >

Re: [Mesa-dev] Make Jordan an Owner of the mesa project?

2018-12-04 Thread Brian Paul
Me too. -Brian On 12/04/2018 07:57 AM, Nicolai Hähnle wrote: > +1 > > On 04.12.18 08:26, Marek Olšák wrote: >> Ack. >> >> On Mon, Dec 3, 2018, 7:49 PM Jason Ekstrand > wrote: >> >>     Jordan has requested to be made an Owner of the mesa project.  As >>     much as

Re: [Mesa-dev] [PATCH] wayland/egl: Ensure EGL surface is resized on DRI update_buffers()

2018-12-04 Thread Carlos Garnacho
Hi!, On Mon, Dec 3, 2018 at 7:02 PM Juan A. Suarez Romero wrote: > > On Mon, 2018-12-03 at 17:08 +, Emil Velikov wrote: > > Hi Carlos, > > > > On Mon, 3 Dec 2018 at 08:09, Carlos Garnacho wrote: > > > Fullscreening and unfullscreening a totem window while playing a video > > > sometimes

  1   2   >