Re: [Mesa-dev] last call for autotools

2018-12-11 Thread Rhys Kidd
On Tue, 11 Dec 2018 at 16:46, Emil Velikov wrote: > On Tue, 11 Dec 2018 at 19:49, Dylan Baker wrote: > > > > Quoting Emil Velikov (2018-12-11 10:48:56) > > > On Tue, 11 Dec 2018 at 18:18, Eric Anholt wrote: > > > > > > > > Emil Velikov writes: > > > > > > > > > On Mon, 10 Dec 2018 at 23:11,

[Mesa-dev] [RFC PATCH 3/5] travis: radeonsi and radv require LLVM 7.0 (meson)

2018-12-11 Thread Rhys Kidd
Signed-off-by: Rhys Kidd --- .travis.yml | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/.travis.yml b/.travis.yml index 60ef236e7be..070c9ef6773 100644 --- a/.travis.yml +++ b/.travis.yml @@ -81,20 +81,21 @@ matrix: - VULKAN_DRIVERS="" -

[Mesa-dev] [RFC PATCH 5/5] meson: libfreedreno depends upon libdrm (for fence support)

2018-12-11 Thread Rhys Kidd
Error message building freedreno Gallium driver with meson: ../src/gallium/drivers/freedreno/freedreno_fence.c:27:21: fatal error: libsync.h: No such file or directory \#include Signed-off-by: Rhys Kidd --- src/gallium/drivers/freedreno/meson.build | 4 +--- 1 file changed, 1

[Mesa-dev] [RFC PATCH 2/5] travis: Add libclc-dev, clang and libclang-dev dependencies of clover

2018-12-11 Thread Rhys Kidd
Fixes: 98a3f027aaf ("travis: enable nine and clover") Signed-off-by: Rhys Kidd --- .travis.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.travis.yml b/.travis.yml index aec1b001083..60ef236e7be 100644 --- a/.travis.yml +++ b/.travis.yml @@ -90,8 +90,11 @@ matrix: #

[Mesa-dev] [RFC PATCH 1/5] travis: fix python3.5 dependency for "meson Gallium Drivers"

2018-12-11 Thread Rhys Kidd
Error message: $ if test "x$BUILD" = xmeson; then sudo update-alternatives --install /usr/bin/python3 python3 /usr/bin/python3.5 10; pip3 install --user meson; pip3 install --user mako; fi update-alternatives: error: alternative path /usr/bin/python3.5 doesn't exist Downloading/unpacking

[Mesa-dev] [RFC PATCH 0/5] last call for autotools (meson travis fixes)

2018-12-11 Thread Rhys Kidd
Emil and Dylan, I took a go at addressing the limited number of remaining meson-based travis-ci errors. This series applies on top of the work Dylan circulated yesterday, and which can be seen here: > Could you help me debug my WIP of porting the autotools tests > to meson? They're just

[Mesa-dev] [RFC PATCH 4/5] travis: delete remaining scons residuals

2018-12-11 Thread Rhys Kidd
Fixes: 53d5129ded5 ("delete me: remove scons") Signed-off-by: Rhys Kidd --- .travis.yml | 12 1 file changed, 12 deletions(-) diff --git a/.travis.yml b/.travis.yml index 070c9ef6773..442afea3a74 100644 --- a/.travis.yml +++ b/.travis.yml @@ -138,12 +138,6 @@ install: pip3

Re: [Mesa-dev] [PATCH v3] mesa: Fix GLES2 OES float texture framebuffer rendering.

2018-12-11 Thread Tapani Pälli
On 12/12/18 8:42 AM, Tapani Pälli wrote: On 12/12/18 5:05 AM, Nick Kreeger wrote: This change enables GLES2 to render float/half-float textures to a framebuffer when the appropriate OES extensions are available. This commit regressed OES GLES2 float texture rendering:

[Mesa-dev] [PATCH 01/10] i965: Move down genX_upload_sbe in profiles.

2018-12-11 Thread Mathias . Froehlich
From: Mathias Fröhlich Avoid looping over all VARYING_SLOT_MAX urb_setup array entries from genX_upload_sbe. Prepare an array indirection to the active entries of urb_setup already in the compile step. On upload only walk the active arrays. v2: Use uint8_t to store the attribute numbers.

[Mesa-dev] [PATCH 03/10] i965: Split merge_inputs and clear_buffers.

2018-12-11 Thread Mathias . Froehlich
From: Mathias Fröhlich The merge_inputs function handles that part that changes when the inputs change. The clear_buffers function triggers when we may need a new upload. Thus the merge_inputs can be limited to be once per brw_draw_prims. Signed-off-by: Mathias Fröhlich ---

[Mesa-dev] [PATCH 06/10] mesa: Remove now unused _mesa_draw_attrib_and_binding.

2018-12-11 Thread Mathias . Froehlich
From: Mathias Fröhlich Signed-off-by: Mathias Fröhlich --- src/mesa/main/arrayobj.h | 19 --- 1 file changed, 19 deletions(-) diff --git a/src/mesa/main/arrayobj.h b/src/mesa/main/arrayobj.h index ee87b4b6ba..49b3522f30 100644 --- a/src/mesa/main/arrayobj.h +++

[Mesa-dev] [PATCH 08/10] mesa: Provide gl_vertex_format accessors.

2018-12-11 Thread Mathias . Froehlich
From: Mathias Fröhlich Provide the same set of VAO and current value gl_vertex_format accessor functions like we have for the gl_array_attributes. For most purpose the vertex format is what we need. Signed-off-by: Mathias Fröhlich --- src/mesa/main/arrayobj.h | 21 + 1

[Mesa-dev] [PATCH 09/10] i965: Make use of the vertex format functions in i965.

2018-12-11 Thread Mathias . Froehlich
From: Mathias Fröhlich Signed-off-by: Mathias Fröhlich --- src/mesa/drivers/dri/i965/brw_draw.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_draw.c b/src/mesa/drivers/dri/i965/brw_draw.c index 6e4a0a0213..e0d17cd449 100644 ---

[Mesa-dev] [PATCH 05/10] i965: Remove glbinding from brw_vertex_element.

2018-12-11 Thread Mathias . Froehlich
From: Mathias Fröhlich Signed-off-by: Mathias Fröhlich --- src/mesa/drivers/dri/i965/brw_context.h | 1 - src/mesa/drivers/dri/i965/brw_draw.c| 7 --- 2 files changed, 8 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_context.h b/src/mesa/drivers/dri/i965/brw_context.h index

[Mesa-dev] [PATCH 07/10] mesa: Remove now unused _mesa_draw_attrib.

2018-12-11 Thread Mathias . Froehlich
From: Mathias Fröhlich Signed-off-by: Mathias Fröhlich --- src/mesa/main/arrayobj.h | 15 --- 1 file changed, 15 deletions(-) diff --git a/src/mesa/main/arrayobj.h b/src/mesa/main/arrayobj.h index 49b3522f30..55d233befb 100644 --- a/src/mesa/main/arrayobj.h +++

[Mesa-dev] [PATCH 04/10] i965: Reorder workaround flags computation.

2018-12-11 Thread Mathias . Froehlich
From: Mathias Fröhlich Vertex processing workaround flags can be split into array and current vertex attributes. By that we can use specific access functions for these different vertex attribute kinds. This finally obsoletes some access functions that I introduced last winter for a smooth

[Mesa-dev] [PATCH 02/10] i965: Use the VAOs binding information in array setup.

2018-12-11 Thread Mathias . Froehlich
From: Mathias Fröhlich The change basically reimplements array setup by walking the gl_contex::Array._DrawVAO on a per binding sequence. In this way we can make direct use of the application provided minimum set of buffer objects and emit fewer relocs. v2: Rebase onto: compiler: Move

[Mesa-dev] [PATCH 00/10] Make use of VAO information in i965 v4.

2018-12-11 Thread Mathias . Froehlich
From: Mathias Fröhlich Hi all, The following series is a resend from last spring with some rebasing on the way. This change finally makes use of the binding/attribute information now present in the VAO. The big part is basically a rewrite of brw_draw_upload in a way that traverses in an outer

Re: [Mesa-dev] [PATCH v3] mesa: Fix GLES2 OES float texture framebuffer rendering.

2018-12-11 Thread Tapani Pälli
On 12/12/18 5:05 AM, Nick Kreeger wrote: This change enables GLES2 to render float/half-float textures to a framebuffer when the appropriate OES extensions are available. This commit regressed OES GLES2 float texture rendering:

Re: [Mesa-dev] [PATCH] nir: Document the function inlining process

2018-12-11 Thread Matt Turner
Thanks. This was very useful for me in the fp64 work. Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 109023] error: inlining failed in call to always_inline ‘__m512 _mm512_and_ps(__m512, __m512)’: target specific option mismatch

2018-12-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109023 Bug ID: 109023 Summary: error: inlining failed in call to always_inline ‘__m512 _mm512_and_ps(__m512, __m512)’: target specific option mismatch Product: Mesa

Re: [Mesa-dev] [PATCH] genxml: Consistently use a numeric "MOCS" field

2018-12-11 Thread Jordan Justen
Reviewed-by: Jordan Justen On 2018-12-11 20:23:06, Kenneth Graunke wrote: > When we first started using genxml, we decided to represent MOCS as an > actual structure, and pack values. However, in many places, it was more > convenient to use a numeric value rather than treating it as a struct, >

Re: [Mesa-dev] [PATCH 4/4] virgl: work around bad assumptions in virglrenderer

2018-12-11 Thread Mathias Fröhlich
Erik, On Tuesday, 11 December 2018 15:29:49 CET Erik Faye-Lund wrote: > On Tue, 2018-12-11 at 15:26 +0100, Erik Faye-Lund wrote: > > Virglrenderer does the wrong thing when given an instance divisor; > > it tries to use the element-index rather than the binding-index as > > the argument to

[Mesa-dev] [PATCH] mesa: ES2 glReadPixels support for OES float extensions.

2018-12-11 Thread Nick Kreeger
The OES extensions for float/half-float allow glReadPixels to read GL_RGBA values as GL_FLOAT for both floats and half-floats. This patch ensures that ES2 context versions allows this if at least one of the extensions is present. --- src/mesa/main/readpix.c | 3 ++- 1 file changed, 2

[Mesa-dev] [Bug 108946] High memory usage in Black Mesa

2018-12-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108946 Ian Romanick changed: What|Removed |Added Status|NEW |NEEDINFO CC|

Re: [Mesa-dev] [PATCH] nir: Document the function inlining process

2018-12-11 Thread Karol Herbst
sorry, totally forgot about that. Seems fine as it is and I have the same within my CL branch (except the last nir_lower_constant_initializers). as I don't really know if all that is actually true, but because it makes sense to me: Acked-by: Karol Herbst I kind of wished we would have a helper

[Mesa-dev] [PATCH] genxml: Consistently use a numeric "MOCS" field

2018-12-11 Thread Kenneth Graunke
When we first started using genxml, we decided to represent MOCS as an actual structure, and pack values. However, in many places, it was more convenient to use a numeric value rather than treating it as a struct, so we added secondary setters in a bunch of places as well. We were not entirely

Re: [Mesa-dev] [PATCH] intel/blorp: Assert that we don't re-layout a compressed surface

2018-12-11 Thread Jason Ekstrand
ping On Thu, Apr 5, 2018 at 12:50 PM Jason Ekstrand wrote: > --- > src/intel/blorp/blorp_blit.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/src/intel/blorp/blorp_blit.c b/src/intel/blorp/blorp_blit.c > index 0757db0..0f9ecb3 100644 > --- a/src/intel/blorp/blorp_blit.c > +++

Re: [Mesa-dev] [PATCH] nir: Document the function inlining process

2018-12-11 Thread Jason Ekstrand
ping On Mon, Oct 29, 2018 at 12:14 PM Jason Ekstrand wrote: > This has thrown a few people off recently and it's good to have the > process and all the rational for it documented somewhere. A comment at > the top of nir_inline_functions seems as good a place as any. > > Cc: Matt Turner > Cc:

Re: [Mesa-dev] [PATCH v2] mesa: Fix GLES2 OES float texture framebuffer rendering.

2018-12-11 Thread Nick Kreeger
Please ignore this patch - I accidentally had my conditionals backwards for half/float float extension checking. The V3 patch is the main one. On Tue, Dec 11, 2018 at 7:02 PM Nick Kreeger wrote: > This change enables GLES2 to render float/half-float textures to a > framebuffer when the

[Mesa-dev] [PATCH v3] mesa: Fix GLES2 OES float texture framebuffer rendering.

2018-12-11 Thread Nick Kreeger
This change enables GLES2 to render float/half-float textures to a framebuffer when the appropriate OES extensions are available. This commit regressed OES GLES2 float texture rendering: https://gitlab.freedesktop.org/mesa/mesa/commit/e333035c47a6a4cc88f0f9ca2bced500538bebae ---

[Mesa-dev] [PATCH v2] mesa: Fix GLES2 OES float texture framebuffer rendering.

2018-12-11 Thread Nick Kreeger
This change enables GLES2 to render float/half-float textures to a framebuffer when the appropriate OES extensions are available. This commit regressed OES GLES2 float texture rendering: https://gitlab.freedesktop.org/mesa/mesa/commit/e333035c47a6a4cc88f0f9ca2bced500538bebae ---

Re: [Mesa-dev] [PATCH v2] docs: Document GitLab merge request process (email alternative)

2018-12-11 Thread Jason Ekstrand
On Tue, Dec 11, 2018 at 8:15 PM Ian Romanick wrote: > It's fairly common for Mesa developers to have several patch series on > the mailing list at a time. I believe most people will author these as > a continuous stream with either implicit dependencies (i.e., commit > messages in the second

Re: [Mesa-dev] [PATCH] etnaviv: fix resource usage tracking across different pipe_context's

2018-12-11 Thread Marek Vasut
On 12/11/2018 10:40 PM, Lukas F. Hartmann wrote: > Hi, Hi, > I tested the patch on i.MX6QP with: > Linux reform 4.20.0-rc2-00133-g1ce80e0fe98e-dirty #10 SMP Mon Nov 26 > 02:02:42 CET 2018 armv7l GNU/Linux > > Running a recent Xorg built from source with modesetting driver and > etnaviv. > > I

Re: [Mesa-dev] [PATCH v2] docs: Document GitLab merge request process (email alternative)

2018-12-11 Thread Ian Romanick
It's fairly common for Mesa developers to have several patch series on the mailing list at a time. I believe most people will author these as a continuous stream with either implicit dependencies (i.e., commit messages in the second series with shader-db results that are impacted by the first

Re: [Mesa-dev] [PATCH v2] docs: Document GitLab merge request process (email alternative)

2018-12-11 Thread Rob Clark
On Tue, Dec 11, 2018 at 7:06 PM Jason Ekstrand wrote: > > Ping? > > I see about 5 acks/reviews, 3 of which are from Intel which doesn't exactly > seem like overwhelming consensus. However, we also haven't had any debate in > a while. > > I know some people are somewhat skeptical as to how well

Re: [Mesa-dev] [PATCH v2] docs: Document GitLab merge request process (email alternative)

2018-12-11 Thread Bas Nieuwenhuizen
On Wed, Dec 12, 2018 at 1:06 AM Jason Ekstrand wrote: > > Ping? > > I see about 5 acks/reviews, 3 of which are from Intel which doesn't exactly > seem like overwhelming consensus. However, we also haven't had any debate in > a while. FWIW, I'm fine with it too. Acked-by: Bas Nieuwenhuizen

Re: [Mesa-dev] [RFC PATCH 12/14] anv/allocator: Rework chunk return to the state pool.

2018-12-11 Thread Jason Ekstrand
On Tue, Dec 11, 2018 at 5:31 PM Rafael Antognolli < rafael.antogno...@intel.com> wrote: > On Mon, Dec 10, 2018 at 11:10:02PM -0600, Jason Ekstrand wrote: > > > > > > On Mon, Dec 10, 2018 at 5:48 PM Rafael Antognolli < > rafael.antogno...@intel.com> > > wrote: > > > > On Mon, Dec 10, 2018 at

Re: [Mesa-dev] [PATCH v2] docs: Document GitLab merge request process (email alternative)

2018-12-11 Thread Jason Ekstrand
Ping? I see about 5 acks/reviews, 3 of which are from Intel which doesn't exactly seem like overwhelming consensus. However, we also haven't had any debate in a while. I know some people are somewhat skeptical as to how well it will work but they won't be able to see until we actually start

Re: [Mesa-dev] [PATCH 4/6] mesa/st: wire up DiscardSubFramebuffer

2018-12-11 Thread Ilia Mirkin
On Tue, Dec 11, 2018 at 6:34 PM Rob Clark wrote: > > On Tue, Dec 11, 2018 at 6:10 PM Ilia Mirkin wrote: > > > > On Tue, Dec 11, 2018 at 5:50 PM Rob Clark wrote: > > > > > > Signed-off-by: Rob Clark > > > --- > > > src/gallium/include/pipe/p_context.h | 11 +++ > > >

Re: [Mesa-dev] [PATCH 1/6] mesa: wire up InvalidateFramebuffer

2018-12-11 Thread Ian Romanick
On 12/11/18 3:15 PM, Rob Clark wrote: > On Tue, Dec 11, 2018 at 6:06 PM Ian Romanick wrote: >> >> On 12/11/18 2:50 PM, Rob Clark wrote: >>> And before someone actually starts implementing DiscardFramebuffer() >>> lets rework the interface to something that is actually usable. >>> >>>

Re: [Mesa-dev] [PATCH 4/6] mesa/st: wire up DiscardSubFramebuffer

2018-12-11 Thread Rob Clark
On Tue, Dec 11, 2018 at 6:10 PM Ilia Mirkin wrote: > > On Tue, Dec 11, 2018 at 5:50 PM Rob Clark wrote: > > > > Signed-off-by: Rob Clark > > --- > > src/gallium/include/pipe/p_context.h | 11 +++ > > src/mesa/state_tracker/st_cb_fbo.c | 26 ++ > > 2 files

Re: [Mesa-dev] [RFC PATCH 10/14] anv: Add clflush to states.

2018-12-11 Thread Jason Ekstrand
On Tue, Dec 11, 2018 at 5:32 PM Rafael Antognolli < rafael.antogno...@intel.com> wrote: > On Mon, Dec 10, 2018 at 01:52:15PM -0600, Jason Ekstrand wrote: > > This seems very much over-the-top. It would be better to either find the > > specific bug or else just allocate the BOs we use for states

Re: [Mesa-dev] [RFC PATCH 10/14] anv: Add clflush to states.

2018-12-11 Thread Rafael Antognolli
On Mon, Dec 10, 2018 at 01:52:15PM -0600, Jason Ekstrand wrote: > This seems very much over-the-top. It would be better to either find the > specific bug or else just allocate the BOs we use for states as snooped. See > also the anv_gem_set_caching call in genX_query.c. It seems we were missing

Re: [Mesa-dev] [PATCH 4/6] mesa/st: wire up DiscardSubFramebuffer

2018-12-11 Thread Rob Clark
On Tue, Dec 11, 2018 at 6:08 PM Roland Scheidegger wrote: > > Am 11.12.18 um 23:50 schrieb Rob Clark: > > Signed-off-by: Rob Clark > > --- > > src/gallium/include/pipe/p_context.h | 11 +++ > > src/mesa/state_tracker/st_cb_fbo.c | 26 ++ > > 2 files changed, 37

Re: [Mesa-dev] [RFC PATCH 12/14] anv/allocator: Rework chunk return to the state pool.

2018-12-11 Thread Rafael Antognolli
On Mon, Dec 10, 2018 at 11:10:02PM -0600, Jason Ekstrand wrote: > > > On Mon, Dec 10, 2018 at 5:48 PM Rafael Antognolli > > wrote: > > On Mon, Dec 10, 2018 at 04:56:40PM -0600, Jason Ekstrand wrote: > > On Fri, Dec 7, 2018 at 6:06 PM Rafael Antognolli < >

Re: [Mesa-dev] [PATCH 2/6] mesa: wire up InvalidateSubFramebuffer

2018-12-11 Thread Rob Clark
On Tue, Dec 11, 2018 at 6:16 PM Ian Romanick wrote: > > On 12/11/18 2:50 PM, Rob Clark wrote: > > Signed-off-by: Rob Clark > > --- > > src/mesa/main/dd.h | 3 +++ > > src/mesa/main/fbobject.c | 34 +- > > 2 files changed, 36 insertions(+), 1 deletion(-) >

Re: [Mesa-dev] [PATCH 1/6] mesa: wire up InvalidateFramebuffer

2018-12-11 Thread Rob Clark
On Tue, Dec 11, 2018 at 6:06 PM Ian Romanick wrote: > > On 12/11/18 2:50 PM, Rob Clark wrote: > > And before someone actually starts implementing DiscardFramebuffer() > > lets rework the interface to something that is actually usable. > > > > Signed-off-by: Rob Clark > > --- > >

Re: [Mesa-dev] [PATCH 2/6] mesa: wire up InvalidateSubFramebuffer

2018-12-11 Thread Ian Romanick
On 12/11/18 2:50 PM, Rob Clark wrote: > Signed-off-by: Rob Clark > --- > src/mesa/main/dd.h | 3 +++ > src/mesa/main/fbobject.c | 34 +- > 2 files changed, 36 insertions(+), 1 deletion(-) > > diff --git a/src/mesa/main/dd.h b/src/mesa/main/dd.h > index

Re: [Mesa-dev] [PATCH 4/6] mesa/st: wire up DiscardSubFramebuffer

2018-12-11 Thread Ilia Mirkin
On Tue, Dec 11, 2018 at 5:50 PM Rob Clark wrote: > > Signed-off-by: Rob Clark > --- > src/gallium/include/pipe/p_context.h | 11 +++ > src/mesa/state_tracker/st_cb_fbo.c | 26 ++ > 2 files changed, 37 insertions(+) > > diff --git

Re: [Mesa-dev] [PATCH 4/6] mesa/st: wire up DiscardSubFramebuffer

2018-12-11 Thread Roland Scheidegger
Am 11.12.18 um 23:50 schrieb Rob Clark: > Signed-off-by: Rob Clark > --- > src/gallium/include/pipe/p_context.h | 11 +++ > src/mesa/state_tracker/st_cb_fbo.c | 26 ++ > 2 files changed, 37 insertions(+) > > diff --git a/src/gallium/include/pipe/p_context.h >

Re: [Mesa-dev] [PATCH 2/6] mesa: wire up InvalidateSubFramebuffer

2018-12-11 Thread Ian Romanick
On 12/11/18 2:50 PM, Rob Clark wrote: > Signed-off-by: Rob Clark > --- > src/mesa/main/dd.h | 3 +++ > src/mesa/main/fbobject.c | 34 +- > 2 files changed, 36 insertions(+), 1 deletion(-) > > diff --git a/src/mesa/main/dd.h b/src/mesa/main/dd.h > index

Re: [Mesa-dev] [PATCH 1/6] mesa: wire up InvalidateFramebuffer

2018-12-11 Thread Ian Romanick
On 12/11/18 2:50 PM, Rob Clark wrote: > And before someone actually starts implementing DiscardFramebuffer() > lets rework the interface to something that is actually usable. > > Signed-off-by: Rob Clark > --- > src/mesa/main/dd.h | 5 +-- > src/mesa/main/fbobject.c | 79

Re: [Mesa-dev] [PATCH] gallium/aux: add is_unorm() helper

2018-12-11 Thread Ilia Mirkin
I was talking about Z24X8, which Roland confirmed would return true here. I guess that's fine, but worth pointing out perhaps. On Tue, Dec 11, 2018 at 5:48 PM Rob Clark wrote: > > The z24s8 permutations are is_mixed, the x24s8 permutations are not > and will show up as is_unorm() (would have been

Re: [Mesa-dev] [PATCH 3/6] mesa/st: wire up DiscardFramebuffer

2018-12-11 Thread Roland Scheidegger
Am 11.12.18 um 23:50 schrieb Rob Clark: > pipe_context::invalidate_resource() is so *almost* what we want, but > with FBOs the fb can be a single layer/level of a pipe_resource, which > makes ::invalidate_resource() not expressive enough. > > Signed-off-by: Rob Clark > --- >

Re: [Mesa-dev] [PATCH] gallium/aux: add is_unorm() helper

2018-12-11 Thread Roland Scheidegger
Am 11.12.18 um 22:21 schrieb Ilia Mirkin: > So ... Z24 will end up with is_unorm() == true? [Just guessing -- > assume it doesn't hae is_mixed == true.] Z24X8 would return true, but Z24S8 would return false. (If you didn't want that I guess you could check for colorspace.) > Also, does RGB10A2

[Mesa-dev] [PATCH 5/6] mesa/st: use invalidate_sub_surface() for scissored clears

2018-12-11 Thread Rob Clark
Now that we have pipe_context::invalidate_sub_surface(), we can also use this to hint to driver about scissored clears (which use draw_vbo()). This is useful in particular for tilers because the driver can avoid bringing (some) tiles back into the tile buffer from system memory. Signed-off-by:

[Mesa-dev] [PATCH 1/6] mesa: wire up InvalidateFramebuffer

2018-12-11 Thread Rob Clark
And before someone actually starts implementing DiscardFramebuffer() lets rework the interface to something that is actually usable. Signed-off-by: Rob Clark --- src/mesa/main/dd.h | 5 +-- src/mesa/main/fbobject.c | 79 ++-- 2 files changed, 77

[Mesa-dev] [PATCH 3/6] mesa/st: wire up DiscardFramebuffer

2018-12-11 Thread Rob Clark
pipe_context::invalidate_resource() is so *almost* what we want, but with FBOs the fb can be a single layer/level of a pipe_resource, which makes ::invalidate_resource() not expressive enough. Signed-off-by: Rob Clark --- src/gallium/include/pipe/p_context.h | 8

[Mesa-dev] [PATCH 6/6] freedreno: support invalidate_{sub_}surface

2018-12-11 Thread Rob Clark
Signed-off-by: Rob Clark --- src/gallium/drivers/freedreno/a6xx/fd6_gmem.c | 3 +- .../drivers/freedreno/freedreno_batch.c | 1 + .../drivers/freedreno/freedreno_batch.h | 8 +- .../drivers/freedreno/freedreno_draw.c| 99 ---

[Mesa-dev] [PATCH 4/6] mesa/st: wire up DiscardSubFramebuffer

2018-12-11 Thread Rob Clark
Signed-off-by: Rob Clark --- src/gallium/include/pipe/p_context.h | 11 +++ src/mesa/state_tracker/st_cb_fbo.c | 26 ++ 2 files changed, 37 insertions(+) diff --git a/src/gallium/include/pipe/p_context.h b/src/gallium/include/pipe/p_context.h index

[Mesa-dev] [PATCH 2/6] mesa: wire up InvalidateSubFramebuffer

2018-12-11 Thread Rob Clark
Signed-off-by: Rob Clark --- src/mesa/main/dd.h | 3 +++ src/mesa/main/fbobject.c | 34 +- 2 files changed, 36 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/dd.h b/src/mesa/main/dd.h index 1214eeaa474..c7112677223 100644 --- a/src/mesa/main/dd.h

Re: [Mesa-dev] [PATCH 10/12] virgl: modify how we handle GL_MAP_FLUSH_EXPLICIT_BIT

2018-12-11 Thread Elie Tournier
On Mon, Dec 10, 2018 at 10:20:36AM -0800, Gurchetan Singh wrote: > Previously, we ignored the the glUnmap(..) operation and > flushed before we flush the cbuf. Now, let's just flush > the data when we unmap. > > Neither method is optimal, for example: > > glMapBufferRange(.., 0, 100,

Re: [Mesa-dev] [PATCH] gallium/aux: add is_unorm() helper

2018-12-11 Thread Rob Clark
The z24s8 permutations are is_mixed, the x24s8 permutations are not and will show up as is_unorm() (would have been an issue for is_snorm() too except they are unsigned) The 10_10_10_2 formats are not mixed. In either case, I'm not sure is_norm() returning true is *incorrect*.. BR, -R On Tue,

[Mesa-dev] [Bug 108946] High memory usage in Black Mesa

2018-12-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108946 --- Comment #5 from Justin Mitzel --- Created attachment 142782 --> https://bugs.freedesktop.org/attachment.cgi?id=142782=edit BMS apitrace with -dev argument -dev option creates static image on the menu-screen instead of an active scene

Re: [Mesa-dev] [PATCH] etnaviv: fix resource usage tracking across different pipe_context's

2018-12-11 Thread Lukas F. Hartmann
Hi, I tested the patch on i.MX6QP with: Linux reform 4.20.0-rc2-00133-g1ce80e0fe98e-dirty #10 SMP Mon Nov 26 02:02:42 CET 2018 armv7l GNU/Linux Running a recent Xorg built from source with modesetting driver and etnaviv. I was getting segfaults after a few seconds of usage and tracked them down

Re: [Mesa-dev] last call for autotools

2018-12-11 Thread Samuel Pitoiset
On 12/11/18 7:18 PM, Eric Anholt wrote: Emil Velikov writes: On Mon, 10 Dec 2018 at 23:11, Dylan Baker wrote: Meson 0.49.0 has been out for a couple of days now, and I'd like to make the final call for autotools. My patch is so massive that it's a huge pain to send to the list, the

[Mesa-dev] [Bug 108946] High memory usage in Black Mesa

2018-12-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108946 --- Comment #4 from Justin Mitzel --- Created attachment 142781 --> https://bugs.freedesktop.org/attachment.cgi?id=142781=edit BMS apitrace with default arguments -- You are receiving this mail because: You are the QA Contact for the bug.

Re: [Mesa-dev] last call for autotools

2018-12-11 Thread Emil Velikov
On Tue, 11 Dec 2018 at 19:49, Dylan Baker wrote: > > Quoting Emil Velikov (2018-12-11 10:48:56) > > On Tue, 11 Dec 2018 at 18:18, Eric Anholt wrote: > > > > > > Emil Velikov writes: > > > > > > > On Mon, 10 Dec 2018 at 23:11, Dylan Baker wrote: > > > >> > > > >> Meson 0.49.0 has been out for a

[Mesa-dev] [Bug 108946] High memory usage in Black Mesa

2018-12-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108946 --- Comment #3 from Justin Mitzel --- Created attachment 142780 --> https://bugs.freedesktop.org/attachment.cgi?id=142780=edit Terminal Output upon executing bms.sh -- You are receiving this mail because: You are the assignee for the bug.

[Mesa-dev] [Bug 108946] High memory usage in Black Mesa

2018-12-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108946 --- Comment #2 from Justin Mitzel --- I can also confirm that this is not a Mesa 18.2 specific bug as I am running Black Mesa on Mesa 19.0.0-devel. I will attach my own apitraces and terminal output and hopefully this can be solved soon as the

[Mesa-dev] [ANNOUNCE] mesa 18.3.1

2018-12-11 Thread Emil Velikov
Mesa 18.3.1 is now available. This version disables the VK_EXT_pci_bus_info extension due to last minute issues spotted in the specification. Emil Velikov (3): docs: add sha256 checksums for 18.3.0 Update version to 18.3.1 docs: add release notes for 18.3.1 Jason Ekstrand

Re: [Mesa-dev] [PATCH] gallium/aux: add is_unorm() helper

2018-12-11 Thread Ilia Mirkin
So ... Z24 will end up with is_unorm() == true? [Just guessing -- assume it doesn't hae is_mixed == true.] Also, does RGB10A2 have mixed set? If so, then it won't report unorm. Not 100% sure if is_mixed is only for norm + int mixing. On Tue, Dec 11, 2018 at 4:05 PM Rob Clark wrote: > > We already

[Mesa-dev] [PATCH] gallium/aux: add is_unorm() helper

2018-12-11 Thread Rob Clark
We already had one for is_snorm() but not unorm. Signed-off-by: Rob Clark --- src/gallium/auxiliary/util/u_format.c | 21 + src/gallium/auxiliary/util/u_format.h | 3 +++ 2 files changed, 24 insertions(+) diff --git a/src/gallium/auxiliary/util/u_format.c

[Mesa-dev] [PATCH] radv: don't decompress HTILE for 16-bit depth surfaces on GFX8

2018-12-11 Thread Samuel Pitoiset
GFX8 only natively supports TC-compatible HTILE for 32-bit surfaces, while GFX9 also supports 16-bit surfaces. Though, it's possible to enable it for 16-bit depth surfaces if no Z planes are compressed and the driver does that. However, it appears that trying to decompress such a surface ends up

[Mesa-dev] [Bug 107563] [RADV] Broken rendering in Unity demos

2018-12-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107563 --- Comment #10 from Samuel Pitoiset --- This patch should fix the VM faults https://patchwork.freedesktop.org/series/53914/ -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the

Re: [Mesa-dev] [Mesa-stable] [PATCH] radv: adjust the VGT workaround for prim restart on GFX9

2018-12-11 Thread Samuel Pitoiset
On 12/11/18 8:57 PM, Marek Olšák wrote: It's up to you as long as you're OK with downgraded performance of triangle strips with primitive restart. I'm OK with it, at least for now. From my point of view, it's definitely better to avoid GPU hangs. Bas, what's your opinion? Marek On

Re: [Mesa-dev] [Mesa-stable] [PATCH] radv: adjust the VGT workaround for prim restart on GFX9

2018-12-11 Thread Marek Olšák
It's up to you as long as you're OK with downgraded performance of triangle strips with primitive restart. Marek On Tue, Dec 11, 2018 at 10:08 AM Samuel Pitoiset wrote: > ping? > > After looking into this again today, I can't find any better solutions. > We should probably push this patch

Re: [Mesa-dev] last call for autotools

2018-12-11 Thread Dylan Baker
Quoting Emil Velikov (2018-12-11 10:48:56) > On Tue, 11 Dec 2018 at 18:18, Eric Anholt wrote: > > > > Emil Velikov writes: > > > > > On Mon, 10 Dec 2018 at 23:11, Dylan Baker wrote: > > >> > > >> Meson 0.49.0 has been out for a couple of days now, and I'd like to make > > >> the > > >> final

Re: [Mesa-dev] [PATCH v2] glx: mandate xf86vidmode only for "drm" dri platforms

2018-12-11 Thread Eric Engestrom
On Tuesday, 2018-12-11 17:22:03 +, Emil Velikov wrote: > From: Emil Velikov > > Currently we have the three dri "platforms" - drm, apple and windows. > > Since xf86vidmode is a thing only for the drm one, adjust the > preprocessor guards and correctly check for the dependency. > > v2:

Re: [Mesa-dev] last call for autotools

2018-12-11 Thread Emil Velikov
On Tue, 11 Dec 2018 at 18:18, Eric Anholt wrote: > > Emil Velikov writes: > > > On Mon, 10 Dec 2018 at 23:11, Dylan Baker wrote: > >> > >> Meson 0.49.0 has been out for a couple of days now, and I'd like to make > >> the > >> final call for autotools. My patch is so massive that it's a huge

Re: [Mesa-dev] last call for autotools

2018-12-11 Thread Eric Anholt
Emil Velikov writes: > On Mon, 10 Dec 2018 at 23:11, Dylan Baker wrote: >> >> Meson 0.49.0 has been out for a couple of days now, and I'd like to make the >> final call for autotools. My patch is so massive that it's a huge pain to >> send >> to the list, the latest versions is here: >>

Re: [Mesa-dev] [PATCH v2] glx: mandate xf86vidmode only for "drm" dri platforms

2018-12-11 Thread Dylan Baker
Quoting Emil Velikov (2018-12-11 09:22:03) > From: Emil Velikov > > Currently we have the three dri "platforms" - drm, apple and windows. > > Since xf86vidmode is a thing only for the drm one, adjust the > preprocessor guards and correctly check for the dependency. > > v2: terminate the

Re: [Mesa-dev] [PATCH mesa] meson/vdpau: add missing soversion

2018-12-11 Thread Dylan Baker
Thanks for fixing this, Reviewed-by: Dylan Baker Quoting Eric Engestrom (2018-12-11 09:13:54) > This mirrors what autotools does in > src/gallium/state_trackers/vdpau/Makefile.am > and src/gallium/targets/vdpau/Makefile.am: > > VDPAU_MAJOR = 1 > VDPAU_MINOR = 0 >

[Mesa-dev] [PATCH v2] glx: mandate xf86vidmode only for "drm" dri platforms

2018-12-11 Thread Emil Velikov
From: Emil Velikov Currently we have the three dri "platforms" - drm, apple and windows. Since xf86vidmode is a thing only for the drm one, adjust the preprocessor guards and correctly check for the dependency. v2: terminate the GLX_USE_WINDOWSGL hunk Cc: Jon TURNEY Cc: Dylan Baker Cc: Eric

Re: [Mesa-dev] [PATCH mesa] meson/vdpau: add missing soversion

2018-12-11 Thread Emil Velikov
On Tue, 11 Dec 2018 at 17:14, Eric Engestrom wrote: > > This mirrors what autotools does in > src/gallium/state_trackers/vdpau/Makefile.am > and src/gallium/targets/vdpau/Makefile.am: > > VDPAU_MAJOR = 1 > VDPAU_MINOR = 0 > libvdpau_gallium_la_LDFLAGS = -version-number

Re: [Mesa-dev] last call for autotools

2018-12-11 Thread Emil Velikov
On Mon, 10 Dec 2018 at 23:11, Dylan Baker wrote: > > Meson 0.49.0 has been out for a couple of days now, and I'd like to make the > final call for autotools. My patch is so massive that it's a huge pain to send > to the list, the latest versions is here: >

[Mesa-dev] [PATCH mesa] meson/vdpau: add missing soversion

2018-12-11 Thread Eric Engestrom
This mirrors what autotools does in src/gallium/state_trackers/vdpau/Makefile.am and src/gallium/targets/vdpau/Makefile.am: VDPAU_MAJOR = 1 VDPAU_MINOR = 0 libvdpau_gallium_la_LDFLAGS = -version-number $(VDPAU_MAJOR):$(VDPAU_MINOR) Reported-by: Igor Gnatenko Fixes: 68076b87474e7959c161

Re: [Mesa-dev] [PATCH 41/59] intel/compiler: split is_partial_write() into two variants

2018-12-11 Thread Pohjolainen, Topi
On Fri, Dec 07, 2018 at 03:30:11PM +0200, Pohjolainen, Topi wrote: > On Tue, Dec 04, 2018 at 08:17:05AM +0100, Iago Toral Quiroga wrote: > > This function is used in two different scenarios that for 32-bit > > instructions are the same, but for 16-bit instructions are not. > > > > One scenario is

Re: [Mesa-dev] [PATCH 04/11] st/mesa: Use Array._DrawVAO in st_atom_array.c.

2018-12-11 Thread Roland Scheidegger
Am 11.12.18 um 10:37 schrieb Mathias Fröhlich: > > Hey, > > On Tuesday, 11 December 2018 10:19:47 CET Erik Faye-Lund wrote: >> On Mon, 2018-12-10 at 18:23 +0100, Mathias Fröhlich wrote: >>> Hi Erik, >>> >>> Not sure if this is our problem as I think that I only saw simple >>> bindings with a

Re: [Mesa-dev] [PATCH] glx: mandate xf86vidmode only for "drm" dri platforms

2018-12-11 Thread Eric Engestrom
On Tuesday, 2018-12-11 16:25:55 +, Emil Velikov wrote: > From: Emil Velikov > > Currently we have the three dri "platforms" - drm, apple and windows. > > Since xf86vidmode is a thing only for the drm one, adjust the > preprocessor guards and correctly check for the dependency. > > Cc: Jon

[Mesa-dev] [PATCH] glx: mandate xf86vidmode only for "drm" dri platforms

2018-12-11 Thread Emil Velikov
From: Emil Velikov Currently we have the three dri "platforms" - drm, apple and windows. Since xf86vidmode is a thing only for the drm one, adjust the preprocessor guards and correctly check for the dependency. Cc: Jon TURNEY Cc: Dylan Baker Cc: Eric Engestrom Fixes: 5bc509363b6 ("glx: make

Re: [Mesa-dev] [PATCH 1/2] Revert "glx: make xf86vidmode mandatory for direct rendering"

2018-12-11 Thread Emil Velikov
Hi Jon, On Tue, 11 Dec 2018 at 15:22, Jon Turney wrote: > > This reverts commit 5bc509363b6dbc42af72668fe500b6aec988dbf0. > Right, I've forgot Cygwin has direct GLX. Not what exactly what we usually consider direct, regardless. A far simpler and more accurate is to add "&& !defined(__CYGWIN__)"

Re: [Mesa-dev] [PATCH] glapi: Fix DispatchSanity_test

2018-12-11 Thread Kristian Høgsberg
On Tue, Dec 11, 2018 at 3:33 AM Emil Velikov wrote: > > On Mon, 10 Dec 2018 at 18:56, Kristian Høgsberg wrote: > > > > On Mon, Dec 10, 2018 at 7:38 AM Emil Velikov > > wrote: > > > > > > On Fri, 7 Dec 2018 at 23:48, Kristian H. Kristensen > > > wrote: > > > > > > > > --- > > > >

Re: [Mesa-dev] [PATCH] svga: Enable rendering of float/half-float

2018-12-11 Thread Brian Paul
On 12/10/2018 02:36 PM, Nick Kreeger wrote: > In GLES2 - if extensions are present, float and half-float textures can > be used for rendering. This change enables the svga driver to handle > rendering these types. > --- > src/gallium/drivers/svga/svga_screen.c | 6 -- > 1 file changed, 4

Re: [Mesa-dev] [PATCH 2/2] glx: make xf86vidmode mandatory for direct rendering

2018-12-11 Thread Jon Turney
On 16/11/2018 15:12, Eric Engestrom wrote: On Friday, 2018-11-16 13:59:01 +, Emil Velikov wrote: From: Emil Velikov Currently we detect the module and if missing, the glXGetMsc* API is effectively a stub, always returning false. This is what effectively has been happening with our meson

[Mesa-dev] [PATCH 2/2] Fix typo preventing xxf86vm being used in meson build

2018-12-11 Thread Jon Turney
Also add now needed xxf86vm to the dependencies of libGL Signed-off-by: Jon Turney --- src/glx/meson.build | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/glx/meson.build b/src/glx/meson.build index 1de35fca6bc..2507993ed52 100644 --- a/src/glx/meson.build +++

[Mesa-dev] [PATCH 1/2] Revert "glx: make xf86vidmode mandatory for direct rendering"

2018-12-11 Thread Jon Turney
This reverts commit 5bc509363b6dbc42af72668fe500b6aec988dbf0. Signed-off-by: Jon Turney --- configure.ac| 12 +++- meson.build | 6 -- src/glx/Makefile.am | 5 + src/glx/SConscript | 5 - src/glx/glxcmds.c | 7 ++- src/glx/meson.build | 6 +-

[Mesa-dev] [PATCH 0/2] Restore optional xf86vidmode

2018-12-11 Thread Jon Turney
Restore optional xf86vidmode, and fix the meson build to actually use it. Jon Turney (2): Revert "glx: make xf86vidmode mandatory for direct rendering" Fix typo preventing xxf86vm being used in meson build configure.ac| 12 +++- meson.build | 6 --

Re: [Mesa-dev] [PATCH] radv: adjust the VGT workaround for prim restart on GFX9

2018-12-11 Thread Samuel Pitoiset
ping? After looking into this again today, I can't find any better solutions. We should probably push this patch because at least two games are affected. My opinion is that correctness is more important than performance. On 10/11/18 10:42 AM, Samuel Pitoiset wrote: WD_SWITCH_ON_EOP seems to

  1   2   >