[Mesa-dev] [PATCH v2 04/29] nir: add support for flushing to zero denorm constants

2018-12-18 Thread Samuel Iglesias Gonsálvez
v2: - Refactor conditions and shared function (Connor) - Move code to nir_eval_const_opcode() (Connor) - Don't flush to zero on fquantize2f16 From Vulkan spec, VK_KHR_shader_float_controls section: "3) Do denorm and rounding mode controls apply to OpSpecConstantOp? RESOLVED: Yes, except

[Mesa-dev] [PATCH v2 10/29] util: added float to float16 conversions with RTZ and RTNE

2018-12-18 Thread Samuel Iglesias Gonsálvez
Signed-off-by: Samuel Iglesias Gonsálvez --- src/util/half_float.c | 74 +++ src/util/half_float.h | 7 2 files changed, 81 insertions(+) diff --git a/src/util/half_float.c b/src/util/half_float.c index 63aec5c5c14..5fdcb20045b 100644 ---

[Mesa-dev] [PATCH v2 06/29] spirv/glsl450: fix atan2(x, x) case

2018-12-18 Thread Samuel Iglesias Gonsálvez
If x < 0 -> atan2(x, x) = -3*pi/4. If x > 0 -> atan2(x, x) = pi/4. Signed-off-by: Samuel Iglesias Gonsálvez --- src/compiler/spirv/vtn_glsl450.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/compiler/spirv/vtn_glsl450.c b/src/compiler/spirv/vtn_glsl450.c index

[Mesa-dev] [PATCH v2 08/29] nir/algebraic: disable inexact optimizations if SHADER_SIGNED_ZERO_INF_NAN_PRESERVE is enabled

2018-12-18 Thread Samuel Iglesias Gonsálvez
Signed-off-by: Samuel Iglesias Gonsálvez --- src/compiler/nir/nir_algebraic.py | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/compiler/nir/nir_algebraic.py b/src/compiler/nir/nir_algebraic.py index a667c4170f1..9d2b248a1c1 100644 ---

[Mesa-dev] [PATCH v2 13/29] spirv/nir: take into account the rounding mode in the conversions

2018-12-18 Thread Samuel Iglesias Gonsálvez
Signed-off-by: Samuel Iglesias Gonsálvez --- src/compiler/nir/nir.h | 15 +++ src/compiler/spirv/vtn_alu.c | 16 +++- 2 files changed, 30 insertions(+), 1 deletion(-) diff --git a/src/compiler/nir/nir.h b/src/compiler/nir/nir.h index 05c87290858..9579b5939fe 100644

Re: [Mesa-dev] Can't compile Mesa with --with-gallium-drivers=radeonsi, swrast (undefined reference)

2018-12-18 Thread Michel Dänzer
On 2018-12-17 2:02 p.m., Rafał Miłecki wrote: > Hi, > > I'd like to report the master branch doesn't compile with: > --with-gallium-drivers=radeonsi,swrast > > It seems there are hardcoded references to the symbols that are > available only when also compiling r300, r600 and svga. > >

Re: [Mesa-dev] PSA: Please send MRs to the mailing list

2018-12-18 Thread Elie Tournier
On Tuesday, 18 December 2018, Erik Faye-Lund wrote: > On Mon, 2018-12-17 at 16:13 -0600, Jason Ekstrand wrote: > > On Mon, Dec 17, 2018 at 2:13 PM Jason Ekstrand > > wrote: > > > On Mon, Dec 17, 2018 at 1:53 PM Eric Anholt > > > wrote: > > > > Jason Ekstrand writes: > > > > > > > > > I don't

Re: [Mesa-dev] [PATCH] freedreno/ir3: Make imageStore use num components from image format

2018-12-18 Thread Ilia Mirkin
Nv_image_formats adds all the core formats to gles. It's pretty easy to add them all in, so I don't see why not. On Tue, Dec 18, 2018, 03:17 Eduardo Lima Mitev > > On 12/18/18 9:05 AM, Eduardo Lima Mitev wrote: > > On 12/17/18 10:02 PM, Ilia Mirkin wrote: > >> Note that the format may not be

Re: [Mesa-dev] PSA: Please send MRs to the mailing list

2018-12-18 Thread Erik Faye-Lund
On Mon, 2018-12-17 at 16:13 -0600, Jason Ekstrand wrote: > On Mon, Dec 17, 2018 at 2:13 PM Jason Ekstrand > wrote: > > On Mon, Dec 17, 2018 at 1:53 PM Eric Anholt > > wrote: > > > Jason Ekstrand writes: > > > > > > > I don't know if it was actually in the doc that Jordan wrote up > > > but

Re: [Mesa-dev] [PATCH mesa] drop autotools

2018-12-18 Thread Juan A. Suarez Romero
On Mon, 2018-12-17 at 19:51 +0100, Bas Nieuwenhuizen wrote: > On Mon, Dec 17, 2018 at 6:33 PM Juan A. Suarez Romero > wrote: > > On Mon, 2018-12-03 at 10:21 +, Eric Engestrom wrote: > > > Cc: Emil Velikov > > > Cc: Andres Gomez > > > Cc: Juan A. Suarez Romero > > > Cc: Dylan Baker > > >

[Mesa-dev] MR: Revert "nir/lower_indirect: Bail early if modes == 0"

2018-12-18 Thread Ian Romanick
https://gitlab.freedesktop.org/mesa/mesa/merge_requests/26 "There's no point in walking the program if we're never going to actually lower anything." Except we might lower compacted local arrays. In that case, modes will be 0, but there is still lowering to be done. This reverts commit

[Mesa-dev] MR: NIR: fsign optimizations and a couple 1-bit Boolean optimizations too.

2018-12-18 Thread Ian Romanick
https://gitlab.freedesktop.org/mesa/mesa/merge_requests/27 This series mostly improves code generation for cases of x*fsign(y). I had some difficulty getting everything working after rebasing on the 1-bit Boolean changes. In that process, I noticed a couple things that led to the last two

Re: [Mesa-dev] [PATCH] freedreno/ir3: Make imageStore use num components from image format

2018-12-18 Thread Eduardo Lima Mitev
On 12/18/18 9:05 AM, Eduardo Lima Mitev wrote: > On 12/17/18 10:02 PM, Ilia Mirkin wrote: >> Note that the format may not be known. I suspect that falls into your >> "default" case. >> > > Hi Ilia, > > while on GLES profiles the format qualifier must be declared for all > image variables, it

Re: [Mesa-dev] [PATCH] freedreno/ir3: Make imageStore use num components from image format

2018-12-18 Thread Eduardo Lima Mitev
On 12/17/18 10:02 PM, Ilia Mirkin wrote: > Note that the format may not be known. I suspect that falls into your > "default" case. > Hi Ilia, while on GLES profiles the format qualifier must be declared for all image variables, it is true that core profiles allow to omit it for

<    1   2