On Thursday, February 7, 2019 3:35:01 AM PST andrey simiklit wrote:
> ping. the piglit test was pushed)
>
> Thanks,
> Andrii.
I landed this today. Thanks!
--Ken
signature.asc
Description: This is a digitally signed message part.
___
mesa-dev
Hello,
On Thu, 7 Feb 2019 15:46:29 -0800
Nanley Chery wrote:
> > - !(mode & BRW_MAP_DIRECT_BIT)) {
> > + !(mode & BRW_MAP_DIRECT_BIT) &&
> > + !(intel_miptree_needs_fake_etc(brw, mt))) {
> >intel_miptree_map_etc(brw, mt, map, level, slice);
>
>
On 2/6/19 12:47 PM, Connor Abbott wrote:
>
>
> On Wed, Feb 6, 2019 at 11:46 AM Samuel Iglesias Gonsálvez
> mailto:sigles...@igalia.com>> wrote:
>
> According to Vulkan spec, the new execution modes affect only
> correctly rounded SPIR-V instructions, which includes fadd,
> fsub
First three versions of this branch were sent for review to the mailing
list. In order to avoid flooding the list with more emails, I create
this MR to continue the review process there.
Reminder: this patch series relies on VK_KHR_shader_float16_int8 patch
series which is currently under review.
From: Dave Airlie
Fixes coverity warning
---
src/amd/vulkan/radv_llvm_helper.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/amd/vulkan/radv_llvm_helper.cpp
b/src/amd/vulkan/radv_llvm_helper.cpp
index f651593ca62..d1e1e376f90 100644
---
From: Dave Airlie
The constructor should init this to NULL
---
src/compiler/glsl/glsl_to_nir.cpp | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/compiler/glsl/glsl_to_nir.cpp
b/src/compiler/glsl/glsl_to_nir.cpp
index 09599e4cee7..d62de862fac 100644
---
One of our internal coverity scans pointed these out, they looked valid.
Dave.
12. mesa-18.3.3/src/gallium/winsys/svga/drm/vmw_screen_ioctl.c:323:
use_invalid: Using "rep", which points to an out-of-scope variable
"s_arg.rep".
Expand
13.
From: Dave Airlie
clang points out this isn't used.
---
src/amd/vulkan/radv_pipeline.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c
index ab56a273a2c..fb6c61cf3f0 100644
---
This fixes a rather astonishing problem that came up while debugging
an issue in the Vulkan CTS. Apparently the Vulkan CTS framework has
the tendency to create multiple VkDevices, each one with a separate
DRM device FD and therefore a disjoint GEM buffer object handle space.
Because the
For split indirect sends we have to put the EOT parameter in the
extended descriptor as well as the instruction itself so just calling
brw_inst_set_eot is insufficient. Moving the EOT handling handling into
the send_indirect_[split]_message helper lets us handle it properly.
---
https://bugs.freedesktop.org/show_bug.cgi?id=109446
--- Comment #4 from fin4...@hotmail.com ---
Feature request: Allow the end user choose the Mesa llvm version.
Why: llvm and Mesa are separate projects and llvm can cause problems in gaming.
Mesa is difficult to build and that is why Oiba ppa
Reviewed-by: Karol Herbst
On Thu, Feb 7, 2019 at 11:55 PM Eric Anholt wrote:
>
> Alyssa Rosenzweig writes:
>
> > Regardless of whether the build uses kmsro, kmsro is the default driver
> > descriptor when the static loader is used. Thus, in an edge case where
> > the static loader is used, no
On Thu, Feb 07, 2019 at 07:17:32PM +0200, Eleni Maria Stea wrote:
> On Thu, 7 Feb 2019 11:18:59 -0500
> Ilia Mirkin wrote:
>
> > On Thu, Feb 7, 2019 at 2:49 AM Eleni Maria Stea
> > wrote:
> > >
> > > On Wed, 6 Feb 2019 12:12:27 -0800
> > > Nanley Chery wrote:
> > >
> > > > > + * For
On Thu, Feb 07, 2019 at 06:00:19PM +0200, Eleni Maria Stea wrote:
> GPUs Gen < 8 cannot sample ETC2 formats. So far, they converted the
> compressed EAC/ETC2 images to non-compressed RGBA images. When
> GetCompressed* functions were called, the pixels were returned in this
> RGBA format and not
Alyssa Rosenzweig writes:
> Regardless of whether the build uses kmsro, kmsro is the default driver
> descriptor when the static loader is used. Thus, in an edge case where
> the static loader is used, no static targets are loaded, and kmsro is
> not compiled, a spurious warning is printed.
https://bugs.freedesktop.org/show_bug.cgi?id=109535
Jason Ekstrand changed:
What|Removed |Added
Depends on||109582
Referenced Bugs:
https://bugs.freedesktop.org/show_bug.cgi?id=109535
Jason Ekstrand changed:
What|Removed |Added
Depends on||109581
Referenced Bugs:
On Thu, Feb 7, 2019 at 2:47 PM Axel Davy wrote:
>
> On 07/02/2019 02:22, Marek Olšák wrote:
> >
> > + bool use_sdma_upload = sscreen->info.has_dedicated_vram &&
> > sctx->dma_cs && debug_get_bool_option("SDMA", true);
> > + sctx->b.const_uploader = u_upload_create(>b, 256 * 1024,
> > +
On 07/02/2019 02:22, Marek Olšák wrote:
+ bool use_sdma_upload = sscreen->info.has_dedicated_vram && sctx->dma_cs && debug_get_bool_option("SDMA", true);
+ sctx->b.const_uploader = u_upload_create(>b, 256 * 1024,
+0, PIPE_USAGE_DEFAULT,
+
https://bugs.freedesktop.org/show_bug.cgi?id=109543
--- Comment #10 from Gustaw Smolarczyk ---
Hi,
After messing for a while with godbolt, it seems like GCC 9 considers literal
scope to end with a block and not a function [1], or at least this is my
assumption. In the godbolt example you can
https://bugs.freedesktop.org/show_bug.cgi?id=109543
--- Comment #9 from mikhail.v.gavri...@gmail.com ---
With mesa 19.0.0 rc2 I has same crashes.
https://koji.fedoraproject.org/koji/buildinfo?buildID=1206254
--
You are receiving this mail because:
You are the assignee for the bug.
You are the
https://bugs.freedesktop.org/show_bug.cgi?id=109543
--- Comment #8 from mikhail.v.gavri...@gmail.com ---
Created attachment 143323
--> https://bugs.freedesktop.org/attachment.cgi?id=143323=edit
vulkan-cube backtrace + mesa 19.0.0 rc2
--
You are receiving this mail because:
You are the QA
On Thu, Feb 7, 2019 at 12:17 PM Eleni Maria Stea wrote:
>
> On Thu, 7 Feb 2019 11:18:59 -0500
> Ilia Mirkin wrote:
>
> > On Thu, Feb 7, 2019 at 2:49 AM Eleni Maria Stea
> > wrote:
> > >
> > > On Wed, 6 Feb 2019 12:12:27 -0800
> > > Nanley Chery wrote:
> > >
> > > > > + * For now, we
On Thu, Feb 7, 2019 at 8:03 AM Daniel Stone wrote:
>
> On Thu, 7 Feb 2019 at 14:59, Eric Engestrom wrote:
> > On Wednesday, 2019-02-06 18:36:09 +, Vinson Lee wrote:
> > > ../src/gallium/drivers/freedreno/freedreno_resource.c: In function
> > > ‘fd_resource_create_with_modifiers’:
> > >
On Thu, 7 Feb 2019 11:18:59 -0500
Ilia Mirkin wrote:
> On Thu, Feb 7, 2019 at 2:49 AM Eleni Maria Stea
> wrote:
> >
> > On Wed, 6 Feb 2019 12:12:27 -0800
> > Nanley Chery wrote:
> >
> > > > + * For now, we can't enable OES_texture_view on Gen 7
> > > > because of
> > > > + * some
https://bugs.freedesktop.org/show_bug.cgi?id=109575
--- Comment #4 from LunarG ---
I'm also seeing this same system crash on Ubuntu 18.04.1 using Radeon R9 380
card.
Happens when trying to run Sascha Willems Bloom sample.
--
You are receiving this mail because:
You are the QA Contact for the
Rename csc_matrix to shader_params, and increase shader_params size
to store more constants for compute shader,
Signed-off-by: James Zhu
Reviewed-by: Christian König
---
src/gallium/auxiliary/vl/vl_compositor.c | 10 +-
src/gallium/auxiliary/vl/vl_compositor.h | 2 +-
Add compute shader initilization, assign and cleanup in vl_compositor API.
Signed-off-by: James Zhu
Reviewed-by: Christian König
---
src/gallium/auxiliary/vl/vl_compositor.c | 31 ++-
src/gallium/auxiliary/vl/vl_compositor.h | 3 +++
2 files changed, 33
Add video compute shader render and set it to default when
pipe support it.
Signed-off-by: James Zhu
Reviewed-by: Christian König
---
src/gallium/auxiliary/vl/vl_compositor.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/src/gallium/auxiliary/vl/vl_compositor.c
V3:
Rename csc_matrix to shader_params
Remove debug option CS_COMPOSITOR_RENDER, and set compute shader video
compositor render as default when hardware supports.
James Zhu (6):
gallium/auxiliary/vl: Move dirty define to header file
gallium/auxiliary/vl: Split vl_compositor graphic
Split vl_compositor graphic shaders from vl_compositor API in order to share
vl_compositor API with vl_compositor compute shader later.
Signed-off-by: James Zhu
Reviewed-by: Christian König
---
src/gallium/auxiliary/Makefile.sources | 2 +
src/gallium/auxiliary/meson.build|
Add compute shader to support video compositor render.
Signed-off-by: James Zhu
Acked-by: Christian König
---
src/gallium/auxiliary/Makefile.sources | 2 +
src/gallium/auxiliary/meson.build | 2 +
src/gallium/auxiliary/vl/vl_compositor.h| 1 +
Move dirty define to header file to share with compute shader.
Signed-off-by: James Zhu
Reviewed-by: Christian König
---
src/gallium/auxiliary/vl/vl_compositor.c | 15 ++-
src/gallium/auxiliary/vl/vl_compositor.h | 2 ++
2 files changed, 8 insertions(+), 9 deletions(-)
diff --git
On Thu, Feb 7, 2019 at 2:49 AM Eleni Maria Stea wrote:
>
> On Wed, 6 Feb 2019 12:12:27 -0800
> Nanley Chery wrote:
>
> > > + * For now, we can't enable OES_texture_view on Gen 7
> > > because of
> > > + * some piglit failures coming from
> > > + *
https://bugs.freedesktop.org/show_bug.cgi?id=109548
Michel Dänzer changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
On Thu, 7 Feb 2019 at 14:59, Eric Engestrom wrote:
> On Wednesday, 2019-02-06 18:36:09 +, Vinson Lee wrote:
> > ../src/gallium/drivers/freedreno/freedreno_resource.c: In function
> > ‘fd_resource_create_with_modifiers’:
> > ../src/gallium/drivers/freedreno/freedreno_resource.c:884:30: error:
Intel Gen7 GPUs don't support the ETC2 formats natively and in order to
show the pixels properly we convert them to RGBA and create RGBA miptrees.
The problem with that is that the GetCompressed* functions that should
return the compressed pixel values return the RGBA instead.
These patches are
For CopyImageSubData to copy the data during the 1st draw call, we need
to update the shadow tree right before the rendering.
v2:
- Added assertion that the miptree doesn't need update at the time we
update the texture surface. (Nanley Chery)
---
src/mesa/drivers/dri/i965/brw_draw.c
Functions intel_miptree_(map|unmap)_etc are not reached anymore, as we
now use the shadow_mt of each compressed ETC miptree for the emulation.
We removed the functions.
v2:
- In the previous patch series, we only removed the assertions that
the tree was mapped for writing. We can now safely
OES_copy_image extension was disabled on Gen7 due to the lack of support
for ETC2 images. Enabled it back. (Kenneth Graunke)
v2:
- Removed the blank lines in the comments above OES_copy_image and
OES_texture_view extensions in intel_extensions.c (Nanley Chery)
---
GPUs Gen < 8 cannot sample ETC2 formats. So far, they converted the
compressed EAC/ETC2 images to non-compressed RGBA images. When
GetCompressed* functions were called, the pixels were returned in this
RGBA format and not the compressed format that was expected.
Trying to fix this problem, we use
From: Nanley Chery
Use more generic field names. We'll reuse these fields for a workaround
with ASTC miptrees.
Reviewed-by: Eleni Maria Stea
---
src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 8
src/mesa/drivers/dri/i965/intel_mipmap_tree.c| 16
https://bugs.freedesktop.org/show_bug.cgi?id=109574
--- Comment #2 from Michel Dänzer ---
These messages:
Received X11 Error:
error code: 182
request code: 156
minor code: 34
error text: GLXBadFBConfig
[...]
Received X11 Error:
error code: 8
On 2019-02-07 9:23 a.m., Christian König wrote:
> Am 07.02.19 um 15:21 schrieb James Zhu:
>> On 2019-02-07 4:49 a.m., Christian König wrote:
>>> Patches #1, #2, #5, #7 are Reviewed-by: Christian König
>>>
>>>
>>> Patch #3 the csc_matrix need a better name since we now store more and
>>> more
On Wednesday, 2019-02-06 18:36:09 +, Vinson Lee wrote:
> ../src/gallium/drivers/freedreno/freedreno_resource.c: In function
> ‘fd_resource_create_with_modifiers’:
> ../src/gallium/drivers/freedreno/freedreno_resource.c:884:30: error:
> ‘DRM_FORMAT_MOD_QCOM_COMPRESSED’ undeclared (first use
https://bugs.freedesktop.org/show_bug.cgi?id=109574
--- Comment #1 from Gert Wollny ---
The HD 2600 Pro and HD 4850 are slightly different hardware, so that the
shader code generated by the drivers might be somewhat different.
In any case, you can try to run blender with
R600_DEBUG=nosb
VA spec regarding VAImage:
This operation is only possible on implementations with
* direct rendering capabilities and internal surface formats that can be
* represented with a VAImage. When the operation is not possible this
interface
* will return VA_STATUS_ERROR_OPERATION_FAILED.
Am 07.02.19 um 15:21 schrieb James Zhu:
On 2019-02-07 4:49 a.m., Christian König wrote:
Patches #1, #2, #5, #7 are Reviewed-by: Christian König
Patch #3 the csc_matrix need a better name since we now store more and
more additional info in there, but that can as well be a follow up patch.
On 2019-02-07 4:49 a.m., Christian König wrote:
> Patches #1, #2, #5, #7 are Reviewed-by: Christian König
>
>
> Patch #3 the csc_matrix need a better name since we now store more and
> more additional info in there, but that can as well be a follow up patch.
csc_matrix is used by upper
On Wed, Feb 6, 2019 at 1:36 PM Vinson Lee wrote:
>
> ../src/gallium/drivers/freedreno/freedreno_resource.c: In function
> ‘fd_resource_create_with_modifiers’:
> ../src/gallium/drivers/freedreno/freedreno_resource.c:884:30: error:
> ‘DRM_FORMAT_MOD_QCOM_COMPRESSED’ undeclared (first use in this
ping. the piglit test was pushed)
Thanks,
Andrii.
On Tue, Jan 22, 2019 at 1:31 PM andrey simiklit
wrote:
> Hello,
>
> Could somebody help me with a push of the following patch?
> https://patchwork.freedesktop.org/patch/254397
>
> This fix is needed to fix these fails:
>
>
On 2/6/19 12:47 PM, Connor Abbott wrote:
>
>
> On Wed, Feb 6, 2019 at 11:46 AM Samuel Iglesias Gonsálvez
> mailto:sigles...@igalia.com>> wrote:
>
> According to Vulkan spec, the new execution modes affect only
> correctly rounded SPIR-V instructions, which includes fadd,
> fsub
Patches #1, #2, #5, #7 are Reviewed-by: Christian König
Patch #3 the csc_matrix need a better name since we now store more and
more additional info in there, but that can as well be a follow up patch.
Patch #4 is Acked-by: Christian König
Patch #6 I think there was a simpler option for
Tested-By: Timur Kristóf
It may be worth to note that the issue addressed was with an external
GPU (through Thunderbolt 3) and the performance benefit may be less
extreme on a system on which the bandwidth isn't as constrained.
(Also, the TB3 eGPU is still outperformed by a normal PCI-E GPU.)
https://bugs.freedesktop.org/show_bug.cgi?id=109543
--- Comment #7 from mikhail.v.gavri...@gmail.com ---
(In reply to Samuel Pitoiset from comment #6)
> Could be an issue related to GCC 9.
Can you test MESA with GCC9 ?
--
You are receiving this mail because:
You are the assignee for the bug.
https://bugs.freedesktop.org/show_bug.cgi?id=109543
--- Comment #6 from Samuel Pitoiset ---
Could be an issue related to GCC 9.
--
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.___
mesa-dev
56 matches
Mail list logo
