[Mesa-dev] [Bug 99553] Tracker bug for runnning OpenCL applications on Clover

2019-02-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99553 Timothy Arceri changed: What|Removed |Added Depends on||109329 Referenced Bugs:

Re: [Mesa-dev] [PATCH v4 33/40] intel/compiler: also set F execution type for mixed float mode in BDW

2019-02-25 Thread Iago Toral
Still waiting on this, specifically we are missing reviews for patches 33, 34, 36 and 37. On Sat, 2019-02-16 at 09:58 -0600, Jason Ekstrand wrote: > Matt, Curro, > > Could one of you please take a look at this and the other validator > patches in this series? Region restrictions aren't my

[Mesa-dev] [Bug 109446] Shadow of the Tomb Raider Trial freezes the system at startup

2019-02-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109446 fin4...@hotmail.com changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|---

[Mesa-dev] [Bug 109446] Shadow of the Tomb Raider Trial freezes the system at startup

2019-02-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109446 --- Comment #5 from fin4...@hotmail.com --- With Padoka ppa this game fails to start so the LLVM version is not the cause of this bug. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the

Re: [Mesa-dev] [PATCH 0/4] RadeonSI: Upload constants to VRAM via SDMA

2019-02-25 Thread Marek Olšák
We need to extend the CS ioctl to allow submitting 2 command buffers at the same time. Marek On Mon, Feb 25, 2019, 10:06 PM Dieter Nützel wrote: > Hello Marek, > > you wrote with your series sent: > > [-] > Trivial benchmarks such as glxgears can expect 20% decrease > in performance due to the

[Mesa-dev] [Bug 109786] Assassin's Creed Black Flag hangs when starting the Abstergo Interlude 1 mission

2019-02-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109786 Bug ID: 109786 Summary: Assassin's Creed Black Flag hangs when starting the Abstergo Interlude 1 mission Product: Mesa Version: git Hardware: x86-64 (AMD64)

[Mesa-dev] [Bug 109443] Build failure with MSVC when using Scons >= 3.0.2

2019-02-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109443 --- Comment #5 from William Deegan --- Found some issues with the patch I attached. Should have an updated one tomorrow. -- You are receiving this mail because: You are the assignee for the bug.___

Re: [Mesa-dev] [PATCH] st/mesa: Reduce array updates due to current changes.

2019-02-25 Thread Mathias Fröhlich
Hi, Thanks, Brian and Marek for the review! best Mathias On Monday, 25 February 2019 22:44:37 CET Marek Olšák wrote: > Reviewed-by: Marek Olšák > > Marek > > On Sun, Feb 24, 2019 at 1:46 AM wrote: > > > From: Mathias Fröhlich > > > > Hi Brian, > > > > Following a small optimization in the

[Mesa-dev] [Bug 109443] Build failure with MSVC when using Scons >= 3.0.2

2019-02-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109443 William Deegan changed: What|Removed |Added CC||b...@baddogconsulting.com --- Comment

[Mesa-dev] [PATCH] svga: fix dma.pending > 0 test

2019-02-25 Thread Brian Paul
The dma.pending field is boolean, so testing for > 0 isn't right. --- src/gallium/drivers/svga/svga_resource_buffer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/svga/svga_resource_buffer.c b/src/gallium/drivers/svga/svga_resource_buffer.c index

Re: [Mesa-dev] [PATCH 0/4] RadeonSI: Upload constants to VRAM via SDMA

2019-02-25 Thread Dieter Nützel
Hello Marek, you wrote with your series sent: [-] Trivial benchmarks such as glxgears can expect 20% decrease in performance due to the added cost of the SDMA CS ioctl that wasn't there before. [-] Any ideas to speed this up, again? glmark2 went from 9766 (best ever) down to 7455 (all with

[Mesa-dev] [Bug 109784] rasterizer/archrast/eventmanager.h:58:21: error: ‘EventHandler’ has not been declared

2019-02-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109784 Bug ID: 109784 Summary: rasterizer/archrast/eventmanager.h:58:21: error: ‘EventHandler’ has not been declared Product: Mesa Version: git Hardware: x86-64 (AMD64)

Re: [Mesa-dev] [PATCH 1/2] radeonsi: always use compute rings for clover on CI and newer (v2)

2019-02-25 Thread Dieter Nützel
Hello Marek, this series need a rebase (if you have some time). Dieter Am 12.02.2019 19:12, schrieb Marek Olšák: From: Marek Olšák initialize all non-compute context functions to NULL. v2: fix SI --- src/gallium/drivers/radeonsi/si_blit.c| 14 ++-

Re: [Mesa-dev] [PATCH 00/26] RadeonSI: Primitive culling with async compute

2019-02-25 Thread Dieter Nützel
Hello Marek, do you plan to commit or rebase both set? Dieter Am 14.02.2019 07:29, schrieb Marek Olšák: I have some fixes for Sea Islands that improve Radeon 290X performance to 43 fps, moving it just below Radeon VII in the picture. Marek On Wed, Feb 13, 2019 at 12:16 AM Marek Olšák

Re: [Mesa-dev] [PATCH 7/7] radeonsi: implement ARB/KHR_parallel_shader_compile callbacks

2019-02-25 Thread Dieter Nützel
For the series Tested-by: Dieter Nützel Do we have a (special) test in the wild? Dieter Am 25.02.2019 19:27, schrieb Marek Olšák: From: Marek Olšák --- src/gallium/drivers/radeonsi/si_pipe.c | 31 ++ 1 file changed, 31 insertions(+) diff --git

Re: [Mesa-dev] [PATCH] mesa: fix display list corner case assertion

2019-02-25 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Mon, Feb 25, 2019 at 5:03 PM Brian Paul wrote: > This fixes a failed assertion in glDeleteLists() for the following > case: > > list = glGenLists(1); > glDeleteLists(list, 1); > > when those are the first display list commands issued by the > application. > >

[Mesa-dev] [Bug 109532] ir_variable has maximum access out of bounds -- but it's not out of bounds

2019-02-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109532 --- Comment #43 from Mark Janes --- On my local system, I can easily reproduce the 32-bit pass, and the 64-bit crash. This is unusual, however the dEQP bug that started all of this also has a different 32 and 64 bit signature.

Re: [Mesa-dev] [Mesa-stable] [PATCH v4] i965: fixed clamping in set_scissor_bits when the y is flipped

2019-02-25 Thread Nanley Chery
On Mon, Feb 25, 2019 at 03:14:10PM -0800, Dylan Baker wrote: > Quoting Eleni Maria Stea (2019-02-22 13:02:30) > > Calculating the scissor rectangle fields with the y flipped (0 on top) > > can generate negative values that will cause assertion failure later on > > as the scissor fields are all

Re: [Mesa-dev] [Mesa-stable] [PATCH v4] i965: fixed clamping in set_scissor_bits when the y is flipped

2019-02-25 Thread Dylan Baker
Quoting Eleni Maria Stea (2019-02-22 13:02:30) > Calculating the scissor rectangle fields with the y flipped (0 on top) > can generate negative values that will cause assertion failure later on > as the scissor fields are all unsigned. We must clamp the bbox values > again to make sure they don't

[Mesa-dev] [Bug 109535] [Tracker] Mesa 19.0 release tracker

2019-02-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109535 Bug 109535 depends on bug 109561, which changed state. Bug 109561 Summary: [regression, bisected] code re-factor causing games to stutter or lock-up system https://bugs.freedesktop.org/show_bug.cgi?id=109561 What|Removed

Re: [Mesa-dev] [PATCH 4/4] i965: Reimplement all the PIPE_CONTROL rules.

2019-02-25 Thread Kenneth Graunke
On Monday, February 25, 2019 11:01:33 AM PST Pohjolainen, Topi wrote: > On Mon, Feb 25, 2019 at 10:32:27AM -0800, Kenneth Graunke wrote: > > On Monday, February 25, 2019 6:33:11 AM PST Pohjolainen, Topi wrote: > > > On Thu, Nov 01, 2018 at 08:04:21PM -0700, Kenneth Graunke wrote: > > > > -

Re: [Mesa-dev] [PATCH 3/9] nir: Add a new ALU nir_op_imad24_ir3

2019-02-25 Thread Jason Ekstrand
On Wed, Feb 13, 2019 at 3:30 PM Eduardo Lima Mitev wrote: > ir3 compiler has an integer multiply-add instruction (MAD_S24) > that is used for different offset calculations in the backend. > Since we intend to move some of these calculations to NIR, we need > a new ALU op that can directly

Re: [Mesa-dev] [PATCH] st/mesa: Reduce array updates due to current changes.

2019-02-25 Thread Brian Paul
LGTM too. Reviewed-by: Brian Paul On Sun, Feb 24, 2019 at 1:46 AM wrote: > From: Mathias Fröhlich > > Hi Brian, > > Following a small optimization in the gallium state tracker to > avoid flagging ST_NEW_VERTEX_ARRAYS a bit more often: > > please review! > > best > > Mathias > > > > > Since

[Mesa-dev] [PATCH] mesa: fix display list corner case assertion

2019-02-25 Thread Brian Paul
This fixes a failed assertion in glDeleteLists() for the following case: list = glGenLists(1); glDeleteLists(list, 1); when those are the first display list commands issued by the application. When we generate display lists, we plug in empty lists created with the make_list() helper. This

Re: [Mesa-dev] [PATCH] util: Don't block SIGSYS for new threads

2019-02-25 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Sat, Feb 23, 2019 at 2:05 AM Drew Davenport wrote: > SIGSYS is needed for programs using seccomp for sandboxing. > --- > src/util/u_thread.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/util/u_thread.h b/src/util/u_thread.h

Re: [Mesa-dev] [PATCH v2] radeonsi: fix query buffer allocation

2019-02-25 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Sun, Feb 24, 2019 at 6:56 PM Timothy Arceri wrote: > Fix the logic for buffer full check on alloc. > > This patch just takes the fix Nicolai attached to the bug report > and updates it to work on master. > > Fixes: e0f0d3675d4 ("radeonsi: factor

Re: [Mesa-dev] [PATCH] st/mesa: Reduce array updates due to current changes.

2019-02-25 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Sun, Feb 24, 2019 at 1:46 AM wrote: > From: Mathias Fröhlich > > Hi Brian, > > Following a small optimization in the gallium state tracker to > avoid flagging ST_NEW_VERTEX_ARRAYS a bit more often: > > please review! > > best > > Mathias > > > > > Since

Re: [Mesa-dev] [PATCH 2/2] Revert "meson: drop GLESv1 .so version back to 1.0.0"

2019-02-25 Thread Dylan Baker
Quoting Ross Burton (2019-02-25 12:06:48) > This patch claimed that the autotools build generates libGLESv1_CM.so.1.0.0, > but > it doesn't: > > es1api_libGLESv1_CM_la_LDFLAGS = \ > -no-undefined \ > -version-number 1:1 \ > $(GC_SECTIONS) \ > $(LD_NO_UNDEFINED) >

[Mesa-dev] [Bug 109739] Mesa build fails when vulkan-overlay-layer option is enabled

2019-02-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109739 --- Comment #6 from Shmerl --- From https://github.com/KhronosGroup/Vulkan-ValidationLayers/issues/729#issuecomment-467162536 it looks like the expected correct usage for these headers is -- You are receiving this mail because: You are the

[Mesa-dev] [PATCH 2/2] Revert "meson: drop GLESv1 .so version back to 1.0.0"

2019-02-25 Thread Ross Burton
This patch claimed that the autotools build generates libGLESv1_CM.so.1.0.0, but it doesn't: es1api_libGLESv1_CM_la_LDFLAGS = \ -no-undefined \ -version-number 1:1 \ $(GC_SECTIONS) \ $(LD_NO_UNDEFINED) Revert commit cc15460e182148292be877bec5a8a61cec57377d to

[Mesa-dev] [PATCH 1/2] winsys/svga/drm: Include sys/types.h

2019-02-25 Thread Ross Burton
From: Khem Raj vmw_screen.h uses dev_t which is defines in sys/types.h this header is required to be included for getting dev_t definition. This issue happens on musl C library, it is hidden on glibc since sys/types.h is included through another system headers ---

[Mesa-dev] [Bug 109443] Build failure with MSVC when using Scons >= 3.0.2

2019-02-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109443 --- Comment #3 from William Deegan --- If you comment out line 311 in mesascons/gallium.py # env.Decider('MD5-timestamp') You can use SCons 3.0.4. 3.0.4 had a bugfix for a longstanding issue where it was possible that md5-timestamp in

Re: [Mesa-dev] [PATCH 3/9] nir: Add a new ALU nir_op_imad24_ir3

2019-02-25 Thread Ian Romanick
On 2/13/19 1:29 PM, Eduardo Lima Mitev wrote: > ir3 compiler has an integer multiply-add instruction (MAD_S24) > that is used for different offset calculations in the backend. > Since we intend to move some of these calculations to NIR, we need > a new ALU op that can directly represent it. > ---

Re: [Mesa-dev] [PATCH] nir/algebraic: Replace a-fract(a) with floor(a)

2019-02-25 Thread Ian Romanick
On 2/23/19 4:11 PM, Timothy Arceri wrote: > > > On 23/2/19 4:09 pm, Ian Romanick wrote: >> From: Ian Romanick >> >> I noticed this while looking at a shader that was affected by Tim's >> "more loop unrolling" series. >> >> All Gen6+ platforms had similar results. (Skylake shown) >> total

Re: [Mesa-dev] [PATCH 4/4] i965: Reimplement all the PIPE_CONTROL rules.

2019-02-25 Thread Pohjolainen, Topi
On Mon, Feb 25, 2019 at 10:32:27AM -0800, Kenneth Graunke wrote: > On Monday, February 25, 2019 6:33:11 AM PST Pohjolainen, Topi wrote: > > On Thu, Nov 01, 2018 at 08:04:21PM -0700, Kenneth Graunke wrote: > > > This implements virtually all documented PIPE_CONTROL restrictions > > > in a

[Mesa-dev] [Bug 109443] Build failure with MSVC when using Scons >= 3.0.2

2019-02-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109443 Alex Granni changed: What|Removed |Added Summary|Build failure with MSVC |Build failure with MSVC

Re: [Mesa-dev] [PATCH 4/4] i965: Reimplement all the PIPE_CONTROL rules.

2019-02-25 Thread Kenneth Graunke
On Monday, February 25, 2019 6:33:11 AM PST Pohjolainen, Topi wrote: > On Thu, Nov 01, 2018 at 08:04:21PM -0700, Kenneth Graunke wrote: > > This implements virtually all documented PIPE_CONTROL restrictions > > in a centralized helper. You now simply ask for the operations you > > want, and the

[Mesa-dev] [PATCH 7/7] radeonsi: implement ARB/KHR_parallel_shader_compile callbacks

2019-02-25 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_pipe.c | 31 ++ 1 file changed, 31 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_pipe.c b/src/gallium/drivers/radeonsi/si_pipe.c index b965d9d64d4..7dbd4cb2c40 100644 ---

[Mesa-dev] [PATCH 5/7] util/queue: hold a lock when reading num_threads in util_queue_finish

2019-02-25 Thread Marek Olšák
From: Marek Olšák Reviewed-by: Ian Romanick --- src/util/u_queue.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/util/u_queue.c b/src/util/u_queue.c index cfd2a08e3c8..5e0c1095569 100644 --- a/src/util/u_queue.c +++ b/src/util/u_queue.c @@ -585,29 +585,29 @@

[Mesa-dev] [PATCH 1/7] mesa: implement ARB/KHR_parallel_shader_compile

2019-02-25 Thread Marek Olšák
From: Marek Olšák Tested by piglit. --- docs/features.txt | 2 +- docs/relnotes/19.0.0.html | 2 ++ src/mapi/glapi/gen/gl_API.xml | 15 ++- src/mesa/main/dd.h | 7 +++ src/mesa/main/extensions_table.h|

[Mesa-dev] [PATCH 4/7] util/queue: add ability to kill a subset of threads

2019-02-25 Thread Marek Olšák
From: Marek Olšák for ARB_parallel_shader_compile --- src/util/u_queue.c | 52 ++ src/util/u_queue.h | 5 ++--- 2 files changed, 36 insertions(+), 21 deletions(-) diff --git a/src/util/u_queue.c b/src/util/u_queue.c index 48c5c79552d..cfd2a08e3c8

[Mesa-dev] [PATCH 3/7] util/queue: move thread creation into a separate function

2019-02-25 Thread Marek Olšák
From: Marek Olšák Reviewed-by: Ian Romanick --- src/util/u_queue.c | 56 ++ 1 file changed, 32 insertions(+), 24 deletions(-) diff --git a/src/util/u_queue.c b/src/util/u_queue.c index 3812c824b6d..48c5c79552d 100644 --- a/src/util/u_queue.c +++

[Mesa-dev] [PATCH 6/7] util/queue: add util_queue_adjust_num_threads

2019-02-25 Thread Marek Olšák
From: Marek Olšák for ARB_parallel_shader_compile Reviewed-by: Ian Romanick --- src/util/u_queue.c | 50 -- src/util/u_queue.h | 8 2 files changed, 52 insertions(+), 6 deletions(-) diff --git a/src/util/u_queue.c b/src/util/u_queue.c

[Mesa-dev] [PATCH 2/7] gallium: implement ARB/KHR_parallel_shader_compile

2019-02-25 Thread Marek Olšák
From: Marek Olšák --- src/gallium/include/pipe/p_screen.h| 13 ++ src/mesa/state_tracker/st_cb_program.c | 59 +- 2 files changed, 71 insertions(+), 1 deletion(-) diff --git a/src/gallium/include/pipe/p_screen.h b/src/gallium/include/pipe/p_screen.h index

Re: [Mesa-dev] [PATCH 1/2] swr/rast: don't create wrapper for every Create LLVM call

2019-02-25 Thread Emil Velikov
On Mon, 25 Feb 2019 at 17:59, Hota, Alok wrote: > > > -Original Message- > > From: Emil Velikov [mailto:emil.l.veli...@gmail.com] > > Sent: Monday, February 11, 2019 7:04 AM > > To: Hota, Alok > > Cc: mesa-dev@lists.freedesktop.org; mesa-sta...@lists.freedesktop.org > > Subject: Re:

Re: [Mesa-dev] [PATCH 1/2] swr/rast: don't create wrapper for every Create LLVM call

2019-02-25 Thread Hota, Alok
> -Original Message- > From: Emil Velikov [mailto:emil.l.veli...@gmail.com] > Sent: Monday, February 11, 2019 7:04 AM > To: Hota, Alok > Cc: mesa-dev@lists.freedesktop.org; mesa-sta...@lists.freedesktop.org > Subject: Re: [Mesa-dev] [PATCH 1/2] swr/rast: don't create wrapper for > every

Re: [Mesa-dev] [PATCH 5/9] ir3/nir: Add a new pass 'ir3_nir_lower_io_offsets'

2019-02-25 Thread Rob Clark
On Wed, Feb 13, 2019 at 4:30 PM Eduardo Lima Mitev wrote: > > This pass moves to NIR some offset computations that are currently > implemented on the IR3 backend compiler, to allow NIR to possibly > optimize them. > > For now, it only supports lowering byte-offset computation for image > store

[Mesa-dev] [Bug 109782] [CTS] dEQP-VK.graphicsfuzz.while-inside-switch hangs

2019-02-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109782 Bug ID: 109782 Summary: [CTS] dEQP-VK.graphicsfuzz.while-inside-switch hangs Product: Mesa Version: git Hardware: Other OS: All Status: NEW Severity:

[Mesa-dev] [Bug 109764] [radv] Enable framerate capping

2019-02-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109764 John changed: What|Removed |Added CC||john.etted...@gmail.com -- You are receiving

[Mesa-dev] [Bug 109443] Build failure with MSVC 2017 when using Scons >= 3.0.2

2019-02-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109443 --- Comment #2 from Alex Granni --- Created attachment 143462 --> https://bugs.freedesktop.org/attachment.cgi?id=143462=edit A hack patch that removes the functionality from the build system that Scons >= 3.0.2 doesn't like -- You are

[Mesa-dev] [Bug 109698] dri.pc contents invalid when built with meson

2019-02-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109698 Emil Velikov changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

[Mesa-dev] [Bug 109443] Build failure with MSVC 2017 when using Scons >= 3.0.2

2019-02-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109443 Alex Granni changed: What|Removed |Added CC||jfons...@vmware.com -- You are

[Mesa-dev] [Bug 109761] misuse of enums in vdpau_private.h

2019-02-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109761 Christian König changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [Bug 109761] misuse of enums in vdpau_private.h

2019-02-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109761 Christian König changed: What|Removed |Added Status|RESOLVED|CLOSED -- You are receiving this

[Mesa-dev] [Bug 109532] ir_variable has maximum access out of bounds -- but it's not out of bounds

2019-02-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109532 --- Comment #42 from Mark Janes --- i965 CI runs debug builds by default, but for mesa it uses these meson configurations: -Dbuildtype=release -Db_ndebug=true We must catch assertions in the CI, however debug builds are much slower to

Re: [Mesa-dev] [PATCH 4/4] i965: Reimplement all the PIPE_CONTROL rules.

2019-02-25 Thread Pohjolainen, Topi
On Thu, Nov 01, 2018 at 08:04:21PM -0700, Kenneth Graunke wrote: > This implements virtually all documented PIPE_CONTROL restrictions > in a centralized helper. You now simply ask for the operations you > want, and the pipe control "brain" will figure out exactly what pipe > controls to emit to

[Mesa-dev] [PATCH 2/2] radv: don't copy buffer descriptors list for samplers

2019-02-25 Thread Samuel Pitoiset
Sampler descriptors don't have a buffer list. This fixes some crashes with new CTS dEQP-VK.binding_model.descriptor_copy.*.sampler_*. Cc: 18.3 19.0 Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_descriptor_set.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH 1/2] radv: fix out-of-bounds access when copying descriptors BO list

2019-02-25 Thread Samuel Pitoiset
We shouldn't increment the buffer list pointers twice. This fixes some crashes with new CTS dEQP-VK.binding_model.descriptor_copy.*. Cc: 18.3 19.0 Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_descriptor_set.c | 2 -- 1 file changed, 2 deletions(-) diff --git

Re: [Mesa-dev] [PATCH] nir: use nir_variable_create instead of open-coding the logic

2019-02-25 Thread Jason Ekstrand
Rb On February 25, 2019 05:35:17 Tapani Pälli wrote: Fixes: 3d7611e9 "st/nir: use NIR for asm programs" Reported-by: Matthias Lorenz Signed-off-by: Tapani Pälli --- src/mesa/program/prog_to_nir.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git

[Mesa-dev] [Bug 109532] ir_variable has maximum access out of bounds -- but it's not out of bounds

2019-02-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109532 --- Comment #41 from asimiklit --- (In reply to andrii simiklit from comment #40) > (In reply to Mark Janes from comment #39) > > I just noticed that this new test passes for 32 bit builds. > > > > Does that surprise anyone else? > > > >

Re: [Mesa-dev] [PATCH] docs: mention "Allow commits from members who can merge..."

2019-02-25 Thread Eric Engestrom
On Monday, 2019-02-25 11:57:20 +, Emil Velikov wrote: > From: Emil Velikov > > Mention the tick-box otherwise only the MR author can rebase the series. I thought it was already mentioned... oops. Reviewed-by: Eric Engestrom > > Cc: Jordan Justen > Cc: Dylan Baker > Cc: Erik Faye-Lund

Re: [Mesa-dev] [PATCH] docs: mention "Allow commits from members who can merge..."

2019-02-25 Thread Erik Faye-Lund
Yeah, good move! Reivewed-by: Erik Faye-Lund On Mon, 2019-02-25 at 11:57 +, Emil Velikov wrote: > From: Emil Velikov > > Mention the tick-box otherwise only the MR author can rebase the > series. > > Cc: Jordan Justen > Cc: Dylan Baker > Cc: Erik Faye-Lund > Cc: Eric Engestrom >

[Mesa-dev] [PATCH] docs: mention "Allow commits from members who can merge..."

2019-02-25 Thread Emil Velikov
From: Emil Velikov Mention the tick-box otherwise only the MR author can rebase the series. Cc: Jordan Justen Cc: Dylan Baker Cc: Erik Faye-Lund Cc: Eric Engestrom Signed-off-by: Emil Velikov --- docs/submittingpatches.html | 5 + 1 file changed, 5 insertions(+) diff --git

[Mesa-dev] [PATCH] nir: use nir_variable_create instead of open-coding the logic

2019-02-25 Thread Tapani Pälli
Fixes: 3d7611e9 "st/nir: use NIR for asm programs" Reported-by: Matthias Lorenz Signed-off-by: Tapani Pälli --- src/mesa/program/prog_to_nir.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/src/mesa/program/prog_to_nir.c b/src/mesa/program/prog_to_nir.c index

[Mesa-dev] [PATCH] radv: fix clearing attachments in secondary command buffers

2019-02-25 Thread Samuel Pitoiset
If no framebuffer is bound, get the number of samples and the image format from the render pass. This fixes new CTS dEQP-VK.geometry.layered.*.secondary_cmd_buffer. Cc: 18.3 19.0 Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_meta_clear.c | 53 ++-- 1 file

Re: [Mesa-dev] [PATCH v6] etnaviv: fix resource usage tracking across different pipe_context's

2019-02-25 Thread Boris Brezillon
On Sat, 23 Feb 2019 16:15:19 +0100 Christian Gmeiner wrote: > A pipe_resource can be shared by all the pipe_context's hanging off the > same pipe_screen. > > Changes from v2 -> v3: > - add locking with mtx_*() to resource and screen (Marek) > Changes from v3 -> v4: > - drop rsc->lock, just

Re: [Mesa-dev] [PATCH 1/1] Avoid leaking parameter name in prog_to_nir.

2019-02-25 Thread Jason Ekstrand
This is correct. However, it's probably better to just replace most of that code with a call to nir_variable_create which will do everything in that block except set the data.read_only bit including the strdup (properly) and adding it to the list. --Jason On Mon, Feb 25, 2019 at 3:06 AM Tapani

Re: [Mesa-dev] [PATCH 1/1] Avoid leaking parameter name in prog_to_nir.

2019-02-25 Thread Tapani Pälli
Yep, confirmed that this plugs the leak. FWIW there seems to be also "Conditional jump or move depends on uninitialised value(s)" from valgrind but that is for something different. Reviewed-by: Tapani Pälli On 2/21/19 11:09 AM, Matthias Lorenz wrote: Fixes: 3d7611e9 "st/nir: use NIR for

[Mesa-dev] [PATCH] gallium/util: Fix off-by-one in box intersection

2019-02-25 Thread Boris Brezillon
From: Daniel Stone pipe_boxes are x/y + width/height, rather than x0/y0 -> x1/y1. This means that (x+width) is not included in the box. The box intersection check was seemingly written for inclusive regions, and would falsely assert that adjacent boxes would overlap. Fix the off-by-one by

[Mesa-dev] [Bug 109532] ir_variable has maximum access out of bounds -- but it's not out of bounds

2019-02-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109532 --- Comment #40 from andrii simiklit --- (In reply to Mark Janes from comment #39) > I just noticed that this new test passes for 32 bit builds. > > Does that surprise anyone else? > >