[Mesa-dev] [PATCH 3/3] glsl: Interface Block instances don't need linking validation

t no link error will be reported on a program like this: "# VS layout(binding = 1) Block1 { vec4 color; } uni_block; ... # FS layout(binding = 2) Block2 { vec4 color; } uni_block; ..." Fixes GL45-CTS.enhanced_layouts.ssb_layout_qualifier_conflict Si

Re: [Mesa-dev] [PATCH] glsl: binding qualifier must match with opaque-uniforms only

Dropping this patch due to the discussion I opened at: https://cvs.khronos.org/bugzilla/show_bug.cgi?id=16238 The layout qualification among Uniform and Shader Storage Blocks across a linked program must match. Br. On Sun, 2017-02-05 at 20:53 +0200, Andres Gomez wrote: > The binding po

[Mesa-dev] [PATCH] glsl: binding qualifier must match with opaque-uniforms only

Fixes GL45-CTS.enhanced_layouts.ssb_layout_qualifier_conflict Signed-off-by: Andres Gomez <ago...@igalia.com> --- src/compiler/glsl/linker.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/glsl/linker.cpp b/src/compiler/glsl/linker.cpp index b768a6e5285..ae

Re: [Mesa-dev] [PATCH 3/5] travis: correct libdrm required regex to also track libdrm itself

LGTM Reviewed-by: Andres Gomez <ago...@igalia.com> On Wed, 2017-02-01 at 22:30 +, Emil Velikov wrote: > From: Emil Velikov <emil.veli...@collabora.com> > > The current regex was tracking only the libdrm_foo packages, while with > recent changed we bumped only (a

Re: [Mesa-dev] [PATCH 4/5] travis: add nearly all gallium drivers to the list

LGTM Reviewed-by: Andres Gomez <ago...@igalia.com> On Wed, 2017-02-01 at 22:30 +, Emil Velikov wrote: > From: Emil Velikov <emil.veli...@collabora.com> > > Note: we need the explicit --enable-freedreno for libdrm since the > latter is 'smart' and disables it if bu

Re: [Mesa-dev] [PATCH 2/5] configure.ac: add swr to the gallium drivers list.

LGTM Reviewed-by: Andres Gomez <ago...@igalia.com> On Wed, 2017-02-01 at 22:30 +, Emil Velikov wrote: > From: Emil Velikov <emil.veli...@collabora.com> > > Signed-off-by: Emil Velikov <emil.veli...@collabora.com> > --- > configure.ac | 2 +- > 1 file

Re: [Mesa-dev] [PATCH 1/5] configure.ac: list all the dri-drivers in the help string

^ Otherwise, LGTM. Reviewed-by: Andres Gomez <ago...@igalia.com> > available. > > Signed-off-by: Emil Velikov <emil.veli...@collabora.com> > --- > configure.ac | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configure.ac b/configure.ac >

Re: [Mesa-dev] [PATCH 16/19] glsl: Silence "unused parameter" warnings in ast_type.cpp

Ugh! Thanks for this. This is Reviewed-by: Andres Gomez <ago...@igalia.com> Br. On Thu, 2016-12-15 at 20:10 -0800, Ian Romanick wrote: > From: Ian Romanick <ian.d.roman...@intel.com> > > glsl/ast_type.cpp: In function ‘bool validate_point_mode(YYLTYPE*, > _mesa_

Re: [Mesa-dev] [PATCH] [rfc] glsl: allow invariant on fragment shader outputs.

outputs. Therefore, Dave, please, go ahead and land your patch. Reviewed-by: Andres Gomez <ago...@igalia.com> Br. On Wed, 2016-08-10 at 16:26 +0300, Andres Gomez wrote: > Hi, > > On Mon, 2016-05-23 at 14:18 +1000, Dave Airlie wrote: > > From: Dave Airlie <airl...@redhat.

[Mesa-dev] [PATCH] docs: fix small typos in the submit patches page

Signed-off-by: Andres Gomez <ago...@igalia.com> --- docs/submittingpatches.html | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/docs/submittingpatches.html b/docs/submittingpatches.html index 2d18c74..3d07c5e 100644 --- a/docs/submittingpatches.html +++

Re: [Mesa-dev] [PATCH 08/14] glsl: refactor duplicated validations between 2 layout-qualifiers

On Fri, 2016-11-25 at 11:07 +1100, Timothy Arceri wrote: > Thanks. Thanks for your patience with the review! ☺ > Patches 7 & 8 are: > > Reviewed-by: Timothy Arceri Pushing! -- Br, Andres ___ mesa-dev mailing list

[Mesa-dev] [PATCH 12/14] glsl: push layout-qualifier-name values from variable declarations to global

are pushing this to the global values since before it was mixed in the merging call and we only run this once all the processing for layout-qualifiers in a declaration has happened. Reviewed-by: Timothy Arceri <timothy.arc...@collabora.com> Signed-off-by: Andres Gomez <ago...@igalia.com&

[Mesa-dev] [PATCH 13/14] Revert "glsl: geom shader max_vertices layout must match."

t;timothy.arc...@collabora.com> Signed-off-by: Andres Gomez <ago...@igalia.com> --- src/compiler/glsl/ast.h | 3 +-- src/compiler/glsl/ast_type.cpp | 17 +++-- src/compiler/glsl/glsl_parser_extras.cpp | 2 +- 3 files changed, 9 insertions(+), 13 de

[Mesa-dev] [PATCH 11/14] glsl: simplified error checking for duplicated layout-qualifiers

The GLSL parser has been simplified to check for the needed GL_ARB_shading_language_420pack extension just when merging the qualifiers in the proper cases. Reviewed-by: Timothy Arceri <timothy.arc...@collabora.com> Signed-off-by: Andres Gomez <ago...@igalia.com> --- src/c

[Mesa-dev] [PATCH 09/14] glsl: ignore all but the rightmost layout qualifier name from the rightmost layout qualifier

nguage_420pack.qualifier_override_layout Reviewed-by: Timothy Arceri <timothy.arc...@collabora.com> Signed-off-by: Andres Gomez <ago...@igalia.com> --- src/compiler/glsl/ast.h | 3 +- src/compiler/glsl/ast_type.cpp | 28 ++--- src/compiler/glsl/glsl_parser.yy | 130

[Mesa-dev] [PATCH 04/14] glsl: split default in layout qualifier merge

the method is the one validated and merged against the default in qualifier. Reviewed-by: Timothy Arceri <timothy.arc...@collabora.com> Signed-off-by: Andres Gomez <ago...@igalia.com> --- src/compiler/glsl/ast.h | 16 +++-- src/compiler/glsl/ast_type

[Mesa-dev] [PATCH 10/14] glsl: simplified ast_type_qualifier::merge_into_[in|out]_qualifier API

arc...@collabora.com> Signed-off-by: Andres Gomez <ago...@igalia.com> --- src/compiler/glsl/ast.h | 4 ++-- src/compiler/glsl/ast_type.cpp | 14 ++ src/compiler/glsl/glsl_parser.yy | 4 ++-- 3 files changed, 10 insertions(+), 12 deletions(-) diff --git a/src/c

[Mesa-dev] [PATCH 08/14] glsl: refactor duplicated validations between 2 layout-qualifiers

Several layout-qualifier validations are duplicated in the merge_qualifier and validate_in_qualifier methods. We would rather have them refactored into single calls. Suggested by Timothy. Signed-off-by: Andres Gomez <ago...@igalia.com> --- src/compiler/glsl/ast_type.cpp

[Mesa-dev] [PATCH 14/14] Revert "glsl: allow layout qualifier overrides with ARB_shading_language_420pack"

) of the GLSL 4.40 spec: " While xfb_stride can be declared multiple times for the same buffer, it is a compile-time or link-time error to have different values specified for the stride for the same buffer." Fixes GL44-CTS.enhanced_layouts.xfb_duplicated_stride Reviewed-by: Ti

[Mesa-dev] [PATCH 05/14] glsl: simplifies the merge of the default in layout qualifier

present in the merge for the default in layout qualifier and the specific validation bits have been moved to the validation method for the default in layout qualifier. Reviewed-by: Timothy Arceri <timothy.arc...@collabora.com> Signed-off-by: Andres Gomez <ago...@igalia.com> --- src/c

[Mesa-dev] [PATCH 03/14] glsl: split default out layout qualifier merge

the method is the one validated and merged against the default out qualifier. Reviewed-by: Timothy Arceri <timothy.arc...@collabora.com> Signed-off-by: Andres Gomez <ago...@igalia.com> --- src/compiler/glsl/ast.h | 16 ++-- src/compiler/glsl/ast_typ

[Mesa-dev] [PATCH 07/14] glsl: assert on incoherent point mode layout-id-qualifier validation

for coherence and raising a compilation error. Suggested by Timothy. Signed-off-by: Andres Gomez <ago...@igalia.com> --- src/compiler/glsl/ast_type.cpp | 16 ++-- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/src/compiler/glsl/ast_type.cpp b/src/compile

[Mesa-dev] [PATCH 06/14] glsl: remove unneeded check for incompatible primitive types in GS

in the shader has been replaced by an assert. Reviewed-by: Timothy Arceri <timothy.arc...@collabora.com> Signed-off-by: Andres Gomez <ago...@igalia.com> --- src/compiler/glsl/ast_to_hir.cpp | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/src/compiler/glsl/as

[Mesa-dev] [PATCH v5 00/14] deal with multiple appearances of the same layout-qualifier-name in a single declaration

New patch 8/14. Fixes: - GL44-CTS.shading_language_420pack.qualifier_override_layout - GL44-CTS.enhanced_layouts.xfb_duplicated_stride Andres Gomez (14): glsl: ignore all but the rightmost layout-qualifier-name glsl: merge layouts into the default one as the last step in interface blocks

[Mesa-dev] [PATCH 02/14] glsl: merge layouts into the default one as the last step in interface blocks

Reviewed-by: Timothy Arceri <timothy.arc...@collabora.com> Signed-off-by: Andres Gomez <ago...@igalia.com> --- src/compiler/glsl/ast.h | 9 ++--- src/compiler/glsl/ast_type.cpp | 9 + src/compiler/glsl/glsl_parser.yy | 24 -

[Mesa-dev] [PATCH 01/14] glsl: ignore all but the rightmost layout-qualifier-name

Reviewed-by: Timothy Arceri <timothy.arc...@collabora.com> Signed-off-by: Andres Gomez <ago...@igalia.com> --- src/compiler/glsl/ast_type.cpp | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/src/compiler/glsl/ast_type.cpp b/src/compiler/glsl/ast_type.cpp i

Re: [Mesa-dev] [PATCH 05/13] glsl: simplifies the merge of the default in layout qualifier

On Wed, 2016-11-23 at 08:46 +1100, Timothy Arceri wrote: > On Tue, 2016-11-22 at 16:07 +0200, Andres Gomez wrote: > > On Tue, 2016-11-22 at 22:22 +1100, Timothy Arceri wrote: > > ... > > > > > > > > > Can I ask that you write a follow up patch for thi

Re: [Mesa-dev] [PATCH 05/13] glsl: simplifies the merge of the default in layout qualifier

On Tue, 2016-11-22 at 22:22 +1100, Timothy Arceri wrote: ... > > Can I ask that you write a follow up patch for this series that creates > a helper function for each of these validations. For example: > > static bool > validate_ordering(loc, state, qualifier, new_qualifier) > { >    if

[Mesa-dev] [PATCH 07/13] glsl: assert on incoherent point mode layout-id-qualifier validation

for coherence and raising a compilation error. Suggested by Timothy. Signed-off-by: Andres Gomez <ago...@igalia.com> --- src/compiler/glsl/ast_type.cpp | 16 ++-- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/src/compiler/glsl/ast_type.cpp b/src/compile

Re: [Mesa-dev] [PATCH 05/13] glsl: simplifies the merge of the default in layout qualifier

On Thu, 2016-11-17 at 16:17 +1100, Timothy Arceri wrote: > On Mon, 2016-11-14 at 19:15 +0200, Andres Gomez wrote: ... > > diff --git a/src/compiler/glsl/ast_type.cpp > > b/src/compiler/glsl/ast_type.cpp > > index 803d952..064c63b 100644 > > --- a/src/compiler/glsl

Re: [Mesa-dev] [PATCH 04/13] glsl: Split default in layout qualifier merge

On Thu, 2016-11-17 at 16:56 +1100, Timothy Arceri wrote: > On Mon, 2016-11-14 at 19:15 +0200, Andres Gomez wrote: ...  > > diff --git a/src/compiler/glsl/glsl_parser.yy > > b/src/compiler/glsl/glsl_parser.yy > > index 50f7097..9f18c15 100644 > > --- a/src/compiler/glsl/g

Re: [Mesa-dev] [PATCH 07/13] glsl: Add comments for the point mode layout-id-qualifier validation

On Thu, 2016-11-17 at 16:47 +1100, Timothy Arceri wrote: > On Mon, 2016-11-14 at 19:15 +0200, Andres Gomez wrote: > > The point mode value in an ast_type_qualifier can only be true if the > > flag is already set since this layout-id-qualifier can only be or not > > b

Re: [Mesa-dev] [PATCH 04/13] glsl: Split default in layout qualifier merge

On Thu, 2016-11-17 at 16:45 +1100, Timothy Arceri wrote: > I might have asked you this before. Is there a reason why we can't call > merge_qualifier from merge_into_in_qualifier() like we do > in merge_into_out_qualifier() to take care of some of these for us? > Since there is duplicate code.

[Mesa-dev] [PATCH 06/13] glsl: Remove unneeded check for incompatible primitive types in GS

in the shader has been replaced by an assert. Signed-off-by: Andres Gomez <ago...@igalia.com> --- src/compiler/glsl/ast_to_hir.cpp | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/src/compiler/glsl/ast_to_hir.cpp b/src/compiler/glsl/ast_to_hir.cpp index 9b8678c..c

[Mesa-dev] [PATCH 13/13] Revert "glsl: allow layout qualifier overrides with ARB_shading_language_420pack"

) of the GLSL 4.40 spec: " While xfb_stride can be declared multiple times for the same buffer, it is a compile-time or link-time error to have different values specified for the stride for the same buffer." Fixes GL44-CTS.enhanced_layouts.xfb_duplicated_stride Reviewed-by: Ti

[Mesa-dev] [PATCH 05/13] glsl: simplifies the merge of the default in layout qualifier

present in the merge for the default in layout qualifier and the specific validation bits have been moved to the validation method for the default in layout qualifier. Signed-off-by: Andres Gomez <ago...@igalia.com> --- src/compiler/glsl/ast_type.cpp

[Mesa-dev] [PATCH 09/13] glsl: simplified ast_type_qualifier::merge_into_[in|out]_qualifier API

Since we modified the way in which multiple repetitions of the same layout-qualifier-name in a single declaration collapse into the ast_type_qualifier class, we can simplify the merge_into_[in|out]_qualifier APIs through removing the create_node parameter. Signed-off-by: Andres Gomez <

[Mesa-dev] [PATCH 02/13] glsl: merge layouts into the default one as the last step in interface blocks

Reviewed-by: Timothy Arceri <timothy.arc...@collabora.com> Signed-off-by: Andres Gomez <ago...@igalia.com> --- src/compiler/glsl/ast.h | 9 ++--- src/compiler/glsl/ast_type.cpp | 9 + src/compiler/glsl/glsl_parser.yy | 24 -

[Mesa-dev] [PATCH 12/13] Revert "glsl: geom shader max_vertices layout must match."

t;timothy.arc...@collabora.com> Signed-off-by: Andres Gomez <ago...@igalia.com> --- src/compiler/glsl/ast.h | 3 +-- src/compiler/glsl/ast_type.cpp | 17 +++-- src/compiler/glsl/glsl_parser_extras.cpp | 2 +- 3 files changed, 9 insertions(+), 13 de

[Mesa-dev] [PATCH 10/13] glsl: simplified error checking for duplicated layout-qualifiers

The GLSL parser has been simplified to check for the needed GL_ARB_shading_language_420pack extension just when merging the qualifiers in the proper cases. Reviewed-by: Timothy Arceri <timothy.arc...@collabora.com> Signed-off-by: Andres Gomez <ago...@igalia.com> --- src/c

[Mesa-dev] [PATCH 04/13] glsl: Split default in layout qualifier merge

the method is the one validated and merged against the default in qualifier. Signed-off-by: Andres Gomez <ago...@igalia.com> --- src/compiler/glsl/ast.h | 16 +++-- src/compiler/glsl/ast_type.cpp | 127 ++- src/compiler/glsl/glsl_parser.yy

[Mesa-dev] [PATCH 11/13] glsl: push layout-qualifier-name values from variable declarations to global

are pushing this to the global values since before it was mixed in the merging call and we only run this once all the processing for layout-qualifiers in a declaration has happened. Signed-off-by: Andres Gomez <ago...@igalia.com> --- src/compiler/glsl/ast.h | 6 + src/compile

[Mesa-dev] [PATCH v4 00/13] deal with multiple appearances of the same layout-qualifier-name in a single declaration

patch v3 8/8 is now patch 9/13 to be closer in the log history with the other related changes. Fixes: - GL44-CTS.shading_language_420pack.qualifier_override_layout - GL44-CTS.enhanced_layouts.xfb_duplicated_stride Andres Gomez (13): glsl: ignore all but the rightmost layout-qualif

[Mesa-dev] [PATCH 07/13] glsl: Add comments for the point mode layout-id-qualifier validation

we do check its value. Added comments explaining this. Signed-off-by: Andres Gomez <ago...@igalia.com> --- src/compiler/glsl/ast_type.cpp | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/compiler/glsl/ast_type.cpp b/src/compiler/glsl/ast_type.cpp index 064c63b..7c59747

[Mesa-dev] [PATCH 03/13] glsl: Split default out layout qualifier merge

the method is the one validated and merged against the default out qualifier. Signed-off-by: Andres Gomez <ago...@igalia.com> --- src/compiler/glsl/ast.h | 16 ++-- src/compiler/glsl/ast_type.cpp | 79 +--- src/compiler/glsl/glsl_parser.y

[Mesa-dev] [PATCH 08/13] glsl: ignore all but the rightmost layout qualifier name from the rightmost layout qualifier

nguage_420pack.qualifier_override_layout Signed-off-by: Andres Gomez <ago...@igalia.com> --- src/compiler/glsl/ast.h | 3 +- src/compiler/glsl/ast_type.cpp | 28 ++--- src/compiler/glsl/glsl_parser.yy | 130 +++ 3 files changed, 84 insertions(

[Mesa-dev] [PATCH 01/13] glsl: ignore all but the rightmost layout-qualifier-name

Reviewed-by: Timothy Arceri <timothy.arc...@collabora.com> Signed-off-by: Andres Gomez <ago...@igalia.com> --- src/compiler/glsl/ast_type.cpp | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/src/compiler/glsl/ast_type.cpp b/src/compiler/glsl/ast_type.cpp i

Re: [Mesa-dev] [PATCH v3 0/8] deal with multiple appearances of the same layout-qualifier-name in a single declaration

On Thu, 2016-11-10 at 19:21 +1100, Timothy Arceri wrote: > On Wed, 2016-11-09 at 23:09 -0800, Kenneth Graunke wrote: > > On Wednesday, October 26, 2016 6:30:43 PM PST Andres Gomez wrote: > > [snip] > > > > > > The main changes in this v3 series are: > >

[Mesa-dev] [PATCH] dir-locals.el: Adds White Space support

. - If the White Space mode is not activated the set variables would not have any effect. v2: Removed too long lines trail highlighting, as suggested by Ilia Mirkin. Signed-off-by: Andres Gomez <ago...@igalia.com> --- .dir-locals.el | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-)

Re: [Mesa-dev] [PATCH] dir-locals.el: Adds whitespace support

If nobody says otherwise, I will land this by the beginning of next week. On Sun, 2016-10-23 at 00:10 +0300, Andres Gomez wrote: > Provides support for highlighting incorrect indentation. > > v2: Removed too long lines trail highlighting, as suggested by Ilia > Mirkin. >

Re: [Mesa-dev] mesa-dev is failing to bounce some mails

On Thu, 2016-10-27 at 14:47 +0300, Martin Peres wrote: > These are know issues and are being investigated by the freedes Thanks Martin! -- Br, Andres ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

Re: [Mesa-dev] mesa-dev is failing to bounce some mails

On Thu, 2016-10-27 at 12:14 +0100, Emil Velikov wrote: > On 27 October 2016 at 12:06, Andres Gomez <ago...@igalia.com> wrote: > > On Wed, 2016-10-26 at 19:35 +0300, Andres Gomez wrote: > > > Hi, > > > > > > recently, we have noticed that we are not rece

Re: [Mesa-dev] mesa-dev is failing to bounce some mails

On Wed, 2016-10-26 at 19:35 +0300, Andres Gomez wrote: > Hi, > > recently, we have noticed that we are not receiving some of the mails > that we have sent to the ML. > > The mails are archived, though, but we don't get the copy from the ML.  > > We were checking if t

[Mesa-dev] [PATCH 7/8] Revert "glsl: allow layout qualifier overrides with ARB_shading_language_420pack"

) of the GLSL 4.40 spec: " While xfb_stride can be declared multiple times for the same buffer, it is a compile-time or link-time error to have different values specified for the stride for the same buffer." Fixes GL44-CTS.enhanced_layouts.xfb_duplicated_stride Reviewed-by: Ti

[Mesa-dev] [PATCH 3/8] glsl: ignore all but the rightmost layout qualifier name from the rightmost layout qualifier

nguage_420pack.qualifier_override_layout Signed-off-by: Andres Gomez <ago...@igalia.com> --- src/compiler/glsl/ast.h | 3 +- src/compiler/glsl/ast_type.cpp | 28 ++--- src/compiler/glsl/glsl_parser.yy | 125 ++- 3 files changed, 79 insertions(

Re: [Mesa-dev] [PATCH 2/9] glsl: merge layouts into the default one as the last step in interface blocks

On Mon, 2016-10-24 at 12:23 +1100, Timothy Arceri wrote: > On Sat, 2016-10-22 at 23:09 +0300, Andres Gomez wrote: > > Consider this example: > > > > " #version 150 core > >   #extension GL_ARB_shading_language_420pack: require > >   #extension GL

[Mesa-dev] mesa-dev is failing to bounce some mails

Hi, recently, we have noticed that we are not receiving some of the mails that we have sent to the ML. The mails are archived, though, but we don't get the copy from the ML.  We were checking if this was a problem in our side. However, we've checked that they don't appear either in patchwork so

[Mesa-dev] [PATCH 1/8] glsl: ignore all but the rightmost layout-qualifier-name

Reviewed-by: Timothy Arceri <timothy.arc...@collabora.com> Signed-off-by: Andres Gomez <ago...@igalia.com> --- src/compiler/glsl/ast_type.cpp | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/src/compiler/glsl/ast_type.cpp b/src/compiler/glsl/ast_type.cpp i

[Mesa-dev] [PATCH 8/8] glsl: simplified ast_type_qualifier::merge_[in|out]_qualifier API

Since we modified the way in which multiple repetitions of the same layout-qualifier-name in a single declaration collapse into the ast_type_qualifier class, we can simplify the merge_[in|out]_qualifier APIs through removing the create_node parameter. Signed-off-by: Andres Gomez <

[Mesa-dev] [PATCH 2/8] glsl: merge layouts into the default one as the last step in interface blocks

Reviewed-by: Timothy Arceri <timothy.arc...@collabora.com> Signed-off-by: Andres Gomez <ago...@igalia.com> --- src/compiler/glsl/ast.h | 9 ++--- src/compiler/glsl/ast_type.cpp | 9 + src/compiler/glsl/glsl_parser.yy | 24 -

[Mesa-dev] [PATCH 5/8] glsl: push layout-qualifier-name values from variable declarations to global

are pushing this to the global values since before it was mixed in the merging call and we only run this once all the processing for layout-qualifiers in a declaration has happened. Signed-off-by: Andres Gomez <ago...@igalia.com> --- src/compiler/glsl/ast.h | 6 + src/compile

[Mesa-dev] [PATCH 6/8] Revert "glsl: geom shader max_vertices layout must match."

t;timothy.arc...@collabora.com> Signed-off-by: Andres Gomez <ago...@igalia.com> --- src/compiler/glsl/ast.h | 3 +-- src/compiler/glsl/ast_type.cpp | 17 +++-- src/compiler/glsl/glsl_parser_extras.cpp | 2 +- 3 files changed, 9 insertions(+), 13 de

[Mesa-dev] [PATCH 4/8] glsl: simplified error checking for duplicated layout-qualifiers

Tthe GLSL parser has been simplified to check for the needed GL_ARB_shading_language_420pack extension just when merging the qualifiers in the proper cases. Reviewed-by: Timothy Arceri <timothy.arc...@collabora.com> Signed-off-by: Andres Gomez <ago...@igalia.com> --- src/c

[Mesa-dev] [PATCH v3 0/8] deal with multiple appearances of the same layout-qualifier-name in a single declaration

alifier_override_layout - GL44-CTS.enhanced_layouts.xfb_duplicated_stride Andres Gomez (8): glsl: ignore all but the rightmost layout-qualifier-name glsl: merge layouts into the default one as the last step in interface blocks glsl: ignore all but the rightmost layout qualifier name

Re: [Mesa-dev] [PATCH 3/9] glsl: ignore all but the rightmost layout qualifier name from the rightmost layout qualifier

On Wed, 2016-10-26 at 11:47 +1100, Timothy Arceri wrote: > Did you test early_fragment_tests specifically? This is one that I > checked is only in merge_in_qualifier() and not merge_qualifier() AFAIK, early_fragment_tests is the only default input layout-qualifier- name for a fragment shader

Re: [Mesa-dev] [PATCH 9/9] glsl: simplified ast_type_qualifier::merge_[in|out]_qualifier API

On Mon, 2016-10-24 at 14:09 +1100, Timothy Arceri wrote: > I'm not sure we can do this see my last commets to patch 3. As commented previously, I've created new tests for input, output, uniform and global default declarations using non-value layout- qualifier-ids and multiple layout-qualifiers in

Re: [Mesa-dev] [PATCH 6/9] glsl: push layout-qualifier-name values from variable declarations to global

On Mon, 2016-10-24 at 13:44 +1100, Timothy Arceri wrote: > On Sat, 2016-10-22 at 23:09 +0300, Andres Gomez wrote: > > After the previous modifications in the merging of the > > layout-qualifier-name values, we no longer push the final value in a > > declaration

Re: [Mesa-dev] [PATCH 3/9] glsl: ignore all but the rightmost layout qualifier name from the rightmost layout qualifier

On Mon, 2016-10-24 at 14:09 +1100, Timothy Arceri wrote: > On Sat, 2016-10-22 at 23:09 +0300, Andres Gomez wrote: > >   > > > > > > +   | layout_qualifier BUFFER ';' > > ; > >   > >  layout_in_defaults: > > layout_qualifie

[Mesa-dev] [PATCH] dir-locals.el: Adds whitespace support

Provides support for highlighting incorrect indentation. v2: Removed too long lines trail highlighting, as suggested by Ilia Mirkin. Signed-off-by: Andres Gomez <ago...@igalia.com> --- .dir-locals.el | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/.dir-loc

[Mesa-dev] [PATCH] dir-locals.el: Adds whitespace support

Provides support to highlighting incorrect indentation. v2: Removed too long lines trail highlighting, as suggested by Ilia Mirkin. Signed-off-by: Andres Gomez <ago...@igalia.com> --- .dir-locals.el | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/.dir-loc

[Mesa-dev] [PATCH 4/9] glsl: simplified error checking for duplicated layout-qualifiers

Tthe GLSL parser has been simplified to check for the needed GL_ARB_shading_language_420pack extension just when merging the qualifiers in the proper cases. Signed-off-by: Andres Gomez <ago...@igalia.com> --- src/compiler/glsl/ast_type.cpp | 6 ++ src/compiler/glsl/glsl_parser.y

[Mesa-dev] [PATCH 3/9] glsl: ignore all but the rightmost layout qualifier name from the rightmost layout qualifier

nguage_420pack.qualifier_override_layout Signed-off-by: Andres Gomez <ago...@igalia.com> --- src/compiler/glsl/ast.h | 3 +- src/compiler/glsl/ast_type.cpp | 28 ++--- src/compiler/glsl/glsl_parser.yy | 125 ++- 3 files changed, 79 insertions(

[Mesa-dev] [PATCH 8/9] Revert "glsl: allow layout qualifier overrides with ARB_shading_language_420pack"

) of the GLSL 4.40 spec: " While xfb_stride can be declared multiple times for the same buffer, it is a compile-time or link-time error to have different values specified for the stride for the same buffer." Fixes GL44-CTS.enhanced_layouts.xfb_duplicated_stride Signed-off-by:

[Mesa-dev] [PATCH 2/9] glsl: merge layouts into the default one as the last step in interface blocks

done from left to right and, as a last step, we merge into the default layout qualifier if needed, so the values of the explicit layouts prevail over it. Signed-off-by: Andres Gomez <ago...@igalia.com> --- src/compiler/glsl/ast.h | 9 ++--- src/compiler/glsl/ast_type.cp

[Mesa-dev] [PATCH 6/9] glsl: push layout-qualifier-name values from variable declarations to global

are pushing this to the global values since before it was mixed in the merging call and we only run this once all the processing for layout-qualifiers in a declaration has happened. Signed-off-by: Andres Gomez <ago...@igalia.com> --- src/compiler/glsl/ast.h | 6 + src/compile

[Mesa-dev] [PATCH 9/9] glsl: simplified ast_type_qualifier::merge_[in|out]_qualifier API

Since we modified the way in which multiple repetitions of the same layout-qualifier-name in a single declaration collapse into the ast_type_qualifier class, we can simplify the merge_[in|out]_qualifier APIs through removing the create_node parameter. Signed-off-by: Andres Gomez <

[Mesa-dev] [PATCH 5/9] glsl: allow multiple layout-qualifier in single declaration if enhanced layouts

ier occurrence(s) within the declaration are not present. This is also true for overriding layout-qualifier-names, where one overrides the other (e.g., row_major vs. column_major); only the last occurrence has any effect."" Signed-off-by: Andres Gomez <ago..

[Mesa-dev] [PATCH 7/9] Revert "glsl: geom shader max_vertices layout must match."

different values. In other words, the list is used for an after check that all the declared values for a layout-qualifier-name are consistent. Therefore, the values stored must match always, not just for "max_vertices" or any other eventual layout-qualifier-name. Signed-off-by: Andres

[Mesa-dev] [PATCH 1/9] glsl: ignore all but the rightmost layout-qualifier-name

Reviewed-by: Timothy Arceri <timothy.arc...@collabora.com> Signed-off-by: Andres Gomez <ago...@igalia.com> --- src/compiler/glsl/ast_type.cpp | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/src/compiler/glsl/ast_type.cpp b/src/compiler/glsl/ast_type.cpp i

[Mesa-dev] [PATCH v2 0/9] deal with multiple appearances of the same layout-qualifier-name in a single declaration

_layouts.xfb_duplicated_stride Andres Gomez (9): glsl: ignore all but the rightmost layout-qualifier-name glsl: merge layouts into the default one as the last step in interface blocks glsl: ignore all but the rightmost layout qualifier name from the rightmost layout qualifier g

Re: [Mesa-dev] [PATCH 2/5] glsl: last duplicated layout-qualifier-name in multiple layout-qualifiers overrides the former

lied in the v2 series to come ... > On Fri, 2016-10-07 at 01:52 +0300, Andres Gomez wrote: > > From page 46 (page 52 of the PDF) of the GLSL 4.20 spec: > > > >   " More than one layout qualifier may appear in a single > > declaration. If the same layout-qualif

Re: [Mesa-dev] [PATCH 1/5] glsl: last duplicated layout-qualifier-name in a layout-qualifier overrides the former

ame > > On Fri, 2016-10-07 at 01:52 +0300, Andres Gomez wrote: > > In a declaration, when a layout qualifier appears and holds > > duplicated > > layout-qualifier-name, only the last occurrence should be taken into > > account. > > > Slight change to

[Mesa-dev] [PATCH 5/5] glsl: simplified ast_type_qualifier::merge_[in|out]_qualifier API

Since we modified the way in which multiple repetitions of the same layout-qualifier-name in a single declaration collapse into the ast_type_qualifier class, we can simplify the merge_[in|out]_qualifier APIs through removing the create_node parameter. Signed-off-by: Andres Gomez <

[Mesa-dev] [PATCH 2/5] glsl: last duplicated layout-qualifier-name in multiple layout-qualifiers overrides the former

xpression is now done prepending instead of appending since the processing of the qualifier constant returns the first value in the list and the last appearing declaration of a variable or default overrides the previous declarations. Fixes GL44-CTS.shading_language_420pack.qualifier_override_layout Signed

[Mesa-dev] [PATCH 4/5] glsl: by default, any ast_layout_expression variable value must match its previous appearances

e error to have different values specified for the stride for the same buffer." Fixes GL44-CTS.enhanced_layouts.xfb_duplicated_stride Signed-off-by: Andres Gomez <ago...@igalia.com> --- src/compiler/glsl/ast.h | 2 +- src/compiler/glsl/glsl_parser_extras.cpp | 2 +- 2 files chan

[Mesa-dev] [PATCH 1/5] glsl: last duplicated layout-qualifier-name in a layout-qualifier overrides the former

if the "is_single_layout_merge" parameter is on, since the GLSL parser works in this case from right to left. Signed-off-by: Andres Gomez <ago...@igalia.com> --- src/compiler/glsl/ast_type.cpp | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/src/compiler/glsl

[Mesa-dev] [PATCH 0/5] deal with multiple appearances of the same layout-qualifier-name in a single declaration

ader are valid. Fixes: - GL44-CTS.shading_language_420pack.qualifier_override_layout - GL44-CTS.enhanced_layouts.xfb_duplicated_stride Andres Gomez (5): glsl: last duplicated layout-qualifier-name in a layout-qualifier overrides the former glsl: last duplicated layout-qualifier-name in multiple layout-q

[Mesa-dev] [PATCH 3/5] glsl: push layout-qualifier-name values from variable declarations to global

are pushing this to the global values since before it was mixed in the merging call and we only run this once all the processing for layout-qualifiers in a declaration has happened. Signed-off-by: Andres Gomez <ago...@igalia.com> --- src/compiler/glsl/ast.h | 6 + src/compile

Re: [Mesa-dev] [PATCH] dir-locals.el: show-trailing-whitespace and whitespace support

On Thu, 2016-09-08 at 12:04 -0400, Ilia Mirkin wrote: > On Thu, Sep 8, 2016 at 12:01 PM, Andres Gomez <ago...@igalia.com> wrote: > > It will highlight malformed indentation > > Malformed meaning what? Usage of tabs, instead of spaces. > > and change color of t

Re: [Mesa-dev] [PATCH] dir-locals.el: show-trailing-whitespace and whitespace support

On Thu, 2016-09-08 at 09:59 -0400, Ilia Mirkin wrote: > On Tue, Aug 2, 2016 at 12:14 PM, Andres Gomez <ago...@igalia.com> wrote: > > Signed-off-by: Andres Gomez <ago...@igalia.com> > > --- > > .dir-locals.el | 9 +++-- > > 1 file changed, 7 insertions

Re: [Mesa-dev] [PATCH] dir-locals.el: show-trailing-whitespace and whitespace support

If nobody says otherwise, I will land this by the beginning of next week. On Tue, 2016-08-02 at 19:14 +0300, Andres Gomez wrote: > Signed-off-by: Andres Gomez <ago...@igalia.com> > --- > .dir-locals.el | 9 +++-- > 1 file changed, 7 insertions(+), 2 deletions(-) >

Re: [Mesa-dev] [PATCH 3/5] i965: use new subroutine index uploader.

On Tue, 2016-08-23 at 10:45 +1000, Dave Airlie wrote: > > > > > #include "main/mtypes.h" > > > #include "program/prog_parameter.h" > > > - > > > +#include "main/shaderapi.h" > > > > Why the extra empty line? If so, I would put it after the new include. > > It actually removes the empty line,

Re: [Mesa-dev] [PATCH 5/5] mesa/subroutines: drop the old subroutine index uploads.

gt; } > > > @@ -2844,8 +2840,6 @@ _mesa_shader_init_subroutine_defaults(struct gl_context > *ctx, > continue; >ctx->SubroutineIndex[sh->Stage].IndexPtr[i] = > find_compat_subroutine(sh, uni->type); > } > - > - _mesa_shader_write_subroutine_index

Re: [Mesa-dev] [PATCH 4/5] st/mesa: use the new subroutine index upload API.

gl_context *ctx, GLint x, GLint y, > * into the constant buffer, we need to update them > */ >st_upload_constants(st, st->fp->Base.Base.Parameters, > - PIPE_SHADER_FRAGMENT); > + MESA_SHADER_FRAGMENT); >

Re: [Mesa-dev] [PATCH 3/5] i965: use new subroutine index uploader.

erapi.h" > > static void > gen7_upload_tes_push_constants(struct brw_context *brw) > @@ -37,6 +38,7 @@ gen7_upload_tes_push_constants(struct brw_context *brw) > if (tep) { >/* BRW_NEW_TES_PROG_DATA */ >const struct brw_stage_prog_data *prog_data

Re: [Mesa-dev] [PATCH 2/5] mesa: add api to write subroutine indicies to the program storage.

ct gl_context *ctx, > + gl_shader_stage stage); > extern void GLAPIENTRY > _mesa_AttachObjectARB(GLhandleARB, GLhandleARB); > Other than the small nitpick, this is: Reviewed-by: Andres Gomez <ago...@igalia.com> -- Br, Andres ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 1/5] mesa/subroutines: start adding per-context subroutine index support

above). > + ctx->SubroutineIndex[sh->Stage].NumIndex = > sh->NumSubroutineUniformRemapTable; > + } > + > + for (i = 0; i < sh->NumSubroutineUniformRemapTable; i++) { > + struct gl_uniform_storage *uni = sh->SubroutineUniformRemapTable[i];

Re: [Mesa-dev] [PATCH 1/5] mesa/subroutines: start adding per-context subroutine index support

On Tue, 2016-06-07 at 16:23 +0200, Iago Toral wrote: > On Tue, 2016-06-07 at 15:25 +1000, Dave Airlie wrote: > > From: Dave Airlie > > > > One piece of ARB_shader_subroutine I ignored was the fact that it > > needs to store the subroutine index data per context and not per >

Re: [Mesa-dev] shader subroutine per-context uniform support

FTR, I rebased this series on top of current master (minimal changes) and run a full CTS and piglit run with the i965 [gen 8]. The failing CTS now passes and I have not observed any regression nor in CTS neither in piglit. On Tue, 2016-06-07 at 15:25 +1000, Dave Airlie wrote: > So when I

Re: [Mesa-dev] [PATCH] [rfc] glsl: allow invariant on fragment shader outputs.

Hi, On Mon, 2016-05-23 at 14:18 +1000, Dave Airlie wrote: > From: Dave Airlie > > A CTS test manages to generate this: > GL45-CTS.shading_language_420pack.qualifier_order > > I cannot find definitive evidence in the spec that it isn't > allowed. The specs mentions some

<    1   2   3   4   5   6   7   >