Re: [Mesa-dev] [PATCH 3/5] glsl: struct constructors/initializers only allow implicit conversions

2016-08-05 Thread Andres Gomez
On Fri, 2016-08-05 at 08:35 +1000, Timothy Arceri wrote: > Thanks for you patience with this series :)  The parameter check above The other way around, thanks to you for reviewing! ☺ > is a nice cleanup too thanks. Patches 2 and 3 are: > > Reviewed-by: Timothy Arceri

[Mesa-dev] [PATCH 3/5] glsl: struct constructors/initializers only allow implicit conversions

2016-08-04 Thread Andres Gomez
ode (Timothy). Fixes GL44-CTS.shading_language_420pack.initializer_list_negative Signed-off-by: Andres Gomez <ago...@igalia.com> --- src/compiler/glsl/ast_function.cpp | 104 - 1 file changed, 55 insertions(+), 49 deletions(-) diff --git a/src/compiler/glsl/ast_function.cpp

[Mesa-dev] [PATCH 2/5] glsl: Refactor implicit conversion into its own helper

2016-08-04 Thread Andres Gomez
v2: Refactor also the conversion to constant and replacement code (Timothy). Signed-off-by: Andres Gomez <ago...@igalia.com> --- src/compiler/glsl/ast_function.cpp | 166 +++-- 1 file changed, 86 insertions(+), 80 deletions(-) diff --git a/src/compile

[Mesa-dev] [PATCH 1/5] glsl/types: disallow implicit conversions before GLSL 1.20

2016-08-03 Thread Andres Gomez
Implicit conversions were added in the GLSL 1.20 spec version. v2 (Timothy): Join the checks for GLSL 1.10 and ESSL. Signed-off-by: Andres Gomez <ago...@igalia.com> --- src/compiler/glsl_types.cpp | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/co

Re: [Mesa-dev] [PATCH 1/5] glsl/types: disallow implicit conversions before GLSL 1.20

2016-08-03 Thread Andres Gomez
On Thu, 2016-08-04 at 08:53 +1000, Timothy Arceri wrote: > On Wed, 2016-08-03 at 23:51 +0300, Andres Gomez wrote: > > Implicit conversions were added in the GLSL 1.20 spec version. > > > > Signed-off-by: Andres Gomez <ago...@igalia.com> > > --- > >  src/

[Mesa-dev] [PATCH 3/5] glsl: struct constructors/initializers only allow implicit conversions

2016-08-03 Thread Andres Gomez
0 "Implicit Conversions". In the latter case, an implicit conversion will be done on the initializer before the assignment is done." Fixes GL44-CTS.shading_language_420pack.initializer_list_negative Signed-off-by: Andres Gomez <ago...@igalia.com> --- src

[Mesa-dev] [PATCH v2 0/5] struct constructors/initializers only allow implicit conversions

2016-08-03 Thread Andres Gomez
When an argument for a structure constructor or initializer doesn't match the expected type, only Section 4.1.10 “Implicit Conversions” are allowed to try to match that expected type. Fixes GL44-CTS.shading_language_420pack.initializer_list_negative Andres Gomez (5): glsl/types: disallow

[Mesa-dev] [PATCH 5/5] glsl: fix indentation, comments and line lengths in ast_function.cpp

2016-08-03 Thread Andres Gomez
Signed-off-by: Andres Gomez <ago...@igalia.com> --- src/compiler/glsl/ast_function.cpp | 880 +++-- 1 file changed, 460 insertions(+), 420 deletions(-) diff --git a/src/compiler/glsl/ast_function.cpp b/src/compiler/glsl/ast_function.cpp index 52cbf1f..8

[Mesa-dev] [PATCH 2/5] glsl: Refactor implicit conversion into its own helper

2016-08-03 Thread Andres Gomez
Signed-off-by: Andres Gomez <ago...@igalia.com> --- src/compiler/glsl/ast_function.cpp | 79 +++--- 1 file changed, 47 insertions(+), 32 deletions(-) diff --git a/src/compiler/glsl/ast_function.cpp b/src/compiler/glsl/ast_function.cpp index 9dcec50..5

[Mesa-dev] [PATCH 1/5] glsl/types: disallow implicit conversions before GLSL 1.20

2016-08-03 Thread Andres Gomez
Implicit conversions were added in the GLSL 1.20 spec version. Signed-off-by: Andres Gomez <ago...@igalia.com> --- src/compiler/glsl_types.cpp | 4 1 file changed, 4 insertions(+) diff --git a/src/compiler/glsl_types.cpp b/src/compiler/glsl_types.cpp index 8a06695..24aec25 100644 ---

[Mesa-dev] [PATCH 4/5] glsl: apply_implicit_conversion is static again

2016-08-03 Thread Andres Gomez
Signed-off-by: Andres Gomez <ago...@igalia.com> --- src/compiler/glsl/ast_function.cpp | 4 src/compiler/glsl/ast_to_hir.cpp | 2 +- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/src/compiler/glsl/ast_function.cpp b/src/compiler/glsl/ast_function.cpp index ccd070f..5

Re: [Mesa-dev] [PATCH 2/2] glsl: struct constructors/initializers only allow implicit conversions

2016-08-03 Thread Andres Gomez
On Mon, 2016-08-01 at 12:05 +0300, Andres Gomez wrote: > On Mon, 2016-08-01 at 10:01 +1000, Timothy Arceri wrote: > > On Sun, 2016-07-31 at 18:43 +0300, Andres Gomez wrote: > > [snip] > > > diff --git a/src/compiler/glsl/ast_function.cpp > > > b/src/compiler/

Re: [Mesa-dev] [PATCH] ast: Updated AST_NUM_OPERATORS for coherence with ast_operators

2016-08-02 Thread Andres Gomez
On Tue, 2016-08-02 at 17:04 +0100, Eric Engestrom wrote: > On Tue, Aug 02, 2016 at 12:20:54PM +0300, Andres Gomez wrote: [snip] > > I'm not sure I'm understanding what you mean. > > > > If you mean to remove the #define and add the value as and additional > > element

[Mesa-dev] [PATCH] dir-locals.el: show-trailing-whitespace and whitespace support

2016-08-02 Thread Andres Gomez
Signed-off-by: Andres Gomez <ago...@igalia.com> --- .dir-locals.el | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/.dir-locals.el b/.dir-locals.el index 4b53931..9c89a63 100644 --- a/.dir-locals.el +++ b/.dir-locals.el @@ -1,4 +1,5 @@ -((prog-mode +((nil .

Re: [Mesa-dev] [PATCH] ast: Updated AST_NUM_OPERATORS for coherence with ast_operators

2016-08-02 Thread Andres Gomez
On Mon, 2016-08-01 at 14:02 +0100, Eric Engestrom wrote: > On Sun, Jul 31, 2016 at 07:07:34PM +0300, Andres Gomez wrote: [snip] > > diff --git a/src/compiler/glsl/ast.h b/src/compiler/glsl/ast.h > > index 157895d..89f531c 100644 > > --- a/src/compiler/glsl/ast.h > > ++

Re: [Mesa-dev] [PATCH 2/2] glsl: struct constructors/initializers only allow implicit conversions

2016-08-01 Thread Andres Gomez
On Mon, 2016-08-01 at 12:05 +0300, Andres Gomez wrote: [snip] > it allows conversions from a vector or a bigger dimension to a vector of ---^^ > or a smaller dimension. That was making the CTS test fail. of^^ (Wake up, Andrés!!!) --  Br,

Re: [Mesa-dev] [PATCH 2/2] glsl: struct constructors/initializers only allow implicit conversions

2016-08-01 Thread Andres Gomez
On Mon, 2016-08-01 at 10:01 +1000, Timothy Arceri wrote: > On Sun, 2016-07-31 at 18:43 +0300, Andres Gomez wrote: [snip] > diff --git a/src/compiler/glsl/ast_function.cpp > > b/src/compiler/glsl/ast_function.cpp > > index 9dcec50..9b09cb6 100644 > > --- a/src/compil

Re: [Mesa-dev] [PATCH 1/2] glsl/types: disallow implicit conversions before GLSL 1.20

2016-08-01 Thread Andres Gomez
On Mon, 2016-08-01 at 09:35 +1000, Timothy Arceri wrote: > On Sun, 2016-07-31 at 18:43 +0300, Andres Gomez wrote: > > Implicit conversions were added in the GLSL 1.20 spec version. > > Does this help fix the CTS test or are you just adding it because you > noticed it? I

[Mesa-dev] [PATCH] ast: Updated AST_NUM_OPERATORS for coherence with ast_operators

2016-07-31 Thread Andres Gomez
AST_NUM_OPERATORS stores the dimension of the ast_operators enumeration but was not updated after its last modification. This doesn't add any real modification for any code paths but it makes sense for coherence. Signed-off-by: Andres Gomez <ago...@igalia.com> --- src/compiler/glsl

[Mesa-dev] [PATCH 1/2] glsl/types: disallow implicit conversions before GLSL 1.20

2016-07-31 Thread Andres Gomez
Implicit conversions were added in the GLSL 1.20 spec version. Signed-off-by: Andres Gomez <ago...@igalia.com> --- src/compiler/glsl_types.cpp | 4 1 file changed, 4 insertions(+) diff --git a/src/compiler/glsl_types.cpp b/src/compiler/glsl_types.cpp index 8a06695..24aec25 100644 ---

[Mesa-dev] [PATCH 2/2] glsl: struct constructors/initializers only allow implicit conversions

2016-07-31 Thread Andres Gomez
0 "Implicit Conversions". In the latter case, an implicit conversion will be done on the initializer before the assignment is done." Fixes GL44-CTS.shading_language_420pack.initializer_list_negative Signed-off-by: Andres Gomez <ago...@igalia.com> --- src

[Mesa-dev] [PATCH 0/2] struct constructors/initializers only allow implicit conversions

2016-07-31 Thread Andres Gomez
When an argument for a structure constructor or initializer doesn't match the expected type, only Section 4.1.10 “Implicit Conversions” are allowed to try to match that expected type. Fixes GL44-CTS.shading_language_420pack.initializer_list_negative Andres Gomez (2): glsl/types: disallow

Re: [Mesa-dev] [PATCH] glsl: subroutine types cannot be compared

2016-07-22 Thread Andres Gomez
On Fri, 2016-07-22 at 06:07 +1000, Dave Airlie wrote: > > > > On Mon, 2016-07-18 at 16:39 +0300, Andres Gomez wrote: > > > subroutine variables are to be used just in the way functions are > > > called. Although the spec doesn't say it explicitely, this me

Re: [Mesa-dev] [PATCH] glsl/ast: don't allow subroutine uniform comparisons

2016-07-19 Thread Andres Gomez
On Tue, 2016-07-19 at 13:45 -0700, Ian Romanick wrote: > On 07/19/2016 06:54 AM, Andres Gomez wrote: ... > > So, what would be the conclusion? Do we allow subroutine variables > > comparison? > > There is no conclusion yet. I opened a Khronos gitlab tracker (right > afte

Re: [Mesa-dev] [PATCH] glsl/ast: don't allow subroutine uniform comparisons

2016-07-19 Thread Andres Gomez
we use type->contains_subroutine() ? That way we would be having into account subroutine arrays too. Other than the open discussion about whether this is allowed by the specs or not, this is: Reviewed-by: Andres Gomez <ago...@igalia.com> -- Br, Andres ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] glsl/ast: don't allow subroutine uniform comparisons

2016-07-19 Thread Andres Gomez
Hi, Just dropped: https://lists.freedesktop.org/archives/mesa-dev/2016-July/123485.html I didn't realize there was already this thread open. On Tue, 2016-06-07 at 09:59 -0700, Ian Romanick wrote: > On 06/06/2016 10:20 PM, Dave Airlie wrote: > > From: Dave Airlie > > > >

Re: [Mesa-dev] [PATCH] glsl: subroutine types cannot be compared

2016-07-19 Thread Andres Gomez
Dropping this patch. It seems I overlooked: https://lists.freedesktop.org/archives/mesa-dev/2016-June/119616.html On Mon, 2016-07-18 at 16:39 +0300, Andres Gomez wrote: > subroutine variables are to be used just in the way functions are > called. Although the spec doesn't say it expli

[Mesa-dev] [PATCH] glsl: subroutine types cannot be compared

2016-07-18 Thread Andres Gomez
h that variable will call that particular function." Fixes GL44-CTS.shader_subroutine.subroutines_cannot_be_assigned_float_int_values_or_be_compared Signed-off-by: Andres Gomez <ago...@igalia.com> --- src/compiler/glsl/ast_to_hir.cpp | 4 1 file changed, 4 insertions(+) diff

Re: [Mesa-dev] [PATCH] Revert "i965: get PrimitiveMode from the program rather than the shader struct"

2016-06-30 Thread Andres Gomez
On Thu, 2016-06-30 at 10:21 +1000, Timothy Arceri wrote: > On Wed, 2016-06-29 at 17:23 +0300, Andres Gomez wrote: > > On Thu, 2016-06-30 at 00:09 +1000, Timothy Arceri wrote: > > > > > > On 29 June 2016 11:29:17 pm AEST, Andres Gomez <ago...@igalia.com > > &

Re: [Mesa-dev] [PATCH] glsl: atomic counters are different than their uniforms

2016-06-30 Thread Andres Gomez
On Thu, 2016-06-30 at 10:55 +1000, Timothy Arceri wrote: > On Mon, 2016-06-27 at 18:28 +0300, Andres Gomez wrote: > > The linker deals with atomic counters in terms of uniforms. This is > > OK > > but when we want to know the number of used atomic counters since a >

Re: [Mesa-dev] [PATCH] glsl: atomic counters are different than their uniforms

2016-06-30 Thread Andres Gomez
On Wed, 2016-06-29 at 18:37 -0700, Ian Romanick wrote: > On 06/27/2016 08:28 AM, Andres Gomez wrote: > > The linker deals with atomic counters in terms of uniforms. This is > > OK > > but when we want to know the number of used atomic counters since a > > 2 > &g

Re: [Mesa-dev] [PATCH] glsl: atomic counters are different than their uniforms

2016-06-30 Thread Andres Gomez
On Thu, 2016-06-30 at 00:29 -0700, Ian Romanick wrote: > On 06/29/2016 05:55 PM, Timothy Arceri wrote: ... > > > > So, I don't think there is a clear part of the spec to quote here, > and > I looked. :)  While the spec doesn't come right out and say it, I > think > we can infer that this

Re: [Mesa-dev] [PATCH] Revert "i965: get PrimitiveMode from the program rather than the shader struct"

2016-06-29 Thread Andres Gomez
On Thu, 2016-06-30 at 00:09 +1000, Timothy Arceri wrote: > > On 29 June 2016 11:29:17 pm AEST, Andres Gomez <ago...@igalia.com> > wrote: > > This reverts commit 644e015f0b9236e955d679cac4bcc7a1523fc475. > > > > PrimitiveMode from the program doesn't hold t

[Mesa-dev] [PATCH] Revert "i965: get PrimitiveMode from the program rather than the shader struct"

2016-06-29 Thread Andres Gomez
This reverts commit 644e015f0b9236e955d679cac4bcc7a1523fc475. PrimitiveMode from the program doesn't hold the proper value when reaching this code. We rather take it from the linked shader. Signed-off-by: Andres Gomez <ago...@igalia.com> --- src/mesa/drivers/dri/i965/brw_tcs.c | 5 +++--

[Mesa-dev] [PATCH] glsl: atomic counters are different than their uniforms

2016-06-27 Thread Andres Gomez
-CTS.arrays_of_arrays_gl.AtomicDeclaration Signed-off-by: Andres Gomez <ago...@igalia.com> --- src/compiler/glsl/link_atomics.cpp | 83 -- 1 file changed, 44 insertions(+), 39 deletions(-) diff --git a/src/compiler/glsl/link_atomics.cpp b/src/compile

[Mesa-dev] [PATCH] configure: added xcb to dri3 modules to pkg-conf

2016-05-20 Thread Andres Gomez
This fixes a recent linking error in libvulkan_common Signed-off-by: Andres Gomez <ago...@igalia.com> --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 6eee2bc..de62e8b 100644 --- a/configure.ac +++ b/configure.ac @@ -

Re: [Mesa-dev] About tolerance calculation on specific (builtin) functions

2016-05-09 Thread Andres Gomez
On Wed, 2016-05-04 at 13:48 -0400, Ilia Mirkin wrote: > On Wed, May 4, 2016 at 1:41 PM, Connor Abbott <cwabbo...@gmail.com> > wrote: > > > > On Wed, May 4, 2016 at 1:05 PM, Andres Gomez <ago...@igalia.com> > > wrote: > > > > > > Hi, >

[Mesa-dev] About tolerance calculation on specific (builtin) functions

2016-05-04 Thread Andres Gomez
Hi, as part of the work done to "Add FP64 support to the i965 shader backends" at: https://bugs.freedesktop.org/show_bug.cgi?id=92760 I've been working to add piglit tests that would check the new features added by this addition. Due to this, I've been checking and making modifications into the

Re: [Mesa-dev] [PATCH] glsl: Checks for interpolation into its own function.

2016-04-28 Thread Andres Gomez
On Tue, 2016-04-26 at 12:16 +0200, Samuel Iglesias Gonsálvez wrote: > On 04/04/16 18:50, Andres Gomez wrote: > > > > This generalizes the validation also to be done for variables > > inside > > interface blocks, which, for some cases, was missing. > > > >

Re: [Mesa-dev] [PATCH] glsl: Checks for interpolation into its own function.

2016-04-19 Thread Andres Gomez
Hi, On Tue, 2016-04-19 at 08:53 +1000, Timothy Arceri wrote: > On Mon, 2016-04-18 at 19:44 +0300, Andres Gomez wrote: > > > > Hi, > > > > I would really appreciate if you could find some time to review > > this > > patch. > Is there a patch somewhere

Re: [Mesa-dev] [PATCH] glsl: Checks for interpolation into its own function.

2016-04-18 Thread Andres Gomez
Hi, I would really appreciate if you could find some time to review this patch. Thanks! On Mon, 2016-04-04 at 19:50 +0300, Andres Gomez wrote: > This generalizes the validation also to be done for variables inside > interface blocks, which, for some cases, was missing. > > For

Re: [Mesa-dev] About border values in fp64 conversion tests

2016-04-14 Thread Andres Gomez
tination type range, and NaN gets > converted to 0. Hence why implementations tend to do this. But still > undefined in glsl (which, of course, doesn't mean someone might not > rely > on d3d10 behaviour there...). > > Roland > > > Am 05.04.2016 um 09:33 schrieb Andres Gomez:

Re: [Mesa-dev] [PATCH] glsl: Checks for interpolation into its own function.

2016-04-14 Thread Andres Gomez
Hi, this patch is still unreviewed. I'd welcome some help to get this into mesa :) -- Br, Andres signature.asc Description: This is a digitally signed message part ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

Re: [Mesa-dev] About border values in fp64 conversion tests

2016-04-05 Thread Andres Gomez
Hi, I haven't had any other feedback than Ilia's (thanks Ilia!) so my doubts still stand. I'd welcome more info regarding this topic. Thanks! Br. On Tue, 2016-03-15 at 17:46 +0200, Andres Gomez wrote: > Hi, > > as complementary work to the one done to "Add FP64 support to the &

Re: [Mesa-dev] About the usage of the "flat" interpolation qualifier with input (unsigned) integers and doubles in fragment shaders

2016-04-04 Thread Andres Gomez
Fri, Mar 4, 2016 at 5:43 AM, Andres Gomez <ago...@igalia.com > > <mailto:ago...@igalia.com>> wrote: > > > > Hi, > > > > as complementary work to the one done to "Add FP64 support to > > the i965 > > shader backends" at

[Mesa-dev] [PATCH] glsl: Checks for interpolation into its own function.

2016-04-04 Thread Andres Gomez
-by: Andres Gomez <ago...@igalia.com> --- src/compiler/glsl/ast_to_hir.cpp | 316 +-- 1 file changed, 171 insertions(+), 145 deletions(-) diff --git a/src/compiler/glsl/ast_to_hir.cpp b/src/compiler/glsl/ast_to_hir.cpp index 7c9be81..e4ebc6b 100644 ---

Re: [Mesa-dev] About border values in fp64 conversion tests

2016-03-18 Thread Andres Gomez
On Tue, 2016-03-15 at 12:38 -0400, Ilia Mirkin wrote: > Not really an answer to your question, but you may be interested in > this model of the NVIDIA Tesla FPU that mwk RE'd, including fp64 > (which was available on the G200 only in that series). I have no > reason to believe that Fermi+ are

[Mesa-dev] About border values in fp64 conversion tests

2016-03-15 Thread Andres Gomez
Hi, as complementary work to the one done to "Add FP64 support to the i965 shader backends" at: https://bugs.freedesktop.org/show_bug.cgi?id=92760 I've been working to add piglit tests that would check the new features added by this addition. One of the topics we have been creating tests for is

Re: [Mesa-dev] About the usage of the "flat" interpolation qualifier with input (unsigned) integers and doubles in fragment shaders

2016-03-15 Thread Andres Gomez
ent shader for (unsigned) integers and doubles. * Open a bug in Khronos specs bugzilla about the ambiguity of this. Br. On Fri, 2016-03-04 at 15:43 +0200, Andres Gomez wrote: > Hi, > > as complementary work to the one done to "Add FP64 support to the i965 > s

Re: [Mesa-dev] About tests for extensions that are later integrated in the core specs

2016-03-08 Thread Andres Gomez
On Fri, 2016-03-04 at 11:49 -0800, Matt Turner wrote: ... > So to answer your main question, I would generate tests for both > glsl-4.00 and arb_gpu_shader_fp64, but only manually write tests for > arb_gpu_shader_fp64. Thanks for the early reply, Matt! We will do as you suggest. -- Br, Andres

[Mesa-dev] About tests for extensions that are later integrated in the core specs

2016-03-04 Thread Andres Gomez
Hi, as complementary work to the one done to "Add FP64 support to the i965 shader backends" at: https://bugs.freedesktop.org/show_bug.cgi?id=92760 We've been working to add piglit tests that would check the new features added by this addition. Because of this, we have created several generators.

Re: [Mesa-dev] About the usage of the "flat" interpolation qualifier with input (unsigned) integers and doubles in fragment shaders

2016-03-04 Thread Andres Gomez
I tried to be careful, and still I introduced a mistake ... On Fri, 2016-03-04 at 15:43 +0200, Andres Gomez wrote: ... > The situation with the glslangValidator is (it doesn't support doubles): > * When using a non-flat integer as a fragment input in the form of >

[Mesa-dev] About the usage of the "flat" interpolation qualifier with input (unsigned) integers and doubles in fragment shaders

2016-03-04 Thread Andres Gomez
Hi, as complementary work to the one done to "Add FP64 support to the i965 shader backends" at: https://bugs.freedesktop.org/show_bug.cgi?id=92760 I've been working to add piglit tests that would check the new features added by this addition. Checking the specification of the extension, when

[Mesa-dev] [PATCH] glsl/ast: Implicit conversion from double to float is not allowed

2016-02-20 Thread Andres Gomez
Also, renamed get_conversion_operation to avoid future misunderstandings. --- src/compiler/glsl/ast_to_hir.cpp | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/compiler/glsl/ast_to_hir.cpp b/src/compiler/glsl/ast_to_hir.cpp index 75abef6..db5ec9a 100644 ---

Re: [Mesa-dev] [PATCH] i965/brw_reg: struct constructor now needs explicit negate and abs values.

2014-12-15 Thread Andres Gomez
On Mon, 2014-12-15 at 11:24 -0800, Matt Turner wrote: On Mon, Dec 15, 2014 at 11:03 AM, Matt Turner matts...@gmail.com wrote: Reviewed-by: Matt Turner matts...@gmail.com Cc: 10.4 10.3 mesa-sta...@lists.freedesktop.org Oh, I suppose I need to commit this and the piglit test? Just confirm

[Mesa-dev] [PATCH] i965: negative and abs modifiers in derivative operators

2014-12-12 Thread Andres Gomez
This patch is intended to fix: https://bugs.freedesktop.org/show_bug.cgi?id=82991 Which is now also exposed through the piglit patch sent at: http://lists.freedesktop.org/archives/piglit/2014-December/013648.html Andres Gomez (1): i965/brw_reg: struct constructor now needs explicit negate

[Mesa-dev] [PATCH] i965/brw_reg: struct constructor now needs explicit negate and abs values.

2014-12-12 Thread Andres Gomez
We were asuming, when constructing a new brw_reg struct, that the negate and abs register modifiers would not be present by default in the new register. Now, we force explicitly setting these values when constructing a new register. This will avoid problems like forgetting to properly set them

Re: [Mesa-dev] [PATCH] glsl_compiler: Add binding hash tables to avoid SIGSEVs on linking stage

2014-11-18 Thread Andres Gomez
On Mon, 2014-11-17 at 09:25 -0700, Brian Paul wrote: Please split up this patch into: 1. gallium comment fixes 2. linker string fixes 3. hash table code changes Sure. I thought it was not worth given the small changes but I suppose it is always better to have different topics in different

[Mesa-dev] [PATCH 3/3] glsl_compiler: Add binding hash tables to avoid SIGSEVs on linking stage

2014-11-18 Thread Andres Gomez
When using the stand alone compiler, if we try to link a shader with vertex attributes it will segfault on linking as the binding hash tables are not included in the shader program. Obviously, we cannot make the linking stage succeed without the bound attributes but we can prevent the crash and

[Mesa-dev] [PATCH] glsl_compiler: Add binding hash tables to avoid SIGSEVs on linking stage

2014-11-17 Thread Andres Gomez
When using the stand alone compiler, if we try to link a shader with vertex attributes it will segfault on linking as the binding hash tables are not included in the shader program. Obviously, we cannot make the linking stage succeed without the bound attributes but we can prevent the crash and

[Mesa-dev] [PATCH] glsl: Standardize names and fix typos

2014-10-24 Thread Andres Gomez
--- src/glsl/linker.cpp | 4 ++-- src/glsl/lower_offset_array.cpp | 10 +- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/glsl/linker.cpp b/src/glsl/linker.cpp index 47a722d..c3f435c 100644 --- a/src/glsl/linker.cpp +++ b/src/glsl/linker.cpp @@ -1679,7

[Mesa-dev] [PATCH] glsl: Update and fix typos in README.

2014-10-16 Thread Andres Gomez
--- src/glsl/README | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/glsl/README b/src/glsl/README index 0a0afcc..2f93f12 100644 --- a/src/glsl/README +++ b/src/glsl/README @@ -8,7 +8,7 @@ passed straight through. See glcpp/* 2) lex and yacc-based

[Mesa-dev] [PATCH] configure.ac: check for libexpat when no pkg-config is available

2014-10-07 Thread Andres Gomez
Previously, when no pkg-config was available for libexpat we would just add the needed linking flags without any extra check. Now, we check that the library and the headers are also installed in the building environment. --- configure.ac | 15 +++ 1 file changed, 7 insertions(+), 8

<    2   3   4   5   6   7