Re: [Mesa-dev] [PATCH 2/2] r600/compute: Mark several functions as static

On Mon, 2018-05-21 at 09:34 -0500, Aaron Watry wrote: > On Mon, May 21, 2018 at 9:34 AM, Aaron Watry <awa...@gmail.com> > wrote: > > On Mon, May 21, 2018 at 6:25 AM, Bruno Jimenez <brunoji...@gmail.co > > m> wrote: > > > On Fri, 2018-05-18 at 22:52 -0400, Ja

Re: [Mesa-dev] [PATCH 2/2] r600/compute: Mark several functions as static

On Fri, 2018-05-18 at 22:52 -0400, Jan Vesely wrote: > On Fri, 2018-05-18 at 21:31 -0500, Aaron Watry wrote: > > On Fri, May 18, 2018 at 1:15 PM, Jan Vesely > > wrote: > > > On Thu, 2018-05-17 at 19:20 -0500, Aaron Watry wrote: > > > > They're not used anywhere else, so

Re: [Mesa-dev] [PATCH 1/2] r600: Fix some printf format warns pretaining to PRIi64

Hi, I don't know if you will believe it or not, but I have just written a very similar patch to yours :) Anyway, yours have come first so have my Reviewed-by: Bruno Jiménez brunoji...@gmail.com Note: I have no permissions in the git repo, you should ask someone to push this patch for you. -

Re: [Mesa-dev] [PATCH 1/4] freedreno/a3xx: add support for disabling depth clipping

On Sat, 2015-04-25 at 18:59 -0400, Ilia Mirkin wrote: On Sat, Apr 25, 2015 at 6:57 PM, Bruno Jimenez brunoji...@gmail.com wrote: On Sat, 2015-04-25 at 15:00 -0400, Ilia Mirkin wrote: Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- docs/relnotes/10.6.0.html

Re: [Mesa-dev] [PATCH 1/4] freedreno/a3xx: add support for disabling depth clipping

On Sat, 2015-04-25 at 15:00 -0400, Ilia Mirkin wrote: Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- docs/relnotes/10.6.0.html | 7 --- src/gallium/drivers/freedreno/a3xx/fd3_rasterizer.c | 2 ++ src/gallium/drivers/freedreno/freedreno_screen.c| 2 +-

Re: [Mesa-dev] Summer of Code ideas (maybe just an idea wishlist?)

On Wed, 2015-03-18 at 16:37 -0700, Jason Ekstrand wrote: On Wed, Mar 18, 2015 at 4:27 PM, Connor Abbott cwabbo...@gmail.com wrote: On Wed, Mar 18, 2015 at 2:58 PM, Matt Turner matts...@gmail.com wrote: On Thu, Mar 12, 2015 at 9:46 PM, Matt Turner matts...@gmail.com wrote: Here are some

Re: [Mesa-dev] Summer of Code ideas (maybe just an idea wishlist?)

Hi, Last year, I participated in GSoC, (yeah, I still read the mailing list every day :) ) so I will give my 2 cents to the topic. My background isn't at all related to graphics or computer science, I am a physicist, although my main interest is in simulation. So that took me to OpenCL, which in

Re: [Mesa-dev] [PATCH 11/22] glsl: Add ir_binop_mul to get_range

On Sat, 2015-01-03 at 20:18 +0100, Thomas Helland wrote: V2: Add some air for readability Use the new IS_CONSTANT macro Combine if-blocks for reduced code-duplication Split out into separate function for reuse later --- src/glsl/opt_minmax.cpp | 33

Re: [Mesa-dev] [PATCH 11/16] glsl: Add ir_binop_pow to get_range

On Mon, 2014-11-17 at 02:51 +0100, Thomas Helland wrote: The spec states that pow is undefined for x 0. Just set the range to correspond to a constant 0 if this is the case. --- src/glsl/opt_minmax.cpp | 11 +++ 1 file changed, 11 insertions(+) diff --git

Re: [Mesa-dev] [PATCH 2/3] mesa/main: Add sse2 streaming clamping

On Wed, 2014-11-12 at 21:47 +0200, Juha-Pekka Heikkila wrote: On 12.11.2014 19:36, Bruno Jimenez wrote: On Wed, 2014-11-12 at 14:50 +0200, Juha-Pekka Heikkila wrote: Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/mesa/Makefile.am | 8 +++ src/mesa

Re: [Mesa-dev] [PATCH 2/3] mesa/main: Add sse2 streaming clamping

On Wed, 2014-11-12 at 14:50 +0200, Juha-Pekka Heikkila wrote: Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/mesa/Makefile.am | 8 +++ src/mesa/main/sse2_clamping.c | 138 ++ src/mesa/main/sse2_clamping.h | 49

Re: [Mesa-dev] [PATCH V2] mesa: Permanently enable features supported by target CPU at compile time.

On Sun, 2014-11-09 at 14:24 +1100, Timothy Arceri wrote: On Sat, 2014-11-08 at 18:25 +, Emil Velikov wrote: On 08/11/14 08:35, Siavash Eliasi wrote: This will remove the need for unnecessary runtime checks for CPU features if already supported by target CPU, resulting in smaller

Re: [Mesa-dev] [PATCH][RFC] mesa/main: Clamp rgba with streamed sse

On Mon, 2014-11-03 at 20:39 +1100, Timothy Arceri wrote: On Fri, 2014-10-31 at 17:24 +, Jose Fonseca wrote: On 31/10/14 17:01, Matt Turner wrote: On Fri, Oct 31, 2014 at 4:12 AM, Jose Fonseca jfons...@vmware.com wrote: On 31/10/14 10:13, Juha-Pekka Heikkila wrote:

Re: [Mesa-dev] [PATCH V4] mesa: add SSE optimisation for glDrawElements

On Wed, 2014-10-29 at 23:09 +1100, Timothy Arceri wrote: On Wed, 2014-10-29 at 16:58 +1100, Timothy Arceri wrote: On Tue, 2014-10-28 at 22:14 +, Bruno Jimenez wrote: Hi, I haven't had time to play yet with OpenMP, but I have seen the assembly it produces in my computer. If I

Re: [Mesa-dev] [PATCH V4] mesa: add SSE optimisation for glDrawElements

On Wed, 2014-10-29 at 07:49 +1100, Timothy Arceri wrote: On Mon, 2014-10-27 at 20:04 +, Bruno Jimenez wrote: [snip] + + if (aligned_count = 4) { ^^ Hi, I have been thinking and I think that you can change that 4 for an 8

Re: [Mesa-dev] [PATCH V4] mesa: add SSE optimisation for glDrawElements

On Mon, 2014-10-27 at 08:37 +1100, Timothy Arceri wrote: Makes use of SSE to speed up compute of min and max elements Callgrind cpu usage results from pts benchmarks: Openarena 0.8.8: 3.67% - 1.03% UrbanTerror: 2.36% - 0.81% Signed-off-by: Timothy Arceri t_arc...@yahoo.com.au ---

Re: [Mesa-dev] [PATCH V4] mesa: add SSE optimisation for glDrawElements

[snip] + + if (aligned_count = 4) { ^^ Hi, I have been thinking and I think that you can change that 4 for an 8. In the case aligned_count == 4 there's no gain in using SSE, as you will have to do a final reduction from 4 elements to 1. Either

Re: [Mesa-dev] [PATCH V3] mesa: add SSE optimisation for glDrawElements

On Sun, 2014-10-26 at 10:47 +1100, Timothy Arceri wrote: Makes use of SSE to speed up compute of min and max elements Callgrind cpu usage results from pts benchmarks: Openarena 0.8.8: 3.67% - 1.03% UrbanTerror: 2.36% - 0.81% Signed-off-by: Timothy Arceri t_arc...@yahoo.com.au ---

Re: [Mesa-dev] [PATCH 12/16] gallium/auxiliary: add contained and rect checks

On Sat, 2014-10-18 at 13:55 +0200, David Heidelberger wrote: From: Christoph Bumiller christoph.bumil...@speed.at Signed-off-by: David Heidelberger david.heidelber...@ixit.cz --- src/gallium/auxiliary/util/u_box.h | 201

Re: [Mesa-dev] [PATCH v2] r600: Use DMA transfers in r600_copy_global_buffer

Hi, Sorry for not answering until now, but I have had some personal issues (changing university, moving to another city...) As you said, this is used from clover's resource::copy, which is used by clEnqueueCopyBuffer if I remember correctly (and understand correctly clover) If it doesn't regress

Re: [Mesa-dev] [PATCH] r600: Use DMA transfers in r600_copy_global_buffer

On Mon, 2014-09-08 at 18:30 +0200, Niels Ole Salscheider wrote: On Monday 08 September 2014, 15:19:15, Bruno Jimenez wrote: Hi, I'm not sure if this will work. Imagine this case: We have an item in the pool, and we want to use r600_resource_copy_region with it, for example because

Re: [Mesa-dev] [PATCH] r600: Use DMA transfers in r600_copy_global_buffer

Hi, I'm not sure if this will work. Imagine this case: We have an item in the pool, and we want to use r600_resource_copy_region with it, for example because we want to demote it. This will call r600_copy_global_buffer, and with your patch it will call r600_compute_global_demote_or_alloc, which

Re: [Mesa-dev] [PATCH] r600/compute: Don't leak compute pool item_list/unallocated_list

On Mon, 2014-08-25 at 18:04 +0200, Jan Vesely wrote: On Sat, 2014-08-23 at 17:01 +0200, Bruno Jimenez wrote: On Thu, 2014-08-21 at 14:37 -0500, Aaron Watry wrote: v2: Change to C-style comments and fix indentation Signed-off-by: Aaron Watry awa...@gmail.com --- src/gallium

Re: [Mesa-dev] [PATCH] r600/compute: Don't leak compute pool item_list/unallocated_list

On Mon, 2014-08-25 at 09:35 -0500, Aaron Watry wrote: On Sat, Aug 23, 2014 at 10:01 AM, Bruno Jimenez brunoji...@gmail.com wrote: On Thu, 2014-08-21 at 14:37 -0500, Aaron Watry wrote: v2: Change to C-style comments and fix indentation Signed-off-by: Aaron Watry awa...@gmail.com

Re: [Mesa-dev] [PATCH] r600/compute: Don't leak compute pool item_list/unallocated_list

On Thu, 2014-08-21 at 14:37 -0500, Aaron Watry wrote: v2: Change to C-style comments and fix indentation Signed-off-by: Aaron Watry awa...@gmail.com --- src/gallium/drivers/r600/compute_memory_pool.c | 5 + 1 file changed, 5 insertions(+) diff --git

Re: [Mesa-dev] [PATCH] r600g/compute: Fix Warnings

On Sat, 2014-08-09 at 23:51 +0200, Marek Olšák wrote: Hi Bruno, Sorry, I fixed the warnings by myself before I saw your patch. Marek Hi Marek, Don't worry, the important thing is that whe warnings are fixed. Thanks! Bruno On Thu, Aug 7, 2014 at 12:07 PM, Bruno Jiménez

Re: [Mesa-dev] [PATCH v2] clover: Add support for CL_MAP_WRITE_INVALIDATE_REGION

On Fri, 2014-08-08 at 18:10 +0300, Francisco Jerez wrote: Bruno Jiménez brunoji...@gmail.com writes: OpenCL 1.2 CL_MAP_WRITE_INVALIDATE_REGION sounds a lot like PIPE_TRANSFER_DISCARD_RANGE: From OpenCL 1.2 spec: The contents of the region being mapped are to be discarded. From

Re: [Mesa-dev] [PATCH] clover: Add support for CL_MAP_WRITE_INVALIDATE_REGION

On Thu, 2014-08-07 at 14:57 +0300, Francisco Jerez wrote: Bruno Jiménez brunoji...@gmail.com writes: OpenCL 1.2 CL_MAP_WRITE_INVALIDATE_REGION sounds a lot like PIPE_TRANSFER_DISCARD_RANGE: From OpenCL 1.2 spec: The contents of the region being mapped are to be discarded. From

Re: [Mesa-dev] [PATCH 3/3] r600g/compute: Defrag the pool at the same time as we grow it

On Fri, 2014-07-25 at 17:54 -0400, Tom Stellard wrote: On Fri, Jul 25, 2014 at 11:28:19PM +0200, Bruno Jimenez wrote: On Fri, 2014-07-25 at 12:46 -0400, Tom Stellard wrote: On Sat, Jul 19, 2014 at 07:35:51PM +0200, Bruno Jiménez wrote: This allows us two things: we now need less item

Re: [Mesa-dev] [PATCH 3/3] r600g/compute: Defrag the pool at the same time as we grow it

On Fri, 2014-07-25 at 12:46 -0400, Tom Stellard wrote: On Sat, Jul 19, 2014 at 07:35:51PM +0200, Bruno Jiménez wrote: This allows us two things: we now need less item copies when we have to defrag+grow the pool (to just one copy per item) and, even in the case where we don't need to defrag

Re: [Mesa-dev] [PATCH 0/5] [RFC] r600g/compute: Adding support for defragmenting compute_memory_pool

On Wed, 2014-07-23 at 10:33 -0400, Tom Stellard wrote: On Fri, Jul 18, 2014 at 01:09:03PM +0200, Bruno Jimenez wrote: On Thu, 2014-07-17 at 22:56 -0400, Tom Stellard wrote: On Wed, Jul 16, 2014 at 11:12:42PM +0200, Bruno Jiménez wrote: Hi, This series finally adds support

Re: [Mesa-dev] [PATCH 1/3] r600g/compute: Allow compute_memory_move_item to move items between resources

On Wed, 2014-07-23 at 10:46 -0400, Tom Stellard wrote: On Sat, Jul 19, 2014 at 07:35:49PM +0200, Bruno Jiménez wrote: --- src/gallium/drivers/r600/compute_memory_pool.c | 43 ++ src/gallium/drivers/r600/compute_memory_pool.h | 1 + 2 files changed, 25

Re: [Mesa-dev] [PATCH 1/1] r600: Fix use after free in compute_memory_promote_item.

inconvenience this may have caused. This fixes crashes and assertion failures in two gegl tests. Signed-off-by: Jan Vesely jan.ves...@rutgers.edu CC: Bruno Jimenez brunoji...@gmail.com CC: Tom Stellard thomas.stell...@amd.com --- src/gallium/drivers/r600/compute_memory_pool.c | 3 ++- 1 file

Re: [Mesa-dev] Testing OpenCL with gegl

Hi, Have you built gegl with the patches that Jan sent to the mailing list? You can find them here: http://lists.freedesktop.org/archives/mesa-dev/2014-June/061880.html Hope it helps! Bruno On Sat, 2014-06-21 at 09:17 +0300, Kertesz Laszlo wrote: Hmm. I get GEGL_DEBUG=opencl

Re: [Mesa-dev] [PATCH 00/11] [RFC v2] Solve the mapping bug

On Sat, 2014-06-21 at 17:39 +0200, Francisco Jerez wrote: Bruno Jiménez brunoji...@gmail.com writes: Hi, This is my second attempt to fix the mapping bug adding all the suggestions that Tom Stellard sent, and, so far, it seems that it is resolved. This series changes completely

Re: [Mesa-dev] Testing OpenCL with gegl

On Fri, 2014-06-20 at 09:31 -0400, Jan Vesely wrote: On Fri, 2014-06-20 at 10:27 +0200, Bruno Jimenez wrote: Hi, Hi Bruno, I have added mesa list to CC as others might be interested. Hope you don't mind. Sure, no problem. I have built babl and gegl but I don't know how to run

Re: [Mesa-dev] [PATCH 00/11] [RFC v2] Solve the mapping bug

On Fri, 2014-06-20 at 13:50 -0400, Tom Stellard wrote: On Wed, Jun 18, 2014 at 05:01:50PM +0200, Bruno Jiménez wrote: Hi, This is my second attempt to fix the mapping bug adding all the suggestions that Tom Stellard sent, and, so far, it seems that it is resolved. This series

Re: [Mesa-dev] [PATCH 11/11] clover: Use PIPE_TRANSFER_MAP_DIRECTLY when writing/reading buffers

On Thu, 2014-06-19 at 10:23 +0900, Michel Dänzer wrote: On 19.06.2014 00:02, Bruno Jiménez wrote: Note: This is just a proof of concept. --- src/gallium/state_trackers/clover/api/transfer.cpp | 4 ++-- src/gallium/state_trackers/clover/core/object.hpp | 4

Re: [Mesa-dev] [PATCH 2/2] r600: Handle failures in compute_memory_pool_finalize

Hi, To which failure are you refering? Could you please send me a test/program that I can try to track this down? Thanks! Bruno On Thu, 2014-06-19 at 10:21 -0400, Jan Vesely wrote: Signed-off-by: Jan Vesely jan.ves...@rutgers.edu CC: Bruno Jimenez brunoji...@gmail.com --- The failure now

Re: [Mesa-dev] [PATCH 1/2] r600: Fix possible endless loop in compute_memory_pool allocations.

growing the pool. The change in the aux-need calculation guarantees max 2 iterations, and avoids wasting memory in case a smaller item can't fit into a relatively larger pool. Signed-off-by: Jan Vesely jan.ves...@rutgers.edu CC: Bruno Jimenez brunoji...@gmail.com --- This fixes hang

Re: [Mesa-dev] [PATCH 1/2] r600: Fix possible endless loop in compute_memory_pool allocations.

to rebase my series on top of yours. Thanks! Bruno regards, Jan -Tom Signed-off-by: Jan Vesely jan.ves...@rutgers.edu CC: Bruno Jimenez brunoji...@gmail.com --- This fixes hang in gegl colors.xml test src/gallium/drivers/r600/compute_memory_pool.c | 7 +-- 1

Re: [Mesa-dev] [PATCH 1/2] r600: Fix possible endless loop in compute_memory_pool allocations.

On Thu, 2014-06-19 at 13:39 -0400, Jan Vesely wrote: On Thu, 2014-06-19 at 18:22 +0200, Bruno Jimenez wrote: On Thu, 2014-06-19 at 11:58 -0400, Jan Vesely wrote: On Thu, 2014-06-19 at 08:27 -0700, Tom Stellard wrote: On Thu, Jun 19, 2014 at 10:21:32AM -0400, Jan Vesely wrote

Re: [Mesa-dev] [PATCH 5/5] clover: Enable cl_khr_fp64 for devices that support doubles

Hi, I have a couple of questions about this patch: 1) Could you please also change how the results of the 'CL_DEVICE_NATIVE_VECTOR_WIDTH_DOUBLE' and 'CL_DEVICE_PREFERRED_VECTOR_WIDTH_DOUBLE' queries are generated? According to the spec, if 'cl_khr_fp64' is not supported, they should be 0. 2)

Re: [Mesa-dev] [PATCH] radeon/compute: Always report at least 1 compute unit

Hi, Looks good to me. -Bruno On Fri, 2014-06-13 at 12:58 -0400, Tom Stellard wrote: Some apps will abort if they detect 0 compute units. This fixes crashes in some OpenCV tests. --- src/gallium/drivers/radeon/r600_pipe_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [Mesa-dev] [PATCH 2/3] radeon/compute: Implement PIPE_COMPUTE_CAP_MAX_COMPUTE_UNITS

On Tue, 2014-06-10 at 14:10 -0400, Tom Stellard wrote: On Thu, Jun 05, 2014 at 08:39:29PM +0200, Bruno Jimenez wrote: With a couple of changes, it applied cleanly to 3.14.5 (Arch's stable). And with the attached patch as #2 for my series I can get the correct number of compute units

Re: [Mesa-dev] [PATCH 2/3] radeon/compute: Implement PIPE_COMPUTE_CAP_MAX_COMPUTE_UNITS

On Tue, 2014-06-03 at 08:55 -0400, Alex Deucher wrote: On Mon, Jun 2, 2014 at 7:34 PM, Bruno Jimenez brunoji...@gmail.com wrote: On Mon, 2014-06-02 at 16:16 -0400, Alex Deucher wrote: On Sat, May 31, 2014 at 7:13 AM, Bruno Jimenez brunoji...@gmail.com wrote: On Fri, 2014-05-30 at 19:33

Re: [Mesa-dev] [PATCH 2/3] radeon/compute: Implement PIPE_COMPUTE_CAP_MAX_COMPUTE_UNITS

On Mon, 2014-06-02 at 16:16 -0400, Alex Deucher wrote: On Sat, May 31, 2014 at 7:13 AM, Bruno Jimenez brunoji...@gmail.com wrote: On Fri, 2014-05-30 at 19:33 -0400, Alex Deucher wrote: On Fri, May 30, 2014 at 11:31 AM, Bruno Jiménez brunoji...@gmail.com wrote: The data has been

Re: [Mesa-dev] [PATCH 2/3] radeon/compute: Implement PIPE_COMPUTE_CAP_MAX_COMPUTE_UNITS

On Fri, 2014-05-30 at 19:33 -0400, Alex Deucher wrote: On Fri, May 30, 2014 at 11:31 AM, Bruno Jiménez brunoji...@gmail.com wrote: The data has been extracted from: AMD Accelerated Parallel Processing OpenCL Programming Guide (rev 2.7) Appendix D: Device Parameters You should add a query

[Mesa-dev] [RFC] clover: Attempt to make clover fail when a kernel fails to build

Hi, I'm trying to make clover fail in the case that a kernel fails to build. My first attempt has been to track a llvm compile failure up from 'radeon_llvm_compile' (at radeon/radeon_llvm_emit.c), through 'r600_llvm_compile' (at r600/r600_llvm.c) and through 'evergreen_launch_grid' (at

Re: [Mesa-dev] [RFC] clover: Attempt to make clover fail when a kernel fails to build

On Thu, 2014-05-15 at 22:42 +0200, Francisco Jerez wrote: Tom Stellard t...@stellard.net writes: On Thu, May 15, 2014 at 06:22:11PM +0200, Francisco Jerez wrote: Bruno Jimenez brunoji...@gmail.com writes: Hi, I'm trying to make clover fail in the case that a kernel fails

Re: [Mesa-dev] [PATCH 1/3] gallium: Add PIPE_COMPUTE_CAP_MAX_CLOCK_FREQUENCY

On Fri, 2014-04-18 at 12:08 +0200, Francisco Jerez wrote: Bruno Jiménez brunoji...@gmail.com writes: From: Tom Stellard thomas.stell...@amd.com --- src/gallium/include/pipe/p_defines.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

Re: [Mesa-dev] [PATCH 1/3] r600g, radeonsi: use a fallback in dma_copy instead of failing

This series fixes some of the opencv opencl-related tests for me. Thanks! On Sun, 2014-03-09 at 02:24 +0100, Marek Olšák wrote: From: Marek Olšák marek.ol...@amd.com --- src/gallium/drivers/r600/evergreen_state.c | 37 +--- src/gallium/drivers/r600/r600_state.c

Re: [Mesa-dev] [PATCH 2/2] clover: Fix building with latest llvm

It's strange, I have just compiled with the latest llvm revision at Arch's mesa-git repo (202852) without problems. I'm not an automake expert either, but at gallium/auxiliary/Makefile.am there's this: AM_CXXFLAGS += \ $(GALLIUM_CFLAGS) \ $(LLVM_CXXFLAGS) So I suppose, of course

Re: [Mesa-dev] [PATCH] clover: Fix building with latest llvm

On Sun, 2014-03-02 at 04:26 -0500, Ilia Mirkin wrote: On Sat, Mar 1, 2014 at 7:35 PM, Francisco Jerez curroje...@riseup.net wrote: Bruno Jiménez brunoji...@gmail.com writes: Recently, llvm has changed to use c++11, so we also should use it ---

Re: [Mesa-dev] [PATCH] clover: Don't call pipe_loader_release() when deleting a device

On Tue, 2014-02-18 at 17:50 +0100, Francisco Jerez wrote: Tom Stellard t...@stellard.net writes: From: Tom Stellard thomas.stell...@amd.com After pipe_loader_release() is called, if any of the pipe_* objects try to call into the gallium API the application will segfault. The only

Re: [Mesa-dev] [PATCH 2/3] driconf: Correct and update Spanish translations

On Tue, 2014-01-14 at 22:07 -0700, Alex Henrie wrote: 2014/1/14 Bruno Jimenez brunoji...@gmail.com: I think I prefer without la, but if you prefer with, it's also ok. I also prefer to omit the la. To me, it sounds better renderizado. As usual, RAE doesn't say anything, and wikipedia

Re: [Mesa-dev] [PATCH 2/3] driconf: Correct and update Spanish translations

On Wed, 2014-01-15 at 01:14 -0800, Eric Anholt wrote: Alex Henrie alexhenri...@gmail.com writes: --- src/mesa/drivers/dri/common/xmlpool/es.po | 65 --- 1 file changed, 33 insertions(+), 32 deletions(-) diff --git

Re: [Mesa-dev] [PATCH 2/3] driconf: Correct and update Spanish translations

Hi, Just a couple of comments to the Spanish translation. Maybe there's others messages that may be changed, but I lack context to do so. On Tue, 2014-01-14 at 11:25 -0700, Alex Henrie wrote: --- src/mesa/drivers/dri/common/xmlpool/es.po | 59 --- 1 file

Re: [Mesa-dev] [PATCH 2/3] driconf: Correct and update Spanish translations

On Tue, 2014-01-14 at 15:35 -0700, Alex Henrie wrote: 2014/1/14 Bruno Jimenez brunoji...@gmail.com I'm not sure about la fuente GLSL, even though it's the correct translation, I think in Spanish we talk more about source code and code. So I think that el código GLSL would be a better

Re: [Mesa-dev] [PATCH 2/3] driconf: Correct and update Spanish translations

On Tue, 2014-01-14 at 17:39 -0700, Alex Henrie wrote: 2014/1/14 Bruno Jimenez brunoji...@gmail.com: I think we are still missing a los: Forzar una versión de GLSL por defecto en los shaders a los que les falta una línea #versión explícita If we include a second los then it doesn't sound

Re: [Mesa-dev] [PATCH 2/5] Adding checks for NULL after CALLOC

On Mon, 2014-01-06 at 12:51 -0500, Alex Deucher wrote: On Mon, Jan 6, 2014 at 10:15 AM, Bruno Jiménez brunoji...@gmail.com wrote: --- src/gallium/drivers/r600/compute_memory_pool.c | 8 1 file changed, 8 insertions(+) diff --git a/src/gallium/drivers/r600/compute_memory_pool.c

Re: [Mesa-dev] [PATCH 4/5] Tidy a bit compute_memory_finalize_pending

On Sat, 2014-01-04 at 08:52 -0800, Tom Stellard wrote: On Sat, Jan 04, 2014 at 01:27:32AM +0100, Bruno Jiménez wrote: --- src/gallium/drivers/r600/compute_memory_pool.c | 18 +++--- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git