[Mesa-dev] [PATCH 3/3] anv: Use vk_outarray in vkGetPhysicalDeviceQueueFamilyProperties

No intended change in behavior. Just a refactor. --- src/intel/vulkan/anv_device.c | 73 +++ 1 file changed, 18 insertions(+), 55 deletions(-) diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c index 35c5a4645ff..21130feac82 100644

Re: [Mesa-dev] [PATCH 1/3] anv: Add anv_outarray

On Wed 08 Mar 2017, Chad Versace wrote: > On Mon 06 Mar 2017, Jason Ekstrand wrote: > > On Mon, Mar 6, 2017 at 10:25 AM, Chad Versace <chadvers...@chromium.org> > > wrote: > > > > > anv_outarray is a wrapper for a Vulkan output array. A Vulkan output > >

Re: [Mesa-dev] [PATCH 1/3] anv: Add anv_outarray

On Mon 06 Mar 2017, Jason Ekstrand wrote: > On Mon, Mar 6, 2017 at 10:25 AM, Chad Versace <chadvers...@chromium.org> > wrote: > > > anv_outarray is a wrapper for a Vulkan output array. A Vulkan output > > array is one that follows the c

Re: [Mesa-dev] [PATCH 4/6] isl: Let isl_surf_init's caller set the exact row pitch

On Wed 08 Mar 2017, Jason Ekstrand wrote: > On Wed, Mar 8, 2017 at 4:16 PM, Chad Versace <chadvers...@chromium.org> > wrote: > > > On Mon 06 Mar 2017, Jason Ekstrand wrote: > > > On Mon, Mar 6, 2017 at 10:12 AM, Chad Versace <chadvers...@chromium.org> > >

Re: [Mesa-dev] [PATCH 5/5] anv: Handle failure in make_hiz_surface_maybe()

On Mon 06 Mar 2017, Jason Ekstrand wrote: > On Mon, Mar 6, 2017 at 10:18 AM, Chad Versace <chadvers...@chromium.org> > wrote: > > > make_ccs_surface_maybe() correctly handles failure > > isl_surf_get_ccs_surf(). When it fails, the resultant VkImage is still > >

Re: [Mesa-dev] [PATCH 4/5] anv/image: Refactor creation of aux surfaces

On Mon 06 Mar 2017, Jason Ekstrand wrote: > On Mon, Mar 6, 2017 at 10:18 AM, Chad Versace <chadvers...@chromium.org> > wrote: > > > Creation of hiz, ccs, and mcs surfaces was encoded by a giant 'if' tree > > at the tail of make_surface(). This patch extracts that

Re: [Mesa-dev] [PATCH 3/5] anv/image: Fix return type of make_surface()

On Mon 06 Mar 2017, Jason Ekstrand wrote: > With modifiers, aren't we going to want to be able to reject an image if > the provide bogus stuff? The current Vulkan spec says that vkCreateImage() only fails due to K_ERROR_OUT_OF_HOST_MEMORY and VK_ERROR_OUT_OF_DEVICE_MEMORY. It never fails due to

Re: [Mesa-dev] [PATCH 4/6] isl: Let isl_surf_init's caller set the exact row pitch

On Mon 06 Mar 2017, Jason Ekstrand wrote: > On Mon, Mar 6, 2017 at 10:12 AM, Chad Versace <chadvers...@chromium.org> > wrote: > > > The caller does so by setting the new field > > isl_surf_init_info::row_pitch, which overrides isl's row pitch > > calculation. >

Re: [Mesa-dev] [PATCH 6/6] isl: Drop unused isl_surf_init_info::min_pitch

On Mon 06 Mar 2017, Jason Ekstrand wrote: > why do we sped two patches refactoring/renaming this field just so we can > delete it? There's no good reason... How it happened: These patches were written at different times, and were non-contiguous in a long-lived branch. I sorted the branch's

[Mesa-dev] [RFC] vulkan: VK_MESAX_external_image_dma_buf

I'm working on Vulkan extensions for importing/exporting dma_bufs. I'm seeking feedback on the extension drafts. But... Sorry, the real RFC is in another castle. Find it at . Reply three, not here. I sent this proxy RFC

[Mesa-dev] [RFC PATCH 07/13] RFC: anv: Implement VK_EXT_get_image_properties

--- src/intel/vulkan/anv_entrypoints_gen.py | 1 + src/intel/vulkan/anv_image.c| 13 + 2 files changed, 14 insertions(+) diff --git a/src/intel/vulkan/anv_entrypoints_gen.py b/src/intel/vulkan/anv_entrypoints_gen.py index 7d7ea5e77ed..eb960b45986 100644 ---

[Mesa-dev] [RFC PATCH 11/13] RFC: anv/wsi: Use VK_MESAX_external_image_dma_buf

When creating a VkSurface for X11, we created the underlying VkImage by calling anv_image_create() and passing driver-private info to it. We can now accomplish the same thing without driver-private info, using VK_MESAX_external_image_dma_buf. In anv_wsi.c, replace the combo of

[Mesa-dev] [RFC PATCH 10/13] RFC: anv: Drop vkCreateDmaBufImageINTEL()

This "extension" function predates Vulkan 1.0 and Vulkan WSI. We created it during the early days of bringing up the Vulkan driver. We used it for testing the early driver because, in those early days, there was no other way to import/export a tiled VkImage and examine it. No VkSurfaceKHR existed

[Mesa-dev] [RFC PATCH 13/13] RFC: anv: Drop unneeded struct anv_image_create_info

Now that anv_image_create() is gone, there is no need for struct anv_image_create_info. The struct just adds an unused layer of indirection. --- src/intel/vulkan/anv_image.c | 38 +++--- src/intel/vulkan/anv_private.h | 9 - 2 files changed, 11

[Mesa-dev] [RFC PATCH 12/13] RFC: anv: Drop unused anv_image_create()

--- src/intel/vulkan/anv_image.c | 26 ++ src/intel/vulkan/anv_private.h | 5 - 2 files changed, 6 insertions(+), 25 deletions(-) diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vulkan/anv_image.c index 60b33fba2ae..998b0b43391 100644 ---

[Mesa-dev] [RFC PATCH 09/13] RFC: anv: Implement VK_MESAX_external_image_dma_buf

For now, we support dma_buf images for only a single format, VK_FORMAT_R8G8B8A8_UNORM. And the image must be a "simple" image: 2D, single-sample, non-mipmappped, non-array, non-cube. --- src/intel/vulkan/anv_device.c | 4 + src/intel/vulkan/anv_entrypoints_gen.py | 1 +

[Mesa-dev] [RFC PATCH 06/13] RFC: vulkan: Update registry for MESAX dma_buf extensions

Update vulkan.h and vk.xml from [1]: git://github.com/chadversary/vulkan-spec refs/tags/chadv/test/2017-03-06-VK_MESAX_external This pulls in the following extensions: - VK_EXT_get_image_properties - VK_MESAX_external_memory_dma_buf - VK_MESAX_external_image_dma_buf WARNING: These

[Mesa-dev] [PATCH 02/13] isl: Add isl_surf_get_drm_format_mod()

--- src/intel/isl/isl.c | 35 +++ src/intel/isl/isl.h | 15 +++ 2 files changed, 50 insertions(+) diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c index c70fac8a176..3559c5e4c84 100644 --- a/src/intel/isl/isl.c +++ b/src/intel/isl/isl.c @@

[Mesa-dev] [PATCH 01/13] isl: Add func isl_tiling_from_drm_format_mod()

It converts a DRM format modifier to enum isl_tiling. That's all. --- src/intel/isl/isl.c | 23 +++ src/intel/isl/isl.h | 3 +++ 2 files changed, 26 insertions(+) diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c index ec8424cd48b..c70fac8a176 100644 ---

[Mesa-dev] [RFC PATCH 08/13] RFC: anv: Implement VK_MESAX_external_memory_dma_buf

For now, we support dma_bufs only for VkBuffers. The VK_MESAX_external_memory_dma_buf spec allows us to support dma_buf VkImages, but we choose to defer that support until VK_MESAX_external_image_dma_buf. --- src/intel/vulkan/anv_device.c | 28 +++-

[Mesa-dev] [PATCH 05/13] anv: Set anv_surface::offset earlier

Set anv_surface::offset *before* calling add_surface(). No intended change in behavior. This patch prepares for supporting user-provided surface offsets, a feature required for VK_MESAX_external_image_dma_buf. --- src/intel/vulkan/anv_image.c | 15 --- 1 file changed, 12

[Mesa-dev] [PATCH 04/13] anv: Annotate anv_get_*format() as pure

--- src/intel/vulkan/anv_private.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/intel/vulkan/anv_private.h b/src/intel/vulkan/anv_private.h index 60b05186c19..01aeb216597 100644 --- a/src/intel/vulkan/anv_private.h +++ b/src/intel/vulkan/anv_private.h @@ -1679,7

[Mesa-dev] [PATCH 00/13] anv: Implement VK_MESAX_image_dma_buf

es to Mark Janes. Diffstat = Chad Versace (13): isl: Add func isl_tiling_from_drm_format_mod() isl: Add isl_surf_get_drm_format_mod() anv: Add func anv_get_raw_format() anv: Annotate anv_get_*format() as pure anv: Set anv_surface::offset earlier RFC: vulkan: Update registry

[Mesa-dev] [PATCH 03/13] anv: Add func anv_get_raw_format()

Like anv_get_format(), but the returned format is not adjusted, not even for the aspect. Add anv_get_raw_isl_format() too, to match anv_get_isl_format(). --- src/intel/vulkan/anv_formats.c | 7 +++ src/intel/vulkan/anv_private.h | 8 2 files changed, 15 insertions(+) diff --git

[Mesa-dev] [PATCH 2/3] anv: Use anv_outarray in vkEnumeratePhysicalDevices

No intended change in behavior. Just a refactor. --- src/intel/vulkan/anv_device.c | 32 ++-- 1 file changed, 6 insertions(+), 26 deletions(-) diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c index fbcbd40c61f..6a73d6bf6db 100644 ---

[Mesa-dev] [PATCH 0/3] anv: Add an anv_outarray_append() macro

. This patch series lives at: git://git.kiwitree.net/~chadv/mesa refs/tags/chadv/review/anv-outarray-v01 gitweb: http://git.kiwitree.net/cgit/~chadv/mesa/log/?h=chadv/review/anv-outarray-v01 Chad Versace (3): anv: Add anv_outarray anv: Use anv_outarray in vkEnumeratePhysicalDevices anv

[Mesa-dev] [PATCH 1/3] anv: Add anv_outarray

anv_outarray is a wrapper for a Vulkan output array. A Vulkan output array is one that follows the convention of the parameters to vkGetPhysicalDeviceQueueFamilyProperties(). In the upcoming dma_buf extensions, anv_outarray will simplify the code for querying the DRM format modifiers. ---

[Mesa-dev] [PATCH 3/3] anv: Use anv_outarray in vkGetPhysicalDeviceQueueFamilyProperties

No intended change in behavior. Just a refactor. --- src/intel/vulkan/anv_device.c | 73 +++ 1 file changed, 18 insertions(+), 55 deletions(-) diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c index 6a73d6bf6db..67dd8405487 100644

[Mesa-dev] [PATCH 0/5] anv: Some image refactors and a hiz fix

://git.kiwitree.net/~chadv/mesa refs/tags/chadv/review/anv-image-refactors-v01 gitweb: http://git.kiwitree.net/cgit/~chadv/mesa/log/?h=chadv/review/anv-image-refactors-v01 Chad Versace (5): anv/image: Better var names in vkCreateImage anv/image: Refactor how tiling is chosen anv/image: Fix

[Mesa-dev] [PATCH 5/5] anv: Handle failure in make_hiz_surface_maybe()

make_ccs_surface_maybe() correctly handles failure isl_surf_get_ccs_surf(). When it fails, the resultant VkImage is still valid, just without a ccs surface. Same of make_mcs_surface_maybe() and isl_surf_get_mcs_surf(). Fix make_hiz_surface_maybe() to do the same. ---

[Mesa-dev] [PATCH 1/5] anv/image: Better var names in vkCreateImage

- Rename the anv_image_create_info vars from 'create_info' to 'anv_info'. - Rename the VkImageCreateInfo vars from 'pCreateInfo' and 'vk_info' to 'base_info'. This reduces the diff and eliminates ambiguity in follow-up patches for upcoming extensions, because the extensions define yet more

[Mesa-dev] [PATCH 4/5] anv/image: Refactor creation of aux surfaces

Creation of hiz, ccs, and mcs surfaces was encoded by a giant 'if' tree at the tail of make_surface(). This patch extracts that 'if' tree into the new functions: make_hiz_surface_maybe() make_ccs_surface_maybe() make_mcs_surface_maybe() For clarity, also rename make_surface() to

[Mesa-dev] [PATCH 2/5] anv/image: Refactor how tiling is chosen

The code that chooses the image's tiling flags, extract it into a new function, choose_isl_tiling_flags(). This reduces the diff in future patches for the upcoming dma_buf-import extension, in which the the tiling code will become more complex. --- src/intel/vulkan/anv_image.c | 30

[Mesa-dev] [PATCH 3/5] anv/image: Fix return type of make_surface()

make_surface() always returns VK_SUCCESS, so change its return type to 'void'. This simplifies the return-code handling in anv_image_create_info() and removes a goto. --- src/intel/vulkan/anv_image.c | 15 ++- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git

[Mesa-dev] [PATCH 4/6] isl: Let isl_surf_init's caller set the exact row pitch

The caller does so by setting the new field isl_surf_init_info::row_pitch, which overrides isl's row pitch calculation. --- src/intel/isl/isl.c | 11 ++- src/intel/isl/isl.h | 9 + 2 files changed, 19 insertions(+), 1 deletion(-) diff --git a/src/intel/isl/isl.c

[Mesa-dev] [PATCH 0/6] isl: Fix requests for exact row pitch

-v01 Chad Versace (6): isl: Fix s/pitch/row_pitch/ in comment isl: Rename isl_surf_init_info::min_pitch -> min_row_pitch isl: Refactor row pitch calculation isl: Let isl_surf_init's caller set the exact row pitch intel: Fix requests for exact surface row pitch isl: Drop unu

[Mesa-dev] [PATCH 5/6] intel: Fix requests for exact surface row pitch

All callers of isl_surf_init() that set 'min_row_pitch' wanted to request an *exact* row pitch, as evidenced by nearby asserts, but isl lacked API for doing so. Now that isl has an API for that, update the code to use it. --- src/intel/blorp/blorp_blit.c | 3 +-- src/intel/vulkan/anv_blorp.c | 3

[Mesa-dev] [PATCH 6/6] isl: Drop unused isl_surf_init_info::min_pitch

--- src/intel/isl/isl.c | 12 ++-- src/intel/isl/isl.h | 3 --- 2 files changed, 2 insertions(+), 13 deletions(-) diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c index b3ac305b81b..ec8424cd48b 100644 --- a/src/intel/isl/isl.c +++ b/src/intel/isl/isl.c @@ -1008,8 +1008,6 @@

[Mesa-dev] [PATCH 3/6] isl: Refactor row pitch calculation

The calculations of row_pitch, surface size, and base_alignment were mixed together. Extract the calculation of row pitch into a new function, isl_calc_row_pitch(), and call it before calculating surface_size and base_alignment. This simplifies a follow-on patch that adds a new member,

[Mesa-dev] [PATCH 2/6] isl: Rename isl_surf_init_info::min_pitch -> min_row_pitch

It is the lower bound for isl_surf::row_pitch; not isl_surf::pitch, which doesn't exist; nor does it affect isl_surf::array_pitch*. --- src/intel/blorp/blorp_blit.c | 4 ++-- src/intel/isl/isl.c | 6 +++--- src/intel/isl/isl.h | 2 +- src/intel/vulkan/anv_blorp.c | 2 +-

[Mesa-dev] [PATCH 1/6] isl: Fix s/pitch/row_pitch/ in comment

struct isl_surf has no member named 'pitch'. --- src/intel/isl/isl.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/isl/isl.h b/src/intel/isl/isl.h index 9d92906ca71..add708b760f 100644 --- a/src/intel/isl/isl.h +++ b/src/intel/isl/isl.h @@ -810,7 +810,7 @@ struct

Re: [Mesa-dev] [PATCH 7/7] anv: Implement VK_KHX_external_memory_fd (v2)

On Tue 28 Feb 2017, Jason Ekstrand wrote: > On Tue, Feb 28, 2017 at 10:58 AM, Chad Versace <chadvers...@chromium.org> > wrote: > > > From: Jason Ekstrand <jason.ekstr...@intel.com> > > > > > > v2 (chadv): > > - Rebase. > >

[Mesa-dev] [PATCH 7/7] anv: Implement VK_KHX_external_memory_fd (v2)

s diff in future dma_buf patches. Co-authored-with: Chad Versace <chadvers...@chromium.org> --- On my branch wip/anv-external-memory. http://git.kiwitree.net/cgit/~chadv/mesa/log/?h=wip/anv-external-memory src/intel/vulkan/anv_device.c | 90 + src/

[Mesa-dev] [PATCH 5/7] anv: Implement VK_KHX_external_memory_capabilities (v2)

This is a complete but trivial implementation. It's trivial becasue We support no external memory capabilities yet. Most of the real work in this commit is in reworking the UUIDs advertised by the driver. v2 (chadv): - Fix chain traversal in vkGetPhysicalDeviceImageFormatProperties2KHR.

Re: [Mesa-dev] [PATCH 6/7] anv: Implement VK_KHX_external_memory

es. > --- > src/intel/vulkan/anv_device.c | 6 +- > src/intel/vulkan/anv_entrypoints_gen.py | 1 + > 2 files changed, 6 insertions(+), 1 deletion(-) Patch 6 is Reviewed-by: Chad Versace <chadvers...@chromium.org> __

Re: [Mesa-dev] [PATCH 0/7] anv: Implement the VK_KHX_external_memory extensions

On Mon 27 Feb 2017, Chad Versace wrote: > For anyone reading the new extension specs and asking "Wait? What's this > OPAQUE_FD thing? And why do we have memory import/export for Win32 > handles but not for dma_bufs?". > > There does exist a dma_buf extension, VK_MESA

Re: [Mesa-dev] [PATCH 4/7] util/vk: Add helpers for finding an extension struct

On Mon 27 Feb 2017, Jason Ekstrand wrote: > --- > src/util/vk_util.h | 17 + > 1 file changed, 17 insertions(+) Patch 4 if Reviewed-by: Chad Versace <chadvers...@chromium.org> ___ mesa-dev mailing list mesa-dev@lists.

Re: [Mesa-dev] [PATCH 3/7] anv/physical_device: Rename uuid to pipeline_cache_uuid

ivate.h| 2 +- > 3 files changed, 6 insertions(+), 5 deletions(-) Yup. Reviewed-by: Chad Versace <chadvers...@chromium.org> ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 2/7] anv: Refactor device_get_cache_uuid into physical_device_init_uuids

return vk_errorf(VK_ERROR_INITIALIZATION_FAILED, > + "build-id too short. It needs to be a SHA"); > + } s/a SHA/a SHA1/ With that, Reviewed-by: Chad Versace <chadvers...@chromium.org> > > uint8_t sha1[20]; > STATIC_ASSERT(VK_UUID_SI

Re: [Mesa-dev] [PATCH 0/7] anv: Implement the VK_KHX_external_memory extensions

add experimental > support image and memory sharing between two Vulkan instances. Since > they're experimental, it's a bit up-for-debate as to whether or not we > should actually merge them into master. This cover letter seems as good a > place as any to hold that discussion. :-) &g

Re: [Mesa-dev] [PATCH 1/7] anv: Add the pci_id into the shader cache UUID

1 */ >return false; > > - memcpy(uuid, build_id_data(note), VK_UUID_SIZE); > + uint8_t sha1[20]; > + STATIC_ASSERT(VK_UUID_SIZE <= sizeof(sha1)); > + struct mesa_sha1 *sha1_ctx = _mesa_sha1_init(); > + if (sha1_ctx == NULL) > + return fal

Re: [Mesa-dev] [PATCH 2/2] anv: Add the pci_id into the shader cache UUID

On Mon 27 Feb 2017, Jason Ekstrand wrote: > On Mon, Feb 27, 2017 at 9:38 AM, Chad Versace <chadvers...@chromium.org> > wrote: > > > On Fri 24 Feb 2017, Jason Ekstrand wrote: > > > This prevents a user from using a cache created on one hardware > > > ge

Re: [Mesa-dev] [PATCH] anv: Bump advertised version to 1.0.42

On Mon 27 Feb 2017, Jason Ekstrand wrote: > We've been following the spec changes. Yup, we have ;) Let's chat on irc today about how to handle the KHX extensions. Reviewed-by: Chad Versace <chadvers...@chromium.org> > --- > src/intel/vulkan/anv_device.c | 2 +- > 1 file ch

Re: [Mesa-dev] [PATCH 2/2] anv: Add the pci_id into the shader cache UUID

On Fri 24 Feb 2017, Jason Ekstrand wrote: > This prevents a user from using a cache created on one hardware > generation on a different one. Of course, with Intel hardware, this > requires moving their drive from one machine to another but it's still > possible and we should prevent it. Or if

Re: [Mesa-dev] [PATCH 1/2] util/build-id: Return a pointer rather than copying the data

| 7 +++ > src/util/build_id.h | 5 ++--- > 3 files changed, 6 insertions(+), 8 deletions(-) Reviewed-by: Chad Versace <chadvers...@chromium.org> ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 3/3] anv: Enable MSAA compression

On Wed 22 Feb 2017, Jason Ekstrand wrote: > On Wed, Feb 22, 2017 at 11:09 AM, Chad Versace <chadvers...@chromium.org> > wrote: > > > On Mon 20 Feb 2017, Jason Ekstrand wrote: > > > This just enables basic MSAA compression (no fast clears) for all > > >

Re: [Mesa-dev] [PATCH 3/3] anv: Enable MSAA compression

iview->image->aux_surface.isl.size == 0, then the next branch checks iview->image->aux_usage. It seems more natural to check aux_usage in both branches. Anyway, that nit fixup belongs in a different commit anyway, for bisection's sake. Reviewed-by: Chad Versace <chadvers...@chromium.org&g

Re: [Mesa-dev] [PATCH 2/3] isl: add MCS width constraint 16 samples

gt; that. Also, I like that the end result of the restriction is clearly > spelled out with the old check. I can't say that I care all that much one > way or the other so long as both the effect (16x 16k surfaces not working) > and the reason (pitch) are documented. I don't un

Re: [Mesa-dev] [PATCH 1/3] isl: Return surface creation success from aux helpers

gt; --- > src/intel/isl/isl.c | 72 > +--- > src/intel/isl/isl.h | 4 +-- > src/intel/vulkan/anv_image.c | 5 +-- > 3 files changed, 40 insertions(+), 41 deletions(-) Thank you for adding my bool's back to the hiz funcs

Re: [Mesa-dev] [PATCH 2/2] anv: Use build-id for pipeline cache UUID.

On Wed 15 Feb 2017, Emil Velikov wrote: > On 14 February 2017 at 21:02, Chad Versace <chadvers...@chromium.org> wrote: > > On Tue 14 Feb 2017, Kenneth Graunke wrote: > >> On Tuesday, February 14, 2017 12:38:45 PM PST Chad Versace wrote: > >> > O

Re: [Mesa-dev] [PATCH 2/2] anv: Use build-id for pipeline cache UUID.

Series is Reviewed-by: Chad Versace <chadvers...@chromium.org> ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 2/2] anv: Use build-id for pipeline cache UUID.

On Tue 14 Feb 2017, Kenneth Graunke wrote: > On Tuesday, February 14, 2017 12:38:45 PM PST Chad Versace wrote: > > On Tue 14 Feb 2017, Matt Turner wrote: > > > > > > > static bool > > > -anv_get_function_timestamp(void *ptr, uint32_t* timestamp) >

Re: [Mesa-dev] [PATCH 2/2] anv: Use build-id for pipeline cache UUID.

On Tue 14 Feb 2017, Matt Turner wrote: > static bool > -anv_get_function_timestamp(void *ptr, uint32_t* timestamp) > +anv_device_get_cache_uuid(void *uuid) > { > - Dl_info info; > - struct stat st; > - if (!dladdr(ptr, ) || !info.dli_fname) > + const struct note *note =

Re: [Mesa-dev] [PATCH 1/2] util: Add utility build-id code.

On Tue 14 Feb 2017, Matt Turner wrote: > Provides the ability to read the .note.gnu.build-id section of ELF > binaries, which is inserted by the --build-id=... flag to ld. > --- > configure.ac | 2 + > src/util/Makefile.sources | 2 + > src/util/build_id.c | 109 >

Re: [Mesa-dev] [PATCH 1/2] util: Add utility build-id code.

On Tue 14 Feb 2017, Matt Turner wrote: > Provides the ability to read the .note.gnu.build-id section of ELF > binaries, which is inserted by the --build-id=... flag to ld. Heh. Sunday night I wrote a prototype of this myself. I'm strongly in favor of basing Vulkan unique id's on the ELF build-id

Re: [Mesa-dev] [PATCH 1/2] util: Add utility build-id code.

On Tue 14 Feb 2017, Matt Turner wrote: > On Tue, Feb 14, 2017 at 11:21 AM, Matt Turner wrote: > > On Tue, Feb 14, 2017 at 11:18 AM, Matt Turner wrote: > >> On Tue, Feb 14, 2017 at 10:59 AM, Jason Ekstrand > >> wrote: > >>> I'm not

Re: [Mesa-dev] [PATCH] configure: add blurb about what the LIBDRM_*_REQUIRED stuff means

On Tue 07 Feb 2017, Ilia Mirkin wrote: > Signed-off-by: Ilia Mirkin <imir...@alum.mit.edu> > Reviewed-by: Emil Velikov <emil.veli...@collabora.com> > --- > configure.ac | 9 - > 1 file changed, 8 insertions(+), 1 deletion(-) Reviewed-by: Chad Versac

Re: [Mesa-dev] [PATCH 5/5] travis: use both cores for make/make check

On Thu 02 Feb 2017, Emil Velikov wrote: > On 2 February 2017 at 01:27, Eric Anholt wrote: > > Emil Velikov writes: > > > >> From: Emil Velikov > >> > >> The instance offers 2 cores, so use them to speed things up. > >> > >>

Re: [Mesa-dev] [PATCH 1/5] configure.ac: list all the dri-drivers in the help string

Regardless, state clearly what's > Opening parenthesis? ^ > > Otherwise, LGTM. > > Reviewed-by: Andres Gomez <ago...@igalia.com> Same here. Reviewed-by: Chad Versace <chadvers...@chromium.org> ___ mesa-dev mailing list

Re: [Mesa-dev] [PATCH] mesa: Don't crash when destroying contexts created with no visual.

with no config, then immediately destroys it.  The drawbuffer is > > never > > set up, so we can't dereference it asking if it's double buffered, or > > we'll crash on a null pointer dereference. > > > > Just bail early. Reviewed-by: Chad Versace <chadvers..

Re: [Mesa-dev] [PATCH] intel/isl: Add a better comment for format_supports_ccs_e

rf for details. > + */ > bool > isl_format_supports_ccs_e(const struct gen_device_info *devinfo, >enum isl_format format) Reviewed-by: Chad Versace <chadvers...@chromium.org> ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 2/5] intel/isl: Add a supports_ccs_d helper

On Thu 02 Feb 2017, Jason Ekstrand wrote: > On Thu, Feb 2, 2017 at 10:13 AM, Chad Versace <chadvers...@chromium.org> > wrote: > > > On Thu 02 Feb 2017, Anuj Phogat wrote: > > > On Thu, Feb 2, 2017 at 9:03 AM, Jason Ekstrand <ja...@jlekstrand.net> > > wro

Re: [Mesa-dev] [PATCH 5/5] anv: Remove the finishme for CCS_E with storage images

On Wed 01 Feb 2017, Jason Ekstrand wrote: > The data port can't handle CCS at all so replace the finishme with > better comments. > --- > src/intel/vulkan/anv_image.c | 21 +++-- > 1 file changed, 7 insertions(+), 14 deletions(-) Patch is Reviewed-by: Chad Ve

Re: [Mesa-dev] [PATCH 4/5] intel/isl: Assert that we don't use CCS for storage images

1 file changed, 6 insertions(+) Patch is Reviewed-by: Chad Versace <chadvers...@chromium.org> ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 3/5] intel/isl: Add a formats_are_ccs_e_compatible helper

format_layout *fmtl2 = isl_format_get_layout(format2); > + > + /* The compression used by CCS is not dependent on the actual data > encoding > +* of the format but only depends on the bit-layout of the channels. > +*/ I would rephrase the comment to say "depend

Re: [Mesa-dev] [PATCH 1/5] intel/isl: Rename supports_lossless_compression to supports_ccs_e

> src/intel/vulkan/genX_cmd_buffer.c | 3 +-- > src/mesa/drivers/dri/i965/brw_context.c | 3 +-- > src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 3 +-- > src/mesa/drivers/dri/i965/intel_mipmap_tree.c| 3 +-- > 7 files changed, 11 insertions(+), 1

Re: [Mesa-dev] [PATCH 2/5] intel/isl: Add a supports_ccs_d helper

On Thu 02 Feb 2017, Anuj Phogat wrote: > On Thu, Feb 2, 2017 at 9:03 AM, Jason Ekstrand wrote: > > On Wed, Feb 1, 2017 at 4:07 PM, Anuj Phogat wrote: > >> > >> On Wed, Feb 1, 2017 at 2:40 PM, Jason Ekstrand > >> wrote: > >> >

Re: [Mesa-dev] [PATCH] configure: Only require libdrm 2.4.75 for intel.

On Thu 02 Feb 2017, Kenneth Graunke wrote: > On Thursday, February 2, 2017 7:35:20 AM PST Chad Versace wrote: > > On Thu 02 Feb 2017, Dave Airlie wrote: > > > On 2 February 2017 at 13:09, Emil Velikov <emil.l.veli...@gmail.com> > > > wrote: > > > > On

Re: [Mesa-dev] [PATCH] configure.ac: describe what all the LIBDRM_*REQUIRED macros mean

On Thu 02 Feb 2017, Emil Velikov wrote: > From: Emil Velikov > > They are versions of the respective libdrm package. They are _not_ the > version of libdrm[.so] required for driver X. > > Doing the latter will lead to combinatoric explosion and in all fairness >

Re: [Mesa-dev] [PATCH] configure.ac: explicitly require libdrm for dri classic drivers.

On Thu 02 Feb 2017, Chad Versace wrote: > On Thu 02 Feb 2017, Dave Airlie wrote: > > From: Dave Airlie <airl...@redhat.com> > > > > Although this might come from somewhere else require it explicitly. > > > > Signed-off-by: Dave Airlie <airl...

Re: [Mesa-dev] [PATCH 1/2] configure: libdrm is a single package, no split different versions

y I think they should work. Reviewed-by: Chad Versace <chadvers...@chromium.org> > --- > configure.ac | 32 > 1 file changed, 16 insertions(+), 16 deletions(-) ___ mesa-dev mailing list mesa-dev@lists.f

Re: [Mesa-dev] [PATCH] configure.ac: explicitly require libdrm for dri classic drivers.

On Thu 02 Feb 2017, Dave Airlie wrote: > From: Dave Airlie <airl...@redhat.com> > > Although this might come from somewhere else require it explicitly. > > Signed-off-by: Dave Airlie <airl...@redhat.com> > --- > configure.ac | 5 + > 1 file changed

Re: [Mesa-dev] [PATCH] configure: Only require libdrm 2.4.75 for intel.

On Thu 02 Feb 2017, Dave Airlie wrote: > On 2 February 2017 at 13:09, Emil Velikov wrote: > > On 2 February 2017 at 02:58, Michel Dänzer wrote: > >> On 02/02/17 09:10 AM, Emil Velikov wrote: > >>> On 1 February 2017 at 23:28, Vinson Lee

Re: [Mesa-dev] [PATCH 0/7] i965: Implement EGL_ANDROID_native_fence_sync

On Fri 27 Jan 2017, Rafael Antognolli wrote: > On Thu, Jan 26, 2017 at 07:18:24PM -0800, Ben Widawsky wrote: > > On 17-01-23 15:32:32, Chad Versace wrote: > > > On Fri 20 Jan 2017, Rafael Antognolli wrote: > > > > I have tested this series with t

Re: [Mesa-dev] [Intel-gfx] [PATCH] i965: Share the workaround bo between all contexts

On Thu 26 Jan 2017, Chad Versace wrote: > On Thu 26 Jan 2017, Chris Wilson wrote: > > Since the workaround bo is used strictly as a write-only buffer, we need > > only allocate one per screen and use the same one from all contexts. > > > > (The caveat here is duri

Re: [Mesa-dev] [Intel-gfx] [PATCH] i965: Share the workaround bo between all contexts

On Thu 26 Jan 2017, Chris Wilson wrote: > On Thu, Jan 26, 2017 at 09:39:51AM -0800, Chad Versace wrote: > > On Thu 26 Jan 2017, Chris Wilson wrote: > > > Since the workaround bo is used strictly as a write-only buffer, we need > > > only allocate one per screen an

Re: [Mesa-dev] [PATCH] i965: Share the workaround bo between all contexts

fully understand the kernel's domain tracking). If that does work, then it just would require a small hack to brw_emit_pipe_control_write(). > Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk> > Cc: Kenneth Graunke <kenn...@whitecape.org> > Cc: Martin Peres <martin.pe..

Re: [Mesa-dev] [PATCH 5/5] anv: Implement VK_KHR_get_physical_device_properties2

On Wed 25 Jan 2017, Jason Ekstrand wrote: > > > On Wed, Jan 25, 2017 at 12:12 PM, Chad Versace <chadvers...@chromium.org> > wrote: > > +VkResult vkGetPhysicalDeviceImageFormatProperties2KHR( > > > This needs to be anv_ Oops. ___

Re: [Mesa-dev] [PATCH 0/5] anv: Implement VK_KHR_get_physical_device_properties2 (v2)

On Wed 25 Jan 2017, Lionel Landwerlin wrote: > Looks good to me : > > Reviewed-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> > > On 25/01/17 20:12, Chad Versace wrote: > > Untested, but builds. I wanted to get feedback on this approach before > > goin

Re: [Mesa-dev] [PATCH] vulkan: Don't install vk_platform.h or vulkan.h.

on we can install.  I'd be ok with a check for a particular loader > > version just to force distros to update their loader but I would like to > be > > able to build with arbitrary XML branches without having to install a > branch > > of the loader. >

Re: [Mesa-dev] [PATCH mesa 1/2] egl: update headers from registry

om <eric.engest...@imgtec.com> > --- > include/EGL/egl.h | 24 +++--- > include/EGL/eglext.h | 197 > +++--- > include/EGL/eglplatform.h | 10 ++- > 3 files changed, 206 insertions(+), 25 deletions(-) For the seri

Re: [Mesa-dev] [PATCH] anv: set command buffer to NULL when allocations fail

ultiple.command_buffer_primary > > dEQP-VK.api.object_management.alloc_callback_fail_multiple.command_buffer_secondary > > Signed-off-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> > --- > src/intel/vulkan/anv_cmd_buffer.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) Reviewed-by: Chad Versace <chadvers..

[Mesa-dev] [PATCH] anv: Revive struct anv_common (v2)

The struct was deleted by: commit efe9d1cde3340d3a9d17e5560b609a4fb839d43d Author: Edward O'Callaghan Subject: anv: Clean up some unused variables Unlike the original anv_common, the new one has a non-const pNext pointer because we will use it for the output

Re: [Mesa-dev] [PATCH 2/5] anv: Revive struct anv_common

On Wed 25 Jan 2017, Jason Ekstrand wrote: > On Wed, Jan 25, 2017 at 12:12 PM, Chad Versace <chadvers...@chromium.org> > wrote: > > The struct was deleted by: >   commit efe9d1cde3340d3a9d17e5560b609a4fb839d43d >   Author: Edward O'Callaghan <

[Mesa-dev] [PATCH 1/5] anv: Define macro anv_debug()

This is a printf-like macro that prints a debug message to stderr when built with DEBUG. If no DEBUG, then do nothing. --- src/intel/vulkan/anv_private.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/intel/vulkan/anv_private.h b/src/intel/vulkan/anv_private.h index

[Mesa-dev] [PATCH 5/5] anv: Implement VK_KHR_get_physical_device_properties2

--- src/intel/vulkan/anv_device.c | 90 ++ src/intel/vulkan/anv_formats.c | 53 + src/intel/vulkan/anv_private.h | 18 + 3 files changed, 161 insertions(+) diff --git a/src/intel/vulkan/anv_device.c

[Mesa-dev] [PATCH 3/5] anv: Refactor anv_GetPhysicalDeviceFormatProperties()

Add a helper function, anv_get_image_format_properties(), which does all the work and has a VkPhysicalDeviceImageFormatInfo2KHR parameter. This patch reduces churn in the following patch that implements vkGetPhysicalDeviceImageFormatProperties2KHR. --- src/intel/vulkan/anv_formats.c | 77

[Mesa-dev] [PATCH 2/5] anv: Revive struct anv_common

The struct was deleted by: commit efe9d1cde3340d3a9d17e5560b609a4fb839d43d Author: Edward O'Callaghan Subject: anv: Clean up some unused variables Unlike the original anv_common, the new one has a non-const pNext pointer because we will use it for the output

[Mesa-dev] [PATCH 4/5] anv: Refactor anv_GetPhysicalDeviceQueueFamilyProperties()

Add a helper function, anv_get_queue_family_properties(), which fills the struct. This patch reduces churn in the following patch that implements vkGetPhysicalDeviceQueueFamilyProperties2KHR. --- src/intel/vulkan/anv_device.c | 26 +- 1 file changed, 17 insertions(+), 9

[Mesa-dev] [PATCH 0/5] anv: Implement VK_KHR_get_physical_device_properties2 (v2)

(which is all of them currently currently). Chad Versace (5): anv: Define macro anv_debug() anv: Revive struct anv_common anv: Refactor anv_GetPhysicalDeviceFormatProperties() anv: Refactor anv_GetPhysicalDeviceQueueFamilyProperties() anv: Implement VK_KHR_get_physical_device_properties2

<    2   3   4   5   6   7   8   9   10   11   >