Re: [Mesa-dev] [PATCH 4/4] radeon/vce: handle newly added parameters

2016-06-24 Thread Christian König
Am 24.06.2016 um 14:46 schrieb Ilia Mirkin: On Fri, Jun 24, 2016 at 8:39 AM, Christian König <deathsim...@vodafone.de> wrote: Ilia and/or maybe other nouveau developers: You guys don't have any plans to expose the NVidia encoding functionality through the OpenMAX/VA-API state tr

Re: [Mesa-dev] [PATCH 4/4] radeon/vce: handle newly added parameters

2016-06-24 Thread Christian König
+ if (pic->enable_low_level_control == true) { Well using this enable_low_level_control switch to choose between two sets of hardcoded values is clearly a no go. For the motion estimation and most of the other flags I would say just try to expose the parameters we have in the hardware

Re: [Mesa-dev] [PATCH 1/4] radeon/vce: add vce structures

2016-06-23 Thread Christian König
Am 22.06.2016 um 23:44 schrieb Boyuan Zhang: Signed-off-by: Boyuan Zhang <boyuan.zh...@amd.com> I'm still not completely happy with this but I think we should move forward and can fix the fallout later on. So patches #1 and #2 are Reviewed-by: Christian König <christian.koe..

Re: [Mesa-dev] [PATCH 3/3] radeon/vce: use vce structures for vce_52 firmware

2016-06-22 Thread Christian König
by just using the values from the picture descriptor directly. Regards, Christian. Regards, Boyuan -Original Message- From: Christian König [mailto:deathsim...@vodafone.de] Sent: June-22-16 3:34 AM To: Zhang, Boyuan; mesa-dev@lists.freedesktop.org Subject: Re: [PATCH 3/3] radeon/vce: use

Re: [Mesa-dev] [PATCH] st/vdpau: use bicubic filter for scaling

2016-06-22 Thread Christian König
Am 21.06.2016 um 23:51 schrieb Andy Furniss: Andy Furniss wrote: Nayan Deshmukh wrote: I forgot to CC the list, so I am attaching our conversation here. Also probably my R7 M265 uses a progressive shader. OK, maybe that could be it. I may be able to try progressive, but need to remember

Re: [Mesa-dev] [PATCH] st/vdpau: use bicubic filter for scaling

2016-06-22 Thread Christian König
Secondly, I also need to set destination_rect clip. I am not yet sure how that could be done. See how clipping is done in the compositor, function vl_compositor_render() and vl_compositor_set_dst_clip(). Basically you just use a scissor state to limit where on the surface we are going to

Re: [Mesa-dev] [PATCH v4] st/vdpau: use bicubic filter for scaling

2016-06-22 Thread Christian König
Am 21.06.2016 um 21:21 schrieb Nayan Deshmukh: use bicubic filtering as high quality scaling L1. v2: fix a typo and add a newline to code v3: -render the unscaled image on a temporary surface (Christian) -apply noise reduction and sharpness filter on unscaled surface -render

Re: [Mesa-dev] [PATCH 3/3] radeon/vce: use vce structures for vce_52 firmware

2016-06-22 Thread Christian König
Am 21.06.2016 um 16:50 schrieb Boyuan Zhang: Signed-off-by: Boyuan Zhang --- src/gallium/drivers/radeon/radeon_vce.c| 171 +++ src/gallium/drivers/radeon/radeon_vce.h| 1 + src/gallium/drivers/radeon/radeon_vce_52.c | 447 +++--

Re: [Mesa-dev] [PATCH 2/3] vl: add parameters for VAAPI encode

2016-06-22 Thread Christian König
Am 21.06.2016 um 16:50 schrieb Boyuan Zhang: Signed-off-by: Boyuan Zhang Please move that patch to the end of the series. E.g. implement the existing interface first, then add the new one and make the changes to support the new one. Regards, Christian. ---

Re: [Mesa-dev] [RFC 7/7] radeon: remove screen ref counting

2016-06-21 Thread Christian König
Am 21.06.2016 um 15:53 schrieb Rob Herring: On Mon, Jun 20, 2016 at 1:15 PM, Christian König <deathsim...@vodafone.de> wrote: Am 20.06.2016 um 17:39 schrieb Rob Herring: On Mon, Jun 20, 2016 at 9:27 AM, Christian König <deathsim...@vodafone.de> wrote: Am 20.06.2016 um 16:13

Re: [Mesa-dev] [RFC 7/7] radeon: remove screen ref counting

2016-06-20 Thread Christian König
Am 20.06.2016 um 17:39 schrieb Rob Herring: On Mon, Jun 20, 2016 at 9:27 AM, Christian König <deathsim...@vodafone.de> wrote: Am 20.06.2016 um 16:13 schrieb Rob Herring: On Mon, Jun 20, 2016 at 8:31 AM, Nicolai Hähnle <nhaeh...@gmail.com> wrote: On 17.06.2016 21:05, Rob Herring wr

Re: [Mesa-dev] [RFC 7/7] radeon: remove screen ref counting

2016-06-20 Thread Christian König
Am 20.06.2016 um 16:13 schrieb Rob Herring: On Mon, Jun 20, 2016 at 8:31 AM, Nicolai Hähnle wrote: On 17.06.2016 21:05, Rob Herring wrote: On Fri, Jun 17, 2016 at 1:45 PM, Emil Velikov wrote: On 17 June 2016 at 18:45, Rob Herring

Re: [Mesa-dev] [PATCH] st/vdpau: use bicubic filter for scaling

2016-06-20 Thread Christian König
for the review. I don't understand the compositor code fully yet. How can I create a unscaled image with it? Regards, Nayan. On Fri, Jun 17, 2016 at 9:15 PM, Christian König <deathsim...@vodafone.de <mailto:deathsim...@vodafone.de>> wrote: Really nice work. I now understand where

Re: [Mesa-dev] [RFC 0/7] Common pipe screen ref counting

2016-06-17 Thread Christian König
Clearly a good idea to move this into common code, but there is just one important thing you are missing here. We intentional export the *_winsys_create() in the created libraries to have only one global file descriptor for all libraries. See the following files as well:

Re: [Mesa-dev] [PATCH] st/vdpau: use bicubic filter for scaling

2016-06-17 Thread Christian König
Really nice work. I now understand where your problem is with the scaled surface. Please see the further comments below. Am 16.06.2016 um 20:15 schrieb Nayan Deshmukh: v2: fix a typo and add a newline to code Signed-off-by: Nayan Deshmukh ---

Re: [Mesa-dev] [PATCH 5/5] st/va: enable h264 VAAPI encode

2016-06-15 Thread Christian König
Please split that up into multiple parts. E.g. adding the config structure, new image format support etc.. Julien, can you take a look as well if you have time and work a bit with Boyuan to get this cleaned up? Thanks in advance, Christian. Am 14.06.2016 um 22:14 schrieb Boyuan Zhang:

Re: [Mesa-dev] [PATCH 4/5] radeon/vce: sort cpb by ref list for VAAPI encode

2016-06-15 Thread Christian König
Am 14.06.2016 um 22:14 schrieb Boyuan Zhang: Signed-off-by: Boyuan Zhang We need to find an interface that works both for OpenMAX as well as VA-API and not implement a separate interface for each state tracker. So I would suggest to implement the logic to provide the

Re: [Mesa-dev] [PATCH 2/5] vl: add parameters for VAAPI encode

2016-06-15 Thread Christian König
Am 14.06.2016 um 22:14 schrieb Boyuan Zhang: Signed-off-by: Boyuan Zhang --- src/gallium/include/pipe/p_video_state.h | 13 + 1 file changed, 13 insertions(+) diff --git a/src/gallium/include/pipe/p_video_state.h b/src/gallium/include/pipe/p_video_state.h

Re: [Mesa-dev] [PATCH 1/5] radeon/vce: add vce structures

2016-06-15 Thread Christian König
Am 14.06.2016 um 22:14 schrieb Boyuan Zhang: Signed-off-by: Boyuan Zhang As I said before please drop this change as it is unrelated to supporting encoding with VA-API and we need to find a conclusion on how to handle things first. Christian. ---

Re: [Mesa-dev] [PATCH v3] st/va: ensure linear memory for dmabuf

2016-06-13 Thread Christian König
+253,9 @@ vl_video_buffer_template(struct pipe_resource *templ, templ->bind = PIPE_BIND_SAMPLER_VIEW | PIPE_BIND_RENDER_TARGET; templ->usage = usage; + if (tmpl->bind) The "if" here is probably superfluous. With that fixed the patch is Reviewed-by: Christian König

[Mesa-dev] Two luma keying follow ups

2016-06-09 Thread Christian König
Hi guys, Two minor things I've noticed after pushing the original patches. The first one is that we only changed the function for progressive frames in the compositor. Add luma keying for interlaced frames as well. The second issue is that we have forgotten to claim support for lumakeying now.

[Mesa-dev] [PATCH 2/2] st/vdpau: we support lumakeying now

2016-06-09 Thread Christian König
From: Christian König <christian.koe...@amd.com> Signed-off-by: Christian König <christian.koe...@amd.com> --- src/gallium/state_trackers/vdpau/query.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/state_trackers/vdpau/query.c b/src/gallium/state_trackers/vdpau/q

[Mesa-dev] [PATCH 1/2] vl: support luma keying for interlaced surfaces as well

2016-06-09 Thread Christian König
From: Christian König <christian.koe...@amd.com> We had the CSC code twice in there, factor it out into a separate function. Signed-off-by: Christian König <christian.koe...@amd.com> --- src/gallium/auxiliary/vl/vl_compositor.c | 76 +--- 1 file

Re: [Mesa-dev] [PATCH v2] st/va: ensure linear memory for dmabuf

2016-06-08 Thread Christian König
o say with my comment back then. Regards, Christian. On 8 June 2016 at 14:07, Christian König <deathsim...@vodafone.de <mailto:deathsim...@vodafone.de>> wrote: Am 08.06.2016 um 14:20 schrieb Julien Isorce: On 8 June 2016 at 09:16, Christian König <deathsim...@vodafone.de

Re: [Mesa-dev] [PATCH v2] st/va: ensure linear memory for dmabuf

2016-06-08 Thread Christian König
Am 08.06.2016 um 14:20 schrieb Julien Isorce: On 8 June 2016 at 09:16, Christian König <deathsim...@vodafone.de <mailto:deathsim...@vodafone.de>> wrote: Am 02.06.2016 um 16:00 schrieb Julien Isorce: In order to do zero-copy between two different devices

Re: [Mesa-dev] [PATCH] st/va: it is valid to release the VABuffer of an exported resource

2016-06-08 Thread Christian König
I'm clearly not deep enough into VA-API to judge if that is correct or not, but it sounds sane to me. So feel free to add an Acked-by: Christian König <christian.koe...@amd.com> on the patch. Cheers, Christian. Am 08.06.2016 um 13:13 schrieb Julien Isorce: Hi Christian, Thx for the

Re: [Mesa-dev] [PATCH v4 2/2] st/vdpau: implement luma keyring

2016-06-08 Thread Christian König
With the type fixed both patches are Reviewed-by: Christian König <christian.koe...@amd.com> If there aren't any more objections I'm going to push the patches now. Regards, Christian. Am 08.06.2016 um 11:28 schrieb Michel Dänzer: AFAIK the term is "luma keying", n

Re: [Mesa-dev] [PATCH] st/va: it is valid to release the VABuffer of an exported resource

2016-06-08 Thread Christian König
Am 02.06.2016 um 16:03 schrieb Julien Isorce: Signed-off-by: Julien Isorce Actually I'm not sure if that is correct. If you release the VABuffer of an exported resource you won't be able to properly close the handle with vlVaReleaseBufferHandle(). On the other hand

Re: [Mesa-dev] [PATCH] st/va: use proper temp pipe_video_buffer template

2016-06-08 Thread Christian König
Am 02.06.2016 um 16:03 schrieb Julien Isorce: Instead of changing the format on the existing template which makes error handling not nice and confuses coverity. CoverityID: 1337953 Signed-off-by: Julien Isorce <j.iso...@samsung.com> Reviewed-by: Christian König <christian.koe..

Re: [Mesa-dev] [PATCH v2] st/va: ensure linear memory for dmabuf

2016-06-08 Thread Christian König
Am 02.06.2016 um 16:00 schrieb Julien Isorce: In order to do zero-copy between two different devices the memory should not be tiled. This is currently no way to set pipe_resource template's flag from pipe_video_buffer template. So disabled_tiling is added. Choosed "disable" prefix so that

Re: [Mesa-dev] [PATCH v3] vl: implement luma key ring

2016-06-08 Thread Christian König
Am 07.06.2016 um 19:42 schrieb Nayan Deshmukh: Apply the luma key filter to the YCbCr values during the CSC conversion in video buffer shader. The initial values of max and min luma are set to opposite values to disable the filter initially and will be set when enabling it. Add extra parmeters

Re: [Mesa-dev] radeonfb: BAR 0: can't reserve [mem 0x98000000-0x9fffffff pref]

2016-06-07 Thread Christian König
Am 07.06.2016 um 14:19 schrieb Mathieu Malaterre: On Tue, Jun 7, 2016 at 8:05 AM, Mathieu Malaterre wrote: Hi Alex, On Mon, Jun 6, 2016 at 7:20 PM, Alex Deucher wrote: On Mon, Jun 6, 2016 at 1:16 PM, Marek Olšák wrote: [+

Re: [Mesa-dev] [PATCH 1/4] vl: Apply luma key filter before CSC conversion

2016-06-07 Thread Christian König
Am 07.06.2016 um 13:28 schrieb Nayan Deshmukh: Apply the luma key filter to the YCbCr values during the CSC conversion in video buffer shader. The initial values of max and min luma are set to opposite values to disable the filter initially and will be set when enabling it. Signed-off-by: Nayan

Re: [Mesa-dev] [PATCH] st/vdpau: check for null pointer in get/put bits.

2016-06-02 Thread Christian König
Am 02.06.2016 um 08:41 schrieb Nayan Deshmukh: Check for null pointer before accessing arrays in get/put bits native/YCbCr/Indexed in VdpOutputSurface and VdpVideoSurface. Signed-off-by: Nayan Deshmukh Reviewed and pushed. Thanks for the help, Christian. ---

Re: [Mesa-dev] [PATCH] st/va: restore old buffer format on error

2016-05-31 Thread Christian König
to be fixed instead. Christian. Am 31.05.2016 um 14:51 schrieb Christian König: Yeah, that solution looks more correct to me. Christian. Am 31.05.2016 um 14:44 schrieb Julien Isorce: Hi, Thx for looking at it but are you sure your diff compiles ? Can you try this instead: --- a/src/gallium

Re: [Mesa-dev] [PATCH] st/va: restore old buffer format on error

2016-05-31 Thread Christian König
surf->templat.buffer_format = old_surf_format; pipe_mutex_unlock(drv->mutex); return VA_STATUS_ERROR_ALLOCATION_FAILED; } surf->buffer->destroy(surf->buffer); surf->buffer = tmp_buf; + surf->templat.buffer_format = format; }

Re: [Mesa-dev] [PATCH] st/va: restore old buffer format on error

2016-05-31 Thread Christian König
Am 31.05.2016 um 03:24 schrieb Eric Engestrom: CoverityID: 1337953 Signed-off-by: Eric Engestrom --- Note that I do not know this code at all; I'm blindly following Coverity's advice on this one :] Well and that is completely nonsense. The buffer was already reallocated

Re: [Mesa-dev] [PATCH] radeon/uvd: fix the H264 level for Tonga

2016-05-30 Thread Christian König
Am 28.05.2016 um 00:45 schrieb Andy Furniss: Emil Velikov wrote: On 27 May 2016 at 15:40, Christian König <deathsim...@vodafone.de> wrote: No, what I'm saying is that it is a number and not an enum. This way you don't need to change the specification when you want to support a new

[Mesa-dev] [PATCH] radeon/uvd: fix the H264 level for Tonga v2

2016-05-30 Thread Christian König
From: Christian König <christian.koe...@amd.com> We support 5.2 for a while now. v2: we even support 5.2 for H264, 5.1 is for HEVC. Signed-off-by: Christian König <christian.koe...@amd.com> Cc: <mesa-sta...@lists.freedesktop.org> --- src/gallium/drivers/radeon/radeon_vide

Re: [Mesa-dev] [PATCH] radeon/uvd: fix the H264 level for Tonga

2016-05-27 Thread Christian König
Am 27.05.2016 um 15:16 schrieb Emil Velikov: On 27 May 2016 at 11:28, Christian König <deathsim...@vodafone.de> wrote: Am 26.05.2016 um 11:27 schrieb Andy Furniss: Alex Deucher wrote: On Wed, May 25, 2016 at 10:57 AM, Christian König <deathsim...@vodafone.de> wrote: From: Chr

Re: [Mesa-dev] [PATCH] radeon/uvd: fix the H264 level for Tonga

2016-05-27 Thread Christian König
Am 26.05.2016 um 11:27 schrieb Andy Furniss: Alex Deucher wrote: On Wed, May 25, 2016 at 10:57 AM, Christian König <deathsim...@vodafone.de> wrote: From: Christian König <christian.koe...@amd.com> We support 5.1 for a while now. Resend as the last one didn't have the CCs.

Re: [Mesa-dev] [PATCH 2/2] winsys/amdgpu: disable CE preamble until the kernel is fixed

2016-05-27 Thread Christian König
ng the CE preamble IB means that the preamble packets are added to the main CE IB instead, which makes the problem go away. Just a guess, but does commit 9f8fb5a2b339ba83493991ca8f1173a939a696d3 in Alex drm-next-4.7 tree helps with the problem? commit 9f8fb5a2b339ba83493991ca8f1173a939a696d3

[Mesa-dev] [PATCH] radeon/uvd: fix the H264 level for Tonga

2016-05-25 Thread Christian König
From: Christian König <christian.koe...@amd.com> We support 5.1 for a while now. Signed-off-by: Christian König <christian.koe...@amd.com> --- src/gallium/drivers/radeon/radeon_video.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeon/ra

Re: [Mesa-dev] [PATCH 3/3] gallium: push offset down to driver

2016-05-17 Thread Christian König
Am 16.05.2016 um 22:16 schrieb Rob Clark: On Mon, May 16, 2016 at 3:53 PM, Emil Velikov wrote: On 15 May 2016 at 12:34, Stanimir Varbanov wrote: Push offset down to drivers when importing dmabuf. This is needed to more fully support

Re: [Mesa-dev] [PATCH 00/14] vl dri3 support for vaapi and vdpau

2016-05-11 Thread Christian König
: add dri3 support Very nice work, for the series Reviewed-by: Christian König <christian.koe...@amd.com> We could clean up the implementation in VDPAU a bit now as well, but that is something for a follow up patch set. Regards, Christian. configure.ac

Re: [Mesa-dev] [PATCH] Change the default to PCI on PowerPC

2016-05-03 Thread Christian König
Am 03.05.2016 um 08:39 schrieb Mathieu Malaterre: AGP mode is unstable on PowerPC Your signed of by line is missing, but apart from that the patch is Reviewed-by: Christian König <christian.koe...@amd.com>. Regards, Christian. --- drivers/gpu/drm/radeon/radeon_drv.c | 5 +

Re: [Mesa-dev] [PATCH 1/3] radeon/video: always use the reusable buffer pool

2016-04-23 Thread Christian König
sense, and there is no clear reason why the cache _shouldn't_ be used, just use the cache always. Cc: Christian König <christian.koe...@amd.com> Nice catch. Patch is Reviewed-by: Christian König <christian.koe...@amd.com> Christian. --- src/gallium/drivers/r600/r600_uvd.c | 2 +- s

Re: [Mesa-dev] Mesa (master): 29 new commits

2016-04-14 Thread Christian König
Yeah, thinking about this since I've seen Michels response this morning. The only major thing which is different is the TLB pressure, e.g. VRAM is allocated continuously and so you can work much more with setting the fragmentation flag in the VM page tables. If you have a system to test this

[Mesa-dev] [PATCH] r600: ignore PIPE_BIND_LINEAR in *_is_format_supported

2016-03-30 Thread Christian König
From: Christian König <christian.koe...@amd.com> Similar to radeonsi linear layout should work for all not compressed or depth/stencil formats. Fixes issues with VDPAU on r600. Signed-off-by: Christian König <christian.koe...@amd.com> --- src/gallium/drivers/r600/evergreen

Re: [Mesa-dev] st/mesa: implement new DMA-buf based VDPAU interop v2 - REGRESSION on r600

2016-03-30 Thread Christian König
Am 30.03.2016 um 06:36 schrieb Dieter Nützel: Hello Christian, after all this new VDPAU stuff, I get after ages (months/years) only black window with mplayer -vo vdpau /data/Filme/test.mkv on r600, NI, Turks XT. Switching between full screen and window mode ('F') the innner (black) window

Re: [Mesa-dev] [PATCH] st/vdpau: correct null check

2016-03-30 Thread Christian König
(-) Good catch, patch is Reviewed-by: Christian König <christian.koe...@amd.com> Do you have commit access or should I push it? Thanks, Christian. diff --git a/src/gallium/state_trackers/vdpau/surface.c b/src/gallium/state_trackers/vdpau/surface.c index 0550141..d418d56 100644 --- a/src/g

Re: [Mesa-dev] [PATCH] r300g: add missing layer argument to rws->buffer_get_handle() call

2016-03-19 Thread Christian König
Ups, yeah that's a rebase problem. Sorry for not compiling R300 once more. Patch is Reviewed-by: Christian König <christian.koe...@amd.com> Regards, Christian. Am 17.03.2016 um 16:49 schrieb Brian Paul: Fixes compilation error since 5aea0d691. --- src/gallium/drivers/r300/r300_texture

Re: [Mesa-dev] [PATCH 05/10] radeonsi: ignore PIPE_BIND_LINEAR in si_is_format_supported

2016-03-19 Thread Christian König
Am 09.03.2016 um 15:53 schrieb Marek Olšák: On Wed, Mar 9, 2016 at 4:54 AM, Michel Dänzer <mic...@daenzer.net> wrote: On 08.03.2016 21:21, Christian König wrote: From: Christian König <christian.koe...@amd.com> Linear layout should work for all formats as well. The hardware actu

Re: [Mesa-dev] [PATCH 10/10] st/mesa: implement new DMA-buf based VDPAU interop

2016-03-10 Thread Christian König
:21 PM, Christian König <deathsim...@vodafone.de> wrote: From: Christian König <christian.koe...@amd.com> Avoid using internal structures from another API. Signed-off-by: Christian König <christian.koe...@amd.com> --- src/mesa/state_tracker/st_vdpau.c | 176 +++

Re: [Mesa-dev] radeonsi external audio + powerconsumption

2016-03-09 Thread Christian König
The only of hand "hack" I can see is to open up an HDMI connector, shortcut the hot plug detection pin and then connect that as "output device" to the amplifier. It should fix your issues with the hot plug detection. You most likely still won't get a valid EDID, but that can be overridden

Re: [Mesa-dev] radeonsi external audio + powerconsumption

2016-03-09 Thread Christian König
That configuration can't work correctly. With HDMI the audio data is interleaved in the video vertical and horizontal sync periods. So if you don't have video you don't have any way to submit audio either. What the driver properly does is providing a dummy video signal so that audio can be

[Mesa-dev] [PATCH 03/10] radeon/winsys: add offset support for BO import/export

2016-03-08 Thread Christian König
From: Christian König <christian.koe...@amd.com> Add offset support to handle NV12 offsets as well. Signed-off-by: Christian König <christian.koe...@amd.com> --- src/gallium/drivers/r300/r300_texture.c | 6 +++--- src/gallium/drivers/radeon/r600_textur

[Mesa-dev] [PATCH 09/10] st/vdpau: implement the new DMA-buf based interop

2016-03-08 Thread Christian König
From: Christian König <christian.koe...@amd.com> That should allow us to get away from passing internal structures around. Signed-off-by: Christian König <christian.koe...@amd.com> --- src/gallium/state_trackers/vdpau/ftab.c | 6 ++- src/gallium/state_trackers/vd

[Mesa-dev] [PATCH 10/10] st/mesa: implement new DMA-buf based VDPAU interop

2016-03-08 Thread Christian König
From: Christian König <christian.koe...@amd.com> Avoid using internal structures from another API. Signed-off-by: Christian König <christian.koe...@amd.com> --- src/mesa/state_tracker/st_vdpau.c | 176 -- 1 file changed, 129 insertions(+),

[Mesa-dev] [PATCH 07/10] st/vdpau: add new interop interface

2016-03-08 Thread Christian König
From: Christian König <christian.koe...@amd.com> Use DMA-buf for the VDPAU interop interface instead of using internal structures. Signed-off-by: Christian König <christian.koe...@amd.com> --- src/gallium/include/state_tracker/vdpau_dmabuf.h | 94 +++ src/gal

[Mesa-dev] [PATCH 06/10] st/vdpau: use linear layout for output surfaces

2016-03-08 Thread Christian König
From: Christian König <christian.koe...@amd.com> Works around a bug in radeonsi and tiling is actually not very beneficial in this use case. Signed-off-by: Christian König <christian.koe...@amd.com> --- src/gallium/state_trackers/vdpau/output.c | 3 ++- 1 file changed, 2 inse

[Mesa-dev] [PATCH 05/10] radeonsi: ignore PIPE_BIND_LINEAR in si_is_format_supported

2016-03-08 Thread Christian König
From: Christian König <christian.koe...@amd.com> Linear layout should work for all formats as well. Signed-off-by: Christian König <christian.koe...@amd.com> --- src/gallium/drivers/radeonsi/si_state.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/drivers/radeons

[Mesa-dev] [PATCH 08/10] st/vdpau: move FormatRGBAToPipe into the interop

2016-03-08 Thread Christian König
From: Christian König <christian.koe...@amd.com> We are going to need that in the Mesa state tracker as well. Signed-off-by: Christian König <christian.koe...@amd.com> --- src/gallium/include/state_tracker/vdpau_funcs.h | 65 src/gallium/state_trackers/vd

[Mesa-dev] [PATCH 01/10] gallium/winsys/drm: add offset to struct winsys_handle

2016-03-08 Thread Christian König
From: Christian König <christian.koe...@amd.com> We are going to need this for EGL_EXT_image_dma_buf_import. Signed-off-by: Christian König <christian.koe...@amd.com> --- src/gallium/include/state_tracker/drm_driver.h| 5 + src/gallium/state_trackers/dri/dri2.c

[Mesa-dev] [PATCH 04/10] radeon/winsys: add layer support for BO export

2016-03-08 Thread Christian König
From: Christian König <christian.koe...@amd.com> Add layer support to export individual array layers. Signed-off-by: Christian König <christian.koe...@amd.com> --- src/gallium/drivers/radeon/r600_texture.c | 1 + src/gallium/drivers/radeon/radeon_winsys.h| 1 + src/gallium/w

[Mesa-dev] New DMA-Buf based interop for VDPAU/OpenGL.

2016-03-08 Thread Christian König
Hi everyone, the following series of patches define and implement an new DMA-Buf based interface for interop between VDPAU and OpenGL in Mesa. The basic idea is that we want to be independent of the source code versions used in both and so avoid using Mesa internal structures for the interop. I

[Mesa-dev] [PATCH 02/10] gallium/winsys/drm: add layer to struct winsys_handle

2016-03-08 Thread Christian König
From: Christian König <christian.koe...@amd.com> For exporting a specific layer of an array texture. Signed-off-by: Christian König <christian.koe...@amd.com> --- src/gallium/include/state_tracker/drm_driver.h | 5 + 1 file changed, 5 insertions(+) diff --git a/src/gal

[Mesa-dev] [PATCH] radeon/uvd: disable MPEG1

2016-02-29 Thread Christian König
From: Christian König <christian.koe...@amd.com> The hardware simply doesn't support that correctly. Signed-off-by: Christian König <christian.koe...@amd.com> --- src/gallium/drivers/radeon/radeon_video.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/dr

Re: [Mesa-dev] [PATCH] radeonsi: also dump shaders on a VM fault

2016-02-25 Thread Christian König
Am 25.02.2016 um 17:54 schrieb Marek Olšák: From: Marek Olšák <marek.ol...@amd.com> Clearly a good idea. Patch is Reviewed-by: Christian König <christian.koe...@amd.com> --- src/gallium/drivers/radeonsi/si_debug.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)

Re: [Mesa-dev] [Libva] vaPutSurface never returns

2016-02-19 Thread Christian König
Questions for VDPAU should probably go to either the Mesa list or the VDPAU list, libva is completely unrelated to this. Well is it possible that you just locked up the GPU? Please take a look at /sys/kernel/debug/dri/0/radeon_fence_info and dmesg. Regards, Christian. Am 18.02.2016 um 23:43

Re: [Mesa-dev] [PATCH] st/omx/h264: fix corruption when scaling matrix present flag is set

2016-02-01 Thread Christian König
Am 01.02.2016 um 17:09 schrieb Leo Liu: The scaling lsit should be filling out with zig zag scan Cc: "11.0 11.1" Signed-off-by: Leo Liu --- src/gallium/state_trackers/omx/vid_dec_h264.c | 21 +++-- 1 file changed, 19

Re: [Mesa-dev] [PATCH v2 2/2] st/omx/h264: fix corruption when scaling matrix present flag is set

2016-02-01 Thread Christian König
. No idea why. I think we can leave optimizing the away which list to use to the compiler, patches are Reviewed-by: Christian König <christian.koe...@amd.com> Regards, Christian. if (nextScale != 0) { signed delta_scale = vl_rbsp_se(rbsp); @@ -

Re: [Mesa-dev] [PATCH 1/2] winsys/amdgpu: Handle RADEON_FLAG_NO_CPU_ACCESS

2016-01-26 Thread Christian König
change shouldn't be backported to stable branches, because released versions of xf86-video-amdgpu unnecessarily try to map the front buffer) Signed-off-by: Michel Dänzer <michel.daen...@amd.com> For those two Reviewed-by: Christian König <christian.koe...@amd.com>. --- src/gallium

Re: [Mesa-dev] [PATCH] st/mesa: conditionally enable GL_NV_vdpau_interop

2016-01-22 Thread Christian König
6 at 21:02, Christian König <deathsim...@vodafone.de> wrote: Advertising NV_vdpau_interop while the backend for the driver isn't installed is fine, cause this only means that the OpenGL side has support for it. Mesa doesn't have a runtime dependency on libvdpau and to initialize NV_vdpau_interop

Re: [Mesa-dev] [PATCH] st/mesa: conditionally enable GL_NV_vdpau_interop

2016-01-22 Thread Christian König
Am 22.01.2016 um 19:24 schrieb Ilia Mirkin: On Fri, Jan 22, 2016 at 1:15 PM, Christian König <deathsim...@vodafone.de> wrote: Form autofoo perspective things look great. Thanks, that exactly what I wanted to know. Although I second Ilia's concern - we need a form of runtime detectio

[Mesa-dev] [PATCH] st/mesa: conditionally enable GL_NV_vdpau_interop

2016-01-21 Thread Christian König
From: Christian König <christian.koe...@amd.com> Only enable it when we compile the state tracker as well. Signed-off-by: Christian König <christian.koe...@amd.com> --- configure.ac | 1 + src/mesa/state_tracker/st_extensions.c | 2 ++ src/mesa/state_tracke

Re: [Mesa-dev] [PATCH] st/mesa: conditionally enable GL_NV_vdpau_interop

2016-01-21 Thread Christian König
builds with vdpau and everything else enabled, but then ships the libraries separately... On Thu, Jan 21, 2016 at 11:05 AM, Christian König <deathsim...@vodafone.de> wrote: From: Christian König <christian.koe...@amd.com> Only enable it when we compile the state tracker as well.

Re: [Mesa-dev] [PATCH 9/9] st/va: add motion adaptive deinterlacing

2016-01-12 Thread Christian König
Am 18.12.2015 um 16:04 schrieb Emil Velikov: On 16 December 2015 at 20:14, Christian König <deathsim...@vodafone.de> wrote: @@ -174,6 +175,51 @@ static VAStatus vlVaPostProcBlit(vlVaDriver *drv, vlVaContext *context, return VA_STATUS_SUCCESS; } +static struct pipe_video_

Re: [Mesa-dev] [PATCH] nir: special hack for TGSI vs indirect inputs

2016-01-12 Thread Christian König
Am 11.01.2016 um 20:55 schrieb Marek Olšák: On Mon, Jan 11, 2016 at 8:00 PM, Rob Clark wrote: On Mon, Jan 11, 2016 at 1:52 PM, Marek Olšák wrote: On Mon, Jan 11, 2016 at 6:07 PM, Rob Clark wrote: Quite possibly I am.. although

Re: [Mesa-dev] [PATCH v2] st/va: count number of slices

2016-01-05 Thread Christian König
On 04.01.2016 23:31, Julien Isorce wrote: From: Julien Isorce <julien.iso...@gmail.com> The counter was not set but used by the nouveau driver. It is required otherwise visual output is garbage. Signed-off-by: Julien Isorce <j.iso...@samsung.com> Reviewed-by: Christian König &l

Re: [Mesa-dev] [PATCH] st/va: count number of slices

2015-12-23 Thread Christian König
On 23.12.2015 10:28, Julien Isorce wrote: The counter was not set but used by the driver. It is required otherwise visual output is garbage. Signed-off-by: Julien Isorce One minor nit pick below, apart from that the patch look good to me. ---

Re: [Mesa-dev] [PATCH 1/9] st/va: make the implementation thread save

2015-12-21 Thread Christian König
On 21.12.2015 11:05, Andy Furniss wrote: Julien Isorce wrote: Hi Christian, I have 2 remarks: 1: I am sure you have the clear answer to the following questions, so maybe add a comment in the commit message: Isn't the thread safety delegated to the application that use vaapi ? like it is

Re: [Mesa-dev] [PATCH 7/8] st/va: add NV12 -> NV12 post processing

2015-12-18 Thread Christian König
On 15.12.2015 11:16, Emil Velikov wrote: On 11 December 2015 at 12:33, Christian König <deathsim...@vodafone.de> wrote: +static void vlVaBoxAdjust(struct pipe_video_buffer *buf, unsigned idx, + struct pipe_box *box) +{ + if (buf->interlaced) { + bo

[Mesa-dev] [PATCH 4/9] st/va: use vl_video_buffer_adjust_size

2015-12-16 Thread Christian König
From: Christian König <christian.koe...@amd.com> Use the new helper function instead of open coding it. Signed-off-by: Christian König <christian.koe...@amd.com> --- src/gallium/state_trackers/va/image.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff

[Mesa-dev] [PATCH 3/9] st/vdpau: use vl_video_buffer_adjust_size

2015-12-16 Thread Christian König
From: Christian König <christian.koe...@amd.com> Use the new helper function instead of open coding it. Signed-off-by: Christian König <christian.koe...@amd.com> --- src/gallium/state_trackers/vdpau/surface.c | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff

[Mesa-dev] [PATCH 7/9] vl: improve motion adaptive deinterlacer

2015-12-16 Thread Christian König
From: Christian König <christian.koe...@amd.com> Handle other formats than YV12 as well. Signed-off-by: Christian König <christian.koe...@amd.com> --- src/gallium/auxiliary/vl/vl_deint_filter.c | 69 +- src/gallium/auxiliary/vl/vl_deint_filter.h | 2

[Mesa-dev] [PATCH 1/9] st/va: make the implementation thread save

2015-12-16 Thread Christian König
From: Christian König <christian.koe...@amd.com> Otherwise we might crash with MPV. Signed-off-by: Christian König <christian.koe...@amd.com> --- src/gallium/state_trackers/va/buffer.c | 69 +- src/gallium/state_trackers/va/context.c| 6 +++

[Mesa-dev] [PATCH 8/9] vl: use preferred format for deinterlacing

2015-12-16 Thread Christian König
From: Christian König <christian.koe...@amd.com> Signed-off-by: Christian König <christian.koe...@amd.com> --- src/gallium/auxiliary/vl/vl_deint_filter.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/vl/vl_deint_filter.c b/src/galli

[Mesa-dev] [PATCH 6/9] st/va: add BOB deinterlacing v2

2015-12-16 Thread Christian König
From: Christian König <christian.koe...@amd.com> Tested with MPV. v2: correctly handle compositor deinterlacing as well. Signed-off-by: Christian König <christian.koe...@amd.com> --- src/gallium/state_trackers/va/postproc.c | 74 src/gallium/state

[Mesa-dev] [PATCH 9/9] st/va: add motion adaptive deinterlacing

2015-12-16 Thread Christian König
From: Christian König <christian.koe...@amd.com> Signed-off-by: Christian König <christian.koe...@amd.com> --- src/gallium/state_trackers/va/context.c| 5 +++ src/gallium/state_trackers/va/postproc.c | 63 -- src/gallium/state_trackers/va/surfa

[Mesa-dev] [PATCH 5/9] st/va: add NV12 -> NV12 post processing v2

2015-12-16 Thread Christian König
From: Christian König <christian.koe...@amd.com> Usefull for mpv and GStreamer. v2: use common functionality for size adjustment. Signed-off-by: Indrajit-kumar Das <indrajit-kumar@amd.com> Signed-off-by: Christian König <christian.koe...@amd.com> --- src/gallium/state_tra

[Mesa-dev] [PATCH 2/9] vl/buffers: extract vl_video_buffer_adjust_size helper

2015-12-16 Thread Christian König
From: Christian König <christian.koe...@amd.com> Useful for the state trackers as well. Signed-off-by: Christian König <christian.koe...@amd.com> --- src/gallium/auxiliary/vl/vl_video_buffer.c | 10 ++ src/gallium/auxiliary/vl/vl_video_buffer.h | 18 ++ 2 f

Re: [Mesa-dev] [Libva] [PATCH] st/va: retrieve size from the temporary img variable

2015-12-16 Thread Christian König
Yeah, agree reviewing them on the mesa list is probably more appropriate. Anyway patch lgtm as well and is Reviewed-by: Christian König <christian.koe...@amd.com> Regards, Christian. On 15.12.2015 18:53, Julien Isorce wrote: + mesa-dev of course :) Thx Sean On 15 December 2015 at

Re: [Mesa-dev] [PATCH 6/8] st/va: remove fence handling

2015-12-15 Thread Christian König
the RGB-like surface (the one that vpp output), not the NV12 one that come from the decoder directly. Cheers Julien On 14 December 2015 at 10:11, Christian König <deathsim...@vodafone.de <mailto:deathsim...@vodafone.de>> wrote: Also note that in th

Re: [Mesa-dev] [PATCH 4/8] st/va: fix unused variable warning

2015-12-15 Thread Christian König
On 15.12.2015 11:08, Emil Velikov wrote: On 11 December 2015 at 12:33, Christian König <deathsim...@vodafone.de> wrote: From: Christian König <christian.koe...@amd.com> Signed-off-by: Christian König <christian.koe...@amd.com> --- src/gallium/state_trackers/va/pictur

Re: [Mesa-dev] [PATCH 1/8] st/va: remove nonesense HEVC picture id handling

2015-12-14 Thread Christian König
INVALID || hevc->ReferenceFrames[i].picture_id == VA_INVALID_SURFACE ? On 11 December 2015 at 12:33, Christian König <deathsim...@vodafone.de <mailto:deathsim...@vodafone.de>> wrote: From: Christian König <christian.koe...@amd.com <mailto:christian.koe...@amd.com>>

Re: [Mesa-dev] [PATCH 6/8] st/va: remove fence handling

2015-12-14 Thread Christian König
one with nouveau driver and rendering is done with intel. dmabuf in between. Maybe the idea of the patch is good but something is still wrong. I can test any update if it helps. Cheers Julien On 11 December 2015 at 12:33, Christian König <deathsim...@vodafone.de <mailto:deathsim...@vo

[Mesa-dev] [PATCH 6/8] st/va: remove fence handling

2015-12-11 Thread Christian König
From: Christian König <christian.koe...@amd.com> It's nonsense to drain the pipeline like this. Signed-off-by: Christian König <christian.koe...@amd.com> --- src/gallium/state_trackers/va/buffer.c | 5 - src/gallium/state_trackers/va/image.c | 1 - src/gallium/state

[Mesa-dev] [PATCH 8/8] st/va: add BOB/WEAVE deinterlacing

2015-12-11 Thread Christian König
From: Christian König <christian.koe...@amd.com> Tested with MPV. Signed-off-by: Christian König <christian.koe...@amd.com> --- src/gallium/state_trackers/va/postproc.c | 72 src/gallium/state_trackers/va/surface.c | 16 ++- 2 files changed, 7

[Mesa-dev] [PATCH 1/8] st/va: remove nonesense HEVC picture id handling

2015-12-11 Thread Christian König
From: Christian König <christian.koe...@amd.com> The picture id in this case is a VA-API surface handle, checking for a certain value can't be correct. Signed-off-by: Christian König <christian.koe...@amd.com> --- src/gallium/state_trackers/va/picture_hevc.c | 5 - 1 fil

<    1   2   3   4   5   6   7   8   9   10   >