[Mesa-dev] [PATCH 3/8] st/va: clean up post process includes

From: Christian König <christian.koe...@amd.com> Signed-off-by: Christian König <christian.koe...@amd.com> --- src/gallium/state_trackers/va/postproc.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/src/gallium/state_trackers/va/postproc.c b/src/gallium/state_trackers/v

[Mesa-dev] [PATCH 4/8] st/va: fix unused variable warning

From: Christian König <christian.koe...@amd.com> Signed-off-by: Christian König <christian.koe...@amd.com> --- src/gallium/state_trackers/va/picture.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/gallium/state_trackers/va/picture.c b/src/gallium/state_trackers/va/pic

[Mesa-dev] [PATCH 2/8] st/va: cleanup filter color standard handling

From: Christian König <christian.koe...@amd.com> Signed-off-by: Christian König <christian.koe...@amd.com> --- src/gallium/state_trackers/va/surface.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/gallium/state_trackers/va/surface.c b/src/gallium/st

[Mesa-dev] [PATCH 5/8] st/va: handle default post process regions

From: Christian König <christian.koe...@amd.com> Avoid referencing NULL pointers. Signed-off-by: Christian König <christian.koe...@amd.com> --- src/gallium/state_trackers/va/postproc.c | 36 +--- 1 file changed, 28 insertions(+), 8 deletions(-) diff

[Mesa-dev] [PATCH 7/8] st/va: add NV12 -> NV12 post processing

From: Christian König <christian.koe...@amd.com> Usefull for mpv and GStreamer. Signed-off-by: Indrajit-kumar Das <indrajit-kumar@amd.com> Signed-off-by: Christian König <christian.koe...@amd.com> --- src/gallium/state_trackers/va/picture.c | 10 +- src/gallium

[Mesa-dev] [PATCH] st/va: WIP remove nonesense HEVC picture id handling

From: Christian König <christian.koe...@amd.com> The picture id in this case is a VA-API surface handle, checking for a certain value is can't be correct. Does anybody have any idea what the original intention was and how to fix it correctly? Signed-off-by: Christian König <chri

[Mesa-dev] [PATCH 1/2] st/va: move HEVC functions into separate file v2

From: Christian König <christian.koe...@amd.com> v2: actually copy all of it Signed-off-by: Christian König <christian.koe...@amd.com> --- src/gallium/state_trackers/va/Makefile.sources | 1 + src/gallium/state_trackers/va/picture.c| 172 +---

[Mesa-dev] [PATCH 2/2] st/va: disable MPEG4 by default v2

From: Christian König <christian.koe...@amd.com> The workarounds are too hacky to enable them by default and otherwise MPEG4 doesn't work reliably. v2: add docs/envvars.html, CC stable and fix typos Signed-off-by: Christian König <christian.koe...@amd.com> Reviewed-by: Emil Velikov

Re: [Mesa-dev] [PATCH v3] st/va: delay decoder creation until max_references is known

HEVC case defaults to num_render_targets as before. But it could also benefits this change by setting a more accurate max_references number in handlePictureParameterBuffer. Signed-off-by: Julien Isorce <j.iso...@samsung.com> Reviewed-by: Christian König <christian.koe...@amd.com>

Re: [Mesa-dev] [PATCH 1/2] st/va: ensure linear memory for dmabuf

On 29.11.2015 18:26, Emil Velikov wrote: On 27 November 2015 at 08:57, Julien Isorce wrote: In order to do zero-copy between two different devices the memory should not be tiled. This is currently no way to set pipe_resource template's flag from pipe_video_buffer

Re: [Mesa-dev] [PATCH] st/va: add missing break statement

by Coverity (CID 1341052) Fixes: 64761a841db "st/va: move MPEG4 functions into separate file" Cc: Christian König <christian.koe...@amd.com> Cc: Julien Isorce <j.iso...@samsung.com> Signed-off-by: Emil Velikov <emil.l.veli...@gmail.com> Crap, stupid typo. Patch is

Re: [Mesa-dev] [PATCH v2 1/2] st/va: if h264 then delay decoder creation until max_references is known

On 25.11.2015 10:12, Julien Isorce wrote: For commit message please read: "HEVC case is left unchanged since delaying decoder creation is not needed on AMD hardware." In this case please update the commit message, but honestly I'm not sure if we don't use the max_references somewhere in the

Re: [Mesa-dev] [PATCH v2 2/2] st/va: also retrieve reference frames info for h264

On 25.11.2015 10:13, Julien Isorce wrote: From: Julien Isorce <julien.iso...@gmail.com> Other hardwares than AMD require to parse: VAPictureParameterBufferH264.ReferenceFrames[16] Signed-off-by: Julien Isorce <j.iso...@samsung.com> Reviewed-by: Christian König <christian

[Mesa-dev] [PATCH 3/8] st/va: move MPEG12 functions into separate file

From: Christian König <christian.koe...@amd.com> Signed-off-by: Christian König <christian.koe...@amd.com> --- src/gallium/state_trackers/va/Makefile.sources | 1 + src/gallium/state_trackers/va/picture.c| 57 +++--- src/gallium/state_trackers/va/picture_m

[Mesa-dev] [PATCH 5/8] st/va: move VC-1 functions into separate file

From: Christian König <christian.koe...@amd.com> Signed-off-by: Christian König <christian.koe...@amd.com> --- src/gallium/state_trackers/va/Makefile.sources | 1 + src/gallium/state_trackers/va/picture.c| 36 +- src/gallium/state_trackers/va/picture_v

[Mesa-dev] [PATCH 4/8] st/va: move H264 functions into separate file

From: Christian König <christian.koe...@amd.com> Signed-off-by: Christian König <christian.koe...@amd.com> --- src/gallium/state_trackers/va/Makefile.sources | 1 + src/gallium/state_trackers/va/picture.c| 76 + src/gallium/state_trackers/va/picture_h2

[Mesa-dev] [PATCH] st/va: disable MPEG4 by default

From: Christian König <christian.koe...@amd.com> The workarounds are to hacky to enable them by default and otherwise MPEG4 doesn't work reliable. Signed-off-by: Christian König <christian.koe...@amd.com> --- src/gallium/state_trackers/va/config.c | 10 +- 1 file changed,

[Mesa-dev] [PATCH 1/8] st/va: fix post process dirty area handling

From: Christian König <christian.koe...@amd.com> The dirty area in this call isn't related to the screen at all. Signed-off-by: Christian König <christian.koe...@amd.com> --- src/gallium/state_trackers/va/picture.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff

[Mesa-dev] [PATCH 7/8] st/va: move HEVC functions into separate file

From: Christian König <christian.koe...@amd.com> Signed-off-by: Christian König <christian.koe...@amd.com> --- src/gallium/state_trackers/va/Makefile.sources | 1 + src/gallium/state_trackers/va/picture.c| 174 + src/gallium/state_trackers/va/pi

[Mesa-dev] [PATCH 8/8] st/va: fix indentation

From: Christian König <christian.koe...@amd.com> Signed-off-by: Christian König <christian.koe...@amd.com> --- src/gallium/state_trackers/va/picture.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/gallium/state_trackers/va/picture.c b

[Mesa-dev] [PATCH 2/8] st/va: move post processing function into own file

From: Christian König <christian.koe...@amd.com> Signed-off-by: Christian König <christian.koe...@amd.com> --- src/gallium/state_trackers/va/Makefile.sources | 1 + src/gallium/state_trackers/va/picture.c| 58 +--- src/gallium/state_trackers/va/postproc.

[Mesa-dev] [PATCH 6/8] st/va: move MPEG4 functions into separate file

From: Christian König <christian.koe...@amd.com> Signed-off-by: Christian König <christian.koe...@amd.com> --- src/gallium/state_trackers/va/Makefile.sources | 1 + src/gallium/state_trackers/va/picture.c| 186 +- src/gallium/state_trackers/va/picture_mp

Re: [Mesa-dev] [PATCH 1/2] radeon/vce: add new firmware interface support

are Reviewed-by: Christian König <christian.koe...@amd.com> --- src/gallium/drivers/radeon/Makefile.sources | 1 + src/gallium/drivers/radeon/radeon_vce.c | 21 ++- src/gallium/drivers/radeon/radeon_vce.h | 3 + src/gallium/drivers/radeon/radeon_vce_52.c | 242 ++

Re: [Mesa-dev] [PATCH 3/4] st/va: properly set max number of reference frames

On 19.11.2015 10:37, Julien Isorce wrote: It fixes asserts like assert(templ->max_references <= 2) in nvc0_video.c::nvc0_create_decodier This patch also post-update the correct value for the number of reference frames in the h264 case, see below. In VA-API the max num ref is retrieved later in

Re: [Mesa-dev] [PATCH] st/va: add mpeg4 startcode workaround

On 06.11.2015 20:28, Ilia Mirkin wrote: On Fri, Nov 6, 2015 at 2:15 PM, Christian König <deathsim...@vodafone.de> wrote: On 06.11.2015 20:10, Ilia Mirkin wrote: On Fri, Nov 6, 2015 at 1:48 PM, Zhang, Boyuan <boyuan.zh...@amd.com> wrote: Hi Emil, Please see the following infor

[Mesa-dev] [PATCH] radeon/uvd: add H.265/HEVC to legal notes

From: Christian König <christian.koe...@amd.com> Signed-off-by: Christian König <christian.koe...@amd.com> --- docs/README.UVD | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/README.UVD b/docs/README.UVD index 38ea864..b0f4b9d 100644 --- a/docs/README.UV

[Mesa-dev] [PATCH 2/2] radeon/uvd: fix VC-1 simple/main profile decode v2

From: Boyuan Zhang <boyuan.zh...@amd.com> We just needed to set the extra width/height fields to get this working. v2 (chk): rebased, CC stable added, commit message added, fixed coding style Signed-off-by: Boyuan Zhang <boyuan.zh...@amd.com> Signed-off-by: Christian König &l

[Mesa-dev] [PATCH 1/2] st/vaapi: fix vaapi VC-1 simple/main corruption v2

From: Boyuan Zhang <boyuan.zh...@amd.com> Apply the start code fix only to advanced profile. v2 (chk): add commit message Signed-off-by: Boyuan Zhang <boyuan.zh...@amd.com> Reviewed-by: Christian König <christian.koe...@amd.com> Cc: "10.6 11.0" <mesa-sta...@

[Mesa-dev] fix VC-1 simple/main profile

Hi list, we haven't fixed all the issues yet, but this is a clearly step in the right direction. If nobody has any more objections I'm going to push these by the end of today. Regards, Christian. ___ mesa-dev mailing list

Re: [Mesa-dev] [PATCH] st/va: add mpeg4 startcode workaround

On 06.11.2015 20:10, Ilia Mirkin wrote: On Fri, Nov 6, 2015 at 1:48 PM, Zhang, Boyuan wrote: Hi Emil, Please see the following information about this patch. - Issue: For Mpeg4, the VOP and GOV headers were truncated. With the existing workaround in st/va, playback

Re: [Mesa-dev] [PATCH v2 1/4] st/va: properly indent buffer.c, config.c, image.c and picture.c

about the switch statement from the commit message now that this fix is in a separate patch. With that fixed the whole set is Reviewed-by: Christian König <christian.koe...@amd.com> Regards, Christian. --- src/gallium/state_trackers/va/buffer.c | 14 +++--- src/gallium/state_trackers

Re: [Mesa-dev] [PATCH 0/4] st/va: indent, leak fix and RGBx/BGRx for vpp

Patches #1-#3 are Reviewed-by: Christian König <christian.koe...@amd.com> Please split patch #4 in two with first adding the new vl_video_buffer formats and then using them in the state tracker. Should I commit that for you as well or do you now have an account? Regards, Chr

Re: [Mesa-dev] [PATCH 2/4] vl: add drm support for vl_screen

+/** + * + * Copyright 2009 Younes Manton. + * All Rights Reserved. You probably want to change the copyright here. With that fixed the whole series is Reviewed-by: Christian König <christian.koe...@amd.com> R

Re: [Mesa-dev] [PATCH] winsys/radeon: Use CPU page size instead of hardcoding 4096 bytes

With that fixed the patch is Reviewed-by: Christian König <christian.koe...@amd.com> pipe_mutex_lock(mgr->bo_va_mutex); /* first look for a hole */ @@ -246,7 +252,7 @@ static void radeon_bomgr_free_va(struct radeon_bomgr *mgr, uint64_t va, uint64_t { struct

Re: [Mesa-dev] [PATCH] winsys/radeon: Use CPU page size instead of hardcoding 4096 bytes

On 04.11.2015 10:10, Michel Dänzer wrote: On 04.11.2015 18:06, Christian König wrote: On 04.11.2015 09:54, Michel Dänzer wrote: @@ -188,8 +191,11 @@ static uint64_t radeon_bomgr_find_va(struct radeon_bomgr *mgr, uint64_t size, ui struct radeon_bo_va_hole *hole, *n; uint64_t

Re: [Mesa-dev] Avoid segfault in omx deconstructor

The subject line should have something like "st/omx: ...". Apart from that the patch is Reviewed-by: Christian König <christian.koe...@amd.com> Regards, Christian. On 03.11.2015 19:06, StDenis, Tom wrote: Now with the correct email address ..

Re: [Mesa-dev] [PATCH v4 7/9] st/va: add headless support, i.e. VA_DISPLAY_DRM

On 29.10.2015 18:40, Julien Isorce wrote: This patch allows to use gallium vaapi without requiring a X server running for your second graphic card. Signed-off-by: Julien Isorce <j.iso...@samsung.com> Reviewed-by: Christian König <christian.koe...@amd.com> --- src/gallium/state

Re: [Mesa-dev] [PATCH v4 8/9] st/va: implement VaDeriveImage

com> Reviewed-by: Christian König <christian.koe...@amd.com> --- src/gallium/state_trackers/va/buffer.c | 43 -- src/gallium/state_trackers/va/image.c | 92 +- src/gallium/state_trackers/va/va_private.h | 5 ++ 3 files changed, 135 inse

Re: [Mesa-dev] [PATCH v4 9/9] st/va: add support to export a surface as dmabuf

/intel-driver Tested with gstreamer-vaapi with nouveau driver. Signed-off-by: Julien Isorce <j.iso...@samsung.com> Reviewed-by: Christian König <christian.koe...@amd.com> --- src/gallium/state_trackers/va/buffer.c | 136 - src/gallium/state

Re: [Mesa-dev] [PATCH v4 6/9] st/va: add colospace conversion through Video Post Processing

vlVaQueryVideoProcPipelineCaps Add handleVAProcPipelineParameterBufferType helper. One application is: VASurfaceNV12 -> gstvaapipostproc -> VASurfaceRGBA Signed-off-by: Julien Isorce <j.iso...@samsung.com> Reviewed-by: Christian König <christian.koe...@amd.com> Are you planning to implement the

Re: [Mesa-dev] [PATCH v2 07/13] st/va: add headless support, i.e. VA_DISPLAY_DRM

+ drm_info = (struct drm_state *) ctx->drm_state; + if (!drm_info) { + FREE(drv); + return VA_STATUS_ERROR_INVALID_PARAMETER; + } + +#if GALLIUM_STATIC_TARGETS + drm_fd = drm_info->fd; +#else + drm_fd = dup(drm_info->fd); +#endif + + if (drm_fd < 0)

Re: [Mesa-dev] [PATCH v2 6/8] st/va: handle Video Post Processing for configs

viewed-by: Christian König <christian.koe...@amd.com> --- src/gallium/state_trackers/va/config.c | 20 src/gallium/state_trackers/va/va_private.h | 5 - 2 files changed, 24 insertions(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/va/config.c b

Re: [Mesa-dev] [PATCH 1/2] st/va: implement VaDeriveImage

Patch #1: + if (buf->data) + FREE(buf->data); FREE() usually does a NULL check anyway. Apart from that minor nitpick the patch is Reviewed-by: Christian König <christian.koe...@amd.com> Regards, Christian. On 29.10.2015 12:47, Julien Isorce wrote: And apply rela

Re: [Mesa-dev] [PATCH 0/7] st/va: VPP, dmabuf import and headless.

Hi Julien, if Emil or Ilia have no further comments please send out your full set of patches once more I would like to get this pusched upstream. Best regards, Christian. On 17.10.2015 01:14, Julien Isorce wrote: This patch serie adds initial support for Video Post Processing. It also

Re: [Mesa-dev] [PATCH v2 7/8] st/va: add colospace conversion through Video Post Processing

+if(src_surface->fence) { + screen->fence_finish(screen, src_surface->fence, PIPE_TIMEOUT_INFINITE); + screen->fence_reference(screen, _surface->fence, NULL); +} That shouldn't be necessary cause all render operations to the same surface are pipelined anyway. Regards,

Re: [Mesa-dev] [PATCH 2/2] st/va: add support to export a surface as dmabuf

@@ -108,6 +109,9 @@ vlVaMapBuffer(VADriverContextP ctx, VABufferID buf_id, void **pbuff) if (!buf) return VA_STATUS_ERROR_INVALID_BUFFER; + if (buf->export_refcount > 0) + return VA_STATUS_ERROR_INVALID_BUFFER; Why it is illegal to CPU map a buffer which is exported? +

Re: [Mesa-dev] [PATCH v4 1/9] st/va: properly defines VAImageFormat formats and improve VaCreateImage

@@ -80,12 +82,46 @@ YCbCrToPipe(unsigned format) ... +PipeToYCbCr(enum pipe_format p_format) You should probably rename those two functions as well, cause when we start to handle RGB formats as well the name doesn't match any more. BTW when do you use PipeToYCbCr? Regards, Christian. On

Re: [Mesa-dev] [PATCH v4 2/9] st/va: do not destroy old buffer when new one failed

-by: Julien Isorce <j.iso...@samsung.com> Reviewed-by: Christian König <christian.koe...@amd.com> Should I push the patches already reviewed? Regards, Christian. --- src/gallium/state_trackers/va/image.c | 19 +-- 1 file changed, 13 insertions(+), 6 deletions(-) diff

Re: [Mesa-dev] [PATCH v4 5/9] st/va: handle Video Post Processing for configs

viewed-by: Christian König <christian.koe...@amd.com> But you should reorder the patch, e.g. commit patch #6 first and then patch #5. Otherwise we have a state where the state tracker claims to support post processing but doesn't. Christian. --- src/gallium/state_trackers/va/confi

Re: [Mesa-dev] [PATCH v4 4/9] st/va: implement dmabuf import for VaCreateSurfaces2

On 29.10.2015 18:40, Julien Isorce wrote: For now it is limited to RGBA, BGRA, RGBX, BGRX surfaces. Signed-off-by: Julien Isorce --- src/gallium/state_trackers/va/surface.c | 97 - 1 file changed, 96 insertions(+), 1 deletion(-) diff

Re: [Mesa-dev] [PATCH] mesa: set the texture target in VDPAUMapSurfacesNV

DPAU interop thus things broke." With those Reviewed-by: Emil Velikov <emil.l.veli...@gmail.com> Yeah that explanation sounds sane to me. Patch is Reviewed-by: Christian König <christian.koe...@amd.com> as well. Thanks for digging up wh

Re: [Mesa-dev] [PATCH] st/va: pass picture desc to begin and decode

Done, but you should apply for an account. Best regards, Christian. On 26.10.2015 13:46, Julien Isorce wrote: Hi Christian, Would you mind to push this patch ? Thx Cheers Julien On 23 October 2015 at 14:33, Christian König <deathsim...@vodafone.de <mailto:deathsim...@vodafone.de&g

Re: [Mesa-dev] [PATCH] st/va: pass picture desc to begin and decode

On 23.10.2015 14:25, Julien Isorce wrote: At least vl_mpeg12_decoder uses the picture desc in begin_frame and decode_bitstream. https://bugs.freedesktop.org/show_bug.cgi?id=92634 Signed-off-by: Julien Isorce <j.iso...@samsung.com> Reviewed-by: Christian König <christian.koe..

Re: [Mesa-dev] [PATCH] radeon/uvd: don't expose HEVC on old UVD hw (v3)

statement, so drop encode checks in the lower case statement. Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> Cc: mesa-sta...@lists.freedesktop.org Reviewed-by: Christian König <christian.koe...@amd.com> --- src/gallium/drivers/radeon/radeon_

Re: [Mesa-dev] [PATCH] radeon/uvd: don't expose HEVC on old UVD hw (v2)

On 22.10.2015 19:50, Alex Deucher wrote: The section for UVD 2 and older was not updated when HEVC support was added. Reported by Kano on irc. v2: integrate the UVD2 and older checks into the main switch statement. Signed-off-by: Alex Deucher Cc:

Re: [Mesa-dev] [PATCH 1/2] Used correct parameter to derive the value of the "h" variable in vlVaCreateImage

On 16.10.2015 18:02, Emil Velikov wrote: On 16 October 2015 at 15:53, Christian König <deathsim...@vodafone.de> wrote: From: Indrajit Das <indrajit-kumar@amd.com> Reviewed-by: Christian König <christian.koe...@amd.com> Nicely spotted ! For the future use correct pref

Re: [Mesa-dev] [PATCH] st/omx/dec/h264: fix field picture type 0 poc disorder

Reviewed-by: Christian König <christian.koe...@amd.com> For mesa you can push small fixes like this even without a review when nobody objects after a few days. Regards, Christian. On 19.10.2015 16:55, Liu, Leo wrote: Ping... -Original Message- From: Liu, Leo Sent: Wed

[Mesa-dev] [PATCH 2/2] Added support for NV12 to IYUV conversion in vlVaGetImage

From: Indrajit Das <indrajit-kumar@amd.com> Reviewed-by: Christian König <christian.koe...@amd.com> --- src/gallium/state_trackers/va/image.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/gallium/state_trackers/va/image.c b/src/gallium/state

[Mesa-dev] [PATCH 1/2] Used correct parameter to derive the value of the "h" variable in vlVaCreateImage

From: Indrajit Das <indrajit-kumar@amd.com> Reviewed-by: Christian König <christian.koe...@amd.com> --- src/gallium/state_trackers/va/image.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/va/image.c b/src/gallium/state_tracker

[Mesa-dev] [PATCH 2/2] r600/vce: enable VCE for trinity/richland

From: Christian König <christian.koe...@amd.com> Signed-off-by: Christian König <christian.koe...@amd.com> --- src/gallium/drivers/r600/r600_uvd.c | 22 +- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/r600/r600_uvd.c b/src/gal

[Mesa-dev] [PATCH 1/2] r600/uvd: disable UVD tiling by default

From: Christian König <christian.koe...@amd.com> It has only minimal advantages for post processing and doesn't work with VCE. Signed-off-by: Christian König <christian.koe...@amd.com> --- src/gallium/drivers/r600/r600_uvd.c | 8 +--- 1 file changed, 5 insertions(+), 3 deleti

Re: [Mesa-dev] [PATCH] radeonsi: don't set DATA_FORMAT if ADD_TID_ENABLE is set on VI (v2)

On 01.10.2015 05:44, Michel Dänzer wrote: On 01.10.2015 04:11, Marek Olšák wrote: From: Marek Olšák <marek.ol...@amd.com> This can cause incorrect address calculations and hangs. v2: do it properly Cc: mesa-sta...@lists.freedesktop.org Tested-and-Reviewed-by: Christian König <chri

Re: [Mesa-dev] [PATCH 1/2] st/vaapi: fix vaapi VC-1 simple/main corruption

On 23.09.2015 17:34, Matt Turner wrote: Should these patches go to the stable branch as well? Good point, most likely yes. Thanks, Christian. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

Re: [Mesa-dev] [PATCH 2/2] radeon/uvd: fix VC-1 simple/main profile decode

Hi Grigori, On 23.09.2015 19:46, Grigori Goronzy wrote: Hi, On 23.09.2015 10:11, Christian König wrote: From: Boyuan Zhang <boyuan.zh...@amd.com> Signed-off-by: Boyuan Zhang <boyuan.zh...@amd.com> Reviewed-by: Christian König <christian.koe...@amd.com> --- Thanks, nice t

[Mesa-dev] [PATCH 2/2] radeon/uvd: fix VC-1 simple/main profile decode

From: Boyuan Zhang <boyuan.zh...@amd.com> Signed-off-by: Boyuan Zhang <boyuan.zh...@amd.com> Reviewed-by: Christian König <christian.koe...@amd.com> --- src/gallium/drivers/radeon/radeon_uvd.c | 6 ++ src/gallium/drivers/radeon/radeon_video.c | 5 + 2 files changed,

[Mesa-dev] [PATCH 1/2] st/vaapi: fix vaapi VC-1 simple/main corruption

From: Boyuan Zhang <boyuan.zh...@amd.com> Signed-off-by: Boyuan Zhang <boyuan.zh...@amd.com> Reviewed-by: Christian König <christian.koe...@amd.com> --- src/gallium/state_trackers/va/picture.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/state_trackers/v

Re: [Mesa-dev] [PATCH 00/17] RadeonSI: Handling buffer allocation failures properly

Indeed nice cleanup, I wonder if that helps with our current problem as well. But allocation failures are printed in dmesg as well, aren't they? Anyway patches are Acked-by: Christian König <christian.koe...@amd.com> Regards, Christian. On 10.09.2015 19:56, Marek Olšák wrote: Hi,

Re: [Mesa-dev] [PATCH 00/42] RadeonSI cleaning up states

Lastly, the INDIRECT_BUFFER packet is used for the init_config state on CIK and later. For the series: Reviewed-by: Alex Deucher <alexander.deuc...@amd.com> Nice cleanup. Whole series is Acked-by: Christian König <christian.koe...@amd.com> Regards, Ch

Re: [Mesa-dev] vlVaQueryImageFormats and vlVdpVideoSurfaceQueryGetPutBitsYCbCrCapabilities also return unsupported formats

vlVaQuerySurfaceAttributes. Well, badly designed interface would I say, but that's already well known :) Fully implementing vlVaQuerySurfaceAttributes indeed sounds like the right solution to me. Regards, Christian. Thx Julien On 21 August 2015 at 18:31, Christian König deathsim...@vodafone.de

Re: [Mesa-dev] [PATCH 00/15] gallium/radeonsi hang debugging and IB parser

Nice work! Finally something that goes into the direction of proper hang debugging for end users. I don't have time to completely review it but the whole set is Acked-by: Christian König christian.koe...@amd.com Regards, Christian. On 23.08.2015 14:04, Marek Olšák wrote: Hi, Setting

Re: [Mesa-dev] vlVaQueryImageFormats and vlVdpVideoSurfaceQueryGetPutBitsYCbCrCapabilities also return unsupported formats

On 21.08.2015 18:30, Ilia Mirkin wrote: On Fri, Aug 21, 2015 at 12:22 PM, Julien Isorce julien.iso...@gmail.com wrote: What is the purpose of checking PIPE_VIDEO_PROFILE_UNKNOWN : http://cgit.freedesktop.org/mesa/mesa/tree/src/gallium/drivers/nouveau/nouveau_vp3_video.c#n486 and

Re: [Mesa-dev] [PATCH] radeon/uvd: remove unused variables

On 18.08.2015 01:51, Grazvydas Ignotas wrote: Recent commits introduced new unused variable warnings, fix them. Reviewed-by: Christian König christian.koe...@amd.com Do you have commit access? Regards, Christian. --- src/gallium/drivers/radeon/radeon_uvd.c | 5 + 1 file changed, 1

Re: [Mesa-dev] [PATCH] radeon/uvd: remove unused variables

On 18.08.2015 14:09, Grazvydas Ignotas wrote: On Tue, Aug 18, 2015 at 11:30 AM, Christian König deathsim...@vodafone.de wrote: On 18.08.2015 01:51, Grazvydas Ignotas wrote: Recent commits introduced new unused variable warnings, fix them. Reviewed-by: Christian König christian.koe...@amd.com

Re: [Mesa-dev] [PATCH] gallium/radeon: add a debug flag not to use write combining

can we disable HDP flushes and other flushes for USWC when we don't use write combining and CPU writes to VRAM? Nope, write combining happens in the CPU before the write request is send over the PCIe bus. The HDP is a (rather small) read/write cache in GPUs memory controller as far as I know.

Re: [Mesa-dev] [PATCH] vl/mpeg12: Silence GCC unused-variable warning.

...@freedesktop.org Reviewed-by: Christian König christian.koe...@amd.com --- src/gallium/auxiliary/vl/vl_mpeg12_bitstream.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/auxiliary/vl/vl_mpeg12_bitstream.c b/src/gallium/auxiliary/vl/vl_mpeg12_bitstream.c index 539a991..52ce6c4

Re: [Mesa-dev] [PATCH] libdrm/amdgpu: Use private fd for amdgpu_device and winsys hash table to fix ZaphodHeads.

of the file descriptor. That was obviously not implemented like this (we leak the descriptor on destruction), but IIRC there was a reason for doing it like this. The patch is Reviewed-by: Christian König christian.koe...@amd.com for now, but I'm not 100% sure if that's the last word on the topic

Re: [Mesa-dev] [PATCH 0/4] fence refcnting fixes

Oh, yes please. That also annoyed me once or twice while hacking on the state trackers. Since I'm not into the drivers those changes are Acked-by: Christian König christian.koe...@amd.com Do you want to take care of the state trackers as well or should I look into the video state trackers

[Mesa-dev] [PATCH 2/2] st/vdpau: fix mixer size checks

From: Christian König christian.koe...@amd.com We need to check what the 3D pipe is able to handle for the mixer, not what the decoder is able to decode. This fixes output of resolutions like 720x1280. Signed-off-by: Christian König christian.koe...@amd.com CC: mesa-sta...@lists.freedesktop.org

[Mesa-dev] [PATCH 1/2] vl: cleanup video buffer private when the decoder is destroyed

From: Christian König christian.koe...@amd.com Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=90728 Signed-off-by: Christian König christian.koe...@amd.com CC: mesa-sta...@lists.freedesktop.org --- src/gallium/auxiliary/vl/vl_mpeg12_decoder.c | 24 src/gallium

Re: [Mesa-dev] abundance of branches in mesa.git

On 22.06.2015 15:41, Ilia Mirkin wrote: On Mon, Jun 22, 2015 at 9:39 AM, Tom Stellard t...@stellard.net wrote: On Mon, Jun 22, 2015 at 12:23:54PM +0200, Marek Olšák wrote: On Mon, Jun 22, 2015 at 5:36 AM, Ilia Mirkin imir...@alum.mit.edu wrote: On Sun, Jun 21, 2015 at 11:33 PM, Michel Dänzer

Re: [Mesa-dev] abundance of branches in mesa.git

Hi Ilia, oh, yes please. Especially since some people tend to completely mirror the mesa master repository including all those old branches. This sometimes creates quite a mess. Regards, Christian. On 20.06.2015 02:10, Ilia Mirkin wrote: Hello, There are a *ton* of branches in the

Re: [Mesa-dev] [PATCH] winsys/radeon: Unmap GPU VM address range when destroying BO

On 17.06.2015 04:54, Michel Dänzer wrote: On 16.06.2015 20:39, Christian König wrote: On 16.06.2015 10:56, Michel Dänzer wrote: On 16.06.2015 17:34, Christian König wrote: What we would need to really clean that up is to make the VM mappings per GEM handle like you suggested or allow multiple

Re: [Mesa-dev] [PATCH] winsys/radeon: Unmap GPU VM address range when destroying BO

On 16.06.2015 10:28, Michel Dänzer wrote: From: Michel Dänzer michel.daen...@amd.com But only when doing so is safe according to the RADEON_INFO_VA_UNMAP_WORKING kernel query. This avoids GPU VM address range conflicts when the BO has other references than the GEM handle being closed, e.g.

Re: [Mesa-dev] [PATCH] winsys/radeon: Unmap GPU VM address range when destroying BO

On 16.06.2015 10:56, Michel Dänzer wrote: On 16.06.2015 17:34, Christian König wrote: On 16.06.2015 10:28, Michel Dänzer wrote: From: Michel Dänzer michel.daen...@amd.com But only when doing so is safe according to the RADEON_INFO_VA_UNMAP_WORKING kernel query. This avoids GPU VM address

[Mesa-dev] [PATCH 2/2] radeon/vce: adapt new firmware interface changes

From: Christian König christian.koe...@amd.com v2: make this also compatible with original released firmware v3 (chk): switch to original idea of separate files for fw versions Signed-off-by: Leo Liu leo@amd.com Signed-off-by: Christian König christian.koe...@amd.com Reviewed-by: Alex

[Mesa-dev] [PATCH 1/2] radeon/vce: move CPB handling function into common code

From: Christian König christian.koe...@amd.com They are not firmware version dependent. Signed-off-by: Christian König christian.koe...@amd.com --- src/gallium/drivers/radeon/radeon_vce.c| 38 ++ src/gallium/drivers/radeon/radeon_vce.h| 7 + src

Re: [Mesa-dev] [PATCH v2 2/2] radeon/vce: implement video usability information support

; + if (enc-use_vui) + enc-vui = vui; We should set the callback independent of whether or not it is used, after all that is just a vtbl. With that fixed this patch and #1 in this series is Reviewed-by: Christian König christian.koe...@amd.com. Regards, Christian

[Mesa-dev] [PATCH] gallium/vl: partially revert Use util_cpu_to_le{16, 32} in many more places.

From: Christian König christian.koe...@amd.com The data in memory is in big endian format and needs to be converted into CPU byte order. So the patch actually reversed what needs to be done. Signed-off-by: Christian König christian.koe...@amd.com --- src/gallium/auxiliary/vl/vl_vlc.h | 6

Re: [Mesa-dev] [PATCH 03/15] st/vdpau: Avoid constness cast warnings.

Reviewed-by: Christian König christian.koe...@amd.com On 20.03.2015 14:59, Jose Fonseca wrote: Fixes MSVC warning C4090: '=' : different 'const' qualifiers --- src/mesa/state_tracker/st_vdpau.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/state_tracker

Re: [Mesa-dev] [PATCH 1/6] mesa: implement GL_AMD_pinned_memory

Sorry for forgetting to bump the driver version, been to busy lately. Patches are Reviewed-by: Christian König christian.koe...@amd.com Regards, Christian. Am 11.02.2015 um 21:18 schrieb Marek Olšák: From: Marek Olšák marek.ol...@amd.com It's not possible to query the current buffer binding

Re: [Mesa-dev] [PATCH] winsys/radeon: add user pointer support

bumped probably. Marek On Tue, Feb 10, 2015 at 9:35 AM, Christian König deathsim...@vodafone.de wrote: Am 10.02.2015 um 03:41 schrieb Alex Deucher: On Mon, Feb 9, 2015 at 7:29 PM, Marek Olšák mar...@gmail.com wrote: Hi Christian, What hardware is this supported on? SI and later? Or even r600? r300

Re: [Mesa-dev] [PATCH] winsys/radeon: add user pointer support

, Christian. Alex Thanks, Marek On Thu, Feb 5, 2015 at 6:34 PM, Christian König deathsim...@vodafone.de wrote: From: Christian König christian.koe...@amd.com Signed-off-by: Christian König christian.koe...@amd.com --- src/gallium/winsys/radeon/drm/radeon_drm_bo.c | 102

[Mesa-dev] [PATCH] winsys/radeon: add user pointer support

From: Christian König christian.koe...@amd.com Signed-off-by: Christian König christian.koe...@amd.com --- src/gallium/winsys/radeon/drm/radeon_drm_bo.c | 102 ++ src/gallium/winsys/radeon/drm/radeon_winsys.h | 11 +++ 2 files changed, 113 insertions(+) diff --git a/src

Re: [Mesa-dev] [PATCH] radeonsi: Enable VGPR spilling for all shader types v3

In general I don't think that modifying shader code with the GPU is such a good idea. We already had quite a number of occasions where the GPU accidentally corrupted the shader data which usually leads to lockups. Because of this I already wanted to suggest that everything that the GPU

Re: [Mesa-dev] [PATCH] auxiliary/vl: move most sources back into the aux library

Am 20.12.2014 um 12:34 schrieb Emil Velikov: On 19/12/14 14:14, Christian König wrote: Am 19.12.2014 um 15:04 schrieb Emil Velikov: Due to the current implementation of the gl-vdpau interop, we depend on the dri module having a working set of util VL functions. Otherwise we will end up calling

Re: [Mesa-dev] [PATCH] auxiliary/vl: move most sources back into the aux library

, Christian. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=86837 Cc: Andy Furniss adf.li...@gmail.com Cc: Kertesz Laszlo laszlo.kert...@gmail.com Cc: Christian König christian.koe...@amd.com Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- src/gallium/auxiliary/Android.mk

Re: [Mesa-dev] [PATCH 1/1] st/xvmc: Fix compiler warnings

Am 02.12.2014 um 21:14 schrieb Jan Vesely: Mostly signed/unsigned comparison Signed-off-by: Jan Vesely jan.ves...@rutgers.edu Reviewed-by: Christian König christian.koe...@amd.com Feel free to commit this patch or if you don't have commit access leave me a note and I can commit

Re: [Mesa-dev] [PATCH 1/1] st/xvmc: Fix compiler warnings

Am 03.12.2014 um 16:31 schrieb Jan Vesely: On Wed, 2014-12-03 at 11:15 +0100, Christian König wrote: Am 02.12.2014 um 21:14 schrieb Jan Vesely: Mostly signed/unsigned comparison Signed-off-by: Jan Vesely jan.ves...@rutgers.edu Reviewed-by: Christian König christian.koe...@amd.com Feel free

Re: [Mesa-dev] [PATCH] Revert configure: ask vdpau.pc for the default location of the vdpau drivers

Am 07.10.2014 um 15:19 schrieb Ilia Mirkin: On Tue, Oct 7, 2014 at 9:13 AM, Christian König deathsim...@vodafone.de wrote: Am 07.10.2014 um 15:07 schrieb Ilia Mirkin: On Tue, Oct 7, 2014 at 9:04 AM, Christian König deathsim...@vodafone.de wrote: Am 07.10.2014 um 03:11 schrieb Ilia Mirkin

[Mesa-dev] [PATCH] st/va: refactored handleVASliceDataBufferType v2

From: Michael Varga michael.va...@amd.com This patch cleans the function handleVASliceDataBufferType() for better readability. v2 (chk): minor commit message changes Signed-off-by: Michael Varga michael.va...@amd.com Signed-off-by: Christian König christian.koe...@amd.com --- src/gallium

<    2   3   4   5   6   7   8   9   10   11   >