"Juan A. Suarez Romero" writes:
> On Thu, 2018-09-20 at 16:53 -0700, Eric Anholt wrote:
>> "Juan A. Suarez Romero" writes:
>>
>> > On Tue, 2018-09-04 at 08:19 -0700, Eric Anholt wrote:
>> > > "Juan A. Suarez Romero" writes
"Juan A. Suarez Romero" writes:
> On Tue, 2018-09-04 at 08:19 -0700, Eric Anholt wrote:
>> "Juan A. Suarez Romero" writes:
>>
>> > Use scheduled pipelines to update both the base and the LLVM images.
>> >
>> > This way
This means that TTN shaders more closely resemble GTN shaders: they have
inputs and outputs as variable derefs, with the variables having their
.driver_location already set up for you.
This will be useful for v3d to do input variable DCE in NIR, which we
can't do when the TTN shaders never have a
In TGSI we have a vec4 of which only .z is used, but for NIR we should be
using a float the same as other NIR IR. We were already moving TGSI's .z
to the .x channel.
---
src/gallium/auxiliary/nir/tgsi_to_nir.c | 1 +
1 file changed, 1 insertion(+)
diff --git
Marek Olšák writes:
> From: Marek Olšák
Could you please work on providing explanatory text in your commit
messages? Something like:
This fixes the default value of GL_SUBPIXEL_BITS, while leaving
GL_VIEWPORT_SUBPIXEL_BITS in place.
Maybe including the test name that motivated the fix.
Dylan Baker writes:
> and _mesa_bitcount_64 with util_bitcount_64. This fixes a build problem
> in nir for platforms that don't have popcount or popcountll, such as
> 32bit msvc.
>
> v2: - Fix additional uses of _mesa_bitcount added after this was
> originally writt
bdrm
> dependency() needs to be explicitly required if vc4 is being built.
>
> Fixes: 4fc0ebdff55419965919e "broadcom/vc4: Bump libdrm requirement"
> Cc: Eric Anholt
> Signed-off-by: Eric Engestrom
> ---
> meson.build | 2 +-
> 1 file changed, 1 insertion(+
Emil Velikov writes:
> Hi Eric,
>
> On 24 August 2018 at 14:11, Emil Velikov wrote:
>> From: Emil Velikov
>>
>> As the comment above globalDriverAPI (in dri_util.c) says, if the loader
>> is unaware of createNewScreen2 there is a race condition.
>>
>> In which globalDriverAPI, will be set in
This is the minimum value for GLES2, and 0 certainly wouldn't be valid.
Fixes dEQP-GLES2.functional.state_query.integers.subpixel_bits_getfloat
and friends.
---
src/gallium/auxiliary/util/u_screen.c | 4
1 file changed, 4 insertions(+)
diff --git a/src/gallium/auxiliary/util/u_screen.c
The argument has never been used since the function was added.
---
src/loader/loader_dri3_helper.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/src/loader/loader_dri3_helper.c b/src/loader/loader_dri3_helper.c
index 91bad86afd84..b62521485837 100644
---
The CTS requires a 565-no-depth-no-stencil config for ES 3.0, but at depth
24 of X11 we wouldn't do so. We can satisfy that bad requirement using a
pbuffer-only visual with whatever other buffers the driver happens to have
given us.
---
Anyone who's done CTS runs have opinions on this one? It
gainst in git.
Still, this seems like a necessary addition for the non-personal-repo
case for now.
Acked-by: Eric Anholt
signature.asc
Description: PGP signature
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
support for templating, and the
> support for mounting external directories during the image building.
> This help to use tools like ccache to improve the build speed.
>
> v2:
> - Review dependencies (Eric Anholt)
> - Install libdrm in base image with Meson (Eric Anholt)
> - Do
"Juan A. Suarez Romero" writes:
> Use scheduled pipelines to update both the base and the LLVM images.
>
> This way allows to have an updated version of the base images even when
> the respect Rockerfiles keep the same.
I'm curious: does the scheduled build end up only updating the image
used
takes to make it build for now
gets:
Acked-by: Eric Anholt
signature.asc
Description: PGP signature
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Ian Romanick writes:
> From: Ian Romanick
>
> For some reason, if I did not move the regular lowering to late
> optimizations, the new lowering would never trigger. This also means
> that the fsub lowering had to be added to late optimizations, and this
> requires "intel/compiler: Repeat
One of the pains of implementing a gallium driver is filling in a million
pipe caps you don't know about yet when you're just starting out. One of
the pains of working on gallium is copy-and-pasting your new PIPE_CAP into
each driver. We can fix both of these by having each driver call into the
Now that we have the util function for the default values, we can get rid
of the boilerplate.
v2: drop GLSL level in favor of defaults.
---
src/gallium/auxiliary/util/u_screen.c | 6 +-
src/gallium/drivers/vc4/vc4_screen.c | 175 --
2 files changed, 1 insertion(+), 180
Now that we have the util function for the default values, we can get rid
of the boilerplate.
Cc: Rob Clark
---
.../drivers/freedreno/freedreno_screen.c | 103 +-
1 file changed, 2 insertions(+), 101 deletions(-)
diff --git
Now that we have the util function for the default values, we can get rid
of the boilerplate.
---
src/gallium/drivers/v3d/v3d_screen.c | 147 ---
1 file changed, 147 deletions(-)
diff --git a/src/gallium/drivers/v3d/v3d_screen.c
b/src/gallium/drivers/v3d/v3d_screen.c
"Juan A. Suarez Romero" writes:
> On Mon, 2018-08-20 at 21:32 +0100, Eric Engestrom wrote:
>> On Monday, 2018-08-20 14:23:28 +, Juan A. Suarez Romero wrote:
>> > This fixes `make distcheck`.
>> >
>> > Fixes: 471f708ed6 ("git_sha1: simplify logic")
>> > CC: Eric Engestrom
>> > ---
>> >
Kenneth Graunke writes:
> This will be used by u_transfer_helper.c shortly, in order to split
> packed depth-stencil into separate resources.
> ---
> src/gallium/auxiliary/util/u_format.h | 21 +
> 1 file changed, 21 insertions(+)
>
> diff --git
gt; machine that uses that format.)
It won't be directly usable for V3D, because we only want separate
stencil z24s8 in the MSAA case. These kinds of complications are why I
wanted a helper library, not a midlayer.
However, this does look good and should bring your project closer to
completi
Kenneth Graunke writes:
> This new function takes separate Z24 depth and S8 stencil sources,
> and packs them into a single combined Z24S8 buffer.
> ---
> src/gallium/auxiliary/util/u_format_zs.c | 20
> src/gallium/auxiliary/util/u_format_zs.h | 2 ++
> 2 files changed,
One of the pains of implementing a gallium driver is filling in a million
pipe caps you don't know about yet when you're just starting out. One of
the pains of working on gallium is copy-and-pasting your new PIPE_CAP into
each driver. We can fix both of these by having each driver call into the
Now that we have the util function for the default values, we can get rid
of the boilerplate.
---
.../drivers/freedreno/freedreno_screen.c | 103 +-
1 file changed, 2 insertions(+), 101 deletions(-)
diff --git a/src/gallium/drivers/freedreno/freedreno_screen.c
Now that we have the util function for the default values, we can get rid
of the boilerplate.
---
src/gallium/drivers/v3d/v3d_screen.c | 147 ---
1 file changed, 147 deletions(-)
diff --git a/src/gallium/drivers/v3d/v3d_screen.c
b/src/gallium/drivers/v3d/v3d_screen.c
I've been putting off some PIPE_CAPs I've needed to write because each
one is such a pain to do, so I went and implemented the thing I've
been dreaming of: a single place to define a new pipe cap's default
state.
Eric Anholt (4):
gallium: Add a helper for implementing PIPE_CAP_* default values
Now that we have the util function for the default values, we can get rid
of the boilerplate.
---
src/gallium/auxiliary/util/u_screen.c | 6 +-
src/gallium/drivers/vc4/vc4_screen.c | 171 --
2 files changed, 1 insertion(+), 176 deletions(-)
diff --git
Rhys Kidd writes:
> Signed-off-by: Rhys Kidd
Does this actually do anything for us, though? Shouldn't we be hooking
up our perf_debug() calls to it?
signature.asc
Description: PGP signature
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
"Juan A. Suarez Romero" writes:
> Creates different Docker images containing Mesa built with different
> tools (autotools, meson, scons, etc).
>
> The build is done in 3 levels: the first level creates a base image
> with all the requirements to build Mesa.
>
> The second level (based of the
This is basically copied from the DRI2 destroy path. Without this,
Raspberry Pi would quickly run out of CMA during the EGL tests in the CTS
due to all the pixmaps laying around.
Fixes: f35198badeb9 ("egl/x11: Implement dri3 support with loader's dri3
helper")
---
Dylan Baker writes:
> ---
> meson.build | 129
> 1 file changed, 79 insertions(+), 50 deletions(-)
>
> diff --git a/meson.build b/meson.build
> index 25de31bfabd..4350e1af810 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -775,69 +775,96
Dylan Baker writes:
> ---
> src/gallium/meson.build | 4 ++-
> src/gallium/targets/graw-gdi/meson.build | 36
> 2 files changed, 39 insertions(+), 1 deletion(-)
> create mode 100644 src/gallium/targets/graw-gdi/meson.build
>
> diff --git
Dylan Baker writes:
> ---
> src/gallium/meson.build | 1 +
> src/gallium/targets/libgl-gdi/meson.build | 44 +++
> 2 files changed, 45 insertions(+)
> create mode 100644 src/gallium/targets/libgl-gdi/meson.build
>
> diff --git a/src/gallium/meson.build
Dylan Baker writes:
> ---
> src/gallium/meson.build| 3 ++
> src/gallium/state_trackers/wgl/meson.build | 50 ++
> 2 files changed, 53 insertions(+)
> create mode 100644 src/gallium/state_trackers/wgl/meson.build
>
> diff --git a/src/gallium/meson.build
Dylan Baker writes:
> ---
> src/mesa/meson.build | 12 ++--
> 1 file changed, 10 insertions(+), 2 deletions(-)
>
> diff --git a/src/mesa/meson.build b/src/mesa/meson.build
> index 29633691ee7..fa086466443 100644
> --- a/src/mesa/meson.build
> +++ b/src/mesa/meson.build
> @@ -728,11
Dylan Baker writes:
> So that it can be implicitly disabled on windows, where it doesn't
> compile.
I don't see how this option successfully controls the shader cache being
built. Also the "elif with_dri_i965 and get_option('shader-cache')"
looks like it needs to get updated for the trillian,
Dylan Baker writes:
> ---
6-12 have my r-b.
signature.asc
Description: PGP signature
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Dylan Baker writes:
> By including the proper headers for getpid and for mkdir.
This comment doesn't seem to match what the patch is doing, and I see
these files as already being in the meson.build. Rebase fail?
Patches 1-4 have my r-b.
signature.asc
Description: PGP signature
entry it sounds like it's
already fixed in:
commit 833c4046007f22ce1da0e1c2b89e8f1892f8d38e
Author: Eric Anholt
Date: Fri Mar 30 16:04:34 2018 -0700
nir: Look into uniform structs for samplers when counting num_textures.
signature.asc
Description
Marek Olšák writes:
> On Thu, Aug 2, 2018 at 1:54 PM, Eric Anholt wrote:
>> Marek Olšák writes:
>>
>>> From: Marek Olšák
>>>
>>> v2: need to do MAX{start+count} instead of MAX{count}
>>> added piglit tests
>>> v3: use m
Marek Olšák writes:
> From: Marek Olšák
>
> v2: need to do MAX{start+count} instead of MAX{count}
> added piglit tests
> v3: use malloc
> ---
> src/gallium/auxiliary/util/u_vbuf.c | 204
> 1 file changed, 180 insertions(+), 24 deletions(-)
>
> diff --git
Brian Paul writes:
> Previously, I added a switch case for GL 2.1 (ed7a0770b881791dd697f3).
> I don't know of any driver which only supports GL 2.0, but adding
> this switch case avoids a failure if the app queries
> GL_SHADING_LANGUAGE_VERSION.
Reviewed-by: Eric Anholt
s
Marek Olšák writes:
> On Fri, Jul 27, 2018 at 5:46 PM, Marek Olšák wrote:
>> On Fri, Jul 27, 2018 at 5:08 PM, Eric Anholt wrote:
>>> Marek Olšák writes:
>>>
>>>> From: Marek Olšák
>>>>
>>>> v2: need to do MAX{start+count} inste
This is just asking for tests to get confused about the HW supporting
atomics in this shader stage or not, such as
dEQP-GLES31.functional.shaders.opaque_type_indexing.atomic_counter.const_expression_vertex.
---
src/mesa/state_tracker/st_extensions.c | 3 ++-
1 file changed, 2 insertions(+), 1
;
> Fixes: e92959c4e0 ("v3d: Pass the whole clif_dump structure to
> v3d_print_group().")
> CC: Eric Anholt
I tried to come up with something yesterday, but automake was already
busted for me on both x86_64 simulator and ARM cross compiles, so I
didn't get far. While I can't te
ties(), and set the default
> for glXChooseFBConfig() in init_fbconfig_for_chooser() to GLX_DONT_CARE.
Reviewed-by: Eric Anholt
signature.asc
Description: PGP signature
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Tapani Pälli writes:
> Hi;
>
>
> On 07/25/2018 08:36 AM, Tapani Pälli wrote:
>>
>>
>> On 07/24/2018 10:31 PM, Eric Anholt wrote:
>>> Tapani Pälli writes:
>>>
>>>> These bits were missing, found when extending the Piglit test.
>&g
Marek Olšák writes:
> From: Marek Olšák
>
> v2: need to do MAX{start+count} instead of MAX{count}
> added piglit tests
> ---
> src/gallium/auxiliary/util/u_vbuf.c | 199
> 1 file changed, 175 insertions(+), 24 deletions(-)
>
> diff --git
Marek Olšák writes:
> From: Marek Olšák
>
> This will be used by indirect multidraws.
>
> v2: clean up the function further, change return types to unsigned
Reviewed-by: Eric Anholt
signature.asc
Description: PGP signature
___
m
w_bug.cgi?id=107117
> Fixes: 069fdd5 ("egl/x11: Support DRI3 v1.1")
> Signed-off-by: Olivier Fourdan
Looks great!
Reviewed-by: Eric Anholt
signature.asc
Description: PGP signature
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
Olivier Fourdan writes:
> get_supported_modifiers() expects a window as drawable, passing a pixmap
> will fail as the Xserver will fail to match the id to a window.
>
> That leads to dri3_alloc_render_buffer() to return NULL and breaks
> rendering when using GLX_DOUBLEBUFFER.
>
> Check if
Marek Olšák writes:
> From: Marek Olšák
Reviewed-by: Eric Anholt
signature.asc
Description: PGP signature
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Tapani Pälli writes:
> These bits were missing, found when extending the Piglit test.
>
> Fixes: 7f467d4f73 "mesa: GL_EXT_texture_norm16 extension plumbing"
> Signed-off-by: Tapani Pälli
Aren't you missing the RGB16 and R/RG/RGB/RGBA16_SNORM cases here? They
aren't required for rendering, but
Karol Herbst writes:
> On Mon, Jul 23, 2018 at 7:02 PM, Eric Anholt wrote:
>> Karol Herbst writes:
>>
>>> this allows to replace some nir_load_system_value calls with the specific
>>> system value constructor
>>>
>>> Reviewed-
Eric Anholt writes:
> This is controlled by a new nir_shader_compiler_options flag, and fixes
> dEQP-GLES3.functional.shaders.builtin_variable.pointcoord on V3D.
> ---
Ken, Rob, any chance you could take a quick look at this? I think this
is the last change I need in Mesa for GLES2 co
es[0] was used, but it looks like system
values can only have one index. Maybe assert(len(opcode.indices) <= 1)?
Other than that, these are:
Reviewed-by: Eric Anholt
signature.asc
Description: PGP signature
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Timothy Arceri writes:
>> On 19.07.18 11:47, Timothy Arceri wrote:
>>> On 19/07/18 08:31, Eric Anholt wrote:
>>>> Danylo Piliaiev writes:
>>>>
>>>>> After optimization passes and many trasfromations most of memory
>>>>
>&g
Harish Krupo writes:
> Eric Anholt writes:
>
>> Harish Krupo writes:
>>
>>> Eric Anholt writes:
>>>
>>>> Harish Krupo writes:
>>>>
>>>>> Hi Eric,
>>>>>
>>>>> Eric Anholt writes:
Ian Romanick writes:
> [ Unknown signature status ]
> On 07/18/2018 03:03 PM, Eric Anholt wrote:
>> Ian Romanick writes:
>>
>>> On 07/16/2018 02:46 PM, Eric Anholt wrote:
>>>> Thi
Danylo Piliaiev writes:
> After optimization passes and many trasfromations most of memory
"transformations"
> NIR holds is a garbage which was being freed only after shader deletion.
"is garbage"
> Freeing it at the end of linking will save memory which would be useful
> in case there are a
Ian Romanick writes:
> On 07/16/2018 02:46 PM, Eric Anholt wrote:
>> This fixes dEQP case:
>>
>> dEQP-GLES2.functional.shaders.scoping.valid.local_variable_hides_function_parameter_fragment
>
> Are we sure that test is correct? I'm sure I already know the answer,
Emil Velikov writes:
> From: Emil Velikov
>
> With commit c6c0f947142, back in 2006 Brian removed the
> _glapi_check_multithread() call from core mesa - _mesa_make_current.
>
> He moved it to a DRI loader (type of) decision - with equivalents in
> the monolithic OSMesa and libGL-Xlib.
>
> Some
The EGL CTS expects that you can make images from all sorts of things,
including things like z16 and s8, which we don't have DRM fourccs for.
Just return an error when trying to export one of those.
---
src/egl/drivers/dri2/egl_dri2.c | 27 +++
1 file changed, 27
Nothing in EGL_KHR_gl_image.txt seems to let us deny creation based on
formats, and doing so causes many failures in
dEQP-EGL.functional.image.api.*
The NONE value we were protecting from only gets looked at in the
__DRI_IMAGE_ATTRIB_FORMAT and __DRI_IMAGE_ATTRIB_FOURCC queries, which are
used
Rob Clark writes:
> From: Eric Anholt
>
> Reviewed-by: Rob Clark
> ---
> Not sure if this ever got sent to list.. but this extension is meant to
> be exposed in GLES as well as GL
Did the trivial whitespace fix and pushed.
signature.asc
Descript
hat the
> results match as we don't have all the starting information at both
> points. So leave the assert out and hope CI comes soon to save us all.
>
> v2: * Let R10G10B10A2_UINT fall back to GL_RGBA_INTEGER (Eric Anholt)
> * Assert with _mesa_format_matches_format_and_type (Eric A
Eric Anholt writes:
> [ Unknown signature status ]
> Marek Olšák writes:
>
>> From: Marek Olšák
>>
>> This will be used by indirect multidraws.
>> ---
>> src/gallium/auxiliary/util/u_vbuf.c | 54 +
>> 1 file changed,
ew_info.start = data[2];
> - pipe_buffer_unmap(pipe, transfer);
> - new_info.indirect = NULL;
> -
> - if (!new_info.count)
> + if (!draw_count)
> return;
> +
> + unsigned data_size = (draw_count - 1) * indirect->stride +
> +
Marek Olšák writes:
> From: Marek Olšák
>
> This will be used by indirect multidraws.
> ---
> src/gallium/auxiliary/util/u_vbuf.c | 54 +
> 1 file changed, 31 insertions(+), 23 deletions(-)
>
> diff --git a/src/gallium/auxiliary/util/u_vbuf.c
>
Harish Krupo writes:
> Eric Anholt writes:
>
>> Harish Krupo writes:
>>
>>> Hi Eric,
>>>
>>> Eric Anholt writes:
>>>
>>>> Harish Krupo writes:
>>>>
>>>>> The intension of the KHR_partial_upda
Ilia Mirkin writes:
> On Mon, Jul 16, 2018 at 7:51 PM, Eric Anholt wrote:
>> Ilia Mirkin writes:
>>
>>> Perhaps use state->es_shader instead of is_version(0, 100)? [Just a
>>> drive-by comment, not a real review, sorry]
>>
>> That doesn't respec
Ilia Mirkin writes:
> Perhaps use state->es_shader instead of is_version(0, 100)? [Just a
> drive-by comment, not a real review, sorry]
That doesn't respect the version overrides and such that is_version
handles.
signature.asc
Description: PGP signature
Jason Ekstrand writes:
> Yes please! Assuming it builds (i.e., those are actually in drm_fourcc.h),
It does. The delta to upstream is at:
https://patchwork.freedesktop.org/patch/236876/
signature.asc
Description: PGP signature
___
mesa-dev
We should only use a #define locally once it's been upstreamed, and at
that point you should just update our drm_fourcc.h.
---
src/egl/Android.mk | 1 +
src/egl/Makefile.am | 1 +
src/egl/SConscript | 1 +
This fixes dEQP case:
dEQP-GLES2.functional.shaders.scoping.valid.local_variable_hides_function_parameter_fragment
without breaking
dEQP-GLES3.functional.shaders.scoping.invalid.local_variable_hides_function_parameter_fragment
---
src/compiler/glsl/ast_to_hir.cpp | 9 +
1 file changed,
Jason Ekstrand writes:
> This makes the arguments match the (thing, container) pattern used in
> other nir_foreach macros and also renames it to make that a bit more
> clear.
Yay, consistency!
Reviewed-by: Eric Anholt
signature.asc
Description: PGP
s kind of code
transformation well. I'd love to see some actual performance numbers on
affected applications.
That said, lower_if_to_cond_assign() was already doing this, and I'm
assuming these shader-db stats are just from
with-glsl-optimization-disabled to with-nir-patch. So, while we should
probably in
Jason Ekstrand writes:
> Eric, I can't test this patch because it only affects your driver.
I tried a piglit run last night, and all the sRGB lowering looks like it
crashes now due to fdivs in the NIR.
signature.asc
Description: PGP signature
___
Caio Marcelo de Oliveira Filho writes:
> And the corresponding test case.
Reviewed-by: Eric Anholt
signature.asc
Description: PGP signature
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/m
Roland Scheidegger writes:
> Am 12.07.2018 um 00:05 schrieb Eric Anholt:
>> For V3D, the HW will interpolate slightly differently along the shared
>> edge of the trifan. The conformance tests manage to catch this in the
>> nearest_consistency_* group. To get interpolat
---
src/intel/tools/intel_dump_gpu.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/intel/tools/intel_dump_gpu.c b/src/intel/tools/intel_dump_gpu.c
index 1201fa35ae0c..766ba662d910 100644
--- a/src/intel/tools/intel_dump_gpu.c
+++ b/src/intel/tools/intel_dump_gpu.c
@@ -728,6 +728,8 @@
These are not unit tests, as they rely on the host's XVMC and some user
configuration. Switch them over to being general installed tools, to fix
unit testing.
Fixes: 22a817af8a89 ("meson: build gallium xvmc state tracker")
---
meson.build | 2 +-
Harish Krupo writes:
> Hi Eric,
>
> Eric Anholt writes:
>
>> Harish Krupo writes:
>>
>>> The intension of the KHR_partial_update was not to send the damage back
>>> to the platform but to send the damage to the driver to ensure that the
>>&g
These helpers have been unused, and were definitely not useful since
330d0607ed60 ("gallium: remove pipe_index_buffer and set_index_buffer")
made it so that they never had an index buffer passed in.
For an upcoming u_blitter change to use these helpers, I have just 6 bytes
of index data, so pass
For V3D, the HW will interpolate slightly differently along the shared
edge of the trifan. The conformance tests manage to catch this in the
nearest_consistency_* group. To get interpolation to match, we need the
last vertex of the triangle to be shared.
I first tried implementing
Harish Krupo writes:
> The intension of the KHR_partial_update was not to send the damage back
> to the platform but to send the damage to the driver to ensure that the
> following rendering could be restricted to those regions.
> This patch removes the set_damage_region from the egl_dri vtbl
; + acp_entry *rhs_entry = pull_acp(rhs);
> + _mesa_set_add(rhs_entry->dsts, lhs);
> + }
> + }
Though I think the logic would be simpler if we skip the checking that
we haven't added to the ACP and just _mesa_set_add() no matter what.
Optional, though. Either way:
Reviewed-by: Eric Anholt
signature.asc
Description: PGP signature
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
break;
> +}
> + }
>
> - /* rhs hash, hash of rhs -> acp_entry pointers to lhs lists */
> - ht_entry = _mesa_hash_table_search(rhs_ht, rhs);
> - if (ht_entry) {
> - exec_list *rhs_list = (exec_list *) ht_entry->data;
> - rhs_list-&
t; };
>
> +class copy_propagation_state {
> +public:
> + DECLARE_RZALLOC_CXX_OPERATORS(copy_propagation_state);
> +
> + copy_propagation_state(void *mem_ctx, void *lin_ctx)
> + {
> + /* Use 'this' as context for the tables, no explicit destruction
> + * neede
Caio Marcelo de Oliveira Filho writes:
> v2: Add unit test. (Eric Anholt)
5-7 are:
Reviewed-by: Eric Anholt
signature.asc
Description: PGP signature
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mail
These are connected as unit tests, so no breaking the build just because
the host can't do it. If you wanted to test on a non-supporting host,
you'd need some sort of mocking.
---
src/gallium/state_trackers/xvmc/tests/test_blocks.c | 2 +-
src/gallium/state_trackers/xvmc/tests/test_context.c
Caio Marcelo de Oliveira Filho writes:
> On Thu, Jul 05, 2018 at 01:56:11PM -0700, Eric Anholt wrote:
>> Caio Marcelo de Oliveira Filho writes:
>>
>> > ---
>>
>> This one should be trivial to unit test, with a present and non-present
>> key.
>
>
Eric Engestrom writes:
> Unused since b174a1ae720cb404738c "egl: Simplify the "driver" interface".
>
> Signed-off-by: Eric Engestrom
Reviewed-by: Eric Anholt
signature.asc
Description: PGP signature
___
m
We just never set the value that was returned for MSAA mappings (directly
reading back an MSAA framebuffer). Since we're handing back ss_map, it
should be ss_map's stride from our nested transfer.
Fixes piglit /home/anholt/src/piglit/bin/fbo-depthstencil -samples=4
casees.
---
We created a temporary with box->{width,height} and then tried to map
width,height from a nonzero offset when we meant to just map the whole
temporary.
Fixes segfaults in V3D in dEQP-GLES3.functional.prerequisite.read_pixels
with --deqp-egl-config-name=rgbad24s8ms4 and also piglit's
in an
> exec_list anymore.
>
> Remove the 'var' from kill_entry since it is now redundant with the
> key of the hash table.
>
> Suggested by Eric Anholt.
These are both:
Reviewed-by: Eric Anholt
signature.asc
Description: PGP signature
___
Eric Anholt writes:
> [ Unknown signature status ]
> zhaowei yuan writes:
>
>> "sampler2DRect" and "sampler2DRectShadow" are specified as
>> reserved from GLSL 1.1 and GLSL ES 1.0
>>
>> Signed-off-by: zhaowei yuan
>> Bugzilla: https
This is controlled by a new nir_shader_compiler_options flag, and fixes
dEQP-GLES3.functional.shaders.builtin_variable.pointcoord on V3D.
---
src/broadcom/compiler/nir_to_vir.c | 1 +
src/compiler/nir/nir.h | 3 ++
src/compiler/nir/nir_lower_wpos_ytransform.c |
201 - 300 of 5366 matches
Mail list logo
