[Mesa-dev] [PATCH] st: Don't try to finalize the texture in st_render_texture().

We can't necessarily finalize the texture at this point if we're rendering to a texture image whose format is different from the baselevel's format. This was introduced as a fix for fbo-incomplete-texture-03 in de414f491526610bb260c73805c81ba413388e20, but the later fix for vmware on that testcase

[Mesa-dev] [PATCH 2/2] gallium/u_vbuf: Protect against overflow with large instance divisors.

GTF-GLES3.gtf.GL3Tests.instanced_arrays.instanced_arrays_divisor uses -1 as a divisor, so we would overflow to count=0 and upload no data, triggering the assert below. We want to upload 1 element in this case, fixing the test on VC5. v2: Use some more obvious logic, and explain why we don't use

[Mesa-dev] [PATCH 1/2] st: Allow accelerated CopyTexImage from RGBA to RGB.

There's nothing to worry about here -- the A channel just gets dropped by the blit. This avoids a segfault in the fallback path when copying from a RGBA16_SINT renderbuffer to a RGB16_SINT destination represented by an RGBA16_SINT texture (the fallback path tries to get/fetch to float buffers,

Re: [Mesa-dev] [PATCH 1/3] st/mesa: s/unsigned/enum pipe_shader_type/

Brian Paul <bri...@vmware.com> writes: > --- > src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 6 -- > src/mesa/state_tracker/st_glsl_to_tgsi.h | 2 +- > 2 files changed, 5 insertions(+), 3 deletions(-) This series is: Reviewed-by: Eric Anholt <e...@anholt.net> s

Re: [Mesa-dev] [PATCH v2 7/7] broadcom/vc4: add path to nir_builder.h

"Juan A. Suarez Romero" <jasua...@igalia.com> writes: > As the other VC4 files do. Otherwise, it won't find nir_builder.h > > v2: add path in source code rather changing autotools (Emil) > > Reviewed-by: Emil Velikov <emil.veli...@collabora.com> Revi

Re: [Mesa-dev] [PATCH 1/7] tgsi: convert opcode macros to enums

Brian Paul <bri...@vmware.com> writes: > Enums are nicer in gdb. This series is: Reviewed-by: Eric Anholt <e...@anholt.net> signature.asc Description: PGP signature ___ mesa-dev mailing list mesa-dev@lists.freede

[Mesa-dev] [PATCH] st: Allow accelerated CopyTexImage from RGBA to RGB.

There's nothing to worry about here -- the A channel just gets dropped by the blit. This avoids a segfault in the fallback path when copying from a RGBA16_SINT renderbuffer to a RGB16_SINT destination represented by an RGBA16_SINT texture (the fallback path tries to get/fetch to float buffers,

[Mesa-dev] [PATCH] gallium/u_vbuf: Protect against overflow with large instance divisors.

GTF-GLES3.gtf.GL3Tests.instanced_arrays.instanced_arrays_divisor uses -1 as a divisor, so we would overflow to count=0 and upload no data, triggering the assert below. We want to upload 1 element in this case, fixing the test on VC5. --- src/gallium/auxiliary/util/u_vbuf.c | 7 ++- 1 file

Re: [Mesa-dev] [PATCH 1/2] nir: Initial implementation of a nir_instr_worklist

rklist. It uses u_vector to keep the overhead and memory > + * footprint at a minimum. > + * Trailing whitespace here. Other than that, this looks great. I particularly like that you've explained the choice of the implementation details in the comments here. With these little nits fixe

Re: [Mesa-dev] [PATCH 1/4] intel/blorp: Fix compiler warning about num_layers.

Lionel Landwerlin <lionel.g.landwer...@intel.com> writes: > On 13/03/18 17:38, Eric Anholt wrote: >> The compiler doesn't notice that the condition for num_layers to be >> undefined already defined it above (as our assert checked in a debug >> build). >> &

[Mesa-dev] [PATCH] intel/blorp: Fix compiler warning about num_layers.

The compiler doesn't notice that the condition for num_layers to be undefined already defined it above (as our assert checked in a debug build). v2: Move the pair of assignments to one outside of the block. Cc: Jason Ekstrand Cc: Lionel Landwerlin

Re: [Mesa-dev] [RFC] Mesa 17.3.x release problems and process improvements

Kenneth Graunke writes: > [ Unknown signature status ] > On Friday, March 9, 2018 12:12:28 PM PDT Mark Janes wrote: > [snip] >> I've been doing this for Intel. Developers are on the hook to fix their >> bugs, but you can't make them do it. They have many pressures on

[Mesa-dev] [PATCH 3/4] i965: Silence compiler warning about promoted_constants.

We only have a cfg != NULL if we went through one of the paths that set it, but my compiler doesn't figure that out. Cc: Jason Ekstrand Fixes: 6411defdcd6f ("intel/cs: Re-run final NIR optimizations for each SIMD size") --- src/intel/compiler/brw_fs.cpp | 2 +- 1 file

[Mesa-dev] [PATCH 4/4] anv: Silence warning about heap_size.

We only get VK_SUCCESS if it was initialized, but apparently my compiler doesn't track that far. Cc: Jason Ekstrand --- src/intel/vulkan/anv_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/vulkan/anv_device.c

[Mesa-dev] [PATCH 2/4] anv: Silence compiler warnings about uninitialized bind_offset.

This is a legitimate warning: if anv's blorp_alloc_binding_table() throws an error from anv_cmd_buffer_alloc_blorp_binding_table(), we silently continue to use this undefined value. The rest of this code doesn't seem very allocation-error-proof, though, either. Cc: Jason Ekstrand

[Mesa-dev] [PATCH 1/4] intel/blorp: Fix compiler warning about num_layers.

The compiler doesn't notice that the condition for num_layers to be undefined already defined it above (as our assert checked in a debug build). Cc: Jason Ekstrand --- src/mesa/drivers/dri/i965/brw_blorp.c | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [Mesa-dev] [PATCH 2/2] glsl: Use hash table cloning in copy propagation

_mesa_hash_table_insert(acp, entry->key, entry->data); > - } > + acp = _mesa_hash_table_clone(orig_acp, NULL); > + } else { > + acp = _mesa_hash_table_create(NULL, _mesa_hash_pointer, > + _mesa_key_pointer_equal);

[Mesa-dev] [PATCH RESEND] spirv: Silence compiler warning about undefined srcs[0]

v2: Use assume() at the srcs[] definition instead. Cc: Jason Ekstrand Cc: Ian Romanick Cc: Eric Engestrom --- src/compiler/spirv/spirv_to_nir.c | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [Mesa-dev] [PATCH 1/3] meson: Use system_has_kms_drm in default driver selection

Greg V writes: > --- I've pushed this patch with Dylan's and my review on it. signature.asc Description: PGP signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

Re: [Mesa-dev] [PATCH 04/56] anv/entrypoints: Generalize the string map a bit

Jason Ekstrand writes: > On Thu, Mar 8, 2018 at 8:45 AM, Dylan Baker wrote: > >> Quoting Jason Ekstrand (2018-03-07 20:22:51) >> > Yes, that is what happened. That said, wrote that patch in September and >> > you've had about 6 months to look at it.

Re: [Mesa-dev] [PATCH 3/3] meson: make GLX_USE_TLS optional

Greg V writes: > FreeBSD builds Mesa with --disable-glx-tls in autotools because: > https://github.com/dumbbell/test-tls-initial-exec > > Add the equivalent option to Meson. > --- > meson.build | 5 - > meson_options.txt | 6 ++ > 2 files changed, 10

Re: [Mesa-dev] [PATCH 1/2] meson: Allow building dri based EGL without GLX

Dylan Baker <dy...@pnwbakers.com> writes: > It should be possible to build EGL without GLX, but the meson build > currently doesn't allow that because it too tightly couples glx and dri. > This patch eases dri and glx apart, so that EGL without GLX can be > built. These are:

[Mesa-dev] [PATCH 1/2] gallium: Add a util_blitter path for using a custom VS and FS.

Like the r600 paths to use other custom states, we pass in a couple of parameters to customize the innards of the blitter. It's up to the caller to wrap other state necessary for its shaders (for example, constant buffers for the uniforms the shader uses). ---

[Mesa-dev] [PATCH 2/2] broadcom/vc4: Add an accelerated path to turn raster R8/RG88 into tiled.

Drawing a 1080p YV12 video stream generated by MMAL goes from 10.5 FPS to 36. --- src/gallium/drivers/vc4/vc4_blit.c| 200 ++ src/gallium/drivers/vc4/vc4_context.c | 7 ++ src/gallium/drivers/vc4/vc4_context.h | 4 + 3 files changed, 211 insertions(+) diff

Re: [Mesa-dev] [RFC PATCH] get_reviewer.pl: Delete

Rob Clark <robdcl...@gmail.com> writes: > On Wed, Feb 28, 2018 at 4:09 PM, Eric Anholt <e...@anholt.net> wrote: >> Matt Turner <matts...@gmail.com> writes: >> >>> I find this script *really* annoying. Getting Cc'd on a random sample of >>>

Re: [Mesa-dev] [PATCH 02/13] nir: add load_param

Rob Clark writes: > From: Karol Herbst > > OpenCL kernels have parameters (see pipe_grid_info::input), and so we > need a way to access them. > > Signed-off-by: Rob Clark > > --- > src/compiler/nir/nir_intrinsics.h | 2 ++ >

Re: [Mesa-dev] [RFC PATCH] get_reviewer.pl: Delete

tuation compared to maintainers needing to manage email filters. It's not consistent, so you need to indoctrinate new submitters (more barriers to entry!) and maintainers need to maintain their mail filters anyway. Reviewed-by: Eric Anholt <e...@anholt.net> sig

Re: [Mesa-dev] [PATCH] ttn: remove {varying_slot, frag_result}_to_tgsi_semantic helpers

Emil Velikov <emil.l.veli...@gmail.com> writes: > From: Emil Velikov <emil.veli...@collabora.com> > > The respective drivers have been updated and the helpers are no longer > needed. Reviewed-by: Eric Anholt <e...@anholt.net> signature.

[Mesa-dev] [PATCH] gbm: Fix the alpha masks in the GBM format table.

Once GBM started looking at the values of the alpha masks, ARGB/ABGR wouldn't match any more because we had both A and R in the low bits. Fixes: 2ed344645d65 ("gbm/dri: Add RGBA masks to GBM format table") --- src/gbm/backends/dri/gbm_dri.c | 4 ++-- 1 file changed, 2 insertions(+), 2

Re: [Mesa-dev] Allocator Nouveau driver, Mesa EXT_external_objects, and DRM metadata import interfaces

Kristian Høgsberg writes: > On Wed, Feb 21, 2018 at 4:00 PM Alex Deucher wrote: > >> On Wed, Feb 21, 2018 at 1:14 AM, Chad Versace > wrote: >> > On Thu 21 Dec 2017, Daniel Vetter wrote: >> >> On Thu, Dec 21, 2017 at 12:22

[Mesa-dev] [PATCH 09/17 v2] spirv: Silence compiler warning about undefined srcs[0]

v2: Use assume() at the srcs[] definition instead. Cc: Jason Ekstrand Cc: Ian Romanick Cc: Eric Engestrom --- src/compiler/spirv/spirv_to_nir.c | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [Mesa-dev] [PATCH 08/17] loader: Fix compiler warnings about truncating the PCI ID path.

Ian Romanick <i...@freedesktop.org> writes: > On 02/10/2018 08:33 AM, Eric Anholt wrote: >> My build was producing: >> >> ../src/loader/loader.c:121:67: warning: ‘%1u’ directive output may be >> truncated writing between 1 and 3 bytes into a region o

Re: [Mesa-dev] [PATCH 10/10] meson: build gallium unit tests

ommon, inc_gallium_drivers, > inc_gallium_winsys], > +link_with : [libgallium, libmesa_util, libtrace, libws_null], > +dependencies : [driver_swrast, dep_thread], > +install : false, > + ) > +endforeach This should probably be gated on with_gallium_softpipe (so drive

[Mesa-dev] [PATCH 17/17] glsl: Suppress sign-compare warning generated by flex 2.6.1.

I got the following warning: src/compiler/glsl/glsl_lexer.cpp:1521:18: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for ( n = 0; n < max_size && \ src/compiler/glsl/glsl_lexer.cpp:3448:3: note: in expansion of macro ‘YY_INPUT’ YY_INPUT(

[Mesa-dev] [PATCH 15/17] i965: Silence compiler warning about promoted_constants.

We only have a cfg != NULL if we went through one of the paths that set it, but my compiler doesn't figure that out. Cc: Jason Ekstrand Fixes: 6411defdcd6f ("intel/cs: Re-run final NIR optimizations for each SIMD size") --- src/intel/compiler/brw_fs.cpp | 2 +- 1 file

[Mesa-dev] [PATCH 16/17] anv: Silence warning about heap_size.

We only get VK_SUCCESS if it was initialized, but apparently my compiler doesn't track that far. Cc: Jason Ekstrand --- src/intel/vulkan/anv_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/vulkan/anv_device.c

[Mesa-dev] [PATCH 09/17] spirv: Silence compiler warning about undefined srcs[0]

It doesn't know that elems >= 1. Cc: Jason Ekstrand --- src/compiler/spirv/spirv_to_nir.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/spirv/spirv_to_nir.c b/src/compiler/spirv/spirv_to_nir.c index c6df764682ec..f86d45511df8 100644

[Mesa-dev] [PATCH 07/17] glsl: Silence warnings in the uniform initializer test about 16-bit types

They should probably get unit tests implemented, but this cleans up a bunch of warnings in my build for now. Fixes: 59f458cd8703 ("glsl: Add 16-bit types") Cc: Eduardo Lima Mitev --- src/compiler/glsl/tests/uniform_initializer_utils.cpp | 9 + 1 file changed, 9

[Mesa-dev] [PATCH 08/17] loader: Fix compiler warnings about truncating the PCI ID path.

My build was producing: ../src/loader/loader.c:121:67: warning: ‘%1u’ directive output may be truncated writing between 1 and 3 bytes into a region of size 2 [-Wformat-truncation=] and we can avoid this careful calculation by just using asprintf (as we do elsewhere in the file). Cc: Eric

[Mesa-dev] [PATCH 13/17] anv: Silence compiler warnings about uninitialized bind_offset.

This is a legitimate warning: if anv's blorp_alloc_binding_table() throws an error from anv_cmd_buffer_alloc_blorp_binding_table(), we silently continue to use this undefined value. The rest of this code doesn't seem very allocation-error-proof, though, either. Cc: Jason Ekstrand

[Mesa-dev] [PATCH 12/17] radv: Fix compiler warning about uninitialized 'set'

The compiler doesn't figure out that we only get result == VK_SUCCESS if set got initialized. Cc: Dave Airlie --- src/amd/vulkan/radv_descriptor_set.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_descriptor_set.c

[Mesa-dev] [PATCH 11/17] glsl/tests: Fix a compiler warning about signed/unsigned loop comparison.

Cc: Ian Romanick Fixes: d32956935edf ("glsl: Walk a list of ir_dereference_array to mark array elements as accessed") --- src/compiler/glsl/tests/array_refcount_test.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH 10/17] glsl/tests: Fix strict aliasing warning about int64/double.

Cc: Rhys Kidd Fixes: 4bf986274728 ("glsl/tests: Add UINT64 and INT64 types") --- .../glsl/tests/uniform_initializer_utils.cpp | 22 +++--- 1 file changed, 19 insertions(+), 3 deletions(-) diff --git

[Mesa-dev] [PATCH 14/17] i965: Fix compiler warning about write being undefined.

This looks like it should be protected by the assume() about nr_color_regions, but my compiler warns anyway. Cc: Matt Turner --- src/intel/compiler/brw_fs.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/compiler/brw_fs.cpp

[Mesa-dev] [PATCH 06/17] ac/nir: Fix compiler warning about uninitialized dw_addr.

Even switching the def's condition to be the same chip revision check as the use, the compiler doesn't figure it out. Just NULL-init it. Fixes: ec53e527421d ("ac/nir: Add ES output to LDS for GFX9.") Cc: Bas Nieuwenhuizen --- src/amd/common/ac_nir_to_llvm.c | 2 +- 1

[Mesa-dev] [PATCH 04/17] egl/gbm: Fix compiler warning about visual matching.

The compiler doesn't know that num_visuals > 0. Fixes: 37a8d907cc16 ("egl/gbm: Ensure EGLConfigs match GBM surface format") Cc: Daniel Stone --- src/egl/drivers/dri2/platform_drm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH 03/17] gallium/llvmpipe: Fix compiler warnings about ddx/ddy/ddmax.

My gcc doesn't figure out that dims >= 1 (seems reasonable), and doesn't notice that ddmax is used from the same no_rho_opt as its initialization. Cc: Roland Scheidegger --- src/gallium/auxiliary/gallivm/lp_bld_sample.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[Mesa-dev] [PATCH 01/17] r200: Remove dead rop table

Fixes: 0aaa27f29187 ("mesa: Pass the translated color logic op dd_function_table::LogicOpcode") Cc: Ian Romanick --- src/mesa/drivers/dri/r200/r200_state.c | 20 1 file changed, 20 deletions(-) diff --git a/src/mesa/drivers/dri/r200/r200_state.c

[Mesa-dev] [PATCH 05/17] intel/blorp: Fix compiler warning about num_layers.

The compiler doesn't notice that the condition for num_layers to be undefined already defined it above (as our assert checked in a debug build). Cc: Jason Ekstrand --- src/mesa/drivers/dri/i965/brw_blorp.c | 1 + 1 file changed, 1 insertion(+) diff --git

[Mesa-dev] [PATCH 02/17] gallium/util: Fix compiler warning about unknown pipe_filter_state.

Fixes: 6321b1bd4005 ("gallium/util: replace uint with tgsi enum types"). Cc: Brian Paul --- src/gallium/auxiliary/util/u_blit.h | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/gallium/auxiliary/util/u_blit.h b/src/gallium/auxiliary/util/u_blit.h

Re: [Mesa-dev] [PATCH 3/3] st/mesa: generate blend state according to the number of enabled color buffers

ion failure in translate_blend for: > > dEQP-GLES31.functional.draw_buffers_indexed.overwrite_common.common_advanced_blend_eq_buffer_blend_eq Reviewed-by: Eric Anholt <e...@anholt.net> signature.asc Description: PGP signature ___ mesa-dev mailing

Re: [Mesa-dev] [PATCH 2/3] st/mesa: don't translate blend state when color writes are disabled

Marek Olšák <mar...@gmail.com> writes: > From: Marek Olšák <marek.ol...@amd.com> Reviewed-by: Eric Anholt <e...@anholt.net> signature.asc Description: PGP signature ___ mesa-dev mailing list mesa-dev@lists.

Re: [Mesa-dev] [PATCH 1/3] st/mesa: don't translate blend state when it's disabled for a colorbuffer

- if (ctx->Extensions.ARB_draw_buffers_blend) > + if (ctx->Extensions.ARB_draw_buffers_blend) > j = i; > > + blend->rt[i].blend_enable = 1; maybe 'true' instead of '1'? Reviewed-by: Eric Anholt <e...@anholt.net> signature.asc Description: PGP signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 10.5/24] st/mesa: don't set sampler states for TBOs

Marek Olšák writes: > On Wed, Feb 7, 2018 at 1:33 AM, Ilia Mirkin wrote: >> This breaks nouveau (at least on nv50). Same deal as in commit >> 2b938a390c15a06be8cf706083890c822979508f which fixed a similar issue >> where this assumption that buffer doesn't

Re: [Mesa-dev] [PATCH] meson: Add build option for tools

t really should live in Mesa instead of an external tree. I like it. Reviewed-by: Eric Anholt <e...@anholt.net> signature.asc Description: PGP signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 1/5] mesa: change ctx->Color.ColorMask into a 32-bit bitmask

_COLORMASK_BIT(ctx->Color.ColorMask, 0, 2) ? > 0xf : 0, > + GET_COLORMASK_BIT(ctx->Color.ColorMask, 0, 3) ? > 0xf : 0, > + }; I think you meant 0xff instead of 0xf. With this and Roland's

Re: [Mesa-dev] [PATCH] mesa: enable ASTC format for CompressedTexSubImage3D

"Juan A. Suarez Romero" <jasua...@igalia.com> writes: > If extensions GL_KHR_texture_compression_astc_hdr or > GL_KHR_texture_compression_astc_sliced_3d are implemented then ASTC > format are supported in CompressedTex*Îmage3D. > > Fixes KHR-GLES2.texture_3d.* with

[Mesa-dev] [PATCH 2/3] gallium: Add a new A4B4G4R4 pipe format for Broadcom.

The VC5 HW puts A in the low bits and R in the high bits. We can't just swizzle in the shaders because the blending HW can't pick what channel A is in, so make a new format to match it. --- src/gallium/auxiliary/util/u_format.csv | 1 + src/gallium/drivers/svga/svga_format.c | 1 +

[Mesa-dev] [PATCH 1/3] mesa: Drop incorrect A4B4G4R4 _mesa_format_matches_format_and_type() cases.

swapBytes operates on bytes, not 4-bit channels, so you can't just take non-swapBytes cases and flip the REV flag. Avoids piglit texture-packed-formats regressions when enabling the ABGR format. Fixes: c5a5c9a7db89 ("mesa/formats: add new mesa formats and their pack/unpack functions.") ---

[Mesa-dev] [PATCH 3/3] broadcom/vc5: Switch our RGBA4 support to the new gallium format.

Fixes fbo-generatemipmap-formats, fbo-alphatest-formats, etc. tests for GL_RGBA4, GL_RGB4, GL_RGBA2, etc. --- src/gallium/drivers/vc5/v3dx_format_table.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/gallium/drivers/vc5/v3dx_format_table.c

Re: [Mesa-dev] [PATCH] gallium: remove pipe_blend_state::dither

Marek Olšák writes: > From: Marek Olšák > > very few drivers actually implement it. I disagree. If the hardware supports it and the API supports it, then we should support it, too. I've got a branch around somewhere for vc4 dithering. signature.asc

Re: [Mesa-dev] [PATCH] st/glsl_to_nir: add more nir opts to st_nir_opts()

ates these problems. Maybe some driver gaining NIR input would want vector math instead of scalar, but if all of our drivers agree at the moment, then let's put it here. Reviewed-by: Eric Anholt <e...@anholt.net> signature.asc Description: PGP signature _

Re: [Mesa-dev] [PATCH] mesa: fix glGet MAX_VERTEX_ATTRIB queries

Marek Olšák <mar...@gmail.com> writes: > From: Marek Olšák <marek.ol...@amd.com> > > Broken by f96a69f916aed40519e755d0460a83940a587 Reviewed-by: Eric Anholt <e...@anholt.net> signature.asc Description: PGP signature ___

Re: [Mesa-dev] [PATCH v2] mesa: enable ASTC/ETC1 compressed 3D textures

"Juan A. Suarez Romero" writes: > Enable these kind of 3D texture when proper extensions are available. > > Fixes KHR-GLES2.texture_3d.* with these textures. > > v2: add better clarification (Eric) > --- > src/mesa/main/teximage.c | 31 --- > 1

Re: [Mesa-dev] [PATCH 1/1] nir: Use a freelist in nir_opt_dce to avoid spamming ralloc

Thomas Helland writes: > Also, allocate worklist_elem in groups of 20, to reduce the burden of > allocation. Do not use rzalloc, as there is no need. This lets us drop > the number of calls to ralloc from aproximately 10% of all calls to > ralloc(130 000 calls),

Re: [Mesa-dev] [PATCH] mesa: enable ASTC/ETC1 compressed textures

"Juan A. Suarez Romero" writes: > Enable these kind of texture when proper extensions are available. In the subject, s/textures/3D textures/ since it's surprising to hear that they're not supported yet :) > Fixes KHR-GLES2.texture_3d.* with these textures. > --- >

Re: [Mesa-dev] [PATCH] broadcom/vc5: Fix source file name.

Vinson Lee writes: > Fixes: c9b2cb78972d ("vc5: add missing files to the tarball") > Signed-off-by: Vinson Lee Reviewed and pushed these two. Thanks! (Also, we need to get automake's distcheck into Travis. I would have caught this before pushing,

[Mesa-dev] [PATCH] mesa: Only require independent blending for GLES 3.2.

We've been requiring this since GLES 3.0 was introduced, but the GLES 3.2 spec is the one that has "Supporting blending on a per-draw-buffer basis" in the new features. V3D 3.3 would require lowering blending to shader code to implement independent blending. --- src/mesa/main/version.c | 2 +- 1

Re: [Mesa-dev] [PATCH] meson: ensure that xmlpool_options.h is generated for targets that need it

Dylan Baker <dy...@pnwbakers.com> writes: > Currently a couple of gallium targets race with xmlpool_options.h being > generated, don't do that. Reviewed-by: Eric Anholt <e...@anholt.net> signature.asc Description: PGP signature __

Re: [Mesa-dev] [PATCH v2] meson: Don't confuse the install and search paths for dri drivers

which will default to the value of > `dri-drivers-path`, like autotools does. > > v2: - Split input list before joining. > > Reported-by: Ilia Mirkin <imir...@alum.mit.edu> > Signed-off-by: Dylan Baker <dylan.c.ba...@intel.com> Reviewed-by: Eric Anholt <e...@anh

Re: [Mesa-dev] [PATCH 02/14] vc4, vc5: add ETIME fallback define

Dylan Baker writes: > [ Unknown signature status ] > I'm not sure how Emil feels about this (and the related patches) but I think > it > might be better to handle this at the build system level, for meson it would > look something like (in the top level meson.build): > > if

Re: [Mesa-dev] compiling OpenCL C to NIR

Tomeu Vizoso writes: > Hi, > > I'm still trying to estimate the work required to support OpenCL on > Freedreno, and as part of that I have given a try to put Khronos' > LLVM-SPIRV into a shape that Mesa can depend on: > >

Re: [Mesa-dev] [PATCH] meson: Don't confuse the install and search paths for dri drivers

Dylan Baker writes: > Currently there is not a separate option for setting the search path of > DRI drivers in meson, like there is in scons and autotools. This is an > oversight and needs to be fixed. This adds an extra option > `dri-search-path`, which will default to the

Re: [Mesa-dev] [PATCH] meson: generate translations for driconf

Dylan Baker writes: > Currently meson implements the same logic as SCons for translations, > namely it doesn't do them. This patch changes meson to use logic more > like autotools, and generate translations. To do this we have to go > behind meson's back a bit, and wrap the

Re: [Mesa-dev] [PATCH v2 2/2] broadcom/vc4: Add support for HW perfmon

'm looking forward to the piglit tests, but this patch is: Reviewed-by: Eric Anholt <e...@anholt.net> signature.asc Description: PGP signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 1/3] nir: Add a lowering pass for gl_FragColor to glFragData[] writes.

Kenneth Graunke <kenn...@whitecape.org> writes: > [ Unknown signature status ] > On Thursday, December 28, 2017 5:56:18 PM PST Eric Anholt wrote: >> For VC5, the shader needs to have the appropriate base type for the >> variable in the render tar

[Mesa-dev] [PATCH 2/3] nir: Add a helper to get the uvec4 type.

I needed this in the vc5 compiler. --- src/compiler/nir_types.cpp | 6 ++ src/compiler/nir_types.h | 1 + 2 files changed, 7 insertions(+) diff --git a/src/compiler/nir_types.cpp b/src/compiler/nir_types.cpp index 377de0c9c7bd..cbdd452dc813 100644 --- a/src/compiler/nir_types.cpp +++

[Mesa-dev] [PATCH 1/3] nir: Add a lowering pass for gl_FragColor to glFragData[] writes.

For VC5, the shader needs to have the appropriate base type for the variable in the render target write, and gallium's FS_COLOR0_WRITES_ALL_CBUFS (used for glClearBufferiv) doesn't give you that information. This pass lets the backend decide what types to explode the gl_FragColor write out to.

[Mesa-dev] [PATCH 3/3] broadcom/vc5: Use the new glFragColor lowering pass.

This fixes dEQP-GLES3.functional.fbo.color.clear.r16i and friends, by making sure we do an integer TLB store instead of float. --- src/broadcom/compiler/nir_to_vir.c| 5 + src/broadcom/compiler/v3d_compiler.h | 6 ++ src/broadcom/compiler/vir.c | 13 +

Re: [Mesa-dev] [PATCH 3/3] broadcom/vc4: Add support for HW perfmon

Boris Brezillon writes: > The V3D engine provides several perf counters. > Implement ->get_driver_query_[group_]info() so that these counters are > exposed through the GL_AMD_performance_monitor extension. Thanks for working on this! I've successfully used

Re: [Mesa-dev] [PATCH mesa] radeon: remove left over dead code

Eric Engestrom <eric.engest...@imgtec.com> writes: > Fixes: 4e0d99a63588c67a955f "r100: Use shared debug code" > Cc: Pauli Nieminen <suok...@gmail.com> > Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> Reviewed-by: Eric Anholt <e...@anho

Re: [Mesa-dev] [PATCH] drirc: add option to disable ARB_draw_indirect

Nicolai Hähnle writes: > On 15.12.2017 12:37, Rob Clark wrote: >> On Fri, Dec 15, 2017 at 4:41 AM, Nicolai Hähnle >> wrote: >>> On 15.12.2017 00:56, Rob Clark wrote: On Wed, Dec 6, 2017 at 3:31 PM, Ian Romanick

Re: [Mesa-dev] [PATCH] meson: fix glx-test race

Dylan Baker <dy...@pnwbakers.com> writes: > This test should rely on dispatch.h being generated, but it doesn't. Reviewed-by: Eric Anholt <e...@anholt.net> signature.asc Description: PGP signature ___ mesa-dev mailin

Re: [Mesa-dev] [PATCH 1/2] gallium/util: add u_transfer_helper

Rob Clark writes: > Add a new helper that drivers can use to emulate various things that > need special handling in particular in transfer_map: > > 1) z32_s8x24.. gl/gallium treats this as a single buffer with depth > and stencil interleaved but hardware frequently

Re: [Mesa-dev] [PATCH 1/3] nir: Fix interaction of GL_CLAMP lowering with texture offsets.

Eric Anholt <e...@anholt.net> writes: > We want the clamping of the coordinate to apply after the offset, so we > need to do math to lower the offset out of the instruction. Fixes texwrap > offset cases for GL_CLAMP with GL_NEAREST on vc5. Still looking for a review

Re: [Mesa-dev] [PATCH 1/2] gallium/util: add u_transfer_helper

Rob Clark writes: > Add a new helper that drivers can use to emulate various things that > need special handling in particular in transfer_map: > > 1) z32_s8x24.. gl/gallium treats this as a single buffer with depth > and stencil interleaved but hardware frequently

Re: [Mesa-dev] [PATCH v2] util: hash_table: move NULL assert to string hashing function

Lionel Landwerlin writes: > Hash maps might use pointer keys (which people surely might want to > use to hash values) in which case a 0 value is perfectly acceptable. > It's only if the hash function needs to deference the pointer that we > want to be sure it's not

Re: [Mesa-dev] [PATCH] mesa/st: glsl_to_tgsi: Dissolve arrays who's elements are only accessed directly

Gert Wollny writes: > Array who's elements are only accessed directly are replaced by the > according number of temporary registers. By doing so the otherwise > reserved register range becomes subject to further optimizations like > copy propagation and register merging. >

Re: [Mesa-dev] [PATCH mesa 11/16] broadcom: use NDEBUG to guard asserts

Eric Engestrom <eric.engest...@imgtec.com> writes: > Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> This and the previous patch are: Reviewed-by: Eric Anholt <e...@anholt.net> signature.asc Description: PGP signature ___

Re: [Mesa-dev] [PATCH mesa 0/7] remove upstreamed specs

Eric Engestrom <eric.engest...@imgtec.com> writes: > On Wednesday, 2017-11-22 12:28:17 -0800, Eric Anholt wrote: >> Jordan Justen <jordan.l.jus...@intel.com> writes: >> >> > On 2017-11-22 09:59:34, Eric Engestrom wrote: >> >> A recent thread [1]

Re: [Mesa-dev] [PATCH v3 06/15] meson: build virgl driver

Dylan Baker <dy...@pnwbakers.com> writes: > Build tested only. I haven't done a detailed comparison to the autotools build, but this all looks fine. Patches 1-6: Reviewed-by: Eric Anholt <e...@anholt.net> signature.asc Description

Re: [Mesa-dev] [PATCH mesa 0/7] remove upstreamed specs

Jordan Justen writes: > On 2017-11-22 09:59:34, Eric Engestrom wrote: >> A recent thread [1] made me check our local specs to see which ones were >> upstream. This series removes the ones that are identical upstream >> (modulo "TBD" extension numbers in some cases). >

[Mesa-dev] [PATCH 2/3] nir: Add a new lowering option to lower all txd to txl.

VC5 requires that all txd are lowered in the shader. --- src/compiler/nir/nir.h | 6 ++ src/compiler/nir/nir_lower_tex.c | 14 -- 2 files changed, 14 insertions(+), 6 deletions(-) diff --git a/src/compiler/nir/nir.h b/src/compiler/nir/nir.h index

[Mesa-dev] [PATCH 1/3] nir: Fix interaction of GL_CLAMP lowering with texture offsets.

We want the clamping of the coordinate to apply after the offset, so we need to do math to lower the offset out of the instruction. Fixes texwrap offset cases for GL_CLAMP with GL_NEAREST on vc5. Note: I moved the get_texture_size() verbatim, so that it was defined before use. ---

[Mesa-dev] [PATCH 3/3] broadcom/vc5: Enable NIR txd lowering on all txd instructions.

Fixes almost all of piglit's arb_shader_texture_lod grad tests, except for the base -texgrad/texgradcube ones which fail on what appear to be precision problems. --- src/broadcom/compiler/vir.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/broadcom/compiler/vir.c

[Mesa-dev] [PATCH v2 1/5] gallium: Add helpers for MSAA resolves in pipe_transfer_map()/unmap().

I had replicated this code from vc4 to vc5, but it's something that most drivers will need to do in a similar way. --- src/gallium/auxiliary/util/u_transfer.c | 119 src/gallium/auxiliary/util/u_transfer.h | 10 +++ 2 files changed, 129 insertions(+) diff --git

[Mesa-dev] [PATCH v2 4/5] gallium: Make a helper for doing Z32_FLOAT_S8X24_UINT mappings.

v2: Remove the callback, leave avoiding the recursion up to the caller (probably by rewriting the vtbl either in pctx or u_resource_vtbl) --- src/gallium/auxiliary/util/u_transfer.c | 114 src/gallium/auxiliary/util/u_transfer.h | 11 +++ 2 files changed, 125

[Mesa-dev] [PATCH v2 2/5] broadcom/vc4: Switch to using the u_transfer_map_msaa_helper().

--- src/gallium/drivers/vc4/vc4_resource.c | 104 - src/gallium/drivers/vc4/vc4_resource.h | 3 - 2 files changed, 10 insertions(+), 97 deletions(-) diff --git a/src/gallium/drivers/vc4/vc4_resource.c b/src/gallium/drivers/vc4/vc4_resource.c index

[Mesa-dev] [PATCH v2 5/5] broadcom/vc5: Start adding support for rendering to Z32F_S8X24_UINT.

There may be some more RCL work to be done (I think I need to split my Z/S stores when doing separate stencil), but this gets piglit's "texwrap GL_ARB_depth_buffer_float" working. v2: Unwrap the z32f_wrapper before calling the helper, rather than having the helper have a callback. ---

[Mesa-dev] [PATCH v2 3/5] broadcom/vc5: Switch to using u_transfer_map_msaa_helper().

--- src/gallium/drivers/vc5/vc5_resource.c | 103 - src/gallium/drivers/vc5/vc5_resource.h | 3 - 2 files changed, 10 insertions(+), 96 deletions(-) diff --git a/src/gallium/drivers/vc5/vc5_resource.c b/src/gallium/drivers/vc5/vc5_resource.c index

<    1   2   3   4   5   6   7   8   9   10   >