Re: [Mesa-dev] NIR linking optimisations for Gallium drivers

Timothy Arceri writes: > This series depends on: > https://patchwork.freedesktop.org/series/34131/ > > Tested without regression on radeonsi. > > Shader-db results (still limited to GLSL 1.40 so not to interesting): > > Totals from affected shaders: > SGPRS: 29440 ->

Re: [Mesa-dev] [PATCH 1/2] meson: don't build gallium subdir unless we're building gallium

Dylan Baker <dy...@pnwbakers.com> writes: > This will allow us to simplify some guards within the gallium directory. These are: Reviewed-by: Eric Anholt <e...@anholt.net> signature.asc Description: PGP signature ___ mesa-dev mailin

[Mesa-dev] [PATCH 4/5] gallium: Make a helper for doing Z32_FLOAT_S8X24_UINT mappings.

--- src/gallium/auxiliary/util/u_transfer.c | 118 src/gallium/auxiliary/util/u_transfer.h | 18 + 2 files changed, 136 insertions(+) diff --git a/src/gallium/auxiliary/util/u_transfer.c b/src/gallium/auxiliary/util/u_transfer.c index

[Mesa-dev] [PATCH 1/5] gallium: Add helpers for MSAA resolves in pipe_transfer_map()/unmap().

I had replicated this code from vc4 to vc5, but it's something that most drivers will need to do in a similar way. --- src/gallium/auxiliary/util/u_transfer.c | 119 src/gallium/auxiliary/util/u_transfer.h | 10 +++ 2 files changed, 129 insertions(+) diff --git

[Mesa-dev] [PATCH 5/5] broadcom/vc5: Start adding support for rendering to Z32F_S8X24_UINT.

There may be some more RCL work to be done (I think I need to split my Z/S stores when doing separate stencil), but this gets piglit's "texwrap GL_ARB_depth_buffer_float." working. --- src/gallium/drivers/vc5/vc5_rcl.c | 22 + src/gallium/drivers/vc5/vc5_resource.c | 85

[Mesa-dev] [PATCH 0/5] gallium transfer_map() helpers (MSAA, Z32F_S8X24).

to work. Eric Anholt (5): gallium: Add helpers for MSAA resolves in pipe_transfer_map()/unmap(). broadcom/vc4: Switch to using the u_transfer_map_msaa_helper(). broadcom/vc5: Switch to using u_transfer_map_msaa_helper(). gallium: Make a helper for doing Z32_FLOAT_S8X24_UINT mappings. broadcom

[Mesa-dev] [PATCH 2/5] broadcom/vc4: Switch to using the u_transfer_map_msaa_helper().

--- src/gallium/drivers/vc4/vc4_resource.c | 104 - src/gallium/drivers/vc4/vc4_resource.h | 3 - 2 files changed, 10 insertions(+), 97 deletions(-) diff --git a/src/gallium/drivers/vc4/vc4_resource.c b/src/gallium/drivers/vc4/vc4_resource.c index

[Mesa-dev] [PATCH 3/5] broadcom/vc5: Switch to using u_transfer_map_msaa_helper().

--- src/gallium/drivers/vc5/vc5_resource.c | 103 - src/gallium/drivers/vc5/vc5_resource.h | 3 - 2 files changed, 10 insertions(+), 96 deletions(-) diff --git a/src/gallium/drivers/vc5/vc5_resource.c b/src/gallium/drivers/vc5/vc5_resource.c index

Re: [Mesa-dev] [PATCH v5 00/10] new series of Mesa for Tizen

"Mun, Gwan-gyeong" writes: > Hi all, > > I am sorry that I didn't have enough discussion about why new window > system code is needed for Tizen on mesa. > > This is a brief architecture of Tizen Window System. > > >

Re: [Mesa-dev] [PATCH 1/3] broadcom/vc4: fix indentation in vc4_screen.c

Andres Rodriguez writes: > Stumbled into this when adding a new PIPE_CAP. > > Signed-off-by: Andres Rodriguez Reviewed this one, and pushed the series with nh's reviews added. signature.asc Description: PGP signature

Re: [Mesa-dev] [PATCH] st/atifs: merge gl_program and ati_fragment_shader

Miklós Máté writes: > On 12/11/17 00:06, Timothy Arceri wrote: >> On 12/11/17 04:10, Miklós Máté wrote: >>> Hi, >>> >>> this breaks a few things. The patch below gets rid of the assertion >>> failures, but the reference counting needs a proper fix, and swrast >>> draws

Re: [Mesa-dev] [PATCH 1/3] meson: don't use build_by_default for specific gallium drivers

+ subdir('drivers/nouveau') > +endif > +if with_gallium_freedreno > + subdir('winsys/freedreno/drm') > + subdir('drivers/freedreno') > +endif > +if with_gallium_pl111 >subdir('winsys/pl111/drm') > endif > -subdir('winsys/radeon/drm') > -subdi

Re: [Mesa-dev] [PATCH 5/5] meson: build gallium-xlib based glx

Dylan Baker <dy...@pnwbakers.com> writes: > [ Unknown signature status ] > Quoting Eric Anholt (2017-11-08 13:26:12) >> We shouldn't have to manually specify most of these deps, I think, since >> they should be transitively pulled in by the static libraries using >>

Re: [Mesa-dev] [PATCH 4/4] meson: Enable VC4's NEON assembly support.

Dylan Baker <dy...@pnwbakers.com> writes: > [ Unknown signature status ] > Quoting Eric Anholt (2017-11-08 14:14:57) >> --- >> meson.build | 5 +++-- >> src/gallium/drivers/vc4/meson.build | 13 + >> 2 files ch

Re: [Mesa-dev] [PATCH 2/3] glx: Prepare the DRI backends for GLX_EXT_no_config_context

no equivalent WGL extension, and wglCreateContextAttribs > seems to really want the HDC's pixel format to be set. Patch 1-2 are: Reviewed-by: Eric Anholt <e...@anohlt.net signature.asc Description: PGP signature ___ mesa-dev mailing list mesa-dev@lis

Re: [Mesa-dev] [PATCH] amd/addrlib: update to latest version

Nicolai Hähnle writes: > On 08.11.2017 09:53, Michel Dänzer wrote: >> On 07/11/17 10:58 PM, Marek Olšák wrote: >>> On Tue, Nov 7, 2017 at 9:01 PM, Nicolai Hähnle wrote: On 07.11.2017 18:35, Michel Dänzer wrote: > > On 07/11/17 06:28 PM, Marek

[Mesa-dev] [PATCH 2/4] meson: Drop stale comment about making valgrind conditional.

It was fixed in 5c2ff5773a707519f6a773126f201c4e1e8a42d7. --- meson.build | 1 - 1 file changed, 1 deletion(-) diff --git a/meson.build b/meson.build index 117ed7c087f4..0118c9a7c5ef 100644 --- a/meson.build +++ b/meson.build @@ -691,7 +691,6 @@ if with_glvnd pre_args += '-DUSE_LIBGLVND=1'

[Mesa-dev] [PATCH 0/4] meson: vc4 ARMHF cross-build support

Timothy Arceri noted that vc4 didn't seem to have the NEON stuff hooked up, so I worked on getting vc4 cross builds working for me finally. I haven't tested the result on HW quite yet. Eric Anholt (4): meson: Leave dep_llvm empty if !with_llvm meson: Drop stale comment about making valgrind

[Mesa-dev] [PATCH 1/4] meson: Leave dep_llvm empty if !with_llvm

The gallium auxiliary build would link against llvm, for the gallivm code that it didn't build. This broke the build on my armhf cross, where libLLVM-3.9.so is not multiarch and thus points to x86-64 libs. --- meson.build | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git

[Mesa-dev] [PATCH 4/4] meson: Enable VC4's NEON assembly support.

--- meson.build | 5 +++-- src/gallium/drivers/vc4/meson.build | 13 + 2 files changed, 16 insertions(+), 2 deletions(-) diff --git a/meson.build b/meson.build index 0118c9a7c5ef..189c9be5b59c 100644 --- a/meson.build +++ b/meson.build @@ -485,8 +485,9 @@

[Mesa-dev] [PATCH 3/4] meson: Always link libgallium_dri.so against dep_thread.

Somehow on my cross build the -pthread is getting lost. All the other deps seem to work out fine. --- src/gallium/targets/dri/meson.build | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/targets/dri/meson.build b/src/gallium/targets/dri/meson.build index

Re: [Mesa-dev] [PATCH 5/5] meson: build gallium-xlib based glx

s : [dep_clock, dep_unwind, gallium_xlib_depends], We shouldn't have to manually specify most of these deps, I think, since they should be transitively pulled in by the static libraries using them, right? It's fine either way, though. > + install : true, > + version : '1.5.0', Looks like

Re: [Mesa-dev] [PATCH 1/3] broadcom/vc5: Add vc5_drm.h to the release tarball

Andreas Boll <andreas.boll@gmail.com> writes: > Fixes: 45bb8f29571 ("broadcom: Add V3D 3.3 gallium driver called "vc5", >for BCM7268.") All are: Reviewed-by: Eric Anholt <e...@anholt.net> signature.asc Description: PGP signature __

Re: [Mesa-dev] [PATCH 2/2] meson: set visibility flags on gbm

Dylan Baker <dy...@pnwbakers.com> writes: > This is done in autotools, and is an oversight in the meson build. > > Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> Both are: Reviewed-by: Eric Anholt <e...@anholt.net> signature.asc

Re: [Mesa-dev] [PATCH 2/2] broadcom/genxml: Fix decoding of groups with small fields.

Kenneth Graunke writes: > Groups containing fields smaller than a byte probably not being decoded > correctly. For example: > > > > > > gen_field_iterator_next would properly walk over each element of the > array, incrementing group_iter. However, the

Re: [Mesa-dev] [PATCH] meson: Use true and false instead of yes and no for tristate options

gt; Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> Reviewed-by: Eric Anholt <e...@anholt.net> signature.asc Description: PGP signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] meson: use dep_m in libgallium

Erik Faye-Lund <kusmab...@gmail.com> writes: > The u_format_other.c users sqrtf, which on some systems require > a math-library. So let's make sure we link with it. > > Signed-off-by: Erik Faye-Lund <kusmab...@gmail.com> Reviewed-by: Eric Anholt <e...@anholt.net>

Re: [Mesa-dev] [PATCH] nir: Don't print swizzles when there are more than 4 components

Jason Ekstrand writes: > On October 27, 2017 18:21:45 Matt Turner wrote: > >> ... as can happen with various types like mat4, or else we'll smash the >> stack writing past the end of components_local[]. > > Ugh... Ideally, I think you'd want

Re: [Mesa-dev] [PATCH v5 00/10] new series of Mesa for Tizen

Gwan-gyeong Mun writes: > Hi, > > These Patch v5 series modified with new helper function series [1]. > > These series only have mesa for tizen feature. > > [1] https://patchwork.freedesktop.org/series/32577/ Rather than have another giant pile of window system code in the

Re: [Mesa-dev] meson for remaining class drivers

Dylan Baker writes: > [ Unknown signature status ] > ping You had my r-b other than one comment. Are you pinging for something else? signature.asc Description: PGP signature ___ mesa-dev mailing list

Re: [Mesa-dev] [PATCH 1/3] gallium: add PIPE_CAP_SIGNED_VERTEX_BUFFER_OFFSET

Marek Olšák writes: > From: Marek Olšák Could you hit vc5, as well? I'm not clear on why this is a pipe_cap instead of just updating type or comments on the pipe structs to say what the new behavior is -- aren't most of us using 32-bit math that will

Re: [Mesa-dev] [PATCH mesa v2] vc4: fix release build

Eric Engestrom <eric.engest...@imgtec.com> writes: > Mesa's DEBUG and assert's NDEBUG are not tied to each other, so we need > to explicitly compile this code out. > > Fixes: 3df78928786134874eafa "vc4: Drop reloc_count tracking for debug >asserts on non-debug

Re: [Mesa-dev] [PATCH mesa] vc4: fix release build

Eric Engestrom writes: > Mesa's DEBUG and assert's NDEBUG are not tied to each other, so we need > to explicitly compile this code out. We should move these DEBUG ifdefs under NDEBUG, then -- the point was to not have the field that's only used for the asserts when

Re: [Mesa-dev] [PATCH 1/2] mesa: enum checks for GL_EXT_occlusion_query_boolean

Y_EXT." > +* > +* Same rule is present also in ES 3.2 spec. > +*/ > + if (_mesa_is_gles(ctx) && pname != GL_CURRENT_QUERY) { > + _mesa_error(ctx, GL_INVALID_ENUM, "glGetQueryivEXT(%s)", > + _mesa_enum_to_string

Re: [Mesa-dev] [PATCH 2/2] gles2: support for GL_EXT_occlusion_query_boolean

@@ -751,6 +751,57 @@ > > > > + > + I think you want number="100" Other than that, this patch is: Reviewed-by: Eric Anholt <e...@anholt.net> signature.asc Description: PGP signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 3/3] mesa: final changes to expose OpenGL 3.1 with ARB_compatibility

Marek Olšák writes: > From: Marek Olšák Do we have tests that the compatibility parts of GLSL are properly enabled when you have GL_ARB_compatibility enabled? I see a bunch of negative tests for them, but we should get some positive ones. signature.asc

Re: [Mesa-dev] [PATCH 2/3] mesa: enable ARB_texture_buffer_* extensions in the Compatibility profile

uffer_range piglit test to run > with the compat profile. Reviewed-by: Eric Anholt <e...@anholt.net> signature.asc Description: PGP signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] meson: bump libdrm_amdgpu requirement to 2.4.85

Dylan Baker writes: > fixes: b60372570323243ec73 ("configure.ac: Bump libdrm_amdgpu version to > 2.4.85.") > cc: Bas Nieuwenhuizen > Signed-off-by: Dylan Baker r-b signature.asc Description: PGP signature

Re: [Mesa-dev] [PATCH 2/2] nir: Print the components referenced for split or packed shader in/outs.

Timothy Arceri <tarc...@itsqueeze.com> writes: > On 20/10/17 20:52, Timothy Arceri wrote: >> >> >> On 20/10/17 17:33, Timothy Arceri wrote: >>> On 18/10/17 07:52, Eric Anholt wrote: >>>> Having 4 variables all called "gl_in_TexCoord0@n&q

Re: [Mesa-dev] [PATCH 2/2] i965: Reduce the frequency of madvise calls

Chris Wilson writes: > We can reduce the frequency of calling madvise by only using it for > buffers that are inactive (busy buffers will be pinned by they use by the > GPU, so should not significantly add to mempressure, but will still be > reaped by our timed cache.)

Re: [Mesa-dev] [PATCH 1/2] nir: Add a safety check that we don't remove dead I/O vars after lowering.

Timothy Arceri <tarc...@itsqueeze.com> writes: > On 18/10/17 07:52, Eric Anholt wrote: >> The pass only looks at var load/store intrinsics, not input load/store >> intrinsics, so assert that we don't see the other type. >> --- >> >> I tripped over thi

Re: [Mesa-dev] [PATCH] meson: turn on pl111 not vc4 when pl111 driver specificed

Dylan Baker <dy...@pnwbakers.com> writes: > cc: Eric Anholt <e...@anholt.net> > fixes: 1918c9b1627d5403 ("meson: Add support for the pl111 driver.") > Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> > --- > > I missed this when I was reviewing,

[Mesa-dev] [PATCH] i965: Fix memmem compiler warnings.

gcc is throwing this warning in my meson build: ../src/intel/compiler/brw_eu_validate.c:50:11: warning argument 1 null where non-null expected [-Wnonnull] return memmem(haystack.str, haystack.len, ^~ needle.str,

[Mesa-dev] [PATCH 1/2] nir: Add a safety check that we don't remove dead I/O vars after lowering.

The pass only looks at var load/store intrinsics, not input load/store intrinsics, so assert that we don't see the other type. --- I tripped over this limitation when trying to use the NIR linking helpers in vc4. src/compiler/nir/nir_remove_dead_variables.c | 20 1 file

[Mesa-dev] [PATCH 2/2] nir: Print the components referenced for split or packed shader in/outs.

Having 4 variables all called "gl_in_TexCoord0@n" isn't very informative, much better to see: decl_var shader_in INTERP_MODE_NONE float gl_in_TexCoord0 (VARYING_SLOT_VAR0.x, 1, 0) decl_var shader_in INTERP_MODE_NONE float gl_in_TexCoord0@0 (VARYING_SLOT_VAR0.y, 1, 0) decl_var shader_in

[Mesa-dev] [PATCH 2/2] ac: Silence a compiler warning about results[0].

We know that num_components will be > 0, but it doesn't. --- src/amd/common/ac_nir_to_llvm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index 3ba3ebf051e2..07fa3fdf84b5 100644 --- a/src/amd/common/ac_nir_to_llvm.c +++

[Mesa-dev] [PATCH 1/2] ac: Fix a compiler warning for possibly undefined "name"

--- src/amd/common/ac_llvm_build.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/amd/common/ac_llvm_build.c b/src/amd/common/ac_llvm_build.c index 949f181aace0..2341d2135856 100644 --- a/src/amd/common/ac_llvm_build.c +++ b/src/amd/common/ac_llvm_build.c @@ -1257,7

Re: [Mesa-dev] [PATCH 3/4] meson: build r200 driver

allium_radeonsi or with_dri_r100 or with_dri_r200 # older radeon too >dep_libdrm_radeon = dependency('libdrm_radeon', version : '>= 2.4.71') > endif Now that there is older radeon being handled, I think the comment can be removed. Other than that, the series is: Reviewed-by: Eric Anho

[Mesa-dev] [PATCH 0/3] meson for broadcom

it easy to bury the dependencies for the vc4 and vc5 drivers in their subdirs. It also means we could drop the build_by_default falses, though I haven't done that. Tested vc4 and vc5 in simulation and vc5's unit test. Eric Anholt (3): meson: Add support for the vc4 driver. meson: Add support

[Mesa-dev] [PATCH 3/3] meson: Add support for the vc5 driver.

--- meson.build| 2 + meson_options.txt | 2 +- src/broadcom/{ => compiler}/meson.build| 25 +++- src/broadcom/meson.build | 18 + src/broadcom/{ => qpu}/meson.build

[Mesa-dev] [PATCH 1/3] meson: Add support for the vc4 driver.

--- meson.build | 2 + meson_options.txt| 2 +- src/{ => broadcom/cle}/meson.build | 80 +++-- src/{ => broadcom}/meson.build | 50 ++--- src/gallium/drivers/vc4/meson.build

[Mesa-dev] [PATCH 2/3] meson: Add support for the pl111 driver.

--- meson.build | 2 ++ meson_options.txt| 2 +- src/gallium/meson.build | 4 +++- src/gallium/targets/dri/meson.build | 5 + src/gallium/winsys/pl111/drm/meson.build | 30 ++ 5 files

Re: [Mesa-dev] [PATCH] meson: build mesa test.

inc_mesa], > + dependencies : [idep_gtest, dep_clock, dep_dl, dep_thread], > + link_with : [libmesa_classic, link_main_test], > +) > + > +test('main-test', main_test) I still find the extra temp variable strange. Regardless, Reviewed-by: Eric Anholt <e...@anholt.net> signature.asc Description: PGP signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH v3 10/21] meson: split and simplify dependencies

Dylan Baker writes: > Rather than group dependencies in complex groups, use a flatter > structure with split dependencies to avoid checking for the same > dependencies twice. > > v2: - Fix building vulkan drivers without gallium or dri drivers > v3: - Drop TODO comment that

Re: [Mesa-dev] [PATCH v3 02/21] configure: commit test files

Dylan Baker <dy...@pnwbakers.com> writes: > These are currently auto-generated, but meson needs the same files, so > lets commit them to reduce duplication. > > v3: - Rename .build to build-support 2, 3 are: Reviewed-by: Eric Anholt <e...@anholt.net> signature.asc De

[Mesa-dev] [PATCH] include: Revert out the update of the Khronos GLX extension header.

They made a mistake in the MESA_swap_control XML, which I'm pursuing in their github. Until then, we can just back this piece out. --- include/GL/glxext.h | 12 +--- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/include/GL/glxext.h b/include/GL/glxext.h index

Re: [Mesa-dev] [PATCH v2 17/21] meson: build nouveau (gallium) driver

Dylan Baker <dy...@pnwbakers.com> writes: > [ Unknown signature status ] > Quoting Eric Anholt (2017-10-12 12:47:19) >> Dylan Baker <dy...@pnwbakers.com> writes: >> >> > Tested with a GK107. >> > >> > v2: - Add target for nouveau

Re: [Mesa-dev] [PATCH v2 18/21] meson: build softpipe

Dylan Baker <dy...@pnwbakers.com> writes: > [ Unknown signature status ] > Quoting Eric Anholt (2017-10-12 12:27:21) >> Dylan Baker <dy...@pnwbakers.com> writes: >> >> > This doesn't include llvmpipe. >> > >&g

Re: [Mesa-dev] [PATCH v2 17/21] meson: build nouveau (gallium) driver

Dylan Baker writes: > Tested with a GK107. > > v2: - Add target for nouveau standalone compiler. This target is not > built by default. Looks like this missed the update of meson_options.txt. signature.asc Description: PGP signature

Re: [Mesa-dev] [PATCH v2 18/21] meson: build softpipe

g', value : 'i965', > description : 'comma separated list of dri drivers to build.') Looks like a stray change. Other than that, 18-20 are: Reviewed-by: Eric Anholt <e...@anholt.net> signature.asc Description: PGP signature ___ mesa-dev

Re: [Mesa-dev] [PATCH v2 10/21] meson: split and simplify depdendncies

Dylan Baker writes: > Rather than group dependencies in complex groups, use a flatter > structure with split dependencies to avoid checking for the same > dependencies twice. meson's going to be caching the dependency checks in the future, so I wouldn't go out of your way

Re: [Mesa-dev] [PATCH v2 07/21] meson: Add option to toggle LLVM

Dylan Baker <dy...@pnwbakers.com> writes: > Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> 5-7 are Reviewed-by: Eric Anholt <e...@anholt.net> signature.asc Description: PGP signature ___ mesa-dev mailing list mesa-dev@

Re: [Mesa-dev] [PATCH 15/20] meson: build radeonsi gallium driver

_depends += files('../dri-vdpau.dyn') > +endif > + > +if with_dri > + gallium_dri_link_with += libswdri > +endif > +if with_gallium_drisw_kms > + gallium_dri_link_with += libswkmsdri > +endif > + > +if with_gallium_radeonsi > + gallium_dri_c_args += '-DGA

Re: [Mesa-dev] [PATCH 09/20] meson: split and simplify depdendncies

Dylan Baker writes: > Rather than group dependencies in complex groups, use a flatter > structure with split dependencies to avoid checking for the same > dependencies twice. In the subject: *dependencies* signature.asc Description: PGP signature

Re: [Mesa-dev] [PATCH v2 3/6] nir: add variant of lower_io_to_scalar to be called earlier

e mask rather than first and last stage integer. Reviewed-by: Eric Anholt <e...@anholt.net> signature.asc Description: PGP signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH v2 4/6] glsl: mark xfb inputs as always_active_io

matched_candidate->toplevel_var->data.always_active_io = 1; > > + /* Mark the any corresponding inputs as always active also. We must do > + * this because we have a NIR pass that lowers vertors to scalars and *vectors O

Re: [Mesa-dev] [PATCH 2/2] meson: Build i915

Ville Syrjala <ville.syrj...@linux.intel.com> writes: > From: Ville Syrjälä <ville.syrj...@linux.intel.com> > > Build i915 with meson. More or less copied from i965, with all > the unneeded cruft removed, and the libdrm_intel dependency added. Both are: Reviewed-by: Eric

[Mesa-dev] [PATCH] mesa: Disallow GL_RED/GL_RG with half-floats on GLES2.

Sure, you'd think that the combination of GL_OES_texture_half_float and GL_EXT_texture_rg would mean that GL_RG16F exists, but it doesn't. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103227 Fixes: c16a7443e999 ("mesa: Expose GL_OES_required_internalformat on GLES contexts.") ---

Re: [Mesa-dev] Testing out Kristian's fast mtx patch

Timothy Arceri writes: > After a recent discussion about this code from 2015 I was curious > to give it a try. The outstanding review item was that we shouldn't > be replacing the C11 mtx type/functions with our own, so I've renamed > the fast path to simple_mtx* and added

Re: [Mesa-dev] [PATCH 08/20] meson: Build gallium auxiliary

Dylan Baker <dy...@pnwbakers.com> writes: > Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> Patch 2, 5-8 are: Reviewed-by: Eric Anholt <e...@anholt.net> For patch 3, I'm not a huge fan of checking in things in .build/, and I'm going to think about that for a

Re: [Mesa-dev] [PATCH] meson: fix glx test

Dylan Baker <dy...@pnwbakers.com> writes: > That requires a generated header that was rolled into a loop. > > fixes: a47c525f3281a27 ("meson: build glx") > Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> Reviewed-by: Eric Anholt <e...@anholt.net>

Re: [Mesa-dev] [PATCH] i965: Allow mapped VBOs during drawing in non-debug contexts.

ests.invalid_mapped_bos, > but that test is invalid and has been removed from the upstream CTS. Given the spec text, we should probably just remove the flag entirely and do this for everyone. However, for i965: Reviewed-by: Eric Anholt <e...@anholt.net> signature.asc Description: PGP s

[Mesa-dev] [PATCH 2/2] include: Update GL headers from khronos opengl registry.

Taken from their c6a99aff31874697741a08cbc8a3488606ce59c7, keeping the BUILDING_MESA hunk in place. --- include/GL/glcorearb.h | 24 +- include/GL/glext.h | 69 -- include/GL/glxext.h| 12 - include/GL/wglext.h|

[Mesa-dev] [PATCH 1/2] mapi: Update extension number of MESA_tile_raster_order.

--- src/mapi/glapi/gen/MESA_tile_raster_order.xml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/mapi/glapi/gen/MESA_tile_raster_order.xml b/src/mapi/glapi/gen/MESA_tile_raster_order.xml index a1f0cb89bee4..7cc73ca4b025 100644 ---

Re: [Mesa-dev] [PATCH v2 1/4] nir: set default lod to texture opcodes that needed it but don't provide it

Samuel Iglesias Gonsálvez <sigles...@igalia.com> writes: > [ Unknown signature status ] > On Tuesday, October 10, 2017 11:53:27 AM CEST Eric Anholt wrote: >> Samuel Iglesias Gonsálvez <sigles...@igalia.com> writes: >> > Signed-off-by: Samuel Iglesia

Re: [Mesa-dev] [PATCH v2 1/4] nir: set default lod to texture opcodes that needed it but don't provide it

Samuel Iglesias Gonsálvez writes: > Signed-off-by: Samuel Iglesias Gonsálvez > --- > src/compiler/nir/nir_lower_tex.c | 68 > > 1 file changed, 68 insertions(+) > > diff --git

Re: [Mesa-dev] [PATCH] egl/dri: don't crash when createImageFromRenderbuffer2 is NULL

e createImageFromRenderbuffer2 when > available") > Cc: Nicolai Hähnle <nhaeh...@gmail.com> > Signed-off-by: Emil Velikov <emil.veli...@collabora.com> Reviewed-by: Eric Anholt <e...@anholt.net> signature.asc Description: PGP signature _

Re: [Mesa-dev] [PATCH 5/5] mesa: Implement a new GL_MESA_tile_raster_order extension.

Eric Anholt <e...@anholt.net> writes: > [ Unknown signature status ] > Nicolai Hähnle <nhaeh...@gmail.com> writes: > >> Patches 1 & 2: >> >> Acked-by: Nicolai Hähnle <nicolai.haeh...@amd.com> >> >> Patches 4 & 5: >> >&

Re: [Mesa-dev] [PATCH 3/6] nir: add variant of lower_io_to_scalar to be called earlier

Timothy Arceri <tarc...@itsqueeze.com> writes: > On 10/10/17 09:31, Timothy Arceri wrote: >> On 10/10/17 09:06, Eric Anholt wrote: >>> Timothy Arceri <tarc...@itsqueeze.com> writes: >>> >>>> This is intended to be called before nir_lower_io(

Re: [Mesa-dev] [PATCH 4/6] glsl: mark xfb inputs as always_active_io

Timothy Arceri <tarc...@itsqueeze.com> writes: > On 10/10/17 09:31, Eric Anholt wrote: >> Timothy Arceri <tarc...@itsqueeze.com> writes: >> >>> We won't split varyings marked as always active because there >>> is no point in doing so. This means we

Re: [Mesa-dev] [PATCH 4/6] glsl: mark xfb inputs as always_active_io

Timothy Arceri writes: > We won't split varyings marked as always active because there > is no point in doing so. This means we need to mark both > sides of the interface as always active otherwise we will have > a mismatch and start removing things we shouldn't. Is this

Re: [Mesa-dev] [PATCH 5/6] nir: add component level support to remove_unused_io_vars()

Other than that suggestion, this is a pretty obvious extension of the existing code. Reviewed-by: Eric Anholt <e...@anholt.net> signature.asc Description: PGP signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 1/6] nir: add glsl_type_is_64bit() to nir_types

Timothy Arceri <tarc...@itsqueeze.com> writes: > From: Timothy Arceri <timothy.arc...@collabora.com> Reviewed-by: Eric Anholt <e...@anholt.net> signature.asc Description: PGP signature ___ mesa-dev mailing list mesa-dev@lists.

Re: [Mesa-dev] [PATCH 2/6] nir: add glsl_channel_type() helper

4_t_type(); > + default: > + unreachable("Unhandled base type glsl_channel_type()"); > + } > + } It looks like the glsl_type_is_array() case could just be in the switch statement under GLSL_TYPE_ARRAY. Either way, Reviewed-by: Eric Anholt <e...@anholt.net

Re: [Mesa-dev] [PATCH 3/6] nir: add variant of lower_io_to_scalar to be called earlier

Timothy Arceri writes: > This is intended to be called before nir_lower_io() so that we > can do some linking optimisations with the results. It can also > be used with drivers that don't use nir_lower_io() at all such > as RADV. > +static void >

Re: [Mesa-dev] [PATCH 5/5] mesa: Implement a new GL_MESA_tile_raster_order extension.

Nicolai Hähnle writes: > Patches 1 & 2: > > Acked-by: Nicolai Hähnle > > Patches 4 & 5: > > Reviewed-by: Nicolai Hähnle > (for the gallium parts; it would have been nice to split patch 4 up into > gallium and driver parts,

Re: [Mesa-dev] [PATCH 1/6] mesa: Add X1B5G5R5 along with A1B5G5R5.

Nicolai Hähnle <nhaeh...@gmail.com> writes: > On 17.08.2017 18:10, Eric Anholt wrote: >> For supporting RGB5 in hardware with A in the low bit (vc4), we need this >> format as well. >> --- >> src/mesa/main/formats.c | 2 ++ >> src/mesa/main/

Re: [Mesa-dev] [PATCH] editorconfig: Add meson configuration

/.editorconfig > +++ b/.editorconfig > @@ -33,3 +33,7 @@ indent_size = 2 > > [*.patch] > trim_trailing_whitespace = false > + > +[meson.build,meson_options.txt] > +indent_style = space > +indent_size = 2 Thank you! Reviewed-by: Eric Anho

Re: [Mesa-dev] [PATCH 6/6] st/dri: implement createImageFromRenderbuffer(2)

Nicolai Hähnle <nhaeh...@gmail.com> writes: > From: Nicolai Hähnle <nicolai.haeh...@amd.com> > > Tested with dEQP-EGL tests. The image struct setup and error list all appear to be complete. Reviewed-by: Eric Anholt <e...@anholt.net> signature.asc

Re: [Mesa-dev] [PATCH v4] meson: build glx

> one (Eric A) > - fix non glvnd version (Eric A) > - build glx tests > - move loader include variables to this patch (Eric A) > v3: - set the version correctly for GL_LIB_NAME in libglx > v4: - set pkgconfig private fields Reviewed-by

Re: [Mesa-dev] [PATCH v3 07/12] meson: build glx

Dylan Baker writes: > [ Unknown signature status ] > I looked at what autotools generates in it's make files and output and matches > that with what meson is generating now. Does this look good to you? It's the > last patch waiting for review in the series. Yeah, looks good

Re: [Mesa-dev] [PATCH 1/3] gallium: add PIPE_FORMAT_A1B5G5R5_UNORM format

Nicolai Hähnle writes: > From: Nicolai Hähnle > > This matches the GL_UNSIGNED_SHORT_5_5_5_1 type. Sigh, I've sent a patch for this 3 times already and not been able to get review.

Re: [Mesa-dev] [PATCH v2 06/12] meson: Build i965 and dri stack

library', > + filebase : 'glesv1_cm' > +) I'd like to make sure we get these right, since our piglit/cts runs won't tell us if we screw it up. Looks like we want libraries_private: m_dep, dl_dep, dep_thread. Same for glesv2. With that fixed, I'd give it: Reviewed-by: Eric Anholt <e..

Re: [Mesa-dev] [PATCH v2 10/12] meson: build classic swrast

Dylan Baker <dy...@pnwbakers.com> writes: > This adds support for building the classic swrast implementation. This > driver has been tested with glxinfo and glxgears. > > Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> Reviewed-by: Eric Anholt <e...@anholt.net&g

Re: [Mesa-dev] [PATCH v2 09/12] meson: build gbm

ion(), > + libraries : libgbm, > + #libraries_private : [dep_dl], # FIXME: autotools lists this a incomplete Is there a reason this is commented out? Other than that, Reviewed-by: Eric Anholt <e...@anholt.net> signature.asc Description: PGP signature ___

Re: [Mesa-dev] [PATCH v2 08/12] meson: Add support for configuring dri drivers directory.

ion('gles1') > with_gles2 = get_option('gles2') > with_opengl = get_option('opengl') > @@ -574,6 +579,7 @@ if with_platform_x11 >dependency('xcb-dri2', version : '>= 1.8'), >dependency('xcb-xfixes'), > ] > +pre_args += '-DHAVE_X11_PLATFORM' S

Re: [Mesa-dev] [PATCH v2 07/12] meson: build glx

Dylan Baker writes: > This gets GLX and the loader building. The resulting GLX and i965 have > been tested on piglit and seem to work fine. This patch leaves a lot of > todo's in it's wake, GLX is quite complicated, and the build options > involved are many, and the goal at

Re: [Mesa-dev] [PATCH v2 05/12] meson: de-tabularize meson_options.txt

Dylan Baker <dy...@pnwbakers.com> writes: > This ends up being unworkable as more options get added, and with > description wrapped onto a new line it doesn't improve readability > anyway. > > Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> Patch 1-5 are:

Re: [Mesa-dev] [PATCH] vc4: Don't advertise tiled dmabuf modifiers if we can't use them

Derek Foreman writes: > If the DRM_VC4_GET_TILING ioctl isn't present then we can't tell > if a dmabuf bo is tiled or linear, so will always assume it's > linear. > > By not advertising tiled formats in this situation we ensure the > assumption is correct. > > This fixes

Re: [Mesa-dev] [PATCH v2] vc4: Mark BOs as purgeable when they enter the BO cache

+continue; Since things get pushed onto the list in the order they will become available, we can just break when we get a busy one. Other than that, and needing a re-import of vc4_drm.h in include/drm-uapi (see README), this patch is: Reviewed-by: Eric

<    1   2   3   4   5   6   7   8   9   10   >