[Mesa-dev] [PATCH] radv: fix int-to-pointer-cast warnings on 32bit

Trivial. --- src/amd/vulkan/radv_debug.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/amd/vulkan/radv_debug.c b/src/amd/vulkan/radv_debug.c index 08fc80c12ab..e81b9cccb57 100644 --- a/src/amd/vulkan/radv_debug.c +++ b/src/amd/vulkan/radv_debug.c @@ -320,11 +320,11

Re: [Mesa-dev] [PATCH] radv: check return from mkdir

On Fri, Oct 5, 2018 at 3:38 AM Dave Airlie wrote: > > From: Dave Airlie > > There may be some security or sandbox reason this might fail, so > check and fail appropriately. > --- > src/amd/vulkan/radv_meta.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git

Re: [Mesa-dev] [PATCH 1/3] vulkan/alloc: Add a vk_strdup helper

On Thu, Aug 23, 2018 at 6:13 PM, Jason Ekstrand wrote: > --- > src/vulkan/util/vk_alloc.h | 17 + > 1 file changed, 17 insertions(+) > > diff --git a/src/vulkan/util/vk_alloc.h b/src/vulkan/util/vk_alloc.h > index f58a80625a8..bc2bb7509e4 100644 > --- a/src/vulkan/util/vk_alloc.h

Re: [Mesa-dev] [PATCH] vulkan/wsi: fix pointer-integer conversion warnings

On Tue, Aug 21, 2018 at 1:05 AM, Bas Nieuwenhuizen wrote: > Reviewed-by: Bas Nieuwenhuizen > > Did you have access to push? Yeah, just pushed everything. Gražvydas > > On Mon, Aug 20, 2018 at 11:40 PM, Grazvydas Ignotas wrote: >> For 32bit build. Trivial. >

[Mesa-dev] [PATCH] vulkan/wsi: fix pointer-integer conversion warnings

For 32bit build. Trivial. --- src/vulkan/wsi/wsi_common_display.c | 4 ++-- src/vulkan/wsi/wsi_common_x11.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/vulkan/wsi/wsi_common_display.c b/src/vulkan/wsi/wsi_common_display.c index e6cba188dfa..1e90bba460c 100644

[Mesa-dev] [PATCH 2/2] radv: use different builtin shader cache for 32bit

Currently if 64bit and 32bit programs are used interchangeably, radv will keep overwriting the cache. Use separate cache files to avoid that. --- src/amd/vulkan/radv_meta.c | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/src/amd/vulkan/radv_meta.c

[Mesa-dev] [PATCH 1/2] radv: place pointer length into cache uuid

Thanks to reproducible builds, binary file timestamps may be identical for both 32bit and 64bit packages when built from the same source. This means radv will use the same cache for both 32 and 64 bit processes, which leads to crashes. Conveniently there is a spare byte in cache_uuid, let's place

[Mesa-dev] [PATCH] llvmpipe: add cc clobber to inline asm

The bsr instruction modifies flags, so that needs to be indicated to the compiler. No effect on generated code, but still needed for correctness. --- src/gallium/drivers/llvmpipe/lp_setup_tri.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

Re: [Mesa-dev] [PATCH 2/3] nir: Add a discard optimization pass

On Wed, Jul 4, 2018 at 9:13 AM, Jason Ekstrand wrote: > Many fragment shaders do a discard using relatively little information > but still put the discard fairly far down in the shader for no good > reason. If the discard is moved higher up, we can possibly avoid doing > some or almost all of

[Mesa-dev] [PATCH] radeonsi: add a debug flag to zero vram allocations

This allows to avoid having to see garbage in Dying Light loading screen at least, which probably expects Windows/NV behavior of all allocations being zeroed by default. Analogous to radv flag with the same name. --- src/gallium/drivers/radeonsi/si_pipe.c| 1 +

[Mesa-dev] [PATCH] radeonsi: use shifts for sign extension

Avoids a branch and reduces code size a tiny bit: text data bss dechex filename 10804563 398653 2070368 13273584 ca89f0 /tmp/radeonsi_dri.so.old 10804499 398653 2070368 13273520 ca89b0 /tmp/radeonsi_dri.so --- src/gallium/drivers/radeonsi/si_descriptors.c | 4 ++-- 1 file

Re: [Mesa-dev] [PATCH 1/2] vkpipeline-db: add sType to pipeline info

On Tue, Jun 12, 2018 at 8:07 AM, Timothy Arceri wrote: > From: Timothy Arceri localhost.localdomain? > > This avoids hitting asserts in anv. > --- > run.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/run.c b/run.c > index eafbd7d..a962887 100644 > --- a/run.c > +++ b/run.c > @@

Re: [Mesa-dev] [PATCH] radv: add a workaround for DXVK hangs by setting amdgpu-skip-threshold

I haven't tried it, but maybe calling LLVMParseCommandLineOptions() second time would work (after creating the target machine, through call_once) to avoid all this code duplication? Gražvydas On Fri, Jun 8, 2018 at 12:38 PM, Samuel Pitoiset wrote: > Workaround for bug in llvm that causes the

Re: [Mesa-dev] [PATCH 2/6] radeonsi: disable primitive binning for all blitter ops

On Thu, May 17, 2018 at 4:47 AM, Marek Olšák wrote: > From: Marek Olšák > > same as Vulkan. Ambiguous. Did you mean amdvlk? Gražvydas > --- > src/gallium/drivers/radeonsi/si_blit.c | 10 ++ > src/gallium/drivers/radeonsi/si_pipe.h

Re: [Mesa-dev] [PATCH v2] st/mesa: only define GLSL 1.4 for compat if driver supports it

On Wed, May 16, 2018 at 5:02 PM, Christian Gmeiner wrote: > Currently GLSL 1.4 is defined for all gallium drivers even only > GLSL 1.2 is supported as seen on etnaviv. > > v1 -> v2: > - use _min(..) as suggested by Lucas Stach and Michel Dänzer > > Fixes 4560aad780b

[Mesa-dev] [PATCH] radv: assorted typo fixes

Trivial. --- src/amd/vulkan/radv_cmd_buffer.c | 4 ++-- src/amd/vulkan/radv_descriptor_set.c | 2 +- src/amd/vulkan/radv_device.c | 6 +++--- src/amd/vulkan/radv_entrypoints_gen.py | 2 +- src/amd/vulkan/radv_image.c| 4 ++-- src/amd/vulkan/radv_nir_to_llvm.c |

Re: [Mesa-dev] [PATCH v2 1/3] mesa: actually support compat profile creation with MESA_GL_VERSION_OVERRIDE

On Wed, May 2, 2018 at 3:38 PM, Timothy Arceri <tarc...@itsqueeze.com> wrote: > On 02/05/18 22:36, Timothy Arceri wrote: >> >> On 02/05/18 21:48, Grazvydas Ignotas wrote: >>> >>> On Wed, May 2, 2018 at 1:27 PM, Timothy Arceri <tarc...@itsqueeze.com> >

Re: [Mesa-dev] [PATCH v2 1/3] mesa: actually support compat profile creation with MESA_GL_VERSION_OVERRIDE

On Wed, May 2, 2018 at 1:27 PM, Timothy Arceri wrote: > --- > src/mesa/drivers/dri/common/dri_util.c | 9 + > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/src/mesa/drivers/dri/common/dri_util.c > b/src/mesa/drivers/dri/common/dri_util.c > index

Re: [Mesa-dev] [PATCH] radv/winsys: allow to submit up to 4 IBs for chips without chaining

On Fri, Apr 20, 2018 at 3:21 PM, Samuel Pitoiset wrote: > The SI family doesn't support chaining which means the maximum > size in dwords per CS is limited. When that limit was reached > we failed to submit the CS and the application crashed. > > This patch allows to

Re: [Mesa-dev] [PATCH 4/4] radv: implement VK_AMD_shader_core_properties

On Fri, Apr 6, 2018 at 3:28 PM, Samuel Pitoiset wrote: > Simple extension that only returns information for AMD hw. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_device.c | 71 > +++

[Mesa-dev] [PATCH 1/2] radv: fix stale comment in generated vk_format_table.c

It seems to be a leftover from u_format_table.py. --- src/amd/vulkan/vk_format_table.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/amd/vulkan/vk_format_table.py b/src/amd/vulkan/vk_format_table.py index 36352b1..c33a4ce 100644 --- a/src/amd/vulkan/vk_format_table.py

[Mesa-dev] [PATCH 2/2] radv: make vk_format_description structures static

No need to bother the linker about them. --- src/amd/vulkan/vk_format_table.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/amd/vulkan/vk_format_table.py b/src/amd/vulkan/vk_format_table.py index c33a4ce..cd1af62 100644 --- a/src/amd/vulkan/vk_format_table.py +++

Re: [Mesa-dev] [PATCH] radv: Really use correct HTILE expanded words.

Seems to fix dxvk, nice! Also tested DOOM which still works. Tested-by: Grazvydas Ignotas <nota...@gmail.com> On Thu, Feb 22, 2018 at 6:57 PM, James Legg <jl...@feralinteractive.com> wrote: > When transitioning to an htile compressed depth format, Set the full > dep

Re: [Mesa-dev] [PATCH] intel/compiler: fix 64bit value prints on 32bit

ping On Sun, Feb 4, 2018 at 12:19 AM, Grazvydas Ignotas <nota...@gmail.com> wrote: > Fix the following: > warning: format ‘%lx’ expects argument of type ‘long unsigned int’, but > argument 3 has type ‘uint64_t {aka long long unsigned int}. > --- > src/intel/

Re: [Mesa-dev] [PATCH] i965: perf: ensure reading config IDs from sysfs isn't interrupted

Is this really sufficient? From what I read in the manpage, you can get an incomplete read instead when a signal arrives. Gražvydas On Fri, Feb 9, 2018 at 12:03 PM, Lionel Landwerlin wrote: > Fixes: 458468c136e "i965: Expose OA counters via

Re: [Mesa-dev] [PATCH] radeonsi: set indent_size in .editorconfig

On Tue, Feb 6, 2018 at 1:37 PM, Eric Engestrom <eric.engest...@imgtec.com> wrote: > On Sunday, 2018-02-04 00:19:33 +0200, Grazvydas Ignotas wrote: >> At least with vim, this is needed to actually get tab instead of >> 3 spaces after hitting the tab key. > > Are yo

[Mesa-dev] [PATCH] gallium/hud: update some query functions

It seems these were missed when struct pipe_context * argument was added to hud_graph::query_new_value. Fixes: 3132afdf4c "gallium/hud: pass pipe_context explicitly to most functions" --- src/gallium/auxiliary/hud/hud_cpufreq.c | 2 +- src/gallium/auxiliary/hud/hud_diskstat.c | 2 +-

[Mesa-dev] [PATCH] radeonsi: set indent_size in .editorconfig

At least with vim, this is needed to actually get tab instead of 3 spaces after hitting the tab key. --- src/gallium/drivers/radeonsi/.editorconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/radeonsi/.editorconfig b/src/gallium/drivers/radeonsi/.editorconfig index

[Mesa-dev] [PATCH] intel/compiler: fix 64bit value prints on 32bit

Fix the following: warning: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 3 has type ‘uint64_t {aka long long unsigned int}. --- src/intel/compiler/brw_disasm.c | 4 ++-- src/intel/compiler/brw_nir_analyze_ubo_ranges.c | 2 +- 2 files changed, 3

[Mesa-dev] [PATCH] radeonsi: avoid int-to-pointer-cast warnings on 32bit

I hope the actual dropping of MSB is ok, but that's what's already happened before this change. --- src/gallium/drivers/radeonsi/si_descriptors.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_descriptors.c

[Mesa-dev] [PATCH] anv: correct a duplicate check in an assert

Looks like checking both sources was intended, instead of the first one twice. Found with Coccinelle, coccinellery/xand/xand.cocci semantic patch. Signed-off-by: Grazvydas Ignotas <nota...@gmail.com> --- src/intel/vulkan/anv_nir_apply_pipeline_layout.c | 2 +- 1 file changed, 1 insertion

[Mesa-dev] [PATCH 1/2] svga: fix context alloc error handling

'cleanup' path is dereferencing 'svga' a lot, 'done' is a better choice. Found by Coccinelle. Signed-off-by: Grazvydas Ignotas <nota...@gmail.com> --- src/gallium/drivers/svga/svga_context.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/driver

[Mesa-dev] [PATCH 2/2] winsys/svga: check correct member after create

.mob_fenced was already checked, probably a copy-paste bug. Found by Coccinelle. Signed-off-by: Grazvydas Ignotas <nota...@gmail.com> --- src/gallium/winsys/svga/drm/vmw_screen_pools.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/winsys/sv

Re: [Mesa-dev] [PATCH 2/2] st/vdpau: release held lock in error path

Anyone cares about vdpau? Gražvydas On Tue, Jan 16, 2018 at 12:03 AM, Grazvydas Ignotas <nota...@gmail.com> wrote: > Signed-off-by: Grazvydas Ignotas <nota...@gmail.com> > --- > src/gallium/state_trackers/vdpau/surface.c | 4 +++- > 1 file changed, 3 insertions(+), 1 de

Re: [Mesa-dev] [PATCH 1/2] st/va: release held locks in error paths

istian. > > > Am 15.01.2018 um 23:03 schrieb Grazvydas Ignotas: >> >> Found with the help of following Coccinelle semantic patch: >> // >> @@ >> expression E; >> @@ >> >>\(pthread_mutex_lock\|mtx_lock\|simple_mtx_l

[Mesa-dev] [PATCH 2/2] st/vdpau: release held lock in error path

Signed-off-by: Grazvydas Ignotas <nota...@gmail.com> --- src/gallium/state_trackers/vdpau/surface.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/vdpau/surface.c b/src/gallium/state_trackers/vdpau/surface.c index c678eb7..012d303

[Mesa-dev] [PATCH 1/2] st/va: release held locks in error paths

-by: Grazvydas Ignotas <nota...@gmail.com> --- src/gallium/state_trackers/va/config.c | 4 +++- src/gallium/state_trackers/va/image.c | 4 +++- src/gallium/state_trackers/va/picture.c | 4 +++- 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/gallium/state_trackers/va/config.c

[Mesa-dev] [PATCH] radeon: remove unneeded semicolons

Trivial. Found by Coccinelle. --- src/gallium/drivers/radeon/radeon_vcn_dec.c | 6 +++--- src/mesa/drivers/dri/radeon/radeon_debug.c | 2 +- src/mesa/drivers/dri/radeon/radeon_state_init.c | 2 +- src/mesa/drivers/dri/radeon/radeon_swtcl.c | 2 +- 4 files changed, 6 insertions(+), 6

[Mesa-dev] [PATCH] mesa: remove unneeded semicolons

Trivial. Found by Coccinelle. --- src/gbm/backends/dri/gbm_dri.c | 2 +- src/mesa/main/dlist.c| 2 +- src/mesa/main/program_resource.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/gbm/backends/dri/gbm_dri.c b/src/gbm/backends/dri/gbm_dri.c index

[Mesa-dev] [PATCH] osmesa: don't check SmoothFlag twice

Trivial. Found by Coccinelle. --- src/mesa/drivers/osmesa/osmesa.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/mesa/drivers/osmesa/osmesa.c b/src/mesa/drivers/osmesa/osmesa.c index 1df3da4..e0f87b8 100644 --- a/src/mesa/drivers/osmesa/osmesa.c +++ b/src/mesa/drivers/osmesa/osmesa.c @@

Re: [Mesa-dev] [PATCH 1/2] amd/common: import get_{load, store}_intr_attribs() from RadeonSI

On Wed, Jan 10, 2018 at 1:57 PM, Samuel Pitoiset wrote: > Signed-off-by: Samuel Pitoiset > --- > src/amd/common/ac_llvm_build.c| 12 ++- > src/amd/common/ac_llvm_util.c | 18 >

[Mesa-dev] [PATCH v2 1/3] util/crc32: don't drop the const qualifier

Signed-off-by: Grazvydas Ignotas <nota...@gmail.com> --- src/util/crc32.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/crc32.c b/src/util/crc32.c index 44d637c..f2e01c6 100644 --- a/src/util/crc32.c +++ b/src/util/crc32.c @@ -109,11 +109,11 @@ util_crc32_tab

[Mesa-dev] [PATCH v2 2/3] android, configure, meson: define HAVE_ZLIB

The next change wants to use some optional zlib functionality, however not all platforms currently use it. Based on earlier Jordan Justen's patches and their review feedback. Signed-off-by: Grazvydas Ignotas <nota...@gmail.com> --- Android.common.mk | 1 + configure.ac | 1 + meson

[Mesa-dev] [PATCH v2 3/3] util: use faster zlib's CRC32 implementaion

mesa zlibmesa zlib 443 1443 225% +/- 2.1% 403 1175 191% +/- 0.9% It has been verified the calculation results stay the same after this change. Signed-off-by: Grazvydas Ignotas <nota...@gmail.com> --- v2: drop the size threshold check because size is unlikely to be th

Re: [Mesa-dev] [PATCH 3/3] util: use zlib's CRC32 implementaion for larger buffers

On Wed, Jan 3, 2018 at 3:09 AM, Ian Romanick <i...@freedesktop.org> wrote: > On 01/02/2018 04:52 PM, Grazvydas Ignotas wrote: >> On Tue, Jan 2, 2018 at 11:38 PM, Ian Romanick <i...@freedesktop.org> wrote: >>> On 12/28/2017 05:56 PM, Grazvydas Ignotas wrote: >>

Re: [Mesa-dev] [PATCH 3/3] util: use zlib's CRC32 implementaion for larger buffers

On Tue, Jan 2, 2018 at 11:38 PM, Ian Romanick <i...@freedesktop.org> wrote: > On 12/28/2017 05:56 PM, Grazvydas Ignotas wrote: >> zlib provides a faster slice-by-4 CRC32 implementation than the >> traditional single byte lookup one used by mesa. As most supported >&

Re: [Mesa-dev] [PATCH 1/3] spirv: Add a mechanism for dumping failing shaders

On Tue, Jan 2, 2018 at 6:30 PM, Jason Ekstrand wrote: > --- > src/compiler/spirv/spirv_to_nir.c | 29 + > src/compiler/spirv/vtn_private.h | 1 + > 2 files changed, 30 insertions(+) > > diff --git a/src/compiler/spirv/spirv_to_nir.c >

Re: [Mesa-dev] [PATCH 3/8] spirv: Add basic type validation for OpLoad, OpStore, and OpCopyMemory

Hi, I don't know if it's the game's fault, but it appears this change broke DOOM. here is the offending spirv binary: https://people.freedesktop.org/~notaz/doom_compute_spirv Gražvydas On Thu, Dec 7, 2017 at 6:12 PM, Jason Ekstrand wrote: > --- >

[Mesa-dev] [PATCH 3/3] util: use zlib's CRC32 implementaion for larger buffers

-by: Grazvydas Ignotas <nota...@gmail.com> --- src/util/crc32.c | 13 + 1 file changed, 13 insertions(+) diff --git a/src/util/crc32.c b/src/util/crc32.c index f2e01c6..0cffa49 100644 --- a/src/util/crc32.c +++ b/src/util/crc32.c @@ -31,12 +31,20 @@ * * @author Jose F

[Mesa-dev] [PATCH 1/3] android,configure,meson: define HAVE_ZLIB

The next change wants to use some optional zlib functionality, however not all platforms currently use zlib. Based on earlier Jordan Justen's patches and their review feedback. Signed-off-by: Grazvydas Ignotas <nota...@gmail.com> --- Android.common.mk | 1 + configure.ac | 1 + meson

[Mesa-dev] [PATCH 2/3] util/crc32: don't drop the const qualifier

Signed-off-by: Grazvydas Ignotas <nota...@gmail.com> --- src/util/crc32.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/crc32.c b/src/util/crc32.c index 44d637c..f2e01c6 100644 --- a/src/util/crc32.c +++ b/src/util/crc32.c @@ -109,11 +109,11 @@ util_crc32_tab

Re: [Mesa-dev] [PATCH 00/28] vulkan/wsi: Rework WSI to look a lot more like a layer

On Wed, Nov 22, 2017 at 7:54 AM, Jason Ekstrand <ja...@jlekstrand.net> wrote: > On Tue, Nov 21, 2017 at 1:21 PM, Grazvydas Ignotas <nota...@gmail.com> > wrote: >> >> On Mon, Nov 20, 2017 at 6:08 PM, Jason Ekstrand <ja...@jlekstrand.net> >> wrote: >&

Re: [Mesa-dev] [PATCH 00/28] vulkan/wsi: Rework WSI to look a lot more like a layer

On Mon, Nov 20, 2017 at 6:08 PM, Jason Ekstrand <ja...@jlekstrand.net> wrote: > On Sun, Nov 19, 2017 at 5:07 AM, Grazvydas Ignotas <nota...@gmail.com> > wrote: >> >> On Sun, Nov 19, 2017 at 1:51 AM, Jason Ekstrand <ja...@jlekstrand.net> >> wrote:

Re: [Mesa-dev] [PATCH 00/28] vulkan/wsi: Rework WSI to look a lot more like a layer

On Sun, Nov 19, 2017 at 1:51 AM, Jason Ekstrand <ja...@jlekstrand.net> wrote: > On Sat, Nov 18, 2017 at 9:02 AM, Grazvydas Ignotas <nota...@gmail.com> > wrote: >> >> On Sat, Nov 18, 2017 at 3:06 AM, Jason Ekstrand <ja...@jlekstrand.net> >> wrote: >&

Re: [Mesa-dev] [PATCH 00/28] vulkan/wsi: Rework WSI to look a lot more like a layer

On Sat, Nov 18, 2017 at 3:06 AM, Jason Ekstrand <ja...@jlekstrand.net> wrote: > On Fri, Nov 17, 2017 at 2:18 PM, Grazvydas Ignotas <nota...@gmail.com> > wrote: >> >> I've tested this branch (rx470 + hd530) and it's only partially working: >> - display on amd

Re: [Mesa-dev] [PATCH 00/28] vulkan/wsi: Rework WSI to look a lot more like a layer

I've tested this branch (rx470 + hd530) and it's only partially working: - display on amd, radv: always fails with "offscreen: wsi/wsi_common.c:172: select_memory_type: Assertion `!"No memory type found"' failed." - display on amd, anv: misrenders. For SaschaWillems, only multisampling, subpasses

Re: [Mesa-dev] [PATCH 3/3] RFC: vulkan/wsi: Rework the way prime support works

On Thu, Nov 16, 2017 at 12:33 AM, Dave Airlie wrote: > On 15 November 2017 at 04:40, Jason Ekstrand wrote: >> This commit significantly reworks the way prime support works and lets >> us pull it even further into radv. The old mechanism required the >>

Re: [Mesa-dev] [PATCH v3 32/34] disk_cache: Fix issue reading GLSL metadata

On Tue, Oct 31, 2017 at 12:54 AM, Kenneth Graunke wrote: > On Sunday, October 22, 2017 1:01:40 PM PDT Jordan Justen wrote: >> This would cause the read of the metadata content to fail, which would >> prevent the linking from being skipped. >> >> Seen on Rocket League with

Re: [Mesa-dev] [PATCH 5/7] u_queue: add a futex-based implementation of fences

On Mon, Oct 23, 2017 at 4:04 PM, Nicolai Hähnle <nicolai.haeh...@amd.com> wrote: > On 23.10.2017 13:50, Grazvydas Ignotas wrote: >> >> On Sun, Oct 22, 2017 at 9:33 PM, Nicolai Hähnle <nhaeh...@gmail.com> >> wrote: >>> >>> From: Nicolai Hähnle

Re: [Mesa-dev] [PATCH 7/7] radeonsi: reduce the scope of sel->mutex in si_shader_select_with_key

On Sun, Oct 22, 2017 at 9:33 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > We only need the lock to guard changes in the variant linked list. The > actual compilation can happen outside the lock, since we use the ready > fence as a guard. > ---

Re: [Mesa-dev] [PATCH 5/7] u_queue: add a futex-based implementation of fences

On Sun, Oct 22, 2017 at 9:33 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > Fences are now 4 bytes instead of 96 bytes (on my 64-bit system). > > Signaling a fence is a single atomic operation in the fast case plus a > syscall in the slow case.

Re: [Mesa-dev] [PATCH 1/2] configure: check if -latomic is needed for __atomic_*

On Tue, Sep 19, 2017 at 2:04 PM, Emil Velikov <emil.l.veli...@gmail.com> wrote: > On 19 September 2017 at 10:12, Grazvydas Ignotas <nota...@gmail.com> wrote: >> On Mon, Sep 18, 2017 at 11:30 PM, Matt Turner <matts...@gmail.com> wrote: >>> On Mon, Sep 18, 2017

Re: [Mesa-dev] [PATCH 1/2] configure: check if -latomic is needed for __atomic_*

On Mon, Sep 18, 2017 at 11:30 PM, Matt Turner <matts...@gmail.com> wrote: > On Mon, Sep 18, 2017 at 12:28 PM, Grazvydas Ignotas <nota...@gmail.com> wrote: >> On some platforms, gcc generates library calls when __atomic_* functions >> are used, but does not link the req

Re: [Mesa-dev] [PATCH] r600: fork and import gallium/radeon

Has anyone ran full piglit on these with r600? Copy-paste bugs are very easy to introduce. Gražvydas On Mon, Sep 18, 2017 at 7:32 PM, Marek Olšák wrote: > Latest version with an updated commit message: >

[Mesa-dev] [PATCH 2/2] util/u_atomic: remove unnecessaty __atomic functions

They are now provided by -latomic, which should be linked as needed since previous commit. Signed-off-by: Grazvydas Ignotas <nota...@gmail.com> --- src/util/u_atomic.c | 12 1 file changed, 12 deletions(-) diff --git a/src/util/u_atomic.c b/src/util/u_atomic.c index b

[Mesa-dev] [PATCH 1/2] configure: check if -latomic is needed for __atomic_*

;util: use GCC atomic intrinsics with explicit memory model" Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102573 Signed-off-by: Grazvydas Ignotas <nota...@gmail.com> --- configure.ac | 13 + src/util/Makefile.am | 3 ++- 2 files changed, 15 insertions(+), 1 d

Re: [Mesa-dev] [PATCH 2/2] util/u_atomic: Add implementation of __sync_val_compare_and_swap_8

On Fri, Sep 15, 2017 at 12:04 PM, Grazvydas Ignotas <nota...@gmail.com> wrote: > It was because on some platforms ./configure test looking for > __atomic_* passes because it's a compile (not link) test, even when > the compiler inserts library calls instead of actual implementat

Re: [Mesa-dev] [PATCH 2/2] util/u_atomic: Add implementation of __sync_val_compare_and_swap_8

It was because on some platforms ./configure test looking for __atomic_* passes because it's a compile (not link) test, even when the compiler inserts library calls instead of actual implementation. It looks like the correct solution is to link against libatomic (which I was not aware of at that

Re: [Mesa-dev] [PATCH] radv: initialize the trace BO to 0

Wouldn't it be better to set AMDGPU_GEM_CREATE_VRAM_CLEARED when creating the bo? That would need new RADEON_FLAG_* for winsys. If not, at least make 4096 a define to use for both ws->buffer_create() and memset. Gražvydas On Wed, Sep 13, 2017 at 12:26 PM, Samuel Pitoiset

[Mesa-dev] [PATCH] radv: clear dynamic_shader_stages on create

Valgrind reports it's being used uninitialized. Fixes: f4e499ec791 "radv: add initial non-conformant radv vulkan driver" Signed-off-by: Grazvydas Ignotas <nota...@gmail.com> --- src/amd/vulkan/radv_descriptor_set.c | 1 + 1 file changed, 1 insertion(+) diff --git

[Mesa-dev] [PATCH] radv: don't assert on empty hash table

ant radv vulkan driver" Signed-off-by: Grazvydas Ignotas <nota...@gmail.com> --- src/amd/vulkan/radv_pipeline_cache.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/amd/vulkan/radv_pipeline_cache.c b/src/amd/vulkan/radv_pipeline_cache.c index 99a614d..beed35b 1

[Mesa-dev] [PATCH] amd: add .editorconfig

amd/common/ and amd/vulkan/ are using tabs for indent, which doesn't match the settings in root .editorconfig, so let's override. Signed-off-by: Grazvydas Ignotas <nota...@gmail.com> --- src/amd/common/.editorconfig | 3 +++ src/amd/vulkan/.editorconfig | 3 +++ 2 files changed, 6 inse

[Mesa-dev] [PATCH] ac/nir: silence maybe-uninitialized warnings

These are likely false positives, but are also annoying because they show up on every "make install", which causes ac_nir_to_llvm to be rebuilt here. Initializing those variables to NULL should be harmless even when unnecessary. Signed-off-by: Grazvydas Ignotas <nota...@gmail.com&

Re: [Mesa-dev] [PATCH] configure: Trust LLVM >= 4.0 llvm-config --libs for shared libraries

On Tue, Aug 15, 2017 at 1:55 AM, Grazvydas Ignotas <nota...@gmail.com> wrote: > > Also, llvm-config --version says "6.0.0git-f49c401", which means I had > to manually hack configure.ac every time to "6.0.0svn" to get mesa > building too :( Nevermind about thi

Re: [Mesa-dev] [PATCH] configure: Trust LLVM >= 4.0 llvm-config --libs for shared libraries

On Mon, Aug 14, 2017 at 11:13 PM, Andy Furniss wrote: > Michel Dänzer wrote: >> >> On 11/08/17 01:45 AM, Emil Velikov wrote: >> >> Thanks, pushed. > > > Don't know if this is expected or not, but llvm built like - > > cmake -DCMAKE_INSTALL_PREFIX=/usr

Re: [Mesa-dev] [PATCH 2/2] i965: Guard GetBufferSubData's streaming memcpy load with USE_SSE41

On Fri, Aug 11, 2017 at 8:52 AM, Kenneth Graunke wrote: > This should hopefully fix build issues on 32-bit Android-x86. > > Cc: Mauro Rossi > Cc: Tapani Pälli > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102050 >

Re: [Mesa-dev] [PATCH 1/3] gallium/util: fix unused variable warning

FWIW: Reviewed-by: Grazvydas Ignotas <nota...@gmail.com> for all 3. On Thu, Jul 20, 2017 at 3:07 AM, Timothy Arceri <tarc...@itsqueeze.com> wrote: > --- > src/gallium/auxiliary/util/u_threaded_context.c | 8 +--- > 1 file changed, 5 insertions(+), 3 deletions(-) > &g

Re: [Mesa-dev] [PATCH v2] radv: Fix descriptors for cube images with VK_IMAGE_USAGE_STORAGE_BIT

On Fri, Jul 21, 2017 at 11:21 AM, Alex Smith wrote: > > I don't have Doom available to test. How's it broken? After the menu loads, it gets stuck flipping between some 2 (?) arbitrary frames than are no longer updating. > Could you see if removing the usage flags

Re: [Mesa-dev] [PATCH v2] radv: Fix descriptors for cube images with VK_IMAGE_USAGE_STORAGE_BIT

For whatever reason this patch is breaking DOOM. Gražvydas On Wed, Jul 12, 2017 at 12:29 PM, Alex Smith wrote: > If a cube image has VK_IMAGE_USAGE_STORAGE_BIT set, the type in an image > view's descriptor was set to a 2D array (and a few other fields adjusted >

Re: [Mesa-dev] [PATCH 8/9] anv: don't use strcpy for copying strings

On Thu, Jul 13, 2017 at 8:09 PM, Lionel Landwerlin wrote: > CID: 1358935 > Signed-off-by: Lionel Landwerlin > --- > src/intel/vulkan/anv_device.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git

Re: [Mesa-dev] [PATCH 07/10] util/u_queue: add an option to resize the queue when it's full

On Tue, Jul 11, 2017 at 12:21 AM, Marek Olšák wrote: > From: Marek Olšák > > Consider the following situation: > mtx_lock(mutex); > do_something(); > util_queue_add_job(...); > mtx_unlock(mutex); > > If the queue is full, util_queue_add_job will

Re: [Mesa-dev] [PATCH 2/2] ac/nir: Make intrinsic_name buffer long enough

USED int ret; ... ret = snprintf(intrinsic_name, ... assert(ret < sizeof(intrinsic_name)); In either case Reviewed-by: Grazvydas Ignotas <nota...@gmail.com> > --- > src/amd/common/ac_nir_to_llvm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/s

Re: [Mesa-dev] radeonsi: ppc64 glamor backtrace

Looks like nobody tested radeonsi on BE for 5 months at least. You can try the attached patch, but I suspect there will be other places like this... Gražvydas On Wed, Jun 21, 2017 at 3:26 PM, Jack Mitchell wrote: > Hi, > > I'm trying to run a VERDE based AMD card in a big

Re: [Mesa-dev] [PATCH] spirv: Work around the Doom shader bug

d this issue in yet another > application so I think we're stuck working around it. Hopefully, we can > delete this code one day. > > Cc: Dave Airlie <airl...@redhat.com> Yes please, would be one less patch to carry. I'd even vote for it to go to stable. Tested-by: Grazvyda

Re: [Mesa-dev] [PATCH mesa v2 1/2] egl/display: only detect the platform once

actually performed. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101252 > Fixes: 7adb9b094894a512c019 ("egl/display: remove unnecessary code and > make it easier to read") > Signed-off-by: Eric Engestrom <e...@engestrom.ch> &g

Re: [Mesa-dev] [PATCH mesa 2/2] egl/display: make platform detection thread-safe

to be discussed when this becomes possible. > > Reported-by: Grazvydas Ignotas <nota...@gmail.com> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=100877 > Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> It seems this has stalled. With the commit message up

Re: [Mesa-dev] [PATCH] mesa/util: add a hash table wrapper which support 64-bit keys

On Tue, Jun 13, 2017 at 10:58 AM, Samuel Pitoiset wrote: > Needed for bindless handles which are represented using > 64-bit unsigned integers. All hash table implementations should > be uniformized later on. > > Signed-off-by: Samuel Pitoiset

[Mesa-dev] [PATCH] radv: fix trace dumping for !use_ib_bos

Fixes trace dumping crash for SI or when RADV_DEBUG=noibs is set. Fixes: 97dfff5410 "radv: Dump command buffer on hang." Signed-off-by: Grazvydas Ignotas <nota...@gmail.com> --- Not sure if chained buffer dumping can be done for !use_ib_bos, returning NULL in _get_cpu_a

[Mesa-dev] [PATCH 2/2] radv: don't even attempt to prefetch on SI

/show_bug.cgi?id=101334 Fixes: bcae327469 "radv: realign cp dma code with radeonsi" Signed-off-by: Grazvydas Ignotas <nota...@gmail.com> --- src/amd/vulkan/radv_cmd_buffer.c | 23 --- 1 file changed, 16 insertions(+), 7 deletions(-) diff --git a/src/amd/vulkan/radv_cm

[Mesa-dev] [PATCH 1/2] radv: assert on CP_DMA_USE_L2 for SI

The register header (and radeonsi comment) states V_411_SRC_ADDR_TC_L2 is for CIK+ only, so let's assert on earlier ASICs. Signed-off-by: Grazvydas Ignotas <nota...@gmail.com> --- src/amd/vulkan/si_cmd_buffer.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/amd/vulkan/si_cmd_buff

Re: [Mesa-dev] [PATCH] nir: make various getters take const pointers

Ping. Boring patch, should be easy to review or NAK. On Wed, Jun 7, 2017 at 2:25 AM, Grazvydas Ignotas <nota...@gmail.com> wrote: > This will allow to constify other things. > > Signed-off-by: Grazvydas Ignotas <nota...@gmail.com> > --- > src/compi

[Mesa-dev] [PATCH 1/3] ac/nir: mark some arguments const

Most functions are only inspecting nir, so nir related arguments can be marked const. Some more can be done if/when some nir changes are accepted. Signed-off-by: Grazvydas Ignotas <nota...@gmail.com> --- does *not* depend on the nir patch src/amd/common/ac_nir_to_llvm.

[Mesa-dev] [PATCH 2/3] ac/nir: convert several ifs to a switch

Also solve "outinfo may be used uninitialized" warning by putting in an unreachable(). Signed-off-by: Grazvydas Ignotas <nota...@gmail.com> --- src/amd/common/ac_nir_to_llvm.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git

[Mesa-dev] [PATCH 3/3] radv/meta: remove an unused variable

Trivial. Signed-off-by: Grazvydas Ignotas <nota...@gmail.com> --- src/amd/vulkan/radv_meta_clear.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/amd/vulkan/radv_meta_clear.c b/src/amd/vulkan/radv_meta_clear.c index f4cb787..d7e7c5b 100644 --- a/src/amd/vulkan/radv_meta_clear.c +++

[Mesa-dev] [PATCH] nir: make various getters take const pointers

This will allow to constify other things. Signed-off-by: Grazvydas Ignotas <nota...@gmail.com> --- src/compiler/nir/nir.h | 25 + src/compiler/nir/nir_lower_io.c | 2 +- 2 files changed, 14 insertions(+), 13 deletions(-) diff --git a/src/compiler/nir/n

Re: [Mesa-dev] [PATCH 03/11] radeonsi: decrease the number of compiler threads to num CPUs - 1

With the "core wars" starting (16core/32thread "consumer" CPUs announced), maybe it's time to add an upper limit? Waking up a core from low power state has it's latency, it's sometimes faster to just do several jobs on an active core than to wake another one (which will also cause more lock

Re: [Mesa-dev] [PATCH mesa 2/2] egl/display: make platform detection thread-safe

On Thu, Jun 1, 2017 at 4:23 PM, Emil Velikov <emil.l.veli...@gmail.com> wrote: > Hi guys, > > On 1 June 2017 at 12:56, Grazvydas Ignotas <nota...@gmail.com> wrote: >> On Thu, Jun 1, 2017 at 2:15 PM, Eric Engestrom >> <eric.engest...@imgtec.com> wrote: >>

Re: [Mesa-dev] [PATCH mesa 2/2] egl/display: make platform detection thread-safe

to be discussed when this becomes possible. > > Reported-by: Grazvydas Ignotas <nota...@gmail.com> Not really, see https://bugs.freedesktop.org/show_bug.cgi?id=101252 > Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> > --- > > This is unnecessary in my o

[Mesa-dev] [PATCH] Revert "egl/display: remove unnecessary code and make it easier to read"

e_platform' as soon as it's not _EGL_INVALID_PLATFORM, it should not cause problems in practice. Cc: Eric Engestrom <eric.engest...@imgtec.com> Fixes: 7adb9b0948 "egl/display: remove unnecessary code and make it easier to read" Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=10125

Re: [Mesa-dev] [PATCH 1/9] util: Add a string buffer implementation

On Sun, May 21, 2017 at 11:49 PM, Thomas Helland wrote: > Based on Vladislav Egorov's work on the preprocessor, but split > out to a util functionality that should be universal. Setup, teardown, > memory handling and general layout is modeled around the hash_table > and

  1   2   3   4   >