Re: Mesa >= 23.3.x and python 2.6 ...

2024-01-21 Thread Jordan Justen
I dropped dri-devel from this reply. On 2024-01-20 05:56:23, Stefan Dirsch wrote: > Hi Jordan > > On Sat, Jan 20, 2024 at 01:47:58AM -0800, Jordan Justen wrote: > > > > It was "fun" finding a way to get python 3.6 :), but after that, I > > think I found a

Re: Mesa >= 23.3.x and python 2.6 ...

2024-01-20 Thread Jordan Justen
On 2024-01-19 12:24:24, Stefan Dirsch wrote: > Hi Jordan > > Thanks for digging into this! > > On Fri, Jan 19, 2024 at 12:10:37PM -0800, Jordan Justen wrote: > > On 2024-01-18 04:37:52, Stefan Dirsch wrote: > > > Hi > > > > > > I noticed that

Re: Mesa >= 23.3.x and python 2.6 ...

2024-01-19 Thread Jordan Justen
On 2024-01-18 04:37:52, Stefan Dirsch wrote: > Hi > > I noticed that with version 23.3.x Mesa no longer can be built with python > 2.6. It still worked with Mesa 23.2.1. As mentioned in other emails, this was typo where 3.6 was intended. > > It fails with > > [ 95s] Traceback (most recent

Re: [PATCH v2 01/12] drm/doc: add rfc section for small BAR uapi

2022-06-21 Thread Jordan Justen
Include newer integrated platforms when applying the non-recoverable > > context and error capture restriction. (Thomas) > > > > Signed-off-by: Matthew Auld > > Cc: Thomas Hellström > > Cc: Lionel Landwerlin > > Cc: Tvrtko Ursulin > > Cc: Jon B

Re: [PATCH v3] uapi/drm/i915: Document memory residency and Flat-CCS capability of obj

2022-05-16 Thread Jordan Justen
On 2022-05-16 00:47:43, Lionel Landwerlin wrote: > On 14/05/2022 00:06, Jordan Justen wrote: >> >> Acked-by: Jordan Justen >> >> I think Nanley has accounted for this on iris with: >> >> >> https://gitlab.freedesktop.org/mesa/mesa/-/co

Re: [PATCH v3] uapi/drm/i915: Document memory residency and Flat-CCS capability of obj

2022-05-13 Thread Jordan Justen
cc: Lionel Landwerlin > > cc: Kenneth Graunke > > cc: mesa-dev@lists.freedesktop.org > > cc: Jordan Justen > > cc: Tony Ye > > Reviewed-by: Matthew Auld > > --- > > include/uapi/drm/i915_drm.h | 16 > > 1 file changed

Re: [PATCH v8 5/5] drm/i915/uapi: document behaviour for DG2 64K support

2022-02-18 Thread Jordan Justen
Ramalingam C writes: > On 2022-02-18 at 18:06:00 +, Robert Beckett wrote: >> >> If desired, we can make the wording clearer, maybe something like: >> >> "To keep things simple for userland, we mandate that any GTT mappings >> must be aligned to 2MB. The kernel will internally pad them out

Re: [PATCH v8 5/5] drm/i915/uapi: document behaviour for DG2 64K support

2022-02-17 Thread Jordan Justen
3: fix typos and less emphasis > v2: Fixed suggestions on formatting [Daniel] > > Signed-off-by: Matthew Auld > Signed-off-by: Ramalingam C > Signed-off-by: Robert Beckett > Acked-by: Jordan Justen > Reviewed-by: Ramalingam C > Reviewed-by: Thomas Hellström > cc: Simon Ser

Re: [PATCH v2 4/4] drm/i915/uapi: document behaviour for DG2 64K support

2022-01-19 Thread Jordan Justen
v2: Fixed suggestions on formatting [Daniel] > > Signed-off-by: Matthew Auld > Signed-off-by: Ramalingam C > Signed-off-by: Robert Beckett > cc: Simon Ser > cc: Pekka Paalanen > Cc: Jordan Justen > Cc: Kenneth Graunke > Cc: mesa-dev@lists.freedesktop.org > Cc: Tony Ye

Re: [Mesa-dev] Workflow Proposal

2021-10-18 Thread Jordan Justen
Daniel Stone writes: > On Wed, 13 Oct 2021 at 20:13, Jordan Justen wrote: >> Alyssa Rosenzweig writes: >> > >> > Sorry, I'll make that point more emphatic. >> > >> > Upstream must do what's best for upstream without zero regard for the >>

Re: [Mesa-dev] Workflow Proposal

2021-10-13 Thread Jordan Justen
Alyssa Rosenzweig writes: >> Upstream should do what's best for upstream, not for Intel's "unique" >> management. >> >>Not sure how from Emma explaining how Rb tags were used by Intel >>management it came the conclusion that it were used in that way only by >>Intel management.

Re: [Mesa-dev] Workflow Proposal

2021-10-06 Thread Jordan Justen
Bas Nieuwenhuizen writes: > On Wed, Oct 6, 2021 at 8:49 PM Jordan Justen > wrote: >> >> I guess I missed where it was suggested that Marge should remove >> Reviewed-by tags. I don't think Marge should ever remove something from >> the commit message. > > A

Re: [Mesa-dev] Workflow Proposal

2021-10-06 Thread Jordan Justen
Mike Blumenkrantz writes: > On Wed, Oct 6, 2021 at 1:27 PM Bas Nieuwenhuizen > wrote: > >> On Wed, Oct 6, 2021 at 7:07 PM Jason Ekstrand >> wrote: >> > >> > My primary grip with approvals or the  button is that it's the wrong >> > granularity. It's per-MR instead of per-patch. When people

[Mesa-dev] NOTICE! Renaming Mesa "master" branch to "main" tomorrow

2021-05-04 Thread Jordan Justen
We plan to proceed with the branch rename tomorrow mid-day (US Pacific time) tomorrow, May 5. If all goes well, this MR will merge, https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10474 and the master branch will be locked from further changes. The main branch will then be created

Re: [Mesa-dev] Rename "master" branch to "main"?

2021-04-29 Thread Jordan Justen
On 2021-03-25 08:11:45, Jason Ekstrand wrote: > On Thu, Mar 25, 2021 at 9:41 AM Rob Clark wrote: > > > > yeah, I meant to convert a repo w/ more MRs than 7 but less than mesa > > using the script to beta test that, wasn't suggesting to do it by hand > > Plan is to convert piglit next. It's

[Mesa-dev] piglit default main branch results - Re: Rename "master" branch to "main"?

2021-03-29 Thread Jordan Justen
On 2021-03-24 23:47:46, Jordan Justen wrote: > On 2021-03-24 21:14:57, Jason Ekstrand wrote: > > > > Jordan, is there any way you can make the script sort by last updated > > before it > > re-targets the MRs so they at least stay in the same order? Updating them >

Re: [Mesa-dev] Rename "master" branch to "main"?

2021-03-25 Thread Jordan Justen
On 2021-03-24 21:14:57, Jason Ekstrand wrote: > > Jordan, is there any way you can make the script sort by last updated before > it > re-targets the MRs so they at least stay in the same order? Updating them in > MR > # order wouldn't be bad either, I guess. > It already does process them

Re: [Mesa-dev] Rename "master" branch to "main"?

2021-03-24 Thread Jordan Justen
On 2021-03-23 09:38:59, Eric Anholt wrote: > On Tue, Mar 23, 2021 at 7:02 AM Jason Ekstrand wrote: > > > > Trying to pick this discussion back up. Daniel Stone thinks it's a > > half hour of API bashing to retarget all the MRs so, if the fd.o > > admins have some heads up, it should be

Re: [Mesa-dev] fp/int64 on gen11/12?

2020-11-17 Thread Jordan Justen
On 2020-11-17 16:03:31, Brian Paul wrote: > Another Intel question: It looks like gen11/gen12 don't have fp/int64 > enabled in the Vulkan driver. From gen_device_info.c: > > #define GEN11_FEATURES(_gt, _slices, _subslices, _l3) \ > GEN8_FEATURES, \ >

Re: [Mesa-dev] [PATCH] mesa: save/restore SSO flag when using ARB_get_program_binary

2019-07-11 Thread Jordan Justen
Reviewed-by: Jordan Justen On 2019-07-10 17:39:24, Timothy Arceri wrote: > Ping! The spec bug was updated and they have agreed to update the spec > to define this behavior. > > I've also sent a piglit test for this: > > https://patchwork.freedesktop.org/patch/317112/ >

Re: [Mesa-dev] [Intel-gfx] [PATCH 2/3] iris: Create a composite context for both compute and render pipelines

2019-03-31 Thread Jordan Justen
On 2019-03-31 03:02:21, Chris Wilson wrote: > Quoting Jordan Justen (2019-03-31 10:57:09) > > On 2019-03-25 03:58:59, Chris Wilson wrote: > > > iris currently uses two distinct GEM contexts to have distinct logical > > > HW contexts for the compute and render pi

Re: [Mesa-dev] [Intel-gfx] [PATCH 2/3] iris: Create a composite context for both compute and render pipelines

2019-03-31 Thread Jordan Justen
On 2019-03-25 03:58:59, Chris Wilson wrote: > iris currently uses two distinct GEM contexts to have distinct logical > HW contexts for the compute and render pipelines. However, using two > distinct GEM contexts implies that they are distinct timelines, yet as > they are a single GL context that

Re: [Mesa-dev] [PATCH 1/3] drm-uapi: Pull i915_drm.h changes for context cloning

2019-03-31 Thread Jordan Justen
Where are these changes from (repo/commit)? It could be good to reference in the commit message. I suspect that the answer might mean that these patches should be labeled RFC. -Jordan On 2019-03-25 03:58:58, Chris Wilson wrote: > For use in GPU recovery and pipeline construction. > --- >

Re: [Mesa-dev] [PATCH] android, autotools: st/mesa: fix location of float64_glsl.h

2019-03-06 Thread Jordan Justen
On 2019-03-04 16:11:33, Jordan Justen wrote: > On 2019-03-04 15:21:26, Mauro Rossi wrote: > > Hi, > > On Mon, Mar 4, 2019 at 7:50 PM Mauro Rossi wrote: > > > > > > Il lun 4 mar 2019, 18:59 Dylan Baker ha scritto: > > >> > > >> I wrote c81

Re: [Mesa-dev] [PATCH] android, autotools: st/mesa: fix location of float64_glsl.h

2019-03-04 Thread Jordan Justen
On 2019-03-04 15:21:26, Mauro Rossi wrote: > Hi, > On Mon, Mar 4, 2019 at 7:50 PM Mauro Rossi wrote: > > > > Il lun 4 mar 2019, 18:59 Dylan Baker ha scritto: > >> > >> I wrote c812, and I'd be very happy to revert it. The problem that I ran > >> into > >> was putting it in a place that android,

[Mesa-dev] Should piglit drop bugzilla and move to using gitlab issues?

2019-03-01 Thread Jordan Justen
I guess piglit makes very light usage of bugzilla. Would it be simpler to just use gitlab issues in the piglit gitlab project? -Jordan ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] Piglit gitlab merge requests enabled - Re: GitLab migration of Piglit

2019-03-01 Thread Jordan Justen
On 2019-02-20 07:36:48, Den wrote: > > Given the discussion below, I think we'll make piglit a sub-project of > > mesa.  Those who need commit access to piglit but not mesa can be > > added directly to the piglit project. > > Hi list. > > Since piglit was also moved to the gitlab, same with

Re: [Mesa-dev] [PATCH] docs: Document and *require* usage of Signed-off-by

2018-12-19 Thread Jordan Justen
*require* usage of Signed-off-by Make Signed-off-by required. So, bring your pitchforks, torches, NACKs and other implements of discussion to MR #31. :) -Jordan On 2018-11-27 23:20:22, Jordan Justen wrote: > This adds the "Developer's Certificate of Origin 1.1" from the Linux

Re: [Mesa-dev] [PATCH] genxml: Consistently use a numeric "MOCS" field

2018-12-11 Thread Jordan Justen
Reviewed-by: Jordan Justen On 2018-12-11 20:23:06, Kenneth Graunke wrote: > When we first started using genxml, we decided to represent MOCS as an > actual structure, and pack values. However, in many places, it was more > convenient to use a numeric value rather than treating it as

Re: [Mesa-dev] [PATCH v2] docs: Document GitLab merge request process (email alternative)

2018-12-06 Thread Jordan Justen
On 2018-12-06 13:57:09, Nicolai Hähnle wrote: > On 06.12.18 00:32, Jordan Justen wrote: > > + To participate in code review, you should monitor the > > + https://lists.freedesktop.org/mailman/listinfo/mesa-dev;> > > + mesa-dev email list and the GitLab &g

Re: [Mesa-dev] [PATCH v2] docs: Document GitLab merge request process (email alternative)

2018-12-05 Thread Jordan Justen
On 2018-12-05 15:44:18, Jason Ekstrand wrote: > On Wed, Dec 5, 2018 at 5:32 PM Jordan Justen > wrote: > > -Mailing Patches > > +Submitting Patches > > > > > > -Patches should be sent to the mesa-dev mailing list for review: > > +Patches may be s

[Mesa-dev] [PATCH v2] docs: Document GitLab merge request process (email alternative)

2018-12-05 Thread Jordan Justen
-dev email list. v2: * No longer require email. Allow submitter to choose email or a GitLab merge request. * Various feedback from Brian, Daniel, Dylan, Eric, Erik, Jason, Matt, Michel and Rob. Signed-off-by: Jordan Justen --- docs/submittingpatches.html | 76

Re: [Mesa-dev] Make Jordan an Owner of the mesa project?

2018-12-05 Thread Jordan Justen
On 2018-12-04 19:39:05, Jason Ekstrand wrote: > Given that everyone else has firmly ACKed, I'm going to click the button. > Congratulations, Jordan, you're now a mesa Owner! Thanks all! ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

[Mesa-dev] GitLab merge requests, discussion summary - Re: [PATCH] docs: Document optional GitLab code review process

2018-12-03 Thread Jordan Justen
seems to think it's reasonable to try to jump straight to using merge requests exclusively, I can type that version up... -Jordan On 2018-11-27 17:13:38, Jordan Justen wrote: > This documents a mechanism for using GitLab Merge Requests as an > optional, secondary way to get code r

Re: [Mesa-dev] [PATCH] docs: Document and *require* usage of Signed-off-by

2018-11-30 Thread Jordan Justen
On 2018-11-29 15:53:09, Eric Anholt wrote: > e<#secure method=pgpmime mode=sign> > Erik Faye-Lund writes: > > > On Wed, 2018-11-28 at 13:43 -0800, Eric Anholt wrote: > >> Jordan Justen writes: > >> > >> > This adds the "Developer's Certif

Re: [Mesa-dev] [PATCH] docs: Document and *require* usage of Signed-off-by

2018-11-28 Thread Jordan Justen
On 2018-11-28 13:43:29, Eric Anholt wrote: > Jordan Justen writes: > > > This adds the "Developer's Certificate of Origin 1.1" from the Linux > > kernel. It indicates that by using Signed-off-by you are certifying > > that your patch meets the DCO 1.1 guidelin

Re: [Mesa-dev] [PATCH] docs: Document optional GitLab code review process

2018-11-28 Thread Jordan Justen
On 2018-11-28 10:14:49, Jason Ekstrand wrote: > On Wed, Nov 28, 2018 at 11:35 AM Jordan Justen > wrote: > > On 2018-11-28 06:59:42, Eric Engestrom wrote: > > > On Tuesday, 2018-11-27 19:45:50 -0800, Jordan Justen wrote: > > > > On 2018-

Re: [Mesa-dev] [PATCH] docs: Document optional GitLab code review process

2018-11-28 Thread Jordan Justen
On 2018-11-28 09:22:35, Dylan Baker wrote: > Quoting Matt Turner (2018-11-27 19:20:09) > > On Tue, Nov 27, 2018 at 5:13 PM Jordan Justen > > wrote: > > > > > > This documents a mechanism for using GitLab Merge Requests as an > > > optional, secon

Re: [Mesa-dev] [PATCH] docs: Document optional GitLab code review process

2018-11-28 Thread Jordan Justen
On 2018-11-28 06:59:42, Eric Engestrom wrote: > On Tuesday, 2018-11-27 19:45:50 -0800, Jordan Justen wrote: > > On 2018-11-27 19:20:09, Matt Turner wrote: > > > > > > Discussion point: I think attempting to have simultaneous review in > > > two places is a rec

Re: [Mesa-dev] [PATCH] docs: Document and *require* usage of Signed-off-by

2018-11-28 Thread Jordan Justen
On 2018-11-28 00:47:25, Erik Faye-Lund wrote: > On Tue, 2018-11-27 at 23:20 -0800, Jordan Justen wrote: > > This adds the "Developer's Certificate of Origin 1.1" from the Linux > > kernel. It indicates that by using Signed-off-by you are certifying > > that your pat

[Mesa-dev] [PATCH] docs: Document and *require* usage of Signed-off-by

2018-11-27 Thread Jordan Justen
This adds the "Developer's Certificate of Origin 1.1" from the Linux kernel. It indicates that by using Signed-off-by you are certifying that your patch meets the DCO 1.1 guidelines. It also changes Signed-off-by from being optional to being required. Signed-off-by: Jordan Justen

Re: [Mesa-dev] [PATCH] docs: Document the optional usage of Signed-off-by

2018-11-27 Thread Jordan Justen
On 2018-11-27 19:53:38, Matt Turner wrote: > On Tue, Nov 27, 2018 at 7:26 PM Jordan Justen > wrote: > > On 2018-11-27 18:04:17, Matt Turner wrote: > > > By all means, require it (with a git hook) if you like. > > > > I personally don't want to push for that r

Re: [Mesa-dev] [PATCH] docs: Document optional GitLab code review process

2018-11-27 Thread Jordan Justen
On 2018-11-27 19:20:09, Matt Turner wrote: > On Tue, Nov 27, 2018 at 5:13 PM Jordan Justen > wrote: > > > > This documents a mechanism for using GitLab Merge Requests as an > > optional, secondary way to get code reviews for patchsets. > > > > We sti

Re: [Mesa-dev] [PATCH] docs: Document the optional usage of Signed-off-by

2018-11-27 Thread Jordan Justen
On 2018-11-27 18:04:17, Matt Turner wrote: > On Tue, Nov 27, 2018 at 6:00 PM Jordan Justen > wrote: > > > > On 2018-11-27 17:17:15, Matt Turner wrote: > > > On Tue, Nov 27, 2018 at 5:13 PM Jordan Justen > > > wrote: > > > > > > > >

Re: [Mesa-dev] [PATCH] docs: Document the optional usage of Signed-off-by

2018-11-27 Thread Jordan Justen
On 2018-11-27 17:17:15, Matt Turner wrote: > On Tue, Nov 27, 2018 at 5:13 PM Jordan Justen > wrote: > > > > This adds the "Developer's Certificate of Origin 1.1" from the Linux > > kernel. It indicates that by using Signed-off-by you are certifying >

[Mesa-dev] [PATCH] docs: Document optional GitLab code review process

2018-11-27 Thread Jordan Justen
review. (Assuming it doesn't fall into the same fate of patchwork with hundreds of open MRs.) Signed-off-by: Jordan Justen Cc: Jason Ekstrand --- docs/submittingpatches.html | 25 + 1 file changed, 25 insertions(+) diff --git a/docs/submittingpatches.html b/docs

[Mesa-dev] [PATCH] docs: Document the optional usage of Signed-off-by

2018-11-27 Thread Jordan Justen
This adds the "Developer's Certificate of Origin 1.1" from the Linux kernel. It indicates that by using Signed-off-by you are certifying that your patch meets the DCO 1.1 guidelines. Signed-off-by: Jordan Justen Cc: Matt Turner --- docs/submittingpatches

[Mesa-dev] [PATCH 1/2] i965/genX_state: Add register access functions

2018-11-12 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/mesa/drivers/dri/i965/genX_state_upload.c | 31 +++ 1 file changed, 31 insertions(+) diff --git a/src/mesa/drivers/dri/i965/genX_state_upload.c b/src/mesa/drivers/dri/i965/genX_state_upload.c index 5acd0922922..6495862e700 100644 --- a/src

[Mesa-dev] [PATCH 2/2] i965/compute: Emit GPGPU_WALKER in genX_state_upload

2018-11-12 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/mesa/drivers/dri/i965/brw_compute.c | 131 +- src/mesa/drivers/dri/i965/brw_context.h | 2 + src/mesa/drivers/dri/i965/genX_state_upload.c | 102 ++ 3 files changed, 105 insertions(+), 130 deletions(-) diff --git

Re: [Mesa-dev] [PATCH v4 1/2] i965/batch: avoid reverting batch buffer if saved state is an empty

2018-11-05 Thread Jordan Justen
dded in to patch series > > v4: Fixed the regression which was introduced by this patch > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108630 > > Reported-by: Mark Janes > > The solution provided by: Jordan Justen > > > > CC: Chris

Re: [Mesa-dev] [PATCH 1/4] i965: Move some genX infrastructure to genX_boilerplate.h.

2018-11-02 Thread Jordan Justen
On 2018-11-01 20:04:18, Kenneth Graunke wrote: > This will let us make multiple genX_*.c files, without copy and pasting > all this boilerplate. > --- > src/mesa/drivers/dri/i965/Makefile.sources| 10 ++ > src/mesa/drivers/dri/i965/genX_boilerplate.h | 160 ++ >

Re: [Mesa-dev] [PATCH] intel: Use a URB start offset of 0 for disabled stages.

2018-11-02 Thread Jordan Justen
Reviewed-by: Jordan Justen On 2018-11-01 20:01:36, Kenneth Graunke wrote: > There are some cases where the VS is the only stage enabled, it uses the > entire URB, and the URB is large enough that placing later stages after > the VS exceeds the number of bits for "URB St

Re: [Mesa-dev] [PATCH v3 1/2] i965/batch: avoid reverting batch buffer if saved state is an empty

2018-10-30 Thread Jordan Justen
erting batch buffer if saved state is an empty -Jordan > > On Thu, Oct 11, 2018 at 9:22 PM Jordan Justen > wrote: > > > On 2018-10-11 03:01:56, andrey simiklit wrote: > > > Hello, > > > > > > Thanks for reviewing. > > > Please find my comment

Re: [Mesa-dev] [PATCH] i965: Add PCI IDs for new Amberlake parts that are Coffeelake based

2018-10-15 Thread Jordan Justen
Reviewed-by: Jordan Justen On 2018-10-15 16:05:39, Kenneth Graunke wrote: > See commit c0c46ca461f136a0ae1ed69da6c874e850aeeb53 in the Linux kernel, > where José Roberto de Souza added this new PCI ID there. > --- > include/pci_ids/i965_pci_ids.h | 5 +++-- > 1 file changed, 3 i

Re: [Mesa-dev] [PATCH v3 1/2] i965/batch: avoid reverting batch buffer if saved state is an empty

2018-10-11 Thread Jordan Justen
On 2018-10-11 03:01:56, andrey simiklit wrote: > Hello, > > Thanks for reviewing. > Please find my comment below. > > On Thu, Oct 11, 2018 at 12:37 AM Jordan Justen > wrote: > > > On 2018-09-12 09:05:44, wrote: > > > From: Andrii Simiklit > > &

Re: [Mesa-dev] [PATCH 1/2] anv/gen9+: Initialize new fields in STATE_BASE_ADDRESS

2018-10-10 Thread Jordan Justen
On 2018-10-10 14:38:23, Rafael Antognolli wrote: > On Wed, Oct 10, 2018 at 02:04:11PM -0700, Jordan Justen wrote: > > On 2018-10-10 13:45:13, Rafael Antognolli wrote: > > > On Wed, Oct 10, 2018 at 01:39:25PM -0700, Jordan Justen wrote: > > > > Ref: 263b584d5

Re: [Mesa-dev] [PATCH v3 1/2] i965/batch: avoid reverting batch buffer if saved state is an empty

2018-10-10 Thread Jordan Justen
chbuffer_require_space(brw, 1500); > brw_require_statebuffer_space(brw, 2400); > intel_batchbuffer_save_state(brw); > + fail_next = intel_batchbuffer_saved_state_is_empty(brw); It seems like this will cause the WARN_ONCE to be hit incorrectly. What about adding a 'bool empty_state',

Re: [Mesa-dev] [PATCH 1/2] anv/gen9+: Initialize new fields in STATE_BASE_ADDRESS

2018-10-10 Thread Jordan Justen
On 2018-10-10 13:45:13, Rafael Antognolli wrote: > On Wed, Oct 10, 2018 at 01:39:25PM -0700, Jordan Justen wrote: > > Ref: 263b584d5e4 "i965/skl: Emit extra zeros in STATE_BASE_ADDRESS on > > Skylake." > > Signed-off-by: Jordan Justen > > --- > &g

[Mesa-dev] [PATCH 1/2] anv/gen9+: Initialize new fields in STATE_BASE_ADDRESS

2018-10-10 Thread Jordan Justen
Ref: 263b584d5e4 "i965/skl: Emit extra zeros in STATE_BASE_ADDRESS on Skylake." Signed-off-by: Jordan Justen --- src/intel/vulkan/genX_cmd_buffer.c | 12 1 file changed, 12 insertions(+) diff --git a/src/intel/vulkan/genX_cmd_buffer.c b/src/intel/vulkan/genX_cmd_buff

[Mesa-dev] [PATCH 2/2] i965/gen10+: Initialize new fields in STATE_BASE_ADDRESS

2018-10-10 Thread Jordan Justen
Ref: 263b584d5e4 "i965/skl: Emit extra zeros in STATE_BASE_ADDRESS on Skylake." Signed-off-by: Jordan Justen --- src/mesa/drivers/dri/i965/brw_misc_state.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_misc_state.c b/src/mesa/d

[Mesa-dev] [PATCH 2/2] anv: If softpin is supported, use it with the hiz clear value bo

2018-09-25 Thread Jordan Justen
Signed-off-by: Jordan Justen Cc: Nanley Chery Cc: Jason Ekstrand --- src/intel/vulkan/anv_device.c | 9 + 1 file changed, 9 insertions(+) diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c index 265fc4a3347..4e64f595650 100644 --- a/src/intel/vulkan

[Mesa-dev] [PATCH 1/2] anv: s/batch/value_bo/ on anv_device_init_hiz_clear_batch

2018-09-25 Thread Jordan Justen
Signed-off-by: Jordan Justen Cc: Jason Ekstrand --- src/intel/vulkan/anv_device.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c index 4219a073d2d..265fc4a3347 100644 --- a/src/intel/vulkan/anv_device.c +++ b

Re: [Mesa-dev] [PATCH] anv: If softpin is supported, use it with hiz clear batch bo

2018-09-25 Thread Jordan Justen
On 2018-09-25 16:02:28, Nanley Chery wrote: > On Tue, Sep 25, 2018 at 03:22:11PM -0700, Jordan Justen wrote: > > Signed-off-by: Jordan Justen > > Cc: Nanley Chery > > --- > > src/intel/vulkan/anv_device.c | 9 + > > 1 file changed, 9 insertions(+) >

[Mesa-dev] [PATCH] anv: If softpin is supported, use it with hiz clear batch bo

2018-09-25 Thread Jordan Justen
Signed-off-by: Jordan Justen Cc: Nanley Chery --- src/intel/vulkan/anv_device.c | 9 + 1 file changed, 9 insertions(+) diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c index 0ea8be052fa..4e446c3280a 100644 --- a/src/intel/vulkan/anv_device.c +++ b/src/intel

Re: [Mesa-dev] [PATCH] i965: Don't bother to call blorp if the blit is zero-sized

2018-09-11 Thread Jordan Justen
Reviewed-by: Jordan Justen On 2018-09-11 09:15:38, Jason Ekstrand wrote: > Cc: mesa-sta...@lists.freedesktop.org > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107892 > --- > src/mesa/drivers/dri/i965/brw_meta_util.c | 3 +++ > 1 file changed, 3 insertions(+) >

Re: [Mesa-dev] [PATCH 2/2] intel/compiler: Add brw_get_compiler_config_value for disk cache

2018-08-02 Thread Jordan Justen
On 2018-08-02 11:27:57, Dylan Baker wrote: > Quoting Jordan Justen (2018-07-25 17:12:20) > > During code review, Jason pointed out that: > > > > 2b3064c0731 "i965, anv: Use INTEL_DEBUG for disk_cache driver flags" > > > > Didn't account for INTEL_SCAL

[Mesa-dev] [PATCH 2/2] intel/compiler: Add brw_get_compiler_config_value for disk cache

2018-07-25 Thread Jordan Justen
EL_SCALER_* into INTEL_DEBUG bits, but as we are currently using 41 of 64 bits, I didn't think it was a good use of 4 more of these bits. (5 since INTEL_PRECISE_TRIG needs to be accounted for as well.) Cc: Jason Ekstrand Signed-off-by: Jordan Justen --- src/intel/compiler/brw_compiler.c

[Mesa-dev] [PATCH 1/2] i965: Disable shader cache with INTEL_DEBUG=shader_time

2018-07-25 Thread Jordan Justen
, let's just disable the disk shader cache if the shader time debug feature is used. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106382 Fixes: 96fe36f7acc "i965: Enable disk shader cache by default" Cc: Eero Tamminen Cc: Kenneth Graunke Signed-off-by: Jordan Justen --- src/in

Re: [Mesa-dev] [PATCH mesa] docs: trivial html fix

2018-07-25 Thread Jordan Justen
You might as well add something like ">" => "" to the subject. Reviewed-by: Jordan Justen On 2018-07-25 12:18:34, Eric Engestrom wrote: > Signed-off-by: Eric Engestrom > --- > docs/releasing.html | 8 > 1 file changed, 4 insertions(+),

Re: [Mesa-dev] [PATCH] i965: Expose ARB_base_instance extension

2018-07-25 Thread Jordan Justen
I think the subject should include gles3: i965: Expose ARB_base_instance extension in OpenGL ES 3.0 Reviewed-by: Jordan Justen On 2018-07-25 10:48:31, Sagar Ghuge wrote: > The extension requires at least OpenGL 3.0 and > OpenGL ES 3.0. > > Fixes two ext_base_in

Re: [Mesa-dev] [PATCH v2 2/2] i965, anv: Use INTEL_DEBUG for disk_cache driver flags

2018-07-23 Thread Jordan Justen
> On 23.07.2018 07:27, Jordan Justen wrote: > > Since various options within INTEL_DEBUG could impact code generation, > > we need to set the disk cache driver_flags parameter based on the > > INTEL_DEBUG flags in use. > > > > An example that will affect the program gen

[Mesa-dev] [PATCH v2 2/2] i965, anv: Use INTEL_DEBUG for disk_cache driver flags

2018-07-22 Thread Jordan Justen
is added to mask the settings of INTEL_DEBUG that can affect program generation. v2: * Use driver_flags (Tim) * Also update Anvil (Jason) Signed-off-by: Jordan Justen Reviewed-by: Lionel Landwerlin (v1) --- src/intel/common/gen_debug.h | 5 + src/intel/vulkan/anv_device.c

[Mesa-dev] [PATCH v2 1/2] i965, anv: Add extra unused character in disk_cache renderer temp string

2018-07-22 Thread Jordan Justen
This extra character should not be used by snprintf, but we make it available to verify that we printed the exact number we wanted, and didn't overflow. v2: * Also update Anvil Signed-off-by: Jordan Justen Reviewed-by: Lionel Landwerlin (v1) --- src/intel/vulkan/anv_device.c | 4

Re: [Mesa-dev] [PATCH 2/2] i965/disk_cache: Add in the INTEL_DEBUG value to the renderer string

2018-07-22 Thread Jordan Justen
-Jordan > > On 22/07/18 05:45, Jordan Justen wrote: > > Since various options within INTEL_DEBUG could impact code generation, > > we should add this into the renderer string so changing the > > INTEL_DEBUG setting will cause the shader cache to work properly. &g

[Mesa-dev] [PATCH 2/2] i965/disk_cache: Add in the INTEL_DEBUG value to the renderer string

2018-07-21 Thread Jordan Justen
. Adding in the entire 64-bits of INTEL_DEBUG is overkill. Many INTEL_DEBUG options won't actually impact the program generated by the driver. Nevertheless, it is more maintainable and safer to just add the entire 64-bit value. Cc: Timothy Arceri Signed-off-by: Jordan Justen --- src/mesa/drivers/dri

[Mesa-dev] [PATCH 1/2] i965/disk_cache: Add extra unused character in renderer temp string

2018-07-21 Thread Jordan Justen
This extra character should not be used by snprintf, but we make it available to verify that we printed the exact number we wanted, and didn't overflow. Signed-off-by: Jordan Justen --- src/mesa/drivers/dri/i965/brw_disk_cache.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff

Re: [Mesa-dev] [PATCH v2 3/4] intel: tools: aubwrite: fix invalid frees on finish

2018-07-19 Thread Jordan Justen
Reviewed-by: Jordan Justen On 2018-07-18 10:21:31, Lionel Landwerlin wrote: > Signed-off-by: Lionel Landwerlin > --- > src/intel/tools/aub_write.c | 13 + > 1 file changed, 9 insertions(+), 4 deletions(-) > > diff --git a/src/intel/tools/aub_write.c b/src/intel

[Mesa-dev] [PATCH] intel/tools: fix segfault with intel_dump_gpu

2018-07-19 Thread Jordan Justen
Cc: Jason Ekstrand Cc: Lionel Landwerlin Fixes: 0a457d987ee "intel/tools: Refactor aub dumping to remove singletons" Signed-off-by: Jordan Justen --- src/intel/tools/intel_dump_gpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/tools/intel_dump_g

Re: [Mesa-dev] [PATCH v2] anv, radv: Add support for VK_KHR_get_display_properties2

2018-06-20 Thread Jordan Justen
features.txt? It looks like some others have been missed recently. -Jordan On 2018-06-20 08:07:20, Jason Ekstrand wrote: > Cc: Keith Packard > --- > src/amd/vulkan/radv_extensions.py | 1 + > src/amd/vulkan/radv_wsi_display.c | 57 + > src/intel/vulkan/anv_extensions.py | 1 +

Re: [Mesa-dev] [PATCH 00/16] Move the Mesa Website to Sphinx

2018-06-19 Thread Jordan Justen
On 2018-06-18 17:48:26, Ilia Mirkin wrote: > On Mon, Jun 18, 2018 at 7:19 PM, Jason Ekstrand wrote: > > On Mon, Jun 18, 2018 at 3:57 PM, Ilia Mirkin wrote: > >> > >> Not sure how much voting power I have, but I really like Erik's version at > >> > >> https://codepen.io/kusma/pen/vrXppL > >> > >>

Re: [Mesa-dev] [PATCH 00/16] Move the Mesa Website to Sphinx

2018-06-18 Thread Jordan Justen
On 2018-06-18 15:57:50, Ilia Mirkin wrote: > Not sure how much voting power I have, but I really like Erik's version at > > https://codepen.io/kusma/pen/vrXppL I think it's unfortunate that the logo says "3D Graphics Library", while simultaneously showing an image that couldn't look more 2D. :)

Re: [Mesa-dev] [PATCH 00/16] Move the Mesa Website to Sphinx

2018-06-17 Thread Jordan Justen
On 2018-06-17 17:43:37, Jason Ekstrand wrote: > On Sun, Jun 17, 2018 at 5:34 PM, Jordan Justen > wrote: > > > On 2018-06-17 16:42:13, Jason Ekstrand wrote: > > > On Sun, Jun 17, 2018 at 4:21 PM, Matt Turner wrote: > > > > > > > Also, Erik's is anim

Re: [Mesa-dev] [PATCH 00/16] Move the Mesa Website to Sphinx

2018-06-17 Thread Jordan Justen
On 2018-06-17 16:42:13, Jason Ekstrand wrote: > On Sun, Jun 17, 2018 at 4:21 PM, Matt Turner wrote: > > > Also, Erik's is animated not with JavaScript at all, but just CSS. > > That's really cool. > > > > The only thing the JS does is turn the animation on and off. The actual > animation is

Re: [Mesa-dev] [PATCH 00/16] Move the Mesa Website to Sphinx

2018-06-17 Thread Jordan Justen
On 2018-06-15 15:16:50, Laura Ekstrand wrote: > > We are now running on our own Docker image: > https://mesa-test.freedesktop.org/. > FWIW, I think the test site now looks better than mesa3d.org and retains some consistency with it, so for the new site: Acked-by: Jordan Justen

Re: [Mesa-dev] [PATCH] glsl: serialize data from glTransformFeedbackVaryings

2018-06-14 Thread Jordan Justen
nsformFeedback.VaryingNames[i] = > + strdup(blob_read_string(metadata)); I guess VaryingNames uses malloc/free rather than ralloc. Maybe worth a comment? A comment might just be extra noise though too. With BufferStride added, Reviewed-by: Jordan Justen > + > str

Re: [Mesa-dev] [PATCH 1/3] features.txt: mark some extensions as done

2018-06-14 Thread Jordan Justen
Series Reviewed-by: Jordan Justen On 2018-06-14 04:08:09, Tapani Pälli wrote: > Signed-off-by: Tapani Pälli > --- > docs/features.txt | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/docs/features.txt b/docs/features.txt > index b32606d2

Re: [Mesa-dev] [PATCH v2 2/2] i965: Implement ARB_compute_variable_group_size.

2018-06-08 Thread Jordan Justen
On 2018-06-07 08:34:26, Plamena Manolova wrote: > This patch adds the implementation of ARB_compute_variable_group_size > for i965. We do this by storing the group size in a buffer surface, > similarly to the work group number. > > v2: Fix some indentation inconsistencies (Jordan, Ilia) > Do

Re: [Mesa-dev] [PATCH 00/16] Move the Mesa Website to Sphinx

2018-06-08 Thread Jordan Justen
On Thu, Jun 7, 2018 at 2:56 AM Eero Tamminen wrote: > On 07.06.2018 12:01, Erik Faye-Lund wrote: > > Just as a fun toy, I decided to give an animated SVG "variation" of > > this a go myself: > > > > https://codepen.io/kusma/pen/vrXppL > > > > The actual SVG can be found here: > > > >

[Mesa-dev] [PATCH] mesa/program_binary: add implicit UseProgram after successful ProgramBinary

2018-06-06 Thread Jordan Justen
urrentProgram rather than gl_shader_program" Cc: Timothy Arceri Cc: Signed-off-by: Jordan Justen --- src/mesa/main/program_binary.c | 33 + 1 file changed, 33 insertions(+) diff --git a/src/mesa/main/program_binary.c b/src/mesa/main/program_binary.c index 021f6315e72

Re: [Mesa-dev] [PATCH 2/2] i965: Implement ARB_compute_variable_group_size.

2018-06-01 Thread Jordan Justen
On 2018-06-01 15:21:34, Plamena Manolova wrote: > This patch adds the implentation of ARB_compute_variable_group_size > for i965. We do this by storing the group size in a buffer surface, > similarly to the work group number. > > Signed-off-by: Plamena Manolova > --- > docs/features.txt

Re: [Mesa-dev] [PATCH 1/2] nir: Add global invocation id intrinsic.

2018-06-01 Thread Jordan Justen
Reviewed-by: Jordan Justen On 2018-06-01 15:21:33, Plamena Manolova wrote: > Add the missing nir intrinsic for the gl_GlobalInvocationID > compute shader variable. > > Signed-off-by: Plamena Manolova > --- > src/compiler/nir/nir.c | 4 > src/compiler/nir/

Re: [Mesa-dev] [PATCH 00/16] Move the Mesa Website to Sphinx

2018-05-31 Thread Jordan Justen
ric about withdrawing my feedback. Thanks, -Jordan > On Thu, May 31, 2018 at 1:55 PM, Jordan Justen > wrote: > > > On 2018-05-31 12:27:04, Eric Anholt wrote: > > > Jordan Justen writes: > > > > > > > On 2018-05-24 17:37:09, Laura Ekstrand wrote: >

Re: [Mesa-dev] [PATCH 00/16] Move the Mesa Website to Sphinx

2018-05-31 Thread Jordan Justen
On 2018-05-31 12:27:04, Eric Anholt wrote: > Jordan Justen writes: > > > On 2018-05-24 17:37:09, Laura Ekstrand wrote: > >> A few of the commits are quite large and awaiting list approval. I suggest > >> that you take a look at the code here: > >> https:/

Re: [Mesa-dev] [PATCH 00/16] Move the Mesa Website to Sphinx

2018-05-30 Thread Jordan Justen
On 2018-05-30 17:35:11, wrote: > On Wed, May 30, 2018 at 7:53 PM, Jordan Justen > wrote: > > On 2018-05-30 14:14:18, Laura Ekstrand wrote: > >> The current plan is that this first patch series should just update the > >> website. Then we can swap out the theme e

Re: [Mesa-dev] [PATCH 00/16] Move the Mesa Website to Sphinx

2018-05-30 Thread Jordan Justen
e to the new > infrastructure. Then we can edit content and style. > > On Tue, May 29, 2018 at 11:05 PM, Jordan Justen > wrote: > > > On 2018-05-24 17:37:09, Laura Ekstrand wrote: > > > A few of the commits are quite large and awaiting list approval. I > > sug

Re: [Mesa-dev] [PATCH 00/16] Move the Mesa Website to Sphinx

2018-05-30 Thread Jordan Justen
On 2018-05-24 17:37:09, Laura Ekstrand wrote: > A few of the commits are quite large and awaiting list approval. I suggest > that you take a look at the code here: > https://gitlab.freedesktop.org/ldeks/mesa/tree/website1_75, > and the new website here:

Re: [Mesa-dev] [PATCH v2 4/4] i965: Require softpin support for Cannonlake and later.

2018-05-29 Thread Jordan Justen
3-4 Reviewed-by: Jordan Justen On 2018-05-27 21:35:43, Kenneth Graunke wrote: > This isn't strictly necessary, but anyone running Cannonlake will > already have Kernel 4.5 or later, so there's no reason to support > the relocation model on Gen10+. > > This will let us avoid de

Re: [Mesa-dev] [PATCH v2 1/4] i965: Add virtual memory allocator infrastructure to brw_bufmgr.

2018-05-29 Thread Jordan Justen
Reviewed-by: Jordan Justen On 2018-05-27 21:35:40, Kenneth Graunke wrote: > This introduces a new fast virtual memory allocator integrated with our > BO cache bucketing. For larger objects, it falls back to the simple > free-list allocator (util_vma). > > This puts the allo

Re: [Mesa-dev] Gitlab migration

2018-05-23 Thread Jordan Justen
On 2018-05-23 15:16:58, wrote: > On Wed, May 23, 2018 at 5:48 PM, Jordan Justen > <jordan.l.jus...@intel.com> wrote: > > Why can this only be done with gitlab? > > I'm not directly involved w/ decision to move things to gitlab, but that said, > > https://gitl

Re: [Mesa-dev] Gitlab migration

2018-05-23 Thread Jordan Justen
On 2018-05-23 16:00:53, Jason Ekstrand wrote: > On Wed, May 23, 2018 at 2:48 PM, Jordan Justen <jordan.l.jus...@intel.com> > wrote: > > > On 2018-05-23 12:34:11, Jason Ekstrand wrote: > > > Mesa developers, > > > > > > tl;dr. Please g

  1   2   3   4   5   6   7   8   9   10   >