Re: [Mesa-dev] ARB_cull_distance (final?) and llvmpipe support

Dave Airlie writes: > This is hopefully the final posting for this series, I've gotten > the lowering pass to look like I wanted, which is to say it lowers > to vec4[2]. > > TGSI then uses the CLIPDIST semantic and the two properties to > workout what is what. This means the

Re: [Mesa-dev] [PATCH 1/2] i965: Actually assign binding table offsets for the TCS.

Kenneth Graunke writes: > As far as I can tell, this was just entirely missing...honestly, I'm > not sure how anything worked at all. > > Caught by noticing GPU hangs in image load store tests with scalar TCS, > but probably has broader implications. Yeah, presumably not

Re: [Mesa-dev] [PATCH] i965: Clamp "Maximum VP Index" to 1 when gl_ViewportIndex isn't written.

Kenneth Graunke writes: > fs_visitor::emit_urb_writes skips writing the VUE header for shaders > that don't write gl_PointSize, gl_Layer, or gl_ViewportIndex. This > leaves their values uninitialized. Kristian's nearby comment says: > > "But often none of the special

Re: [Mesa-dev] [PATCH 3/7] i965: Create multiple miptrees planar YUV images

"Pohjolainen, Topi" <topi.pohjolai...@intel.com> writes: > On Thu, May 05, 2016 at 05:04:02PM -0700, Kristian H?gsberg wrote: >> From: Kristian Høgsberg Kristensen <kristian.h.kristen...@intel.com> >> >> --- >> src/mesa/drivers/dri/i965/intel_mi

[Mesa-dev] [PATCH] nir: Fix out-of-tree build for spirv2nir

This needs to be able to find the generated nir_opcodes.h header. --- src/compiler/Makefile.am | 5 + 1 file changed, 5 insertions(+) diff --git a/src/compiler/Makefile.am b/src/compiler/Makefile.am index fe96cb3..8f37448 100644 --- a/src/compiler/Makefile.am +++ b/src/compiler/Makefile.am

Re: [Mesa-dev] [PATCH] Add missing platform information for KBL

\ ... which looks correct for all SKUs, except GT1 and GT4, which both override it to the correct value. As for GT4 urb size, it wont matter for a while, but 1088 / 3 is the safe choice. With the .urb.size assignments removed, this patch is Reviewed-by: Kristian Høgsberg Kristensen <kr

Re: [Mesa-dev] [PATCH 3/3] glsl: Move _mesa_shader_stage_to_string/abbrev to shader_enums.c

Matt Turner <matts...@gmail.com> writes: > On Fri, Jan 8, 2016 at 2:36 PM, Kristian Høgsberg <k...@bitplanet.net> wrote: >> From: Kristian Høgsberg Kristensen <k...@owl.jf.intel.com> >> >> These are used by code that doens't necessarily link to libgl

Re: [Mesa-dev] [PATCH 2/7] mesa: Add core mesa support for GL_ARB_shader_draw_parameters

Ian Romanick <i...@freedesktop.org> writes: > On 12/15/2015 12:28 AM, Kristian Høgsberg Kristensen wrote: >> --- >> src/glsl/builtin_variables.cpp | 5 + >> src/glsl/glsl_parser_extras.cpp | 1 + >> src/glsl/glsl_parser_extras.h

Re: [Mesa-dev] [PATCH 3/7] i965: Assert that SYSTEM_VALUE_VERTEX_ID gets lowered

Ian Romanick <i...@freedesktop.org> writes: > On 12/15/2015 12:28 AM, Kristian Høgsberg Kristensen wrote: >> fs_visitor::emit_vs_system_value() looks like it's trying to handle >> SYSTEM_VALUE_VERTEX_ID, but we should never see that value in the >> backend. >>

Re: [Mesa-dev] [PATCH 4/7] i965: Add support for gl_BaseVertexARB and gl_BaseInstanceARB

next patch. I'll send out a v2 with the rebasing fixed. Kristian > On 12/15/2015 12:28 AM, Kristian Høgsberg Kristensen wrote: >> We already have gl_BaseVertexARB in the .x component of the SGVS vec4 >> and plug gl_BaseInstanceARB into the last free component (.y). >> --- >>

Re: [Mesa-dev] [PATCH 7/7] i965: Reduce vertex state reemission

Ian Romanick <i...@freedesktop.org> writes: > On 12/15/2015 12:28 AM, Kristian Høgsberg Kristensen wrote: >> We can inspect VS prog_data for iterations i > 0, and only flag >> BRW_NEW_VERTICES when one of our system values change. >> >> This change also flags

Re: [Mesa-dev] [PATCH 5/7] i965: Add support for gl_DrawIDARB and enable extension

Ian Romanick <i...@freedesktop.org> writes: > On 12/15/2015 12:28 AM, Kristian Høgsberg Kristensen wrote: >> We have to break open a new vec4 for gl_DrawIDARB. We've used up all >> space in the vec4 we use for SGVS and gl_DrawIDARB has to come from its >> own se

[Mesa-dev] [PATCH 2/7] mesa: Add core mesa support for GL_ARB_shader_draw_parameters

--- src/glsl/builtin_variables.cpp | 5 + src/glsl/glsl_parser_extras.cpp | 1 + src/glsl/glsl_parser_extras.h | 2 ++ src/glsl/nir/nir.c | 8 src/glsl/nir/nir_intrinsics.h | 2 ++ src/glsl/nir/shader_enums.h | 20

[Mesa-dev] [PATCH 5/7] i965: Add support for gl_DrawIDARB and enable extension

We have to break open a new vec4 for gl_DrawIDARB. We've used up all space in the vec4 we use for SGVS and gl_DrawIDARB has to come from its own separate vertex buffer anyway. This is because we point the vb for base vertex and base instance into the draw parameter BO for indirect draw calls, but

[Mesa-dev] [PATCH 7/7] i965: Reduce vertex state reemission

We can inspect VS prog_data for iterations i > 0, and only flag BRW_NEW_VERTICES when one of our system values change. This change also flags BRW_NEW_VERTICES in one case we were missing before: if we're doing an indirect draw, prims[i].basevertex is always 0 and the real base vertex value is in

[Mesa-dev] [PATCH 4/7] i965: Add support for gl_BaseVertexARB and gl_BaseInstanceARB

We already have gl_BaseVertexARB in the .x component of the SGVS vec4 and plug gl_BaseInstanceARB into the last free component (.y). --- src/mesa/drivers/dri/i965/brw_compiler.h | 2 ++ src/mesa/drivers/dri/i965/brw_context.h | 9 -- src/mesa/drivers/dri/i965/brw_draw.c

[Mesa-dev] [PATCH 3/7] i965: Assert that SYSTEM_VALUE_VERTEX_ID gets lowered

fs_visitor::emit_vs_system_value() looks like it's trying to handle SYSTEM_VALUE_VERTEX_ID, but we should never see that value in the backend. --- src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp

[Mesa-dev] [PATCH 0/7] GL_ARB_shader_draw_parameters

Hi, Here's 7 patches to implement GL_ARB_shader_draw_parameters: https://www.opengl.org/registry/specs/ARB/shader_draw_parameters.txt and I have few new piglit tests for the extension as well. Kristian Kristian Høgsberg Kristensen (7): mesa/vbo: Add draw_id field to struct _mesa_prim

[Mesa-dev] [PATCH 1/7] mesa/vbo: Add draw_id field to struct _mesa_prim

The drivers will need this for passing in gl_DrawIDARB. For indirect multidraw calls, we get the prim array and prim[i].draw_id == i and is redundant. But for non-indirect calls, we get one primitive at a time and need the draw_id field. --- src/mesa/vbo/vbo.h| 1 +

[Mesa-dev] [PATCH 6/7] nir: Teach nir_opt_algebraic about adding and subtracting the same thing

This optimizes a + b - b to just a. Modest shader-db results (BDW): total instructions in shared programs: 7842452 -> 7841862 (-0.01%) instructions in affected programs: 61938 -> 61348 (-0.95%) total loops in shared programs:2131 -> 2131 (0.00%) helped:

[Mesa-dev] [PATCH] i965: Move brw_cs_fill_local_id_payload() to libi965_compiler

This is a helper function for setting up the local invocation ID payload according to the cs_prog_data generated by the compiler. It's intended to be available to users of libi965_compiler so move it there. --- src/mesa/drivers/dri/i965/brw_compiler.h | 7 +++

[Mesa-dev] [PATCH v2 1/3] glsl: Drop exec_list argument to lower_ubo_reference

We always pass in shader->ir and we already pass in the shader, so just drop the exec_list. Most passes either take just a exec_list or a shader, so this seems more consistent. Reviewed-by: Timothy Arceri <timothy.arc...@collabora.com> Signed-off-by: Kristian Høgsberg Kris

[Mesa-dev] [PATCH v2 0/3] Lower UBO/SSBO access early

, the pass now failed to eliminate some cases of dead code. This v2 series, now has no shader-db impact and no jenkins regressions. Kristian Høgsberg Kristensen (3): glsl: Drop exec_list argument to lower_ubo_reference glsl: Lower UBO and SSBO access in glsl linker glsl: Use array deref

[Mesa-dev] [PATCH v2 3/3] glsl: Use array deref for access to vector components

ars in the IR as an array deref. This lets us run lowering passes that lower the vector access to I/O (eg for SSBO load/store) before we lower the per-component access to full vector writes. Signed-off-by: Kristian Høgsberg Kristensen <k...@bitplanet.net> --- src/glsl/Makefile.sources

[Mesa-dev] [PATCH v2 2/3] glsl: Lower UBO and SSBO access in glsl linker

All GLSL IR consumers run this lowering pass so we can move it to the linker. This moves the pass up quite a bit, but that's the point: it needs to run before we throw away information about per-component vector access. Signed-off-by: Kristian Høgsberg Kristensen <k...@bitplanet.net> --

[Mesa-dev] [PATCH 3/3] glsl: Use array deref for access to vector components

ars in the IR as an array deref. This lets us run lowering passes that lower the vector access to I/O (eg for SSBO load/store) before we lower the per-component access to full vector writes. Signed-off-by: Kristian Høgsberg Kristensen <k...@bitplanet.net> --- src/glsl/Makefile.sources

[Mesa-dev] [PATCH 1/3] glsl: Drop exec_list argument to lower_ubo_reference

We always pass in shader->ir and we already pass in the shader, so just drop the exec_list. Most passes either take just a exec_list or a shader, so this seems more consistent. Signed-off-by: Kristian Høgsberg Kristensen <k...@bitplanet.net> --- src/glsl/ir_optimization.h

[Mesa-dev] [PATCH 2/3] glsl: Lower UBO and SSBO access in glsl linker

All GLSL IR consumers run this lowering pass so we can move it to the linker. This moves the pass up quite a bit, but that's the point: it needs to run before we throw away information about per-component vector access. Signed-off-by: Kristian Høgsberg Kristensen <k...@bitplanet.net> --

[Mesa-dev] [PATCH 0/3] Fix racy full-vector writes for v[i].x

is racy and we have to handle this different in case the vector is in globally visible storage. Kristian Høgsberg Kristensen (3): glsl: Drop exec_list argument to lower_ubo_reference glsl: Lower UBO and SSBO access in glsl linker glsl: Use array deref for access to vector components src/glsl

[Mesa-dev] [PATCH v2 5/8] i965/fs: Avoid scalar destinations in emit_uniformize()

The scalar destination registers break copy propagation. Instead compute the results to a regular register and then reference a component when we later use the result as a source. Signed-off-by: Kristian Høgsberg Kristensen <k...@bitplanet.net> --- src/mesa/drivers/dri/i965/brw_fs_builder

[Mesa-dev] [PATCH v2 4/8] i965/fs: Don't uniformize surface index twice

The emit_untyped_read and emit_untyped_write helpers already uniformize the surface index argument. No need to do it before calling them. Signed-off-by: Kristian Høgsberg Kristensen <k...@bitplanet.net> --- src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 2 -- 1 file changed, 2 deletions(-)

[Mesa-dev] [PATCH v2 8/8] i965/fs: Allow copy propagating into new surface access opcodes

Signed-off-by: Kristian Høgsberg Kristensen <k...@bitplanet.net> --- src/mesa/drivers/dri/i965/brw_fs_copy_propagation.cpp | 15 +++ 1 file changed, 15 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_fs_copy_propagation.cpp b/src/mesa/drivers/dr

[Mesa-dev] [PATCH v2 6/8] i965/fs: Drop offset_reg temporary in ssbo load

Now that we don't read each component one-by-one, we don't need the temoprary vgrf for the offset. More importantly, this register was type UD while the nir source was type D. This broke copy propagation and left a redundant MOV in the generated code. Signed-off-by: Kristian Høgsberg Kristensen

[Mesa-dev] [PATCH v2 3/8] i965/fs: Use unsigned immediate 0 when eliminating SHADER_OPCODE_FIND_LIVE_CHANNEL

The destination for SHADER_OPCODE_FIND_LIVE_CHANNEL is always a UD register. When we replace the opcode with a MOV, make sure we use a UD immediate 0 so copy propagation doesn't bail because of non-matching types. Signed-off-by: Kristian Høgsberg Kristensen <k...@bitplanet.net> --- sr

[Mesa-dev] [PATCH v2 2/8] i965/fs: Read all components of a SSBO field with one send

Instead of looping through single-component reads, read all components in one go. Reviewed-by: Iago Toral Quiroga <ito...@igalia.com> Reviewed-by: Jordan Justen <jordan.l.jus...@intel.com> Signed-off-by: Kristian Høgsberg Kristensen <k...@bitplanet.net> --- src/mes

[Mesa-dev] [PATCH v2 0/8] SSBO optimizations

of the payload and can accept misc strides and modifiers. I also took a look at ssbo stores and made it write out contiguous channels in the writemask together, in particular, the common case of writing a vec4 goes from 4 to 1 write instruction. Kristian Høgsberg Kristensen (8): i965: Don't use

[Mesa-dev] [PATCH v2 1/8] i965: Don't use message headers for untyped reads

dan.l.jus...@intel.com> Signed-off-by: Kristian Høgsberg Kristensen <k...@bitplanet.net> --- src/mesa/drivers/dri/i965/brw_eu_emit.c | 3 +-- src/mesa/drivers/dri/i965/brw_fs.cpp| 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_eu_

[Mesa-dev] [PATCH v2 7/8] i965/fs: Optimize ssbo stores

Write groups of enabled components together. Signed-off-by: Kristian Høgsberg Kristensen <k...@bitplanet.net> --- src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 56 +++- 1 file changed, 26 insertions(+), 30 deletions(-) diff --git a/src/mesa/drivers/dr

[Mesa-dev] [PATCH 0/3] brw surface builder / ssbo fixes

;8,8,1>D { align1 1Q }; send(8) g124<1>UD g9<8,8,1>UD dp data 1 ( untyped surface read, Surface = 0, SIMD8, Mask = 0x0) mlen 1 rlen 4 { align1 1Q }; send(8) g7<1>UD g8<8,8,1>UD

[Mesa-dev] [PATCH 2/3] i965/fs: Make emit_uniformize a no-op for immediates

-off-by: Kristian Høgsberg Kristensen <k...@bitplanet.net> --- src/mesa/drivers/dri/i965/brw_fs_builder.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_fs_builder.h b/src/mesa/drivers/dri/i965/brw_fs_builder.h index df10a9d..98ce71e 100644 --- a/sr

[Mesa-dev] [PATCH 1/3] i965: Don't use message headers for typed/untyped reads

We always set the mask to 0x, which is what it defaults to when no header is present. Let's drop the header instead. Signed-off-by: Kristian Høgsberg Kristensen <k...@bitplanet.net> --- src/mesa/drivers/dri/i965/brw_eu_emit.c | 3 +-- src/mesa/drivers/dri/i965/brw_fs.cpp| 4 ++-- 2

[Mesa-dev] [PATCH 3/3] i965/fs: Read all components of a SSBO field with one send

Instead of looping through single-component reads, read all components in one go. Signed-off-by: Kristian Høgsberg Kristensen <k...@bitplanet.net> --- src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 25 +++-- 1 file changed, 7 insertions(+), 18 deletions(-) diff --git a/sr

[Mesa-dev] [PATCH 12/12] i965: Link compiler unit tests to libi965_compiler.la

the compiler. Signed-off-by: Kristian Høgsberg Kristensen <k...@bitplanet.net> --- src/mesa/drivers/dri/i965/Makefile.am | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/src/mesa/drivers/dri/i965/Makefile.am b/src/mesa/drivers/dri/i965/Makefile.am index 82e58a6..2

[Mesa-dev] [PATCH 03/12] i965: Configure bufmgr debug options from intel_screen.c

We need the debug flag parsing and INTEL_DEBUG in the compiler, but we don't want the dependency on bufmgr (libdrm_intel) in there. Move to intel_screen.c. Signed-off-by: Kristian Høgsberg Kristensen <k...@bitplanet.net> --- src/mesa/drivers/dri/i965/intel_debug.c | 14 +- sr

[Mesa-dev] [PATCH 10/12] i965/cs: Get max_cs_threads from brw_compiler devinfo

Signed-off-by: Kristian Høgsberg Kristensen <k...@bitplanet.net> --- src/mesa/drivers/dri/i965/brw_fs.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp b/src/mesa/drivers/dri/i965/brw_fs.cpp index 65c3628..b79b4a4 100644 ---

[Mesa-dev] [PATCH 04/12] i965: Move brw_link_shader() and friends to new file brw_link.cpp

We want to use the rest of brw_shader.cpp with the rest of the compiler without pulling in the GLSL linking code. Signed-off-by: Kristian Høgsberg Kristensen <k...@bitplanet.net> --- src/mesa/drivers/dri/i965/Makefile.sources | 1 + src/mesa/drivers/dri/i965/brw_link.cpp

[Mesa-dev] [PATCH 11/12] i965: Break out backend compiler to its own library

This introduces a new libtool helper library, libi965_compiler.la. This library is moderately self-contained, but still needs to link to all of libmesa.la among other things. Signed-off-by: Kristian Høgsberg Kristensen <k...@bitplanet.net> --- src/mesa/drivers/dri/i965/Makefile.am

[Mesa-dev] [PATCH 08/12] i965: Move brw_select_clip_planes() to brw_shader.cpp

We call this from the compiler so move it to brw_shader.cpp. Signed-off-by: Kristian Høgsberg Kristensen <k...@bitplanet.net> --- src/mesa/drivers/dri/i965/brw_shader.cpp | 26 ++ src/mesa/drivers/dri/i965/brw_vs.c | 25 - 2 files chang

[Mesa-dev] [PATCH 05/12] i965/cs: Split out helper for building local id payload

to the compiler code that uses the payload layout and makes it avaiable to other users of the compiler. Signed-off-by: Kristian Høgsberg Kristensen <k...@bitplanet.net> --- src/mesa/drivers/dri/i965/brw_context.h | 1 + src/mesa/drivers/dri/i965/brw_cs.h| 5 +- src/mesa/drive

[Mesa-dev] [PATCH 02/12] util: Move DRI parse_debug_string() to util

We want to use intel_debug.c in code that doesn't link to dri common. Signed-off-by: Kristian Høgsberg Kristensen <k...@bitplanet.net> --- src/mesa/drivers/dri/i965/intel_debug.c | 5 ++-- src/util/Makefile.sources | 2 ++ src/util/debug.c

[Mesa-dev] [PATCH 06/12] i965: Move brw_mark_surface_used() to brw_shader.cpp

brw_program.c won't be part of the compiler library, but we need brw_mark_surface_used() in the compiler. Move to brw_shader.cpp. Signed-off-by: Kristian Høgsberg Kristensen <k...@bitplanet.net> --- src/mesa/drivers/dri/i965/brw_program.c | 10 -- src/mesa/drivers/dr

[Mesa-dev] [PATCH 01/12] i965: Move brw_dump_ir() out of brw_*_emit() functions

We move these calls one level up into the codegen functions. Signed-off-by: Kristian Høgsberg Kristensen <k...@bitplanet.net> --- src/mesa/drivers/dri/i965/brw_cs.c| 3 +++ src/mesa/drivers/dri/i965/brw_fs.cpp | 13 - src/mesa/drivers/dri/i965/br

[Mesa-dev] [PATCH 00/12] Introduce libi965_compiler.la

of brw_context references in there, INTEL_DEUBG is defined in the compiler library and other oddities. However, the split lets us link the compiler unit tests to just libi965_compiler.la and drop a few dependencies there and of course, lets us use the compiler in other projects more easily. Kristian Høgsberg

[Mesa-dev] [PATCH 07/12] i965: Use util_next_power_of_two() for brw_get_scratch_size()

function instead. Signed-off-by: Kristian Høgsberg Kristensen <k...@bitplanet.net> --- src/mesa/drivers/dri/i965/brw_context.h | 7 ++- src/mesa/drivers/dri/i965/brw_program.c | 12 2 files changed, 6 insertions(+), 13 deletions(-) diff --git a/src/mesa/drivers/dr

[Mesa-dev] [PATCH 09/12] i965: Move brw_get_shader_time_index() call out of emit functions

brw_get_shader_time_index() is all tangled up in brw_context state and we can't call it from the compiler. Thanks the Jasons recent refactoring, we can just get the index and pass to the emit functions instead. Signed-off-by: Kristian Høgsberg Kristensen <k...@bitplanet.net> --- src/mesa/d

[Mesa-dev] [PATCH] i965: Respect stride and subreg_offset for ATTR registers

/show_bug.cgi?id=91970 Cc: "11.0" <mesa-sta...@lists.freedesktop.org> Signed-off-by: Kristian Høgsberg Kristensen <k...@bitplanet.net> --- src/mesa/drivers/dri/i965/brw_fs.cpp | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs.c

[Mesa-dev] [PATCH 0/3] Move libdrm dependencies out of backend compiler

dependencies out of the compiler. Kristian Høgsberg Kristensen (3): i965: Move compute shader code around i965: Move brw_fs_precompile() to brw_wm.c i965: Move perf_debug code to brw_codegen_*_prog() src/mesa/drivers/dri/i965/Makefile.sources | 3 +- src/mesa/drivers/dri/i965/brw_cs.c

[Mesa-dev] [PATCH 2/3] i965: Move brw_fs_precompile() to brw_wm.c

All other precompile functions live in the brw_.c files, make fs follow the convention. Signed-off-by: Kristian Høgsberg Kristensen <k...@bitplanet.net> --- src/mesa/drivers/dri/i965/brw_fs.cpp | 58 --- src/mesa/drivers/dri/i965/brw_wm.c

[Mesa-dev] [PATCH 3/3] i965: Move perf_debug code to brw_codegen_*_prog()

We're trying to avoid a libdrm dependency in the core compiler, so let's move the perf_debug code one level up from the brw_*_emit() helpers to the brw_codegen_*_prog() helpers. Signed-off-by: Kristian Høgsberg Kristensen <k...@bitplanet.net> --- src/mesa/drivers/dri/i965/brw_cs.c

[Mesa-dev] [PATCH 1/3] i965: Move compute shader code around

this convention, we move the brw_cs_emit() function into brw_fs.cpp. We can then rename brw_cs.cpp to brw_cs.c and do this in C like the other similar files. Finally, move state setup and atoms to gen7_cs_state.c. Signed-off-by: Kristian Høgsberg Kristensen <k...@bitplanet.net> --- src/mesa/drive