Re: [Mesa-dev] [PATCH v4 0/4] Fix OpenGL 1.3 big-endian support in r600g

On Tue, Apr 26, 2016 at 1:26 PM, Andy Furniss <adf.li...@gmail.com> wrote: > Oded Gabbay wrote: > >> Oded Gabbay (4): r600g/radeonsi: send endian info to format >> translation functions r600g: set endianess of 16/32-bit buffers >> according to do_endian_swap r600

[Mesa-dev] [PATCH] radeonsi: fix build error because of missing param

Signed-off-by: Oded Gabbay <oded.gab...@gmail.com> Cc: "11.1 11.2" <mesa-sta...@lists.freedesktop.org> --- src/gallium/drivers/radeonsi/si_state.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_state.c b/src/gallium/drive

[Mesa-dev] [PATCH v4 1/4] r600g/radeonsi: send endian info to format translation functions

ded FALSE to translation functions when called by it. Signed-off-by: Oded Gabbay <oded.gab...@gmail.com> --- src/gallium/drivers/r600/evergreen_state.c| 33 +-- src/gallium/drivers/r600/r600_pipe.h | 8 --- src/gallium/drivers/r600/r600_state.c

[Mesa-dev] [PATCH v4 0/4] Fix OpenGL 1.3 big-endian support in r600g

between upstream code and upstream + patch-set, both running in BE. This shows all the tests my patch-set fixed (and no regressions) In addition, I of course checked for regressions on LE, without reducing OpenGL version. Thanks, Oded Oded Gabbay (4): r600g/radeonsi: send endian info

[Mesa-dev] [PATCH v4 2/4] r600g: set endianess of 16/32-bit buffers according to do_endian_swap

, because for them gallium sets an alias based on the machine's endianess. v4: V_0280A0_COLOR_16_16 and V_0280A0_COLOR_16_16_FLOAT should be set to 8IN16 because the bytes inside need to be swapped even for array formats. Signed-off-by: Oded Gabbay <oded.gab...@gmail.com> --- src/gallium/d

[Mesa-dev] [PATCH v4 4/4] r600g: use do_endian_swap in texture swapping function

For some texture formats we need to take "do_endian_swap" into account when configuring their swizzling. Signed-off-by: Oded Gabbay <oded.gab...@gmail.com> --- src/gallium/drivers/r600/r600_state_common.c | 35 +++- 1 file changed, 34 insertions(+), 1 d

[Mesa-dev] [PATCH v4 3/4] r600g: use do_endian_swap in color swapping functions

For some formats we need to take "do_endian_swap" into account when configuring swapping for color buffers. Signed-off-by: Oded Gabbay <oded.gab...@gmail.com> --- src/gallium/drivers/r600/r600_state_common.c | 2 +- src/gallium/drivers/radeon/r600_texture.c| 20 +

Re: [Mesa-dev] [PATCH v3 0/4] Fix OpenGL 1.3 big-endian support in r600g

it.edu> wrote: > It appears you regressed vbo-subdata-many > drawelements/drawrangeelements. This seems highly relevant, since it's > mapping a buffer and updating data within it. Any idea what happened > there? Or was it just passing by luck before? > > On Thu, Apr 21, 2016

[Mesa-dev] [PATCH v3 4/4] r600g: use do_endian_swap in texture swapping function

For some texture formats we need to take "do_endian_swap" into account when configuring their swizzling. Signed-off-by: Oded Gabbay <oded.gab...@gmail.com> --- src/gallium/drivers/r600/r600_state_common.c | 35 +++- 1 file changed, 34 insertions(+), 1 d

[Mesa-dev] [PATCH v3 2/4] r600g: set endianess of 16/32-bit buffers according to do_endian_swap

, because for them gallium sets an alias based on the machine's endianess. Signed-off-by: Oded Gabbay <oded.gab...@gmail.com> --- src/gallium/drivers/r600/r600_state_common.c | 17 - 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/src/gallium/driver

[Mesa-dev] [PATCH v3 3/4] r600g: use do_endian_swap in color swapping functions

For some formats we need to take "do_endian_swap" into account when configuring swapping for color buffers. Signed-off-by: Oded Gabbay <oded.gab...@gmail.com> --- src/gallium/drivers/r600/r600_state_common.c | 2 +- src/gallium/drivers/radeon/r600_texture.c| 20 +

[Mesa-dev] [PATCH v3 1/4] r600g/radeonsi: send endian info to format translation functions

f so, they will send FALSE through this parameter. Otherwise, they will send TRUE. The translation functions, in specific cases, will look at this parameter and configure the swapping accordingly. Signed-off-by: Oded Gabbay <oded.gab...@gmail.com> --- src/gallium/drivers/r600/evergreen_state.c| 42

[Mesa-dev] [PATCH v3 0/4] Fix OpenGL 1.3 big-endian support in r600g

code and upstream + patch-set, both running in BE. This shows all the tests my patch-set fixed (and no regressions) In addition, I of course checked for regressions on LE, without reducing OpenGL version. Thanks, Oded Oded Gabbay (4): r600g/radeonsi: send endian info to format

Re: [Mesa-dev] [PATCH v2 04/11] gallium: add endian_format field to struct pipe_resource

On Wed, Apr 20, 2016 at 12:35 PM, Marek Olšák <mar...@gmail.com> wrote: > On Wed, Apr 20, 2016 at 11:14 AM, Oded Gabbay <oded.gab...@gmail.com> wrote: >> On Wed, Apr 20, 2016 at 12:04 PM, Michel Dänzer <mic...@daenzer.net> wrote: >>> On 20.04.2016 17:48, Od

Re: [Mesa-dev] [PATCH v2 04/11] gallium: add endian_format field to struct pipe_resource

On Wed, Apr 20, 2016 at 12:04 PM, Michel Dänzer <mic...@daenzer.net> wrote: > On 20.04.2016 17:48, Oded Gabbay wrote: >> On Wed, Apr 20, 2016 at 11:28 AM, Michel Dänzer <mic...@daenzer.net> wrote: >>> On 20.04.2016 03:13, Oded Gabbay wrote: >>>> On Tue,

Re: [Mesa-dev] [PATCH v2 04/11] gallium: add endian_format field to struct pipe_resource

On Wed, Apr 20, 2016 at 11:28 AM, Michel Dänzer <mic...@daenzer.net> wrote: > On 20.04.2016 03:13, Oded Gabbay wrote: >> On Tue, Apr 19, 2016 at 5:59 PM, Marek Olšák <mar...@gmail.com> wrote: >>> On Tue, Apr 19, 2016 at 3:11 PM, Oded Gabbay <oded.gab...@gmail.com&

Re: [Mesa-dev] [PATCH v2 04/11] gallium: add endian_format field to struct pipe_resource

On Tue, Apr 19, 2016 at 5:59 PM, Marek Olšák <mar...@gmail.com> wrote: > On Tue, Apr 19, 2016 at 3:11 PM, Oded Gabbay <oded.gab...@gmail.com> wrote: >> On Mon, Apr 18, 2016 at 6:03 PM, >> Ilia Mirkin <imir...@alum.mit.edu> wrote: >>> On Mon, Apr 1

Re: [Mesa-dev] [PATCH v2 04/11] gallium: add endian_format field to struct pipe_resource

On Mon, Apr 18, 2016 at 6:03 PM, Ilia Mirkin <imir...@alum.mit.edu> wrote: > On Mon, Apr 18, 2016 at 10:47 AM, Oded Gabbay <oded.gab...@gmail.com> wrote: >> On Thu, Apr 14, 2016 at 6:44 PM, Ilia Mirkin <imir...@alum.mit.edu> wrote: >>> On Thu, Apr 14, 201

Re: [Mesa-dev] [PATCH v2 04/11] gallium: add endian_format field to struct pipe_resource

On Tue, Apr 19, 2016 at 9:10 AM, Michel Dänzer <mic...@daenzer.net> wrote: > On 19.04.2016 00:03, Ilia Mirkin wrote: >> On Mon, Apr 18, 2016 at 10:47 AM, Oded Gabbay <oded.gab...@gmail.com> wrote: >>> On Thu, Apr 14, 2016 at 6:44 PM, Ilia Mirkin <imir...@alu

Re: [Mesa-dev] [PATCH v2 04/11] gallium: add endian_format field to struct pipe_resource

On Thu, Apr 14, 2016 at 6:44 PM, Ilia Mirkin <imir...@alum.mit.edu> wrote: > On Thu, Apr 14, 2016 at 11:08 AM, Oded Gabbay <oded.gab...@gmail.com> wrote: >>> Wouldn't it make more sense to handle such issues in transfer_map? >>> (i.e. create a staging memory area,

Re: [Mesa-dev] [PATCH v2 04/11] gallium: add endian_format field to struct pipe_resource

On Fri, Apr 15, 2016 at 2:35 AM, Ilia Mirkin <imir...@alum.mit.edu> wrote: > On Thu, Apr 14, 2016 at 7:26 PM, Roland Scheidegger <srol...@vmware.com> > wrote: >> Am 14.04.2016 um 14:18 schrieb Oded Gabbay: >>> This patch adds a new field, called "endian

Re: [Mesa-dev] [PATCH v2 04/11] gallium: add endian_format field to struct pipe_resource

On Thu, Apr 14, 2016 at 5:47 PM, Ilia Mirkin <imir...@alum.mit.edu> wrote: > On Thu, Apr 14, 2016 at 10:34 AM, Oded Gabbay <oded.gab...@gmail.com> wrote: >> On Thu, Apr 14, 2016 at 5:01 PM, Ilia Mirkin <imir...@alum.mit.edu> wrote: >>> This feels like an incredi

Re: [Mesa-dev] [PATCH v2 04/11] gallium: add endian_format field to struct pipe_resource

path, I need to configure LE and in the other path I need to configure BE. > [I left these issues unresolved... nv30 on BE sorta works but not > really.] > > -ilia > > On Thu, Apr 14, 2016 at 8:18 AM, Oded Gabbay <oded.gab...@gmail.com> wrote: >> This patch adds a

[Mesa-dev] [PATCH v2 02/11] r600g: Move R600_BIG_ENDIAN to r600_pipe_common.h

I need to do this so I could use R600_BIG_ENDIAN in files which include r600_pipe_common.h but not r600_pipe.h Signed-off-by: Oded Gabbay <oded.gab...@gmail.com> --- src/gallium/drivers/r600/r600_pipe.h | 6 -- src/gallium/drivers/radeon/r600_pipe_common.h | 6 ++ 2

[Mesa-dev] [PATCH v2 05/11] r600g/radeonsi: propagate endian_format to relevant functions

This patch propagates the pipe_resource's endian_format field to relevant functions in the r600g driver. It doesn't make any use of it though. v2: squash the patch that fixes the calls from radeonsi Signed-off-by: Oded Gabbay <oded.gab...@gmail.com> --- src/gallium/driver

[Mesa-dev] [PATCH v2 11/11] r600g: use endian_format in texture swapping function

For some texture formats we need to take endian_format into account when configuring their swizzling. We also need to take into account those formats when we use staging textures. Signed-off-by: Oded Gabbay <oded.gab...@gmail.com> --- src/gallium/drivers/r600/r600_state_common.

[Mesa-dev] [PATCH v2 07/11] r600g: update endian_format after operations

After operations are done, where resources have been copied to the GPU, we need to mark those resources as little-endian for future operations on them. Signed-off-by: Oded Gabbay <oded.gab...@gmail.com> --- src/gallium/drivers/radeon/r600_texture.c | 4 1 file changed, 4 insertions(+)

[Mesa-dev] [PATCH v2 10/11] r600g: use endian_format in color swapping functions

For some formats we need to take endian_format into account when configuring swapping for color buffers. Signed-off-by: Oded Gabbay <oded.gab...@gmail.com> --- src/gallium/drivers/r600/r600_state_common.c | 5 - src/gallium/drivers/radeon/r600_texture.c| 11 --- 2 files c

[Mesa-dev] [PATCH v2 08/11] r600g: set staging texture endianess

Set the default endianess of a staging texture to match the original texture's endianess. Signed-off-by: Oded Gabbay <oded.gab...@gmail.com> --- src/gallium/drivers/radeon/r600_texture.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/gallium/drivers/radeon/r600_textur

[Mesa-dev] [PATCH v2 06/11] r600g: override endian when mapping to read

When the driver performs a read from the GPU to the CPU, the endianess should always be set to NATIVE. Signed-off-by: Oded Gabbay <oded.gab...@gmail.com> --- src/gallium/drivers/radeon/r600_texture.c | 12 1 file changed, 12 insertions(+) diff --git a/src/gallium/drivers/

[Mesa-dev] [PATCH v2 01/11] r600g: fix code indentation

Signed-off-by: Oded Gabbay <oded.gab...@gmail.com> --- src/gallium/drivers/r600/r600_blit.c | 18 +- src/gallium/drivers/r600/r600_pipe.c | 2 +- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/src/gallium/drivers/r600/r600_blit.c b/src/gallium/driver

[Mesa-dev] [PATCH v2 04/11] gallium: add endian_format field to struct pipe_resource

function can set its endian_format during creation, same as pipe_format. - When a pipe_resource is created using a template, I initialized the endian_format field of the template so the created object will contain the correct endian value. Signed-off-by: Oded Gabbay <oded.gab...@gmail.c

[Mesa-dev] [PATCH v2 09/11] r600g: set endianess of 16/32-bit buffers according to endian_format

-endian, because for them, gallium sets a different pipe_format based on endianess Signed-off-by: Oded Gabbay <oded.gab...@gmail.com> --- src/gallium/drivers/r600/r600_state_common.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/src/gallium/driver

[Mesa-dev] [PATCH v2 03/11] mesa/st: add helper to return pipe_endian based on pipe_format

Add a helper function which receives pipe_format value and returns a matching pipe_endian value. It is needed because almost every call to st_create_texture will use this function to send the pipe_endian value Signed-off-by: Oded Gabbay <oded.gab...@gmail.com> --- src/mesa/state_t

[Mesa-dev] [PATCH v2 00/11] Fix OpenGL 1.3 big-endian support in r600g

all the tests my patch-set fixed (and no regressions) In addition, I of course checked for regressions on LE, without reducing OpenGL version. Thanks, Oded Oded Gabbay (11): r600g: fix code indentation r600g: Move R600_BIG_ENDIAN to r600_pipe_common.h mesa/st: add helper to return

Re: [Mesa-dev] [PATCH 03/10] mesa/st: add endian_format field to struct pipe_resource

On Mon, Apr 11, 2016 at 6:34 PM, Roland Scheidegger <srol...@vmware.com> wrote: > Am 11.04.2016 um 16:34 schrieb Oded Gabbay: >> This patch adds a new field, called "endian_format", to >> "struct pipe_resource". The new field is of type "enum pip

Re: [Mesa-dev] [PATCH 03/10] mesa/st: add endian_format field to struct pipe_resource

On Tue, Apr 12, 2016 at 10:40 AM, Michel Dänzer <mic...@daenzer.net> wrote: > On 12.04.2016 16:31, Oded Gabbay wrote: >> On Tue, Apr 12, 2016 at 10:21 AM, Michel Dänzer <mic...@daenzer.net> wrote: >>> On 11.04.2016 23:34, Oded Gabbay wrote: >>>> This pat

Re: [Mesa-dev] [PATCH 03/10] mesa/st: add endian_format field to struct pipe_resource

On Tue, Apr 12, 2016 at 10:21 AM, Michel Dänzer <mic...@daenzer.net> wrote: > On 11.04.2016 23:34, Oded Gabbay wrote: >> This patch adds a new field, called "endian_format", to >> "struct pipe_resource". The new field is of type "enum pip

Re: [Mesa-dev] [PATCH 03/10] mesa/st: add endian_format field to struct pipe_resource

On Mon, Apr 11, 2016 at 6:34 PM, Roland Scheidegger <srol...@vmware.com> wrote: > Am 11.04.2016 um 16:34 schrieb Oded Gabbay: >> This patch adds a new field, called "endian_format", to >> "struct pipe_resource". The new field is of type "enum pip

Re: [Mesa-dev] [PATCH 03/10] mesa/st: add endian_format field to struct pipe_resource

ware.com> > wrote: >> Am 11.04.2016 um 16:34 schrieb Oded Gabbay: >>> This patch adds a new field, called "endian_format", to >>> "struct pipe_resource". The new field is of type "enum pipe_endian" and >>> can receive one of two v

Re: [Mesa-dev] [PATCH 05/10] radeonsi: fix calls to r600 functions that take endian_format

On Tue, Apr 12, 2016 at 12:17 AM, Marek Olšák <mar...@gmail.com> wrote: > > This should be squashed with the patch changing those function signatures. > > Marek Yes, of course you are correct here. Oded > > On Mon, Apr 11, 2016 at 4:34 PM, Oded Gabbay <oded.gab...@gma

[Mesa-dev] [PATCH 09/10] r600g: use endian_format in color swapping functions

For some formats we need to take endian_format into account when configuring swapping for color buffers. Signed-off-by: Oded Gabbay <oded.gab...@gmail.com> --- src/gallium/drivers/r600/r600_state_common.c | 5 - src/gallium/drivers/radeon/r600_texture.c| 11 --- 2 files c

[Mesa-dev] [PATCH 01/10] r600g: fix code indentation

Signed-off-by: Oded Gabbay <oded.gab...@gmail.com> --- src/gallium/drivers/r600/r600_blit.c | 18 +- src/gallium/drivers/r600/r600_pipe.c | 2 +- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/src/gallium/drivers/r600/r600_blit.c b/src/gallium/driver

[Mesa-dev] [PATCH 05/10] radeonsi: fix calls to r600 functions that take endian_format

radeonsi calls some r600 functions that now receive the endian_format value as a parameter, so we need to fix the calls to prevent compilation errors. Signed-off-by: Oded Gabbay <oded.gab...@gmail.com> --- src/gallium/drivers/radeonsi/si_state.c | 4 ++-- 1 file changed, 2 insertions

[Mesa-dev] [PATCH 03/10] mesa/st: add endian_format field to struct pipe_resource

n only be set in that layer. That way, drivers which don't use this field won't be effected at all. - The values that this field can be set to must be only PIPE_ENDIAN_LITTLE or PIPE_ENDIAN_NATIVE. It should never be set to PIPE_ENDIAN_BIG directly for the code to work correctly in both endian modes

[Mesa-dev] [PATCH 08/10] r600g: set endianess of 16/32-bit buffers according to endian_format

-endian, because for them, gallium sets a different pipe_format based on endianess Signed-off-by: Oded Gabbay <oded.gab...@gmail.com> --- src/gallium/drivers/r600/r600_state_common.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/src/gallium/driver

[Mesa-dev] [PATCH 10/10] r600g: use endian_format in texture swapping function

For some texture formats we need to take endian_format into account when configuring their swizzling. We also need to take into account those formats when we use staging textures. Signed-off-by: Oded Gabbay <oded.gab...@gmail.com> --- src/gallium/drivers/r600/r600_state_common.

[Mesa-dev] [PATCH 04/10] r600g: propagate endian_format to relevant functions

This patch propagates the pipe_resource's endian_format field to relevant functions in the r600g driver. It doesn't make any use of it though. Signed-off-by: Oded Gabbay <oded.gab...@gmail.com> --- src/gallium/drivers/r600/evergreen_state.c| 24 +--- src/gallium/d

[Mesa-dev] [PATCH 06/10] r600g: update endian_format after operations

After operations are done, where resources have been copied to the GPU, we need to mark those resources as little-endian for future operations on them. Signed-off-by: Oded Gabbay <oded.gab...@gmail.com> --- src/gallium/drivers/radeon/r600_texture.c | 4 1 file changed, 4 insertions(+)

[Mesa-dev] [PATCH 07/10] r600g: set staging texture endianess

Set the default endianess of a staging texture to match the original texture's endianess. Signed-off-by: Oded Gabbay <oded.gab...@gmail.com> --- src/gallium/drivers/radeon/r600_texture.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/gallium/drivers/radeon/r600_textur

[Mesa-dev] [PATCH 02/10] r600g: Move R600_BIG_ENDIAN to r600_pipe_common.h

I need to do this so I could use R600_BIG_ENDIAN in files which include r600_pipe_common.h but not r600_pipe.h Signed-off-by: Oded Gabbay <oded.gab...@gmail.com> --- src/gallium/drivers/r600/r600_pipe.h | 6 -- src/gallium/drivers/radeon/r600_pipe_common.h | 6 ++ 2

[Mesa-dev] [PATCH 00/10] Fix OpenGL 1.3 big-endian support in r600g

my patch-set fixed (and no regressions) In addition, I of course checked for regressions on LE, without reducing OpenGL version. Thanks, Oded Oded Gabbay (10): r600g: fix code indentation r600g: Move R600_BIG_ENDIAN to r600_pipe_common.h mesa/st: add endian_format field to struct

[Mesa-dev] [PATCH] tgsi/doc: fix spelling error

Signed-off-by: Oded Gabbay <oded.gab...@gmail.com> --- src/gallium/docs/source/tgsi.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/docs/source/tgsi.rst b/src/gallium/docs/source/tgsi.rst index ac6052a..85c302f 100644 --- a/src/gallium/docs/source/tg

Re: [Mesa-dev] Removing R600_BIG_ENDIAN and using #ifdef instead

R600_BIG_ENDIAN can be moved to r600_pipe_common.h. > > Marek > OK, no problem. I'll move the define as part of the next patch set I'll send. Oded > > On Sun, Mar 6, 2016 at 9:01 AM, Oded Gabbay <oded.gab...@gmail.com> wrote: > > Hi, > > > > Do you mind if

Re: [Mesa-dev] [PATCH v2] r600g: Fix ARB_texture_rgb10_a2ui support in big-endian

On Tue, Mar 1, 2016 at 2:11 PM, Oded Gabbay <oded.gab...@gmail.com> wrote: > This patch enables the correct detection of PIPE_FORMAT_R10G10B10A2_UINT > and PIPE_FORMAT_B10G10R10A2_UINT formats in r600g in big-endian mode. > > Because the swapping doesn't happen on co

Re: [Mesa-dev] [PATCH] r600g: Adjust pipe format when decompressing depth in BE

On Fri, Mar 4, 2016 at 10:08 PM, Marek Olšák <mar...@gmail.com> wrote: > On Fri, Mar 4, 2016 at 6:53 PM, Oded Gabbay <oded.gab...@gmail.com> wrote: >> On Fri, Mar 4, 2016 at 6:59 PM, Marek Olšák <mar...@gmail.com> wrote: >>> On Fri, Mar 4, 2016 at 4:56 PM, Oded

[Mesa-dev] Removing R600_BIG_ENDIAN and using #ifdef instead

Hi, Do you mind if I totally remove R600_BIG_ENDIAN global variable and instead use in all places #ifdef PIPE_ARCH_BIG_ENDIAN ? It's just that: 1. Checking for R600_BIG_ENDIAN is an extra check which can be eliminated using #ifdef 2. Some files, e.g r600_texture.c, don't know R600_BIG_ENDIAN

Re: [Mesa-dev] [PATCH] r600g: Adjust pipe format when decompressing depth in BE

On Mar 4, 2016 7:53 PM, "Oded Gabbay" <oded.gab...@gmail.com> wrote: > > On Fri, Mar 4, 2016 at 6:59 PM, Marek Olšák <mar...@gmail.com> wrote: > > On Fri, Mar 4, 2016 at 4:56 PM, Oded Gabbay <oded.gab...@gmail.com> wrote: > >> On Fri, Mar 4, 2016

Re: [Mesa-dev] [PATCH] r600g: Adjust pipe format when decompressing depth in BE

On Fri, Mar 4, 2016 at 6:59 PM, Marek Olšák <mar...@gmail.com> wrote: > On Fri, Mar 4, 2016 at 4:56 PM, Oded Gabbay <oded.gab...@gmail.com> wrote: >> On Fri, Mar 4, 2016 at 2:19 PM, Marek Olšák <mar...@gmail.com> wrote: >>> Note that the DB only supports tilin

Re: [Mesa-dev] [PATCH] r600g: Adjust pipe format when decompressing depth in BE

we program the GPU with the PIPE_FORMAT_S8_UINT_Z24_UNORM parameters. I think that if we use a workaround, better use a cleaner/simpler one. Oded > On Mar 4, 2016 12:20 PM, "Oded Gabbay" <oded.gab...@gmail.com> wrote: >> >> On Fri, Mar 4, 2016 at 12:16 PM, Marek Olšák

Re: [Mesa-dev] [PATCH] r600g: Adjust pipe format when decompressing depth in BE

ted how ? You want me to check specifically for this format there ? I'll take a look if it can be done and I'll get back to you. Oded > > On Thu, Mar 3, 2016 at 4:47 PM, Oded Gabbay <oded.gab...@gmail.com> wrote: >> The following is what happens when trying to do glReadPixels() wi

[Mesa-dev] [PATCH] r600g: Adjust pipe format when decompressing depth in BE

function will be called to copy the values, unpack_uint_z_X8_UINT_Z24_UNORM() will be called instead of unpack_uint_z_Z24_UNORM_X8_UINT. This patch fix gl-1.0-readpixsanity (check_depth and check_stencil). Signed-off-by: Oded Gabbay <oded.gab...@gmail.com> Cc: "11.1 11.2

Re: [Mesa-dev] [PATCH 1/2] r600g: Do colorformat endian swap for PIPE_USAGE_STAGING

On Wed, Mar 2, 2016 at 11:48 PM, Marek Olšák <mar...@gmail.com> wrote: > On Wed, Mar 2, 2016 at 8:22 PM, Oded Gabbay <oded.gab...@gmail.com> wrote: >> There is an old if statement (dated to 2011) that prevented doing >> endian swap for colorformat, i

[Mesa-dev] [PATCH 1/2] r600g: Do colorformat endian swap for PIPE_USAGE_STAGING

is rendered correctly to the monitor, when reading it back we get unswapped/wrong values. This patch makes the check_rgba() function in gl-1.0-readpixsanity piglit test pass in big-endian. Signed-off-by: Oded Gabbay <oded.gab...@gmail.com> Cc: "11.1 11.2" <mesa-sta...@lists.freede

[Mesa-dev] [PATCH 2/2] radeonsi: Do colorformat endian swap for PIPE_USAGE_STAGING

is rendered correctly to the monitor, when reading it back we get unswapped/wrong values. This patch makes the check_rgba() function in gl-1.0-readpixsanity piglit test pass in big-endian. Signed-off-by: Oded Gabbay <oded.gab...@gmail.com> Cc: "11.1 11.2" <mesa-sta...@lists.freede

[Mesa-dev] [PATCH v2] r600g: Fix ARB_texture_rgb10_a2ui support in big-endian

on BE (V_0280A0_COLOR_10_10_10_2) to configure the GPU - Added detection of this color format in endian swap function - removed blank line Signed-off-by: Oded Gabbay <oded.gab...@gmail.com> Cc: "11.1 11.2" <mesa-sta...@lists.freedesktop.org> --- src/gallium/drivers/r600/r600_state_common

Re: [Mesa-dev] [PATCH] r600g: Fix ARB_texture_rgb10_a2ui support in big-endian

On Mon, Feb 29, 2016 at 11:33 AM, Oded Gabbay <oded.gab...@gmail.com> wrote: > > On Mon, Feb 29, 2016 at 7:44 AM, Ilia Mirkin <imir...@alum.mit.edu> wrote: > > On Mon, Feb 29, 2016 at 12:31 AM, Oded Gabbay <oded.gab...@gmail.com> wrote: > >> On Mon, Feb

Re: [Mesa-dev] [PATCH] r600g: Fix ARB_texture_rgb10_a2ui support in big-endian

On Mon, Feb 29, 2016 at 7:44 AM, Ilia Mirkin <imir...@alum.mit.edu> wrote: > On Mon, Feb 29, 2016 at 12:31 AM, Oded Gabbay <oded.gab...@gmail.com> wrote: >> On Mon, Feb 29, 2016 at 3:51 AM, Michel Dänzer <mic...@daenzer.net> wrote: >>> On 28.02.2016 05:48

Re: [Mesa-dev] [PATCH] r600g: Fix ARB_texture_rgb10_a2ui support in big-endian

On Mon, Feb 29, 2016 at 3:51 AM, Michel Dänzer <mic...@daenzer.net> wrote: > On 28.02.2016 05:48, Oded Gabbay wrote: >> This patch enables the correct detection of PIPE_FORMAT_R10G10B10A2_UINT >> and PIPE_FORMAT_B10G10R10A2_UINT formats in r600g in big-endian mode, by &

[Mesa-dev] [PATCH] r600g: Fix ARB_texture_rgb10_a2ui support in big-endian

. Signed-off-by: Oded Gabbay <oded.gab...@gmail.com> --- src/gallium/drivers/r600/r600_state_common.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/src/gallium/drivers/r600/r600_state_common.c b/src/gallium/drivers/r600/r600_state_common.c index b231d1e..b

[Mesa-dev] [PATCH v2 2/3] gallium/r600: Don't let h/w do endian swap for colorformat

components (V_0280A0_COLOR_8_8_8_8) Signed-off-by: Oded Gabbay <oded.gab...@gmail.com> Cc: "11.1 11.2" <mesa-sta...@lists.freedesktop.org> --- src/gallium/drivers/r600/r600_state_common.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/gallium/drivers/r600/r600_state_c

[Mesa-dev] [PATCH v2 3/3] gallium/radeon: disable evergreen_do_fast_color_clear for BE

for colorformat - gallium/radeon: remove separate BE path in r600_translate_colorswap it fixes BZ#72877 and BZ#92039 Signed-off-by: Oded Gabbay <oded.gab...@gmail.com> Cc: "11.1 11.2" <mesa-sta...@lists.freedesktop.org> Reviewed-by: Marek Olšák <marek.ol...@amd.com&

[Mesa-dev] [PATCH v2 1/3] gallium/radeon: remove separate BE path in r600_translate_colorswap

is relevant for both systems. This patch adds an additional 120 available visuals for LE and BE, as seen in glxinfo v2: Tested for regressions by running piglit gpu.py with CAICOS (r600g) on x86-64 machine. No regressions found. Signed-off-by: Oded Gabbay <oded.gab...@gmail.com> Cc: "11.1

Re: [Mesa-dev] [PATCH 1/3] gallium/radeon: remove separate BE path in r600_translate_colorswap

On Fri, Feb 26, 2016 at 5:03 AM, Michel Dänzer <mic...@daenzer.net> wrote: > On 26.02.2016 06:09, Oded Gabbay wrote: >> After further testing, it appears there is no need for >> separate BE path in r600_translate_colorswap() >> >> The only fix remaining is th

Re: [Mesa-dev] [PATCH 1/3] gallium/radeon: remove separate BE path in r600_translate_colorswap

On Fri, Feb 26, 2016 at 12:51 PM, Marek Olšák <mar...@gmail.com> wrote: > On Thu, Feb 25, 2016 at 10:09 PM, Oded Gabbay <oded.gab...@gmail.com> wrote: >> After further testing, it appears there is no need for >> separate BE path in r600_translate_colorswap() &

Re: [Mesa-dev] [PATCH 2/3] gallium/r600: Don't let h/w do endian swap for colorformat

On Fri, Feb 26, 2016 at 9:35 AM, Oded Gabbay <oded.gab...@gmail.com> wrote: > On Fri, Feb 26, 2016 at 9:32 AM, Michel Dänzer <mic...@daenzer.net> wrote: >> On 26.02.2016 16:14, Oded Gabbay wrote: >>> On Fri, Feb 26, 2016 at 5:01 AM, Michel Dänzer <mic...@daenzer

Re: [Mesa-dev] [PATCH 2/3] gallium/r600: Don't let h/w do endian swap for colorformat

On Fri, Feb 26, 2016 at 9:32 AM, Michel Dänzer <mic...@daenzer.net> wrote: > On 26.02.2016 16:14, Oded Gabbay wrote: >> On Fri, Feb 26, 2016 at 5:01 AM, Michel Dänzer <mic...@daenzer.net> wrote: >>> >>> [ Dropping mesa-stable list from Cc, since sending pat

Re: [Mesa-dev] [PATCH 2/3] gallium/r600: Don't let h/w do endian swap for colorformat

On Fri, Feb 26, 2016 at 5:01 AM, Michel Dänzer <mic...@daenzer.net> wrote: > > [ Dropping mesa-stable list from Cc, since sending patches there by > e-mail before they've landed on master is basically noise ] Problem is that I sometimes later forget to add stable :) > > On 2

Re: [Mesa-dev] [PATCH 2/3] gallium/r600: Don't let h/w do endian swap for colorformat

On Thu, Feb 25, 2016 at 11:23 PM, Matt Turner <matts...@gmail.com> wrote: > On Thu, Feb 25, 2016 at 1:19 PM, Oded Gabbay <oded.gab...@gmail.com> wrote: >> On Thu, Feb 25, 2016 at 11:16 PM, Matt Turner <matts...@gmail.com> wrote: >>> On Thu, Feb 25, 20

Re: [Mesa-dev] [PATCH 2/3] gallium/r600: Don't let h/w do endian swap for colorformat

On Thu, Feb 25, 2016 at 11:16 PM, Matt Turner <matts...@gmail.com> wrote: > On Thu, Feb 25, 2016 at 1:09 PM, Oded Gabbay <oded.gab...@gmail.com> wrote: >> Since the rework on gallium pipe formats, there is no more need to do >> endian swap of the colorformat in the

[Mesa-dev] [PATCH 2/3] gallium/r600: Don't let h/w do endian swap for colorformat

Since the rework on gallium pipe formats, there is no more need to do endian swap of the colorformat in the h/w, because the conversion between mesa format and gallium (pipe) format takes endianess into account (see the big #if in p_format.h). Signed-off-by: Oded Gabbay <oded.gab...@gmail.com&

[Mesa-dev] [PATCH 3/3] gallium/radeon: disable evergreen_do_fast_color_clear for BE

for colorformat - gallium/radeon: remove separate BE path in r600_translate_colorswap it fixes BZ#72877 and BZ#92039 Signed-off-by: Oded Gabbay <oded.gab...@gmail.com> Cc: "11.1 11.2" <mesa-sta...@lists.freedesktop.org> --- src/gallium/drivers/radeon/r600_texture.c | 5 ++

[Mesa-dev] [PATCH 1/3] gallium/radeon: remove separate BE path in r600_translate_colorswap

is relevant for both systems. This patch adds an additional 120 available visuals for LE and BE, as seen in glxinfo Signed-off-by: Oded Gabbay <oded.gab...@gmail.com> Cc: "11.1 11.2" <mesa-sta...@lists.freedesktop.org> --- src/gallium/drivers/radeon/r600_texture.c | 13 +-

[Mesa-dev] [PATCH 0/3] Fix desktop colors for r600g on Big-Endian machines

colors on the desktop are correct. Thanks, Oded Oded Gabbay (3): gallium/radeon: remove separate BE path in r600_translate_colorswap gallium/r600: Don't let h/w do endian swap for colorformat gallium/radeon: disable evergreen_do_fast_color_clear for BE src/gallium/drivers/r600/r600_state_co

Re: [Mesa-dev] [PATCH] gallium/radeon: return correct values for BE in r600_translate_colorswap

On Wed, Feb 24, 2016 at 5:56 PM, Emil Velikov <emil.l.veli...@gmail.com> wrote: > Hi Oded, > > On 24 February 2016 at 12:46, Oded Gabbay <oded.gab...@gmail.com> wrote: >> Because I changed the swizzle check, I also need to adapt the return >> values for each c

[Mesa-dev] [PATCH] gallium/radeon: return correct values for BE in r600_translate_colorswap

demos). Signed-off-by: Oded Gabbay <oded.gab...@gmail.com> --- src/gallium/drivers/radeon/r600_texture.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/radeon/r600_texture.c b/src/gallium/drivers/radeon/r600_texture.c index 1df0c30..9a3ccb5

[Mesa-dev] [PATCH] gallium: remove duplicate define from enum pipe_format

Signed-off-by: Oded Gabbay <oded.gab...@gmail.com> --- src/gallium/include/pipe/p_format.h | 1 - 1 file changed, 1 deletion(-) diff --git a/src/gallium/include/pipe/p_format.h b/src/gallium/include/pipe/p_format.h index d9c9f9b..ab18523 100644 --- a/src/gallium/include/pipe/p_format.h

Re: [Mesa-dev] [PATCH] gallium/radeon: Correctly translate colorswaps for big endian

On Tue, Feb 23, 2016 at 5:45 PM, Marek Olšák <mar...@gmail.com> wrote: > On Tue, Feb 23, 2016 at 4:41 PM, Oded Gabbay <oded.gab...@gmail.com> wrote: >> The current code in r600_translate_colorswap uses the swizzle information >> to determine which colorswap to use. &

[Mesa-dev] [PATCH] gallium/radeon: Correctly translate colorswaps for big endian

ned-off-by: Oded Gabbay <oded.gab...@gmail.com> CC: "11.1" <mesa-sta...@lists.freedesktop.org> --- src/gallium/drivers/radeon/r600_texture.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/src/gallium/drivers/radeon/r600_texture.c b/src/gallium/drivers/radeon

[Mesa-dev] [PATCH 2/2] gallivm: Check whether to stop disassemble only for x86

Because the if statement that checks whether we have a return statement is valid only on x86, surround it with X86 or X86-64 arch defines Signed-off-by: Oded Gabbay <oded.gab...@gmail.com> --- src/gallium/auxiliary/gallivm/lp_bld_debug.cpp | 2 ++ 1 file changed, 2 insertions(+) diff

[Mesa-dev] [PATCH 1/2] gallivm: use sstream for dissasembling

). Signed-off-by: Oded Gabbay <oded.gab...@gmail.com> --- src/gallium/auxiliary/gallivm/lp_bld_debug.cpp | 51 +++--- 1 file changed, 30 insertions(+), 21 deletions(-) diff --git a/src/gallium/auxiliary/gallivm/lp_bld_debug.cpp b/src/gallium/auxiliary/gallivm/lp_bld_deb

Re: [Mesa-dev] [PATCH] mesa: Fix test for big-endian architecture in compiler.h

On Tue, Feb 16, 2016 at 9:23 AM, Jonathan Gray wrote: > On Fri, Feb 12, 2016 at 10:01:21AM +0100, Jochen Rollwagen wrote: >> Hi, >> >> i think i found & fixed a bug in mesa concerning tests for big-endian >> machines. The defines tested don't exist or are wrongly defined so the

Re: [Mesa-dev] [PATCH] mesa: Fix test for big-endian architecture in compiler.h

On Mon, Feb 15, 2016 at 8:33 PM, Jochen Rollwagen <joro-2...@t-online.de> wrote: > Am 15.02.2016 um 15:53 schrieb Oded Gabbay: >> >> Sent with MailTrack >> >> On Sat, Feb 13, 2016 at 2:39 AM, Roland Scheidegger <srol...@vmware.com> >> wrote: >>&g

Re: [Mesa-dev] [PATCH] mesa: Fix test for big-endian architecture in compiler.h

h - which > defines those BYTE_ORDER etc. values. Albeit it includes this _after_ > these ifdefs... > But don't ask me how this is really supposed to work... > > Roland includes which includes However, this depends on the c/h files to include before including "compil

Re: [Mesa-dev] [Mesa-stable] New stable-branch 11.0 candidate pushed

On Tue, Jan 19, 2016 at 2:48 PM, Emil Velikov wrote: > > Hello list, > > The candidate for the Mesa 11.0.9 is now available. Currently we have: > - 22 queued > - 20 nominated (outstanding) > - and 1 rejected/obsolete patches > > Current queue addressed a few important

Re: [Mesa-dev] [PATCH] llvmpipe: use vpkswss when dst is signed

On Mon, Jan 18, 2016 at 12:40 AM, Jose Fonseca <jfons...@vmware.com> wrote: > On 17/01/16 20:55, Oded Gabbay wrote: >> >> This patch fixes a bug when building a pack instruction. >> >> For POWER (altivec), in case the destination is signed and the >>

Re: [Mesa-dev] [PATCH] llvmpipe: use vpkswss when dst is signed

On Sun, Jan 17, 2016 at 11:16 PM, Roland Scheidegger <srol...@vmware.com> wrote: > Reviewed-by: Roland Scheidegger <srol...@vmware.com> > > Am 17.01.2016 um 21:55 schrieb Oded Gabbay: >> This patch fixes a bug when building a pack instruction. >> >> For P

[Mesa-dev] [PATCH] llvmpipe: use vpkswss when dst is signed

@arb_color_buffer_float@gl_rgba8-drawpixels - shaders@glsl-fs-fogscale - spec@arb_timer_query@query gl_timestamp I've also corrected some coding style issues in the function. Signed-off-by: Oded Gabbay <oded.gab...@gmail.com> --- src/gallium/auxiliary/gallivm/lp_bld_pack.c | 44 --

[Mesa-dev] [PATCH] llvmpipe: fix arguments order given to vec_andc

won't return in another place, I added a wrapper function, vec_andnot_si128, in u_pwr8.h, which makes the swap inside. Signed-off-by: Oded Gabbay <oded.gab...@gmail.com> --- src/gallium/auxiliary/util/u_pwr8.h | 6 ++ src/gallium/drivers/llvmpipe/lp_setup_tri.c | 2 +- 2 files c

Re: [Mesa-dev] [PATCH] configure.ac: always define __STDC_CONSTANT_MACROS

On Mon, Jan 11, 2016 at 11:24 PM, Jose Fonseca <jfons...@vmware.com> wrote: > On 11/01/16 21:07, Oded Gabbay wrote: >> >> The ISO C99 standard (7.18.4) specifies that C++ >> implementations should define UINT64_C only when >> __STDC_CONSTANT_MACROS is defined.

  1   2   >