Re: [Mesa-dev] MESA_Build_ERROR

2019-03-18 Thread Sergii Romantsov
.h' there is no define of *memfd_create.* > > > --- > > Regards > > Milav > On 3/15/19 5:12 PM, Sergii Romantsov wrote: > > /home/teqdiligent

Re: [Mesa-dev] MESA_Build_ERROR

2019-03-15 Thread Sergii Romantsov
arm-cortexa8-linux-gnueabihf/bin/arm-cortexa8-linux-gnueabihf-objdump" > NM="/home/teqdiligent/HMI_SCADA/Toolchain/arm-cortexa8-linux-gnueabihf/bin/arm-cortexa8-linux-gnueabihf-nm" > > > > please help me to sort out this problem. >

Re: [Mesa-dev] [PATCH v1] nir: Length of boolean vtn_value now is 1

2019-01-23 Thread Sergii Romantsov
LGTM, so assuming it passes intel CI: >> >> Reviewed-by: Alejandro Piñeiro >> >> On 15/1/19 12:08, Sergii Romantsov wrote: >> > During conversion type-length was lost due to math. >> > >> > CC: Jason Ekstrand >> > Fixes: 44227453ec03 (nir: Swi

[Mesa-dev] [PATCH v1] nir: Length of boolean vtn_value now is 1

2019-01-15 Thread Sergii Romantsov
During conversion type-length was lost due to math. CC: Jason Ekstrand Fixes: 44227453ec03 (nir: Switch to using 1-bit Booleans for almost everything) Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109353 Signed-off-by: Sergii Romantsov --- src/compiler/spirv/spirv_to_nir.c | 9

[Mesa-dev] [PATCH v2] configure/vulkan: linking issue of Vulkan

2018-11-19 Thread Sergii Romantsov
From: Sergii Romantsov Xcb-dri3 is installed into custom directory. Installing of Vulkan on Ubuntu 16.04 fails during relinking. Potential reason: seems during relinking a path to the custom dri3-path is missed: glx.la depends on libloader_dri3_helper.la which depends on XCB_DRI3_LIBS

[Mesa-dev] [PATCH v4] mesa/driconf: rotation of 0-vector

2018-11-07 Thread Sergii Romantsov
equavalent to logic that magnitude of (0,0,0)-vector is 1.0. -v2: logic moved to _math_matrix_rotate -v3: general optimization of computations -v4: added compatible_0vector_rotation option CC: Tapani Pälli CC: Timothy Arceri CC: Brian Paul Signed-off-by: Sergii Romantsov Bugzilla: https://bugs.freedesk

[Mesa-dev] [PATCH v1] i965/batch/debug: Allow log be dumped before assert

2018-11-05 Thread Sergii Romantsov
Message that may show the culprit of assert now will be dumped before that for debug purposes. CC: Kenneth Graunke CC: Lionel G Landwerlin Signed-off-by: Sergii Romantsov --- src/mesa/drivers/dri/i965/intel_batchbuffer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src

Re: [Mesa-dev] [PATCH v3] autotools: library-dependency when no sse and 32-bit

2018-11-05 Thread Sergii Romantsov
Could, please, somebody push? On Thu, Nov 1, 2018 at 6:11 PM Dylan Baker wrote: > Reviewed-by: Dylan Baker > > Quoting Sergii Romantsov (2018-11-01 04:02:43) > > Building of 32bit Mesa may fail if __SSE__ is not specified. > > Added missed dependency from libm. > >

[Mesa-dev] [PATCH v3] autotools: library-dependency when no sse and 32-bit

2018-11-01 Thread Sergii Romantsov
=108560 Signed-off-by: Sergii Romantsov --- src/util/Makefile.am | 3 ++- src/util/meson.build | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/util/Makefile.am b/src/util/Makefile.am index d79f2b3..85c7553 100644 --- a/src/util/Makefile.am +++ b/src/util/Makefile.am

Re: [Mesa-dev] [PATCH v2] autotools: library-dependency when no sse and 32-bit

2018-11-01 Thread Sergii Romantsov
Hi, meson doesn't fail, but, probably, better to add for sure. Will do soon. On Thu, Nov 1, 2018 at 12:25 PM Lionel Landwerlin < lionel.g.landwer...@intel.com> wrote: > Hi Sergii, > > Do we need the same fix in meson? > > Thanks, > > - > Lionel > > On 01/1

Re: [Mesa-dev] [PATCH v2] autotools: library-dependency when no sse and 32-bit

2018-11-01 Thread Sergii Romantsov
Thanks, Dylan. Could, please, somebody push it? On Tue, Oct 30, 2018 at 5:30 PM Dylan Baker wrote: > Reviewed-by: Dylan Baker > > Quoting Sergii Romantsov (2018-10-30 02:45:14) > > Building of 32bit Mesa may fail if __SSE__ is not specified. > > Added missed dependency

Re: [Mesa-dev] [PATCH] intel/aubinator_error_decode: link libm

2018-11-01 Thread Sergii Romantsov
LIB_LIBS) \ > + -lm > > tools_aubinator_error_decode_CFLAGS = \ > $(AM_CFLAGS) \ > -- > 2.19.1 > > ___ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > https://lists.free

Re: [Mesa-dev] [PATCH v1 1/5] meson: compilation flags for sse

2018-10-30 Thread Sergii Romantsov
id). > > But if we don't need such optimization, than it will be nice at least to > fix > > autotools 32b build (https://patchwork.freedesktop.org/patch/258659/) - > i will > > update patch just by linking -lm with mesautil. > > Yeah, I think we should land that if it fi

[Mesa-dev] [PATCH v2] autotools: library-dependency when no sse and 32-bit

2018-10-30 Thread Sergii Romantsov
Building of 32bit Mesa may fail if __SSE__ is not specified. Added missed dependency from libm. CC: Dylan Baker Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108560 Signed-off-by: Sergii Romantsov --- src/util/Makefile.am | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff

Re: [Mesa-dev] [PATCH v1 1/5] meson: compilation flags for sse

2018-10-29 Thread Sergii Romantsov
date patch just by linking -lm with mesautil. Please, advise. On Fri, Oct 26, 2018 at 9:54 PM Dylan Baker wrote: > Quoting Matt Turner (2018-10-26 10:44:47) > > On Fri, Oct 26, 2018 at 3:06 AM Sergii Romantsov > > wrote: > > > > > > While building of 32b

[Mesa-dev] [PATCH v1 4/5] autotools: library-dependency when no sse and 32-bit

2018-10-26 Thread Sergii Romantsov
Building of 32bit Mesa may fail if __SSE__ is not specified. Added missed dependency from libm. CC: Dylan Baker Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108560 Signed-off-by: Sergii Romantsov --- src/util/Makefile.am | 5 + 1 file changed, 5 insertions(+) diff --git a/src

[Mesa-dev] [PATCH v1 3/5] autotools: compilation flags for sse

2018-10-26 Thread Sergii Romantsov
While building of 32bit Mesa gcc doesn't specifies __SSE__ by default. So it has to be done manually by flag '-msee'. Added support of such specification to build-system. CC: Dylan Baker Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108560 Signed-off-by: Sergii Romantsov

[Mesa-dev] [PATCH v1 2/5] meson: specify -msse manually for 32-bit build

2018-10-26 Thread Sergii Romantsov
?id=108560 Signed-off-by: Sergii Romantsov --- src/compiler/glsl/meson.build | 2 +- src/compiler/meson.build| 4 ++-- src/compiler/nir/meson.build| 2 +- src/glx/meson.build | 2 +- src/intel/blorp/meson.build | 2 +- src/intel

[Mesa-dev] [PATCH v1 1/5] meson: compilation flags for sse

2018-10-26 Thread Sergii Romantsov
While building of 32bit Mesa gcc doesn't specifies __SSE__ by default. So it has to be done manually by flag '-msee'. Added support of such specification to build-system. CC: Dylan Baker Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108560 Signed-off-by: Sergii Romantsov

[Mesa-dev] [PATCH v1 5/5] autotools: specify -msse manually for 32-bit build

2018-10-26 Thread Sergii Romantsov
?id=108560 Signed-off-by: Sergii Romantsov --- src/Makefile.am | 2 +- src/compiler/Makefile.am| 6 -- src/glx/Makefile.am | 3 ++- src/intel/Makefile.am | 6 -- src/intel/Makefile.common.am| 2 +- src

Re: [Mesa-dev] [PATCH v3] mesa: rotation of 0-vector

2018-10-10 Thread Sergii Romantsov
Hello, i've updated a test for the latest version of mesa-patch: https://patchwork.freedesktop.org/patch/255629/ The image should looks for any driver (Windows, Nvidia, mesa) like this: [image: Screenshot from 2018-10-10 13-47-56.png] On Fri, Sep 21, 2018 at 4:21 PM Sergii Romantsov wrote

Re: [Mesa-dev] [PATCH v1] loader/dri3: wait for fences if back-buffer available

2018-10-01 Thread Sergii Romantsov
Yes, it also works On Mon, Oct 1, 2018 at 5:24 PM Michel Dänzer wrote: > On 2018-10-01 12:37 p.m., Sergii Romantsov wrote: > > Kabylake doesn't have such issue, but also it doesn't have > > a front buffers in that case. > > Coffelake can be fixed if to wait for fences

[Mesa-dev] [PATCH v1] loader/dri3: wait for fences if back-buffer available

2018-10-01 Thread Sergii Romantsov
in dri3_get_buffer) CC: Michel Dänzer Signed-off-by: Sergii Romantsov --- src/loader/loader_dri3_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/loader/loader_dri3_helper.c b/src/loader/loader_dri3_helper.c index 258678a..e9f59a2 100644 --- a/src/loader/loader_dri3_helper.c

[Mesa-dev] [PATCH v3] mesa: rotation of 0-vector

2018-09-21 Thread Sergii Romantsov
equavalent to logic that magnitude of (0,0,0)-vector is 1.0. -v2: logic moved to _math_matrix_rotate -v3: general optimization of computations Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=100960 Signed-off-by: Sergii Romantsov --- src/mesa/math/m_matrix.c | 12 1 file changed, 12

Re: [Mesa-dev] [ANNOUNCE] Mesa 18.2.1 release candidate

2018-09-20 Thread Sergii Romantsov
Hello, about rejected: > Sergii Romantsov (1): > 4aec44c0d9c i965/tools: 32bit compilation with meson > Reason: this commit was immediately reverted by commit 2dce1175c1c. Actually, commit 'i965/tools: 32bit compilation with meson' depends on 'intel: compiler opt

[Mesa-dev] [PATCH v2] anv/skylake: disable ForceThreadDispatchEnable

2018-09-19 Thread Sergii Romantsov
(anv: Stop setting 3DSTATE_PS_EXTRA::PixelShaderHasUAV) Signed-off-by: Sergii Romantsov --- src/intel/vulkan/genX_pipeline.c | 33 - 1 file changed, 32 insertions(+), 1 deletion(-) diff --git a/src/intel/vulkan/genX_pipeline.c b/src/intel/vulkan/genX_pipeline.c

Re: [Mesa-dev] [PATCH v1] anv/skylake: disable ForceThreadDispatchEnable

2018-09-19 Thread Sergii Romantsov
Probably there should be some much more complex conditions for doing that, but as initial solution... On Wed, Sep 19, 2018 at 6:55 PM, Sergii Romantsov < sergii.romant...@gmail.com> wrote: > On Skylake enabling of ForceThreadDispatchEnable causes gpu-hang. > > CC: Jason Ekstr

[Mesa-dev] [PATCH v1] anv/skylake: disable ForceThreadDispatchEnable

2018-09-19 Thread Sergii Romantsov
On Skylake enabling of ForceThreadDispatchEnable causes gpu-hang. CC: Jason Ekstrand Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107941 Fixes: 79270d2140ec (anv: Stop setting 3DSTATE_PS_EXTRA::PixelShaderHasUAV) Signed-off-by: Sergii Romantsov --- src/intel/vulkan/genX_pipeline.c

Re: [Mesa-dev] [PATCH v2] mesa: rotation of 0-vector

2018-09-18 Thread Sergii Romantsov
2018 o 15:59 Sergii Romantsov > napisał(a): > > > > Specification doesn't define behaviour for rotation of 0-vector. > > Windows and Nvidia drivers have a workaround for that. > > For compatibility proposed that for 0-vector a rotation will be > > do

Re: [Mesa-dev] [PATCH v2] mesa: rotation of 0-vector

2018-09-18 Thread Sergii Romantsov
Uploaded new version. Seems that waiting for any response on https://github.com/KhronosGroup/OpenGL-API/issues/41 may take much more time On Tue, Sep 18, 2018 at 4:57 PM, Sergii Romantsov < sergii.romant...@gmail.com> wrote: > Specification doesn't define behaviour for rotation of

[Mesa-dev] [PATCH v2] mesa: rotation of 0-vector

2018-09-18 Thread Sergii Romantsov
?id=100960 Signed-off-by: Sergii Romantsov --- src/mesa/math/m_matrix.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/src/mesa/math/m_matrix.c b/src/mesa/math/m_matrix.c index 57a4953..2b3adb3 100644 --- a/src/mesa/math/m_matrix.c +++ b/src/mesa/math/m_matrix.c @@ -824,6

Re: [Mesa-dev] [PATCH v1] autotools: multiple definitions for libmesagallium

2018-09-18 Thread Sergii Romantsov
; build that uses autotools just to cover everything? > > > > > Dylan > > > > Quoting Sergii Romantsov (2018-09-17 03:23:04) > > > Error of multiple definitions for libmesagallium and libmesautil may > > be > > > fixed by linker-option allow-multiple-

[Mesa-dev] [PATCH v1] autotools: multiple definitions for libmesagallium

2018-09-17 Thread Sergii Romantsov
Error of multiple definitions for libmesagallium and libmesautil may be fixed by linker-option allow-multiple-definition CC: Dylan Baker Fixes: 8396043f304b (Replace uses of _mesa_bitcount with util_bitcount) Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107923 Signed-off-by: Sergii

Re: [Mesa-dev] [PATCH v1] glsl: missed error_emitted for do_assignment

2018-09-14 Thread Sergii Romantsov
Seems that patch is simplified version of already exist one: https://patchwork.freedesktop.org/series/48256/ On Fri, Sep 14, 2018 at 4:39 PM, Sergii Romantsov < sergii.romant...@gmail.com> wrote: > During do_assignment a validation of rhs may fail. > Because of lack error_emitted an

[Mesa-dev] [PATCH v1] glsl: missed error_emitted for do_assignment

2018-09-14 Thread Sergii Romantsov
During do_assignment a validation of rhs may fail. Because of lack error_emitted an error_value may not be generated. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107547 Signed-off-by: Sergii Romantsov --- src/compiler/glsl/ast_to_hir.cpp | 2 ++ 1 file changed, 2 insertions(+) diff

Re: [Mesa-dev] [PATCH v1] mesa: rotation of 0-vector

2018-09-13 Thread Sergii Romantsov
%7C1% >>> 7C0%7C636723558454036605sdata=IAlt%2FkpHJyb5JHRYaOTfhf5 >>> v9V7Xl5iQBNBdqe2PHQs%3Dreserved=0 >>> Signed-off-by: Sergii Romantsov >>> --- >>> src/mesa/main/matrix.c | 5 + >>> 1 file changed, 5 insertions(+) >>> >>>

[Mesa-dev] [PATCH v1] mesa: rotation of 0-vector

2018-09-12 Thread Sergii Romantsov
Specification doesn't define behaviour for rotation of 0-vector. But khronos.org says that vector has to be normalized. As workaround assumed that for 0-vector x-position will be defined as 1.0f. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=100960 Signed-off-by: Sergii Romantsov

Re: [Mesa-dev] [PATCH v3] mesa/meson: 32bit xmlconfig linkage

2018-09-10 Thread Sergii Romantsov
Hello, just reminder for case: don't have push-rights... On Fri, Sep 7, 2018 at 8:05 PM, Dylan Baker wrote: > Quoting Sergii Romantsov (2018-09-07 02:43:41) > > Building of 32bit mesa with meson causes linkage issue: > > "undefined reference to `util_get_process_name'"

Re: [Mesa-dev] [PATCH v5] intel: compiler option msse2 and mstackrealign

2018-09-07 Thread Sergii Romantsov
7/09/2018 10:57, Lionel Landwerlin wrote: > > There was a test that failed, but I think it might be flakyness. > I'm retrying one more time. Will get back to you in ~1h. > > - > Lionel > > On 07/09/2018 10:32, Sergii Romantsov wrote: > > Hello, Lionel. > Any regression with

[Mesa-dev] [PATCH v3] mesa/meson: 32bit xmlconfig linkage

2018-09-07 Thread Sergii Romantsov
esktop.org/show_bug.cgi?id=107843 Fixes: 2e1e6511f76370870b5cd "util: extract get_process_name from xmlconfig.c" Cc: Marek Olšák Cc: Dylan Baker Signed-off-by: Sergii Romantsov Reviewed-by: Eric Engestrom --- src/util/meson.build | 1 + 1 file changed, 1 insertion(+) diff --git a/sr

Re: [Mesa-dev] [PATCH v5] intel: compiler option msse2 and mstackrealign

2018-09-07 Thread Sergii Romantsov
Hello, Lionel. Any regression with CI? On Thu, Sep 6, 2018 at 12:33 PM, Lionel Landwerlin < lionel.g.landwer...@intel.com> wrote: > Giving it a run through CI and I'll push after. > > Thanks! > > > On 06/09/2018 09:07, Sergii Romantsov wrote: > >> Seems in case

Re: [Mesa-dev] [PATCH v1] mesa/meson: 32bit xmlconfig linkage

2018-09-07 Thread Sergii Romantsov
Hello, Eric. but we don't want to remove libmesa_util from the other libs Does it mean to revert src/gbm/meson.build and src/glx/meson.build ? On Thu, Sep 6, 2018 at 8:30 PM, Eric Engestrom wrote: > On Thursday, 2018-09-06 17:38:36 +0300, Sergii Romantsov wrote: > > Building of 3

[Mesa-dev] [PATCH v2] mesa/meson: 32bit xmlconfig linkage

2018-09-07 Thread Sergii Romantsov
7843 Fixes: 2e1e6511f76370870b5cd "util: extract get_process_name from xmlconfig.c" Cc: Marek Olšák Cc: Dylan Baker Signed-off-by: Sergii Romantsov Reviewed-by: Eric Engestrom --- src/gbm/meson.build | 2 +- src/glx/meson.build | 2 +- src/util/meson.build | 1 + 3 files changed, 3 insertions(+), 2 dele

Re: [Mesa-dev] [PATCH v1] mesa/meson: 32bit xmlconfig linkage

2018-09-06 Thread Sergii Romantsov
Probably, here is a sense to remove constructions similar to 'libmesa_util, libxmlconfig' and left only libxmlconfig for the rest of meson.build files. Any doubts? On Thu, Sep 6, 2018 at 5:38 PM, Sergii Romantsov wrote: > Building of 32bit mesa with meson causes linkage issue: > &quo

[Mesa-dev] [PATCH v1] mesa/meson: 32bit xmlconfig linkage

2018-09-06 Thread Sergii Romantsov
Building of 32bit mesa with meson causes linkage issue: "undefined reference to `util_get_process_name'" Fixed by adding link-with mesa_util for xmlconfig primary. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107843 Signed-off-by: Sergii Romantsov --- src/gbm/meson.build |

Re: [Mesa-dev] [PATCH v1 2/2] driconf: replaced file with defines

2018-09-06 Thread Sergii Romantsov
Looks like you are right. After 'git clean' its ok. Thanks. On Thu, Sep 6, 2018 at 2:37 PM Eric Engestrom wrote: > On Thursday, 2018-09-06 12:59:48 +0300, Sergii Romantsov wrote: > > Building of 32bit mesa with meson causes issues: > > "expected ‘}’ before ‘DR

Re: [Mesa-dev] [PATCH v1 1/2] i965/tools: 32bit compilation with meson

2018-09-06 Thread Sergii Romantsov
wrote: > Aren't other tools affected as well? > > Thanks, > > - > Lionel > > On 06/09/2018 10:59, Sergii Romantsov wrote: > >> Building of 32bit mesa with meson causes issue: >> "implicit declaration of function ‘__builtin_ia32_clflush’". >>

[Mesa-dev] [PATCH v1 2/2] driconf: replaced file with defines

2018-09-06 Thread Sergii Romantsov
d to correct. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107843 Signed-off-by: Sergii Romantsov --- src/util/xmlpool.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/xmlpool.h b/src/util/xmlpool.h index ebd4e7c..f2181ce 100644 --- a/src/util/xmlpool.h +++ b/src/u

[Mesa-dev] [PATCH v1 1/2] i965/tools: 32bit compilation with meson

2018-09-06 Thread Sergii Romantsov
Signed-off-by: Sergii Romantsov --- src/intel/tools/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/tools/meson.build b/src/intel/tools/meson.build index 3617478..44d6bdd 100644 --- a/src/intel/tools/meson.build +++ b/src/intel/tools/meson.build @@ -

Re: [Mesa-dev] [Mesa-stable] [PATCH v4] i965: compiler option msse2 and mstackrealign

2018-09-06 Thread Sergii Romantsov
Hello, can you replace i965 with intel in the title of the commit done I assume you have commit access? Unfortunately, i don't. Thanks everybody for pointing details. On Wed, Sep 5, 2018 at 8:41 PM, Dylan Baker wrote: > Quoting Sergii Romantsov (2018-09-05 04:40:37) > > Seems in c

[Mesa-dev] [PATCH v5] intel: compiler option msse2 and mstackrealign

2018-09-06 Thread Sergii Romantsov
: Added for Vulkan also. v5: Commit message correction. CC: Fixes: 6b05c080f202 (i965: Compile with -msse3) Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107779 Signed-off-by: Sergii Romantsov Reviewed-by: Dylan Baker Reviewed-by: Emil Velikov Reviewed-by: Lionel Landwerlin --- src

[Mesa-dev] [PATCH v4] i965: compiler option msse2 and mstackrealign

2018-09-05 Thread Sergii Romantsov
: Added for Vulkan also. CC: Fixes: 6b05c080f202 (i965: Compile with -msse3) Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107779 Signed-off-by: Sergii Romantsov --- src/intel/Makefile.vulkan.am | 2 +- src/intel/meson.build | 1 + src/intel/vulkan/meson.build

[Mesa-dev] [PATCH v3] i965: compiler option msse2 and mstackrealign

2018-09-05 Thread Sergii Romantsov
: Fixes: 6b05c080f202 (i965: Compile with -msse3) Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107779 Signed-off-by: Sergii Romantsov --- src/intel/meson.build | 1 + src/mesa/Android.libmesa_dricore.mk | 2 +- src/mesa/Android.libmesa_sse41.mk | 2 +- src/mesa/drivers

Re: [Mesa-dev] [PATCH v1] i965: compiler option msse2 and mstackrealign

2018-09-05 Thread Sergii Romantsov
should i do anything with that? On Wed, Sep 5, 2018 at 1:19 AM, Dylan Baker wrote: > Quoting Sergii Romantsov (2018-09-04 03:46:23) > > Seems in case of 32-bit library, usage of msse2 makes > > some stack corruption or incorrect instructions. > > Usage with mstackrealign

[Mesa-dev] [PATCH v2] i965: compiler option msse2 and mstackrealign

2018-09-05 Thread Sergii Romantsov
Seems in case of 32-bit library, usage of msse2 makes some stack corruption or incorrect instructions. Usage with mstackrealign fixes that case. v2: fixed meson Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107779 Signed-off-by: Sergii Romantsov --- src/intel/meson.build

[Mesa-dev] [PATCH v1] i965: compiler option msse2 and mstackrealign

2018-09-04 Thread Sergii Romantsov
Seems in case of 32-bit library, usage of msse2 makes some stack corruption or incorrect instructions. Usage with mstackrealign fixes that case. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107779 Signed-off-by: Sergii Romantsov --- src/mesa/drivers/dri/i965/Makefile.am | 2 +- 1 file

[Mesa-dev] [PATCH v1 1/2] glsl/standalone: segfault with --dump-builder for ir_texture

2018-08-31 Thread Sergii Romantsov
Shader that contains builtin functions texture* causes segfault for standalone compiler with parameter --dump-builder. Added handling of ir_texture as rhs of assignment. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107767 Signed-off-by: Sergii Romantsov --- src/compiler/glsl

[Mesa-dev] [PATCH v1 2/2] glsl/standalone: --dump-builder: dump of ir_texture

2018-08-31 Thread Sergii Romantsov
For standalone compilation with parameter --dump-builder in dump absent description of texture invocation. Added the simplest handling. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107767 Signed-off-by: Sergii Romantsov --- src/compiler/glsl/ir_builder_print_visitor.cpp | 51

[Mesa-dev] [PATCH v1] configure/vulkan: linking issue of Vulkan

2018-08-20 Thread Sergii Romantsov
Installing of Vulkan on Ubuntu 16.04 fails during relinking. Seems caught libtool-issue. Library-dependicies GL_LIB_DEPS moved upper. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107624 Signed-off-by: Sergii Romantsov --- src/glx/Makefile.am | 4 ++-- 1 file changed, 2 insertions

[Mesa-dev] [PATCH v2] configure/intel: checking for correct xcb-randr version

2018-08-17 Thread Sergii Romantsov
Fixes: 7ab1fffcd2a5 (vulkan: Add EXT_acquire_xlib_display [v5]) Signed-off-by: Sergii Romantsov --- configure.ac | 24 ++-- 1 file changed, 10 insertions(+), 14 deletions(-) diff --git a/configure.ac b/configure.ac index 2f1d13c..c73e0b0 100644 --- a/configure.ac +++ b

Re: [Mesa-dev] [PATCH v5 1/2] intel/ppgtt: memory address alignment

2018-08-16 Thread Sergii Romantsov
And also thanks to you :). On Thu, Aug 16, 2018 at 4:16 PM, Lionel Landwerlin < lionel.g.landwer...@intel.com> wrote: > Both patches pushed to master. > > Thanks! > > - > Lionel > > > On 15/08/18 16:03, Lionel Landwerlin wrote: > >> On 15/08/18 12

[Mesa-dev] [PATCH v1] configure/intel: checking for correct xcb-randr version

2018-08-16 Thread Sergii Romantsov
EXT_acquire_xlib_display [v5]) Signed-off-by: Sergii Romantsov --- configure.ac | 24 ++-- 1 file changed, 10 insertions(+), 14 deletions(-) diff --git a/configure.ac b/configure.ac index c2155a5..fb4e501 100644 --- a/configure.ac +++ b/configure.ac @@ -97,6 +97,7

Re: [Mesa-dev] [PATCH v1] i965: Emitting 3DSTATE_SO_BUFFER of 0-size.

2018-08-15 Thread Sergii Romantsov
e empty. " And seems additional one: https://patchwork.freedesktop.org/patch/244674/ On Wed, Aug 15, 2018 at 3:21 PM, Sergii Romantsov < sergii.romant...@gmail.com> wrote: > Avoided filling of whole structure and bo-allocation if > size of surface is 0. > > Signed-off-by: S

[Mesa-dev] [PATCH v1] i965/bo/perf: 0-sized-bo allocation log

2018-08-15 Thread Sergii Romantsov
Added debug-log in case of bo-allocation with 0 size. Potentially we may not need to allocate such buffers and each case could be analyzed to improve behaviour. Signed-off-by: Sergii Romantsov --- src/mesa/drivers/dri/i965/brw_bufmgr.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src

[Mesa-dev] [PATCH v1] i965: Emitting 3DSTATE_SO_BUFFER of 0-size.

2018-08-15 Thread Sergii Romantsov
Avoided filling of whole structure and bo-allocation if size of surface is 0. Signed-off-by: Sergii Romantsov --- src/mesa/drivers/dri/i965/genX_state_upload.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/mesa/drivers/dri/i965/genX_state_upload.c b/src/mesa

[Mesa-dev] [PATCH v5 1/2] intel/ppgtt: memory address alignment

2018-08-15 Thread Sergii Romantsov
.) Signed-off-by: Sergii Romantsov --- src/mesa/drivers/dri/i965/brw_bufmgr.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_bufmgr.c b/src/mesa/drivers/dri/i965/brw_bufmgr.c index 09d45e3..19e2d14 100644 --- a/src/mesa/drivers/dri/i965

[Mesa-dev] [PATCH v5 2/2] intel/ppgtt: 4096 replaced by PAGE_SIZE

2018-08-15 Thread Sergii Romantsov
Usage of number 4096 replaced by PAGE_SIZE. Signed-off-by: Sergii Romantsov --- src/mesa/drivers/dri/i965/brw_bufmgr.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_bufmgr.c b/src/mesa/drivers/dri/i965/brw_bufmgr.c index 19e2d14

Re: [Mesa-dev] [PATCH v4 1/2] intel/ppgtt: memory address alignment

2018-08-15 Thread Sergii Romantsov
ting 0 size BOs. > It looks like most of them come from the 3DSTATE_SO_BUFFER code, > where one stream has valid transform feedback info, and the other > 3 are empty. Whoops. > > Would you like to fix that, or should I? > > --Ken > > On Tuesday, August 14, 2018 4:28:35 AM

Re: [Mesa-dev] [PATCH v4 1/2] intel/ppgtt: memory address alignment

2018-08-14 Thread Sergii Romantsov
Hello, seems some part of the World is still may waiting for a possibility to play Dying Light... till pushed :) On Mon, Aug 6, 2018 at 4:26 PM, Lionel Landwerlin < lionel.g.landwer...@intel.com> wrote: > On 06/08/18 13:41, Sergii Romantsov wrote: > >> Kernel (for ppgtt) requi

[Mesa-dev] [PATCH v4 1/2] intel/ppgtt: memory address alignment

2018-08-06 Thread Sergii Romantsov
to separate commit Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106997 Fixes: a363bb2cd0e2 (i965: Allocate VMA in userspace for full-PPGTT systems.) Fixes: 01058a552294 (i965: Add virtual memory allocator infrastructure to brw_bufmgr.) Signed-off-by: Sergii Romantsov --- src/mesa

[Mesa-dev] [PATCH v4 2/2] intel/ppgtt: 4096 replaced by PAGE_SIZE

2018-08-06 Thread Sergii Romantsov
Usage of number 4096 replaced by PAGE_SIZE. Signed-off-by: Sergii Romantsov --- src/mesa/drivers/dri/i965/brw_bufmgr.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_bufmgr.c b/src/mesa/drivers/dri/i965/brw_bufmgr.c index 8274c2e

Re: [Mesa-dev] [PATCH v3] intel/ppgtt: memory address alignment

2018-07-27 Thread Sergii Romantsov
Hello, Kenneth and Lionel. Maybe, could we make a final review? On Wed, Jul 25, 2018 at 4:24 PM, Sergii Romantsov < sergii.romant...@globallogic.com> wrote: > Sorry, > do we have any objections about PAGE_SIZE usage instead of 4096? > > And what do you think if, maybe, some a

Re: [Mesa-dev] [PATCH v3] intel/ppgtt: memory address alignment

2018-07-25 Thread Sergii Romantsov
Sorry, do we have any objections about PAGE_SIZE usage instead of 4096? And what do you think if, maybe, some auto Intel-internal tests to run with that patch? On Wed, Jul 25, 2018 at 1:21 PM, Sergii Romantsov < sergii.romant...@gmail.com> wrote: > Kernel (for ppgtt) requires memor

[Mesa-dev] [PATCH v3] intel/ppgtt: memory address alignment

2018-07-25 Thread Sergii Romantsov
/show_bug.cgi?id=106997 Fixes: a363bb2cd0e2 (i965: Allocate VMA in userspace for full-PPGTT systems.) Fixes: 01058a552294 (i965: Add virtual memory allocator infrastructure to brw_bufmgr.) Signed-off-by: Sergii Romantsov --- src/mesa/drivers/dri/i965/brw_bufmgr.c | 19 +-- 1 file

Re: [Mesa-dev] [PATCH v2] intel/ppgtt: memory address alignment

2018-07-25 Thread Sergii Romantsov
, Chris Wilson wrote: > Quoting Sergii Romantsov (2018-07-25 08:42:55) > > Hello, > > here is a backtrace: > ... > > Please try: > diff --git a/src/mesa/drivers/dri/i965/brw_bufmgr.c > b/src/mesa/drivers/dri/i965/brw_bufmgr.c > index 09d45e30ecc..8274c2e0b2f 100644

Re: [Mesa-dev] [PATCH v2] intel/ppgtt: memory address alignment

2018-07-25 Thread Sergii Romantsov
bug locally, would you mind adding > > assert(size % 4096 == 0); > > at the top of vma_alloc() and see if it hits the asserts. > Having a backtrace would be great :) > > Thanks a lot, > > - > Lionel > > ___ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/mesa-dev > -- Sergii Romantsov GlobalLogic Inc. www.globallogic.com ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH v2] intel/ppgtt: memory address alignment

2018-07-24 Thread Sergii Romantsov
Hello, Kenneth. Looks like you are expert in memory management for i965. Could you, please, point me if that idea of patch is correct and what could i improve? Seems its better somehow to bind it to I915_GTT_PAGE_SIZE... right? On Tue, Jul 24, 2018 at 2:50 PM, Sergii Romantsov < sergii.rom

[Mesa-dev] [PATCH v2] intel/ppgtt: memory address alignment

2018-07-24 Thread Sergii Romantsov
: Allocate VMA in userspace for full-PPGTT systems.) Fixes: 01058a552294 (i965: Add virtual memory allocator infrastructure to brw_bufmgr.) Signed-off-by: Sergii Romantsov --- src/mesa/drivers/dri/i965/brw_bufmgr.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/mesa

[Mesa-dev] [PATCH] intel/ppgtt: memory address alignment

2018-07-23 Thread Sergii Romantsov
-by: Sergii Romantsov --- src/mesa/drivers/dri/i965/brw_bufmgr.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_bufmgr.c b/src/mesa/drivers/dri/i965/brw_bufmgr.c index 09d45e3..8383735 100644 --- a/src/mesa/drivers/dri/i965/brw_bufmgr.c +++ b

Re: [Mesa-dev] [PATCH v2] intel/batch_decoder: decoding of 3DSTATE_CONSTANT_BODY.

2018-07-16 Thread Sergii Romantsov
Hello, Kenneth. Any more remarks? On Thu, Jul 12, 2018 at 3:47 PM, Sergii Romantsov < sergii.romant...@gmail.com> wrote: > SNB doesn't have a definition of 3DSTATE_CONSTANT_BODY, thats > why we got segmentation fault when used INTEL_DEBUG=bat. > Fixed by adding of 3DSTAT

[Mesa-dev] [PATCH v2] intel/batch_decoder: decoding of 3DSTATE_CONSTANT_BODY.

2018-07-12 Thread Sergii Romantsov
(intel: Fix 3DSTATE_CONSTANT buffer decoding.) Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107190 Signed-off-by: Sergii Romantsov --- src/intel/genxml/gen6.xml | 38 ++- src/mesa/drivers/dri/i965/genX_state_upload.c | 12 - 2 files changed

[Mesa-dev] [PATCH] intel/batch_decoder: decoding of 3DSTATE_CONSTANT_BODY.

2018-07-11 Thread Sergii Romantsov
://bugs.freedesktop.org/show_bug.cgi?id=107190 Signed-off-by: Sergii Romantsov --- src/intel/common/gen_batch_decoder.c | 4 1 file changed, 4 insertions(+) diff --git a/src/intel/common/gen_batch_decoder.c b/src/intel/common/gen_batch_decoder.c index fe7536d..973221b 100644 --- a/src/intel/common

[Mesa-dev] [PATCH v1] configure.ac: Missed package 'wayland-egl-backend'

2018-06-12 Thread Sergii Romantsov
s than 18.10 don't have package libwayland-egl-backend-dev. To fix that issue used mesa-platfrom-header wayland-egl-backend.h. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106897 Signed-off-by: Sergii Romantsov --- configure.ac | 20 +

Re: [Mesa-dev] [PATCH] dri3: Only update number of back buffers in loader_dri3_get_buffers

2018-04-30 Thread Sergii Romantsov
update_drawable(driDrawable, draw)) >return false; > > + dri3_update_num_back(draw); > + > + /* Free no longer needed back buffers */ > + for (buf_id = draw->num_back; buf_id < LOADER_DRI3_MAX_BACK; buf_id++) > { > + if (draw->cur_blit_source != buf_id && draw->

Re: [Mesa-dev] [PATCH v2] dri3: Prevent multiple freeing of buffers.

2018-04-27 Thread Sergii Romantsov
Hello, Michel On 2018-04-10 09:44 AM, Sergii Romantsov wrote: > Commit 3160cb86aa92 adds optimization with flag 'reallocate'. > Processing of flag causes buffers freeing while pointer > is still hold in caller stack and than again used to be freed. > > Fixes: 3160cb86aa92 "

[Mesa-dev] [PATCH v3] dri3: Prevent multiple freeing of buffers.

2018-04-27 Thread Sergii Romantsov
y' instead of introducing new one. v3: added searching for back-buffer after potential freeing previous one. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105906 Signed-off-by: Sergii Romantsov <sergii.romant...@globallogic.com> Tested-by: Andriy Khulap <andriy.khu...@globallogic.c

Re: [Mesa-dev] [PATCH] dri3: Prevent multiple freeing of buffers.

2018-04-16 Thread Sergii Romantsov
:10 AM, Sergii Romantsov < sergii.romant...@gmail.com> wrote: > Hello, > i've updated patch simply, > but that seems requires additional checking because in call > *dri3_handle_present_event > *potentially may happens reset of '*busy*' with condition '*buf->pixmap > ==

Re: [Mesa-dev] [PATCH] dri3: Prevent multiple freeing of buffers.

2018-04-10 Thread Sergii Romantsov
wrote: > Hi, > > > On 04/06/2018 04:51 PM, Daniel Stone wrote: > >> Hi Sergii, >> >> On 6 April 2018 at 09:12, Sergii Romantsov <sergii.romant...@gmail.com> >> wrote: >> >>> Commit 3160cb86aa92 adds optimization with flag 'reallocate'. >&

[Mesa-dev] [PATCH v2] dri3: Prevent multiple freeing of buffers.

2018-04-10 Thread Sergii Romantsov
y' instead of introducing new one. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105906 Signed-off-by: Sergii Romantsov <sergii.romant...@globallogic.com> Tested-by: Andriy Khulap <andriy.khu...@globallogic.com> --- src/loader/loader_dri3_helper.c | 5 - 1 file changed, 4 ins

[Mesa-dev] [PATCH] dri3: Prevent multiple freeing of buffers.

2018-04-06 Thread Sergii Romantsov
esktop.org/show_bug.cgi?id=105906 Signed-off-by: Sergii Romantsov <sergii.romant...@globallogic.com> Tested-by: Andriy Khulap <andriy.khu...@globallogic.com> --- src/loader/loader_dri3_helper.c | 7 +-- src/loader/loader_dri3_helper.h | 1 + 2 files changed, 6 insertions(+), 2 de

Re: [Mesa-dev] [PATCH] i965: Extend the negative 32-bit deltas to 64-bits

2018-04-04 Thread Sergii Romantsov
r use 32-bit deltas so are unaffected by this issue. > > > > v2: > > used int32_t fucntion parameter instead of explicit type conversion. > > > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101408 > > Signed-off-by: Sergii Romantsov <sergii.romant.

[Mesa-dev] [PATCH v3] i965: Extend the negative 32-bit deltas to 64-bits

2018-04-04 Thread Sergii Romantsov
conversion. v3: added "Cc" into commit-message. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101408 Reviewed-by: Chris Wilson <ch...@chris-wilson.co.uk> Cc: "18.0" <mesa-sta...@lists.freedesktop.org> Signed-off-by: Sergii Romantsov <sergii.romant...@global

[Mesa-dev] [PATCH] i965: Extend the negative 32-bit deltas to 64-bits

2018-04-02 Thread Sergii Romantsov
conversion. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101408 Signed-off-by: Sergii Romantsov <sergii.romant...@globallogic.com> Tested-by: Andriy Khulap <andriy.khu...@globallogic.com> --- src/mesa/drivers/dri/i965/intel_batchbuffer.c | 2 +- 1 file changed, 1 insertion(+)

Re: [Mesa-dev] [PATCH] i965: Extend the negative 32-bit deltas to 64-bits

2018-03-27 Thread Sergii Romantsov
Hello Chris and Emil. Could we make a final decision? Because I'm bit confused what you are expecting exactly. I would prefer to left initial patch as is (if its possible). On Tue, Mar 27, 2018 at 9:20 AM, Sergii Romantsov < sergii.romant...@gmail.com> wrote: > Hello Stuart, >

Re: [Mesa-dev] [PATCH] i965: Extend the negative 32-bit deltas to 64-bits

2018-03-27 Thread Sergii Romantsov
; This includes not just the issues with the Mortar, but the other visual > artefacts that I've noticed with the player models and with other weapons > in the game. > > Many thanks for digging into this. > > > On 26 March 2018 at 23:22, Sergii Romantsov <sergii.romants

Re: [Mesa-dev] [PATCH] i965: Extend the negative 32-bit deltas to 64-bits

2018-03-26 Thread Sergii Romantsov
with similar type-conversion fix." On Mon, Mar 26, 2018 at 4:57 PM, Emil Velikov <emil.l.veli...@gmail.com> wrote: > On 26 March 2018 at 13:31, Chris Wilson <ch...@chris-wilson.co.uk> wrote: > > Quoting Sergii Romantsov (2018-03-26 13:16:24) > >> Negative deltas

Re: [Mesa-dev] [PATCH] i965: Extend the negative 32-bit deltas to 64-bits

2018-03-26 Thread Sergii Romantsov
. Regards, Sergii. On Mon, Mar 26, 2018 at 3:31 PM, Chris Wilson <ch...@chris-wilson.co.uk> wrote: > Quoting Sergii Romantsov (2018-03-26 13:16:24) > > Negative deltas are used to fake a range in a large buffer. > > See 900a5c91eeb3 > > "i965: Use negative relocation d

Re: [Mesa-dev] [PATCH] i965: Extend the negative 32-bit deltas to 64-bits

2018-03-26 Thread Sergii Romantsov
Hello, Stuart. Could You, please, test this patch? On Mon, Mar 26, 2018 at 3:16 PM, Sergii Romantsov < sergii.romant...@gmail.com> wrote: > Negative deltas are used to fake a range in a large buffer. > See 900a5c91eeb3 > "i965: Use negative relocation deltas to minimise vert

[Mesa-dev] [PATCH] i965: Extend the negative 32-bit deltas to 64-bits

2018-03-26 Thread Sergii Romantsov
e negavive values. Haswell and older use 32-bit deltas so are unaffected by this issue. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101408 Signed-off-by: Sergii Romantsov <sergii.romant...@globallogic.com> Tested-by: Andriy Khulap <andriy.khu...@globallogic.com> --- src