Re: [Mesa-dev] [PATCH] mesa: Remove GL_ARB_sampler_object depth compare error checking.

2015-10-09 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Am 2015-10-06 um 21:01 schrieb Brian Paul: > Thanks for reposting. Look OK to me. I'll commit it later. I see it is in. Thanks for taking care of this! Cheers, Stefan -BEGIN PGP SIGNATURE- Version: GnuPG v2

[Mesa-dev] [PATCH] mesa: Remove GL_ARB_sampler_object depth compare error checking.

2015-10-05 Thread Stefan Dösinger
Version 3: Simplify the code comment, word wrap commit description. Version 2: Return GL_FALSE if ARB_shadow is unsupported instead of pretending to store the value as suggested by Brian Paul. This fixes a GL error warning on r200 in Wine. The GL_ARB_sampler_objects extension does not specify a

Re: [Mesa-dev] [PATCH] Allow setting GL_TEXTURE_COMPARE_MODE on a sampler object without ARB_shadow support (v2).

2015-07-30 Thread Stefan Dösinger
: mesa: disable texture compare mode error checking for Wine On 07/30/2015 07:04 AM, Stefan Dösinger wrote: Version 2: Return GL_FALSE if ARB_shadow is unsupported instead of pretending to store the value as Please word wrap that line to 75 chars or less. suggested by Brian Paul

[Mesa-dev] [PATCH] Allow setting GL_TEXTURE_COMPARE_MODE on a sampler object without ARB_shadow support (v2).

2015-07-30 Thread Stefan Dösinger
Version 2: Return GL_FALSE if ARB_shadow is unsupported instead of pretending to store the value as suggested by Brian Paul. This fixes a GL error warning on r200 in Wine. The GL_ARB_sampler_objects extension does not specify a dependency on GL_ARB_shadow or GL_ARB_depth_texture for this value.

[Mesa-dev] [PATCH] mesa: Remove GL_ARB_sampler_object depth compare error checking.

2015-07-30 Thread Stefan Dösinger
Version 3: Simplify the code comment, word wrap commit description. Version 2: Return GL_FALSE if ARB_shadow is unsupported instead of pretending to store the value as suggested by Brian Paul. This fixes a GL error warning on r200 in Wine. The GL_ARB_sampler_objects extension does not specify a

[Mesa-dev] [PATCH] Allow setting GL_TEXTURE_COMPARE_MODE on a sampler object without ARB_shadow support.

2015-03-23 Thread Stefan Dösinger
This fixes a GL error warning on r200 in Wine. The GL_ARB_sampler_objects extension does not specify a dependency on GL_ARB_shadow or GL_ARB_depth_texture for this value. Just set the value and don't do anything else. It won't matter without a depth texture being assigned anyway. ---

[Mesa-dev] [PATCH] r300g: Fix the ATI1N swizzle.

2015-03-09 Thread Stefan Dösinger
This fixes the GL_COMPRESSED_RED_RGTC1 part of piglit's rgtc-teximage-01 test as well as the precision part of Wine's 3dc format test (fd.o bug 89156). The Z component seems to contain a lower precision version of the result, probably a temporary value from the decompression computation. The Y

Re: [Mesa-dev] [PATCH] r300g: Fix the ATI1N swizzle.

2015-03-09 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, Thanks for the quick feedback! Am 2015-03-09 um 16:20 schrieb Ilia Mirkin: I don't suppose you've tried adding RGTC1_SNORM/LATC1_SNORM into that condition? No, because the codepath isn't entered for them at all. There's an if(format !=

Re: [Mesa-dev] [PATCH] r300g: Fix the ATI1N swizzle.

2015-03-09 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 2015-03-09 um 17:19 schrieb Ilia Mirkin: It also has the additional problem that it doesn't do the swizzle workaround which apparently is necessary even for single-component textures. Do you mean the change I made in my patch? That part works

Re: [Mesa-dev] [PATCH] r300g: Fix the ATI1N swizzle.

2015-03-09 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 2015-03-09 um 16:53 schrieb Stefan Dösinger: I did test if LATC_UNORM and LATC_SNORM still work after my fix. LATC_SNORM is unchanged (broken in the same way as RGTC_SNORM) and LATC_UNORM now has the proper precision like RGTC_UNORM. I think

Re: [Mesa-dev] [PATCH v3 0/9] Gallium Nine

2014-11-19 Thread Stefan Dösinger
Am 18.11.2014 um 23:31 schrieb Emil Velikov emil.l.veli...@gmail.com: Hmm the binaries do not seem to match the source. Am I missing something ? Not sure. As you can see I've last touched them in January. It is possible that I have changed some things in the code and not updated the binaries on

Re: [Mesa-dev] [PATCH v3 0/9] Gallium Nine

2014-11-18 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 2014-11-18 19:36, schrieb Henri Verbeet: To clarify, that's not what I said. It's mostly just that I'd like to see some actual evidence for the (implicit) claim that the performance difference is largely due to inherent OpenGL API overhead. I

Re: [Mesa-dev] Direct3D 9 state tracker

2013-07-22 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 2013-07-22 15:39, schrieb Jose Fonseca: It seems to me that this would be more useful if the state tracker targeted not the D3D9 API, but the WDDM D3D9 DDI [2]. Targeting the DDI would allow, e.g., to share more code with rest of WINE (the

Re: [Mesa-dev] [PATCH 0/6] Eliminating unused built-in varyings

2013-06-20 Thread Stefan Dösinger
Hi, Am 19.06.2013 um 13:22 schrieb Marek Olšák mar...@gmail.com: Could somebody please review this series? I don't really know the code well enough to give a meaningful review, but I've tested the patches with Wine on r300g and they work as advertised :-) . Rendering is OK, and 3DMark2000

Re: [Mesa-dev] [PATCH] mesa syncobj: don't store a pointer to the set_entry

2012-12-11 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 2012-12-11 00:47, schrieb Ian Romanick: [ 760.187261] [drm:radeon_cs_ib_chunk] *ERROR* Invalid command stream ! [ 760.192898] radeon :01:00.0: evergreen_cs_track_validate_stencil:602 stencil read bo base 4148500480 not aligned with

Re: [Mesa-dev] [PATCH] mesa syncobj: don't store a pointer to the set_entry

2012-12-09 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 2012-12-08 22:24, schrieb Jordan Justen: This likely will fix https://bugs.freedesktop.org/show_bug.cgi?id=58012 (Regression since 56e95d3c) The crashes are gone on r300g and r600g. This is most likely unrelated, but on r600g I get broken

[Mesa-dev] [PATCH] r300: Don't disable destination read if the src blend factor needs it

2012-12-07 Thread Stefan Dösinger
The read can remain disabled if the src alpha factor needs it because the result would still be zero. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=57984 NOTE: This is a candidate for stable release branches. --- src/gallium/drivers/r300/r300_state.c | 12 ++-- 1 files

[Mesa-dev] [PATCH 1/4] r200: Initialize swrast before setting limits

2012-12-06 Thread Stefan Dösinger
Otherwise the driver announces 4096 vertex shader constants and other way too high limits. NOTE: This is a candidate for stable release branches. --- src/mesa/drivers/dri/r200/r200_context.c | 19 +-- 1 files changed, 9 insertions(+), 10 deletions(-) diff --git

[Mesa-dev] [PATCH 2/4] radeon: Initialize swrast before setting limits

2012-12-06 Thread Stefan Dösinger
NOTE: This is a candidate for stable release branches. --- src/mesa/drivers/dri/radeon/radeon_context.c | 18 +- 1 files changed, 9 insertions(+), 9 deletions(-) diff --git a/src/mesa/drivers/dri/radeon/radeon_context.c b/src/mesa/drivers/dri/radeon/radeon_context.c index

[Mesa-dev] [PATCH 3/4] meta: Disable GL_FRAGMENT_SHADER_ATI in MESA_META_SHADER

2012-12-06 Thread Stefan Dösinger
Fixes clears in Wine on r200. NOTE: This is a candidate for stable release branches. --- src/mesa/drivers/common/meta.c | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/src/mesa/drivers/common/meta.c b/src/mesa/drivers/common/meta.c index d5e8af3..ad21fa8

[Mesa-dev] [PATCH 4/4] r300g: Remove an incorrect comment

2012-12-06 Thread Stefan Dösinger
This occurred because I started this patch by reverting another patch and forgot to remove it. --- src/gallium/drivers/r300/r300_screen.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/gallium/drivers/r300/r300_screen.c b/src/gallium/drivers/r300/r300_screen.c

[Mesa-dev] [PATCH 1/2] meta: Disable GL_FRAGMENT_SHADER_ATI in MESA_META_SHADER

2012-12-05 Thread Stefan Dösinger
From b882d9e08932198e243b9cbb534d01d547661f86 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Stefan=20D=C3=B6singer?= stefandoesin...@gmx.at Date: Mon, 3 Dec 2012 11:03:26 +0100 Subject: [PATCH 1/4] meta: Disable GL_FRAGMENT_SHADER_ATI in MESA_META_SHADER Fixes clears in Wine on r200. ---

[Mesa-dev] [PATCH 2/2] r200: Initialize swrast before setting limits

2012-12-05 Thread Stefan Dösinger
From f572545ee0e2e17322554f03409237e40c732d1a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Stefan=20D=C3=B6singer?= stefandoesin...@gmx.at Date: Mon, 3 Dec 2012 14:31:23 +0100 Subject: [PATCH 2/4] r200: Initialize swrast before setting limits Otherwise the driver announces 4096 vertex shader

Re: [Mesa-dev] [PATCH 2/2] r200: Initialize swrast before setting limits

2012-12-05 Thread Stefan Dösinger
On 12/05/12 15:23, Alex Deucher wrote: Also, should probably also make a note to apply this to the stable branches. While you are at it can you also check and see if radeon needs a similar fix? From the code it looks like it needs a similar fix. I don't have a pre-r250 card though so I can't