We haven't updated in a long time, so better do it now and again when
5.3 is released.
Signed-off-by: Tomeu Vizoso
---
src/gallium/drivers/panfrost/ci/debian-install.sh | 2 +-
src/gallium/drivers/panfrost/ci/gitlab-ci.yml | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git
Instead of running it with the Wayland platform, which introduces
unwanted dependencies and complexity.
Makes tests run 30% faster, as well.
Signed-off-by: Tomeu Vizoso
---
.../drivers/panfrost/ci/create-rootfs.sh | 2 +-
.../drivers/panfrost/ci/debian-install.sh | 35
So we can better correlate different results to versions of the runner.
Signed-off-by: Tomeu Vizoso
---
src/gallium/drivers/panfrost/ci/debian-install.sh | 8 +---
src/gallium/drivers/panfrost/ci/gitlab-ci.yml | 2 +-
2 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/src
Sometimes LAVA jobs will timeout due to transient issues, and the Gitlab
job will fail in that case. Increase the timeouts to reduce the
likeliness of that happening and reduce false positives.
Signed-off-by: Tomeu Vizoso
---
src/gallium/drivers/panfrost/ci/lava-deqp.yml.jinja2 | 4 ++--
1 file
Now that Volt supports armhf, build again images and submit to LAVA for
RK3288.
Signed-off-by: Tomeu Vizoso
---
.../drivers/panfrost/ci/debian-install.sh | 10 ++--
.../drivers/panfrost/ci/deqp-runner.sh| 3 ++
src/gallium/drivers/panfrost/ci/gitlab-ci.yml | 53
So repositories don't need to be specially configured with a token to
access LAVA, store this token in a bind volume for a special runner.
Signed-off-by: Tomeu Vizoso
---
src/gallium/drivers/panfrost/ci/gitlab-ci.yml | 10 +-
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git
On Fri, 6 Sep 2019 at 03:23, Rob Clark wrote:
>
> On Wed, Sep 4, 2019 at 1:42 PM Eric Anholt wrote:
> >
> > If you haven't seen this MR:
> >
> > https://gitlab.freedesktop.org/mesa/mesa/merge_requests/1632
> >
> > I feel ready to enable CI of freedreno on Mesa MRs. There are some docs
> > here:
Now that Volt supports armhf, build again images and submit to LAVA for
RK3288.
Signed-off-by: Tomeu Vizoso
---
.../drivers/panfrost/ci/debian-install.sh | 10 ++--
.../drivers/panfrost/ci/deqp-runner.sh| 3 ++
src/gallium/drivers/panfrost/ci/gitlab-ci.yml | 53
Some functionality has been added to deqp-volt to only print
regressions, so update our version of it and use the new options.
Signed-off-by: Tomeu Vizoso
---
src/gallium/drivers/panfrost/ci/deqp-runner.sh | 9 ++---
src/gallium/drivers/panfrost/ci/gitlab-ci.yml | 2 +-
2 files changed, 7
On 8/21/19 7:48 PM, Alyssa Rosenzweig wrote:
Otherwise, there is too much noise to see what's going on.
I'm afraid this doesn't improve things much, as you can see below:
https://gitlab.freedesktop.org/tomeu/mesa/-/jobs/524402
Jakob has kindly offered to add this weekend a mode that prints
are
hitting a few more failures in tests that previously were being skipped.
The time to run the tests decreases from around 8 minutes to 1:45
minutes, allowing for extending coverage without increasing CI times too
much.
Signed-off-by: Tomeu Vizoso
---
.../drivers/panfrost/ci/create-rootfs.sh
To help make sure we are running tests in the ideal number of threads,
print load stats to make obvious when there's a problem with
utilization.
This will be specially useful when we run tests on a wider variety of
devices.
Signed-off-by: Tomeu Vizoso
---
src/gallium/drivers/panfrost/ci/lava
There's lots of locking changes going into the Panfrost kernel driver,
so better be prepared.
Signed-off-by: Tomeu Vizoso
---
src/gallium/drivers/panfrost/ci/arm64.config | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/src/gallium/drivers/panfrost/ci/arm64.config
b
Some runners may be configured such that the qemu binary might not be
available by the time we need to start running commands within the
chroot.
So make sure that it's there to avoid suprising problems in that case.
Signed-off-by: Tomeu Vizoso
---
src/gallium/drivers/panfrost/ci/debian
A number of things can go wrong when building the rootfs from within a
non-native chroot, so make sure to print the bootstrap.log so we can
tell what's going on.
Signed-off-by: Tomeu Vizoso
---
src/gallium/drivers/panfrost/ci/debian-install.sh | 3 +++
1 file changed, 3 insertions(+)
diff
Both patches look good to me.
Reviewed-by: Tomeu Vizoso
Thanks!
Tomeu
On Fri, 9 Aug 2019 at 21:53, Rob Herring wrote:
>
> The kernel now supports madvise ioctl to indicate which BOs can be freed
> when there is memory pressure. Mark BOs purgeable when they are in the
> BO cache.
On Thu, 8 Aug 2019 at 16:50, Rob Herring wrote:
>
> On Wed, Aug 7, 2019 at 5:47 PM Alyssa Rosenzweig
> wrote:
> >
> > > This is using the
> > > untranslated flags, but I think it should be the 'translated_flags' as
> > > those are the ones changing the allocation.
> >
> > It's a little more
On Thu, 8 Aug 2019 at 16:19, Rob Herring wrote:
>
> On Wed, Aug 7, 2019 at 11:23 PM Tomeu Vizoso
> wrote:
> >
> > On Thu, 8 Aug 2019 at 00:47, Rob Herring wrote:
> > >
> > > On Wed, Aug 7, 2019 at 2:37 AM Tomeu Vizoso
> > > wrote:
>
On Thu, 8 Aug 2019 at 00:52, Rob Herring wrote:
>
> On Wed, Aug 7, 2019 at 2:37 AM Tomeu Vizoso
> wrote:
> >
> > Signed-off-by: Tomeu Vizoso
> > Reviewed-by: Alyssa Rosenzweig
> > ---
> > src/gallium/drivers/panfrost/pan_drm.c | 10 +-
> >
On Thu, 8 Aug 2019 at 00:47, Rob Herring wrote:
>
> On Wed, Aug 7, 2019 at 2:37 AM Tomeu Vizoso
> wrote:
> >
> > Instead of all shaders being stored in a single BO, have each shader in
> > its own.
> >
> > This removes the need for a 16MB allocation
Signed-off-by: Tomeu Vizoso
Reviewed-by: Alyssa Rosenzweig
---
src/gallium/drivers/panfrost/pan_drm.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/gallium/drivers/panfrost/pan_drm.c
b/src/gallium/drivers/panfrost/pan_drm.c
index 71eda2d1e328..36a6b975680a
).
v2: - Store compiled blend shaders in a malloc'ed buffer, to avoid
reading from GPU-accessible memory when patching (Alyssa).
- Free struct panfrost_blend_shader (Alyssa).
- Give the job a reference to regular shaders when emitting
(Alyssa).
Signed-off-by: Tomeu Vizoso
---
src
.
Signed-off-by: Tomeu Vizoso
Reviewed-by: Alyssa Rosenzweig
---
src/gallium/drivers/panfrost/pan_drm.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/src/gallium/drivers/panfrost/pan_drm.c
b/src/gallium/drivers/panfrost/pan_drm.c
index 6d1e0c08d33d..71eda2d1e328 100644
--- a/src
Some hash functions (eg. key_u64_hash) will attempt to dereference the
key, causing an invalid access when passed DELETED_KEY_VALUE (0x1) or
FREED_KEY_VALUE (0x0).
To avoid this problem, stuff the fake keys into a hash_key_u64 struct
and pass the pointer to it instead.
Signed-off-by: Tomeu
Unless a BO has the EXECUTABLE flag, mark it as NOEXEC.
v2: - Rework version detection (Alyssa).
Signed-off-by: Tomeu Vizoso
---
include/drm-uapi/panfrost_drm.h | 27 +++
src/gallium/drivers/panfrost/pan_drm.c| 6 -
src/gallium/drivers/panfrost
On Tue, 6 Aug 2019 at 16:58, Alyssa Rosenzweig wrote:
>
> > Android should be fine, as they use it in their own code.
>
> Hmm, still uncomfortable, but tentative R-b I guess :/
>
> I just.. don't like relying on glibc specific behaviour. Even if bionic
> implements it too, I mean... what
These tests have been fixed by:
b514f411837b ("glcpp: use pre-expansion line number for __LINE__")
Signed-off-by: Tomeu Vizoso
---
src/gallium/drivers/panfrost/ci/expected-failures.txt | 2 --
1 file changed, 2 deletions(-)
diff --git a/src/gallium/drivers/panfrost/ci/expected-failu
>
> On Mon, Aug 05, 2019 at 05:18:36PM +0200, Tomeu Vizoso wrote:
> > Signed-off-by: Tomeu Vizoso
> > ---
> > src/gallium/drivers/panfrost/pan_drm.c | 10 +-
> > 1 file changed, 5 insertions(+), 5 deletions(-)
> >
> > diff --git a/src/gallium/drive
On Mon, 5 Aug 2019 at 19:06, Alyssa Rosenzweig wrote:
>
> > +if (screen->kernel_version >= 1) {
>
> Maybe have some #defines for kernel versions instead of magic numbers?
> Also, maybe make it clear that this is a minor version -- what does
> happen if we bump the major version at some
On Mon, 5 Aug 2019 at 19:01, Alyssa Rosenzweig wrote:
>
> > +for (unsigned c = 0; c < 4; ++c) {
> > +struct panfrost_blend_rt *rt = >rt[c];
> > +_mesa_hash_table_u64_clear(rt->shaders,
> > panfrost_delete_blend_shader);
> > +}
>
> What's the
n patch 5, otherwise the
GPU would try to execute a shader in a memory region marked as not
executable.
Will be sending a v2 with Caio's suggestion.
Cheers,
Tomeu
> On Mon, Aug 05, 2019 at 05:18:32PM +0200, Tomeu Vizoso wrote:
> > Some hash functions (eg. key_u64_hash) will attempt to deref
Signed-off-by: Tomeu Vizoso
---
src/gallium/drivers/panfrost/pan_drm.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/gallium/drivers/panfrost/pan_drm.c
b/src/gallium/drivers/panfrost/pan_drm.c
index 122bc5f3db36..46cceb808919 100644
--- a/src/gallium/drivers
).
Signed-off-by: Tomeu Vizoso
---
src/gallium/drivers/panfrost/pan_allocate.h | 2 +
src/gallium/drivers/panfrost/pan_assemble.c | 5 ++-
src/gallium/drivers/panfrost/pan_blend.h | 11 --
src/gallium/drivers/panfrost/pan_blend_cso.c | 39 ++-
.../drivers/panfrost
Unless a BO has the EXECUTABLE flag, mark it as NOEXEC.
Signed-off-by: Tomeu Vizoso
---
include/drm-uapi/panfrost_drm.h | 27 +++
src/gallium/drivers/panfrost/pan_drm.c| 7 +-
src/gallium/drivers/panfrost/pan_screen.c | 12 ++
src/gallium/drivers
.
Signed-off-by: Tomeu Vizoso
---
src/gallium/drivers/panfrost/pan_drm.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/src/gallium/drivers/panfrost/pan_drm.c
b/src/gallium/drivers/panfrost/pan_drm.c
index a3f35aed4d0f..122bc5f3db36 100644
--- a/src/gallium/drivers
Some hash functions (eg. key_u64_hash) will attempt to dereference the
key, causing an invalid access when passed DELETED_KEY_VALUE (0x1) or
FREED_KEY_VALUE (0x0).
The entry.hash field isn't needed by the delete_function, so just stop
populating it.
Signed-off-by: Tomeu Vizoso
Cc: Samuel
Signed-off-by: Tomeu Vizoso
---
src/gallium/drivers/panfrost/ci/debian-install.sh | 4 ++--
src/gallium/drivers/panfrost/ci/gitlab-ci.yml | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/gallium/drivers/panfrost/ci/debian-install.sh
b/src/gallium/drivers/panfrost
Fixes this assertion:
../mesa/src/panfrost/midgard/midgard_schedule.c:507:schedule_block: Assertion
`ins == __next && "use _safe iterator"' failed.
Trace/breakpoint trap
Signed-off-by: Tomeu Vizoso
---
src/panfrost/midgard/midgard_schedule.c | 2 +-
1 file changed, 1 insert
In the mali_single_framebuffer descriptor.
Signed-off-by: Tomeu Vizoso
v2: Remove unwanted chunks
---
src/gallium/drivers/panfrost/pan_context.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/gallium/drivers/panfrost/pan_context.c
b/src/gallium/drivers/panfrost
In the mali_single_framebuffer descriptor.
Signed-off-by: Tomeu Vizoso
---
src/gallium/drivers/panfrost/pan_context.c | 12
src/gallium/drivers/panfrost/pan_tiler.c | 12
src/gallium/drivers/panfrost/pan_tiler.h | 6 --
3 files changed, 20 insertions(+), 10
Patches 8 to 11 look good to me:
Reviewed-by: Tomeu Vizoso
Thanks,
Tomeu
On 7/10/19 3:24 PM, Alyssa Rosenzweig wrote:
A lot of the pan_screen.c code was cargoculted from other drivers. The
upshot is that we return true for a lot of PIPE_CAPs that we don't
actually support, resulting in us
This was stale code that was causing a SIGSEGV when using SFBD, as we
stopped creating the corresponding BO.
Signed-off-by: Tomeu Vizoso
---
src/gallium/drivers/panfrost/pan_context.h | 1 -
src/gallium/drivers/panfrost/pan_sfbd.c| 8 ++--
2 files changed, 6 insertions(+), 3 deletions
This was stale code that was causing a SIGSEGV when using SFBD, as we
stopped creating the corresponding BO.
Signed-off-by: Tomeu Vizoso
---
src/gallium/drivers/panfrost/pan_context.h | 1 -
src/gallium/drivers/panfrost/pan_sfbd.c| 6 --
2 files changed, 4 insertions(+), 3 deletions
On Thu, 4 Jul 2019 at 10:05, Tomeu Vizoso wrote:
>
> Implement query_dmabuf_modifiers and resource_create_with_modifiers so
> Wayland clients can share AFBC buffers with the compositor.
>
> For now this is guarded behind the PAN_MESA_DEBUG=modifiers env var
> because implementi
it.
Signed-off-by: Tomeu Vizoso
---
src/gallium/drivers/panfrost/pan_drm.c | 1 +
src/gallium/drivers/panfrost/pan_resource.c | 74 ++---
src/gallium/drivers/panfrost/pan_screen.c | 37 +++
src/gallium/drivers/panfrost/pan_util.h | 7 ++
4 files changed, 108
is done with it.
Signed-off-by: Tomeu Vizoso
---
src/gallium/drivers/panfrost/pan_allocate.h | 2 +-
src/gallium/drivers/panfrost/pan_drm.c | 46 +++--
src/gallium/drivers/panfrost/pan_resource.c | 20 -
src/gallium/drivers/panfrost/pan_screen.h | 6 +++
4 files
In preparation for using AFBC for BOs that could be scanned out (though
they are likely to be only shared with the compositor for now), use the
buffer allocation UABI of the GPU driver, as dumb buffers cannot be
allocated for AFBC.
Signed-off-by: Tomeu Vizoso
---
src/gallium/drivers/panfrost
In that case, ctx->pipe_framebuffer.cbufs[0] can be NULL.
Signed-off-by: Tomeu Vizoso
Cc: Boris Brezillon
Fixes: 5375d009be18 ("panfrost: Pass referenced BOs to the SUBMIT ioctls")
---
src/gallium/drivers/panfrost/pan_drm.c | 10 ++
1 file changed, 6 insertions(+), 4 delet
On Tue, 2 Jul 2019 at 17:02, Boris Brezillon
wrote:
>
> On Tue, 2 Jul 2019 16:54:22 +0200
> Tomeu Vizoso wrote:
>
> > On Tue, 2 Jul 2019 at 15:24, Boris Brezillon
> > wrote:
> > >
> > > There's no point duplicating the code, and it will help us sim
On Tue, 2 Jul 2019 at 15:24, Boris Brezillon
wrote:
>
> There's no point duplicating the code, and it will help us simplify
> the bo_handles[] filling logic in panfrost_drm_submit_job().
Looks good but, could we drop panfrost_memory completely? Other
drivers seem to do fine wthout such a thing.
and some
> of what I'm proposing here might be irrelevant or might have to be
> ported on top of other changes (which is fine). Let me know if that's
> the case.
Looks great to me, will be a pleasure to rebase my modifiers work on
top of this.
Reviewed-by: Tomeu Vizoso
Thanks,
Tomeu
On Tue, 2 Jul 2019 at 15:24, Boris Brezillon
wrote:
>
> Let's keep a clear split between ioctl wrappers and the rest of the
> driver. All the import BO function need is a dmabuf FD and the screen
> object, and the export one should only take care of generating a dmabuf
> FD out of a BO object.
Besides the leak, I think I preferred the open-coded version, which is
incidentally what all other drivers I've seen do. The modifiers work
is going to massively change this code anyway.
But I'm not against it, so
Reviewed-by: Tomeu Vizoso
Cheers,
Tomeu
On Tue, 2 Jul 2019 at 15:24, Boris
Rendering to AFBC was broken, as the HW will complaint loudly if we pass
a tagged pointer in bifrost_render_target.
Signed-off-by: Tomeu Vizoso
Fixes: 3609b50a6443 ("panfrost: Merge AFBC slab with BO backing")
---
src/gallium/drivers/panfrost/pan_context.c | 8 +++-
src/galli
As there's lots of them and Gitlab struggles rendering logs with so many
lines.
Signed-off-by: Tomeu Vizoso
---
src/gallium/drivers/panfrost/ci/debian-install.sh | 2 +-
src/gallium/drivers/panfrost/ci/gitlab-ci.yml | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src
These changes will make sure we get the right image from the container
registry.
Signed-off-by: Tomeu Vizoso
---
src/gallium/drivers/panfrost/ci/gitlab-ci.yml | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/gallium/drivers/panfrost/ci/gitlab-ci.yml
b/src
Panfrost has grown and doesn't leak as much as before.
Signed-off-by: Tomeu Vizoso
---
src/gallium/drivers/panfrost/ci/deqp-runner.sh | 9 ++---
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/src/gallium/drivers/panfrost/ci/deqp-runner.sh
b/src/gallium/drivers/panfrost/ci
ora
> + * © Copyright2019 Collabora, Ltd.
Patch looks good to me, but please add the space missing above.
Reviewed-by: Tomeu Vizoso
Thanks,
Tomeu
> *
> * Permission is hereby granted, free of charge, to any person obtaining a
> * copy of this software and associated document
When the fault_pointer field in the header is set, we can get some idea
of which descriptor the HW isn't happy with if we know their addresses.
Signed-off-by: Tomeu Vizoso
---
.../drivers/panfrost/pandecode/decode.c | 24 +--
1 file changed, 11 insertions(+), 13 deletions
Then we can get some information back about any exception that might
have happened.
Signed-off-by: Tomeu Vizoso
---
src/gallium/drivers/panfrost/pan_drm.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/src/gallium/drivers/panfrost/pan_drm.c
b/src/gallium/drivers
Arm's kernel driver mentions how to decode this field, which makes a bit
clearer what had happened.
Signed-off-by: Tomeu Vizoso
---
src/gallium/drivers/panfrost/pandecode/decode.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/src/gallium/drivers/panfrost/pandecode
Signed-off-by: Tomeu Vizoso
---
src/gallium/drivers/panfrost/pandecode/decode.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/gallium/drivers/panfrost/pandecode/decode.c
b/src/gallium/drivers/panfrost/pandecode/decode.c
index 7f58ad033669..d468e10140b7 100644
On Mon, 24 Jun 2019 at 12:00, Rohan Garg wrote:
>
> > I think assertions should be limited to the most basic of sanity checks,
> > and the other asserts replaced by proper error handling.
>
> So, should I leave it as is and let us hit assertions that we fix?
Sorry, can you rephrase?
Thanks,
On 6/21/19 3:05 PM, Alyssa Rosenzweig wrote:
Very nice, this will fix a few tests.
Ah, of course :)
Good riddance!
To be fair, a lot of that just got moved in with panfrost_job.. :)
Can we remove now the has_draws arg?
Maybe? The has_draws arg controls a lot of things beyond just,
if (dep_1 == node_n_1) {
+BITSET_SET(edge_removal_1, node_m);
+dep_1 = 0;
+} else if (dep_2 == node_n_1) {
+BITSET_SET(edge_removal_2, node_m);
+dep_2 = 0;
+} else {
+/* This node has no relevant dependencies */
+continue;
+}
+
+/* Are there edges left? If not, add us to S */
+bool has_edges = dep_1 || dep_2;
+
+if (!has_edges)
+BITSET_SET(no_incoming, node_m);
+}
+}
+
+}
This is excelent work, thanks!
Reviewed-by: Tomeu Vizoso
Regards,
Tomeu
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Without this fix, LAVA isn't parsing crashes as failed tests, because
the shell logging is interspersed within the fake deqp output.
Signed-off-by: Tomeu Vizoso
---
src/gallium/drivers/panfrost/ci/deqp-runner.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/gallium
On 6/21/19 12:23 PM, Rohan Garg wrote:
Hey
Good stuff, but isn't this change making us hit assertions?
Hm, I thought it only enabled debugging symbols. Do you have a recommendation
on how to enable debug symbols but not enabling assertions?
I think assertions should be limited to the most
On 6/20/19 6:33 PM, Rohan Garg wrote:
Not sure I understand how this works. Isn't this going to cause
unnecessary container builds?
And, why cannot developers just add whatever they want to DEBIAN_TAG
to that end?
This will spin a container for each branch, yes, though I think that is
how it
These tests have been fixed recently.
Signed-off-by: Tomeu Vizoso
---
.../drivers/panfrost/ci/expected-failures.txt | 54 ---
1 file changed, 54 deletions(-)
diff --git a/src/gallium/drivers/panfrost/ci/expected-failures.txt
b/src/gallium/drivers/panfrost/ci/expected
On Thu, 20 Jun 2019 at 16:56, Alyssa Rosenzweig
wrote:
>
> > Isn't enough with ctx->blitter->running ?
>
> What if we're legitimately blitting something?
Forgot about that.
Reviewed-by: Tomeu Vizoso
Thanks!
Tomeu
___
mesa-dev
On 6/20/19 4:18 PM, Alyssa Rosenzweig wrote:
Looking at the scissor, we can discard some tiles. We specifially don't
care about the scissor on the wallpaper, since that's a no-op if the
entire tile is culled.
Signed-off-by: Alyssa Rosenzweig
---
src/gallium/drivers/panfrost/pan_context.c |
On Thu, 20 Jun 2019 at 15:59, Rohan Garg wrote:
>
> This enables developers to add packages to the container
> when working on their own branches by creating
> a container tag which features the branch name.
Not sure I understand how this works. Isn't this going to cause
unnecessary container
Good commit, but the "what" should be in the subject line and the
"why" in the body.
With that change:
Reviewed-by: Tomeu Vizoso
Thanks,
Tomeu
On Thu, 20 Jun 2019 at 15:59, Rohan Garg wrote:
>
> Change to /artifacts in order to potentially fix
> debootstrap fa
On Thu, 20 Jun 2019 at 15:59, Rohan Garg wrote:
>
> ---
> src/gallium/drivers/panfrost/ci/create-rootfs.sh | 2 +-
> src/gallium/drivers/panfrost/ci/deqp-runner.sh | 6 ++
> src/gallium/drivers/panfrost/ci/gitlab-ci.yml| 4 ++--
>
Right now we are doing it at a moment when we don't have all the
information we need.
Signed-off-by: Tomeu Vizoso
Suggested-by: Alyssa Rosenzweig
Cc: Rohan Garg
Fixes: bfca21b622df ("panfrost: Figure out job requirements in pan_job.c")
---
src/gallium/drivers/panfrost/pan_con
On 6/20/19 3:28 PM, Alyssa Rosenzweig wrote:
NAK. There's a patch for this I pushed to your repo which should fix
these regressions (they were legitimate bugs that had nothing to do with
autovectorization and would have cropped up anyhow).
You mean this commit?
Signed-off-by: Tomeu Vizoso
---
src/gallium/drivers/panfrost/pan_job.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/gallium/drivers/panfrost/pan_job.c
b/src/gallium/drivers/panfrost/pan_job.c
index 14efa71fb055..ecc0ac7be8e1 100644
--- a/src/gallium/drivers/panfrost
Signed-off-by: Tomeu Vizoso
---
.../drivers/panfrost/midgard/compiler.h | 2 +
.../panfrost/midgard/midgard_compile.c| 13 +-
.../panfrost/midgard/midgard_compile.h| 17 ++-
.../drivers/panfrost/midgard/midgard_ra.c | 116 ++
.../panfrost/midgard
Signed-off-by: Tomeu Vizoso
---
src/gallium/drivers/panfrost/pan_context.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/src/gallium/drivers/panfrost/pan_context.c
b/src/gallium/drivers/panfrost/pan_context.c
index 7c0ba679dd91..78976facda3d 100644
--- a/src/gallium
Hi,
we often OOM when trying to run test suites as the leaks quickly
accumulate.
With these patches things get much better.
Thanks,
Tomeu
Tomeu Vizoso (3):
panfrost: Move ra_regs to the screen context
panfrost: Release transient pools
panfrost: Allocate panfrost_job in panfrost_context
These tests are failing at times, blacklist for now:
dEQP-GLES2.functional.fbo.render.shared_colorbuffer_clear.tex2d_rgba
dEQP-GLES2.functional.fbo.render.shared_colorbuffer_clear.tex2d_rgb
dEQP-GLES2.functional.shaders.matrix.mul.dynamic_highp_mat4_vec4_vertex
Signed-off-by: Tomeu Vizoso
This reverts commit bfca21b622dfd2fcfe32494339aea9061070c7e5.
---
src/gallium/drivers/panfrost/pan_context.c | 8
src/gallium/drivers/panfrost/pan_job.c | 12
src/gallium/drivers/panfrost/pan_job.h | 4
3 files changed, 8 insertions(+), 16 deletions(-)
diff
This reverts commit 9402970751ca04c4d6edb3a0441a4063a975295c.
---
src/gallium/drivers/panfrost/midgard/midgard_compile.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/gallium/drivers/panfrost/midgard/midgard_compile.c
Hi,
the two commits reverted introduced some regressions and don't have an
obvious fix, so I propose to revert them while we fix them properly.
I also add some tests to the ignore list because they pass and fail
randomly.
Thanks,
Tomeu
Tomeu Vizoso (3):
Revert "panfrost/midgard: E
On Wed, 19 Jun 2019 at 07:44, Tomeu Vizoso wrote:
>
> On Tue, 18 Jun 2019 at 17:00, Alyssa Rosenzweig
> wrote:
> >
> > Now that sRGB formats are supported for both rendering and sampling,
> > advertise support.
> >
> > Signed-off-by: Alyssa Rosenzweig
>
On Tue, 18 Jun 2019 at 17:00, Alyssa Rosenzweig
wrote:
>
> Now that sRGB formats are supported for both rendering and sampling,
> advertise support.
>
> Signed-off-by: Alyssa Rosenzweig
Hi there,
this patch seems to have caused the following regressions:
Hi there,
this patch seems to have caused the following regressions:
+dEQP-GLES2.functional.shaders.conversions.vector_combine.bvec2_float_to_bvec3_fragment
+dEQP-GLES2.functional.shaders.conversions.vector_combine.float_bool_to_bvec2_fragment
We have some serious leaks, so plug some and also move to ralloc to
limit the lifetime of some objects to that of their parent.
Lots more such work to do.
Signed-off-by: Tomeu Vizoso
---
src/gallium/drivers/panfrost/pan_context.c | 24 +++--
src/gallium/drivers/panfrost/pan_drm.c
On Tue, 18 Jun 2019 at 15:19, Alyssa Rosenzweig
wrote:
>
> Not sure what would have fixed any of these but sure, A-b, I won't say
> no to fixed tests ^_^
>
> What about the fragment_ops.scissor.* tests?
Don't know, what about them? They seem to pass.
Cheers,
Tomeu
Alyssa fixed some failing tests last night.
Signed-off-by: Tomeu Vizoso
---
.../drivers/panfrost/ci/expected-failures.txt | 15 ---
1 file changed, 15 deletions(-)
diff --git a/src/gallium/drivers/panfrost/ci/expected-failures.txt
b/src/gallium/drivers/panfrost/ci/expected
We hadn't updated the kernel header after the driver got into mainline.
Signed-off-by: Tomeu Vizoso
---
include/drm-uapi/panfrost_drm.h| 6 --
src/gallium/drivers/panfrost/pan_drm.c | 2 +-
2 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/include/drm-uapi
Some tests got fixed since the last update, but also some regressions
crept in.
To keep the CI green, add the regressions to the expected failures.
Signed-off-by: Tomeu Vizoso
---
.../drivers/panfrost/ci/expected-failures.txt | 98 +--
1 file changed, 5 insertions(+), 93
These are tests that regressed in RK3288 but still pass on RK3399.
So we still have a CI we can rely on, add them to the flip-flop list for
now.
Signed-off-by: Tomeu Vizoso
---
src/gallium/drivers/panfrost/ci/gitlab-ci.yml | 51 ++-
1 file changed, 50 insertions(+), 1 deletion
Any ideas on why these two changes get kmscube working on T720?
Signed-off-by: Tomeu Vizoso
---
src/gallium/drivers/panfrost/pan_context.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/src/gallium/drivers/panfrost/pan_context.c
b/src/gallium/drivers/panfrost
Rosenzweig
Looks good too me!
Reviewed-by: Tomeu Vizoso
Thanks,
Tomeu
> ---
> src/gallium/drivers/panfrost/pan_context.c | 22 +++---
> 1 file changed, 15 insertions(+), 7 deletions(-)
>
> diff --git a/src/gallium/drivers/panfrost/pan_context.c
> b/src/ga
On Fri, 7 Jun 2019 at 09:51, Eduardo Lima Mitev wrote:
>
> On 5/20/19 11:33 AM, Tomeu Vizoso wrote:
> > Signed-off-by: Tomeu Vizoso
> > ---
> > src/gallium/drivers/panfrost/ci/Dockerfile | 7 +++
> > 1 file changed, 3 insertions(+), 4 deletions(-)
> >
Use the infrastructure in wayland/ci-templates to build the container
images.
This prevents from getting into some situations in which the images
wouldn't be rebuilt, and allows us to share some infrastructure with
other projects in freedesktop.org.
Signed-off-by: Tomeu Vizoso
Suggested
On 6/6/19 6:10 PM, Michel Dänzer wrote:
On 2019-05-20 11:33 a.m., Tomeu Vizoso wrote:
Jump over the container stage if we haven't changed any of the files
that involved in building the container images.
This saves 1-2 minutes in each run and helps conserve resources.
Signed-off-by: Tomeu
The compiler configuration was hardened to fail on format warnings and
things stopped building.
Fixes: c9c1e2610647 ("mesa: prevent common string formatting security issues")
Signed-off-by: Tomeu Vizoso
---
src/gallium/drivers/panfrost/bifrost/disassemble.c | 2 +-
1 file changed, 1
On Tue, 28 May 2019 at 08:17, Tomeu Vizoso wrote:
>
> On 5/26/19 1:51 AM, Alyssa Rosenzweig wrote:
> > The mesa/st flips the viewport, so we respect that rather than
> > trying to flip the framebuffer itself and ignoring the viewport and
> > using a messy heuristic.
>
1 - 100 of 214 matches
Mail list logo
