https://bugs.freedesktop.org/show_bug.cgi?id=109929
Adam Jackson changed:
What|Removed |Added
Resolution|--- |FIXED
Status|NEW
https://bugs.freedesktop.org/show_bug.cgi?id=109929
--- Comment #22 from Timur Kristóf ---
The problem has been fixed in MR 1799:
https://gitlab.freedesktop.org/mesa/mesa/merge_requests/1799/
TTN no longer depends on libglsl. I think this bug can be closed now unless
anyone has any objections?
https://bugs.freedesktop.org/show_bug.cgi?id=109929
--- Comment #21 from Timur Kristóf ---
The issue is not really autotools specific. Even though meson is able to build
it, ideally TTN shouldn't need to use GL(SL), as Michel said above.
--
You are receiving this mail because:
You are the QA
https://bugs.freedesktop.org/show_bug.cgi?id=109929
--- Comment #20 from Juan A. Suarez ---
Autotools has been removed in Mesa 19.1.0.
Should we close this?
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the
https://bugs.freedesktop.org/show_bug.cgi?id=109929
--- Comment #19 from Jan Vesely ---
(In reply to Eric Engestrom from comment #18)
> (In reply to Jan Vesely from comment #17)
> > Ideally, meson would use '-Wl,--no-undefined' by default to catch this kind
> > of errors.
>
> It does; it's
https://bugs.freedesktop.org/show_bug.cgi?id=109929
--- Comment #18 from Eric Engestrom ---
(In reply to Jan Vesely from comment #17)
> Ideally, meson would use '-Wl,--no-undefined' by default to catch this kind
> of errors.
It does; it's controlled by `b_lundef`, which is `true` by default,
https://bugs.freedesktop.org/show_bug.cgi?id=109929
--- Comment #17 from Jan Vesely ---
(In reply to Timur Kristóf from comment #16)
> Can you guys try this branch?
>
> https://gitlab.freedesktop.org/Venemo/mesa/commits/nir-lower-samplers
>
> It seems to work for me at least on radeonsi, but I
https://bugs.freedesktop.org/show_bug.cgi?id=109929
--- Comment #16 from Timur Kristóf ---
Can you guys try this branch?
https://gitlab.freedesktop.org/Venemo/mesa/commits/nir-lower-samplers
It seems to work for me at least on radeonsi, but I haven't been able to test
it thoroughly yet.
--
https://bugs.freedesktop.org/show_bug.cgi?id=109929
--- Comment #15 from Timur Kristóf ---
As discussed with Jan and Jason on IRC, the proper solution will be to attempt
to refactor gl_nir_lower_samplers and gl_nir_lower_samplers_as_deref in a way
that separates the GLSL specific code. Then
https://bugs.freedesktop.org/show_bug.cgi?id=109929
--- Comment #14 from Michel Dänzer ---
(In reply to Jan Vesely from comment #13)
> anyone feel free to correct me, my work on CL was mostly outside mesa, so I
> might have misunderstood the state_tracker/pipe_driver split.
You're spot on. Code
https://bugs.freedesktop.org/show_bug.cgi?id=109929
--- Comment #13 from Jan Vesely ---
(In reply to Timur Kristóf from comment #12)
> Jan, the commit you linked adds a dependency from the gallium auxiliary lib
> to the glsl compiler. This is required by tgsi_to_nir for calling
>
https://bugs.freedesktop.org/show_bug.cgi?id=109929
--- Comment #12 from Timur Kristóf ---
Jan, the commit you linked adds a dependency from the gallium auxiliary lib to
the glsl compiler. This is required by tgsi_to_nir for calling
gl_nir_lower_samplers and gl_nir_lower_samplers_as_deref,
https://bugs.freedesktop.org/show_bug.cgi?id=109929
--- Comment #11 from Jan Vesely ---
(In reply to Vinson Lee from comment #10)
> The diff fixes the entire build for me.
>
> diff --git a/src/gallium/targets/pipe-loader/Makefile.am
> b/src/gallium/targets/pipe-loader/Makefile.am
> index
https://bugs.freedesktop.org/show_bug.cgi?id=109929
Jan Vesely changed:
What|Removed |Added
CC||jv356@scarletmail.rutgers.e
https://bugs.freedesktop.org/show_bug.cgi?id=109929
--- Comment #10 from Vinson Lee ---
The diff fixes the entire build for me.
diff --git a/src/gallium/targets/pipe-loader/Makefile.am
b/src/gallium/targets/pipe-loader/Makefile.am
index db515e3097b7..807a100a7d0a 100644
---
https://bugs.freedesktop.org/show_bug.cgi?id=109929
--- Comment #9 from Vinson Lee ---
(In reply to Timur Kristóf from comment #8)
> Can you tell me how to build libxatracker.la? Ie. what autotools command to
> use? Thanks!
./autogen.sh --enable-autotools --enable-opencl --with-dri-drivers=
https://bugs.freedesktop.org/show_bug.cgi?id=109929
--- Comment #8 from Timur Kristóf ---
Can you tell me how to build libxatracker.la? Ie. what autotools command to
use? Thanks!
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the
https://bugs.freedesktop.org/show_bug.cgi?id=109929
--- Comment #7 from Vinson Lee ---
There is a similar build error with libxatracker.la.
CXXLDlibxatracker.la
/usr/bin/ld:
../../../../src/gallium/auxiliary/.libs/libgallium.a(tgsi_to_nir.o): in
function `ttn_finalize_nir':
https://bugs.freedesktop.org/show_bug.cgi?id=109929
--- Comment #6 from Vinson Lee ---
(In reply to Timur Kristóf from comment #5)
> Okay, I think I got it. Can you please try with this patch:
> https://gitlab.freedesktop.org/Venemo/mesa/commit/
> c1efd5b26d210b017118d29ecf16aaaeeb34a420
>
> It
https://bugs.freedesktop.org/show_bug.cgi?id=109929
--- Comment #5 from Timur Kristóf ---
Okay, I think I got it. Can you please try with this patch:
https://gitlab.freedesktop.org/Venemo/mesa/commit/c1efd5b26d210b017118d29ecf16aaaeeb34a420
It gets rid of the problem for me.
--
You are
https://bugs.freedesktop.org/show_bug.cgi?id=109929
Michel Dänzer changed:
What|Removed |Added
Attachment #143635|text/x-log |text/plain
mime type|
https://bugs.freedesktop.org/show_bug.cgi?id=109929
--- Comment #4 from Timur Kristóf ---
Created attachment 143635
--> https://bugs.freedesktop.org/attachment.cgi?id=143635=edit
build log of mesa with e582e761b7f49d1c0b100289b62442e6295cefef
I tried with the commit before that,
https://bugs.freedesktop.org/show_bug.cgi?id=109929
Vinson Lee changed:
What|Removed |Added
Keywords||bisected
CC|
https://bugs.freedesktop.org/show_bug.cgi?id=109929
--- Comment #2 from Timur Kristóf ---
Vinson, can you give me some more details on how to reproduce this, such as
what commands you used to configure and build mesa?
I tried the following:
./autogen.sh --enable-autotools --enable-debug
https://bugs.freedesktop.org/show_bug.cgi?id=109929
--- Comment #1 from Timur Kristóf ---
This is my mistake, forgot to add the autotools equivalent when I wrote the
meson part:
https://bugs.freedesktop.org/show_bug.cgi?id=109929
Bug ID: 109929
Summary: tgsi_to_nir.c:2111: undefined reference to
`gl_nir_lower_samplers_as_deref'
Product: Mesa
Version: git
Hardware: x86-64 (AMD64)
26 matches
Mail list logo