Re: [Mesa-dev] [Mesa-stable] [PATCH] mesa: implement missing glGet(GL_RGBA_SIGNED_COMPONENTS_EXT) query

2014-01-09 Thread Carl Worth
Ian Romanick i...@freedesktop.org writes: There are fixes on top of this fix. When they get picked over to the stable branch, I think at least this and the one from 050961.html should get squashed together. http://lists.freedesktop.org/archives/mesa-dev/2014-January/050961.html

Re: [Mesa-dev] [Mesa-stable] [PATCH] mesa: implement missing glGet(GL_RGBA_SIGNED_COMPONENTS_EXT) query

2014-01-07 Thread Ian Romanick
There are fixes on top of this fix. When they get picked over to the stable branch, I think at least this and the one from 050961.html should get squashed together. http://lists.freedesktop.org/archives/mesa-dev/2014-January/050961.html

Re: [Mesa-dev] [Mesa-stable] [PATCH] mesa: implement missing glGet(GL_RGBA_SIGNED_COMPONENTS_EXT) query

2014-01-06 Thread Chris Forbes
On Tue, Jan 7, 2014 at 8:57 AM, Brian Paul bri...@vmware.com wrote: --- a/src/mesa/main/get_hash_params.py +++ b/src/mesa/main/get_hash_params.py @@ -611,6 +611,9 @@ descriptor=[ # GL_ARB_fragment_program [ FRAGMENT_PROGRAM_ARB, CONTEXT_BOOL(FragmentProgram.Enabled),

Re: [Mesa-dev] [Mesa-stable] [PATCH] mesa: implement missing glGet(GL_RGBA_SIGNED_COMPONENTS_EXT) query

2014-01-06 Thread Brian Paul
On 01/06/2014 01:01 PM, Chris Forbes wrote: On Tue, Jan 7, 2014 at 8:57 AM, Brian Paul bri...@vmware.com wrote: --- a/src/mesa/main/get_hash_params.py +++ b/src/mesa/main/get_hash_params.py @@ -611,6 +611,9 @@ descriptor=[ # GL_ARB_fragment_program [ FRAGMENT_PROGRAM_ARB,

Re: [Mesa-dev] [Mesa-stable] [PATCH] mesa: implement missing glGet(GL_RGBA_SIGNED_COMPONENTS_EXT) query

2014-01-06 Thread Chris Forbes
+ const GLboolean signd = +rb ? _mesa_is_format_signed(rb- Format) : GL_FALSE; + v-value_int_4[0] = + v-value_int_4[1] = + v-value_int_4[2] = + v-value_int_4[3] = signd; Might have gone with something like is_signed rather than dropping a letter

Re: [Mesa-dev] [Mesa-stable] [PATCH] mesa: implement missing glGet(GL_RGBA_SIGNED_COMPONENTS_EXT) query

2014-01-06 Thread Brian Paul
On 01/06/2014 01:21 PM, Chris Forbes wrote: + const GLboolean signd = +rb ? _mesa_is_format_signed(rb- Format) : GL_FALSE; + v-value_int_4[0] = + v-value_int_4[1] = + v-value_int_4[2] = + v-value_int_4[3] = signd; Might have gone with