Re: [Mesa-dev] [PATCH] HUD: Add support for block I/O, network I/O and lmsensor stats

2016-09-30 Thread Steven Toth
Hello Emil, >> +AC_ARG_ENABLE([gallium-extra-hud], >> +[AS_HELP_STRING([--enable-gallium-extra-hud], >> +[enable HUD block/NIC I/O HUD stats support >> @<:@default=disabled@:>@])], >> +[enable_gallium_extra_hud="$enableval"], >> +[enable_gallium_extra_hud=no]) > Looking at

Re: [Mesa-dev] [PATCH] HUD: Add support for block I/O, network I/O and lmsensor stats

2016-09-30 Thread Emil Velikov
Hi Steven, On 28 September 2016 at 19:58, Steven Toth wrote: > V8: Feedback based on peer review > convert if block into a switch > Constify some func args > > V7: Increase precision when measuring lmsensors volts > Flatten patch series. > > V6: Feedback based

[Mesa-dev] [PATCH] HUD: Add support for block I/O, network I/O and lmsensor stats

2016-09-28 Thread Steven Toth
V8: Feedback based on peer review convert if block into a switch Constify some func args V7: Increase precision when measuring lmsensors volts Flatten patch series. V6: Feedback based on peer review Simplify sensor initialization (arg passing). Constify some func args V5:

Re: [Mesa-dev] [PATCH] HUD: Add support for block I/O, network I/O and lmsensor stats

2016-09-28 Thread Steven Toth
> I found just a few more nit-picks below. With those fixed (if appropriate), > Reviewed-by: Brian Paul > > I'll push the patch for you then. All reasonable requests, thank you. I'll take care of these later this afternoon. -- Steven Toth - Kernel Labs

Re: [Mesa-dev] [PATCH] HUD: Add support for block I/O, network I/O and lmsensor stats

2016-09-28 Thread Brian Paul
I found just a few more nit-picks below. With those fixed (if appropriate), Reviewed-by: Brian Paul I'll push the patch for you then. -Brian On 09/28/2016 07:21 AM, Steven Toth wrote: V7: Increase precision when measuring lmsensors volts Flatten patch series. V6:

[Mesa-dev] [PATCH] HUD: Add support for block I/O, network I/O and lmsensor stats

2016-09-28 Thread Steven Toth
V7: Increase precision when measuring lmsensors volts Flatten patch series. V6: Feedback based on peer review Simplify sensor initialization (arg passing). Constify some func args V5: Feedback based on peer review Convert sprintf to snprintf Convert char * to const char *

Re: [Mesa-dev] [PATCH] HUD: Add support for block I/O, network I/O and lmsensor stats

2016-09-13 Thread Steven Toth
>> Hopefully, this explanation helps support my justification for the >> additional HUD stats. >> > Thanks for the comprehensive explanation Steven. Completely forgot > about the fun one can have with embedded devices :-P :) > As you gave the Freescale IMX as an example, would that mean you'll

Re: [Mesa-dev] [PATCH] HUD: Add support for block I/O, network I/O and lmsensor stats

2016-09-13 Thread Emil Velikov
On 13 September 2016 at 13:07, Steven Toth wrote: >> On 12 September 2016 at 19:33, Steven Toth wrote: >>> Three new features: >>> 1. Disk/block I/O device read/write stats MB/ps. >>> 2. Network Interface RX/TX transfer statistics as a percentage >>>

Re: [Mesa-dev] [PATCH] HUD: Add support for block I/O, network I/O and lmsensor stats

2016-09-13 Thread Steven Toth
> On 12 September 2016 at 19:33, Steven Toth wrote: >> Three new features: >> 1. Disk/block I/O device read/write stats MB/ps. >> 2. Network Interface RX/TX transfer statistics as a percentage >>of the overall NIC speed. >> 3. lmsensor power, voltage and temperature

Re: [Mesa-dev] [PATCH] HUD: Add support for block I/O, network I/O and lmsensor stats

2016-09-13 Thread Emil Velikov
Hi Steven, On 12 September 2016 at 19:33, Steven Toth wrote: > Three new features: > 1. Disk/block I/O device read/write stats MB/ps. > 2. Network Interface RX/TX transfer statistics as a percentage >of the overall NIC speed. > 3. lmsensor power, voltage and temperature

Re: [Mesa-dev] [PATCH] HUD: Add support for block I/O, network I/O and lmsensor stats

2016-09-13 Thread Steven Toth
> well it won't for your GPU, it is currently Fermi (GF100+) only. > > I guess I will add support for it later then > ok. I'm not too familiar with the nvidia architectures. Should a GTX 950 card on a 4.6+ kernel expose those newer features? -- Steven Toth - Kernel Labs

Re: [Mesa-dev] [PATCH] HUD: Add support for block I/O, network I/O and lmsensor stats

2016-09-13 Thread Karol Herbst
well it won't for your GPU, it is currently Fermi (GF100+) only. I guess I will add support for it later then 2016-09-13 13:14 GMT+02:00 Steven Toth : >>> Ahh, my nouveau card must be too old then. I only get temperature from >>> it. I have a 6yo(?) 8800 GTS. That being

Re: [Mesa-dev] [PATCH] HUD: Add support for block I/O, network I/O and lmsensor stats

2016-09-13 Thread Steven Toth
>> Ahh, my nouveau card must be too old then. I only get temperature from >> it. I have a 6yo(?) 8800 GTS. That being said - it services the >> console well enough. >> >> nouveau-pci-0100 >> Adapter: PCI adapter >> temp1:+57.0°C (high = +95.0°C, hyst = +3.0°C) >>

Re: [Mesa-dev] [PATCH] HUD: Add support for block I/O, network I/O and lmsensor stats

2016-09-12 Thread Karol Herbst
2016-09-13 0:15 GMT+02:00 Steven Toth : >> I think you expose Temperature, Voltage and Current. But Nouveau exposes >> Temperature, Voltage, Fan and Power through hwmon. >> >> Read the "power" section here for more info: >>

Re: [Mesa-dev] [PATCH] HUD: Add support for block I/O, network I/O and lmsensor stats

2016-09-12 Thread Steven Toth
> I think you expose Temperature, Voltage and Current. But Nouveau exposes > Temperature, Voltage, Fan and Power through hwmon. > > Read the "power" section here for more info: > https://www.kernel.org/doc/Documentation/hwmon/sysfs-interface Ahh, my nouveau card must be too old then. I only get

Re: [Mesa-dev] [PATCH] HUD: Add support for block I/O, network I/O and lmsensor stats

2016-09-12 Thread Karol Herbst
2016-09-12 23:20 GMT+02:00 Steven Toth : >> nice work regarding the lmsensor bits. But I think it makes sense to >> also wire the power things in, cause we actually expose them within >> nouveau. Others might want or actually do the same as well. > > Karol, thank you for your

Re: [Mesa-dev] [PATCH] HUD: Add support for block I/O, network I/O and lmsensor stats

2016-09-12 Thread Steven Toth
> Can you enclose all the unix-specific parts in #ifdef PIPE_OS_UNIX to allow > this to build for Windows? > > -Brian Brian, thank you for your feedback. Whoops! Yes, I'll take care of this. -- Steven Toth - Kernel Labs http://www.kernellabs.com +1.646.355.8490

Re: [Mesa-dev] [PATCH] HUD: Add support for block I/O, network I/O and lmsensor stats

2016-09-12 Thread Steven Toth
> nice work regarding the lmsensor bits. But I think it makes sense to > also wire the power things in, cause we actually expose them within > nouveau. Others might want or actually do the same as well. Karol, thank you for your feedback. I'm happy and willing to adapt to any changes

Re: [Mesa-dev] [PATCH] HUD: Add support for block I/O, network I/O and lmsensor stats

2016-09-12 Thread Brian Paul
Steven, Can you enclose all the unix-specific parts in #ifdef PIPE_OS_UNIX to allow this to build for Windows? -Brian On Mon, Sep 12, 2016 at 1:22 PM, Karol Herbst wrote: > Hey, > > nice work regarding the lmsensor bits. But I think it makes sense to > also wire the

Re: [Mesa-dev] [PATCH] HUD: Add support for block I/O, network I/O and lmsensor stats

2016-09-12 Thread Karol Herbst
Hey, nice work regarding the lmsensor bits. But I think it makes sense to also wire the power things in, cause we actually expose them within nouveau. Others might want or actually do the same as well. Many thanks 2016-09-12 20:33 GMT+02:00 Steven Toth : > Three new

[Mesa-dev] [PATCH] HUD: Add support for block I/O, network I/O and lmsensor stats

2016-09-12 Thread Steven Toth
Three new features: 1. Disk/block I/O device read/write stats MB/ps. 2. Network Interface RX/TX transfer statistics as a percentage of the overall NIC speed. 3. lmsensor power, voltage and temperature sensors. The lmsensor changes makes a dependency on libsensors so support so the change is