Re: [Mesa-dev] [PATCH] anv: FORMAT_FEATURE_TRANSFER_SRC/DST_BIT_KHR not used with VkFormatProperties.bufferFeatures

2017-06-21 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand On Wed, Jun 14, 2017 at 9:55 AM, Andres Gomez wrote: > VK_FORMAT_FEATURE_TRANSFER_[SRC|DST]_BIT_KHR is a flag value of the > VkFormatFeatureFlagBits enum that can only be hold and checked against > the linearTilingFeatures or

Re: [Mesa-dev] [PATCH] anv: FORMAT_FEATURE_TRANSFER_SRC/DST_BIT_KHR not used with VkFormatProperties.bufferFeatures

2017-06-15 Thread Andres Gomez
On Thu, 2017-06-15 at 01:13 +0100, Lionel Landwerlin wrote: > Out of curiosity, does this fix a test (maybe upcoming one)? Not really, but realized checking an upcoming test for vk-gl-cts. The test was failing on some conditions because of erroneously checking some FORMAT_FEATURE flags against

Re: [Mesa-dev] [PATCH] anv: FORMAT_FEATURE_TRANSFER_SRC/DST_BIT_KHR not used with VkFormatProperties.bufferFeatures

2017-06-14 Thread Lionel Landwerlin
Out of curiosity, does this fix a test (maybe upcoming one)? Otherwise sounds fair : Reviewed-by: Lionel Landwerlin Thanks! On 14/06/17 17:55, Andres Gomez wrote: VK_FORMAT_FEATURE_TRANSFER_[SRC|DST]_BIT_KHR is a flag value of the VkFormatFeatureFlagBits enum

[Mesa-dev] [PATCH] anv: FORMAT_FEATURE_TRANSFER_SRC/DST_BIT_KHR not used with VkFormatProperties.bufferFeatures

2017-06-14 Thread Andres Gomez
VK_FORMAT_FEATURE_TRANSFER_[SRC|DST]_BIT_KHR is a flag value of the VkFormatFeatureFlagBits enum that can only be hold and checked against the linearTilingFeatures or optimalTilingFeatures members of the VkFormatProperties struct but not the bufferFeatures member. From the VulkanĀ® 1.0.51, with