Re: [Mesa-dev] [PATCH] configure.ac: rework wayland-protocols handling

2017-07-23 Thread Andres Gomez
On Mon, 2017-07-24 at 01:27 +0300, Andres Gomez wrote: > This is: > > Reviewed-by: Andres Gomez Mmmm ... I hit the send button too quickly. Just wanted to mention that I share the same concerns than Daniel. Would it be up to me, I would not be adding the generated files in

Re: [Mesa-dev] [PATCH] configure.ac: rework wayland-protocols handling

2017-07-23 Thread Andres Gomez
This is: Reviewed-by: Andres Gomez On Fri, 2017-07-21 at 13:02 +0100, Emil Velikov wrote: > From: Emil Velikov > > At dist/distcheck time we need to ensure that all the files and their > respective dependencies are handled. > > At the moment

Re: [Mesa-dev] [PATCH] configure.ac: rework wayland-protocols handling

2017-07-21 Thread Daniel Stone
Hi, On 21 July 2017 at 15:00, Emil Velikov wrote: > On 21 July 2017 at 14:19, Daniel Stone wrote: >> I don't mind relaxing it, but OTOH wayland-scanner is already there >> when you install libwayland, and wayland-protocols is just a pile of >>

Re: [Mesa-dev] [PATCH] configure.ac: rework wayland-protocols handling

2017-07-21 Thread Emil Velikov
On 21 July 2017 at 14:19, Daniel Stone wrote: > Hi Emil, > > On 21 July 2017 at 14:13, Emil Velikov wrote: >> On 21 July 2017 at 13:28, Daniel Stone wrote: >>> Why do we need to dist these files? We enforce that wayland

Re: [Mesa-dev] [PATCH] configure.ac: rework wayland-protocols handling

2017-07-21 Thread Daniel Stone
Hi Emil, On 21 July 2017 at 14:13, Emil Velikov wrote: > On 21 July 2017 at 13:28, Daniel Stone wrote: >> Why do we need to dist these files? We enforce that wayland (providing >> wayland-scanner) and wayland-protocols (providing the XML) are

Re: [Mesa-dev] [PATCH] configure.ac: rework wayland-protocols handling

2017-07-21 Thread Emil Velikov
On 21 July 2017 at 13:28, Daniel Stone wrote: > Hi Emil, > > On 21 July 2017 at 13:02, Emil Velikov wrote: >> At dist/distcheck time we need to ensure that all the files and their >> respective dependencies are handled. >> >> At the moment we'll

Re: [Mesa-dev] [PATCH] configure.ac: rework wayland-protocols handling

2017-07-21 Thread Daniel Stone
Hi Emil, On 21 July 2017 at 13:02, Emil Velikov wrote: > At dist/distcheck time we need to ensure that all the files and their > respective dependencies are handled. > > At the moment we'll bail out as the linux-dmabuf rules are guarded in a > conditional. Move them

[Mesa-dev] [PATCH] configure.ac: rework wayland-protocols handling

2017-07-21 Thread Emil Velikov
From: Emil Velikov At dist/distcheck time we need to ensure that all the files and their respective dependencies are handled. At the moment we'll bail out as the linux-dmabuf rules are guarded in a conditional. Move them outside of it and drop the sources from

Re: [Mesa-dev] [PATCH] configure.ac: rework wayland-protocols handling

2017-07-20 Thread Emil Velikov
On 20 July 2017 at 18:27, Emil Velikov wrote: > From: Emil Velikov > > At dist/distcheck time we need to ensure that all the files and their > respective dependencies are handled. > > At the moment we'll bail out as the linux-dmabuf rules are

[Mesa-dev] [PATCH] configure.ac: rework wayland-protocols handling

2017-07-20 Thread Emil Velikov
From: Emil Velikov At dist/distcheck time we need to ensure that all the files and their respective dependencies are handled. At the moment we'll bail out as the linux-dmabuf rules are guarded in a conditional. Move them outside of it and drop the sources from