Re: [Mesa-dev] [PATCH] egl/android: fix error in droid_add_configs_for_visuals()

2016-10-17 Thread Eric Engestrom
On Monday, 2016-10-17 12:04:00 +0100, Emil Velikov wrote: > On 17 October 2016 at 07:04, Tapani Pälli wrote: > > This was some kind of leftover in commit acd35c8 and format_count > > array variable (declared in outer scope) should be used instead. > > > Which brings the

Re: [Mesa-dev] [PATCH] egl/android: fix error in droid_add_configs_for_visuals()

2016-10-17 Thread Emil Velikov
On 17 October 2016 at 07:04, Tapani Pälli wrote: > This was some kind of leftover in commit acd35c8 and format_count > array variable (declared in outer scope) should be used instead. > Which brings the question - do we want to enable -Wshadow for the C sources. The C++

Re: [Mesa-dev] [PATCH] egl/android: fix error in droid_add_configs_for_visuals()

2016-10-17 Thread Eric Engestrom
On Monday, 2016-10-17 09:04:56 +0300, Tapani Pälli wrote: > This was some kind of leftover in commit acd35c8 and format_count > array variable (declared in outer scope) should be used instead. > > Signed-off-by: Tapani Pälli Fixes: acd35c8758dc73240903 ("egl/android:

[Mesa-dev] [PATCH] egl/android: fix error in droid_add_configs_for_visuals()

2016-10-17 Thread Tapani Pälli
This was some kind of leftover in commit acd35c8 and format_count array variable (declared in outer scope) should be used instead. Signed-off-by: Tapani Pälli --- src/egl/drivers/dri2/platform_android.c | 2 -- 1 file changed, 2 deletions(-) diff --git