Re: [Mesa-dev] [PATCH] egl/dri2: Implement swapInterval fallback in a conformant way (v2)

2017-09-27 Thread Tomasz Figa
On Wed, Sep 27, 2017 at 11:06 PM, Emil Velikov wrote: > On 25 September 2017 at 08:25, Tomasz Figa wrote: > >> Gentle ping. :) >> > > I forgot that you don't have commit access. Can you please apply for one? Yep, I have it on my list, sorry for

Re: [Mesa-dev] [PATCH] egl/dri2: Implement swapInterval fallback in a conformant way (v2)

2017-09-27 Thread Emil Velikov
On 25 September 2017 at 08:25, Tomasz Figa wrote: > Gentle ping. :) > I forgot that you don't have commit access. Can you please apply for one? Thanks Emil [1] https://www.freedesktop.org/wiki/AccountRequests/ [2] https://bugs.freedesktop.org/show_bug.cgi?id=99601

Re: [Mesa-dev] [PATCH] egl/dri2: Implement swapInterval fallback in a conformant way (v2)

2017-09-25 Thread Tomasz Figa
On Fri, Aug 11, 2017 at 1:31 PM, Tomasz Figa wrote: > On Fri, Aug 11, 2017 at 2:29 AM, Emil Velikov > wrote: >> On 10 August 2017 at 14:59, Tomasz Figa wrote: >>> dri2_fallback_swap_interval() currently used to stub out swap

Re: [Mesa-dev] [PATCH] egl/dri2: Implement swapInterval fallback in a conformant way (v2)

2017-08-10 Thread Tomasz Figa
On Fri, Aug 11, 2017 at 2:29 AM, Emil Velikov wrote: > On 10 August 2017 at 14:59, Tomasz Figa wrote: >> dri2_fallback_swap_interval() currently used to stub out swap interval >> support in Android backend does nothing besides returning EGL_FALSE. >>

Re: [Mesa-dev] [PATCH] egl/dri2: Implement swapInterval fallback in a conformant way (v2)

2017-08-10 Thread Tapani Pälli
Reviewed-by: Tapani Pälli On 08/10/2017 04:59 PM, Tomasz Figa wrote: dri2_fallback_swap_interval() currently used to stub out swap interval support in Android backend does nothing besides returning EGL_FALSE. This causes at least one known application (Android Snapchat)

Re: [Mesa-dev] [PATCH] egl/dri2: Implement swapInterval fallback in a conformant way (v2)

2017-08-10 Thread Chad Versace
On Thu 10 Aug 2017, Tomasz Figa wrote: > dri2_fallback_swap_interval() currently used to stub out swap interval > support in Android backend does nothing besides returning EGL_FALSE. > This causes at least one known application (Android Snapchat) to fail > due to an unexpected error and my loose

Re: [Mesa-dev] [PATCH] egl/dri2: Implement swapInterval fallback in a conformant way (v2)

2017-08-10 Thread Emil Velikov
On 10 August 2017 at 14:59, Tomasz Figa wrote: > dri2_fallback_swap_interval() currently used to stub out swap interval > support in Android backend does nothing besides returning EGL_FALSE. > This causes at least one known application (Android Snapchat) to fail > due to an

Re: [Mesa-dev] [PATCH] egl/dri2: Implement swapInterval fallback in a conformant way

2017-08-10 Thread Emil Velikov
On 10 August 2017 at 13:51, Tomasz Figa wrote: > On Thu, Aug 10, 2017 at 9:40 PM, Eric Engestrom wrote: >> On 10 August 2017 06:43:45 BST, Tomasz Figa wrote: >>> dri2_fallback_swap_interval() currently used to stub out swap interval >>>

[Mesa-dev] [PATCH] egl/dri2: Implement swapInterval fallback in a conformant way (v2)

2017-08-10 Thread Tomasz Figa
dri2_fallback_swap_interval() currently used to stub out swap interval support in Android backend does nothing besides returning EGL_FALSE. This causes at least one known application (Android Snapchat) to fail due to an unexpected error and my loose interpretation of the EGL 1.5 specification

Re: [Mesa-dev] [PATCH] egl/dri2: Implement swapInterval fallback in a conformant way

2017-08-10 Thread Tomasz Figa
On Thu, Aug 10, 2017 at 9:40 PM, Eric Engestrom wrote: > On 10 August 2017 06:43:45 BST, Tomasz Figa wrote: >> dri2_fallback_swap_interval() currently used to stub out swap interval >> support in Android backend does nothing besides returning EGL_FALSE. >>

Re: [Mesa-dev] [PATCH] egl/dri2: Implement swapInterval fallback in a conformant way

2017-08-10 Thread Eric Engestrom
On 10 August 2017 06:43:45 BST, Tomasz Figa wrote: > dri2_fallback_swap_interval() currently used to stub out swap interval > support in Android backend does nothing besides returning EGL_FALSE. > This causes at least one known application (Android Snapchat) to fail > due to

Re: [Mesa-dev] [PATCH] egl/dri2: Implement swapInterval fallback in a conformant way

2017-08-10 Thread Tapani Pälli
I agree to the interpretation, it is stated that EGL_FALSE happens 'on failure' and there are 2 error cases specified for eglSwapInterval. It seems right to assume those are the only cases where it can fail (no current context or surface bound). Reviewed-by: Tapani Pälli

[Mesa-dev] [PATCH] egl/dri2: Implement swapInterval fallback in a conformant way

2017-08-09 Thread Tomasz Figa
dri2_fallback_swap_interval() currently used to stub out swap interval support in Android backend does nothing besides returning EGL_FALSE. This causes at least one known application (Android Snapchat) to fail due to an unexpected error and my loose interpretation of the EGL 1.5 specification