Re: [Mesa-dev] [PATCH] gallium/util: Allow pipe_resource_reference to be inlined again

2017-06-13 Thread Michel Dänzer
On 13/06/17 08:08 PM, Gustaw Smolarczyk wrote: > 2017-06-13 12:07 GMT+02:00 Michel Dänzer : >> On 13/06/17 06:51 PM, Timothy Arceri wrote: >>> On 13/06/17 19:22, Michel Dänzer wrote: From: Michel Dänzer It calling itself recursively

Re: [Mesa-dev] [PATCH] gallium/util: Allow pipe_resource_reference to be inlined again

2017-06-13 Thread Marek Olšák
On Tue, Jun 13, 2017 at 1:08 PM, Gustaw Smolarczyk wrote: > 2017-06-13 12:07 GMT+02:00 Michel Dänzer : >> On 13/06/17 06:51 PM, Timothy Arceri wrote: >>> On 13/06/17 19:22, Michel Dänzer wrote: From: Michel Dänzer

Re: [Mesa-dev] [PATCH] gallium/util: Allow pipe_resource_reference to be inlined again

2017-06-13 Thread Gustaw Smolarczyk
2017-06-13 12:07 GMT+02:00 Michel Dänzer : > On 13/06/17 06:51 PM, Timothy Arceri wrote: >> On 13/06/17 19:22, Michel Dänzer wrote: >>> From: Michel Dänzer >>> >>> It calling itself recursively prevented it from being inlined, resulting >>> in a copy

Re: [Mesa-dev] [PATCH] gallium/util: Allow pipe_resource_reference to be inlined again

2017-06-13 Thread Michel Dänzer
On 13/06/17 06:51 PM, Timothy Arceri wrote: > On 13/06/17 19:22, Michel Dänzer wrote: >> From: Michel Dänzer >> >> It calling itself recursively prevented it from being inlined, resulting >> in a copy being generated in every compilation unit referencing it. This >>

Re: [Mesa-dev] [PATCH] gallium/util: Allow pipe_resource_reference to be inlined again

2017-06-13 Thread Timothy Arceri
On 13/06/17 19:22, Michel Dänzer wrote: From: Michel Dänzer It calling itself recursively prevented it from being inlined, resulting in a copy being generated in every compilation unit referencing it. This bloated the text segment of the Gallium mega-driver *_dri.so by

Re: [Mesa-dev] [PATCH] gallium/util: Allow pipe_resource_reference to be inlined again

2017-06-13 Thread Samuel Pitoiset
How about adding a comment which explains why we need that? This might prevent someone to remove pipe_resource_next_reference() in the future because these two functions are *quite* similar. :) Other than, looks good to me. On 06/13/2017 11:22 AM, Michel Dänzer wrote: From: Michel Dänzer

[Mesa-dev] [PATCH] gallium/util: Allow pipe_resource_reference to be inlined again

2017-06-13 Thread Michel Dänzer
From: Michel Dänzer It calling itself recursively prevented it from being inlined, resulting in a copy being generated in every compilation unit referencing it. This bloated the text segment of the Gallium mega-driver *_dri.so by ~5%, and might also have impacted