Re: [Mesa-dev] [PATCH] gallivm: fix a missing argument to CreateAtomicCmpXchg

2019-08-02 Thread Neha Bhende
LGTM Reviewed-by: Neha Bhende Regards, Neha From: Charmaine Lee Sent: Thursday, August 1, 2019 3:56 PM To: mesa-dev@lists.freedesktop.org; Brian Paul; Neha Bhende; Roland Scheidegger; Jose Fonseca; airl...@redhat.com Cc: Charmaine Lee Subject: [PATCH]

Re: [Mesa-dev] [PATCH] gallivm: fix a missing argument to CreateAtomicCmpXchg

2019-08-02 Thread Jose Fonseca
Looks good to me. Reviewed-by: Jose Fonseca From: Charmaine Lee Sent: Thursday, August 1, 2019 23:56 To: mesa-dev@lists.freedesktop.org ; Brian Paul ; Neha Bhende ; Roland Scheidegger ; Jose Fonseca ; airl...@redhat.com Cc: Charmaine Lee Subject: [PATCH]

Re: [Mesa-dev] [PATCH] gallivm: fix a missing argument to CreateAtomicCmpXchg

2019-08-01 Thread Dave Airlie
On Fri, 2 Aug 2019 at 13:08, Brian Paul wrote: > > On 08/01/2019 04:56 PM, Charmaine Lee wrote: > > This patch fixes a missing argument to CreateAtomicCmpXchg for older > > version of LLVM. Does this pass CI? please try a pull request. We've got a bug open

Re: [Mesa-dev] [PATCH] gallivm: fix a missing argument to CreateAtomicCmpXchg

2019-08-01 Thread Brian Paul
On 08/01/2019 04:56 PM, Charmaine Lee wrote: This patch fixes a missing argument to CreateAtomicCmpXchg for older version of LLVM. --- src/gallium/auxiliary/gallivm/lp_bld_misc.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/auxiliary/gallivm/lp_bld_misc.cpp

[Mesa-dev] [PATCH] gallivm: fix a missing argument to CreateAtomicCmpXchg

2019-08-01 Thread Charmaine Lee
This patch fixes a missing argument to CreateAtomicCmpXchg for older version of LLVM. --- src/gallium/auxiliary/gallivm/lp_bld_misc.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/auxiliary/gallivm/lp_bld_misc.cpp b/src/gallium/auxiliary/gallivm/lp_bld_misc.cpp index