Re: [Mesa-dev] [PATCH] glsl/linker: Link all out vars from a shader objects on a single stage

2018-08-29 Thread Timothy Arceri
On 30/08/18 08:16, Andres Gomez wrote: Vadym, should we also include this in the stable queues ? Yes. It should be fine to add this to stable. Thanks. On Mon, 2018-08-27 at 15:20 +0300, Vadym Shovkoplias wrote: From: "vadym.shovkoplias" During intra stage linking some out variables can

Re: [Mesa-dev] [PATCH] glsl/linker: Link all out vars from a shader objects on a single stage

2018-08-29 Thread Andres Gomez
Vadym, should we also include this in the stable queues ? On Mon, 2018-08-27 at 15:20 +0300, Vadym Shovkoplias wrote: > From: "vadym.shovkoplias" > > During intra stage linking some out variables can be dropped because > it is not used in a shader with the main function. But these out vars >

Re: [Mesa-dev] [PATCH] glsl/linker: Link all out vars from a shader objects on a single stage

2018-08-29 Thread Timothy Arceri
On 28/08/18 17:34, Vadim Shovkoplias wrote: Hi Timothy, Thanks for the review! Space was removed. Can you please push this patch since I haven't got write permissions ? For some reason the space was still there but I removed it and pushed. Thanks for the patch. Regards, Vadym вт, 28

Re: [Mesa-dev] [PATCH] glsl/linker: Link all out vars from a shader objects on a single stage

2018-08-28 Thread Vadim Shovkoplias
Hi Timothy, Thanks for the review! Space was removed. Can you please push this patch since I haven't got write permissions ? Regards, Vadym вт, 28 авг. 2018 г. в 10:32, Vadym Shovkoplias : > From: "vadym.shovkoplias" > > During intra stage linking some out variables can be dropped because >

[Mesa-dev] [PATCH] glsl/linker: Link all out vars from a shader objects on a single stage

2018-08-28 Thread Vadym Shovkoplias
From: "vadym.shovkoplias" During intra stage linking some out variables can be dropped because it is not used in a shader with the main function. But these out vars can be referenced on later stages which can lead to further linking errors. Bugzilla:

Re: [Mesa-dev] [PATCH] glsl/linker: Link all out vars from a shader objects on a single stage

2018-08-27 Thread Timothy Arceri
On 27/08/18 22:20, Vadym Shovkoplias wrote: From: "vadym.shovkoplias" During intra stage linking some out variables can be dropped because it is not used in a shader with the main function. But these out vars can be referenced on later stages which can lead to further linking errors.

[Mesa-dev] [PATCH] glsl/linker: Link all out vars from a shader objects on a single stage

2018-08-27 Thread Vadym Shovkoplias
From: "vadym.shovkoplias" During intra stage linking some out variables can be dropped because it is not used in a shader with the main function. But these out vars can be referenced on later stages which can lead to further linking errors. Bugzilla: