Re: [Mesa-dev] [PATCH] glsl: add missing explicit_image_format flag to has_layout()

2016-01-20 Thread Ian Romanick
On 01/19/2016 04:28 PM, Mark Janes wrote: > This patch fixes > arb_shader_image_load_store.compiler.declaration-format-qualifier-duplicate > tests. However, it regresses 17 other arb_shader_image_load_store other > tests with: Which tests? As Timothy says, the tests may be incorrect. Rules

Re: [Mesa-dev] [PATCH] glsl: add missing explicit_image_format flag to has_layout()

2016-01-20 Thread Timothy Arceri
On Wed, 2016-01-20 at 10:51 -0800, Ian Romanick wrote: > On 01/19/2016 04:28 PM, Mark Janes wrote: > > This patch fixes > > arb_shader_image_load_store.compiler.declaration-format-qualifier > > -duplicate > > tests. However, it regresses 17 other arb_shader_image_load_store > > other > > tests

[Mesa-dev] [PATCH] glsl: add missing explicit_image_format flag to has_layout()

2016-01-19 Thread Timothy Arceri
Fixes piglit regression after fixes to duplicate layout rules. Previously catching multiple layouts was relying on the code meant to catch duplicates within a single layout(...), this change triggers the rules for multiple layouts. Cc: Mark Janes ---

Re: [Mesa-dev] [PATCH] glsl: add missing explicit_image_format flag to has_layout()

2016-01-19 Thread Mark Janes
This patch fixes arb_shader_image_load_store.compiler.declaration-format-qualifier-duplicate tests. However, it regresses 17 other arb_shader_image_load_store other tests with: Failed to compile fragment shader: 0:20(1): error: storage qualifiers must come after precise, invariant,

Re: [Mesa-dev] [PATCH] glsl: add missing explicit_image_format flag to has_layout()

2016-01-19 Thread Timothy Arceri
On Tue, 2016-01-19 at 16:28 -0800, Mark Janes wrote: > This patch fixes > arb_shader_image_load_store.compiler.declaration-format-qualifier > -duplicate > tests. However, it regresses 17 other arb_shader_image_load_store > other > tests with: > > Failed to compile fragment shader: 0:20(1):

Re: [Mesa-dev] [PATCH] glsl: add missing explicit_image_format flag to has_layout()

2016-01-19 Thread Francisco Jerez
Timothy Arceri writes: > Fixes piglit regression after fixes to duplicate layout rules. > > Previously catching multiple layouts was relying on the code > meant to catch duplicates within a single layout(...), this > change triggers the rules for multiple layouts. >