Re: [Mesa-dev] [PATCH] glsl: fix heap-buffer-overflow

2017-01-31 Thread Eric Engestrom
On Monday, 2017-01-30 21:55:49 +0100, Bartosz Tomczyk wrote: > Found by ASAN. There is no need to add +1 to strlen, we have already add > +1 to str_end. The change is mathematically correct, but the commit message need rewording: The `end+1` skips the ']', whereas the `strlen+1` includes the

[Mesa-dev] [PATCH] glsl: fix heap-buffer-overflow

2017-01-30 Thread Bartosz Tomczyk
Found by ASAN. There is no need to add +1 to strlen, we have already add +1 to str_end. --- src/compiler/glsl/link_uniforms.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/glsl/link_uniforms.cpp b/src/compiler/glsl/link_uniforms.cpp index