Re: [Mesa-dev] [PATCH] glsl: gl_Max{Vertex, Fragment}UniformComponents exist in all desktop GL versions

2017-07-06 Thread Iago Toral
Yes, I think so, thanks Andres. Iago On Thu, 2017-07-06 at 16:45 +0300, Andres Gomez wrote: > It looks like we could want this into -stable (?) > > On Fri, 2017-06-16 at 12:05 +0200, Iago Toral Quiroga wrote: > > The current implementation assumed that these were replaced in GLSL > > >= 4.10 >

Re: [Mesa-dev] [PATCH] glsl: gl_Max{Vertex, Fragment}UniformComponents exist in all desktop GL versions

2017-07-06 Thread Andres Gomez
It looks like we could want this into -stable (?) On Fri, 2017-06-16 at 12:05 +0200, Iago Toral Quiroga wrote: > The current implementation assumed that these were replaced in GLSL >= 4.10 > by gl_Max{Vertex,Fragment}UniformVectors, however this is not true: both > built-ins should be produced

Re: [Mesa-dev] [PATCH] glsl: gl_Max{Vertex, Fragment}UniformComponents exist in all desktop GL versions

2017-06-19 Thread Nicolai Hähnle
Reviewed-by: Nicolai Hähnle On 16.06.2017 12:05, Iago Toral Quiroga wrote: The current implementation assumed that these were replaced in GLSL >= 4.10 by gl_Max{Vertex,Fragment}UniformVectors, however this is not true: both built-ins should be produced from GLSL 4.10

[Mesa-dev] [PATCH] glsl: gl_Max{Vertex, Fragment}UniformComponents exist in all desktop GL versions

2017-06-16 Thread Iago Toral Quiroga
The current implementation assumed that these were replaced in GLSL >= 4.10 by gl_Max{Vertex,Fragment}UniformVectors, however this is not true: both built-ins should be produced from GLSL 4.10 onwards. This was raised by new CTS tests that are in development. ---