Re: [Mesa-dev] [PATCH] i965/batch: don't ignore the 'brw_new_batch' call for a 'new batch'

2018-09-10 Thread andrey simiklit
Hello, Thanks for your reply. Please find my comments below: On Mon, Sep 10, 2018 at 2:45 PM Chris Wilson wrote: > Quoting andrey simiklit (2018-08-21 13:00:57) > > Hi all, > > > > The bug for this issue was created: > > https://bugs.freedesktop.org/show_bug.cgi?id=107626 > > What about

Re: [Mesa-dev] [PATCH] i965/batch: don't ignore the 'brw_new_batch' call for a 'new batch'

2018-09-10 Thread Chris Wilson
Quoting andrey simiklit (2018-08-21 13:00:57) > Hi all, > > The bug for this issue was created: > https://bugs.freedesktop.org/show_bug.cgi?id=107626 What about something like diff --git a/src/mesa/drivers/dri/i965/brw_draw.c b/src/mesa/drivers/dri/i965/brw_draw.c index

Re: [Mesa-dev] [PATCH] i965/batch: don't ignore the 'brw_new_batch' call for a 'new batch'

2018-09-07 Thread andrey simiklit
Hi all, Could somebody check it on CI to confirm that this patch do not add regressions or maybe even take a look at this patch. Regards, Andrii. On Mon, Aug 27, 2018 at 12:39 PM andrey simiklit wrote: > Hi all, > > It would be great if somebody look at this. > I guess that this issue can

Re: [Mesa-dev] [PATCH] i965/batch: don't ignore the 'brw_new_batch' call for a 'new batch'

2018-08-27 Thread andrey simiklit
Hi all, It would be great if somebody look at this. I guess that this issue can affect every place where we use 'intel_batchbuffer_save_state/intel_batchbuffer_reset_to_saved' but only when the 'brw_batch_has_aperture_space' function returns false several times in a row. Pay attention that the

Re: [Mesa-dev] [PATCH] i965/batch: don't ignore the 'brw_new_batch' call for a 'new batch'

2018-08-21 Thread andrey simiklit
Hi all, The bug for this issue was created: https://bugs.freedesktop.org/show_bug.cgi?id=107626 Regards, Andrii. On Mon, Aug 20, 2018 at 5:43 PM, wrote: > From: Andrii Simiklit > > If we restore the 'new batch' using 'intel_batchbuffer_reset_to_saved' > function we must restore the default

[Mesa-dev] [PATCH] i965/batch: don't ignore the 'brw_new_batch' call for a 'new batch'

2018-08-20 Thread asimiklit . work
From: Andrii Simiklit If we restore the 'new batch' using 'intel_batchbuffer_reset_to_saved' function we must restore the default state of the batch using 'brw_new_batch' function because the 'intel_batchbuffer_flush' function will not do it for the 'new batch' again. At least the following

[Mesa-dev] [PATCH] i965/batch: don't ignore the 'brw_new_batch' call for a 'new batch'

2018-08-20 Thread asimiklit . work
From: Andrii Simiklit If we restore the 'new batch' using 'intel_batchbuffer_reset_to_saved' function we must restore the default state of the batch using 'brw_new_batch' function because the 'intel_batchbuffer_flush' function will not do it for the 'new batch' again. At least the following