Re: [Mesa-dev] [PATCH] i965/blorp: Correct type of src_format in call to intel_miptree_texture_aux_usage

Pushed. On Mon, Aug 14, 2017 at 10:37 AM, Scott D Phillips < scott.d.phill...@intel.com> wrote: > Jason Ekstrand writes: > > > On Fri, Aug 11, 2017 at 10:36 AM, Scott D Phillips < > > scott.d.phill...@intel.com> wrote: > > > >> Jason Ekstrand writes:

Re: [Mesa-dev] [PATCH] i965/blorp: Correct type of src_format in call to intel_miptree_texture_aux_usage

Jason Ekstrand writes: > oof... Have you run this through Jenkins? It should be ok, but > it will be a functional change. It's a good change, but it is a > change. I ran the patch through jenkins, where the only problem it reported was a gpu hang on skl gt2 in:

Re: [Mesa-dev] [PATCH] i965/blorp: Correct type of src_format in call to intel_miptree_texture_aux_usage

Reviewed-by: Jordan Justen On 2017-08-09 15:52:30, Scott D Phillips wrote: > intel_miptree_texture_aux_usage() takes an isl_format, but we are > passing a mesa_format. clang warns: > > brw_blorp.c:305:52: warning: implicit conversion from enumeration > type

Re: [Mesa-dev] [PATCH] i965/blorp: Correct type of src_format in call to intel_miptree_texture_aux_usage

oof... Have you run this through Jenkins? It should be ok, but it will be a functional change. It's a good change, but it is a change. Also, this should probably get CCd to stable. --Jason On Wed, Aug 9, 2017 at 3:52 PM, Scott D Phillips wrote: >

[Mesa-dev] [PATCH] i965/blorp: Correct type of src_format in call to intel_miptree_texture_aux_usage

intel_miptree_texture_aux_usage() takes an isl_format, but we are passing a mesa_format. clang warns: brw_blorp.c:305:52: warning: implicit conversion from enumeration type 'mesa_format' to different enumeration type 'enum isl_format' [-Wenum-conversion]