Quoting Lionel Landwerlin (2018-09-04 01:07:12)
> Talking with Ken about this, it seems we might not actually coherent use
> GTT maps because those are just for buffer (which are allocated linear).
> GTT maps are only used with tiled buffers.
>
> So we most likely don't even need this patch.
>
Talking with Ken about this, it seems we might not actually coherent use
GTT maps because those are just for buffer (which are allocated linear).
GTT maps are only used with tiled buffers.
So we most likely don't even need this patch.
The code is confusing though.
-
Lionel
On 31/08/2018
On 31/08/2018 12:43, Chris Wilson wrote:
Quoting Lionel Landwerlin (2018-08-31 12:32:23)
On 31/08/2018 12:22, Chris Wilson wrote:
Quoting Lionel Landwerlin (2018-08-31 12:16:19)
We would need a fairly recent kernel (drm-tip?) to test this in CI.
Unpatched mesa, assumes all is fine.
Quoting Lionel Landwerlin (2018-08-31 12:32:23)
> On 31/08/2018 12:22, Chris Wilson wrote:
> > Quoting Lionel Landwerlin (2018-08-31 12:16:19)
> >> We would need a fairly recent kernel (drm-tip?) to test this in CI.
> > Unpatched mesa, assumes all is fine.
> > Post-patch mesa, assumes all is
On 31/08/2018 12:22, Chris Wilson wrote:
Quoting Lionel Landwerlin (2018-08-31 12:16:19)
We would need a fairly recent kernel (drm-tip?) to test this in CI.
Unpatched mesa, assumes all is fine.
Post-patch mesa, assumes all is broken.
So we can quickly see if anything actually fails if a
Quoting Lionel Landwerlin (2018-08-31 12:16:19)
> We would need a fairly recent kernel (drm-tip?) to test this in CI.
Unpatched mesa, assumes all is fine.
Post-patch mesa, assumes all is broken.
So we can quickly see if anything actually fails if a persistent GGTT
mmap is rejected. Which is the
We would need a fairly recent kernel (drm-tip?) to test this in CI.
I can't see any issue with this because we always have the meta path as
a fallback for tiled buffers.
Reviewed-by: Lionel Landwerlin
On 30/08/2018 16:22, Chris Wilson wrote:
On more recent HW, the indirect writes via the
On more recent HW, the indirect writes via the GGTT are internally
buffered presenting a nuisance to trying to use them for persistent
client maps. (We cannot guarantee that any write by the client will
then be visible to either the GPU or third parties in a timely manner,
leading to corruption.)
