Re: [Mesa-dev] [PATCH] main/shaderimage: image unit invalid if texture is incomplete, independently of the level

2016-08-03 Thread Alejandro Piñeiro
On 27/07/16 13:47, Alejandro Piñeiro wrote: > On 26/07/16 22:16, Francisco Jerez wrote: -- However that spec change would have the side effect of making the CTS test you're trying to fix non-compliant... >>> This would not be the first case of a CTS test that is not correct due >>> the

Re: [Mesa-dev] [PATCH] main/shaderimage: image unit invalid if texture is incomplete, independently of the level

2016-07-27 Thread Alejandro Piñeiro
On 26/07/16 22:16, Francisco Jerez wrote: > >>> -- However that spec change would have the side effect of making >>> the CTS test you're trying to fix non-compliant... >> This would not be the first case of a CTS test that is not correct due >> the complexities/ambiguities of the OpenGL spec. Or

Re: [Mesa-dev] [PATCH] main/shaderimage: image unit invalid if texture is incomplete, independently of the level

2016-07-26 Thread Francisco Jerez
Alejandro Piñeiro writes: > On 23/07/16 00:31, Francisco Jerez wrote: >> Alejandro Piñeiro writes: >> >>> Hi, >>> >>> On 15/07/16 22:46, Francisco Jerez wrote: Alejandro Piñeiro writes: > On 14/07/16 21:24,

Re: [Mesa-dev] [PATCH] main/shaderimage: image unit invalid if texture is incomplete, independently of the level

2016-07-26 Thread Alejandro Piñeiro
On 23/07/16 00:31, Francisco Jerez wrote: > Alejandro Piñeiro writes: > >> Hi, >> >> On 15/07/16 22:46, Francisco Jerez wrote: >>> Alejandro Piñeiro writes: >>> On 14/07/16 21:24, Francisco Jerez wrote: > Alejandro Piñeiro

Re: [Mesa-dev] [PATCH] main/shaderimage: image unit invalid if texture is incomplete, independently of the level

2016-07-26 Thread Alejandro Piñeiro
On 23/07/16 00:31, Francisco Jerez wrote: > Alejandro Piñeiro writes: > >> Hi, >> >> On 15/07/16 22:46, Francisco Jerez wrote: >>> Alejandro Piñeiro writes: >>> On 14/07/16 21:24, Francisco Jerez wrote: > Alejandro Piñeiro

Re: [Mesa-dev] [PATCH] main/shaderimage: image unit invalid if texture is incomplete, independently of the level

2016-07-22 Thread Francisco Jerez
Alejandro Piñeiro writes: > Hi, > > On 15/07/16 22:46, Francisco Jerez wrote: >> Alejandro Piñeiro writes: >> >>> On 14/07/16 21:24, Francisco Jerez wrote: Alejandro Piñeiro writes: > Without this commit, a image

Re: [Mesa-dev] [PATCH] main/shaderimage: image unit invalid if texture is incomplete, independently of the level

2016-07-22 Thread Alejandro Piñeiro
Ping. Also including Ian Romanick on the conversation, as right now the main question is about the spec. The thread is somewhat messy, so in order to be clear, this is the last patch I sent to the list (and the one Im proposing): https://patchwork.freedesktop.org/patch/98877/ On 18/07/16 14:44,

Re: [Mesa-dev] [PATCH] main/shaderimage: image unit invalid if texture is incomplete, independently of the level

2016-07-18 Thread Alejandro Piñeiro
Hi, On 15/07/16 22:46, Francisco Jerez wrote: > Alejandro Piñeiro writes: > >> On 14/07/16 21:24, Francisco Jerez wrote: >>> Alejandro Piñeiro writes: >>> Without this commit, a image is considered valid if the level of the texture bound to

Re: [Mesa-dev] [PATCH] main/shaderimage: image unit invalid if texture is incomplete, independently of the level

2016-07-15 Thread Francisco Jerez
Alejandro Piñeiro writes: > On 14/07/16 21:24, Francisco Jerez wrote: >> Alejandro Piñeiro writes: >> >>> Without this commit, a image is considered valid if the level of the >>> texture bound to the image is complete, something we can check as mesa

Re: [Mesa-dev] [PATCH] main/shaderimage: image unit invalid if texture is incomplete, independently of the level

2016-07-15 Thread Alejandro Piñeiro
On 14/07/16 21:24, Francisco Jerez wrote: > Alejandro Piñeiro writes: > >> Without this commit, a image is considered valid if the level of the >> texture bound to the image is complete, something we can check as mesa >> save independently if it is "base incomplete" of

Re: [Mesa-dev] [PATCH] main/shaderimage: image unit invalid if texture is incomplete, independently of the level

2016-07-14 Thread Francisco Jerez
Alejandro Piñeiro writes: > Without this commit, a image is considered valid if the level of the > texture bound to the image is complete, something we can check as mesa > save independently if it is "base incomplete" of "mipmap incomplete". > > But, from the OpenGL 4.3

[Mesa-dev] [PATCH] main/shaderimage: image unit invalid if texture is incomplete, independently of the level

2016-07-14 Thread Alejandro Piñeiro
Without this commit, a image is considered valid if the level of the texture bound to the image is complete, something we can check as mesa save independently if it is "base incomplete" of "mipmap incomplete". But, from the OpenGL 4.3 Core Specification, section 8.25 ("Texture Image Loads and